Re: [PATCH] cxl: Delete an unnecessary check before the function call "kfree"

2015-11-08 Thread Andrew Donnellan
tected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Thanks for picking this up - will remember in my future patches. Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan Software Engineer, Oz

Re: [RFC] powerpc: Enable UBSAN support

2015-12-14 Thread Andrew Donnellan
; I tested this patch as found in linux-next, along with the SANITIZE_ALL typo fix, on a big-endian BML system, with gcc 5.2.1. It successfully picked up one of the shift input issues that Daniel found, so therefore... Tested-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -

Re: [PATCH v3 1/2] cxl: Add mechanism for delivering AFU driver specific events

2016-03-10 Thread Andrew Donnellan
On 10/03/16 12:18, Ian Munsie wrote: On a related matter, we should send a patch to remove some of the leftover config options that were added to smooth the merging of cxlflash in the first place (CXL_KERNEL_API, CXL_EEH). I'm happy to do that after this series is merged. -- Andrew Donnellan

Re: [PATCH 2/2] powerpc/drivers: Add driver for operator panel on FSP machines

2016-04-10 Thread Andrew Donnellan
it's only FSP machines (the Power Systems LC models are not). Hmm, perhaps also mention that in the Kconfig description too? -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH] arch: powerpc: mm: fixed spelling error.

2016-03-22 Thread Andrew Donnellan
ot;hugepage". We also use "huge page", but "hugepage" is more common. Therefore I wouldn't call it a spelling error, just an internal term :) Andrew -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH v3 1/2] cxl: Add mechanism for delivering AFU driver specific events

2016-03-08 Thread Andrew Donnellan
eneric cxl driver will never use this event, the ABI of the event is up to each individual AFU driver. Signed-off-by: Ian Munsie <imun...@au1.ibm.com> Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan Software Engineer, OzLabs andrew.don

Re: [PATCH v3 2/2] cxl: add set/get private data to context struct

2016-03-08 Thread Andrew Donnellan
easily get back to any private data structures they may use. Signed-off-by: Michael Neuling <mi...@neuling.org> Signed-off-by: Ian Munsie <imun...@au1.ibm.com> Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Looks good to me. Reviewed-by: Andrew Donnellan <a

Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure

2016-05-20 Thread Andrew Donnellan
on the plugin infrastructure so that arch maintainers are aware of this? Upon further testing it does seem we've got header issues as well as hitting a segfault on 4.7.0. Looking into it further... -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure

2016-05-18 Thread Andrew Donnellan
On 18/05/16 20:33, Emese Revfy wrote: Did you test the plugins with all gcc versions (4.5-6)? No, I tested with 4.8 and 5.2 as those are the toolchains I have on hand - I'll try to test with the rest of 4.5 - 6.1. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1

Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure

2016-05-19 Thread Andrew Donnellan
don't care about <=4.4. However if Andrew's only tested on little endian, then that select should be guarded with an "if CPU_LITTLE_ENDIAN". And to build LE you need gcc >= 4.9. I'm going to give BE a test too just to be sure. -- Andrew Donnellan OzLabs, ADL Canber

Re: [kernel-hardening] [PATCH v8 3/4] Add Cyclomatic complexity GCC plugin

2016-05-18 Thread Andrew Donnellan
exit nodes). + If this plugin is intended primarily as a demonstration it's probably worth mentioning this in the Kconfig description. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [kernel-hardening] [PATCH v8 2/4] GCC plugin infrastructure

2016-05-18 Thread Andrew Donnellan
ed-off-by: Emese Revfy <re.em...@gmail.com> I've done some basic sanity testing on powerpc with the cyclomatic complexity plugin (with LE native + cross-compilers) and it seems to work with the patch below. Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> diff --git a/arch

Re: [PATCH] cxl: Delete an unnecessary check before the function call "of_node_put"

2016-07-27 Thread Andrew Donnellan
On 20/07/16 23:38, Julia Lawall wrote: I don't think that the call should be there at all. The loop only exits when afu_np is NULL. Furthermore, the loop should not be written as a for loop, but rather with for_each_child_of_node. Will send a patch to fix both issues shortly. -- Andrew

Re: [PATCH -next] cxl: Use for_each_compatible_node() macro

2016-07-12 Thread Andrew Donnellan
On 12/07/16 21:30, weiyj...@163.com wrote: From: Wei Yongjun <yongjun_...@trendmicro.com.cn> Use for_each_compatible_node() macro instead of open coding it. Generated by Coccinelle. Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn> Reviewed-by: Andrew Donnellan &l

[PATCH] cxl: replace loop with for_each_child_of_node(), remove unneeded of_node_put()

2016-07-28 Thread Andrew Donnellan
net> Reported-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- Checked the of_node_put() with Fred, he thinks it was probably just left over from an earlier private version of the code and we can just get rid of it. --- drivers

Re: checkkconfigsymbols.py: add --no-color option

2016-07-05 Thread Andrew Donnellan
cases of redirecting to a file or piping to another script, without requiring the user to pass --no-color. That's a good point - I'll submit a v2 with that. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

[PATCH v2] checkkconfigsymbols.py: add --no-color option, don't print color to non-TTY

2016-07-05 Thread Andrew Donnellan
Only print the ANSI colour escape codes if stdout is a TTY. Useful if redirecting output to a file or piping to another script. Also add a new option, --no-color, if the user wants to disable colour output for whatever reason. Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-04 Thread Andrew Donnellan
On 05/08/16 08:58, York Sun wrote: Two symbols are missing if mpc85xx_edac driver is compiled as module. Signed-off-by: York Sun <york@nxp.com> Good catch! One comment below. Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> /* * Reads the interrupt pin

Re: [PATCH] cpufreq: powernv: Fix crash in gpstate_timer_handler

2016-08-05 Thread Andrew Donnellan
eported-by: Madhavan Srinivasan <ma...@linux.vnet.ibm.com> Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com> Tested-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: linux-next: Tree for Aug 8

2016-08-07 Thread Andrew Donnellan
On 08/08/16 13:17, Stephen Rothwell wrote: Please do not add material destined for v4.9 to your linux-next included branches until after v4.8-rc1 has been released. Which has now happened :) -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia

[PATCH] checkkconfigsymbols.py: add --no-color option

2016-07-04 Thread Andrew Donnellan
-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- scripts/checkkconfigsymbols.py | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py index df643f6..a9eba02 100755 --- a/scripts/checkkconfigsymb

Re: Build Linux kernel to have comparable zImages

2017-02-08 Thread Andrew Donnellan
but it seems to be somewhat in the direction you're after. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

[PATCH] powerpc: sort Kconfig selects under CONFIG_PPC

2017-01-30 Thread Andrew Donnellan
config PPC has a lot of selects under it. They're not sorted in any particular order, leading to merge conflicts when adding items at the end. Sort them alphabetically. Suggested-by: Michael Ellerman <m...@ellerman.id.au> Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>

Re: [PATCH 3/3] powerpc: enable support for GCC plugins

2017-01-26 Thread Andrew Donnellan
On 27/01/17 16:52, Andrew Donnellan wrote: basic-block.h includes tm.h, and I don't believe we can remove that. I'm not convinced there's a way around this. Includes via function.h, I should say. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia

Re: [PATCH 3/3] powerpc: enable support for GCC plugins

2017-01-26 Thread Andrew Donnellan
. basic-block.h includes tm.h, and I don't believe we can remove that. I'm not convinced there's a way around this. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH] cxl: drop unused header asm/pnv-pci.h

2017-01-24 Thread Andrew Donnellan
-api.h. At least four of which aren't included directly by api.c. But I'll take you word for it :) I did compile test it before giving my Reviewed-by. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match

2017-02-15 Thread Andrew Donnellan
: Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- MAINTAINERS |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3960e7f..25ed25a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7393,18 +7393,24 @@ L: linuxppc-...@l

Re: [PATCHv4 4/4] MAINTAINERS: Remove powerpc's opal match

2017-02-15 Thread Andrew Donnellan
system Documentation/ABI/stable/sysfs-firmware-opal-dump - no other subsystem -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH] cxl: drop unused header asm/pnv-pci.h

2017-01-19 Thread Andrew Donnellan
On 19/01/17 21:50, Greg Kurz wrote: The kernel API does not use anything from this header file. Signed-off-by: Greg Kurz <gr...@kaod.org> Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.

linux.conf.au 2017 - Kernel Miniconf CFP

2016-10-04 Thread Andrew Donnellan
entire 2LD to itself...) [1] https://linux.conf.au/schedule/presentation/6/ [2] https://linux.conf.au/account/signup/ [3] https://linux.conf.au/speaker/create/ [4] https://linux.conf.au/proposals/submit/kernel-miniconf/ -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@a

[PATCH] drm/ast: free correct pointer in astfb_create() error paths

2016-09-19 Thread Andrew Donnellan
In the err_free_vram and err_release_fbi error paths in astfb_create(), we attempt to free afbdev->sysram. The only jumps to these error paths occur before we assign afbdev->sysram = sysram. Free sysram instead. Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>

Re: [PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths

2016-09-19 Thread Andrew Donnellan
On 20/09/16 11:56, Andrew Donnellan wrote: In the err_free_vram and err_release_fbi error paths in astfb_create(), we attempt to free afbdev->sysram. The only jumps to these error paths occur before we assign afbdev->sysram = sysram. Free sysram instead. Signed-off-by: Andrew Don

[PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths

2016-09-19 Thread Andrew Donnellan
In the err_free_vram and err_release_fbi error paths in astfb_create(), we attempt to free afbdev->sysram. The only jumps to these error paths occur before we assign afbdev->sysram = sysram. Free sysram instead. Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>

[PATCH 1/2] builddeb: fix typo

2016-08-26 Thread Andrew Donnellan
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- scripts/package/builddeb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/package/builddeb b/scripts/package/builddeb index 8ea9fd2..d600fd0 100755 --- a/scripts/package/builddeb +++ b/scripts/p

[PATCH 2/2] builddeb: allow building without headers/firmware packages

2016-08-26 Thread Andrew Donnellan
of the linux-headers, linux-libc-dev and linux-firmware packages to be disabled if the environment variables KDEB_NO_HEADERS, KDEB_NO_LIBC_HEADERS or KDEB_NO_FIRMWARE are non-empty. Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> ---

Re: [PATCH 4.4 000/118] 4.4.22-stable review

2016-09-28 Thread Andrew Donnellan
.4 and works for me in the cxl case. Mauricio - any objections from the pseries/dlpar side? Andrew -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 1/4] MAINTAINERS: Add "B:" for URI where to file bugs

2016-10-24 Thread Andrew Donnellan
iki-searching on the rare occasion I venture outside powerpc... For the whole series: Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 2/2] builddeb: allow building without headers/firmware packages

2016-10-17 Thread Andrew Donnellan
On 26/08/16 18:17, Andrew Donnellan wrote: Currently, the deb-pkg and bindeb-pkg targets create multiple packages for the kernel binaries, headers, userspace headers and firmware. For developers who generate Debian packages as part of their development workflows, it's often not necessary

Re: linux.conf.au 2017 - Kernel Miniconf CFP

2016-10-25 Thread Andrew Donnellan
On 04/10/16 21:18, Andrew Donnellan wrote: Greetings, * TL;DR - LCA Kernel Miniconf, Hobart, Australia, {16,17} Jan 2017 - Submissions by 23:59, 21 November (Anywhere on Earth) CFP less than a month away! See https://linux.conf.au/schedule/presentation/6/ for submission details

Re: [PATCH] cxl: drop duplicate header sched.h

2016-11-23 Thread Andrew Donnellan
On 24/11/16 02:27, Geliang Tang wrote: Drop duplicate header sched.h from native.c. Signed-off-by: Geliang Tang <geliangt...@gmail.com> Good catch! Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...

Re: linux.conf.au 2017 - Kernel Miniconf CFP

2016-11-23 Thread Andrew Donnellan
On 04/10/16 21:18, Andrew Donnellan wrote: Greetings, * TL;DR - LCA Kernel Miniconf, Hobart, Australia, {16,17} Jan 2017 - Submissions by 23:59, 21 November (Anywhere on Earth) - Wanted: anything interesting to kernel hackers! Speakers from diverse backgrounds

Re: [PATCH 2/2] builddeb: allow building without headers/firmware packages

2016-11-28 Thread Andrew Donnellan
better, I'll review that. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH] lockdep: fix report formatting

2016-11-28 Thread Andrew Donnellan
e finished it :) Cc: aryabi...@virtuozzo.com Cc: andreyk...@google.com Cc: j...@perches.com Cc: pet...@infradead.org Cc: mi...@redhat.com Cc: linux-kernel@vger.kernel.org Cc: syzkal...@googlegroups.com Missing Signed-off-by. FWIW I think the pr_cont() macro looks nicer than printk(KERN_CONT ...).

[PATCH] cpuidle/powernv: staticise powernv_idle_driver

2016-11-21 Thread Andrew Donnellan
powernv_idle_driver isn't exported, it can be made static. Found by sparse. Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- drivers/cpuidle/cpuidle-powernv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpuidle/cpuidle-powernv.c b/d

Re: linux.conf.au 2017 - Kernel Miniconf CFP

2016-11-13 Thread Andrew Donnellan
On 25/10/16 17:52, Andrew Donnellan wrote: On 04/10/16 21:18, Andrew Donnellan wrote: Greetings, * TL;DR - LCA Kernel Miniconf, Hobart, Australia, {16,17} Jan 2017 - Submissions by 23:59, 21 November (Anywhere on Earth) CFP less than a month away! See https://linux.conf.au

[PATCH RESEND 1/2] builddeb: fix typo

2016-11-13 Thread Andrew Donnellan
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- scripts/package/builddeb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/package/builddeb b/scripts/package/builddeb index 8ea9fd2..d600fd0 100755 --- a/scripts/package/builddeb +++ b/scripts/p

[PATCH RESEND 2/2] builddeb: allow building without headers/firmware packages

2016-11-13 Thread Andrew Donnellan
of the linux-headers, linux-libc-dev and linux-firmware packages to be disabled if the environment variables KDEB_NO_HEADERS, KDEB_NO_LIBC_HEADERS or KDEB_NO_FIRMWARE are non-empty. Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- Documentation/kbuild/kbuild.tx

[PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths

2016-11-13 Thread Andrew Donnellan
In the err_free_vram and err_release_fbi error paths in astfb_create(), we attempt to free afbdev->sysram. The only jumps to these error paths occur before we assign afbdev->sysram = sysram. Free sysram instead. Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>

Re: [PATCH] cxl: Fix memory allocation failure test

2016-10-31 Thread Andrew Donnellan
. Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- un-compiled because I don't have the required cross build environment. Compiles on my system! -- Andrew Donnellan OzLabs,

Re: [PATCH] cxl: Fix error handling

2016-10-31 Thread Andrew Donnellan
On 31/10/16 08:40, Christophe JAILLET wrote: 'cxl_dev_context_init()' returns an error pointer in case of error, not NULL. So test it with IS_ERR. Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> ---

Re: [PATCH] cxl: Fix error handling

2016-10-31 Thread Andrew Donnellan
On 31/10/16 08:34, Christophe JAILLET wrote: 'cxl_dev_context_init()' returns an error pointer in case of error, not NULL. So test it with IS_ERR. Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> ---

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

2016-11-03 Thread Andrew Donnellan
(particularly so we pick it up in distros) but I'm not convinced that enabling HW breakpoints on a platform where it has *never* worked qualifies as an "actual bug". (BTW many thanks for fixing this - I had a shot at it late last year but never quite got there!) -- Andrew

[PATCH] MAINTAINERS: add GCC plugins Makefile

2016-11-02 Thread Andrew Donnellan
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4012c2f..76049e0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5202,6 +5202,7 @@ L:kernel-harden...@lists.openwall.

Re: [PATCH] pci-error-recover: doc cleanup

2016-12-08 Thread Andrew Donnellan
has reasonably full EEH support, including surviving a full PHB fence and complete reset. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 4.4 01/16] powerpc/eeh: Fix deadlock when PE frozen state cant be cleared

2016-12-13 Thread Andrew Donnellan
On 14/12/16 04:15, Greg Kroah-Hartman wrote: 4.4-stable review patch. If anyone has any objections, please let me know. -- From: Andrew Donnellan <andrew.donnel...@au1.ibm.com> commit 409bf7f8a02ef88db5a0f2cdcf9489914f4b8508 upstream. In eeh_reset_device(), w

Re: [PATCH 3/3] powerpc: enable support for GCC plugins

2016-12-06 Thread Andrew Donnellan
On 06/12/16 17:28, Andrew Donnellan wrote: Enable support for GCC plugins on powerpc. Add an additional version check in gcc-plugins-check to advise users to upgrade to gcc 5.2+ on powerpc to avoid issues with header files (gcc <= 4.6) or missing copies of rs6000-cpus.def (4.8 to 5.1 on 64-

Re: [PATCH 3/3] powerpc: enable support for GCC plugins

2016-12-06 Thread Andrew Donnellan
/plugin/include/c-common.h ./lib/gcc/powerpc64-linux/4.6.4/plugin/include/c-family/c-common.def Are we sure the version check in gcc-common.h:59 is correct, or is this just a peculiarity of my particular toolchain? I need to build another 4.5 toolchain, I'll try to do that this week. -- Andrew

Re: [kernel-hardening] Re: [PATCH 3/3] powerpc: enable support for GCC plugins

2016-12-06 Thread Andrew Donnellan
p till 6.2, so yes :) I think it's best to take this through powerpc#next with an ACK from Kees/Emese? That would be fine by me. Please consider the whole series: Acked-by: Kees Cook <keesc...@chromium.org> Thanks! -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...

Re: [PATCH 3/3] powerpc: enable support for GCC plugins

2016-12-08 Thread Andrew Donnellan
, but it seems that it definitely is still putting c-common.h in the old location. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: Linux 4.9-rc8

2016-12-05 Thread Andrew Donnellan
. Andrew -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

[PATCH 2/3] powerpc: correctly disable latent entropy GCC plugin on prom_init.o

2016-12-05 Thread Andrew Donnellan
po. Fixes: 38addce8b600 ("gcc-plugins: Add latent_entropy plugin") Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- I think that we potentially could get rid of some of these disables, but it's safer to leave it for now. --- arch/powerpc/kernel/Makefile | 2 +- 1

[PATCH 1/3] gcc-plugins: fix definition of DISABLE_LATENT_ENTROPY_PLUGIN

2016-12-05 Thread Andrew Donnellan
ugins: Add latent_entropy plugin") Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- scripts/Makefile.gcc-plugins | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.gcc-plugins b/scripts/Makefile.gcc-plugins index 060d2cb..26c67b7 1006

[PATCH 3/3] powerpc: enable support for GCC plugins

2016-12-05 Thread Andrew Donnellan
Enable support for GCC plugins on powerpc. Add an additional version check in gcc-plugins-check to advise users to upgrade to gcc 5.2+ on powerpc to avoid issues with header files (gcc <= 4.6) or missing copies of rs6000-cpus.def (4.8 to 5.1 on 64-bit targets). Signed-off-by: Andrew Donnel

Re: kernel 4.9 iwlwifi startup error

2017-01-02 Thread Andrew Donnellan
not subscribed to mailing lists, so please keep me in CC: for any information request. Many thanks. I've so far seen this once on my laptop, a Samsung NP540U3C (don't have it with me right now, so I'm not sure what the wifi chipset is), running with a Debian 4.9 kernel. -- Andrew Donnellan

Re: [kernel-hardening] [PATCH v5 1/4] gcc-plugins: Add the initify gcc plugin

2017-03-27 Thread Andrew Donnellan
y_32.o += $(INITIFY_DISABLE_VERIFIY_NOCAPTURE_FUNCTIONS) s/VERIFIY/VERIFY/g here + Makefile.gcc-plugins? -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [kernel-hardening] [PATCH v5 1/4] gcc-plugins: Add the initify gcc plugin

2017-03-27 Thread Andrew Donnellan
On 27/03/17 18:38, Andrew Donnellan wrote: On 01/02/17 07:24, Kees Cook wrote: From: Emese Revfy <re.em...@gmail.com> The kernel already has a mechanism to free up code and data memory that is only used during kernel or module initialization. This plugin will teach the compiler to fin

Re: [PATCH v2 02/11] ABI: fix some syntax issues at the ABI database

2017-04-13 Thread Andrew Donnellan
Please notice". Otherwise, for cxl: Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH v3] Fix missing PCI ID; Necessary for Lenovo Yoga 720-15 Touchpad.

2017-08-16 Thread Andrew Donnellan
authorship details. If you then re-send it, it should skip this From: line and everything should be fine. Andrew -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH] scsi: cxlflash: Fix an error handling path in 'cxlflash_disk_attach()'

2017-08-15 Thread Andrew Donnellan
On 16/08/17 06:18, Christophe JAILLET wrote: 'rc' is known to be 0 at this point. If 'create_context()' fails, returns -ENOMEM instead of 0 which means success. Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> ENOMEM seems right here. Reviewed-by: Andrew Don

Re: Missing File REPORTING-BUGS In Linux Kernel.

2017-05-08 Thread Andrew Donnellan
/index.html -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: Regression for Power PC in 4.14-rc0 - bisected to commit 31bfdb036f12

2017-09-13 Thread Andrew Donnellan
is the configuration. Try with https://patchwork.ozlabs.org/patch/813153/ (A selftest for the instruction emulation will make its way upstream eventually...) -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

New Linux accelerators discussion list [was: Re: Fostering linux community collaboration on hardware accelerators]

2017-10-16 Thread Andrew Donnellan
-accelerators Archives: https://lists.ozlabs.org/pipermail/linux-accelerators I haven't set up Patchwork as yet, but if people think that's a good idea I can get that done too. Andrew -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

[ANNOUNCE] Call for Papers - linux.conf.au Kernel Miniconf, Sydney, 22 January 2018

2017-10-17 Thread Andrew Donnellan
. For general LCA questions, ask t...@lca2018.org or @linuxconfau on Twitter. - Andrew -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [ANNOUNCE] Call for Papers - linux.conf.au Kernel Miniconf, Sydney, 22 January 2018

2017-11-28 Thread Andrew Donnellan
On 18/10/17 15:34, Andrew Donnellan wrote: Greetings, * TL;DR     - LCA Kernel Miniconf, Sydney, Australia, 22 Jan 2018     - Submissions by 30 November 2017, 23:59 (AEDT/UTC+11)     - Wanted: anything interesting to kernel hackers! Speakers from   diverse backgrounds encouraged

Re: [PATCH 02/13] powerpc/powernv: Set correct configuration space size for opencapi devices

2017-12-18 Thread Andrew Donnellan
On 19/12/17 02:21, Frederic Barrat wrote: From Andrew Donnellan <andrew.donnel...@au1.ibm.com> Good try :) That should be "From: ..." git format-patch/send-email will handle this automatically if the commit author is set correctly, ie: git commit --amend --author=&

Re: [PATCH 00/13] New driver to support OpenCAPI devices on POWER9

2017-12-18 Thread Andrew Donnellan
(none exists yet) - no access to the adapter-local memory Many people contributed directly or indirectly, from the software, hardware and bringup teams. In particular Andrew Donnellan and Alastair D'Silva, who are developing the related firmware and library. Feedback welcome! [+ linux

Re: [PATCH 11/13] cxl: Remove support for "Processing accelerators" class

2017-12-18 Thread Andrew Donnellan
table. So removing the class is expected to go unnoticed. Signed-off-by: Frederic Barrat <fbar...@linux.vnet.ibm.com> Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- drivers/misc/cxl/pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/misc/cxl/pci.c b/

Re: [PATCH 03/13] powerpc/powernv: Add opal calls for opencapi

2017-12-18 Thread Andrew Donnellan
849830/ Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- arch/powerpc/include/asm/opal-api.h| 5 - arch/powerpc/include/asm/opal.h| 6 ++ arch/powerpc/platforms/powernv/opal-wrappers.S | 3 +++ 3 files changed, 13 insertions(+), 1 deletion(-)

Re: [ANNOUNCE] Call for Papers - linux.conf.au Kernel Miniconf, Sydney, 22 January 2018

2017-11-15 Thread Andrew Donnellan
On 18/10/17 15:34, Andrew Donnellan wrote: Greetings, * TL;DR     - LCA Kernel Miniconf, Sydney, Australia, 22 Jan 2018     - Submissions by 30 November 2017, 23:59 (AEDT/UTC+11)     - Wanted: anything interesting to kernel hackers! Speakers from   diverse backgrounds encouraged

Re: [PATCH] powerpc: eeh: stop using do_gettimeofday()

2017-11-05 Thread Andrew Donnellan
<a...@arndb.de> Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- arch/powerpc/include/asm/eeh.h | 2 +- arch/powerpc/kernel/eeh_driver.c | 2 +- arch/powerpc/kernel/eeh_pe.c | 8 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/powerpc

Re: [PATCH v5 2/7] powerpc: Use TIDR CPU feature to control TIDR allocation

2018-05-30 Thread Andrew Donnellan
On 11/05/18 16:12, Alastair D'Silva wrote: From: Alastair D'Silva Switch the use of TIDR on it's CPU feature, rather than assuming it is available based on architecture. Signed-off-by: Alastair D'Silva Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra

Re: [PATCH v2 3/7] powerpc: use task_pid_nr() for TID allocation

2018-04-26 Thread Andrew Donnellan
. Alastair has also confirmed with me that truncating the pid to a u16 should be safe, so therefore: Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 02/13] powerpc/powernv: Set correct configuration space size for opencapi devices

2018-01-21 Thread Andrew Donnellan
On 20/01/18 20:52, Michael Ellerman wrote:> On my Power8 PowerVM LPAR: Will fix... -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH v2 07/13] ocxl: Add AFU interrupt support

2018-01-25 Thread Andrew Donnellan
was written! :D -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH] ocxl: fix signed comparison with less than zero

2018-01-30 Thread Andrew Donnellan
xpression compared with zero: used < 0 Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices") Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks for picking this up! Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- driver

Re: [PATCH] ocxl: Add get_metadata IOCTL to share OCXL information to userspace

2018-02-20 Thread Andrew Donnellan
arsing effort in userspace. Signed-off-by: Alastair D'Silva <alast...@d-silva.org> Seems fine. Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH] ocxl: Add get_metadata IOCTL to share OCXL information to userspace

2018-02-21 Thread Andrew Donnellan
. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH v3 2/2] ocxl: Document the OCXL_IOCTL_GET_METADATA IOCTL

2018-02-21 Thread Andrew Donnellan
On 22/02/18 15:17, Alastair D'Silva wrote: From: Alastair D'Silva <alast...@d-silva.org> Signed-off-by: Alastair D'Silva <alast...@d-silva.org> Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel..

Re: [PATCH 21/23] gcc-plugins: move GCC version check for PowerPC to Kconfig

2018-02-21 Thread Andrew Donnellan
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH v3 1/2] ocxl: Add get_metadata IOCTL to share OCXL information to userspace

2018-02-21 Thread Andrew Donnellan
arsing effort in userspace. Signed-off-by: Alastair D'Silva <alast...@d-silva.org> Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 01/13] powerpc/powernv: Introduce new PHB type for opencapi links

2018-01-02 Thread Andrew Donnellan
the information in later patches. So rename existing PNV_PHB_NPU type to PNV_PHB_NPU_NVLINK and add a new type PNV_PHB_NPU_OCAPI. Signed-off-by: Frederic Barrat <fbar...@linux.vnet.ibm.com> Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- arch/powerpc/platforms/powernv/npu

Re: [PATCH 10/13] ocxl: Add Makefile and Kconfig

2018-01-02 Thread Andrew Donnellan
+= main.o pci.o config.o file.o pasid.o +ocxl-y += link.o context.o afu_irq.o sysfs.o trace.o +obj-$(CONFIG_OCXL) += ocxl.o + +# For tracepoints to include our trace.h from tracepoint infrastructure: +CFLAGS_trace.o := -I$(src) + +# ccflags-y += -DDEBUG -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 06/13] ocxl: Driver code for 'generic' opencapi devices

2018-01-02 Thread Andrew Donnellan
currently doesn't handle memory attached to the opencapi device. Signed-off-by: Frederic Barrat <fbar...@linux.vnet.ibm.com> Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> Signed-off-by: Alastair D'Silva <alast...@d-silva.org> A bunch of sparse warnings we should look

Re: [PATCH 04/13] powerpc/powernv: Add platform-specific services for opencapi

2018-01-02 Thread Andrew Donnellan
quot;, hwirq); + if (rc) { + dev_err(>dev, + "Can't translation xsl interrupt for device\n"); Can't get? -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [RFC PATCH 1/2] checkpatch: Correctly detect git commit references that span 3 lines

2018-08-06 Thread Andrew Donnellan
got some spare time over the next few days and send a v2. Thanks, -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

[RFC PATCH 2/2] checkpatch: Fix commit ID test when "commit" and hash on different lines

2018-08-05 Thread Andrew Donnellan
Signed-off-by: Andrew Donnellan --- RFC because I'm bad at Perl --- scripts/checkpatch.pl | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index aca4d758112a..ae7a54287db7 100755 --- a/scripts

[RFC PATCH 1/2] checkpatch: Correctly detect git commit references that span 3 lines

2018-08-05 Thread Andrew Donnellan
the value of the 'copros' counter of the memory context. === checkpatch will return a GIT_COMMIT_ID error even though the reference actually follows the correct format. Fix the GIT_COMMIT_ID test so it can match against a reference that spans 3 lines. Reported-by: Frederic Barrat Signed-off-

Re: [PATCH] misc: cxl: changed asterisk position

2018-08-05 Thread Andrew Donnellan
On 03/08/18 20:20, Parth Y Shah wrote: Resolved <"foo* bar" should be "foo *bar"> error Signed-off-by: Parth Y Shah Thanks for picking this up. Acked-by: Andrew Donnellan --- drivers/misc/cxl/fault.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [PATCH 2/2] misc: ocxl: use put_device() instead of device_unregister()

2018-03-12 Thread Andrew Donnellan
On 12/03/18 22:36, Arvind Yadav wrote: if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> This looks right, thanks for picking it up. Acked-by: Andrew Donnellan <andrew.donn

Re: [PATCH 4/7] ocxl: Rename pnv_ocxl_spa_remove_pe to clarify it's action

2018-04-16 Thread Andrew Donnellan
apper around the OPAL call of a similar name. But I don't feel strongly about this at all, so: Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

  1   2   3   >