Re: linux-next: Tree for Nov 26 (staging/fwserial)

2012-11-26 Thread Andrew Morton
On Mon, 26 Nov 2012 12:56:07 -0800 Randy Dunlap wrote: > On 11/26/2012 06:17 AM, Stephen Rothwell wrote: > > > Hi all, > > > > Changes since 20121115: > > > > > on i386: > > drivers/staging/fwserial/dma_fifo.c: In function 'dma_fifo_in': > drivers/staging/fwserial/dma_fifo.c:174:2: error: i

Re: [patch 7/7] fs, notify: Add procfs fdinfo helper v6

2012-11-26 Thread Andrew Morton
On Wed, 14 Nov 2012 19:19:44 +0400 Cyrill Gorcunov wrote: > This allow us to print out fsnotify details such as > watchee inode, device, mask and optionally a file handle. This helps the compiler quite a lot: --- a/fs/notify/fdinfo.c~fs-notify-add-procfs-fdinfo-helper-v7-fix +++ a/fs/notify/fdi

Re: [Patch v4 00/12] memory-hotplug: hot-remove physical memory

2012-11-27 Thread Andrew Morton
On Tue, 27 Nov 2012 18:00:10 +0800 Wen Congyang wrote: > The patch-set was divided from following thread's patch-set. > https://lkml.org/lkml/2012/9/5/201 > > The last version of this patchset: > https://lkml.org/lkml/2012/11/1/93 As we're now at -rc7 I'd prefer to take a look at all of

Re: [PATCH v6 0/6] solve deadlock caused by memory allocation with I/O

2012-11-27 Thread Andrew Morton
On Sat, 24 Nov 2012 20:59:12 +0800 Ming Lei wrote: > This patchset try to solve one deadlock problem which might be caused > by memory allocation with block I/O during runtime PM and block device > error handling path. Traditionly, the problem is addressed by passing > GFP_NOIO statically to mm,

Re: [PATCH RESEND] rtc: Add NXP PCF8523 support

2012-11-27 Thread Andrew Morton
On Fri, 23 Nov 2012 16:17:37 +0100 Thierry Reding wrote: > This commit adds an RTC driver for PCF8523 chips by NXP Semiconductors. > No support is currently provided for the alarm and interrupt functions. > Only the time and date functionality is implemented. > > ... > > +static int pcf8523_rtc_

Re: [PATCH] mm, soft offline: split thp at the beginning of soft_offline_page()

2012-11-27 Thread Andrew Morton
On Tue, 27 Nov 2012 16:05:31 -0500 Naoya Horiguchi wrote: > When we try to soft-offline a thp tail page, put_page() is called on the > tail page unthinkingly and VM_BUG_ON is triggered in put_compound_page(). > This patch splits thp before going into the main body of soft-offlining. > > The inte

Re: [Patch v3 3/7] rtc: DA9055 RTC driver

2012-11-27 Thread Andrew Morton
On Fri, 23 Nov 2012 15:41:03 +0530 Ashish Jangam wrote: > On Tue, 2012-10-23 at 15:33 +0530, Ashish Jangam wrote: > > Does this patch looks good? > > On Thu, 2012-10-11 at 16:10 +0530, Ashish Jangam wrote: > > > This is the RTC patch for the DA9055 PMIC. This patch has got dependency > > > on >

Re: [patch -mm 4/4] docs: Add documentation about /proc//fdinfo/ output

2012-11-27 Thread Andrew Morton
On Fri, 23 Nov 2012 01:15:26 +0400 Cyrill Gorcunov wrote: > Documentation/filesystems/proc.txt | 81 > + Looks good to me. Here's a small tune-up: --- a/Documentation/filesystems/proc.txt~docs-add-documentation-about-proc-pid-fdinfo-fd-output-fix +++ a/D

Re: [PATCH 1/2 v2] wait: add wait_event_lock_irq() interface

2012-11-27 Thread Andrew Morton
On Thu, 22 Nov 2012 09:18:34 +0100 Lukas Czerner wrote: > New wait_event{_interruptible}_lock_irq{_cmd} macros added. This commit > moves the private wait_event_lock_irq() macro from MD to regular wait > includes, introduces new macro wait_event_lock_irq_cmd() instead of using > the old method wi

Re: [PATCH] mm: fix balloon_page_movable() page->flags check

2012-11-27 Thread Andrew Morton
On Tue, 27 Nov 2012 21:31:10 -0200 Rafael Aquini wrote: > This patch fixes the following crash by fixing and enhancing the way > page->flags are tested to identify a ballooned page. > > ---8<--- > BUG: unable to handle kernel NULL pointer dereference at 0194 > IP: [] isolate_migrate

Re: [PATCH] mm: fix balloon_page_movable() page->flags check

2012-11-27 Thread Andrew Morton
On Tue, 27 Nov 2012 22:34:10 -0200 Rafael Aquini wrote: > Do you want me to resubmit this patch with the changes you suggested? oh, I think I can reach that far. How's this look? From: Andrew Morton Subject: mm-introduce-a-common-interface-for-balloon-pages-mobilit

Re: kswapd craziness in 3.7

2012-11-28 Thread Andrew Morton
On Wed, 28 Nov 2012 10:13:59 + Mel Gorman wrote: > Based on the reports I've seen I expect the following to work for 3.7 > > Keep > 96710098 mm: revert "mm: vmscan: scale number of pages reclaimed by > reclaim/compaction based on failures" > ef6c5be6 fix incorrect NR_FREE_PAGES accounti

Re: [RFC] Add mempressure cgroup

2012-11-28 Thread Andrew Morton
On Wed, 28 Nov 2012 02:29:08 -0800 Anton Vorontsov wrote: > The main characteristics are the same to what I've tried to add to vmevent > API: > > Internally, it uses Mel Gorman's idea of scanned/reclaimed ratio for > pressure index calculation. But we don't expose the index to the > userla

Re: [PATCH v2] rtc: Add NXP PCF8523 support

2012-11-28 Thread Andrew Morton
On Wed, 28 Nov 2012 20:21:26 +0100 Thierry Reding wrote: > + err = i2c_transfer(client->adapter, &msg, 1); > + if (err < 0) { > + /* > + * If the time cannot be set, restart the RTC anyway. Note > + * that errors are ignored if the RTC cannot be start

Re: [PATCH 0/8] aoe: miscellaneous fixes follow-up recent patch submissions

2012-11-28 Thread Andrew Morton
On Wed, 21 Nov 2012 19:52:41 -0500 Ed Cashin wrote: > This patch series applies to today's linux-next/akpm, commit > d3faae60d84f586ff8937b77c8476bca1b5f8ec6. > > Ed L. Cashin (8): > aoe: copy fallback timing information on destination failover > aoe: remove vestigial request queue allocatio

Re: [RFT PATCH v2 4/5] mm: provide more accurate estimation of pages occupied by memmap

2012-11-28 Thread Andrew Morton
On Wed, 21 Nov 2012 23:09:46 +0800 Jiang Liu wrote: > Subject: Re: [RFT PATCH v2 4/5] mm: provide more accurate estimation of pages > occupied by memmap How are people to test this? "does it boot"? > If SPARSEMEM is enabled, it won't build page structures for > non-existing pages (holes) with

Re: [PATCH, resend] kfifo: initialize fifo accordingly to C99 standard

2012-11-28 Thread Andrew Morton
On Wed, 21 Nov 2012 16:31:11 +0200 Andy Shevchenko wrote: > When build a kernel with "make W=1" we will get a warning about missing > initializer. It comes from kfifo usage style. The DEFINE_KFIFO macro doesn't > initialize the buf[] field of the fifo structure. So, using C99 style helps in > suc

Re: kswapd craziness in 3.7

2012-11-28 Thread Andrew Morton
On Wed, 28 Nov 2012 23:54:12 + Mel Gorman wrote: > On Wed, Nov 28, 2012 at 02:52:15PM -0800, Andrew Morton wrote: > > On Wed, 28 Nov 2012 10:13:59 + > > Mel Gorman wrote: > > > > > Based on the reports I've seen I expect the following to work for 3.7

Re: [PATCH, resend] kfifo: initialize fifo accordingly to C99 standard

2012-11-28 Thread Andrew Morton
On Wed, 21 Nov 2012 16:31:11 +0200 Andy Shevchenko wrote: > When build a kernel with "make W=1" we will get a warning about missing > initializer. It comes from kfifo usage style. The DEFINE_KFIFO macro doesn't > initialize the buf[] field of the fifo structure. So, using C99 style helps in > suc

Re: [PATCH V2 00/23] printk: refactoring

2012-11-29 Thread Andrew Morton
On Thu, 29 Nov 2012 14:08:15 -0800 Joe Perches wrote: > On Mon, 2012-11-12 at 15:26 -0800, Andrew Morton wrote: > > On Mon, 12 Nov 2012 14:54:10 -0800 > > Joe Perches wrote: > > > > > On Fri, 2012-11-02 at 06:49 -0700, Joe Perches wrote: > > > > On W

Re: [PATCH] tmpfs: support SEEK_DATA and SEEK_HOLE (reprise)

2012-11-29 Thread Andrew Morton
y well established convention that the lseek seek mode is called "whence". The below gets most of it. Too anal? From: Andrew Morton Subject: lseek: the "whence" argument is called "whence" But the kernel decided to call it "origin" instead. Fix

Re: [BUG REPORT] [mm-hotplug, aio] aio ring_pages can't be offlined

2012-11-29 Thread Andrew Morton
On Thu, 29 Nov 2012 14:54:58 +0800 Lin Feng wrote: > Hi all, > > We encounter a "Resource temporarily unavailable" fail while trying > to offline a memory section in a movable zone. We found that there are > some pages can't be migrated. The offline operation fails in function > migrate_page_m

Re: [PATCH 1/2] percpu-rwsem: use synchronize_sched_expedited

2012-11-29 Thread Andrew Morton
ented behaviour of synchronize_sched(), it doesn't try to pair synchronize_sched() with barrier. Signed-off-by: Oleg Nesterov Reviewed-by: Paul E. McKenney Cc: Linus Torvalds Cc: Mikulas Patocka Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Srikar Dronamraju Cc: Ananth N Mavinakayanahalli

Re: [PATCH 2/2] rtc-tps65910: enable RTC power domain on initialization

2012-11-29 Thread Andrew Morton
On Thu, 29 Nov 2012 23:11:37 + "Kim, Milo" wrote: > Hi Venu > > > > Enabling RTC HW block depends on the default value of TPS65910 > > register. > > > In some mode, RTC block is disabled by default.(eg. AM3517 > > Craneboard) > > > In this case, RTC_PWDN(RTC power down) bit should be clea

Re: [PATCH] tmpfs: support SEEK_DATA and SEEK_HOLE (reprise)

2012-11-29 Thread Andrew Morton
On Thu, 29 Nov 2012 15:29:15 -0800 (PST) Hugh Dickins wrote: > On Thu, 29 Nov 2012, Andrew Morton wrote: > > On Wed, 28 Nov 2012 17:22:03 -0800 (PST) > > Hugh Dickins wrote: > > > > > +/* > > > + * llseek SEEK_DATA or SEEK_HOLE through the radix

Re: [BUG REPORT] [mm-hotplug, aio] aio ring_pages can't be offlined

2012-11-29 Thread Andrew Morton
On Fri, 30 Nov 2012 11:42:05 +0800 Lin Feng wrote: > hi Andrew, > > On 11/30/2012 07:39 AM, Andrew Morton wrote: > > Tricky. > > > > I expect the same problem would occur with pages which are under > > O_DIRECT I/O. Obviously O_DIRECT pages won't be pin

Re: [BUG REPORT] [mm-hotplug, aio] aio ring_pages can't be offlined

2012-11-29 Thread Andrew Morton
On Fri, 30 Nov 2012 15:01:26 +0800 Lin Feng wrote: > > > On 11/30/2012 01:57 PM, Andrew Morton wrote: > > On Fri, 30 Nov 2012 11:42:05 +0800 Lin Feng wrote: > > > >> hi Andrew, > >> > >> On 11/30/2012 07:39 AM, Andrew Morton wrote: > >

Re: [BUG REPORT] [mm-hotplug, aio] aio ring_pages can't be offlined

2012-11-30 Thread Andrew Morton
On Fri, 30 Nov 2012 16:13:16 +0900 Kamezawa Hiroyuki wrote: > > What about futexes? > > > > IIUC, futex's key is now a pair of (mm,address) or (inode, pgoff). > Then, get_user_page() in futex.c will release the page by put_page(). > 'struct page' is just touched by get_futex_key() to obtain pag

Re: [BUG REPORT] [mm-hotplug, aio] aio ring_pages can't be offlined

2012-11-30 Thread Andrew Morton
On Fri, 30 Nov 2012 18:29:30 +0800 Lin Feng wrote: > > add a new library function which callers can use before (or after?) > > calling get_user_pages[_fast](). > Sorry, I'm not quite understand what "library function" function means.. > Does it means a function aids get_user_pages() or totally wr

Re: [PATCH 2/2] relay: move FIX_SIZE macro into relay.c

2013-03-18 Thread Andrew Morton
On Mon, 18 Mar 2013 10:51:54 +0800 "zhangwei(Jovi)" wrote: > +/* Needs a _much_ better name... */ > +#define FIX_SIZE(x) x) - 1) & PAGE_MASK) + PAGE_SIZE) > + Gad. That's the same as PAGE_ALIGN(), is it not? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [RFC PATCH] seq_file: Use seq_puts when seq_printf has only a format with no args

2013-03-18 Thread Andrew Morton
On Sat, 16 Mar 2013 17:54:47 + Al Viro wrote: > On Sat, Mar 16, 2013 at 06:50:44AM -0700, Joe Perches wrote: > > Instead of converting the 800 or so uses of seq_printf with > > a constant format (without a % substitution) to seq_puts, > > maybe there's another way to slightly speed up these o

Re: [PATCH 4/4] selftests: Add basic posix timers selftests

2013-03-18 Thread Andrew Morton
On Fri, 15 Mar 2013 17:54:02 +0100 Frederic Weisbecker wrote: > Add some initial basic tests on a few posix timers > interface such as setitimer() and timer_settime(). > > These simply check that expiration happens in a reasonable > timeframe after expected elapsed clock time (user time, > user

Re: [PATCH 1/2] teach argv_split() to handle the mutable strings

2013-03-18 Thread Andrew Morton
On Sat, 16 Mar 2013 21:23:53 +0100 Oleg Nesterov wrote: > argv_split() allocates argv[count_argc(str)] array and assumes that > it will find the same number of arguments later. This is obviously > wrong if this string can be changed, say, by sysctl. > > With this patch argv_split() kstrndup's th

Re: [Patch v1] rtc: fix for the DA9052 rtc device registration

2013-03-18 Thread Andrew Morton
On Fri, 15 Mar 2013 13:59:39 +0530 Ashish Jangam wrote: > DA9052/53 MFD core handles only virtual irq therefore rtc driver needs > to be updated to work on virtual irq. Without this update DA9052/53 rtc > driver will fail during its registration. > Also getting irq by it name is no longer suppo

Re: [PATCH v3 00/21] kdump, vmcore: support mmap() on /proc/vmcore

2013-03-19 Thread Andrew Morton
On Sat, 16 Mar 2013 13:00:47 +0900 HATAYAMA Daisuke wrote: > Currently, read to /proc/vmcore is done by read_oldmem() that uses > ioremap/iounmap per a single page. For example, if memory is 1GB, > ioremap/iounmap is called (1GB / 4KB)-times, that is, 262144 > times. This causes big performance

Re: [PATCH v3 07/21] vmcore, procfs: introduce a flag to distinguish objects copied in 2nd kernel

2013-03-19 Thread Andrew Morton
On Sat, 16 Mar 2013 13:01:26 +0900 HATAYAMA Daisuke wrote: > The part of dump target memory is copied into the 2nd kernel if it > doesn't satisfy mmap()'s page-size boundary requirement. To > distinguish such copied object from usual old memory, a flag > MEM_TYPE_CURRENT_KERNEL is introduced. If

Re: [PATCH v3 08/21] vmcore: copy non page-size aligned head and tail pages in 2nd kernel

2013-03-19 Thread Andrew Morton
On Sat, 16 Mar 2013 13:01:32 +0900 HATAYAMA Daisuke wrote: > Due to mmap() requirement, we need to copy pages not starting or > ending with page-size aligned address in 2nd kernel and to map them to > user-space. > > For example, see the map below: > > -0001 : reserved > 00

Re: [PATCH v3 18/21] vmcore: check if vmcore objects satify mmap()'s page-size boundary requirement

2013-03-19 Thread Andrew Morton
On Sat, 16 Mar 2013 13:02:29 +0900 HATAYAMA Daisuke wrote: > If there's some vmcore object that doesn't satisfy page-size boundary > requirement, remap_pfn_range() fails to remap it to user-space. > > Objects that posisbly don't satisfy the requirement are ELF note > segments only. The memory c

Re: [PATCH 0/2] lib,crypto: Add lz4 compressor module and crypto API

2013-03-19 Thread Andrew Morton
On Tue, 19 Mar 2013 15:42:04 +0100 Yann Collet wrote: > Thanks for pointing that out. > I've been looking into the document pointed by Andrew, > and here is my understanding : > > Signed-off-by is a one-line, so in this case : > > Signed-off-by: Yann Collet > > > or > > Signed-off-by follo

Re: [PATCH] mqueue: sys_mq_open: do not call mnt_drop_write() if read-only

2013-03-19 Thread Andrew Morton
On Tue, 19 Mar 2013 13:31:18 +0400 Vladimir Davydov wrote: > mnt_drop_write() must be called only if mnt_want_write() succeeded, > otherwise the mnt_writers counter will diverge. > > ... > > --- a/ipc/mqueue.c > +++ b/ipc/mqueue.c > @@ -840,7 +840,8 @@ out_putfd: > fd = error; >

Re: gen_pool_add broken with LPAE based systems

2013-03-19 Thread Andrew Morton
On Thu, 14 Mar 2013 16:05:27 -0700 Laura Abbott wrote: > Hi, > > We use genalloc for managing certain pools of physical memory. genalloc > currently uses unsigned long for virtual addresses and phys_addr_t for > physical addresses. Our ARM LPAE systems have 64-bit physical addresses > but uns

Re: [PATCH 1/4] posix_cpu_timer: Consolidate expiry time type

2013-03-19 Thread Andrew Morton
On Fri, 15 Mar 2013 17:53:59 +0100 Frederic Weisbecker wrote: > The posix cpu timer expiry time is stored in a union of > two types: a 64 bits field if we rely on scheduler precise > accounting, or a cputime_t if we rely on jiffies. > > This result in quite some duplicate code and special cases

Re: gen_pool_add broken with LPAE based systems

2013-03-19 Thread Andrew Morton
On Tue, 19 Mar 2013 15:49:24 -0700 Laura Abbott wrote: > On 3/19/2013 2:54 PM, Andrew Morton wrote: > > On Thu, 14 Mar 2013 16:05:27 -0700 Laura Abbott > > wrote: > > > >> Hi, > >> > >> We use genalloc for managing certain pools of physical me

Re: make[2]: execvp: /bin/bash: Argument list too long

2013-03-19 Thread Andrew Morton
On Wed, 20 Mar 2013 13:41:07 +1030 Rusty Russell wrote: > Fengguang Wu writes: > > On Tue, Mar 19, 2013 at 09:10:25AM -0400, Konrad Rzeszutek Wilk wrote: > >> On Mon, Mar 18, 2013 at 11:50:58PM -0700, Andrew Morton wrote: > >> > On Tue, 19 Mar 2013 14

Re: [PATCH] rtc: rtc-at91rm9200: use a variable for storing IMR

2013-03-20 Thread Andrew Morton
On Fri, 15 Mar 2013 18:37:12 +0100 Nicolas Ferre wrote: > On some revisions of AT91 SoCs, the RTC IMR register is not working. > Instead of elaborating a workaround for that specific SoC or IP version, > we simply use a software variable to store the Interrupt Mask Register and > modify it for e

Re: [PATCH} mm: Merging memory blocks resets mempolicy

2013-03-20 Thread Andrew Morton
On Mon, 18 Mar 2013 06:13:42 + "Hampson, Steven T" wrote: > Using mbind to change the mempolicy to MPOL_BIND on several adjacent > mmapped blocks > may result in a reset of the mempolicy to MPOL_DEFAULT in vma_adjust. > > ... > > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -820,7 +820,7 @@ again

Re: [patch] mm: speedup in __early_pfn_to_nid

2013-03-20 Thread Andrew Morton
On Mon, 18 Mar 2013 10:56:19 -0500 Russ Anderson wrote: > When booting on a large memory system, the kernel spends > considerable time in memmap_init_zone() setting up memory zones. > Analysis shows significant time spent in __early_pfn_to_nid(). > > The routine memmap_init_zone() checks each PF

Re: [PATCH 10/18] mm: teach truncate_inode_pages_range() to handle non page aligned ranges

2013-02-04 Thread Andrew Morton
On Mon, 4 Feb 2013 15:51:19 +0100 (CET) Luk Czerner wrote: > I hope I explained myself well enough :). Are you ok with this king > of approach ? If so, I'll resend the patch set without the > initialisation-at-declaration. uh, maybe. Next time I'll apply the patch and look at the end result

Re: [PATCH v6 08/15] memory-hotplug: Common APIs to support page tables hot-remove

2013-02-04 Thread Andrew Morton
On Wed, 9 Jan 2013 17:32:32 +0800 Tang Chen wrote: > +static void __meminit > +remove_pagetable(unsigned long start, unsigned long end, bool direct) > +{ > + unsigned long next; > + pgd_t *pgd; > + pud_t *pud; > + bool pgd_changed = false; > + > + for (; start < end; start = n

Re: [PATCH] mm: cma: fix accounting of CMA pages placed in high memory

2013-02-04 Thread Andrew Morton
On Mon, 04 Feb 2013 11:27:05 +0100 Marek Szyprowski wrote: > The total number of low memory pages is determined as > totalram_pages - totalhigh_pages, so without this patch all CMA > pageblocks placed in highmem were accounted to low memory. What are the end-user-visible effects of this bug? (T

Re: [PATCH 3/3] acpi, memory-hotplug: Support getting hotplug info from SRAT.

2013-02-04 Thread Andrew Morton
On Fri, 25 Jan 2013 17:42:09 +0800 Tang Chen wrote: > We now provide an option for users who don't want to specify physical > memory address in kernel commandline. > > /* > * For movablemem_map=acpi: > * > * SRAT:|_| |_| |_| |___

Re: [PATCH 1/2] mm: hotplug: implement non-movable version of get_user_pages() called get_user_pages_non_movable()

2013-02-04 Thread Andrew Morton
->node_zones + ZONE_MOVABLE; > +} A better name would be zone_is_movable(). We haven't been very consistent about this in mmzone.h, but zone_is_foo() is pretty common. And a neater implementation would be return zone_idx(zone) == ZONE_MOVABLE; All of which made me look

Re: [PATCH 1/2] mm: hotplug: implement non-movable version of get_user_pages() called get_user_pages_non_movable()

2013-02-04 Thread Andrew Morton
Also... On Mon, 4 Feb 2013 16:06:24 -0800 Andrew Morton wrote: > > +put_page: > > + /* Undo the effects of former get_user_pages(), we won't pin anything */ > > + for (i = 0; i < ret; i++) > > + put_page(pages[i]); We can use release_pages() here.

Re: [GIT PULL] printk: Support for full dynticks mode

2013-02-04 Thread Andrew Morton
On Tue, 5 Feb 2013 01:51:18 +0100 Frederic Weisbecker wrote: > printk: Wake up klogd using irq_work That seems reasonable. I'm wondering if we can now remove the printk_sched() special-case. iirc, that was needed because wake_up(klogd) would deadlock when called from sched internals. B

Re: [GIT PULL] printk: Support for full dynticks mode

2013-02-04 Thread Andrew Morton
On Tue, 5 Feb 2013 02:37:54 +0100 Frederic Weisbecker wrote: > 2013/2/5 Andrew Morton : > > On Tue, 5 Feb 2013 01:51:18 +0100 > > Frederic Weisbecker wrote: > > > >> printk: Wake up klogd using irq_work > > > > That seems reasonable. >

Re: [GIT PULL] printk: Support for full dynticks mode

2013-02-04 Thread Andrew Morton
On Mon, 04 Feb 2013 21:42:02 -0500 Steven Rostedt wrote: > On Mon, 2013-02-04 at 18:09 -0800, Andrew Morton wrote: > > > I don't think so. Conceptually printk() should be "inner" to the > > scheduler and shouldn't call into sched things at all. The (afa

Re: [PATCH v2] printk: Avoid softlockups in console_unlock()

2013-02-05 Thread Andrew Morton
On Mon, 4 Feb 2013 23:17:10 +0100 Jan Kara wrote: > A CPU can be caught in console_unlock() for a long time (tens of seconds are > reported by our customers) when other CPUs are using printk heavily and serial > console makes printing slow. Despite serial console drivers are calling > touch_nmi_

Re: [PATCH 1/2] mm: hotplug: implement non-movable version of get_user_pages() called get_user_pages_non_movable()

2013-02-05 Thread Andrew Morton
ould we update other ones in a separate patch later or just keep the old > style? I do think the old names were poorly chosen. Yes, we could fix them up sometime but it's hardly a pressing issue. > > And a neater implementation would be > > > > return zone_i

Re: [PATCH] mm: break circular include from linux/mmzone.h

2013-02-05 Thread Andrew Morton
On Tue, 05 Feb 2013 13:56:36 +0800 li guang wrote: > ___ 2013-02-04__ 21:20 -0800___David Rientjes_ > > On Tue, 5 Feb 2013, liguang wrote: > > > > > linux/mmzone.h included linux/memory_hotplug.h, > > > and linux/memory_hotplug.h also included > > > linux/mmzone.h, so there's a bad c

Re: [PATCH] mm: introduce __linear_page_index()

2013-02-05 Thread Andrew Morton
On Tue, 5 Feb 2013 15:03:39 +0800 Huang Shijie wrote: > There are many places we should get the offset(in PAGE_SIZE unit) of > an address within a non-hugetlb vma. > > In order to simplify the code, add a new helper __linear_page_index() > to do the work. > Seems nice. > --- a/include/linux/p

Re: [PATCH 0/3] mm: rename confusing function names

2013-02-05 Thread Andrew Morton
On Tue, 5 Feb 2013 14:26:40 -0500 Johannes Weiner wrote: > On Wed, Feb 06, 2013 at 01:09:55AM +0800, Zhang Yanfei wrote: > > Function nr_free_zone_pages, nr_free_buffer_pages and > > nr_free_pagecache_pages > > are horribly badly named, they count present_pages - pages_high within zones > > inst

Re: [PATCH 0/3] mm: rename confusing function names

2013-02-05 Thread Andrew Morton
On Wed, 06 Feb 2013 09:06:05 +0800 Zhang Yanfei wrote: > So could I rename the functions to the names like > nr_available_buffer_high_pages > And accurately document them with code comments just as you suggested. gee. "available" implies "available for you to allocate". It has the same problem

Re: [PATCH 0/3] mm: rename confusing function names

2013-02-05 Thread Andrew Morton
On Wed, 06 Feb 2013 09:34:16 +0800 Zhang Yanfei wrote: > > > > > > hm, > > > > static unsigned int nr_free_zone_pages(int offset) > > { > > ... > > unsigned int sum = 0; > > ... > > return sum; > > } > > > > How long will it be until these things start exploding from > > sums

Re: [PATCH] mm: don't overwrite mm->def_flags in do_mlockall()

2013-02-06 Thread Andrew Morton
On Wed, 6 Feb 2013 16:49:34 +0100 Gerald Schaefer wrote: > With commit 8e72033 "thp: make MADV_HUGEPAGE check for mm->def_flags" > the VM_NOHUGEPAGE flag may be set on s390 in mm->def_flags for certain > processes, to prevent future thp mappings. This would be overwritten > by do_mlockall(), whi

Re: [PATCH] rtc: max8997: Add driver for max8997 rtc.

2013-02-06 Thread Andrew Morton
On Wed, 06 Feb 2013 20:23:05 +0900 Jonghwa Lee wrote: > This patch adds rtc driver for Maxim 8997 multifunction chip. > Max8997 has rtc module in it. and it can be used for timekeeping > clock and system alarm. It provide various operational mode those are > BCD/binary, 24/12hour, am/pm. Driver s

Re: [PATCH] rtc: core: Prevent repeated calling of alarm_irq_enable().

2013-02-06 Thread Andrew Morton
On Wed, 06 Feb 2013 20:22:45 +0900 Jonghwa Lee wrote: > This patch removes repeated execution of disabling alarm in > rtc_alarm_irq_enable() of rtc core interface. It made useless > call even all alarm had been disabled from rtc_timer_remove(). > We'd better to skip disabling alarm when timer que

Re: [PATCH 3/3] acpi, memory-hotplug: Support getting hotplug info from SRAT.

2013-02-06 Thread Andrew Morton
On Wed, 06 Feb 2013 10:20:57 +0800 Tang Chen wrote: > >> > >> + if (!strncmp(p, "acpi", max(4, strlen(p > >> + movablemem_map.acpi = true; > > > > Generates a warning: > > > > mm/page_alloc.c: In function 'cmdline_parse_movablemem_map': > > mm/page_alloc.c:5312: warning: comparison

Re: [PATCH 21/77] block: fix synchronization and limit check in blk_alloc_devt()

2013-02-06 Thread Andrew Morton
On Wed, 6 Feb 2013 11:39:53 -0800 Tejun Heo wrote: > idr allocation in blk_alloc_devt() wasn't synchronized against lookup > and removal, and its limit check was off by one - 1 << MINORBITS is > the number of minors allowed, not the maximum allowed minor. > > Add locking and rename MAX_EXT_DEVT

Re: [PATCH 21/77] block: fix synchronization and limit check in blk_alloc_devt()

2013-02-06 Thread Andrew Morton
On Wed, 6 Feb 2013 14:27:55 -0800 Tejun Heo wrote: > Hello, Andrew. > > On Wed, Feb 06, 2013 at 02:24:22PM -0800, Andrew Morton wrote: > > This gets all tangled up with > > http://ozlabs.org/~akpm/mmotm/broken-out/block-fix-ext_devt_idr-handling.patch, > > which appe

Re: [PATCH v2] hlist: drop the node parameter from iterators

2013-02-06 Thread Andrew Morton
On Wed, 30 Jan 2013 21:00:22 -0500 Sasha Levin wrote: > I'm not sure why, but the hlist for each entry iterators were conceived > differently from the list ones. While the list ones are nice and elegant: > > list_for_each_entry(pos, head, member) > > The hlist ones were greedy and wante

Re: [PATCH 1/3] mm: use long type for page counts in mm_populate() and get_user_pages()

2013-02-06 Thread Andrew Morton
On Wed, 06 Feb 2013 19:39:11 -0500 Sasha Levin wrote: > We're now hitting the VM_BUG_ON() which was added in the last hunk of the > patch: hm, why was that added. Michel, I seem to have confused myself over this series. I saw a report this morning which led me to drop mm-accelerate-munlock-tre

Re: [PATCH] rtc: max8997: Add driver for max8997 rtc.

2013-02-06 Thread Andrew Morton
On Thu, 07 Feb 2013 10:43:23 +0900 jonghwa3@samsung.com wrote: > > The best way of handling this sort of thing is for the driver to probe > > the hardware, work out its capabilities and "do the right thing". > > > > The second best way is to require that the user add certain module > > parame

Re: linux-next: manual merge of the akpm-current tree with the kvm tree

2013-02-06 Thread Andrew Morton
On Thu, 7 Feb 2013 17:03:19 +1100 Stephen Rothwell wrote: > Hi Andrew, > > Today's linux-next merge of the akpm-current tree got a conflict in > arch/x86/kvm/mmu.c between commit 9bb4f6b15ec0 ("KVM: MMU: drop unneeded > checks") from the kvm tree and commit "hlist: drop the node parameter > fro

Re: [PATCH v2] hlist: drop the node parameter from iterators

2013-02-07 Thread Andrew Morton
On Wed, 30 Jan 2013 21:00:22 -0500 Sasha Levin wrote: > I'm not sure why, but the hlist for each entry iterators were conceived > differently from the list ones. While the list ones are nice and elegant: > > list_for_each_entry(pos, head, member) > > The hlist ones were greedy and wante

Re: [PATCH v2] rtc: max8997: Add driver for max8997 rtc.

2013-02-07 Thread Andrew Morton
On Thu, 07 Feb 2013 20:01:27 +0900 Jonghwa Lee wrote: > This patch adds rtc driver for Maxim 8997 multifunction chip. > Max8997 has rtc module in it. and it can be used for timekeeping > clock and system alarm. It provide various operational mode those are > BCD/binary, 24/12hour, am/pm. Driver s

Re: Odd ENOMEM being returned in 3.8-rcX

2013-02-07 Thread Andrew Morton
On Thu, 7 Feb 2013 16:57:42 -0500 Josh Boyer wrote: > Hi All, > > We've hit a weird error in Fedora using the 3.8-rcX kernels. It seems > the mock tool is getting back ENOMEM when doing very simple things that > normally just work. The 3.7 kernels on the same userspace work just > fine. It se

Re: [PATCH 1/1] eventfd: implementation of EFD_MASK flag

2013-02-07 Thread Andrew Morton
On Thu, 7 Feb 2013 07:41:32 +0100 Martin Sustrik wrote: > When implementing network protocols in user space, one has to implement > fake user-space file descriptors to represent the sockets for the protocol. > > While all the BSD socket API functionality for such descriptors may be faked > as

Re: [PATCH 1/3 v3] selftests: Add tests for efivarfs

2013-02-07 Thread Andrew Morton
On Wed, 06 Feb 2013 22:48:08 +0800 Jeremy Kerr wrote: > This change adds a few initial efivarfs tests to the > tools/testing/selftests directory. > > The open-unlink test is based on code from > Lingzhu Xiang . > > ... > > --- a/tools/testing/selftests/Makefile > +++ b/tools/testing/selftests/M

Re: [PATCH RESEND] mm: accurately document nr_free_*_pages functions with code comments

2013-02-07 Thread Andrew Morton
On Thu, 07 Feb 2013 09:57:27 +0800 Zhang Yanfei wrote: > Functions nr_free_zone_pages, nr_free_buffer_pages and nr_free_pagecache_pages > are horribly badly named, so accurately document them with code comments > in case of the misuse of them. Looks OK. I fiddled with it a bit: --- a/mm/page_

Re: [PATCH v2 10/18] mm: teach truncate_inode_pages_range() to handle non page aligned ranges

2013-02-07 Thread Andrew Morton
On Tue, 5 Feb 2013 10:12:03 +0100 Lukas Czerner wrote: > This commit changes truncate_inode_pages_range() so it can handle non > page aligned regions of the truncate. Currently we can hit BUG_ON when > the end of the range is not page aligned, but we can handle unaligned > start of the range. >

Re: [PATCH] fs/proc/vmcore.c: Put if tests in the top of the while loop to reduce duplication

2013-02-07 Thread Andrew Morton
On Sun, 03 Feb 2013 21:13:36 +0800 Zhang Yanfei wrote: > From: Zhang Yanfei > > In function read_vmcore, two if tests are duplicate. Change the position > of them could reduce the duplication. This change does not affect > the behaviour of the function. > hm, yes. > --- a/fs/proc/vmcore.c >

Re: [PATCH 23/32] Generic dynamic per cpu refcounting

2013-02-08 Thread Andrew Morton
On Fri, 8 Feb 2013 15:49:02 +0100 Jens Axboe wrote: > > > Signed-off-by: Kent Overstreet > > > > What's the status of this series? The percpu-refcnt part is still > > going through review and the merge window is opening up pretty soon. > > Kent, Andrew? > > I'd feel a lot better deferring the

Re: [PATCH] fs/proc/vmcore.c: Put if tests in the top of the while loop to reduce duplication

2013-02-08 Thread Andrew Morton
On Fri, 08 Feb 2013 06:25:39 -0800 ebied...@xmission.com (Eric W. Biederman) wrote: > Andrew Morton writes: > > > On Sun, 03 Feb 2013 21:13:36 +0800 > > Zhang Yanfei wrote: > > > >> From: Zhang Yanfei > >> > >> In function read_vmcore, two

Re: [PATCH v2] lib/scatterlist: add simple page iterator

2013-02-11 Thread Andrew Morton
On Mon, 11 Feb 2013 20:50:04 +0200 Imre Deak wrote: > Add an iterator to walk through a scatter list a page at a time starting > at a specific page offset. As opposed to the mapping iterator this is What is "the mapping iterator"? > meant to be small, performing well even in simple loops like c

Re: RFC: mincore: add a bit to indicate a page is dirty.

2013-02-11 Thread Andrew Morton
On Mon, 11 Feb 2013 11:27:01 -0500 Johannes Weiner wrote: > > Is PG_dirty the right choice? Is that right for huge pages? Should I > > assume is_migration_entry(entry) means it's not dirty, or is there some > > other check here? > > If your only consequence of finding dirty pages is to sync, w

Re: [PATCH] driver core: add wait event for deferred probe

2013-02-11 Thread Andrew Morton
On Sun, 10 Feb 2013 00:57:57 +0800 Haojian Zhuang wrote: > do_initcalls() could call all driver initialization code in kernel_init > thread. It means that probe() function will be also called from that > time. After this, kernel could access console & release __init section > in the same thread.

Re: [PATCH 1/6] idr: fix top layer handling

2013-02-11 Thread Andrew Morton
On Fri, 8 Feb 2013 13:00:50 -0800 Tejun Heo wrote: > Most functions in idr fail to deal with the high bits when the idr > tree grows to the maximum height. > > * idr_get_empty_slot() stops growing idr tree once the depth reaches > MAX_IDR_LEVEL - 1, which is one depth shallower than necessary

Re: Odd ENOMEM being returned in 3.8-rcX

2013-02-11 Thread Andrew Morton
On Fri, 08 Feb 2013 12:13:09 -0800 ebied...@xmission.com (Eric W. Biederman) wrote: > If mock has called unshare(CLONE_NEWPID). And then forked a process and > that process exited, and then forked anothe process that second and all > subsequent fork calls will fail with -ENOMEM (because init has e

Re: [PATCH 1/6] idr: fix top layer handling

2013-02-12 Thread Andrew Morton
On Tue, 12 Feb 2013 09:10:49 -0800 Tejun Heo wrote: > Hey, Andrew. > > On Mon, Feb 11, 2013 at 03:39:55PM -0800, Andrew Morton wrote: > > This doesn't apply happily to 3.7, so Greg will be needing a redone > > version when the time arrives. > > > > Bu

Re: [PATCH v2] lib/scatterlist: add simple page iterator

2013-02-12 Thread Andrew Morton
On Tue, 12 Feb 2013 19:07:20 +0200 Imre Deak wrote: > > So, exactly how big is this thing, and how do we know it's better this > > way than if we were to uninline some/all of the helpers? > > I admit I only hoped compiler optimization would keep the inlined parts > at a minimum, but now I actual

Re: [PATCH 1/3] nbd: support FLUSH requests

2013-02-12 Thread Andrew Morton
On Tue, 12 Feb 2013 19:06:09 +0100 Paolo Bonzini wrote: > Il 12/02/2013 18:37, Alex Bligh ha scritto: > > For my education, why remove the FUA stuff? > > Because I had no way to test it. > > >>> > > Hmmm... the underlying storage could be md/dm RAIDs in which case FUA > >>> > > should be cheape

Re: [PATCH 2/3] nbd: fsync and kill block device on shutdown

2013-02-12 Thread Andrew Morton
On Tue, 12 Feb 2013 17:06:10 +0100 Paolo Bonzini wrote: > There are two problems with shutdown in the NBD driver. The first is > that receiving the NBD_DISCONNECT ioctl does not sync the filesystem; > this is useful because BLKFLSBUF is restricted to processes that have > CAP_SYS_ADMIN, and the

Re: [PATCH 0/3] NBD fixes for caching and block device flags

2013-02-12 Thread Andrew Morton
inst > power losses. The second properly syncs and cleans the client's page > cache when an NBD device is disconnected from the server. > > The third reports read-only devices properly in sysfs. > > Ok for 3.9? I saw the last NBD patches were applied by Andrew Morton, &g

Re: [PATCH 1/3 v3] selftests: Add tests for efivarfs

2013-02-12 Thread Andrew Morton
On Fri, 08 Feb 2013 18:05:52 +0800 Jeremy Kerr wrote: > > I'll do this for now: > > > > --- > > a/tools/testing/selftests/efivarfs/Makefile~selftests-add-tests-for-efivarfs-fix > > +++ a/tools/testing/selftests/efivarfs/Makefile > > @@ -6,7 +6,7 @@ test_objs = open-unlink > > all: $(test_objs)

Re: [PATCH 1/3 v3] selftests: Add tests for efivarfs

2013-02-12 Thread Andrew Morton
On Fri, 08 Feb 2013 10:08:49 + Matt Fleming wrote: > On Fri, 2013-02-08 at 18:05 +0800, Jeremy Kerr wrote: > > However, the tests expose a bug at the moment, so run_tests will fail. > > Matt will have that fixed soon though :) > > In which case, would it make more sense for me to take these

Re: [PATCH] Documentation: Add a simple doc for selftests

2013-02-12 Thread Andrew Morton
On Fri, 08 Feb 2013 18:02:44 +0800 Jeremy Kerr wrote: > On 08/02/13 07:13, Andrew Morton wrote: > > > The general ruleset for selftests is: do as much as you can if you're not > > root and don't take too long and don't break the build on any > > architect

Re: [PATCH V3] ia64/mm: fix a bad_page bug when crash kernel booting

2013-02-12 Thread Andrew Morton
On Tue, 12 Feb 2013 16:11:33 -0800 Tony Luck wrote: > Building linux-next today (tag next-20130212) I get the following errors when > building arch/ia64/configs/{tiger_defconfig, zx1_defconfig, bigsur_defconfig, > sim_defconfig} > > arch/ia64/mm/init.c: In function 'free_initrd_mem': > arch/ia64

Re: [PATCH V3] ia64/mm: fix a bad_page bug when crash kernel booting

2013-02-12 Thread Andrew Morton
On Tue, 12 Feb 2013 16:11:33 -0800 Tony Luck wrote: > Building linux-next today (tag next-20130212) I get the following errors when > building arch/ia64/configs/{tiger_defconfig, zx1_defconfig, bigsur_defconfig, > sim_defconfig} > > arch/ia64/mm/init.c: In function 'free_initrd_mem': > arch/ia64

Re: MAINTAINERS: Remove Mark M. Hoffman

2013-02-12 Thread Andrew Morton
On Fri, 8 Feb 2013 10:54:37 +0100 Jean Delvare wrote: > Mark M. Hoffman stopped working on the Linux kernel several years > ago, so he should no longer be listed as a driver maintainer. I'm not > even sure if his e-mail address still works. > > I can take over 3 drivers he was responsible for, t

Re: linux-next: manual merge of the akpm tree with the vfs tree

2013-04-03 Thread Andrew Morton
On Thu, 4 Apr 2013 17:26:48 +1100 Stephen Rothwell wrote: > Hi Andrew, > > Today's linux-next merge of the akpm tree got a conflict in > fs/proc/generic.c between several commits from the vfs tree and commit > "procfs: improve scaling in proc" from the akpm tree. > > I just dropped the akpm tr

  1   2   3   4   5   6   7   8   9   10   >