[PATCH] max77693: added device tree support

2013-04-09 Thread Andrzej Hajda
max77693 mfd main device uses only wakeup field from max77693_platform_data. This field is mapped to wakeup-source common property in device tree. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

[PATCH] regulator: fixed regulator_bulk_enable unwinding code

2013-03-01 Thread Andrzej Hajda
Unwinding code disables all successfully enabled regulators. Error is logged for every failed regulator. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/regulator/core.c | 10 +++--- 1 file changed, 7 insertions(+), 3

[PATCH RFC v2 0/2] max77693-led driver

2013-02-19 Thread Andrzej Hajda
Those two patches add max77693-led driver with device tree support. Driver is exposed to user space as a V4L2 flash subdevice. This subdevice should be registered by V4L2 driver of the camera device. Changes for v2 are described in patch 2/2, thanks for review to Sylwester. Additionally I have

[PATCH RFC v2 2/2] media: added max77693-led driver

2013-02-19 Thread Andrzej Hajda
-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes for v2: - kzalloc replaced by devm_kzalloc - corrected cleanup code on probe fail - simplified clamp routine

[PATCH RFC v2 1/2] max77693: added device tree support

2013-02-19 Thread Andrzej Hajda
max77693 mfd main device uses only wakeup field from max77693_platform_data. This field is mapped to wakeup-source property in device tree. Device tree bindings doc will be added in max77693-led patch. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro

[PATCH RESEND] max77693: added device tree support

2013-08-19 Thread Andrzej Hajda
max77693 mfd main device uses only wakeup field from max77693_platform_data. This field is mapped to wakeup-source common property in device tree. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

[PATCH v2] max77693: added device tree support

2013-08-19 Thread Andrzej Hajda
max77693 mfd main device uses only wakeup field from max77693_platform_data. This field is mapped to wakeup-source common property in device tree. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

Re: [PATCH v2] max77693: added device tree support

2013-08-20 Thread Andrzej Hajda
Hi, Thanks for the review. On 08/19/2013 11:18 PM, Stephen Warren wrote: On 08/19/2013 05:40 AM, Andrzej Hajda wrote: max77693 mfd main device uses only wakeup field from max77693_platform_data. This field is mapped to wakeup-source common property in device tree. diff --git a/Documentation

[PATCH v3 2/2] max77693: added device tree support

2013-08-21 Thread Andrzej Hajda
This patch adds only of_match_table. There are no device specific properties. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/mfd/max77693.c | 8 1 file changed, 8

[PATCH v3 0/2] max77693: added device tree support

2013-08-21 Thread Andrzej Hajda
Hi, The first patch cleans up the driver from unneccesary wakeup handling. The second patch adds device tree support to the driver. Regards Andrzej Andrzej Hajda (2): max77693: remove device wakeup from driver max77693: added device tree support drivers/mfd/max77693.c | 18

[PATCH v3 1/2] max77693: remove device wakeup from driver

2013-08-21 Thread Andrzej Hajda
The patch removes wakeup related code from the driver and plaftorm data - it is already handled by i2c core using I2C_CLIENT_WAKE flag from struct i2c_board_info. As a result MFD itself do not requires platform data. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH RFC v2 1/2] max77693: added device tree support

2013-08-14 Thread Andrzej Hajda
Hi Lee, I have no response from Samuel regarding this patch. Could you take care of it, I can rebase it again if necessary. Regards Andrzej On 07/17/2013 09:45 AM, Andrzej Hajda wrote: Hi Samuel, A while ago I have send rebased patch adding device-tree support for max77693 as you asked

Re: [PATCH RFC v2 1/2] max77693: added device tree support

2013-07-17 Thread Andrzej Hajda
Andrzej, On Tue, Feb 19, 2013 at 04:36:16PM +0100, Andrzej Hajda wrote: max77693 mfd main device uses only wakeup field from max77693_platform_data. This field is mapped to wakeup-source property in device tree. Device tree bindings doc will be added in max77693-led patch. Signed-off

Re: [PATCH v4 1/3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-10 Thread Andrzej Hajda
Hi, On 03/08/2014 04:54 PM, Laurent Pinchart wrote: Hi Philipp, On Saturday 08 March 2014 13:07:23 Philipp Zabel wrote: On Fri, Mar 7, 2014 at 6:18 PM, Grant Likely wrote: On Wed, 26 Feb 2014 16:24:57 +0100, Philipp Zabel wrote: The 'ports' node is optional. It is only needed if the parent

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Andrzej Hajda
On 03/10/2014 04:15 PM, Laurent Pinchart wrote: Hi Grant, On Monday 10 March 2014 14:58:15 Grant Likely wrote: On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: On 08/03/14 13:41, Grant Likely wrote: Ok. If we go for single

Re: [PATCH v4 1/3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Andrzej Hajda
On 03/10/2014 12:42 PM, Laurent Pinchart wrote: Hi Andrzej, I like that idea. I would prefer making the 'port' nodes mandatory and the 'ports' and 'endpoint' nodes optional. Leaving the 'port' node out slightly decreases readability in my opinion, but making the 'endpoint' node optional

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-21 Thread Andrzej Hajda
On 03/20/2014 06:23 PM, Grant Likely wrote: On Tue, 11 Mar 2014 14:16:37 +0100, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Tuesday 11 March 2014 14:59:20 Tomi Valkeinen wrote: So depending on the use case, the endpoints would point to opposite direction from the encoder's

Re: [PATCH v3 1/2] max77693: remove device wakeup from driver

2013-09-26 Thread Andrzej Hajda
On 08/21/2013 06:53 PM, Andrzej Hajda wrote: The patch removes wakeup related code from the driver and plaftorm data - it is already handled by i2c core using I2C_CLIENT_WAKE flag from struct i2c_board_info. As a result MFD itself do not requires platform data. Signed-off-by: Andrzej Hajda

Re: [PATCH v3 2/2] max77693: added device tree support

2013-09-26 Thread Andrzej Hajda
On 08/21/2013 06:53 PM, Andrzej Hajda wrote: This patch adds only of_match_table. There are no device specific properties. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCH v4 2/2] max77693: added device tree support

2013-09-27 Thread Andrzej Hajda
This patch adds only of_match_table. There are no device specific properties. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Hi, Spaces added. Regards Andrzej --- drivers/mfd

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-06-09 Thread Andrzej Hajda
On 06/09/2014 01:29 PM, Lars-Peter Clausen wrote: On 06/09/2014 01:18 AM, Ben Dooks wrote: On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote: On 05/30/2014 07:33 PM, David Daney wrote: On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at 1:30 PM,

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-06-10 Thread Andrzej Hajda
On 06/09/2014 03:43 PM, David Laight wrote: From: Of Andrzej Hajda ... You can't error out on module unload, although that's not really relevant here. gpiochip_remove() is typically called when the device that registered the GPIO chip is unbound. And despite some remove() callbacks having

Re: [PATCH v2 4/7] drivers/base: Add interface framework

2014-05-20 Thread Andrzej Hajda
Hi Thierry, Greg, On 05/15/2014 10:53 AM, Thierry Reding wrote: On Tue, May 13, 2014 at 05:32:15PM -0700, Greg Kroah-Hartman wrote: On Tue, May 13, 2014 at 07:57:13PM +0200, Daniel Vetter wrote: On Tue, May 13, 2014 at 05:30:47PM +0200, Thierry Reding wrote: From: Thierry Reding

[PATCH 3/8] drm/exynos/ipp: simplify property list allocation

2014-05-19 Thread Andrzej Hajda
prop_list is always allocated, so instead of allocating it dynamically the pointer can be replaced by the structure itself. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c| 10 ++ drivers/gpu/drm/exynos/exynos_drm_gsc.c | 10

[PATCH 8/8] drm/exynos/fimc: simplify and rename fimc_dst_get_buf_seq

2014-05-19 Thread Andrzej Hajda
fimc_dst_get_buf_seq returns number of buffers so the name should be fimc_dst_get_buf_count. Function body has been simplified. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff

[PATCH 7/8] drm/exynos/fimc: replace mutex by spinlock

2014-05-19 Thread Andrzej Hajda
Function fimc_dst_set_buf_seq is called by irq handler so it should not use mutexes. This patch fixes it. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 5/8] drm/exynos/fimc: simplify irq masking function

2014-05-19 Thread Andrzej Hajda
The name fimc_handle_irq suggests it is irq handler, but the function is for irq mask configuration. The patch renames the function to fimc_mask_irq and removes unused arguments. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 25

[PATCH 4/8] drm/exynos/fimc: simplify pre-scaler ratio calculation

2014-05-19 Thread Andrzej Hajda
The patch replaces dedicated function for scaling ratio calculation by fls calls. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 56 1 file changed, 13 insertions(+), 43 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 6/8] drm/exynos/fimc: replace hw access macros with functions

2014-05-19 Thread Andrzej Hajda
HW access macros implicitly depended on presence of ctx local variable. This patch replaces them with C functions. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 311 +++ 1 file changed, 150 insertions(+), 161 deletions

[PATCH 0/8] drm/exynos/ipp: image post processing improvements

2014-05-19 Thread Andrzej Hajda
This set of independent patches contains various improvement and fixes for exynos_drm ipp framework and drivers. The patchset is based on drm-exynos/exynos-drm-next branch. Regards Andrzej Andrzej Hajda (8): drm/exynos/ipp: fix get_property IOCTL drm/exynos/ipp: correct ipp_id field

[PATCH 1/8] drm/exynos/ipp: fix get_property IOCTL

2014-05-19 Thread Andrzej Hajda
Due to incorrect assignment in EXYNOS_IPP_GET_PROPERTY IOCTL handler this IOCTL did not work at all. The patch fixes it. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH 2/8] drm/exynos/ipp: correct ipp_id field initialization

2014-05-19 Thread Andrzej Hajda
prop_list.ipp_id field is not initialized properly. The patch fixes it, additionally it removes redundant field from ippdrv. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 14 ++ drivers/gpu/drm/exynos/exynos_drm_ipp.h | 1 - 2 files

[PATCH] drm/panel/s6e8aa0: add backlight support

2014-05-29 Thread Andrzej Hajda
The patch adds backlight support to s6e8aa0 panel. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/panel/Kconfig | 2 ++ drivers/gpu/drm/panel/panel-s6e8aa0.c | 50 +++ 2 files changed, 52 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 1/9] drm/exynos: ipp: remove usless list_empty() functions

2014-05-26 Thread Andrzej Hajda
Tested-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 61 + 1 file changed, 9 insertions(+), 52 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c index bf71d97..c8cfa24 100644

[PATCH 0/9] drm/exynos/ipp: image post processing improvements, part deux

2014-05-26 Thread Andrzej Hajda
This is the next part of ipp improvement patches, this time made by YoungJun Cho, I am posting them as he is on leave. The patchset is based on drm-exynos/exynos-drm-next branch. Regards Andrzej Andrzej Hajda (1): drm/exynos: ipp: remove description of non-existing field YoungJun Cho (8

[PATCH 5/9] drm/exynos: ipp: add ipp_remove_id()

2014-05-26 Thread Andrzej Hajda
From: YoungJun Cho yj44@samsung.com This patch adds ipp_remove_id() for idr resource free. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Seong-Woo Kim sw0312@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Tested-by: Andrzej Hajda a.ha...@samsung.com

[PATCH 4/9] drm/exynos: ipp: add cmd_lock for cmd_list

2014-05-26 Thread Andrzej Hajda
From: YoungJun Cho yj44@samsung.com This patch adds cmd_lock for cmd_list synchronization. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Seong-Woo Kim sw0312@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Tested-by: Andrzej Hajda a.ha...@samsung.com

[PATCH 6/9] drm/exynos: ipp: rearrange c_node-mem_lock using routines

2014-05-26 Thread Andrzej Hajda
From: YoungJun Cho yj44@samsung.com The c_node-mem_list[] should be protected with c_node-mem_lock. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Seong-Woo Kim sw0312@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Tested-by: Andrzej Hajda a.ha...@samsung.com

[PATCH 8/9] drm/exynos: ipp: update comment for struct drm_ipp_buf_info

2014-05-26 Thread Andrzej Hajda
...@samsung.com Tested-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.h b/drivers/gpu/drm/exynos/exynos_drm_ipp.h index 09cb5a2..e06c41e 100644 --- a/drivers/gpu

[PATCH 7/9] drm/exynos: ipp: rearrange c_node-event_lock using routine

2014-05-26 Thread Andrzej Hajda
From: YoungJun Cho yj44@samsung.com The c_node-event_list should be protected with c_node-event_lock. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Seong-Woo Kim sw0312@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Tested-by: Andrzej Hajda a.ha...@samsung.com

[PATCH 9/9] drm/exynos: ipp: remove description of non-existing field

2014-05-26 Thread Andrzej Hajda
ipp_id field is removed from exynos_drm_ippdrv struct. The patch removes its description as well. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.h b/drivers/gpu

[PATCH 2/9] drm/exynos: ipp: remove duplicated setting

2014-05-26 Thread Andrzej Hajda
From: YoungJun Cho yj44@samsung.com This patch removes duplicated setting. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Seong-Woo Kim sw0312@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Tested-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm

[PATCH 3/9] drm/exynos: ipp: rename cmd_lock to lock

2014-05-26 Thread Andrzej Hajda
From: YoungJun Cho yj44@samsung.com The ippdrv-cmd_list requires cmd_lock. So renames cmd_lock to lock for context. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Seong-Woo Kim sw0312@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Tested-by: Andrzej Hajda a.ha

Re: [RFC PATCH 0/2] drm/panel: add simple-panel description using DT

2014-05-13 Thread Andrzej Hajda
On 05/13/2014 09:51 AM, Thierry Reding wrote: On Fri, May 09, 2014 at 04:16:40PM +0200, Boris BREZILLON wrote: Hello Thierry, I noticed you're describing each new panel with a new entry in the of_platform_match table and a new compatible string. I guess you have a good reason to do it this

[RFC PATCH 4/4] drm/panel/ld9040: do not power off panel on removal

2014-04-30 Thread Andrzej Hajda
Panel is powered off already by connector during drm_panel_remove call. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/panel/panel-ld9040.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-ld9040.c b/drivers/gpu/drm/panel/panel-ld9040.c index

[RFC PATCH 2/4] drm/panel: add interface tracker support

2014-04-30 Thread Andrzej Hajda
drm_panel framework allows only query for presence of given panel. It also does not protect panel module from unloading and does not provide solution for driver unbinding. interface_tracker should solve both issues. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- --- drivers/gpu/drm

[RFC PATCH 3/4] drm/exynos/dpi: add interface tracker support

2014-04-30 Thread Andrzej Hajda
exynos_dpi uses connector polling for tracking panel presence, this solution introduces unnecessary 10s delay before panel activation. Moreover it is unsafe, module unloading or driver unbinding can cause system crash. interface_tracker support solves both problems. Signed-off-by: Andrzej Hajda

[RFC PATCH 1/4] drivers/base: add interface tracker framework

2014-04-30 Thread Andrzej Hajda
type. Object type depends on interface type, for example interface type drm_panel determines that object is a device_node. Object pointer is used to distinguish different interfaces of the same type and should identify object the interface is bound to. Signed-off-by: Andrzej Hajda a.ha

[RFC PATCH 0/4] drivers/base: Generic framework for tracking internal interfaces

2014-04-30 Thread Andrzej Hajda
Andrzej Hajda (4): drivers/base: add interface tracker framework drm/panel: add interface tracker support drm/exynos/dpi: add interface tracker support drm/panel/ld9040: do not power off panel on removal drivers/base/Makefile | 2 +- drivers/base/interface_tracker.c

Re: [RFC PATCH 0/4] drivers/base: Generic framework for tracking internal interfaces

2014-04-30 Thread Andrzej Hajda
Hi Greg, Thanks for comments. I CC Laurent, I hope it could be interesting for him also. Greg Kroah-Hartman wrote, On 30.04.2014 17:49: On Wed, Apr 30, 2014 at 04:02:50PM +0200, Andrzej Hajda wrote: Generic framework for tracking internal interfaces

Re: [RFC PATCH 0/4] drivers/base: Generic framework for tracking internal interfaces

2014-05-01 Thread Andrzej Hajda
Russell King - ARM Linux wrote, On 01.05.2014 00:28: On Wed, Apr 30, 2014 at 11:42:09PM +0200, Andrzej Hajda wrote: The main problem with component framework is that componentization significantly changes every driver and changes it in a way which is not compatible with traditional drivers, so

Re: [RFC PATCH 0/4] drivers/base: Generic framework for tracking internal interfaces

2014-05-05 Thread Andrzej Hajda
On 05/01/2014 11:11 AM, Russell King - ARM Linux wrote: On Thu, May 01, 2014 at 09:04:19AM +0200, Andrzej Hajda wrote: 2. You replace calls of component_add and component_del with calls to interface_tracker_ifup(dev, INTERFACE_TRACKER_TYPE_COMPONENT, specific_component_ops

Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver

2014-04-09 Thread Andrzej Hajda
Hi Tomasz, On 04/08/2014 04:37 PM, Tomasz Stanislawski wrote: Add exynos-simple-phy driver to support a single register PHY interfaces present on Exynos4 SoC. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com --- .../devicetree/bindings/phy/samsung-phy.txt| 24 +++

Re: [PATCHv2 2/3] drm: exynos: hdmi: use hdmiphy as PHY

2014-04-09 Thread Andrzej Hajda
Hi Tomasz, On 04/08/2014 04:37 PM, Tomasz Stanislawski wrote: The HDMIPHY (physical interface) is controlled by a single bit in a power controller's regiter. It was implemented as clock. It was a simple but effective hack. This power controller register has also bits to control HDMI clock

Re: [PATCH RFC 3/3] drm/exynos: use pending_components for components tracking

2014-04-25 Thread Andrzej Hajda
On 04/23/2014 07:13 PM, Russell King - ARM Linux wrote: On Wed, Apr 23, 2014 at 05:43:28PM +0100, Russell King - ARM Linux wrote: So, maybe you would like to finally address *my* point about TDA998x and your solution in a way that provides a satisfactory answer. *Show* how it can be done, or

Re: [PATCH RFC 3/3] drm/exynos: use pending_components for components tracking

2014-04-22 Thread Andrzej Hajda
Hi Russel, My answer little bit later due to Easter. On 04/18/2014 02:42 PM, Russell King - ARM Linux wrote: On Fri, Apr 18, 2014 at 01:27:53PM +0200, Andrzej Hajda wrote: Hi Russel, Thanks for comments. On 04/17/2014 11:47 PM, Russell King - ARM Linux wrote: On Thu, Apr 17, 2014 at 01:28

Re: [PATCH RFC 3/3] drm/exynos: use pending_components for components tracking

2014-04-22 Thread Andrzej Hajda
On 04/18/2014 02:46 PM, Russell King - ARM Linux wrote: On Fri, Apr 18, 2014 at 02:02:37PM +0200, Andrzej Hajda wrote: Separation of the interfaces exposed by the device from the device itself seems to me a good thing. I would even consider it as a biggest advantage of this solution

Re: [PATCH RFC 3/3] drm/exynos: use pending_components for components tracking

2014-04-23 Thread Andrzej Hajda
On 04/22/2014 01:51 PM, Russell King - ARM Linux wrote: On Tue, Apr 22, 2014 at 01:29:54PM +0200, Andrzej Hajda wrote: On 04/18/2014 02:46 PM, Russell King - ARM Linux wrote: On Fri, Apr 18, 2014 at 02:02:37PM +0200, Andrzej Hajda wrote: Separation of the interfaces exposed by the device from

[PATCH RFC 2/3] drivers/base: provide lightweight framework for componentized devices

2014-04-17 Thread Andrzej Hajda
components wants to become not-ready it adds again itself to the list and callback is fired to stop superdevice. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/base/Kconfig | 3 ++ drivers/base/Makefile | 1 + drivers/base/pending_components.c | 93

[PATCH RFC 0/3] drm/exynos: refactoring drm initialization/cleanup code

2014-04-17 Thread Andrzej Hajda
-next branch. Regards Andrzej Andrzej Hajda (3): drm/exynos: refactor drm drivers registration code drivers/base: provide lightweight framework for componentized devices drm/exynos: use pending_components for components tracking drivers/base/Kconfig| 3 + drivers

[PATCH RFC 1/3] drm/exynos: refactor drm drivers registration code

2014-04-17 Thread Andrzej Hajda
The patch removes driver registration code based on preprocessor conditionals. Instead it uses private linker section to create array of drm drivers. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- v2: - minor fixes of compilation issues --- drivers/gpu/drm/exynos/Makefile | 2

[PATCH RFC 3/3] drm/exynos: use pending_components for components tracking

2014-04-17 Thread Andrzej Hajda
of the changes is in exynos_drm_drv.c. Driver modifications are limited only to signal its readiness in probe and remove driver callbacks. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/Kconfig | 1 + drivers/gpu/drm/exynos/exynos_dp_core.c | 36

Re: [PATCH RFC 3/3] drm/exynos: use pending_components for components tracking

2014-04-18 Thread Andrzej Hajda
Hi Russel, Thanks for comments. On 04/17/2014 11:47 PM, Russell King - ARM Linux wrote: On Thu, Apr 17, 2014 at 01:28:50PM +0200, Andrzej Hajda wrote: +out: +if (ret != -EPROBE_DEFER) +exynos_drm_dev_ready(pdev-dev); So we end up with everyone needing a ready call in each

Re: [PATCH RFC 3/3] drm/exynos: use pending_components for components tracking

2014-04-18 Thread Andrzej Hajda
On 04/18/2014 12:04 AM, Russell King - ARM Linux wrote: On Thu, Apr 17, 2014 at 01:28:50PM +0200, Andrzej Hajda wrote: +static int exynos_drm_add_blocker(struct device *dev, void *data) +{ +struct device_driver *drv = data; + +if (!platform_bus_type.match(dev, drv

Re: [PATCH v3] vb2: Check if there are buffers before streamon

2014-04-01 Thread Andrzej Hajda
Hi, It seems the patch has been applied twice in linux-next/master: $ git log --oneline -25 linux-next/master drivers/media/v4l2-core/videobuf2-core.c 9cf3c31 [media] vb2: call buf_finish after the state check 3f1a9a3 [media] vb2: fix streamoff handling if streamon wasn't called e4d2581 [media]

Re: [PATCH 00/12] drm/exynos/ipp: image post processing improvements, part three

2014-07-21 Thread Andrzej Hajda
Hi Inki, On 07/09/2014 04:47 PM, Inki Dae wrote: On 2014년 07월 03일 22:10, Andrzej Hajda wrote: This set of independent patches contains various improvement and fixes for exynos_drm ipp framework. The patchset is based on exynos-drm-next branch. Did you test ipp module using libdrm? If so

Re: [PATCH 1/4] drm/dsi: Add flag for continuous clock behavior

2014-07-03 Thread Andrzej Hajda
Hi Alexandre, Thanks for the patch. On 07/02/2014 02:19 PM, Alexandre Courbot wrote: As per section 5.6.1 of the DSI specification, all DSI transmitters must support continuous clock behavior on the clock lane, while non-continuous mode support is only optional. Add a flag that allows

[PATCH 00/12] drm/exynos/ipp: image post processing improvements, part three

2014-07-03 Thread Andrzej Hajda
This set of independent patches contains various improvement and fixes for exynos_drm ipp framework. The patchset is based on exynos-drm-next branch. Regards Andrzej Andrzej Hajda (12): drm/exynos/ipp: remove type casting drm/exynos/ipp: remove unused field from exynos_drm_ipp_private drm

[PATCH 06/12] drm/exynos/ipp: remove incorrect checks of list_first_entry result

2014-07-03 Thread Andrzej Hajda
list_first_entry does not return NULL on empty list so this check does not make sense. Moreover there is already code which prevents calling list_first_entry on empty lists. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 15 --- 1 file

[PATCH 03/12] drm/exynos/ipp: remove struct exynos_drm_ipp_private

2014-07-03 Thread Andrzej Hajda
struct exynos_drm_ipp_private contains only one pointer so all occurrences of the struct can be replaced by the pointer itself. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 6 +- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 30

[PATCH 10/12] drm/exynos/ipp: remove redundant messages

2014-07-03 Thread Andrzej Hajda
In case of error callback prints already corresponding message. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu

[PATCH 12/12] drm/exynos/ipp: simplify ipp_find_driver

2014-07-03 Thread Andrzej Hajda
The patch puts repeated code sequence into one function, removes verbose comments and decreases log verbosity. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 74 ++--- 1 file changed, 21 insertions(+), 53 deletions

[PATCH 11/12] drm/exynos/ipp: simplify ipp_create_id

2014-07-03 Thread Andrzej Hajda
There is no gain in passing id by pointer to be filled. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 28 +--- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b

[PATCH 08/12] drm/exynos/ipp: remove useless registration checks

2014-07-03 Thread Andrzej Hajda
Argument checks are redundant, clients always check ippdrv before calling these functions. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu

[PATCH 05/12] drm/exynos/ipp: remove temporary variable

2014-07-03 Thread Andrzej Hajda
There is no reason to allocate intermediate variable. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos

[PATCH 09/12] drm/exynos/ipp: simplify ipp_find_obj

2014-07-03 Thread Andrzej Hajda
The patch simplifies ipp_find_obj and removes debug messages. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b

[PATCH 07/12] drm/exynos/ipp: simplify memory check function

2014-07-03 Thread Andrzej Hajda
The only thing function should check is if there are buffers in respective queues. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 44 - 1 file changed, 10 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 01/12] drm/exynos/ipp: remove type casting

2014-07-03 Thread Andrzej Hajda
The patch replaces type casting with proper pointer. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c

[PATCH 04/12] drm/exynos/ipp: correct address type

2014-07-03 Thread Andrzej Hajda
exynos_drm_gem_get_dma_addr returns dma_addr_t, type casting to void* and back is not necessary. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos

[PATCH 02/12] drm/exynos/ipp: remove unused field from exynos_drm_ipp_private

2014-07-03 Thread Andrzej Hajda
The patch removes unused event_list field from struct exynos_drm_ipp_private. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 1 - drivers/gpu/drm/exynos/exynos_drm_ipp.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/gpu/drm/exynos

Re: [PATCH 1/4] drm/dsi: Add flag for continuous clock behavior

2014-07-04 Thread Andrzej Hajda
On 07/04/2014 07:57 AM, Alexandre Courbot wrote: Hi Andrejz, On Thu, Jul 3, 2014 at 5:23 PM, Andrzej Hajda a.ha...@samsung.com wrote: Hi Alexandre, Thanks for the patch. On 07/02/2014 02:19 PM, Alexandre Courbot wrote: As per section 5.6.1 of the DSI specification, all DSI transmitters

Re: [PATCH 03/15] drm/exynos/ipp: move file reference from memory to command node

2014-08-26 Thread Andrzej Hajda
Hi Joonyoung, Thanks for review. On 08/26/2014 04:59 AM, Joonyoung Shim wrote: On 08/26/2014 11:55 AM, Joonyoung Shim wrote: Hi Andrzej, On 08/22/2014 04:52 PM, Andrzej Hajda wrote: Command node should contain file reference to distinguish commands created by different processes. Signed

Re: [PATCH 14/15] drm/exynos/fimc: simplify buffer queuing

2014-08-26 Thread Andrzej Hajda
On 08/26/2014 07:53 AM, Joonyoung Shim wrote: Hi Andrzej, On 08/22/2014 04:52 PM, Andrzej Hajda wrote: The patch removes redundant checks, redundant HW reads and simplifies code. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 64

Re: [PATCH 15/15] drm/exynos/fimc: fix source buffer registers

2014-08-26 Thread Andrzej Hajda
On 08/26/2014 07:57 AM, Joonyoung Shim wrote: Hi Andrzej, On 08/22/2014 04:52 PM, Andrzej Hajda wrote: FIMC in default mode of operation uses only one input buffer, but the driver used also second buffer, as a result only the first frame was processed correctly. The patch fixes it. I can't

Re: [PATCH 06/15] drm/exynos/ipp: free partially allocated resources on error

2014-08-27 Thread Andrzej Hajda
On 08/26/2014 07:00 AM, Joonyoung Shim wrote: Hi Andrzej, On 08/22/2014 04:52 PM, Andrzej Hajda wrote: In case of allocation errors some already allocated buffers were not freed. The patch fixes it. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos

[PATCH v2 14/15] drm/exynos/fimc: simplify buffer queuing

2014-08-27 Thread Andrzej Hajda
The patch removes redundant checks, redundant HW reads and simplifies code. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- v2: - fixed bit cleaning operation --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 64 1 file changed, 15 insertions(+), 49 deletions

Re: [PATCH v4 00/11] drm: add support for Atmel HLCDC Display Controller

2014-08-21 Thread Andrzej Hajda
On 08/21/2014 11:41 AM, Boris BREZILLON wrote: On Thu, 21 Aug 2014 11:04:07 +0200 Thierry Reding thierry.red...@gmail.com wrote: On Thu, Aug 21, 2014 at 10:37:06AM +0200, Boris BREZILLON wrote: Hi Ludovic, On Thu, 21 Aug 2014 10:16:19 +0200 Ludovic Desroches ludovic.desroc...@atmel.com

Re: [PATCH v4 00/11] drm: add support for Atmel HLCDC Display Controller

2014-08-21 Thread Andrzej Hajda
On 08/21/2014 11:52 AM, Thierry Reding wrote: On Thu, Aug 21, 2014 at 11:41:59AM +0200, Boris BREZILLON wrote: On Thu, 21 Aug 2014 11:04:07 +0200 Thierry Reding thierry.red...@gmail.com wrote: On Thu, Aug 21, 2014 at 10:37:06AM +0200, Boris BREZILLON wrote: Hi Ludovic, On Thu, 21 Aug 2014

Re: [PATCH v4 00/11] drm: add support for Atmel HLCDC Display Controller

2014-08-21 Thread Andrzej Hajda
On 08/21/2014 03:21 PM, Thierry Reding wrote: On Thu, Aug 21, 2014 at 12:32:43PM +0200, Andrzej Hajda wrote: On 08/21/2014 11:52 AM, Thierry Reding wrote: On Thu, Aug 21, 2014 at 11:41:59AM +0200, Boris BREZILLON wrote: On Thu, 21 Aug 2014 11:04:07 +0200 Thierry Reding thierry.red

Re: [PATCH v4 00/11] drm: add support for Atmel HLCDC Display Controller

2014-08-21 Thread Andrzej Hajda
On 08/21/2014 05:30 PM, Boris BREZILLON wrote: On Thu, 21 Aug 2014 17:04:34 +0200 Andrzej Hajda a.ha...@samsung.com wrote: On 08/21/2014 03:21 PM, Thierry Reding wrote: On Thu, Aug 21, 2014 at 12:32:43PM +0200, Andrzej Hajda wrote: On 08/21/2014 11:52 AM, Thierry Reding wrote: On Thu, Aug

[PATCH 00/15] drm/exynos/ipp: image post processing fixes and improvements, part four

2014-08-22 Thread Andrzej Hajda
This set of patches contains various improvement and fixes for exynos_drm ipp framework. The patchset is based on exynos-drm-next branch. IPP framework was tested for regressions on exynos4210-trats target. Regards Andrzej Andrzej Hajda (15): drm/exynos/ipp: remove fake pm callbacks drm

[PATCH 04/15] drm/exynos/ipp: remove only related commands on file close

2014-08-22 Thread Andrzej Hajda
On file close driver should remove only command nodes created via this file. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu

[PATCH 08/15] drm/exynos/ipp: clean memory nodes on command node cleaning

2014-08-22 Thread Andrzej Hajda
The nodes should be removed before removing command node. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c index

[PATCH 12/15] drm/exynos/fimc: avoid clearing overflow bits

2014-08-22 Thread Andrzej Hajda
Overflow bits shall be cleared by H/W. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c index 3264ed3..bbaf4f9

[PATCH 15/15] drm/exynos/fimc: fix source buffer registers

2014-08-22 Thread Andrzej Hajda
FIMC in default mode of operation uses only one input buffer, but the driver used also second buffer, as a result only the first frame was processed correctly. The patch fixes it. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 16

[PATCH 14/15] drm/exynos/fimc: simplify buffer queuing

2014-08-22 Thread Andrzej Hajda
The patch removes redundant checks, redundant HW reads and simplifies code. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 64 1 file changed, 15 insertions(+), 49 deletions(-) diff --git a/drivers/gpu/drm/exynos

[PATCH 13/15] drm/exynos/fimc: do not enable fimc twice

2014-08-22 Thread Andrzej Hajda
The patch removes redundant H/W activation. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c

[PATCH 10/15] drm/exynos/ipp: stop hardware before freeing memory

2014-08-22 Thread Andrzej Hajda
Memory shouldn't be freed when hardware is still running. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm

[PATCH 09/15] drm/exynos/ipp: replace work_struct casting with better constructs

2014-08-22 Thread Andrzej Hajda
Type casting should be avoided if possible. In case of work_struct it can be simply replaced by reference to member field. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c| 2 +- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 3 +-- drivers/gpu/drm

[PATCH 05/15] drm/exynos/ipp: remove unused field in command node

2014-08-22 Thread Andrzej Hajda
Since command node have file pointer dev field became useless. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 1 - drivers/gpu/drm/exynos/exynos_drm_ipp.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c

  1   2   3   4   5   6   7   8   >