Re: Regression caused by commit 4bdc33ed ("NFSDv4.2: Add NFS v4.2 support to the NFS server")

2013-09-25 Thread Anna Schumaker
Hi Jongman, Is the panic on your client or server? I don't see how the patch your bisect led you to could cause the problem, since all it does is expand the minor version array on the server. Your client doesn't have NFSD enabled, so this code shouldn't even be affecting it. A few questions: w

Re: [RFC] extending splice for copy offloading

2013-09-25 Thread Anna Schumaker
On Wed, Sep 25, 2013 at 2:38 PM, Zach Brown wrote: > > Hrmph. I had composed a reply to you during Plumbers but.. something > happened to it :). Here's another try now that I'm back. > >> > Some things to talk about: >> > - I really don't care about the naming here. If you do, holler. >> > - We

Re: [PATCH] nfs: add missing CONFIG_MIGRATION for nfs_migrate_page

2016-09-19 Thread Anna Schumaker
Hi Chao, On 09/19/2016 08:09 AM, Chao Yu wrote: > We'd better to use CONFIG_MIGRATION to cover nfs_migrate_page, otherwise > when CONFIG_MIGRATION is not defined, unused nfs_migrate_page will still > be compiled into kernel. I don't think that nfs_migrate_page is still compiled into the kernel wh

Re: NFS/d_splice_alias breakage

2016-06-20 Thread Anna Schumaker
Hi, On 06/20/2016 10:08 AM, Al Viro wrote: > On Mon, Jun 20, 2016 at 09:25:12AM -0400, Oleg Drokin wrote: >> It looks like this patch was totally forgotten? >> I don't see it in neither vfs nor nfs trees and yet it fixes a very easy to >> cause >> crash in nfs code. And I think it's unrelated to

Re: [PATCH 0/2] NFS: Use complete() instead complete_all()

2016-09-23 Thread Anna Schumaker
Hi Daniel, On 09/22/2016 07:54 AM, Daniel Wagner wrote: > From: Daniel Wagner > > Hi, > > Using complete_all() is not wrong per se but it suggest that there > might be more than one waiter. For -rt I am reviewing all > complete_all() users and would like to leave only the real ones in the > tre

Re: [PATCH 0/2] NFS: Use complete() instead complete_all()

2016-09-26 Thread Anna Schumaker
On 09/26/2016 01:33 AM, Daniel Wagner wrote: > Hi Anna, > > On 09/23/2016 03:48 PM, Anna Schumaker wrote: >>> Besides trying to analys all the code paths to the wait_for_completion() >>> call and convince myself that there is only one waiter, I also run >>&

Re: 答复: [PATCH] sunrpc: queue work on system_power_efficient_wq

2016-09-26 Thread Anna Schumaker
; > Thanks, > Ke > ____ > 发件人: Anna Schumaker > 发送时间: 2016年9月2日 2:46 > 收件人: Chunyan Zhang; trond.mykleb...@primarydata.com; > anna.schuma...@netapp.com; da...@davemloft.net > 抄送: linux-...@vger.kernel.org; net...@vger.kernel.org; > linux-kernel@vg

Re: [PATCH 0/2] NFS: Use complete() instead complete_all()

2016-09-27 Thread Anna Schumaker
On 09/27/2016 04:33 AM, Daniel Wagner wrote: > On 09/27/2016 09:42 AM, Daniel Wagner wrote: >> Failures: generic/035 generic/087 generic/088 generic/089 generic/126 >> generic/184 generic/285 generic/347 generic/350 >> Failed 9 of 62 tests >> >> Hmm, not sure if this good or bad. Does it help? >

Re: [PATCH] sunrpc: queue work on system_power_efficient_wq

2016-09-01 Thread Anna Schumaker
On 09/01/2016 03:30 AM, Chunyan Zhang wrote: > From: Ke Wang > > sunrpc uses workqueue to clean cache regulary. There is no real dependency > of executing work on the cpu which queueing it. > > On a idle system, especially for a heterogeneous systems like big.LITTLE, > it is observed that the bi

Re: [PATCH] sunrpc: Remove unnecessary variable

2016-08-08 Thread Anna Schumaker
On 08/08/2016 05:13 AM, Amitoj Kaur Chawla wrote: > The variable `err` is not used anywhere and just returns the > predefined value `0` at the end of the function. Hence, remove the > variable and return 0 explicitly. Makes sense to me. Thanks! Anna > > Signed-off-by: Amitoj Kaur Chawla > ---

Re: [PATCH v10 44/46] nfs: Add richacl support

2015-10-12 Thread Anna Schumaker
Hi Andreas, On 10/11/2015 06:58 PM, Andreas Gruenbacher wrote: > From: Andreas Gruenbacher > > Add support for the "system.richacl" xattr in nfs. The existing > "system.nfs4_acl" xattr on nfs doesn't map user and group names to uids > and gids; the "system.richacl" xattr does, and only keeps th

Re: linux-next: build warning after merge of the nfs-anna tree

2018-07-31 Thread Anna Schumaker
Hi David, On 07/31/2018 05:04 AM, David Wysochanski wrote: > On Mon, 2018-07-30 at 18:52 +1000, Stephen Rothwell wrote: >> Hi all, >> >> After merging the nfs-anna tree, today's linux-next build (powerpc >> ppc44x_defconfig, sparc defconfig) produced this warning: >> >> net/sunrpc/stats.c: In func

Re: [RFC][PATCH 00/14] VFS: Introduce superblock configuration context [ver #2]

2017-05-11 Thread Anna Schumaker
Hi David, On 05/11/2017 09:59 AM, David Howells wrote: > > Here are a set of patches to create a superblock configuration context > prior to setting up a new mount, populating it with the parsed > options/binary data, creating the superblock and then effecting the mount. > > This allows namespac

Re: [RFC][PATCH 00/14] VFS: Introduce superblock configuration context [ver #2]

2017-05-12 Thread Anna Schumaker
On 05/11/2017 03:24 PM, David Howells wrote: > Anna Schumaker wrote: > >> Is there any way to split the NFS patch into multiple pieces? > > Are you okay with a patch or two that add code that is unconnected in that > patch, but connected in a later one? Yes, I'm o

Re: linux-next: bad commits in the nfs-anna tree

2018-04-06 Thread Anna Schumaker
On 04/05/2018 05:43 PM, Stephen Rothwell wrote: > Hi all, > > It looks like part of Linus' tree has been rebased into the nfs-anna tree ... > commits > > 4c8936622a01 ("btrfs: use kvzalloc to allocate btrfs_fs_info") > to > 8f1cd0ae48f5 ("Linux 4.16-rc4") > > in the nfs-anna tree are the

Re: [GIT PULL] Please pull NFS client updates for 4.17

2018-04-12 Thread Anna Schumaker
Hi Linus, What's the status of this? I don't see the NFS changes in your tree yet, and I'm worried the pull request email got lost somewhere along the way. Cheers, Anna On 04/10/2018 04:47 PM, Anna Schumaker wrote: > Hi Linus, > > The follow

Re: [GIT PULL] Please pull NFS client updates for 4.17

2018-04-12 Thread Anna Schumaker
On 04/12/2018 02:19 PM, Linus Torvalds wrote: > On Thu, Apr 12, 2018 at 11:13 AM, Anna Schumaker > wrote: >> Hi Linus, >> >> What's the status of this? I don't see the NFS changes in your tree yet, >> and I'm worried the pull request email got lost

Re: [md PATCH 0/4] Minor 'cred' improvements prepare for NFS conversion

2018-03-21 Thread Anna Schumaker
On 01/31/2018 12:15 AM, NeilBrown wrote: > Hi, > NFS and SUNRPC have an internal "rpc_cred" which plays two distinct > roles, one of which is much the same as 'struct cred' (which didn't > exist when rpc_cred was created). > I want to replace that usage of rpc_cred with 'struct cred'. > Doin

Re: linux-next: please clean up the nfs-anna tree

2018-03-21 Thread Anna Schumaker
On 03/20/2018 08:11 PM, Stephen Rothwell wrote: > Hi all, > > It only seems to contain commits that have been upsreamed as different > commits and is causing conflicts: > > CONFLICT (content): Merge conflict in net/sunrpc/xprtrdma/transport.c > CONFLICT (content): Merge conflict in net/sunrpc/x

[GIT PULL] Please pull NFS client updates for 4.17

2018-04-10 Thread Anna Schumaker
Hi Linus, The following changes since commit 661e50bc853209e41a5c14a290ca4decc43cbfd1: Linux 4.16-rc4 (2018-03-04 14:54:11 -0800) are available in the Git repository at: git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.17-1 for you to fetch changes up to 98de9ce6f6660d02a

Re: linux-next: build failure after merge of the nfs-anna tree

2018-12-17 Thread Anna Schumaker
On Mon, 2018-12-17 at 12:18 +0100, Rasmus Villemoes wrote: > On 17/12/2018 00.16, Stephen Rothwell wrote: > > Hi all, > > > > After merging the nfs-anna tree, today's linux-next build (arm > > multi_v7_defconfig) failed like this: > > > > /home/sfr/next/next/fs/nfs/nfsroot.c: In function 'root_nf

Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices

2021-02-16 Thread Anna Schumaker
On Tue, Feb 16, 2021 at 2:22 PM Amir Goldstein wrote: > > On Tue, Feb 16, 2021 at 8:54 PM Luis Henriques wrote: > > > > Amir Goldstein writes: > > > > > On Tue, Feb 16, 2021 at 6:41 PM Luis Henriques wrote: > > >> > > >> Amir Goldstein writes: > > >> > > >> >> Ugh. And I guess overlayfs may h

Re: [PATCH v2 3/5] nfs: don't dirty ITER_BVEC pages read through direct I/O

2015-01-05 Thread Anna Schumaker
Hi Omar, On 12/19/2014 10:18 PM, Omar Sandoval wrote: > As with the generic blockdev code, kernel pages shouldn't be dirtied by > the direct I/O path. > > Signed-off-by: Omar Sandoval > --- > fs/nfs/direct.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/nfs/di

Re: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper

2015-04-14 Thread Anna Schumaker
On 04/14/2015 12:53 PM, Christoph Hellwig wrote: > On Sat, Apr 11, 2015 at 09:04:02AM -0400, Jeff Layton wrote: >> Yuck! How the heck do you clean up the mess if that happens? I guess >> you're just stuck redoing the copy with normal READ/WRITE? >> >> Maybe we need to have the interface return a ha

Re: [PATCH 4/5] SUNRPC: track when a client connection is routed to the local host.

2014-04-23 Thread Anna Schumaker
On 04/22/2014 10:40 PM, NeilBrown wrote: > If requests are being sent to the local host, then NFS will > need to take care to avoid deadlocks. > > So keep track when accepting a connection or sending a UDP request > and set a flag in the svc_xprt when the peer connected to is local. > > The interfa

Re: [PATCH 4/5] SUNRPC: track when a client connection is routed to the local host.

2014-04-24 Thread Anna Schumaker
On 04/23/2014 07:14 PM, NeilBrown wrote: > On Wed, 23 Apr 2014 09:44:12 -0400 Anna Schumaker > wrote: > >> On 04/22/2014 10:40 PM, NeilBrown wrote: >>> If requests are being sent to the local host, then NFS will >>> need to take care to avoid deadlocks. >&

Re: [PATCH 3/4] NFS: avoid deadlocks with loop-back mounted NFS filesystems.

2014-09-16 Thread Anna Schumaker
On 09/16/2014 01:31 AM, NeilBrown wrote: > Support for loop-back mounted NFS filesystems is useful when NFS is > used to access shared storage in a high-availability cluster. > > If the node running the NFS server fails, some other node can mount the > filesystem and start providing NFS service. I

Re: linux-next: bad commits in the nfs tree

2014-06-04 Thread Anna Schumaker
Linux 3.15-rc8 >> 2b267bb3a8e5powerpc: Wire renameat2() syscall >> >> These are part of a branch that you merged from Anna Schumaker. It >> looks like they may have been included when Anna was trying to rebase >> the rest of the branch onto v3.15-rc8? >>

Re: [RFC] extending splice for copy offloading

2013-12-18 Thread Anna Schumaker
On 12/18/2013 12:10 PM, Zach Brown wrote: > On Wed, Dec 18, 2013 at 04:41:26AM -0800, Christoph Hellwig wrote: >> On Wed, Sep 11, 2013 at 10:06:47AM -0700, Zach Brown wrote: >>> When I first started on this stuff I followed the lead of previous >>> work and added a new syscall for the copy operatio

Re: [PATCH v5 39/39] nfs: Add support for the v4.1 dacl attribute

2015-07-22 Thread Anna Schumaker
Hi Andreas, On 07/22/2015 09:03 AM, Andreas Gruenbacher wrote: > From: Andreas Gruenbacher > > The dacl attribute includes Automatic Inheritance flags not supported by the > acl attribute. it is only supported in NFS version 4.1 and higher. On > systems > where NFS version 4.0 is still the de

Re: linux-next: build failure after merge of the nfs tree

2016-05-19 Thread Anna Schumaker
On 05/19/2016 08:06 AM, Trond Myklebust wrote: > Thanks Stephen! > > Anna will be managing pushing the NFS client changes to Linus during > this merge window, so I'm assuming she will include this and your > other fixup in her pull request. Yep! I'll make sure it's in there. Anna > > Cheers >

[GIT PULL] Please pull NFS client changes for Linux 4.7

2016-05-26 Thread Anna Schumaker
reference. Thanks, Anna ---- Anna Schumaker (2): NFS: Add nfs_commit_file() NFS: Add COPY nfs operation Benjamin Coddington (1): SUNRPC: init xdr_stream for zero iov_len, page_len Chuck Lever (21): NFS: Fix an LOCK

Re: [PATCH] xprtrdma: add missing curly braces, set rc to zero on non-zero

2015-12-02 Thread Anna Schumaker
On 11/24/2015 06:11 PM, Colin King wrote: > From: Colin Ian King > > Add the missing curly braces so that rc is only set to zero when > it is non-zero. Without this minor fix, rc is set to zero even > when it is zero, which is slightly redundant. > > Detected with smatch static analysis. Thank

Re: [REGRESSION v5.2-rc] SUNRPC: Declare RPC timers as TIMER_DEFERRABLE (431235818bc3)

2019-06-18 Thread Anna Schumaker
On Tue, 2019-06-18 at 10:35 +0100, Jon Hunter wrote: > Trond, Anna, > > On 12/06/2019 15:23, Jon Hunter wrote: > > On 05/06/2019 23:01, Trond Myklebust wrote: > > > > ... > > > > > I'd be OK with just reverting this patch if it is causing a > > > performance > > > issue. > > > > > > Anna? > >

[GIT PULL] Please pull additional NFS client fixes for 5.0

2019-02-15 Thread Anna Schumaker
Hi Linus, The following changes since commit 8fc75bed96bb94e23ca51bd9be4daf65c57697bf: NFS: Fix up return value on fatal errors in nfs_page_async_flush() (2019-01-29 16:33:24 -0500) are available in the Git repository at: git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-5.

Re: [PATCH] NFSv4.x: hide array-bounds warning

2016-11-22 Thread Anna Schumaker
Thanks, Arnd! I'll send it for 4.9 Anna On 11/22/2016 03:50 PM, Arnd Bergmann wrote: > A correct bugfix introduced a harmless warning that shows up with gcc-7: > > fs/nfs/callback.c: In function 'nfs_callback_up': > fs/nfs/callback.c:214:14: error: array subscript is outside array bounds > [-W

[GIT PULL] Please pull more NFS client bugfixes for 4.9

2016-11-23 Thread Anna Schumaker
Hi Linus, The following changes since commit 62bdf94a2049822ef8c6d4b0e83cd9c3a1663ab4: xprtrdma: Fix DMAR failure in frwr_op_map() after reconnect (2016-11-10 11:04:54 -0500) are available in the git repository at: git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.9-4 for

Re: [PATCH] Fix NULL pointer dereference in bl_free_device().

2016-07-19 Thread Anna Schumaker
Hi Artem, On 07/19/2016 07:30 AM, Artem Savkov wrote: > When bl_parse_deviceid() fails in bl_alloc_deviceid_node() on > blkdev_get_by_*() step we get an pnfs_block_dev struct that is > uninitialized except for bdev field which is set to whatever error > blkdev_get_by_*() returns. bl_free_device()

Re: [PATCH] Fix NULL pointer dereference in bl_free_device().

2016-07-19 Thread Anna Schumaker
Hi Artem, On 07/19/2016 07:30 AM, Artem Savkov wrote: > When bl_parse_deviceid() fails in bl_alloc_deviceid_node() on > blkdev_get_by_*() step we get an pnfs_block_dev struct that is > uninitialized except for bdev field which is set to whatever error > blkdev_get_by_*() returns. bl_free_device()

Re: [PATCH 18/21] fs: nfs: Make nfs boot time y2038 safe

2016-06-10 Thread Anna Schumaker
On 06/09/2016 05:10 PM, Deepa Dinamani wrote: >>> boot_time is represented as a struct timespec. >>> struct timespec and CURRENT_TIME are not y2038 safe. >>> Overall, the plan is to use timespec64 for all internal >>> kernel representation of timestamps. >>> CURRENT_TIME will also be removed. >>> U

Re: [PATCH] net/netfiliter: Fix used uninitialized warn in ip_vs_proc_sync_conn()

2016-11-07 Thread Anna Schumaker
Hi Shuah, On 11/07/2016 10:41 AM, Shuah Khan wrote: > Fix the following warn: > > net/netfilter/ipvs/ip_vs_sync.c: In function ‘ip_vs_proc_sync_conn’: > net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘opt.init_seq’ may be used > uninitialized in this function [-Wmaybe-uninitialized] >st

Re: net/sunrpc/clnt.c:2773 suspicious rcu_dereference_check() usage!

2016-11-08 Thread Anna Schumaker
42.750701] [] ? nfs_clone_super+0x130/0x130 >>> [ 42.750713] [] ? param_set_portnr+0x70/0x70 >>> [ 42.750726] [] mount_fs+0x39/0x170 >>> [ 42.750740] [] vfs_kern_mount+0x6b/0x150 >>> [ 42.750752] [] do_mount+0x1f1/0xd10 >>> [ 42.750765] [] ? co

Re: net/sunrpc/clnt.c:2773 suspicious rcu_dereference_check() usage!

2016-11-08 Thread Anna Schumaker
On 11/08/2016 12:43 PM, Ross Zwisler wrote: > On Tue, Nov 08, 2016 at 07:42:59AM -0500, Anna Schumaker wrote: >> On 11/08/2016 07:09 AM, Jeff Layton wrote: >>> On Tue, 2016-11-08 at 06:53 -0500, Jeff Layton wrote: >>>> On Mon, 2016-11-07 at 22:42 -0700, Ross Zwisler

[GIT PULL] Please pull NFS client changes for Linux 4.9

2016-10-13 Thread Anna Schumaker
Hi Linus, The following changes since commit 3be7988674ab33565700a37b210f502563d932e6: Linux 4.8-rc7 (2016-09-18 17:27:41 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.9-1 for you to fetch changes up to 3f807e5ae5597bd65a6

Re: [BUG] Suspicious RCU usage: NFS client - 4.9-rc4

2016-11-15 Thread Anna Schumaker
Hi Russel, On 11/15/2016 10:07 AM, Russell King - ARM Linux wrote: > While booting two of my machines, I noticed this splat on the console. > Not sure if this is due to a RCU change or NFS change, so adding folk > on both sides. The patch to fix this went into rc5 :) Thanks for reporting! Anna

[GIT PULL] Please pull NFS client bugfixes

2016-10-21 Thread Anna Schumaker
Hi Linus, The following changes since commit 3f807e5ae5597bd65a6fff684083e8eaa21f3fa7: NFSv4.2: Fix a reference leak in nfs42_proc_layoutstats_generic (2016-10-04 16:30:54 -0400) are available in the git repository at: git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.9-2

[GIT PULL] Please pull a few more NFS client bugfixes

2016-11-10 Thread Anna Schumaker
Anna Schumaker (2): SUNRPC: Fix suspicious RCU usage NFS: Don't print a pNFS error if we aren't using pNFS Arnd Bergmann (1): NFSv4.1: work around -Wmaybe-uninitialized warning Benjamin Coddington (1): NFS: Trim extra slash in v4 nfs_p

Re: BUG: User triggerable kernel panic in 4.8 (possibly 4.9)

2016-11-29 Thread Anna Schumaker
Hi Darren, On 11/29/2016 03:40 AM, Jan Kara wrote: > Hello, > > Thanks for report. I suspect this bug got lost in the noise of > linux-kernel. Adding more relevant lists and people to CC. > > Honza > > On Thu 20-10-16 15:24:37, Darre

[GIT PULL] Please pull NFS client bugfixes for 4.11

2017-03-17 Thread Anna Schumaker
Hi Linus, The following changes since commit ed92d8c137b7794c2c2aa14479298b9885967607: NFSv4: fix getacl ERANGE for some ACL buffer sizes (2017-02-23 17:23:35 -0500) are available in the git repository at: git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.11-2 for you to f

[GIT PULL] Please pull NFS client changes for Linux 4.11

2017-03-01 Thread Anna Schumaker
unrpc Thanks, Anna ---- Anna Schumaker (21): NFS: Move nfs4_get_session() into nfs4_session.h NFS: Change nfs4_get_session() to take an nfs_client structure NFS: Change nfs4_setup_sequence() to take an nfs_client structure NFS: Use nfs4_setup_s

[GIT PULL] Please pull NFS client bugfixes for 4.7

2016-06-29 Thread Anna Schumaker
Hi Linus, The following changes since commit 33688abb2802ff3a230bd2441f765477b94cc89e: Linux 4.7-rc4 (2016-06-19 21:30:02 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.7-2 for you to fetch changes up to e547f2628327fec6afd

Re: [GIT PULL] please pull file-locking related changes for v4.2

2015-07-14 Thread Anna Schumaker
r > nasty. So I suggest we merge this and if he raises issues with it we > can sort it out when he gets back. This looks reasonable to me, especially since Bruce and Dane have commented that it fixes their bugs. Is my acked-by good enough? :) Acked-by: Anna Schumaker > >

Re: linux-next: manual merge of the rdma tree with the nfsd tree

2016-01-06 Thread Anna Schumaker
nux-nfs was not included on that e-mail at all. > Did Anna ever reply with an Acked-by ? I don't see > that in either the archive or my own inbox. I'm not sure if I ever replied to that one. This patch was part of an alternative to Christoph's deviceattr cleanup, right? The N

[GIT PULL] Please pull NFS Client Updates for v5.10

2020-10-20 Thread Anna Schumaker
with HTTPS ones: NFS, SUNRPC, and LOCKD clients Anna Schumaker (10): SUNRPC: Split out a function for setting current page SUNRPC: Implement a xdr_page_pos() function NFS: Use xdr_page_pos() in NFSv4 decode_getacl() NFS: Add READ_PLUS data segment support SU

Re: [PATCH] xprtrdma: fix incorrect header size calcations

2020-07-15 Thread Anna Schumaker
No need for a v2, I can fix it up! On Wed, Jul 15, 2020 at 12:32 PM Colin Ian King wrote: > > Bah, $SUBJECT typo "calcations" -> "calculations". can that be fixed up > when it's applied, or shall I send a V2? > > On 15/07/2020 17:26, Colin King wrote: > > From: Colin Ian King > > > > Currently

Re: [PATCH 2/5] fs,nfs: lift compat nfs4 mount data handling into the nfs code

2020-09-21 Thread Anna Schumaker
This is for the binary mount stuff? That was already legacy code when I first started, and mount uses text options now. My preference is for keeping it as close to the original code as possible. I'm curious if you've been able to test this? I'm not sure if there is a way to force binary mount data

Re: [PATCH v3] nfs: remove incorrect fallthrough label

2020-09-24 Thread Anna Schumaker
On Thu, Sep 24, 2020 at 2:08 PM Joe Perches wrote: > > On Thu, 2020-09-24 at 10:40 -0700, Joe Perches wrote: > > On Thu, 2020-09-24 at 10:19 -0700, Nick Desaulniers wrote: > > > Hello maintainers, > > > Would you mind please picking up this patch? KernelCI has been > > > erroring for over a week

Re: [PATCH 1/1 linux-next] nfs: kmap can't fail

2017-04-25 Thread Anna Schumaker
Hi Fabian, On 04/25/2017 02:10 PM, Fabian Frederick wrote: > Remove NULL test on kmap() > > Signed-off-by: Fabian Frederick > --- > fs/nfs/dir.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c > index 3a188cb..f89e54c 100644 > --- a/fs/nfs/dir.c > +++ b/fs

Re: [PATCH] NFS: fix usage of mempools.

2017-04-10 Thread Anna Schumaker
Hi Neil, On 04/09/2017 10:22 PM, NeilBrown wrote: > > When passed GFP flags that allow sleeping (such as > GFP_NOIO), mempool_alloc() will never return NULL, it will > wait until memory is available. > > This means that we don't need to handle failure, but that we > do need to ensure one thread

Re: patch to candidate for stable kernel 4.10

2017-04-11 Thread Anna Schumaker
y message - > From: "Greg KH" > To: "Mkrtchyan, Tigran" , "Anna Schumaker" > > Cc: , > Subject: patch to candidate for stable kernel 4.10 > Date: Sun, Apr 9, 2017 21:14 > > > On Sun, Apr 09, 2017 at 11:36:30AM +0

[GIT PULL] Please pull a few more NFS client bugfixes for 4.11

2017-03-31 Thread Anna Schumaker
Hi Linus, The following changes since commit da066f3f039eba3e72e97b2ccad0dd8b45ba84bd: pNFS/flexfiles: never nfs4_mark_deviceid_unavailable (2017-03-17 16:07:17 -0400) are available in the git repository at: git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.11-3 for you t

[GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-13 Thread Anna Schumaker
g choice! Cheers, Anna ---- Anna Schumaker (1): NFS: Set FATTR4_WORD0_TYPE for . and .. entries Benjamin Coddington (3): NFS: convert flags to bool NFS: nfs_rename() - revalidate directories on -ERESTARTSYS NFS

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Anna Schumaker
On 07/14/2017 03:09 AM, Christoph Hellwig wrote: > On Thu, Jul 13, 2017 at 02:43:14PM -0700, Linus Torvalds wrote: >> On Thu, Jul 13, 2017 at 2:16 PM, Anna Schumaker >> wrote: >>> >>> git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1

[GIT PULL] Please pull NFS client fixes for 4.13

2017-07-21 Thread Anna Schumaker
Hi Linus, The following changes since commit 5b5faaf6df73412af0278997db36dbcb51011d9d: nfs4: add NFSv4 LOOKUPP handlers (2017-07-13 16:00:15 -0400) are available in the git repository at: git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-2 for you to fetch changes up to

[GIT PULL] Please pull NFS client bugfixes for 4.15

2017-12-15 Thread Anna Schumaker
Hi Linus, The following changes since commit eb5b46faa693470681ec7c28cc2436edd1571198: SUNRPC: Handle ENETDOWN errors (2017-11-30 11:52:52 -0500) are available in the Git repository at: git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.15-3 for you to fetch changes up to 9

[GIT PULL] Please pull a few more NFS client fixes for 4.13

2017-08-11 Thread Anna Schumaker
Hi Linus, The following changes since commit d9cb73300ac0001832c048a489c592263fc28193: NFSv4: Fix double frees in nfs4_test_session_trunk() (2017-08-02 09:45:55 -0400) are available in the g

[GIT PULL] Please pull a few more NFS client fixes for 4.13

2017-07-28 Thread Anna Schumaker
xes: - Don't excessively generate tiny writes with fallocate - Use the raw NFS access mask in nfs4_opendata_access() Thanks, Anna ---- Anna Schumaker (1): NFS: Use raw NFS access mask in nfs4_opendat

Re: [RFC PATCH] NFS: Fix the access mask checks in NFSv4

2017-07-31 Thread Anna Schumaker
Hi Catalin, On 07/31/2017 07:19 AM, Catalin Marinas wrote: > Anna, Trond, > > On Fri, Jul 28, 2017 at 06:54:52PM +0100, Catalin Marinas wrote: >> --- a/fs/nfs/nfs4proc.c >> +++ b/fs/nfs/nfs4proc.c >> @@ -2236,7 +2236,7 @@ static int nfs4_opendata_access(struct rpc_cred *cred, >>

[GIT PULL] Please pull two more NFS client fixes for 4.13

2017-08-02 Thread Anna Schumaker
Hi Linus, The following changes since commit b7dbcc0e433f0f61acb89ed9861ec996be4f2b38: NFSv4.1: Fix a race where CB_NOTIFY_LOCK fails to wake a waiter (2017-07-28 15:35:30 -0400) are available in the git repository at: git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-4

Re: [PATCH 24/27] NFS: Add fs_context support. [ver #5]

2017-06-15 Thread Anna Schumaker
Hi David, Several comments below: On 06/14/2017 11:18 AM, David Howells wrote: > Add filesystem context support to NFS, parsing the options in advance and > attaching the information to struct nfs_fs_context. The highlights are: > > (*) Merge nfs_mount_info and nfs_clone_mount into nfs_fs_cont

Re: [REGRESSION 4.13-rc] NFS returns -EACCESS at the first read

2017-07-26 Thread Anna Schumaker
Hi Takashi, On 07/26/2017 08:54 AM, Takashi Iwai wrote: > Hi, > > I seem hitting a regression of NFS client on the today's Linus git > tree. The symptom is that the file read over NFS returns occasionally > -EACCESS at the first read. When I try to read the same file again > (or do some other t

Re: [REGRESSION 4.13-rc] NFS returns -EACCESS at the first read

2017-07-26 Thread Anna Schumaker
On 07/26/2017 09:30 AM, Takashi Iwai wrote: > On Wed, 26 Jul 2017 14:57:07 +0200, > Anna Schumaker wrote: >> >> Hi Takashi, >> >> On 07/26/2017 08:54 AM, Takashi Iwai wrote: >>> Hi, >>> >>> I seem hitting a regression of NFS client on the

[GIT PULL] Please pull NFS client fixes for 4.15-rc2

2017-12-01 Thread Anna Schumaker
Hi Linus, The following changes since commit fcfa447062b2061e11f68b846d61cbfe60d0d604: NFS: Revert "NFS: Move the flock open mode check into nfs_flock()" (2017-11-17 16:43:52 -0500) are available in the Git repository at: git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.1

Re: [PATCH 0/4] make function arg and structures as const

2017-11-10 Thread Anna Schumaker
On 11/09/2017 09:21 PM, J. Bruce Fields wrote: > On Tue, Oct 17, 2017 at 12:40:27PM -0400, Jeff Layton wrote: >> On Tue, 2017-10-17 at 18:14 +0200, Bhumika Goyal wrote: >>> Make the function argument as const. After thing change, make >>> the cache_detail structures as const. >>> >>> Bhumika Goya

[GIT PULL] Please pull NFS client fixes for 4.15

2017-11-17 Thread Anna Schumaker
me() - Use common error handling code in nfs_lock_and_join_request() - Check that some structures are properly cleaned up during net_exit() - Remove net pointer from dprintk()s Have a good weekend! Anna ---- Anna Schumaker (3): NFS: Create NFS

Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4

2017-11-30 Thread Anna Schumaker
On 11/30/2017 06:46 AM, Trond Myklebust wrote: > On Wed, 2017-11-29 at 23:05 -0500, Steven Rostedt wrote: >> On Wed, 29 Nov 2017 19:44:33 -0800 >> Linus Torvalds wrote: >> >> I keep older compilers around to test ftrace before -mfentry was >> introduced. >> >> I wonder if I should just add a con

Re: [GIT PULL] Please pull NFS client changes for Linux 4.9

2016-10-14 Thread Anna Schumaker
On 10/14/2016 12:24 AM, Linus Torvalds wrote: > On Thu, Oct 13, 2016 at 1:21 PM, Anna Schumaker > wrote: >> >> git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.9-1 > > Please keep the summary of changes in the email too. I can see it in > the tag,

Re: [PATCH] nfs4: fix missing-braces warning

2016-10-19 Thread Anna Schumaker
Hi Arnd (and Geert, if you're out there. I keep getting "relay access denied" when I try to CC you), Thanks for the patches for this issue! I've applied Arnd's version for 4.9-rc* since I think it looks a little cleaner. Cheers, Anna On 10/18/2016 11:21 AM, Arnd Bergmann wrote: > A bugfix in