Modify link to FrameBuffer HOWTO because original link become unavailable
Found by Linux Driver Verification project (linuxtesting.org)
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
drivers/video/fbdev/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
If ibmasm_event_buffer_init() or ibmasm_heartbeat_init() fails,
then ibmasm_init_one() release all resources and return 0 on error path.
The patch adds corresponding error for fails.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasil...@ispras
that dev will be deallocated exactly after
this call and leads to use after free.
The patch moves deallocation from gadget_release() to
net2280_remove().
Found by Linux Driver Verififcation project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
drivers/usb/gadg
On 16.08.2017 18:29, Alan Stern wrote:
On Wed, 16 Aug 2017, Anton Vasilyev wrote:
gadget_release() is responsible for cleanup dev memory.
But if net2280_probe() fails after dev allocation, then
gadget_release() become unregistered and dev memory leaks.
This isn't needed
Replace ioremap() and request_mem_region() by devm_ioremap_resource().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
Suggested-by: Boris Brezillon <boris.brezil...@free-electrons.com>
---
v1: Fix commit based on Bor
Use api pair of request_mem_region and release_mem_region
instead of release_resource.
Found by Linux Driver Verification project (linuxtesting.
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
v1: Fix commit based on Boris Brezillon review
---
drivers/mtd/maps/plat-ram.c | 4 ++--
resources are under devm control.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
v2: Drop initialization of sec_dai by NULL at samsung_i2s_remove
as Sylwester Nawrocki suggest.
---
v3: Fix typo in the comment
---
v4: Chan
Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
drivers/hwmon/stts751.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/hwmon/stts751.c b/drivers/hwmon/stts751.c
index d56251d..f6eddbd 100644
--- a/drivers/hwmon/stts751.c
+
If dw2102_probe() fails on dvb_usb_device_init(), then memleak occurs.
The patch adds deallocation to the error path.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
drivers/media/usb/dvb-usb/dw2102.
Use api pair of request_mem_region and release_mem_region
instead of release_resource.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
drivers/i2c/busses/i2c-simtec.c | 6 ++
1 file changed, 2 insertions(+), 4 del
nux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
sound/soc/samsung/i2s.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index af3ba4d..6beeea8 100644
--- a/sound/s
).
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
drivers/dma/qcom/hidma_mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c
index 5a0991b..89e36e3 100644
--- a/drivers/dma/qcom/hidma_mgmt.c
+++ b/
Use api pair of request_mem_region and release_mem_region
instead of release_resource.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
drivers/parport/parport_ax88796.c | 6 ++
1 file changed, 2 insertions(+), 4 del
Use api pair of request_mem_region and release_mem_region
instead of release_resource.
Found by Linux Driver Verification project (linuxtesting.
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
drivers/mtd/maps/plat-ram.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
If mISDN_FsmNew() fails to allocate memory for jumpmatrix
then null pointer dereference will occur on any write to
jumpmatrix.
The patch adds check on successful allocation and
corresponding error handling.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton
nux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
v2: Drop initialization of sec_dai at samsung_i2s_remove as Sylwester
Nawrocki suggest.
---
sound/soc/samsung/i2s.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff -
If dlfb_usb_probe drops to error path then there is only one
kref_init() call and no kref_get(), so second kref_put() leads to
use after free.
The patch removes superfluous kref_put on dlfb_usb_probe error path.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton
nux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
v2: Drop initialization of sec_dai by NULL at samsung_i2s_remove
as Sylwester Nawrocki suggest.
---
v3: Fix typo in the comment
---
sound/soc/samsung/i2s.c | 6 +-
1 file changed, 1
Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
v2: Fixed Guenter's remark about comparison
---
drivers/hwmon/stts751.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/hwmon/stts751.c b/drivers/hwmon/stts751.c
index d562
If ibmasm_event_buffer_init() or ibmasm_heartbeat_init() fails,
then ibmasm_init_one() release all resources and return 0 on error path.
The patch adds corresponding error for fails.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasil...@ispras
index = ((range << 1) | conf2);
become 3, but index is used for dereference pv88090_buck_vol[3].
Should be index=3 considered as incorrect value and pv88090_i2c_probe()
must return error,
or pv88090_buck_vol[] should be expanded?
Found by Linux Driver Verification project (linuxtesting.org)
achieve value 3 + 3 * 4 = 15,
which lead to buffer overwrite on
bgx_vnic[bgx->bgx_id] = bgx;
Question: is it enough for fix to change bgx_vnic's size?
Found by Linux Driver Verification project (linuxtesting.org).
--
Anton Vasilyev
Linux Verification Center, ISPRAS
web: http://linuxtes
).
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
index 66056f9..d42c617
Sorry for delayed reply.
On 16.08.2017 19:35, Alan Stern wrote:
On Wed, 16 Aug 2017, Anton Vasilyev wrote:
On 16.08.2017 18:29, Alan Stern wrote:
On Wed, 16 Aug 2017, Anton Vasilyev wrote:
gadget_release() is responsible for cleanup dev memory.
But if net2280_probe() fails after dev
The patch removes unnecessary return from void function.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasil...@ispras.ru>
---
arch/x86/include/asm/paravirt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/inclu
Driver contains unsuitable request_mem_region() and
release_resource() calls.
The patch switches manual resource management by devm interface for
readability and error-free simplification.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <va
ect (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/staging/rts5208/rtsx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 70e0b8623110..952dd0d580cf 100644
--- a/drivers/staging/rts5208/rtsx.c
++
If rtsx_probe() fails to allocate dev->chip, then NULL pointer
dereference occurs at release_everything()->rtsx_release_resources().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v2: Add error handling into rtsx_probe based on Dan Carpe
roject (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v3: fix subject and commit message
v2: Add error handling into rtsx_probe based on Dan Carpenter's comment.
I do not have corresponding hardware, so patch was tested by compilation only.
I faced with inaccuracy at rtsx_remove() and original rtsx
If rtsx_probe() fails to allocate dev->chip, then release_everything()
will crash on uninitialized dev->cmnd_ready complete.
Patch adds error handling into rtsx_probe.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v3: fix subject and
If rtsx_probe() fails to allocate dev->chip, then release_everything()
will crash on uninitialized dev->cmnd_ready complete
Patch adds error handling into rtsx_probe.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v4: rename labels baced
I found that staging-next already contains my patch v3, committed by
Greg Kroah-Hartman.
Do I need to send a new patch with a label renaming based on Dan
Carpenter comments?
--
Anton Vasilyev
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: vasil...@ispras.ru
project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/media/platform/davinci/vpif_display.c | 24 ---
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/media/platform/davinci/vpif_display.c
b/drivers/media/platform/davinci/vpif_display.c
index
There is no deallocation of fmc memory, allocated at ff_dev_create()
by kmemdup(), and no check on kmemdup() success.
The patch adds deallocation into ff_dev_release() and adds check on
allocation success.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton
Free resources instead of direct return of the error code if kim_probe
fails.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/misc/ti-st/st_kim.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/ti-st
tch replaces kzalloc allocation by devm_kzalloc and removes
ishtp_device *dev deallocation by kfree.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
Acked-by: Srinivas Pandruvada
---
v2: Fix align for multi line statements
---
drivers/hid/intel-ish-
If rtsx_probe() fails to allocate dev->chip, then release_everything()
will crash on uninitialized dev->cmnd_ready complete.
Patch adds an error handling into rtsx_probe.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v5: fix mistype and
cation project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/tty/rocket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/rocket.c b/drivers/tty/rocket.c
index bdd17d2aaafd..b121d8f8f3d7 100644
--- a/drivers/tty/rocket.c
+++ b/drivers/tty/rocket.c
@@ -
There is no check that tps->strobes is allocated successfully in
tps65217_regulator_probe().
The patch adds corresponding check.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/regulator/tps65217-regulator.c | 2 ++
1 file changed
cation project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v2: do not enable device which will not be managed by driver.
Based on Alan's comment.
NOTE: I can't find if there is a call of pci_disable_device(),
corresponding to pci_enable_device() from register_PCI().
---
drivers/tty/rocket
There is no deallocation of fotg210->ep[i] elements, allocated at
fotg210_udc_probe.
The patch adds deallocation of fotg210->ep array elements and simplifies
error path of fotg210_udc_probe().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Va
lid for signed and unsigned
types.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v2: mistype in patch as result of combination of different fixes.
Change comment and leave enum type.
---
drivers/tty/serial/mxs-auart.c | 3 ++-
1 file changed
There is no check that allocation in axp20x_funcs_groups_from_mask
is successful.
The patch adds corresponding check and return values.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/pinctrl/pinctrl-axp209.c | 26
int.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/tty/serial/mxs-auart.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index 76aa289652f7..89b34bb09
n project (linuxtesting.org).
--
Anton Vasilyev
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: vasil...@ispras.ru
chip_save array.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/gpio/gpio-ml-ioh.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
index b23d9a36be1f..51c7d1b84c2e
-by: Anton Vasilyev
---
drivers/firmware/google/vpd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
index e9db895916c3..5347c17c7108 100644
--- a/drivers/firmware/google/vpd.c
+++ b/drivers/firmware/google/vpd.c
@@ -246,6 +246,7
tch replaces kzalloc allocation by devm_kzalloc and removes
ishtp_device *dev deallocation by kfree.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/hid/intel-ish-hid/ipc/ipc.c | 7 +--
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 2 --
Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v2: add cleanup on the error path of vpd_sections_init
---
drivers/firmware/google/vpd.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
hwarc_probe() allocates memory for hwarc, but does not free it
if uwb_rc_add() or hwarc_get_version() fail.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/uwb/hwa-rc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/uwb/hwa
Replace ioremap() and request_mem_region() by devm_ioremap_resource().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
Suggested-by: Boris Brezillon
---
v1: Fix commit based on Boris Brezillon review
---
v2: Change commit by Boris Brezillon solution
If ibmasm_event_buffer_init() or ibmasm_heartbeat_init() fails,
then ibmasm_init_one() release all resources and return 0 on error path.
The patch adds corresponding error for fails.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/misc
If ibmasm_event_buffer_init() or ibmasm_heartbeat_init() fails,
then ibmasm_init_one() release all resources and return 0 on error path.
The patch adds corresponding error for fails.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v2: change
index = ((range << 1) | conf2);
become 3, but index is used for dereference pv88090_buck_vol[3].
Should be index=3 considered as incorrect value and pv88090_i2c_probe()
must return error,
or pv88090_buck_vol[] should be expanded?
Found by Linux Driver Verification project (linuxtesting.org)
Use api pair of request_mem_region and release_mem_region
instead of release_resource.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/parport/parport_ax88796.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
Use api pair of request_mem_region and release_mem_region
instead of release_resource.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/i2c/busses/i2c-simtec.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/hwmon/stts751.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/hwmon/stts751.c b/drivers/hwmon/stts751.c
index d56251d..f6eddbd 100644
--- a/drivers/hwmon/stts751.c
+++ b/drivers/hwmon/stt
If dw2102_probe() fails on dvb_usb_device_init(), then memleak occurs.
The patch adds deallocation to the error path.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/media/usb/dvb-usb/dw2102.c | 39
).
Signed-off-by: Anton Vasilyev
---
drivers/dma/qcom/hidma_mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c
index 5a0991b..89e36e3 100644
--- a/drivers/dma/qcom/hidma_mgmt.c
+++ b/drivers/dma/qcom/hidma_mgmt.c
nux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
sound/soc/samsung/i2s.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index af3ba4d..6beeea8 100644
--- a/sound/soc/samsung/i2s.c
+++ b
Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v2: Fixed Guenter's remark about comparison
---
drivers/hwmon/stts751.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/hwmon/stts751.c b/drivers/hwmon/stts751.c
index d56251d..3f940fb 100644
--- a/d
nux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v2: Drop initialization of sec_dai at samsung_i2s_remove as Sylwester
Nawrocki suggest.
---
sound/soc/samsung/i2s.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/sound/soc/samsung/i2s
Use api pair of request_mem_region and release_mem_region
instead of release_resource.
Found by Linux Driver Verification project (linuxtesting.
Signed-off-by: Anton Vasilyev
---
drivers/mtd/maps/plat-ram.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd
If mISDN_FsmNew() fails to allocate memory for jumpmatrix
then null pointer dereference will occur on any write to
jumpmatrix.
The patch adds check on successful allocation and
corresponding error handling.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton
If dlfb_usb_probe drops to error path then there is only one
kref_init() call and no kref_get(), so second kref_put() leads to
use after free.
The patch removes superfluous kref_put on dlfb_usb_probe error path.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton
nux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v2: Drop initialization of sec_dai by NULL at samsung_i2s_remove
as Sylwester Nawrocki suggest.
---
v3: Fix typo in the comment
---
sound/soc/samsung/i2s.c | 6 +-
1 file changed, 1 insertion(+), 5 deletion
Driver contains unsuitable request_mem_region() and
release_resource() calls.
The patch switches manual resource management by devm interface for
readability and error-free simplification.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
Suggested
Sorry for delayed reply.
On 16.08.2017 19:35, Alan Stern wrote:
On Wed, 16 Aug 2017, Anton Vasilyev wrote:
On 16.08.2017 18:29, Alan Stern wrote:
On Wed, 16 Aug 2017, Anton Vasilyev wrote:
gadget_release() is responsible for cleanup dev memory.
But if net2280_probe() fails after dev
).
Signed-off-by: Anton Vasilyev
---
drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
index 66056f9..d42c617 100644
--- a/drivers/infiniband/hw
achieve value 3 + 3 * 4 = 15,
which lead to buffer overwrite on
bgx_vnic[bgx->bgx_id] = bgx;
Question: is it enough for fix to change bgx_vnic's size?
Found by Linux Driver Verification project (linuxtesting.org).
--
Anton Vasilyev
Linux Verification Center, ISPRAS
web: http://linuxtes
resources are under devm control.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v2: Drop initialization of sec_dai by NULL at samsung_i2s_remove
as Sylwester Nawrocki suggest.
---
v3: Fix typo in the comment
---
v4: Change comment based on Krzysz
Use api pair of request_mem_region and release_mem_region
instead of release_resource.
Found by Linux Driver Verification project (linuxtesting.
Signed-off-by: Anton Vasilyev
---
v1: Fix commit based on Boris Brezillon review
---
drivers/mtd/maps/plat-ram.c | 4 ++--
1 file changed, 2
that dev will be deallocated exactly after
this call and leads to use after free.
The patch moves deallocation from gadget_release() to
net2280_remove().
Found by Linux Driver Verififcation project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/usb/gadget/udc/net2280.c | 14
On 16.08.2017 18:29, Alan Stern wrote:
On Wed, 16 Aug 2017, Anton Vasilyev wrote:
gadget_release() is responsible for cleanup dev memory.
But if net2280_probe() fails after dev allocation, then
gadget_release() become unregistered and dev memory leaks.
This isn't needed
n heap to prevent
memleak and use after free.
Also fixes s421_properties.devices initialization to have 2 element
instead of 6 copied from p7500_properties.
Signed-off-by: Anton Vasilyev
Fixes: 299c7007e936 ("media: dw2102: Fix memleak on sequence of probes")
---
drivers/media/usb/dvb-us
If rtsx_probe() fails to allocate dev->chip, then release_everything()
will crash on uninitialized dev->cmnd_ready complete
Patch adds error handling into rtsx_probe.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v4: rename labels baced
project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/media/platform/davinci/vpif_display.c | 24 ---
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/media/platform/davinci/vpif_display.c
b/drivers/media/platform/davinci/vpif_display.c
index
cation project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/tty/rocket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/rocket.c b/drivers/tty/rocket.c
index bdd17d2aaafd..b121d8f8f3d7 100644
--- a/drivers/tty/rocket.c
+++ b/drivers/tty/rocket.c
@@ -
There is no check that tps->strobes is allocated successfully in
tps65217_regulator_probe().
The patch adds corresponding check.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/regulator/tps65217-regulator.c | 2 ++
1 file changed
There is no deallocation of fmc memory, allocated at ff_dev_create()
by kmemdup(), and no check on kmemdup() success.
The patch adds deallocation into ff_dev_release() and adds check on
allocation success.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton
Free resources instead of direct return of the error code if kim_probe
fails.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/misc/ti-st/st_kim.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/ti-st
tch replaces kzalloc allocation by devm_kzalloc and removes
ishtp_device *dev deallocation by kfree.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
Acked-by: Srinivas Pandruvada
---
v2: Fix align for multi line statements
---
drivers/hid/intel-ish-
If rtsx_probe() fails to allocate dev->chip, then release_everything()
will crash on uninitialized dev->cmnd_ready complete.
Patch adds an error handling into rtsx_probe.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v5: fix mistype and
I found that staging-next already contains my patch v3, committed by
Greg Kroah-Hartman.
Do I need to send a new patch with a label renaming based on Dan
Carpenter comments?
--
Anton Vasilyev
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: vasil...@ispras.ru
cation project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v2: do not enable device which will not be managed by driver.
Based on Alan's comment.
NOTE: I can't find if there is a call of pci_disable_device(),
corresponding to pci_enable_device() from register_PCI().
---
drivers/tty/rocket
There is no check that allocation in axp20x_funcs_groups_from_mask
is successful.
The patch adds corresponding check and return values.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/pinctrl/pinctrl-axp209.c | 26
int.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/tty/serial/mxs-auart.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index 76aa289652f7..89b34bb09
lid for signed and unsigned
types.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v2: mistype in patch as result of combination of different fixes.
Change comment and leave enum type.
---
drivers/tty/serial/mxs-auart.c | 3 ++-
1 file changed
There is no deallocation of fotg210->ep[i] elements, allocated at
fotg210_udc_probe.
The patch adds deallocation of fotg210->ep array elements and simplifies
error path of fotg210_udc_probe().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Va
n project (linuxtesting.org).
--
Anton Vasilyev
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: vasil...@ispras.ru
tch replaces kzalloc allocation by devm_kzalloc and removes
ishtp_device *dev deallocation by kfree.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/hid/intel-ish-hid/ipc/ipc.c | 7 +--
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 2 --
Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v2: add cleanup on the error path of vpd_sections_init
---
drivers/firmware/google/vpd.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
hwarc_probe() allocates memory for hwarc, but does not free it
if uwb_rc_add() or hwarc_get_version() fail.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/uwb/hwa-rc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/uwb/hwa
-by: Anton Vasilyev
---
drivers/firmware/google/vpd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
index e9db895916c3..5347c17c7108 100644
--- a/drivers/firmware/google/vpd.c
+++ b/drivers/firmware/google/vpd.c
@@ -246,6 +246,7
chip_save array.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/gpio/gpio-ml-ioh.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
index b23d9a36be1f..51c7d1b84c2e
If rtsx_probe() fails to allocate dev->chip, then NULL pointer
dereference occurs at release_everything()->rtsx_release_resources().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v2: Add error handling into rtsx_probe based on Dan Carpe
roject (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v3: fix subject and commit message
v2: Add error handling into rtsx_probe based on Dan Carpenter's comment.
I do not have corresponding hardware, so patch was tested by compilation only.
I faced with inaccuracy at rtsx_remove() and original rtsx
If rtsx_probe() fails to allocate dev->chip, then release_everything()
will crash on uninitialized dev->cmnd_ready complete.
Patch adds error handling into rtsx_probe.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
v3: fix subject and
ect (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/staging/rts5208/rtsx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 70e0b8623110..952dd0d580cf 100644
--- a/drivers/staging/rts5208/rtsx.c
++
The patch removes unnecessary return from void function.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
arch/x86/include/asm/paravirt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/paravirt.h b/arch
1 - 100 of 103 matches
Mail list logo
