Re: [PATCH] iio: ad_sigma_delta: use unsigned long for timeout

2018-07-27 Thread Ardelean, Alexandru
On Thu, 2018-07-26 at 11:44 +, Ardelean, Alexandru wrote: > On Mon, 2018-07-23 at 11:18 +0200, Nicholas Mc Guire wrote: > > wait_for_completion_timeout returns unsigned long not int so an > > appropriate > > variable is declared and the assignment and check fixed up. >

Re: [PATCH] iio: ad_sigma_delta: use unsigned long for timeout

2018-07-26 Thread Ardelean, Alexandru
On Mon, 2018-07-23 at 11:18 +0200, Nicholas Mc Guire wrote: > wait_for_completion_timeout returns unsigned long not int so an > appropriate > variable is declared and the assignment and check fixed up. > Patch looks good. Thanks for this Alex > Signed-off-by: Nicholas Mc Guire > --- > >

Re: [PATCH 2/2] dt-bindings: iio: adc: Add docs for AD7606 ADC

2018-10-18 Thread Ardelean, Alexandru
On Thu, 2018-10-18 at 12:12 +0300, Stefan Popa wrote: > Document support for AD7606 Analog to Digital Converter. > Commments inline > Signed-off-by: Stefan Popa > --- > .../devicetree/bindings/iio/adc/adi,ad7606.txt | 51 > ++ > MAINTAINERS

Re: [PATCH v3 1/3] staging: iio: ad7780: fix offset read value

2018-11-01 Thread Ardelean, Alexandru
Good catch. Acked-by: Alexandru Ardelean On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote: > Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET. > This was fixed by assigning the correct value instead. > > Signed-off-by: Renato Lui Geh > --- >

Re: [PATCH v3 2/3] staging: iio: ad7780: update voltage on read

2018-11-01 Thread Ardelean, Alexandru
On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote: > The ad7780 driver previously did not read the correct device output, as > it read an outdated value set at initialization. It now updates its > voltage on read. > > Signed-off-by: Renato Lui Geh > --- > Changes in v3: > - removed

Re: [PATCH v3 3/3] staging: iio: ad7780: remove unnecessary stashed voltage value

2018-11-01 Thread Ardelean, Alexandru
On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote: > This patch removes the unnecessary field int_vref_mv in ad7780_state > referring to the device's voltage. > > Signed-off-by: Renato Lui Geh > --- > Changes in v3: > - removed unnecessary int_vref_mv from ad7780_state > >

Re: [PATCH 3/3] staging: iio: ad7780: generates pattern_mask from PAT bits

2018-11-07 Thread Ardelean, Alexandru
On Wed, 2018-11-07 at 16:50 -0200, Giuliano Belinassi wrote: > Previously, all pattern_masks in the chip_info table were hardcoded. Now > they > are generated using the PAT macros, as described in the datasheets. > I like this change :) I only have nitpicks. See inline. > Signed-off-by:

Re: [PATCH 2/3] staging: iio: ad7780: check if ad778x before gain update

2018-11-07 Thread Ardelean, Alexandru
On Wed, 2018-11-07 at 16:50 -0200, Giuliano Belinassi wrote: > Only the ad778x have the 'gain' status bit. Check it before updating. > This looks good. The only note is that it can be squashed with the 1st patch (which I noted on the 1st patch). > Signed-off-by: Giuliano Belinassi > --- >

Re: [PATCH 1/3] staging: iio: ad7780: Add is_ad778x flag chip info

2018-11-07 Thread Ardelean, Alexandru
On Wed, 2018-11-07 at 16:49 -0200, Giuliano Belinassi wrote: > This patch allows further checking of whatever the chip is (ad778x or > ad717x). Hey, The patch looks good overall. I only have one nitpick for this patch. See inline. And you can squash this patch with patch `[PATCH 2/3] staging:

Re: [PATCH v2 1/2] staging: iio: ad7780: check if ad778x before gain update

2018-11-08 Thread Ardelean, Alexandru
On Thu, 2018-11-08 at 11:03 -0200, Giuliano Belinassi wrote: > Only the ad778x have the 'gain' status bit. Check it before updating > through a new variable is_ad778x in chip_info. > Looks good. Alex > Signed-off-by: Giuliano Belinassi > --- > Changes in v2: > - Squashed is_ad778x

Re: [PATCH v2 2/2] staging: iio: ad7780: generates pattern_mask from PAT bits

2018-11-08 Thread Ardelean, Alexandru
On Thu, 2018-11-08 at 11:03 -0200, Giuliano Belinassi wrote: > Previously, all pattern_masks and patterns in the chip_info table were > hardcoded. Now they are generated using the PAT macros, as described in > the datasheets. One comment about indentation/whitespace. Rest looks good. Alex > >

Re: [PATCH v4 1/2] staging: iio: ad7780: update voltage on read

2018-11-11 Thread Ardelean, Alexandru
On Sun, 2018-11-11 at 14:30 +, Jonathan Cameron wrote: > On Tue, 6 Nov 2018 09:24:44 + > "Ardelean, Alexandru" wrote: > > > On Mon, 2018-11-05 at 17:14 -0200, Renato Lui Geh wrote: > > > The ad7780 driver previously did not read the correct dev

Re: [PATCH v2 1/2] staging: iio: ad7780: check if ad778x before gain update

2018-11-11 Thread Ardelean, Alexandru
On Sun, 2018-11-11 at 12:58 +, Jonathan Cameron wrote: > On Thu, 8 Nov 2018 13:44:17 + > "Ardelean, Alexandru" wrote: > > > On Thu, 2018-11-08 at 11:03 -0200, Giuliano Belinassi wrote: > > > Only the ad778x have the 'gain' status bit. Check it before upd

Re: [PATCH v4 1/2] staging: iio: ad7780: update voltage on read

2018-11-06 Thread Ardelean, Alexandru
On Mon, 2018-11-05 at 17:14 -0200, Renato Lui Geh wrote: > The ad7780 driver previously did not read the correct device output, as > it read an outdated value set at initialization. It now updates its > voltage on read. > Looks good from my side. Alex > Signed-off-by: Renato Lui Geh > --- >

Re: [PATCH v4 2/2] staging: iio: ad7780: remove unnecessary stashed voltage value

2018-11-06 Thread Ardelean, Alexandru
On Mon, 2018-11-05 at 17:16 -0200, Renato Lui Geh wrote: > This patch removes the unnecessary field int_vref_mv in ad7780_state > referring to the device's voltage. > Looks good from my side. Alex > Signed-off-by: Renato Lui Geh > --- > Changes in v3: > - removed unnecessary int_vref_mv

Re: [PATCH v4 4/4] staging: iio: ad7816: Add device tree table.

2018-11-15 Thread Ardelean, Alexandru
On Wed, 2018-11-14 at 23:16 +0530, Nishad Kamdar wrote: > Add device tree table for matching vendor ID. > This could have been just one patch. Something like [PATCH v4] staging: iio: ad7816: Add device tree table. It's no longer a series, because the other patches were applied already. I

Re: [PATCH v3 1/4] staging: iio: ad7816: Switch to the gpio descriptor interface

2018-11-09 Thread Ardelean, Alexandru
On Fri, 2018-11-09 at 13:05 +0530, Nishad Kamdar wrote: > Use the gpiod interface for rdwr_pin, convert_pin and busy_pin > instead of the deprecated old non-descriptor interface. > Patch looks good. I do have some thoughts about it. See inline. > Signed-off-by: Nishad Kamdar > --- >

Re: [PATCH v3 1/4] staging: iio: ad7816: Switch to the gpio descriptor interface

2018-11-09 Thread Ardelean, Alexandru
On Fri, 2018-11-09 at 08:05 +, Ardelean, Alexandru wrote: > On Fri, 2018-11-09 at 13:05 +0530, Nishad Kamdar wrote: > > Use the gpiod interface for rdwr_pin, convert_pin and busy_pin > > instead of the deprecated old non-descriptor interface. > > > > Patch l

Re: [PATCH v3 4/4] staging: iio: ad7816: Add device tree table.

2018-11-09 Thread Ardelean, Alexandru
On Fri, 2018-11-09 at 13:08 +0530, Nishad Kamdar wrote: > Add device tree table for matching vendor ID. One comment inline for this. Thanks Alex > > Signed-off-by: Nishad Kamdar > --- > drivers/staging/iio/adc/ad7816.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [PATCH] staging: iio: ad7780: Add gain & filter gpio support

2018-11-29 Thread Ardelean, Alexandru
On Tue, 2018-11-27 at 06:11 -0500, Popa, Stefan Serban wrote: > On Lu, 2018-11-26 at 17:24 -0200, Giuliano Belinassi wrote: > Hi, please see bellow > One note from me here. > > Hi, thank you for the review > > > > > > > > On Thu, 22 Nov 2018 11:01:00 + > > > "Popa, Stefan Serban" wrote:

Re: [PATCH v2 5/5] Staging: iio: adt7316: Use device tree data to assign irq_type

2018-11-21 Thread Ardelean, Alexandru
On Tue, 2018-11-20 at 22:30 +0530, Shreeya Patel wrote: > ADT7316 driver no more uses platform data and hence use device tree > data instead of platform data for assigning irq_type field. > Switch case figures out the type of irq and if it's the default case > then assign the default value to the

Re: [PATCH v3 7/7] staging:iio:ad2s90: Move out of staging

2018-11-25 Thread Ardelean, Alexandru
On Fri, 2018-11-23 at 22:23 -0200, Matheus Tavares wrote: > Move ad2s90 resolver driver out of staging to the main tree. > Acked-by: Alexandru Ardelean > Signed-off-by: Matheus Tavares > Signed-off-by: Victor Colombo > --- > Changes in v3: > - none > > Changes in v2: > - Disabled git move

Re: [PATCH v2 1/7] staging:iio:ad2s90: Add device tree support

2018-11-19 Thread Ardelean, Alexandru
On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote: > This patch adds device tree support to ad2s90 with standard > device tree id table. > Hey, Comment inline > Signed-off-by: Matheus Tavares > --- > Changes in v2: > - none > > drivers/staging/iio/resolver/ad2s90.c | 7 +++ > 1

Re: [PATCH v2 3/7] staging:iio:ad2s90: Add max frequency check at probe

2018-11-19 Thread Ardelean, Alexandru
On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote: > From: Alexandru Ardelean > > This patch adds a max frequency check at the beginning of ad2s90_probe > function so that when it is set to a value above 0.83Mhz, dev_err is > called with an appropriate message and -EINVAL is returned. >

Re: [PATCH v2 4/7] dt-bindings:iio:resolver: Add docs for ad2s90

2018-11-19 Thread Ardelean, Alexandru
On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote: > This patch adds the device tree binding documentation for the ad2s90 > resolver-to-digital converter. > One minor comment inline. > Signed-off-by: Matheus Tavares > --- > Changes in v2: > - Rewritten 'spi-cpol and spi-cpha' item to