This set of patches fixes a substantial number of checkpatch.pl errors and
warnings, and additionally it refactors some sections of code where lines were
far too long due to organizational problems.
Axel Rasmussen (9):
drivers: staging: rtl8187se: use netdev_* instead of prink
drivers
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 40 ++
1 file changed, 26 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/Module.symvers | 0
drivers/staging/rtl8187se/r8180_core.c | 8
2 files changed, 4 insertions(+), 4 deletions(-)
create mode 100644 drivers/staging/rtl8187se/Module.symvers
diff --git a/drivers
The definition of the driver's ChannelPlan array produced a large number
of checkpatch.pl errors. This patch fixes all of them by adding spaces
and wrapping the resulting overly-long lines.
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 49
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 125 ++---
1 file changed, 83 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index
A section of code in the function rtl8180_tx was indented for no reason,
causing numerous checkpatch.pl warnings.
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 133 +
1 file changed, 70 insertions(+), 63
needed for the original blocks of code.
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 119 ++---
1 file changed, 49 insertions(+), 70 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 65 ++
1 file changed, 42 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 73 --
1 file changed, 44 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180.h | 2 +-
drivers/staging/rtl8187se/r8180_core.c | 29 ++---
2 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180.h
b/drivers
needed for the original blocks of code.
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 119 ++---
1 file changed, 49 insertions(+), 70 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180.h | 2 +-
drivers/staging/rtl8187se/r8180_core.c | 29 ++---
2 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180.h
b/drivers
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 63 +-
1 file changed, 40 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/Module.symvers | 0
drivers/staging/rtl8187se/r8180_core.c | 8
2 files changed, 4 insertions(+), 4 deletions(-)
create mode 100644 drivers/staging/rtl8187se/Module.symvers
diff --git a/drivers
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 125 ++---
1 file changed, 83 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index
The definition of the driver's ChannelPlan array produced a large number
of checkpatch.pl errors. This patch fixes all of them by adding spaces
and wrapping the resulting overly-long lines.
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 49
A section of code in the function rtl8180_tx was indented for no reason,
causing numerous checkpatch.pl warnings.
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 132 +
1 file changed, 69 insertions(+), 63
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 40 ++
1 file changed, 26 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index
in the original set of patches.
Axel Rasmussen (9):
drivers: staging: rtl8187se: use netdev_* instead of prink
drivers: staging: rtl8187se: refactor/clean signal smoothing
drivers: staging: rtl8187se: wrap excessively long lines
drivers: staging: rtl8187se: wrap excessively long lines
drivers: staging
Signed-off-by: Axel Rasmussen axel.rasmuss...@gmail.com
---
drivers/staging/rtl8187se/r8180_core.c | 73 --
1 file changed, 44 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index
This set of patches fixes a substantial number of checkpatch.pl errors and
warnings, and additionally it refactors some sections of code where lines were
far too long due to organizational problems.
Axel Rasmussen (9):
drivers: staging: rtl8187se: use netdev_* instead of prink
drivers
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 40 ++
1 file changed, 26 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index 67c2583..b6c8c00 100644
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/Module.symvers | 0
drivers/staging/rtl8187se/r8180_core.c | 8
2 files changed, 4 insertions(+), 4 deletions(-)
create mode 100644 drivers/staging/rtl8187se/Module.symvers
diff --git a/drivers/staging/rtl8187se
The definition of the driver's ChannelPlan array produced a large number
of checkpatch.pl errors. This patch fixes all of them by adding spaces
and wrapping the resulting overly-long lines.
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 49
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 125 ++---
1 file changed, 83 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index 9e1642f..b6fdb6f 100644
A section of code in the function rtl8180_tx was indented for no reason,
causing numerous checkpatch.pl warnings.
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 133 +
1 file changed, 70 insertions(+), 63 deletions(-)
diff --git
needed for the original blocks of code.
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 119 ++---
1 file changed, 49 insertions(+), 70 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 65 ++
1 file changed, 42 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index cd22ba3..a0ca4f2 100644
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 73 --
1 file changed, 44 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index b6c8c00..cd22ba3 100644
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180.h | 2 +-
drivers/staging/rtl8187se/r8180_core.c | 29 ++---
2 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180.h
b/drivers/staging/rtl8187se/r8180.h
needed for the original blocks of code.
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 119 ++---
1 file changed, 49 insertions(+), 70 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180.h | 2 +-
drivers/staging/rtl8187se/r8180_core.c | 29 ++---
2 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180.h
b/drivers/staging/rtl8187se/r8180.h
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 63 +-
1 file changed, 40 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index 8681099..fc0b6d3 100644
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/Module.symvers | 0
drivers/staging/rtl8187se/r8180_core.c | 8
2 files changed, 4 insertions(+), 4 deletions(-)
create mode 100644 drivers/staging/rtl8187se/Module.symvers
diff --git a/drivers/staging/rtl8187se
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 125 ++---
1 file changed, 83 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index efe1c6e..e89907c 100644
The definition of the driver's ChannelPlan array produced a large number
of checkpatch.pl errors. This patch fixes all of them by adding spaces
and wrapping the resulting overly-long lines.
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 49
A section of code in the function rtl8180_tx was indented for no reason,
causing numerous checkpatch.pl warnings.
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 132 +
1 file changed, 69 insertions(+), 63 deletions(-)
diff --git
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 40 ++
1 file changed, 26 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index 67c2583..344ef74 100644
in the original set of patches.
Axel Rasmussen (9):
drivers: staging: rtl8187se: use netdev_* instead of prink
drivers: staging: rtl8187se: refactor/clean signal smoothing
drivers: staging: rtl8187se: wrap excessively long lines
drivers: staging: rtl8187se: wrap excessively long lines
drivers: staging
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 73 --
1 file changed, 44 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index 344ef74..8681099 100644
On Thu, Jan 21, 2021 at 2:47 PM Peter Xu wrote:
>
> On Fri, Jan 15, 2021 at 11:04:49AM -0800, Axel Rasmussen wrote:
> > This ioctl is how userspace ought to resolve "minor" userfaults. The
> > idea is, userspace is notified that a minor fault has occurred. It m
On Thu, Jan 21, 2021 at 11:12 AM Peter Xu wrote:
>
> On Fri, Jan 15, 2021 at 11:04:42AM -0800, Axel Rasmussen wrote:
> > UFFDIO_COPY and UFFDIO_ZEROPAGE cannot be used to resolve minor faults.
> > Without
> > modifications, the existing codepath assumes a new page ne
re commonly used since we're
talking about backing guest memory for VMs. I plan to implement shmem support in
a follow-up patch series.
Axel Rasmussen (2):
userfaultfd: add minor fault registration mode
userfaultfd: add UFFDIO_CONTINUE ioctl
fs/proc/task_mmu.c | 1 +
fs/us
e, and it also avoid set_page_huge_active() (as this would have been
done when the page was allocated).
Signed-off-by: Axel Rasmussen
---
fs/userfaultfd.c | 63 +++
include/linux/userfaultfd_k.h| 2 +
include/uapi/linux/userfaultfd.h | 21 ++
n future
commits]).
- Doing so would make handle_userfault()'s "reason" argument confusing.
We'd pass in "MISSING" even if the pages weren't really missing.
Signed-off-by: Axel Rasmussen
---
fs/proc/task_mmu.c | 1 +
fs/userfaultfd.c | 80 +++
ect hugetlbfs to be much more commonly used since we're
talking about backing guest memory for VMs. I plan to implement shmem support in
a follow-up patch series.
Axel Rasmussen (5):
userfaultfd: add minor fault registration mode
userfaultfd: disable huge PMD sharing for MINOR registered VMAs
From: Peter Xu
It is a preparation work to be able to behave differently in the per
architecture huge_pte_alloc() according to different VMA attributes.
Signed-off-by: Peter Xu
Signed-off-by: Axel Rasmussen
---
arch/arm64/mm/hugetlbpage.c | 2 +-
arch/ia64/mm/hugetlbpage.c| 3 ++-
arch
.
This will pair with want_pmd_share() in hugetlb code so that huge pmd sharing
is completely disabled for userfaultfd-wp registered range.
Signed-off-by: Peter Xu
Signed-off-by: Axel Rasmussen
---
fs/userfaultfd.c | 43
include/linux/mmu_notifier.h
From: Peter Xu
Prepare for it to be called outside of mm/hugetlb.c.
Signed-off-by: Peter Xu
Signed-off-by: Axel Rasmussen
---
include/linux/hugetlb.h | 8
mm/hugetlb.c| 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/include/linux/hugetlb.h b
something that arch code would like to use too
- ARM64 currently directly check against CONFIG_ARCH_WANT_HUGE_PMD_SHARE when
trying to share huge pmd. Switch to the want_pmd_share() helper.
Signed-off-by: Peter Xu
Signed-off-by: Axel Rasmussen
---
arch/arm64/mm/hugetlbpage.c | 3 +--
include
.
Huge PMD sharing would prevent these faults from occurring for
suitably aligned areas, so disable it upon UFFD registration.
Signed-off-by: Axel Rasmussen
---
include/linux/userfaultfd_k.h | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/include/linux
IO_ZEROPAGE case, so
just extend that design: add an enum for the three modes of operation,
and make the small adjustments needed for the MCOPY_ATOMIC_CONTINUE
case. (Basically, look up the existing page, and avoid adding the
existing page to the page cache or calling set_page_huge_active() on
it.)
ING faults, whereas CONTINUE is used for MINOR
faults.
Signed-off-by: Axel Rasmussen
---
Documentation/admin-guide/mm/userfaultfd.rst | 105 +++
1 file changed, 64 insertions(+), 41 deletions(-)
diff --git a/Documentation/admin-guide/mm/userfaultfd.rst
b/Documentation/admi
INUE ioctl, to setup the
mapping and resolve the fault. The reading thread should wake up and see
this modification.
Currently the minor fault test is only enabled in hugetlb_shared mode,
as this is the only configuration the kernel feature supports.
Signed-off-by: Axel Rasmussen
---
tools/testing/selfte
n future
commits]).
- Doing so would make handle_userfault()'s "reason" argument confusing.
We'd pass in "MISSING" even if the pages weren't really missing.
Signed-off-by: Axel Rasmussen
---
fs/proc/task_mmu.c | 1 +
fs/userfaultfd.c | 80 +++
On Tue, Sep 29, 2020 at 1:33 PM Tom Zanussi wrote:
>
> synth_field_size() returns either the size or an error. However, the
> code assigns the return val to ssize_t which is unsigned, and then
> tests whether it's less than 0, which it isn't so discards the error.
I think the patch is correct,
On Tue, Sep 29, 2020 at 1:33 PM Tom Zanussi wrote:
>
> Currently, sythetic events only support static string fields such as:
>
> # echo 'test_latency u64 lat; char somename[32]' >
> /sys/kernel/debug/tracing/synthetic_events
>
> Which is fine, but wastes a lot of space in the event.
>
> It
On Tue, Sep 29, 2020 at 1:33 PM Tom Zanussi wrote:
>
> Hi,
>
> This patchset adds support for dynamic strings for synthetic events,
> as requested by Axel Rasmussen.
>
> Actually, the first two patches should be applied in any case - the
> first just changes the c
, not just this one patch):
Tested-by: Axel Rasmussen
On Wed, Sep 30, 2020 at 11:41 AM Tom Zanussi wrote:
>
> 32 is too small for this value, and anyway it makes more sense to use
> MAX_FILTER_STR_VAL, as this is also the value used for variable-length
> __strings.
>
> Signed-o
s on exactly what e.g. the BPF program does.
Signed-off-by: Axel Rasmussen
---
include/linux/mmap_lock.h| 112 ---
include/trace/events/mmap_lock.h | 70 +++
mm/Makefile | 2 +-
mm/mmap_lock.c | 87 +++
of
these properties don't match, you get EINVAL [2]).
Supporting "bool" explicitly makes hooking this up easier and more
portable for userspace.
[1]: grep -r "bool" include/trace/events/
[2]: check_synth_field() in kernel/trace/trace_events_hist.c
Signed-o
rg/patchwork/patch/1316922/
[2] https://lore.kernel.org/patchwork/patch/1311996/
Axel Rasmussen (2):
tracing: support "bool" type in synthetic trace events
mmap_lock: add tracepoints around lock acquisition
include/linux/mmap_lock.h | 112 +++---
On Thu, Oct 8, 2020 at 12:40 AM Michel Lespinasse wrote:
>
> On Wed, Oct 7, 2020 at 11:44 AM Axel Rasmussen
> wrote:
> > The goal of these tracepoints is to be able to debug lock contention
> > issues. This lock is acquired on most (all?) mmap / munmap / page fault
>
I also tried constructing a synthetic event as we
discussed on the thread about my series.
As far as I can see, this addresses the edge cases Masami pointed out,
and it all seems to work as intended. It works fine with the kind of
synthetic event I'm hoping to define for my particular use case.
s on exactly what e.g. the BPF program does.
Signed-off-by: Axel Rasmussen
---
include/linux/mmap_lock.h| 93 ++--
include/trace/events/mmap_lock.h | 70
mm/Makefile | 2 +-
mm/mmap_lock.c | 87 +++
of
these properties don't match, you get EINVAL [2]).
Supporting "bool" explicitly makes hooking this up easier and more
portable for userspace.
[1]: grep -r "bool" include/trace/events/
[2]: check_synth_field() in kernel/trace/trace_events_hist.c
Acked-by: Michel L
ining any of the lock wrappers. This yields ~zero overhead if the
tracepoints aren't enabled, and therefore obviates the need for a Kconfig for
this change.
[1] https://lore.kernel.org/patchwork/patch/1316922/
[2] https://lore.kernel.org/patchwork/patch/1311996/
Axel Rasmussen (2):
On Mon, Oct 12, 2020 at 7:46 AM Steven Rostedt wrote:
>
> On Mon, 12 Oct 2020 09:26:13 -0500
> Tom Zanussi wrote:
>
> > Hi Steve,
> >
> > Looks ok to me.
> >
> > Acked-by: Tom Zanussi
>
> Great!
>
> I'll pull this patch into my tree. It doesn't look like patch 2/2 is
> dependent on this and
The goal of these tracepoints is to be able to debug lock contention
issues. This lock is acquired on most (all?) mmap / munmap / page fault
operations, so a multi-threaded process which does a lot of these can
experience significant contention.
We trace just before we start acquisition, when the
Yafang Shao wrote:
>
> On Fri, Jun 19, 2020 at 6:43 AM Axel Rasmussen
> wrote:
> >
> > The goal is to be able to collect a latency histogram for contended
> > mmap_lock acquisitions. This will be used to diagnose slowness observed
> > in production workloads,
On Sun, Sep 20, 2020 at 9:58 PM Yafang Shao wrote:
>
> On Fri, Sep 18, 2020 at 2:13 AM Axel Rasmussen
> wrote:
> >
> > The goal of these tracepoints is to be able to debug lock contention
> > issues. This lock is acquired on most (all?) mmap / munmap / page fault
cepoints are enabled in a header is used to
avoid un-inlining any of the lock wrappers. This yields ~zero overhead if the
tracepoints aren't enabled, and therefore obviates the need for a Kconfig for
this change.
[1] https://lore.kernel.org/patchwork/patch/1316922/
[2] https://lore.kernel.org/pat
s on exactly what e.g. the BPF program does.
[ rost...@goodmis.org: in-depth examples of tracepoint_enabled() usage,
and per-cpu-per-context buffer design ]
Signed-off-by: Axel Rasmussen
---
include/linux/mmap_lock.h| 95 +++-
include/trace/events/mmap_lock.h | 107 +
On Fri, Oct 23, 2020 at 7:00 AM Vlastimil Babka wrote:
>
> On 10/20/20 8:47 PM, Axel Rasmussen wrote:
> > The goal of these tracepoints is to be able to debug lock contention
> > issues. This lock is acquired on most (all?) mmap / munmap / page fault
> > operations, so
> test-description: The motivation behind this suite is to exercise functions
> > and regions of the mm/ of the Linux kernel which are of interest to us.
> > test-url:
> > https://git.kernel.org/cgit/linux/kernel/git/wfg/vm-scalability.git/
> >
>
> I'm curious why
On Tue, Oct 20, 2020 at 7:50 AM Vlastimil Babka wrote:
>
> On 10/10/20 12:05 AM, Axel Rasmussen wrote:
> > The goal of these tracepoints is to be able to debug lock contention
> > issues. This lock is acquired on most (all?) mmap / munmap / page fault
> > operations, so
s on exactly what e.g. the BPF program does.
Reviewed-by: Michel Lespinasse
Acked-by: Yafang Shao
Acked-by: David Rientjes
Signed-off-by: Axel Rasmussen
---
include/linux/mmap_lock.h| 93 --
include/trace/events/mmap_lock.h | 98 +++
tch/1316922/
[2] https://lore.kernel.org/patchwork/patch/1311996/
Axel Rasmussen (1):
mmap_lock: add tracepoints around lock acquisition
include/linux/mmap_lock.h| 93 --
include/trace/events/mmap_lock.h | 98
mm/Makefile
On Mon, Oct 26, 2020 at 1:31 AM David Hildenbrand wrote:
>
> On 23.10.20 21:44, Axel Rasmussen wrote:
> > On Fri, Oct 23, 2020 at 12:29 PM David Rientjes wrote:
> >>
> >> On Wed, 21 Oct 2020, kernel test robot wrote:
> >>
> >>> Greeting,
&g
Nov 30, 2020 at 5:08 AM syzbot
wrote:
>
> syzbot has bisected this issue to:
>
> commit 0f818c4bc1f3dc0d6d0ea916e0ab30cf5e75f4c0
> Author: Axel Rasmussen
> Date: Tue Nov 24 05:37:42 2020 +
>
> mm: mmap_lock: add tracepoints around lock acquisitio
uot;)
Signed-off-by: Axel Rasmussen
---
mm/mmap_lock.c | 100 +
1 file changed, 85 insertions(+), 15 deletions(-)
diff --git a/mm/mmap_lock.c b/mm/mmap_lock.c
index 12af8f1b8a14..be38dc58278b 100644
--- a/mm/mmap_lock.c
+++ b/mm/mmap_lock.c
@@ -3,6 +
On Fri, Dec 4, 2020 at 8:36 AM Vlastimil Babka wrote:
>
> On 12/2/20 2:11 AM, Shakeel Butt wrote:
> > On Tue, Dec 1, 2020 at 5:07 PM Steven Rostedt wrote:
> >>
> >> On Tue, 1 Dec 2020 16:36:32 -0800
> >> Shakeel Butt wrote:
> >>
> >> > SGTM but note that usually Andrew squash all the patches
r_hugepages (leaving it at 0), and then trying to run the
hugetlb_shared test.
Another small improvement is, when the original mmap fails, don't just
print "it failed": perror(), so we can see *why*. :)
Signed-off-by: Axel Rasmussen
---
tools/testing/selftests/vm/userfaultfd.c | 25 ++
On Mon, Nov 30, 2020 at 5:34 PM Shakeel Butt wrote:
>
> On Mon, Nov 30, 2020 at 3:43 PM Axel Rasmussen
> wrote:
> >
> > syzbot reported[1] a use-after-free introduced in 0f818c4bc1f3. The bug
> > is that an ongoing trace event might race with the tracepoint being
On Tue, Dec 1, 2020 at 10:42 AM Shakeel Butt wrote:
>
> On Tue, Dec 1, 2020 at 9:56 AM Greg Thelen wrote:
> >
> > Axel Rasmussen wrote:
> >
> > > On Mon, Nov 30, 2020 at 5:34 PM Shakeel Butt wrote:
> > >>
> > >> On M
called get_mem_cgroup_from_mm(), but we never called css_put() to
release that reference. get_mm_memcg_path() now does this properly.
[1]: https://syzkaller.appspot.com/bug?extid=19e6dd9943972fa1c58a
Signed-off-by: Axel Rasmussen
---
mm/mmap_lock.c | 104 +++--
1 file c
On Tue, Dec 1, 2020 at 12:53 PM Shakeel Butt wrote:
>
> +Tejun Heo
>
> On Tue, Dec 1, 2020 at 11:14 AM Axel Rasmussen
> wrote:
> >
> > On Tue, Dec 1, 2020 at 10:42 AM Shakeel Butt wrote:
> > >
> > > On Tue, Dec 1, 2020 at 9:56 AM Greg Thelen
tializer" warning
when we initialize prms in wp_range().
Signed-off-by: Axel Rasmussen
---
tools/testing/selftests/vm/userfaultfd.c | 77 +++-
1 file changed, 36 insertions(+), 41 deletions(-)
diff --git a/tools/testing/selftests/vm/userfaultfd.c
b/tools/testing/selftests/vm/us
On Wed, Dec 2, 2020 at 3:10 PM Peter Xu wrote:
>
> Hi, Axel,
>
> Looks mostly good to me, but a few nitpickings below.
>
> On Wed, Dec 02, 2020 at 01:15:42PM -0800, Axel Rasmussen wrote:
>
> [...]
>
> > +static void uffd_error(const char *message, __s64 code)
>
ot; warning
when we initialize prms in wp_range().
Acked-by: Peter Xu
Signed-off-by: Axel Rasmussen
---
tools/testing/selftests/vm/userfaultfd.c | 81 ++--
1 file changed, 35 insertions(+), 46 deletions(-)
diff --git a/tools/testing/selftests/vm/userfaultfd.c
b/tools/test
cepoints are enabled in a header is used to
avoid un-inlining any of the lock wrappers. This yields ~zero overhead if the
tracepoints aren't enabled, and therefore obviates the need for a Kconfig for
this change.
[1] https://lore.kernel.org/patchwork/patch/1316922/
[2] https://lore.kernel.org/pat
s on exactly what e.g. the BPF program does.
[ rost...@goodmis.org: in-depth examples of tracepoint_enabled() usage,
and per-cpu-per-context buffer design ]
Acked-by: Vlastimil Babka
Signed-off-by: Axel Rasmussen
---
include/linux/mmap_lock.h| 94 +++-
include/
On Thu, Sep 17, 2020 at 12:43 PM Steven Rostedt wrote:
>
> On Thu, 17 Sep 2020 11:13:47 -0700
> Axel Rasmussen wrote:
>
> > +/*
> > + * Trace calls must be in a separate file, as otherwise there's a circuclar
> > + * dependency between linux/mmap_lock.
On Thu, Sep 24, 2020 at 10:42 AM Mathieu Desnoyers
wrote:
>
> - On Sep 24, 2020, at 1:09 PM, rostedt rost...@goodmis.org wrote:
>
> > From: "Steven Rostedt (VMware)"
> >
> > As tracepoints are discouraged from being added in a header because it can
> > cause side effects if other tracepoints
On Thu, Sep 24, 2020 at 12:08 PM Mathieu Desnoyers
wrote:
>
>
>
> - On Sep 24, 2020, at 2:30 PM, rostedt rost...@goodmis.org wrote:
>
> > On Thu, 24 Sep 2020 13:42:25 -0400 (EDT)
> > Mathieu Desnoyers wrote:
> >
> >> > Signed-off-by: Steven Rostedt (VMware)
> >> > ---
> >> >
know what you think. Happy to drop this and wait for Tom's suggested
approach instead.
Axel Rasmussen (1):
tracing: support dynamic string field types for synthetic events
kernel/trace/trace_events_hist.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
--
2.28.0.681.g6f77f65b4e-goog
ical tracepoints. It turns out
this is already handled correctly, as long as the check during
definition parsing doesn't prevent it.
[1] grep -r "__string" include/trace/events/
[2] See synth_field_is_string in kernel/trace/trace_events_synth.c
[3] See check_synth_field in kernel/trace/
On Fri, Sep 25, 2020 at 12:48 PM Tom Zanussi wrote:
>
> Hi Axel,
>
> On Fri, 2020-09-25 at 12:08 -0700, Axel Rasmussen wrote:
> > Hi Steven and Tom,
> >
> > In this thread: https://lkml.org/lkml/2020/9/17/1015 we discussed how
> > to plumb
> > dynam
On Fri, Sep 25, 2020 at 2:18 PM Steven Rostedt wrote:
>
> From: "Steven Rostedt (VMware)"
>
> As tracepoints are discouraged from being added in a header because it can
> cause side effects if other tracepoints are in headers, as well as bloat the
> kernel as the trace_() function is not a small
On Mon, Sep 21, 2020 at 9:09 PM Yafang Shao wrote:
>
> On Tue, Sep 22, 2020 at 12:53 AM Axel Rasmussen
> wrote:
> >
> > On Sun, Sep 20, 2020 at 9:58 PM Yafang Shao wrote:
> > >
> > > On Fri, Sep 18, 2020 at 2:13 AM Axel Rasmussen
> > > wrot
1 - 100 of 282 matches
Mail list logo
