-Original Message-
From: Mark Brown [mailto:broo...@sirena.org.uk]
Sent: Wednesday, May 29, 2013 10:56 PM
To: Bard Liao
Cc: Stephen Warren
Subject: Re: a question about range_map_cfg
On Wed, May 29, 2013 at 08:46:40PM +0800, Bard Liao wrote:
However, I /think
-Original Message-
From: weizhewang [mailto:hmsjwz...@gmail.com]
Sent: Sunday, March 08, 2015 11:10 AM
To: Bard Liao
Cc: linux-kernel@vger.kernel.org; weizhewang
Subject: [PATCH] Sound: soc: codecs: rt5670: fix two space coding style
issue
fixed a coding style issue
Signed-off
-Original Message-
From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
Sent: Thursday, March 12, 2015 10:12 AM
To: Mark Brown; Liam Girdwood
Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Bard Liao
Subject: Re: linux-next: build failure after merge of the sound-asoc
Dear All,
I will send a patch to fix it immediately.
Thanks.
Bard Liao
Computer Peripherals Business Unit
Realtek Semiconductor Corp.
886-3-578-0211 ext. 3334
bardl...@realtek.com
-Original Message-
From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
Sent: Thursday, April 30
> -Original Message-
> From: Caesar Wang [mailto:w...@rock-chips.com]
> Sent: Monday, December 21, 2015 10:56 PM
> To: broo...@kernel.org; robh...@kernel.org
> Cc: linux-kernel@vger.kernel.org; devicet...@vger.kernel.org;
> alsa-de...@alsa-project.org; Bard Liao; he...
> -Original Message-
> From: kbuild test robot [mailto:l...@intel.com]
> Sent: Saturday, September 17, 2016 10:45 AM
> To: Wei Yongjun
> Cc: kbuild-...@01.org; Bard Liao; Oder Chiou; Liam Girdwood; Mark Brown;
> Jaroslav Kysela; Takashi Iwai; Wei Yongjun; alsa-de..
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Thursday, October 13, 2016 4:47 PM
> To: Bard Liao
> Cc: Oder Chiou; Liam Girdwood; Mark Brown; Jaroslav Kysela; Takashi Iwai;
> alsa-de...@alsa-project.org; linux-kernel@vger.kernel.o
> -Original Message-
> From: Shrirang Bagul [mailto:shrirang.ba...@canonical.com]
> Sent: Thursday, January 12, 2017 8:01 PM
> To: alsa-de...@alsa-project.org
> Cc: linux-kernel@vger.kernel.org; Bard Liao; Oder Chiou; Liam Girdwood; Mark
> Brown; Jaroslav Kysela; Taka
> -Original Message-
> From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com]
> Sent: Thursday, March 23, 2017 12:42 PM
> To: Bard Liao
> Cc: broo...@kernel.org; lgirdw...@gmail.com; Oder Chiou;
> alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org
> Subject
> -Original Message-
> From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com]
> Sent: Wednesday, March 22, 2017 1:37 PM
> To: Bard Liao
> Cc: broo...@kernel.org; lgirdw...@gmail.com; Oder Chiou;
> alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org
> Subject
> -Original Message-
> From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com]
> Sent: Monday, March 20, 2017 11:59 AM
> To: broo...@kernel.org
> Cc: lgirdw...@gmail.com; Bard Liao; Oder Chiou;
> alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Kai-Heng Feng
&g
> -Original Message-
> From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com]
> Sent: Tuesday, March 21, 2017 1:39 PM
> To: Bard Liao
> Cc: broo...@kernel.org; lgirdw...@gmail.com; Oder Chiou;
> alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org
> Subject
> -Original Message-
> From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com]
> Sent: Tuesday, March 21, 2017 1:26 PM
> To: Mark Brown
> Cc: Liam Girdwood; Bard Liao; Oder Chiou; alsa-de...@alsa-project.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH
> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: Thursday, June 29, 2017 9:54 AM
> To: Mark Brown; Liam Girdwood
> Cc: Linux-Next Mailing List; Linux Kernel Mailing List; Bard Liao
> Subject: linux-next: build failure after merge of t
> -Original Message-
> From: Carlo Caione [mailto:ca...@endlessm.com]
> Sent: Thursday, October 19, 2017 11:55 PM
> To: Pierre-Louis Bossart
> Cc: Carlo Caione; Linux Upstreaming Team; Bard Liao; Oder Chiou; Mark
> Brown; alsa-de...@alsa-project.org; linux-kernel@vge
> -Original Message-
> From: Carlo Caione [mailto:carlo.cai...@gmail.com] On Behalf Of Carlo
> Caione
> Sent: Thursday, October 19, 2017 7:03 PM
> To: li...@endlessm.com; Bard Liao; Oder Chiou;
> pierre-louis.boss...@linux.intel.com; broo...@kernel.org;
> alsa-de...@al
> -Original Message-
> From: Colin King [mailto:colin.k...@canonical.com]
> Sent: Thursday, April 19, 2018 10:35 PM
> To: Bard Liao; Oder Chiou; Liam Girdwood; Mark Brown; Jaroslav Kysela;
> Takashi Iwai; alsa-de...@alsa-project.org
> Cc: kernel-janit...@vger.kernel
> -Original Message-
> From: Mark Brown [mailto:broo...@sirena.org.uk]
> Sent: Wednesday, May 29, 2013 10:56 PM
> To: Bard Liao
> Cc: Stephen Warren
> Subject: Re: a question about range_map_cfg
>
> On Wed, May 29, 2013 at 08:46:40PM +0800, Bard Liao wrote:
&g
> -Original Message-
> From: Colin King [mailto:colin.k...@canonical.com]
> Sent: Thursday, April 19, 2018 10:35 PM
> To: Bard Liao; Oder Chiou; Liam Girdwood; Mark Brown; Jaroslav Kysela;
> Takashi Iwai; alsa-de...@alsa-project.org
> Cc: kernel-janit...@vger.kernel
> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: Thursday, June 29, 2017 9:54 AM
> To: Mark Brown; Liam Girdwood
> Cc: Linux-Next Mailing List; Linux Kernel Mailing List; Bard Liao
> Subject: linux-next: build failure after merge of t
initialization is to use _no_pm
routines. The duty of making sure the bus is operational needs to be
handled above the regmap level.
Fixes: 7c22ce6e21840 ('regmap: Add SoundWire bus support')
Signed-off-by: Bard Liao
---
drivers/base/regmap/regmap-sdw.c | 4 ++--
1 file changed, 2 insertions(+), 2
"GPL v2" is the same as "GPL". It exists for historic reasons.
See Documentation/process/license-rules.rst
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/base/regmap/regmap-sdw-mbq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Use no_pm versions for write and read.
Signed-off-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
---
drivers/base/regmap/regmap-sdw-mbq.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/base/regmap/regmap-sdw-mbq.c
b/drivers
of read/write
functions')
Fixes: aa79293517b39 ('soundwire: bus: fix io error when processing alert
event')
Fixes: 9d715fa005ebc ('soundwire: Add IO transfer')
Reported-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire
ice number is not zero, we
should use >dev to provide more precisions to the
user/integrator.
Reported-by: Rander Wang
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 63 +
1 file chang
sdw_write_no_pm and sdw_read_no_pm are useful when we want to do IO
without touching PM.
Fixes: 0231453bc08f ('soundwire: bus: add clock stop helpers')
Fixes: 60ee9be25571 ('soundwire: bus: add PM/no-PM versions of
read/write functions')
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c
rding to maintainer's comments.
Bard Liao (4):
soundwire: export sdw_write/read_no_pm functions
regmap: sdw: use _no_pm functions in regmap_read/write
regmap: sdw: use no_pm routines for SoundWire 1.2 MBQ
regmap: sdw-mbq: use MODULE_LICENSE("GPL")
Pierre-Louis Bossart (5):
s
problem as the previous one, but is split to
make the life of linux-stable maintainers less painful.
Fixes: 29d158f90690 ('soundwire: bus: initialize bus clock base and scale
registers')
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire
('soundwire: bus: add PM/no-PM versions of read/write
functions')
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers
From: Pierre-Louis Bossart
There is no need to play with pm_runtime reference counts, if needed
the codec drivers are already explicitly resumed.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 26
sdw_master_ops and IO transfer
support')
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/soundwire/cadence_master.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
index
-by: Bard Liao
---
drivers/soundwire/bus.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 3cc006bfae71..6e1c988f3845 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -267,8 +267,10 @@ static int
ndwire sdw-master-0: No more devices to enumerate
[ 121.892200] intel-sdw intel-sdw.0: Slave status change: 0x21
<< this shows the device now Attached as Device1 and Unattached as
Device0, i.e. a successful enumeration.
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drive
-by: Bard Liao
---
drivers/soundwire/bus.c | 5 ++---
drivers/soundwire/slave.c | 10 --
2 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index d1e8c3a54976..3cc006bfae71 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers
.
Bard Liao (1):
soundwire: bus: add more details to track failed transfers
Pierre-Louis Bossart (4):
soundwire: use consistent format for Slave devID logs
soundwire: cadence: add status in dev_dbg 'State change' log
soundwire: cadence: fix ACK/NAK handling
soundwire: cadence: adjust verbosity
devices to enumerate
We can skip the 'Msg Ack not received' since it's typical of the
enumeration end, and conversely add the information on which command
fails.
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/soundwire/cadence_master.c | 4 ++--
1 file changed, 2 insertions
tiated interrupts may be lost, but at least audio function can
still work after resume.
Signed-off-by: Bard Liao
Reviewed-by: Rander Wang
Reviewed-by: Kai Vehmanen
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff
The timeout for an individual transaction w/ the Cadence IP is the same as
the entire resume operation for codecs.
This doesn't make sense, we need to have at least one order of magnitude
between individual transactions and the entire resume operation.
Set the timeout on the Cadence side to 500ms
Signed-off-by: Bard Liao
---
sound/soc/codecs/max98373-sdw.c | 4 +++-
sound/soc/codecs/rt1308-sdw.c | 2 +-
sound/soc/codecs/rt5682.h | 2 +-
sound/soc/codecs/rt700-sdw.c| 2 +-
sound/soc/codecs/rt711-sdw.c| 2 +-
sound/soc/codecs/rt715-sdw.c| 2 +-
6 files changed, 8
than generous.
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/soundwire/cadence_master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
index 9fa55164354a..f0b0ec173f8b 100644
public but this
information is released with explicit permission from the MIPI Board
to avoid delays with SDCA support on Linux platforms.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
include/linux/soundwire
the status of the
sdca_cascade bit.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 14 ++
include/linux/soundwire/sdw.h | 4
2 files changed, 18 insertions(+)
diff --git a/drivers
sdw_add_bus_master()
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah. All hard-coded
values were removed from the initial contribution to use BIOS
information instead.
Signed-off-by: Bard Liao
---
drivers/soundwire/Kconfig
interrupt sources.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Kai Vehmanen
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
Some codecs may report fake PARITY errors in the initial state. This
series will filter them out.
Pierre-Louis Bossart (7):
ASoC/soundwire: bus: use property to set interrupt masks
soundwire: bus: filter-out unwanted interrupt reports
soundwire: slave: add first_interrupt_done status
From: Pierre-Louis Bossart
If a Slave device reports with a quirk that its initial parity check
may be incorrect, filter it but keep the parity checks active in
steady state.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Kai Vehmanen
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard
nen
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/cadence_master.c | 86 ++
1 file changed, 86 insertions(+)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
index ecf503fb23e1..13e565f93166 100
On 8/31/2020 11:12 PM, Pierre-Louis Bossart wrote:
On 8/30/20 8:27 AM, Bard Liao wrote:
The existing code allocates memory for the total number of ports.
This only works if the ports are contiguous, but will break if e.g. a
Devices uses port0, 1, and 14. The port_ready[] array would contain
Signed-off-by: Bard Liao
---
sound/soc/codecs/max98373-sdw.c | 15 +--
sound/soc/codecs/rt1308-sdw.c | 14 +-
sound/soc/codecs/rt5682-sdw.c | 15 +--
sound/soc/codecs/rt700-sdw.c| 15 +--
sound/soc/codecs/rt711-sdw.c| 15
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/mipi_disco.c | 18 +-
drivers/soundwire/slave.c | 4
include/linux/soundwire/sdw.h | 2 +-
3 files changed, 6 insertions(+), 18 deletions(-)
diff --git a/drivers
The existing code allocates memory for the total number of ports.
This only works if the ports are contiguous, but will break if e.g. a
Devices uses port0, 1, and 14. The port_ready[] array would contain 3
elements, which would lead to an out-of-bounds access. Conversely in
other cases, the wrong
From: Pierre-Louis Bossart
A Device may have at most 15 physical ports (DP0, DP1..DP14).
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
include/linux/soundwire/sdw.h | 3 ++-
1 file changed, 2 insertions(+), 1
to test capture paths. In this case the
input generated by a Slave source port is replaced by a fixed or
cyclical patterns.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/intel.c | 42
Test modes are required for all SoundWire IP, and help debug
integration issues. This series adds debugfs support and data
port test fail interrupt to enable data port test mode feature
on Intel platforms.
Pierre-Louis Bossart (3):
soundwire: enable Data Port test modes
soundwire: intel:
rding to maintainer's comments.
Bard Liao (4):
soundwire: export sdw_write/read_no_pm functions
regmap: sdw: use _no_pm functions in regmap_read/write
regmap: sdw: use no_pm routines for SoundWire 1.2 MBQ
regmap: sdw-mbq: use MODULE_LICENSE("GPL")
Pierre-Louis Bossart (5):
s
problem as the previous one, but is split to
make the life of linux-stable maintainers less painful.
Fixes: 29d158f90690 ('soundwire: bus: initialize bus clock base and scale
registers')
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire
('soundwire: bus: add PM/no-PM versions of read/write
functions')
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers
From: Pierre-Louis Bossart
There is no need to play with pm_runtime reference counts, if needed
the codec drivers are already explicitly resumed.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 26
sdw_write_no_pm and sdw_read_no_pm are useful when we want to do IO
without touching PM.
Fixes: 0231453bc08f ('soundwire: bus: add clock stop helpers')
Fixes: 60ee9be25571 ('soundwire: bus: add PM/no-PM versions of
read/write functions')
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c
initialization is to use _no_pm
routines. The duty of making sure the bus is operational needs to be
handled above the regmap level.
Fixes: 7c22ce6e21840 ('regmap: Add SoundWire bus support')
Signed-off-by: Bard Liao
---
drivers/base/regmap/regmap-sdw.c | 4 ++--
1 file changed, 2 insertions(+), 2
Use no_pm versions for write and read.
Signed-off-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
---
drivers/base/regmap/regmap-sdw-mbq.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/base/regmap/regmap-sdw-mbq.c
b/drivers
"GPL v2" is the same as "GPL". It exists for historic reasons.
See Documentation/process/license-rules.rst
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/base/regmap/regmap-sdw-mbq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
of read/write
functions')
Fixes: aa79293517b39 ('soundwire: bus: fix io error when processing alert
event')
Fixes: 9d715fa005ebc ('soundwire: Add IO transfer')
Reported-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire
ice number is not zero, we
should use >dev to provide more precisions to the
user/integrator.
Reported-by: Rander Wang
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 63 +
1 file chang
_primary_fwnode()") was fully
correct. Thus, revert the former one here and improve documentation.
Bard Liao (2):
Revert "device property: Keep secondary firmware node secondary by
type"
device property: add description of fwnode cases
drivers/base/core.c | 9 -
1 fi
e node handling in set_primary_fwnode()") was fully
correct. Thus, revert the former one here and improve documentation in
the next patch.
Fixes: d5dcce0c414f ("device property: Keep secondary firmware node secondary
by type")
Signed-off-by: Bard Liao
---
drivers/base/core.c | 2 +-
1 file chang
it in the code so people will keep it in mind.
Signed-off-by: Bard Liao
---
drivers/base/core.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 51b9545a050b..17eb14607074 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -
-Louis Bossart
Signed-off-by: Bard Liao
---
Changelog:
v2:
- add SDW_SDCA_MBQ_CTL
v3:
- add SDW_SDCA_NEXT_CTL
---
include/linux/soundwire/sdw_registers.h | 32 +
1 file changed, 32 insertions(+)
diff --git a/include/linux/soundwire/sdw_registers.h
b/include/linux
The MIPI SoundWire Device Class standard will define audio functionality
beyond the scope of the existing SoundWire 1.2 standard, which is limited
to the bus and interface.
The description is inspired by the USB Audio Class, with "functions",
"entities", "control selectors", "audio clusters". The
-Louis Bossart
Signed-off-by: Bard Liao
---
include/linux/soundwire/sdw_registers.h | 32 +
1 file changed, 32 insertions(+)
diff --git a/include/linux/soundwire/sdw_registers.h
b/include/linux/soundwire/sdw_registers.h
index 0cb1a22685b8..138bec908c40 100644
--- a/include
ander Wang
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Kai Vehmanen
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/base/regmap/Kconfig | 6 +-
drivers/base/regmap/Makefile | 1 +
drivers/base/regmap/regmap-sdw-mbq.c | 101 ++
From: Shuming Fan
This is the initial amplifier driver for rt1316 SDCA version.
Signed-off-by: Shuming Fan
Reviewed-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
sound/soc/codecs/Kconfig | 6 +
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/rt1316-sdw.c | 756
From: Jack Yu
First version of rt715 sdw sdca codec driver.
Signed-off-by: Jack Yu
Reviewed-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
sound/soc/codecs/Kconfig | 7 +
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/rt715-sdca-sdw.c | 278 +
sound
From: Shuming Fan
This is the initial codec driver for rt711 SDCA version.
Signed-off-by: Shuming Fan
Reviewed-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
sound/soc/codecs/Kconfig |7 +
sound/soc/codecs/Makefile |2 +
sound/soc/codecs/rt711-sdca-sdw.c
('soundwire: bus: add PM/no-PM versions of read/write
functions')
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers
is needed for soundwire tree to complie.
On the other hands,
commit 6e06a85556f9 ("soundwire: bus: add comments to explain interrupt loop
filter")
to
commit 47b8520997a8 ("soundwire: bus: only clear valid DPN interrupts")
are needed for regmap tree.
Bard Liao (2):
soundwir
problem as the previous one, but is split to
make the life of linux-stable maintainers less painful.
Fixes: 29d158f90690 ('soundwire: bus: initialize bus clock base and scale
registers')
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire
initialization is to use _no_pm
routines. The duty of making sure the bus is operational needs to be
handled above the regmap level.
Fixes: 7c22ce6e21840 ('regmap: Add SoundWire bus support')
Signed-off-by: Bard Liao
Reviewed-by: Rander Wang
---
drivers/base/regmap/regmap-sdw.c | 4 ++--
drivers/soundwire
From: Pierre-Louis Bossart
There is no need to play with pm_runtime reference counts, if needed
the codec drivers are already explicitly resumed.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 26
Use no_pm versions for write and read.
Signed-off-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
---
drivers/base/regmap/regmap-sdw-mbq.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/base/regmap/regmap-sdw-mbq.c
b/drivers
of read/write
functions')
Fixes: aa79293517b39 ('soundwire: bus: fix io error when processing alert
event')
Fixes: 9d715fa005ebc ('soundwire: Add IO transfer')
Reported-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire
ice number is not zero, we
should use >dev to provide more precisions to the
user/integrator.
Reported-by: Rander Wang
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 63 +
1 file chang
We wrote 1 to the handled interrupts bits along with 0 to all other bits
to the SoundWire DPx interrupt register. However, DP0 has reserved fields
and the read-only SDCA_CASCADE bit. DPN also has reserved fields. We should
not try to write values in these fields.
Besides, we deal with pending
From: Pierre-Louis Bossart
The code loops multiple times to deal with pending interrupts, but we
never reset the slave_notify status.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 4 +++-
1 file changed, 3
in the first
read. This strategy helps meet SoundWire requirements without
remaining forever in an interrupt handler.
Add a couple of comments to document this design.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 7
From: Pierre-Louis Bossart
We should only access the fields that are relevant for DP0, and never
write to reserved or read-only SDCA_CASCADE fields.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 8 +---
1
From: Pierre-Louis Bossart
Mirror the changes made for DP0 and don't modify reserved fields.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
interrupts as well.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
include/linux/soundwire/sdw_registers.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/linux/soundwire/sdw_registers.h
b/include/linux/soundwire
will suspend when all its children are no longer active.
Fixes: bd84256e86ecf ('soundwire: master: enable pm runtime')
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/master.c | 14 ++
1 file changed, 14 insertions(+)
diff
From: Pierre-Louis Bossart
Explicitly add header files used by regmap SoundWire support.
Suggested-by: Guennadi Liakhovetski
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Kai Vehmanen
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/base
Signed-off-by: Bard Liao
---
sound/soc/intel/boards/sof_sdw.c | 40
1 file changed, 40 insertions(+)
diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c
index f251e046d74d..16503772965c 100644
--- a/sound/soc/intel/boards/sof_sdw.c
: return proper error for get_sdw_stream()')
Cc: Srinivas Kandagatla
Reported-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
include/sound/soc-dai.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/sound/soc
Sdw stream operation APIs can be called once per stream. Move these
operations to dailink ops. The linked series is "soundwire: Remove sdw
stream operations from Intel soundwire dai".
Pierre-Louis Bossart (3):
ASoC: soc-dai: clarify return value for get_sdw_stream()
ASOC: Intel: sof_sdw: add
-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
sound/soc/intel/boards/sof_sdw.c | 41
1 file changed, 41 insertions(+)
diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c
index 2463d432bf4d..f251e046d74d 100644
Sdw stream operation APIs can be called once per stream. Move these
operations to dailink ops. The linked series is "ASoC: Add sdw stream
operations to dailink ops".
Pierre-Louis Bossart (4):
soundwire: stream: fix NULL/IS_ERR confusion
soundwire: intel: fix NULL/ERR_PTR confusion
Bossart
Signed-off-by: Bard Liao
---
drivers/soundwire/intel.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index d208c49b157a..a254f271acf2 100644
--- a/drivers/soundwire/intel.c
+++ b/drivers/soundwire
From: Pierre-Louis Bossart
snd_soc_dai_get_sdw_stream() can only return -ENOTSUPP or the stream,
NULL is not a possible value.
Fixes: 4550569bd779f ('soundwire: stream: add helper to startup/shutdown
streams')
Reported-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander
From: Pierre-Louis Bossart
Now that the stream trigger is handled at the dai-link level, there is
no need for a dai-level trigger any longer.
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/soundwire/intel.c | 39 ---
1 file
From: Pierre-Louis Bossart
snd_soc_dai_get_sdw_stream() can only return the pointer to stream or
an ERR_PTR value, NULL is not a possible value.
Fixes: 09553140c8d7b ('soundwire: intel: implement get_sdw_stream() operations')
Reported-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed
Signed-off-by: Bard Liao
---
sound/soc/intel/boards/sof_sdw.c | 40
1 file changed, 40 insertions(+)
diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c
index f251e046d74d..16503772965c 100644
--- a/sound/soc/intel/boards/sof_sdw.c
1 - 100 of 330 matches
Mail list logo
