Re: Is gcc thread-unsafe?

2007-10-26 Thread Bart Van Assche
/msg00465.html Bart Van Assche. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Is gcc thread-unsafe?

2007-10-26 Thread Bart Van Assche
On 10/26/07, Linus Torvalds [EMAIL PROTECTED] wrote: On Fri, 26 Oct 2007, Linus Torvalds wrote: On Fri, 26 Oct 2007, Bart Van Assche wrote: You can find my proposal to improve gcc here: http://gcc.gnu.org/ml/gcc/2007-10/msg00465.html Btw, I think this is fine per se, but putting

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-12 Thread Bart Van Assche
incorrect: * transport_allocate_passthrough(). * iscsi_do_build_list(). Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: Integration of SCST in the mainstream Linux kernel

2008-02-15 Thread Bart Van Assche
On Thu, Feb 7, 2008 at 2:45 PM, Vladislav Bolkhovitin [EMAIL PROTECTED] wrote: Bart Van Assche wrote: Since the focus of this thread shifted somewhat in the last few messages, I'll try to summarize what has been discussed so far: - There was a number of participants who joined

Re: BUG/ spinlock lockup, 2.6.24

2008-02-15 Thread Bart Van Assche
you already run memtest ? You can run memtest by booting from the Knoppix CD-ROM or DVD. Most Linux distributions also have included memtest on their bootable distribution CD's/DVD's. Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [patch 01/10] scsi: make __scsi_alloc_queue numa-aware

2012-11-02 Thread Bart Van Assche
On 10/30/12 21:14, Jeff Moyer wrote: Pass the numa node id set in the Scsi_Host on to blk_init_queue_node in order to keep all allocations local to the numa node the device is closest to. Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/scsi_lib.c |2 +- 1 files changed, 1

Re: [patch,v2 01/10] scsi: add scsi_host_alloc_node

2012-11-03 Thread Bart Van Assche
On 11/02/12 22:45, Jeff Moyer wrote: diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c index 593085a..7d7ad8b 100644 --- a/drivers/scsi/hosts.c +++ b/drivers/scsi/hosts.c @@ -336,16 +336,25 @@ static struct device_type scsi_host_type = { **/ struct Scsi_Host *scsi_host_alloc(struct

Re: [patch,v2 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node

2012-11-03 Thread Bart Van Assche
On 11/02/12 22:45, Jeff Moyer wrote: diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 2936b44..4db6973 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -173,16 +173,20 @@ static DEFINE_MUTEX(host_cmd_pool_mutex); * NULL on failure */ static struct scsi_cmnd *

Re: [patch,v2 05/10] sd: use alloc_disk_node

2012-11-03 Thread Bart Van Assche
On 11/02/12 22:45, Jeff Moyer wrote: Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/sd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 12f6fdf..8deb915 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c

Re: [patch,v2 05/10] sd: use alloc_disk_node

2012-11-05 Thread Bart Van Assche
On 11/05/12 15:12, Jeff Moyer wrote: Bart Van Assche bvanass...@acm.org writes: On 11/02/12 22:45, Jeff Moyer wrote: Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/sd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers

Re: [PATCH] prevent CVE-2012-2372 rds-ping causes kernel panic

2012-10-22 Thread Bart Van Assche
On 10/22/12 20:12, Jay Fenlason wrote: If you use rds-ping of the local IP address of some Infiniband HCAs (QLogic, possibly others) the machine will panic with a BUG_ON due to an overly restrictive check. Loosen the restriction a bit This should have gotten sent a while ago (it was first

Re: [patch/rfc/rft] sd: allocate request_queue on device's local numa node

2012-10-23 Thread Bart Van Assche
On 10/22/12 21:01, Jeff Moyer wrote: All of the infrastructure is available to allocate a request_queue on a particular numa node, but it isn't being utilized at all. Wire up the sd driver to allocate the request_queue on the HBA's local numa node. This is a request for comments and testing

Re: [patch/rfc/rft] sd: allocate request_queue on device's local numa node

2012-10-23 Thread Bart Van Assche
On 10/23/12 18:52, Jeff Moyer wrote: Bart Van Assche bvanass...@acm.org writes: Please keep in mind that a single PCIe bus may have a minimal distance to more than one NUMA node. See e.g. the diagram at the top of page 8 in http://bizsupport1.austin.hp.com/bc/docs/support/SupportManual

Re: [RESEND PATCH] scsi: make struct scsi_varlen_cdb_hdr packed

2012-10-11 Thread Bart Van Assche
On 10/11/12 11:15, James Hogan wrote: The struct scsi_varlen_cdb_hdr is expected to be exactly 10 bytes when used in struct osd_cdb_head, but it isn't marked as packed. Some architectures will round the struct size up which triggers BUILD_BUG_ON compile errors in osd_initiator.c when the outer

Re: [patch,v3 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node

2012-11-10 Thread Bart Van Assche
On 11/09/12 20:18, Jeff Moyer wrote: - cmd = kmem_cache_zalloc(pool-cmd_slab, gfp_mask | pool-gfp_mask); + cmd = kmem_cache_alloc_node(pool-cmd_slab, + gfp_mask | pool-gfp_mask | __GFP_ZERO, + node); Hello Jeff,

[PATCH] I2C: add support for the PCF8575 chip

2007-10-05 Thread Bart Van Assche
From: Bart Van Assche Add support for the PCF8575 I2C chip. Signed-off-by: Bart Van Assche ([EMAIL PROTECTED]) --- diff -uprN -X orig/linux-2.6.22.9/Documentation/dontdiff orig/linux-2.6.22.9/drivers/i2c/chips/Kconfig linux-2.6.22.9/drivers/i2c/chips/Kconfig --- orig/linux-2.6.22.9/drivers/i2c

Re: I/O blocked while dirty pages are being flushed

2013-03-24 Thread Bart Van Assche
On 03/24/13 06:12, Fredrik Tolf wrote: While this flush is running, I find that many a process goes into disk sleep waiting for the flush to complete. This includes the process manipulating the mmapped file whenever it tries to redirty a page currently waiting to be flushed, but also, for

Re: [PATCH V7 4/5] virtio-scsi: introduce multiqueue support

2013-03-25 Thread Bart Van Assche
On 03/23/13 12:28, Wanlong Gao wrote: +static struct virtio_scsi_vq *virtscsi_pick_vq(struct virtio_scsi *vscsi, + struct virtio_scsi_target_state *tgt) +{ + struct virtio_scsi_vq *vq; + unsigned long flags; + u32 queue_num; + +

Re: Improving AIO cancellation

2013-02-08 Thread Bart Van Assche
On 02/08/13 04:42, Anatol Pomozov wrote: Hi, At Google we have several applications that heavily use asynchronous IO. One thing that our userspace developers need is effective AIO cancellation. You might say sure use io_cancel syscall. Well, while it cancels AIO requests it does it

Re: [PATCH] IB/lmx4: silence GCC warning

2013-02-13 Thread Bart Van Assche
On 10/29/12 10:50, Paul Bolle wrote: On Wed, 2012-10-10 at 09:23 +0200, Jack Morgenstein wrote: You could use: u16 uninitialized_var(vlan); instead. I guess we'd better just wait and see whether uninitialized_var() survives before discussing your suggestion (see the thread starting at

Re: How to online remove an error scsi disk from the system?

2013-01-31 Thread Bart Van Assche
On 02/01/13 07:13, Tao Ma wrote: In our product system, we have several sata disks attached to one machine. So when one of the disk fails, the jbd2(yes, we use ext4) will hang forever and we will get something in /var/log/messages like below. It seems to me that the io sent to the scsi

Re: [GIT PULL] Final round of SCSI updates for the 3.8+ merge window

2013-03-01 Thread Bart Van Assche
On 03/01/13 10:19, James Bottomley wrote: This is an assorted set of stragglers into the merge window with driver updates for qla2xxx, megaraid_sas, storvsc and ufs. It also includes pulls of the uapi tree (all the remaining SCSI pieces) and the fcoe tree (updates to fcoe and libfc) Hello

Re: [PATCH 1/2] virtio-scsi: fix parsing of hotplug/hot-unplug LUN number

2012-07-26 Thread Bart Van Assche
On 07/26/12 09:21, James Bottomley wrote: On Thu, 2012-07-26 at 11:04 +0200, Paolo Bonzini wrote: Il 26/07/2012 10:52, James Bottomley ha scritto: +static unsigned int virtscsi_get_lun(u8 *lun_bytes) +{ + unsigned int lun = (lun_bytes[2] 8) | lun_bytes[3]; + return lun 16383; +} + Why

Re: [PATCH 0/5] Fix bugs in ib_srp patches for H.A. purposes

2012-09-01 Thread Bart Van Assche
On 08/31/12 20:00, dongsu.p...@profitbricks.com wrote: This patchset aims at fixing bugs that have been discovered in our own SRP test environment so far. These patches are based on your patchset v4, Make ib_srp better suited for H.A. purposes,(09 Aug 2012). The 5th patch, fix an error

Re: [PATCH][SCSI] remove the queue unlock in scsi_requset_fn

2012-08-13 Thread Bart Van Assche
On 08/10/12 03:22, Chanho Min wrote: We don't need to unlock the queue before put_device in scsi_request_fn() It looks like there is a typo in the patch subject ? Also, you can omit [SCSI] from the patch subject - AFAIK James has a script that inserts that text automatically. Bart. -- To

Re: [PATCH RESEND] remove the queue unlock in scsi_requset_fn

2012-08-16 Thread Bart Van Assche
On 08/16/12 01:35, Chanho Min wrote: functions will occur in line. I also don't see why the sdev reference couldn't drop to zero here. scsi_request_fn is called under the lock of request_queue-queue_lock. If we drop the sdev reference to zero here, scsi_device_dev_release_usercontext is

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

2012-08-07 Thread Bart Van Assche
On 08/07/12 08:53, Chanho Min wrote: On Tue, Aug 7, 2012 at 2:56 AM, Bart Van Assche bvanass...@acm.org wrote: Indeed. How about the patch below ? Scsi devices are removed from starved_list after blk_cleanup_queue() and before put_device(). That guarantees that inside scsi_run_queue

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

2012-08-07 Thread Bart Van Assche
On 08/07/12 08:53, Chanho Min wrote: In addition, Is it ironic that we are careful to use put_device at scsi_request_fn?. If we trigger the -remove(), It occur a oops. What about the removal of unlock/lock as patch bellow? diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

2012-08-08 Thread Bart Van Assche
On 08/08/12 03:42, Chanho Min wrote: Thank you for the explanation. It look correct. Let's check one more thing. What If __scsi_remove_device doesn't release device? : reference count is more than 2. So We lost starved_list but device is exist. Is there any issue about this? As far as I can

Kernel hangs in truncate_inode_pages()

2012-08-24 Thread Bart Van Assche
Hello, If I log in with the open-iscsi initiator to an iSCSI target an power down the target the initiator hangs in truncate_inode_pages(). This happens systematically with kernel 3.6-rc3 and it's something I've never seen with kernel 3.4 or before. Has anyone else already run into this issue ?

Re: Kernel hangs in truncate_inode_pages()

2012-08-24 Thread Bart Van Assche
On 08/24/12 17:24, Mike Christie wrote: On 08/24/2012 08:13 AM, Bart Van Assche wrote: If I log in with the open-iscsi initiator to an iSCSI target an power down the target the initiator hangs in truncate_inode_pages(). This happens systematically with kernel 3.6-rc3 and it's something I've

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

2012-08-04 Thread Bart Van Assche
On 08/02/12 08:41, Chanho Min wrote: This patch is to fix a oops from a torn down device. When scsi_run_queue process starved queues, scsi_request_fn can race with scsi_remove_device. In this case, rarely, scsi_request_fn release the last reference and set sdev-request_queue to NULL. It result

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

2012-08-04 Thread Bart Van Assche
On 08/04/12 16:46, Mike Christie wrote: I think we have to have scsi-ml do a get_device when a sdev is added to the starved entry and then do a put_device when it is removed (must do these under the host lock for the starved entry case too). I am not sure if that is just a hack/papering-over

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

2012-08-06 Thread Bart Van Assche
On 08/04/12 22:36, Mike Christie wrote: On 08/04/2012 03:18 PM, Bart Van Assche wrote: On 08/04/12 16:46, Mike Christie wrote: I think we have to have scsi-ml do a get_device when a sdev is added to the starved entry and then do a put_device when it is removed (must do these under the host

Re: [PATCH RESEND] remove the queue unlock in scsi_requset_fn

2012-08-18 Thread Bart Van Assche
On 08/16/12 07:52, Bart Van Assche wrote: On 08/16/12 01:35, Chanho Min wrote: functions will occur in line. I also don't see why the sdev reference couldn't drop to zero here. scsi_request_fn is called under the lock of request_queue-queue_lock. If we drop the sdev reference to zero here

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Bart Van Assche
). Another issue I have to look further into is that dd and xdd report different results for very large block sizes ( 1 MB). Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [Cbe-oss-dev] LIO Target iSCSI/SE PS3-Linux / FC8 builds

2008-02-04 Thread Bart Van Assche
detection script ? config.guess is included with a.o. automake and libtool. Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Bart Van Assche
performing streaming, database like accesses and small file transactions. Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: kara_am

2008-02-05 Thread Bart Van Assche
-6 Pages: 1062 Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Bart Van Assche
graphs, see also http://software.qlayer.com/display/iSCSI/Measurements . Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Bart Van Assche
for 99% of all people. Please read my e-mail (posted earlier today) with a comparison for 4 KB - 64 KB block transfer sizes between SCST and STGT. Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

Re: Integration of SCST in the mainstream Linux kernel

2008-02-06 Thread Bart Van Assche
device each run in another operating system: the filesystem runs inside the virtual machine and iSCSI either runs in the hypervisor or in the native OS. Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: Integration of SCST in the mainstream Linux kernel

2008-02-06 Thread Bart Van Assche
will see that all data is transferred via RDMA and not via TCP/IP. Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-07 Thread Bart Van Assche
of the existing iSCSI kernel target implementations (iETD, STGT, SCST and PyX/LIO). As an iSCSI user, I prefer option (3). The big question is whether the various storage target authors agree with this ? Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: Integration of SCST in the mainstream Linux kernel

2008-01-30 Thread Bart Van Assche
values for the following iSER parameters: FirstBurstLength, MaxBurstLength and MaxRecvDataSegmentLength (16 MB, which is more than the 1 MB block size specified to dd). Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: Integration of SCST in the mainstream Linux kernel

2008-01-30 Thread Bart Van Assche
and also implementing a new caching mechanism using pre-registered buffers). See also: http://sourceforge.net/mailarchive/forum.php?forum_name=scst-develviewmonth=200801viewday=17 Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: Integration of SCST in the mainstream Linux kernel

2008-01-30 Thread Bart Van Assche
On Jan 30, 2008 11:56 AM, FUJITA Tomonori [EMAIL PROTECTED] wrote: On Wed, 30 Jan 2008 09:38:04 +0100 Bart Van Assche [EMAIL PROTECTED] wrote: Please specify which parameters you are referring to. As you know I Sorry, I can't say. I don't know much about iSER. But seems that Pete

Re: Integration of SCST in the mainstream Linux kernel

2008-01-30 Thread Bart Van Assche
On Jan 30, 2008 5:34 PM, James Bottomley [EMAIL PROTECTED] wrote: On Wed, 2008-01-30 at 09:38 +0100, Bart Van Assche wrote: On Jan 30, 2008 12:32 AM, FUJITA Tomonori [EMAIL PROTECTED] wrote: iSER has parameters to limit the maximum size of RDMA (it needs to repeat RDMA with a poor

Re: Integration of SCST in the mainstream Linux kernel

2008-01-30 Thread Bart Van Assche
On Jan 30, 2008 5:22 PM, James Bottomley [EMAIL PROTECTED] wrote: ... Deciding what lives in userspace and what should be in the kernel lies at the very heart of architectural decisions. However, the argument that it should be in the kernel because that would make it faster is pretty much a

Re: Integration of SCST in the mainstream Linux kernel

2008-01-31 Thread Bart Van Assche
-- any hints with regard to suitable combinations of command line parameters are welcome. The most recent version I could find on http://ltp.sourceforge.net/ is ltp-20071231. Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-01-31 Thread Bart Van Assche
with Bonnie++, but found out that on a fast network like IB the filesystem used for the test has a really big impact on the test results. If anyone has a suggestion for a better test than dd to compare the performance of SCSI storage protocols, please let it know. Bart Van Assche. -- To unsubscribe from

Re: Integration of SCST in the mainstream Linux kernel

2008-01-31 Thread Bart Van Assche
Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Bart Van Assche
information about licensing deals. Licensing deals can only be closed for software that is not entirely licensed under the GPL. Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Bart Van Assche
: InfiniBand Trade Association, InfiniBand Architecture Specification Release 1.2.1, http://www.infinibandta.org/specs/register/publicspec/ Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Bart Van Assche
On Feb 1, 2008 11:39 AM, Nicholas A. Bellinger [EMAIL PROTECTED] wrote: On Fri, 2008-02-01 at 09:11 +0100, Bart Van Assche wrote: On Jan 31, 2008 2:25 PM, Nicholas A. Bellinger [EMAIL PROTECTED] wrote: The PyX storage engine supports a scatterlist linked list algorithm

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.25

2008-01-23 Thread Bart Van Assche
On Jan 18, 2008 1:11 AM, Roland Dreier [EMAIL PROTECTED] wrote: Anyway, here are all the pending things that I'm aware of. As usual, if something isn't already in my tree and isn't listed below, I probably missed it or dropped it by mistake. Please remind me again in that case. Are there

Re: Integration of SCST in the mainstream Linux kernel

2008-02-18 Thread Bart Van Assche
. As an example, I obtained the following numbers on my setup (SDR 4x network); ib_write_bw: 933 MB/s. ib_read_bw: 905 MB/s. ib_send_bw: 931 MB/s. Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

SMP-related kernel memory leak

2008-02-19 Thread Bart Van Assche
anyone notice anything similar ? See also: http://bugzilla.kernel.org/show_bug.cgi?id=9991 Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: SMP-related kernel memory leak

2008-02-19 Thread Bart Van Assche
On Feb 19, 2008 7:18 PM, Oliver Pinter [EMAIL PROTECTED] wrote: On 2/19/08, Bart Van Assche [EMAIL PROTECTED] wrote: I noticed that the amount of memory used by the Linux kernel steadily increases over time on SMP systems (x86 architecture, 32-bit kernel). This problem disappears when I add

Re: Integration of SCST in the mainstream Linux kernel

2008-02-20 Thread Bart Van Assche
On Feb 20, 2008 8:34 AM, Erez Zilber [EMAIL PROTECTED] wrote: Bart Van Assche wrote: Or: data sent during the first burst is not transferred via one-sided remote memory reads or writes but via two-sided send/receive operations. At least on my setup, these operations are as fast as one

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread Bart Van Assche
the lines are very long (more than 160 characters). Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread Bart Van Assche
with checkpatch is that most checkpatch complaints are easy to resolve. Bart Van Assche. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: Is gcc thread-unsafe?

2007-11-02 Thread Bart Van Assche
by calls to locking functions. Bart Van Assche. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Is gcc thread-unsafe?

2007-11-04 Thread Bart Van Assche
On 11/2/07, Andrew Haley [EMAIL PROTECTED] wrote: Bart Van Assche writes: On 10/30/07, Andrew Haley [EMAIL PROTECTED] wrote: That's what the proposed standard language says, kinda-sorta. There's an informal description at http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2338

Re: Is gcc thread-unsafe?

2007-11-04 Thread Bart Van Assche
On 11/4/07, Linus Torvalds [EMAIL PROTECTED] wrote: On Sun, 4 Nov 2007, Bart Van Assche wrote: Has it already been decided who will do this audit, and when this audit will happen ? Has a target date been set when this audit should be complete, or is the completion of this audit

Re: Deadlock observed in SCSI device removal

2012-12-15 Thread Bart Van Assche
On 12/15/12 05:22, Amit Sahrawat wrote: We are using kernel version 3.0.33, and the patch which is mentioned for the above problem - is already applied in the kernel. If the kernel reports that io_schedule() hangs that usually means that an I/O request was not finished properly. It would help

Re: [patch,v3 00/10] make I/O path allocations more numa-friendly

2012-11-16 Thread Bart Van Assche
five patches in this series: Reviewed-by: Bart Van Assche bvanass...@acm.org Bart. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

[PATCH] kbuild: Unbreak cleaning external module build directory

2012-11-18 Thread Bart Van Assche
...@gmail.com Cc: Nick Bowler nbow...@elliptictech.com Cc: Richard Weinberger rich...@nod.at Cc: Michal Marek mma...@suse.cz Cc: sta...@vger.kernel.org Signed-off-by: Bart Van Assche bvanass...@acm.org --- Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile

Re: [GIT PULL] please pull infiniband.git

2013-07-10 Thread Bart Van Assche
On 07/10/13 16:38, Roland Dreier wrote: On Wed, Jul 10, 2013 at 7:35 AM, Sebastian Riemer sebastian.rie...@profitbricks.com wrote: I've checked the commits on that tag and the following commit is not what we've agreed on: Sorry about that. The discussion was long and complex and I probably

Re: [PATCH] [SCSI] sg: late O_EXCL fix for lk 3.12-rc

2013-10-20 Thread Bart Van Assche
On 10/20/13 18:09, Douglas Gilbert wrote: Given that lk 3.12.0 release is not far away, the safest path may still be to revert Vaughan Cao's patch. I'll leave that decision to the maintainers. Hello Doug, Thanks for looking into this. But I would appreciate it if you could address the

Re: [PATCH] drivers: scsi: scsi_lib.c: add prefix SCSILIB_ to macro SP

2013-12-01 Thread Bart Van Assche
On 11/27/13 03:29, Chen Gang wrote: the macro SP is too common to make conflict with some architectures, so recommend to add prefix for it. The related warning (with allmodconfig for hexagon): CC [M] drivers/scsi/scsi_lib.o drivers/scsi/scsi_lib.c:46:0: warning: SP redefined

Re: [PATCH] scsi: avoid use of reclaimed reference

2013-11-13 Thread Bart Van Assche
On 11/13/13 02:10, David Decotigny wrote: This patch avoids to use an object after it was potentially reclaimed by scsi_device_put(). Signed-off-by: David Decotigny de...@googlers.com --- drivers/scsi/scsi_scan.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] percpu_ida: Handle out-of-tags gracefully

2014-03-12 Thread Bart Van Assche
On 03/12/14 16:21, Alexander Gordeev wrote: While 'remote-nr_free' could be dropped on another CPU it still does not explain how steal_tags() enters the loop, but fails to locate 'cpus_have_tags' count of bits. So although v2 of your patch fixes the crash it does not address the root cause

[PATCH] percpu_ida: Handle out-of-tags gracefully

2014-03-10 Thread Bart Van Assche
] vfs_read+0x9b/0x160 [8114b389] SyS_read+0x49/0xa0 [81416049] tracesys+0xd0/0xd5 ---[ end trace cdd1a8a7968266cf ]--- Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Kent Overstreet k...@daterainc.com Cc: Shaohua Li s...@kernel.org Cc: Christoph Hellwig h...@lst.de Cc: Jens

Re: [PATCH] percpu_ida: Handle out-of-tags gracefully

2014-03-11 Thread Bart Van Assche
On 03/11/14 14:51, Alexander Gordeev wrote: On Mon, Mar 10, 2014 at 03:12:33PM +0100, Bart Van Assche wrote: Avoid that percpu_ida_alloc() hangs or crashes if there are still tags are available. Wait until a tag becomes available instead of giving up when running out of tags temporarily

Re: [PATCH] percpu_ida: Handle out-of-tags gracefully

2014-03-12 Thread Bart Van Assche
On 03/11/14 21:48, Alexander Gordeev wrote: On Tue, Mar 11, 2014 at 07:10:18PM +0100, Bart Van Assche wrote: I assume the BUG() above hits? If so, I am failing to understand how the code gets here. Mind elaborate? You are correct, the BUG() mentioned in the call stack in the description

Re: [PATCH] percpu_ida: Handle out-of-tags gracefully

2014-03-12 Thread Bart Van Assche
On 03/12/14 09:41, Alexander Gordeev wrote: Still the hunk below (a) breaks the 'pool-percpu_max_size' threshold and (b) somehow suboptimal, because you wake another thread while a free tag was/is on this CPU. If it is still here we would better to grab it. If not, it was stolen by another

[PATCH v2] percpu_ida: Handle out-of-tags gracefully

2014-03-12 Thread Bart Van Assche
+0xd0/0xd5 ---[ end trace cdd1a8a7968266cf ]--- Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Alexander Gordeev agord...@redhat.com CC: Jens Axboe ax...@kernel.dk Cc: Kent Overstreet k...@daterainc.com Cc: Shaohua Li s...@kernel.org Cc: Christoph Hellwig h...@lst.de Cc: Mike Christie micha

Re: RFC: Allow block drivers to poll for I/O instead of sleeping

2013-06-25 Thread Bart Van Assche
On 06/25/13 05:18, Matthew Wilcox wrote: On Mon, Jun 24, 2013 at 10:07:51AM +0200, Ingo Molnar wrote: I'm wondering, how will this scheme work if the IO completion latency is a lot more than the 5 usecs in the testcase? What if it takes 20 usecs or 100 usecs or more? There's clearly a

Re: [PATCH] scsi_prep_fn() check for empty queue

2013-06-26 Thread Bart Van Assche
On 06/26/13 11:02, Maxim Uvarov wrote: This fix: end_request: I/O error, dev sdc, sector 976576 rport-0:0-3: blocked FC remote port time out: removing target and saving binding BUG: unable to handle kernel NULL pointer dereference at 0400 IP: [812f0cc2]

Re: [PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

2013-05-30 Thread Bart Van Assche
On 05/30/13 01:01, Andrew Morton wrote: On Tue, 21 May 2013 20:43:50 +0200 Bart Van Assche bart.vanass...@gmail.com wrote: Make sure that the round_jiffies*() functions return a time that is in the future when the jiffies counter is about to wrap. Actually when the jiffies counter has

[PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

2013-05-21 Thread Bart Van Assche
Make sure that the round_jiffies*() functions return a time that is in the future when the jiffies counter is about to wrap. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Thomas Gleixner t...@linutronix.de Cc: Arjan van de Ven ar...@infradead.org Cc: Stephen Rothwell s...@canb.auug.org.au

Re: [PATCH] scsi: bfa: bfad_attr.c: Optimization of the Code

2014-06-05 Thread Bart Van Assche
On 06/04/14 20:08, Rickard Strandqvist wrote: Minimized the use of snprintf() And removed a variable that was only used for the temporary storage. This was partly found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist

Re: [PATCH] scsi: bfa: bfad_attr.c: Optimization of the Code

2014-06-05 Thread Bart Van Assche
On 06/05/14 08:55, Bart Van Assche wrote: On 06/04/14 20:08, Rickard Strandqvist wrote: This is ugly. Please use sprintf(buf, %.*s\n, PAGE_SIZE - 1, str) instead of strncpy() + strlen(). (replying to my own e-mail) The above should of course have read sprintf(buf, %.*s\n, PAGE_SIZE - 2, str

Re: scsi-mq

2014-06-13 Thread Bart Van Assche
On 06/12/14 15:48, Christoph Hellwig wrote: The usage of blk-mq dramatically decreases CPU usage under all workloads going down from 100% CPU usage that the old setup can hit easily to usually less than 20% for maxing out storage subsystems with 512 byte reads and writes, and it allows to

Re: [PATCH v2] kref: warn on uninitialized kref

2014-05-17 Thread Bart Van Assche
On 05/17/14 14:38, Mikulas Patocka wrote: I found a memory leak in iSCSI target that was caused by kref initialized to zero (the memory object was allocated with kzalloc, kref_init was not called and kref_put_spinlock_irqsave was called which changed 0 to -1 and didn't free the object).

Re: [PATCH v2] kref: warn on uninitialized kref

2014-05-18 Thread Bart Van Assche
On 05/17/14 23:14, Mikulas Patocka wrote: BTW. if we talk about performance - what about replacing: if (atomic_dec_and_test(variable)) { ... release(object); } with this: if (atomic_read(variable) == 1 || atomic_dec_and_test(variable)) {

[PATCH RFC] block: Eliminate first argument of submit_bio()

2014-06-02 Thread Bart Van Assche
bi_rw. Note: some but not all submit_bio() callers have been fixed such that bi_rw is set before bio_add_page() is called. See also http://thread.gmane.org/gmane.comp.file-systems.ocfs2.devel/7988 for a prior discussion of this topic. Compile tested only, hence the RFC. Signed-off-by: Bart Van

[PATCH] Suppress -Wignored-qualifiers warnings

2014-06-14 Thread Bart Van Assche
Avoid that gcc reports the following warning when building with W=1: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Ingo Molnar mi...@kernel.org Cc: Peter Zijlstra pet...@infradead.org Cc: Vincent Guittot

[PATCH] spin_lock_*(): Always evaluate second argument

2014-06-16 Thread Bart Van Assche
= SINGLE_DEPTH_NESTING; ^ Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Ingo Molnar mi...@kernel.org Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: David S. Miller da...@davemloft.net --- include/linux/spinlock.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux

Re: scsi-mq

2014-06-17 Thread Bart Van Assche
On 06/12/14 15:48, Christoph Hellwig wrote: Bart and Robert have helped with some very detailed measurements that they might be able to send in reply to this, although these usually involve significantly reworked low level drivers to avoid other bottle necks. In case someone would like to see

Re: scsi-mq

2014-06-18 Thread Bart Van Assche
On 06/18/14 05:44, Jens Axboe wrote: Thanks for posting these numbers, Bart. The CPU utilization and IOPS speak a very clear message. The only mystery is why the singe threaded performance is down. That we need to get sort, but it's not a show stopper for inclusion. If you run the single

Re: [PATCH 4/6] scsi_error: fix invalid setting of host byte

2014-06-04 Thread Bart Van Assche
On 06/03/14 21:33, Paolo Bonzini wrote: From: Ulrich Obergfell uober...@redhat.com After scsi_try_to_abort_cmd returns, the eh_abort_handler may have already found that the command has completed in the device, causing the host_byte to be nonzero (e.g. it could be DID_ABORT). When this

Re: [PATCH v2 0/6] virtio-scsi patches for 3.16 + midlayer fix

2014-06-04 Thread Bart Van Assche
On 06/04/14 12:11, Paolo Bonzini wrote: v1-v2: fix all occurrences of scmd-result |= DID_TIME_OUT 16 in patch 4 Hello Paolo, Thanks for the quick respin. However, since you are mentioning that in v2 all occurrences of scmd-result |= DID_TIME_OUT 16 have been addressed, this made me

Re: [PATCH] trivial: scsi: Fix warning on make htmldocs caused by scsi_transport_srp.c

2014-02-03 Thread Bart Van Assche
On 02/03/14 15:34, Masanari Iida wrote: This patch fixed following warnings on make htmldocs. Warning(/drivers/scsi/scsi_transport_srp.c:819): No description found for parameter 'rport' Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/scsi/scsi_transport_srp.c | 2 ++ 1

[0/3] Driver core patches for kernel 3.14

2014-01-04 Thread Bart Van Assche
This series consists of the following three patches: 0001-kobject-Fix-source-code-comment-spelling.patch 0002-firmware-loader-Add-sparse-annotation.patch 0003-driver-core-Fix-use-after-free-triggered-by-bus_unre.patch -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the

[PATCH 1/3] kobject: Fix source code comment spelling

2014-01-04 Thread Bart Van Assche
Signed-off-by: Bart Van Assche bvanass...@acm.org --- lib/kobject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/kobject.c b/lib/kobject.c index 5b4b888..0061f55 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -346,7 +346,7 @@ static int kobject_add_varg(struct

[PATCH 2/3] firmware loader: Add sparse annotation

2014-01-04 Thread Bart Van Assche
Avoid that sparse reports the following warning on __fw_free_buf(): drivers/base/firmware_class.c:230:9: warning: context imbalance in '__fw_free_buf' - unexpected unlock Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Ming Lei ming@canonical.com --- drivers/base/firmware_class.c | 1

[PATCH 3/3] driver-core: Fix use-after-free triggered by bus_unregister()

2014-01-04 Thread Bart Van Assche
]--- Signed-off-by: Bart Van Assche bvanass...@acm.org --- drivers/base/bus.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/base/bus.c b/drivers/base/bus.c index 73f6c29..59dc808 100644 --- a/drivers/base/bus.c +++ b/drivers/base/bus.c @@ -146,8 +146,19

Re: [dm-devel] [PATCH] kobject: provide kobject_put_wait to fix module unload race

2014-01-05 Thread Bart Van Assche
On 01/04/14 19:06, Mikulas Patocka wrote: - if (t !t-release) - pr_debug(kobject: '%s' (%p): does not have a release() - function, it is broken and must be fixed.\n, - kobject_name(kobj), kobj); - Has it been considered to issue a

  1   2   3   4   5   6   7   8   9   10   >