Re: [PATCH] ALSA: hda/realtek: Limit mic boost on T480

2018-03-06 Thread Benjamin Berg
cking connector at the side (which is USB-C + 14 pins primarily for Ethernet incl. LEDs and likely some other purpose). Thanks, Benjamin > -Original Message- > From: Peter FP1 Zhang > Sent: Wednesday, February 21, 2018 12:07 AM > To: 'Takashi Iwai' > Cc: Benjamin

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

2018-06-04 Thread Benjamin Berg
Hi, On Thu, 2018-05-24 at 16:33 +0800, Chris Chiu wrote: > I've made my change to set the brightness level directly in the > driver, but the > OSD doesn't show correctly correspond to the level value. The brightness shows > OK in /sys/class/led//brighness but the OSD always shows level 0. I >

Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

2018-06-05 Thread Benjamin Berg
Hey, On Tue, 2018-06-05 at 12:31 +0200, Hans de Goede wrote: > On 05-06-18 12:14, Bastien Nocera wrote: > > On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote: > > > On 05-06-18 11:58, Bastien Nocera wrote: > > > > [SNIP] > > > > > > Ok, so what are you suggestion, do you really want to hardc

Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

2018-06-06 Thread Benjamin Berg
Hi, On Wed, 2018-06-06 at 10:50 +0800, Chris Chiu wrote: > On Tue, Jun 5, 2018 at 7:06 PM, Hans de Goede > wrote: > > Hi, > > > > > > On 05-06-18 12:46, Benjamin Berg wrote: > > > > > > Hey, > > > > > > On Tue, 2018-06-05 at

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

2018-05-15 Thread Benjamin Berg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Daniel, I had a quick chat with Bastien about this. The conclusion was that reusing the TOGGLE key may be problematic for gnome-settings-daemon. And the alternative of a new CYCLE key also has some caveats. The most straight forward solution is

Re: [PATCH 0/4 POC] Allow executing code and syscalls in another address space

2021-04-14 Thread Benjamin Berg
On Wed, 2021-04-14 at 09:34 +0200, Johannes Berg wrote: > On Wed, 2021-04-14 at 08:22 +0100, Anton Ivanov wrote: > > On 14/04/2021 06:52, Andrei Vagin wrote: > > > We already have process_vm_readv and process_vm_writev to read and > > > write > > > to a process memory faster than we can do this wit

[PATCH] x86/mce: Lower throttling MCE messages to warnings

2019-10-09 Thread Benjamin Berg
limitting the long term power consumption of the package. So these messages do not usually indicate a hardware issue (e.g. insufficient cooling). Log them as warnings to avoid confusion about their severity. Signed-off-by: Benjamin Berg Tested-by: Christian Kellner --- arch/x86/kernel/cpu/mce

Re: [PATCH] x86/mce: Lower throttling MCE messages to warnings

2019-10-11 Thread Benjamin Berg
ivas > > > > Signed-off-by: Benjamin Berg > > > Tested-by: Christian Kellner > > > --- > > > arch/x86/kernel/cpu/mce/therm_throt.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/

Re: [PATCH] drivers: thermal: processor_thermal_device: Export sysfs inteface for TCC offset

2019-07-24 Thread Benjamin Berg
Tested-by: Benjamin Berg Hi, this patch allows performance improvements of some machines. It would be nice if this could still make 5.3. Benjamin On Mon, 2019-07-22 at 18:03 -0700, Srinivas Pandruvada wrote: > This change exports an interface to read tcc offset and allow writing if &g

Re: [RFC] Documentation: Add documentation for new performance_profile sysfs class

2020-10-05 Thread Benjamin Berg
rofile of these automatic-mechanisms. > > Cc: Mark Pearson > Cc: Elia Devito > Cc: Bastien Nocera > Cc: Benjamin Berg > Cc: linux...@vger.kernel.org > Cc: linux-a...@vger.kernel.org > Signed-off-by: Hans de Goede > --- > .../testing/sysfs-class-performance_pr

[PATCH 0/2] UCSI race condition resulting in wrong port state

2020-10-09 Thread Benjamin Berg
From: Benjamin Berg Hi all, so, I kept running in an issue where the UCSI port information was saying that power was being delivered (online: 1), while no cable was attached. The core of the problem is that there are scenarios where UCSI change notifications are lost. This happens because

[PATCH 2/2] usb: typec: ucsi: Work around PPM losing change information

2020-10-09 Thread Benjamin Berg
From: Benjamin Berg Some/many PPMs are simply clearing the change bitfield when a notification on a port is acknowledge. Unfortunately, doing so means that any changes between the GET_CONNECTOR_STATUS and ACK_CC_CI commands is simply lost. Work around this by re-fetching the connector status

[PATCH 1/2] usb: typec: ucsi: acpi: Always decode connector change information

2020-10-09 Thread Benjamin Berg
From: Benjamin Berg Normal commands may be reporting that a connector has changed. Always call the usci_connector_change handler and let it take care of scheduling the work when needed. Doing this makes the ACPI code path identical to the CCG one. Cc: Hans de Goede Cc: Heikki Krogerus Signed

Re: [PATCH 0/2] UCSI race condition resulting in wrong port state

2020-11-06 Thread Benjamin Berg
Hi, On Fri, 2020-11-06 at 11:47 +0100, Greg Kroah-Hartman wrote: > Due to the lack of response, I guess they don't need to go to any > stable kernel, so will queue them up for 5.11-rc1. Sorry, forgot to reply. Not including them in stable seems reasonable as I have not seen it cause major troubl

[PATCH] ALSA: hda/realtek: Limit mic boost on T480

2018-02-14 Thread Benjamin Berg
The internal mic boost on the T480 is too high. Fix this by applying the ALC269_FIXUP_LIMIT_INT_MIC_BOOST fixup to the machine to limit the gain. Signed-off-by: Benjamin Berg Tested-by: Benjamin Berg --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound

Re: [PATCH] ALSA: hda/realtek: Limit mic boost on T480

2018-02-14 Thread Benjamin Berg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Wed, 2018-02-14 at 14:00 +0100, Takashi Iwai wrote: > On Wed, 14 Feb 2018 13:29:39 +0100, > Benjamin Berg wrote: > > > > The internal mic boost on the T480 is too high. Fix this by > > applying the > > ALC269_FIXU

[PATCH] thinkpad_acpi: Implement tablet mode resolving using GMMS method

2017-09-15 Thread Benjamin Berg
method to query the tablet mode. Signed-off-by: Benjamin Berg Cc: Peter FP1 Zhang Cc: Lyude Paul --- drivers/platform/x86/thinkpad_acpi.c | 132 +++ 1 file changed, 119 insertions(+), 13 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers

[PATCHv2] thinkpad_acpi: Implement tablet mode resolving using GMMS method

2017-10-10 Thread Benjamin Berg
method to query the tablet mode. Signed-off-by: Benjamin Berg Cc: Peter FP1 Zhang Cc: Lyude Paul -- v2: - It appears that mode 4 may also report the FLAT state. This has been observed on an X1 Yoga 2nd Generation. --- drivers/platform/x86/thinkpad_acpi.c | 135

Re: ath9k: Fix beacon configuration assertion failure

2016-08-22 Thread Benjamin Berg
On Fr, 2016-08-19 at 13:03 +0300, Kalle Valo wrote: > Actually, I see two patches which might be related but not identical: > > ath9k: fix client mode beacon configuration > https://patchwork.kernel.org/patch/9247699/ > > ath9k: Fix beacon configuration assertion failure > https://patchwork.kerne

[tip: ras/core] x86/mce: Lower throttling MCE messages' priority to warning

2019-10-17 Thread tip-bot2 for Benjamin Berg
The following commit has been merged into the ras/core branch of tip: Commit-ID: 9c3bafaa1fd88e4dd2dba3735a1f1abb0f2c7bb7 Gitweb: https://git.kernel.org/tip/9c3bafaa1fd88e4dd2dba3735a1f1abb0f2c7bb7 Author:Benjamin Berg AuthorDate:Wed, 09 Oct 2019 17:54:24 +02:00 Committer