Gentle ping!
Benoit
Benoit Parrot wrote on Wed [2016-Sep-14 15:03:13 -0500]:
> The advertised V4L2 pixel format and Media Bus code don't match.
> The current media bud code advertised is MEDIA_BUS_FMT_YUYV8_2X8
> which does not reflect what the encoder actually outputs.
> This
The advertised V4L2 pixel format and Media Bus code don't match.
The current media bud code advertised is MEDIA_BUS_FMT_YUYV8_2X8
which does not reflect what the encoder actually outputs.
This encoder generate MEDIA_BUS_FMT_UYVY8_2X8 so advertise as such.
Signed-off-by: Benoit P
Rob Herring wrote on Tue [2017-Oct-17 16:00:51 -0500]:
> On Thu, Oct 12, 2017 at 02:27:17PM -0500, Benoit Parrot wrote:
> > Device Tree bindings for the Video Processing Engine (VPE) driver.
> >
> > Signed-off-by: Benoit Parrot
> > ---
> > Documentation/dev
Ping.
Benoit
Benoit Parrot wrote on Fri [2018-Oct-12 15:16:55 -0500]:
> This patch series adds virtual-plane support to omapdrm driver to allow the
> use
> of display wider than 2048 pixels.
>
> In order to do so we introduce the concept of hw_overlay which can then be
> dyn
Hi Rob,
For ti-vpe/cal.c,
Reviewed-by: Benoit Parrot
Regards,
Benoit
Rob Herring wrote on Wed [2018-Dec-05 13:50:29 -0600]:
> Convert string compares of DT node names to use of_node_name_eq helper
> instead. This removes direct access to the node name pointer.
>
> Cc: Kyungmi
Reviewed-by: Benoit Parrot
Tomi Valkeinen wrote on Thu [2018-May-24 10:58:25
+0300]:
>
> On 24/05/18 01:03, Tony Lindgren wrote:
> > Hi all,
> >
> > I bisected the n900 LCD issue to commit 24aac6011f70 ("drm: omapdrm:
> > sdi: Allocate the sdi private data
Daniel Vetter wrote on Tue [2018-Oct-16 14:29:46 +0200]:
> On Fri, Oct 12, 2018 at 03:17:00PM -0500, Benoit Parrot wrote:
> > Global shared resources (like hw overlays) for omapdrm are implemented
> > as a part of atomic state using the drm_private_obj infrastructure
> > av
Alexandre Courbot wrote on Wed [2014-Dec-10 19:56:17 +0900]:
> On Fri, Dec 5, 2014 at 6:02 AM, Benoit Parrot wrote:
> > Add GPIO hogging documentation to gpio.txt
> >
> > Signed-off-by: Benoit Parrot
> > ---
> > Changes since v2:
> > * Updated to the late
Alexandre Courbot wrote on Wed [2014-Dec-10 20:19:51 +0900]:
> On Fri, Dec 5, 2014 at 6:02 AM, Benoit Parrot wrote:
> > Based on Boris Brezillion's work this is a reworked patch
> > of his initial GPIO hogging mechanism.
> > This patch provides a way to initally config
of_gpiochip_remove
Changes since v1:
* Split the devicetree bindings documentation in its own patch.
* Refactor the gpio-hog mechanism as private functions meant to
be to invoked from of_gpiochip_add().
Benoit Parrot (2):
gpio: add GPIO hogging mechanism
gpio: Document GPIO hogging mecha
es to switch various modes and combination.
Specific drivers should not necessarily need to be aware of
what accounts to a specific board implementation. This board level
"description" should be best kept as part of the dts file.
Signed-off-by: Benoit Parrot
---
Changes since v2:
* Refact
Add GPIO hogging documentation to gpio.txt
Signed-off-by: Benoit Parrot
---
Changes since v2:
* Updated to the latest hog syntax.
Changes since v1:
* Split the devicetree bindings documentation in its own patch.
Documentation/devicetree/bindings/gpio/gpio.txt | 23 +++
1
Lad, Prabhakar wrote on Mon [2015-Jan-26 08:13:01
+]:
> Hi Paul,
>
> Thanks for the review.
>
> On Mon, Jan 26, 2015 at 2:15 AM, Paul Walmsley wrote:
> > Hi
> >
> > On Sun, 25 Jan 2015, Lad, Prabhakar wrote:
> >
> >> From: Benoit Parro
Alexandre Courbot wrote on Tue [2015-Jan-13 06:43:33 +0900]:
> On Tue, Jan 13, 2015 at 1:39 AM, Benoit Parrot wrote:
> > Linus Walleij wrote on Mon [2015-Jan-12 11:20:14
> > +0100]:
> >> On Fri, Dec 19, 2014 at 9:07 PM, Benoit Parrot wrote:
> >>
> &g
Linus Walleij wrote on Mon [2015-Jan-12 11:20:14
+0100]:
> On Fri, Dec 19, 2014 at 9:07 PM, Benoit Parrot wrote:
>
> > Add GPIO hogging documentation to gpio.txt
> >
> > Signed-off-by: Benoit Parrot
> > Reviewed-by: Alexandre Courbot
>
Paul Walmsley wrote on Mon [2015-Jan-26 18:47:11 +]:
> Hi Prabhakar,
>
> On Mon, 26 Jan 2015, Lad, Prabhakar wrote:
>
> > Hi Benoit,
> >
> > On Mon, Jan 26, 2015 at 3:50 PM, Benoit Parrot wrote:
> > > Lad, Prabhakar wrote on Mon [2015-Jan-26
Suspend/resume is functional with this patch.
Tested-by: Benoit Parrot
Lad, Prabhakar wrote on Mon [2015-Jan-26 08:21:28
+]:
> From: Benoit Parrot
>
> this patch adds VPFE HWMOD data for AM43xx.
>
> Signed-off-by: Benoit Parrot
> Signed-off-by: Darren Etheridg
1 Sequence: 118 Field: None Timestamp: 69.352916s
Buffer: 2 Sequence: 119 Field: None Timestamp: 69.374892s
test MMAP: OK
test USERPTR: OK (Not Supported)
test DMABUF: Cannot test, specify --expbuf-device
Total: 45, Succeeded: 45, Failed: 0, Warnings: 0
Device Tree bindings for the Camera Adaptation Layer (CAL) driver
Signed-off-by: Benoit Parrot
---
Documentation/devicetree/bindings/media/ti-cal.txt | 70 ++
1 file changed, 70 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/ti-cal.txt
diff --git
compliant.
Driver supports the following:
- V4L2 API using DMABUF/MMAP buffer access based on videobuf2 api
- Asynchronous sensor sub device registration
- DT support
Signed-off-by: Benoit Parrot
---
drivers/media/platform/Kconfig | 12 +
drivers/media/platform/Makefile
Hans Verkuil wrote on Mon [2015-Jun-22 09:31:21 +0200]:
> On 06/16/2015 07:29 PM, Benoit Parrot wrote:
> > The Camera Adaptation Layer (CAL) is a block which consists of a dual
> > port CSI2/MIPI camera capture engine.
> > This camera engine is currently found on DRA7
Hans,
Thanks for the feedback.
Hans Verkuil wrote on Mon [2015-Jun-22 10:09:00 +0200]:
> Hi Benoit,
>
> Thanks for the patch! I do have a few comments, though. See below.
>
> On 06/16/2015 07:29 PM, Benoit Parrot wrote:
> > The Camera Adaptation Layer (CAL) is a bloc
Ville Syrjälä wrote on Thu [2019-Mar-14
17:31:29 +0200]:
> On Thu, Mar 14, 2019 at 08:44:45AM -0500, Benoit Parrot wrote:
> > During a suspend cycle the atomic state is saved to be used during the
> > restore cycle.
> >
> > However the current state duplication logic
occinelle.lip6.fr)
>
> Signed-off-by: Daniel W. S. Almeida
Reviewed-by: Benoit Parrot
> ---
> drivers/media/platform/ti-vpe/vpdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/ti-vpe/vpdma.c
> b/drivers/media/platfor
Pratyush,
Tomi Valkeinen wrote on Wed [2021-Mar-31
09:06:35 +0300]:
> Hi,
>
> On 30/03/2021 20:33, Pratyush Yadav wrote:
> > TI's J721E uses the Cadence CSI2RX and DPHY peripherals to facilitate
> > capture over a CSI-2 bus.
> >
> > The Cadence CSI2RX IP acts as a bridge between the TI specifi
S_ERR(csc->base)) {
> - dev_err(&pdev->dev, "failed to ioremap\n");
> + if (IS_ERR(csc->base))
> return ERR_CAST(csc->base);
> - }
Reviewed-by: Benoit Parrot
>
> return csc;
> }
> --
> 2.25.1
>
base)) {
> - dev_err(&pdev->dev, "failed to ioremap\n");
> + if (IS_ERR(sc->base))
> return ERR_CAST(sc->base);
> - }
Reviewed-by: Benoit Parrot
>
> return sc;
> }
> --
> 2.25.1
>
switch various modes and combination.
Specific drivers should not necessarily need to be aware of
what accounts to a specific board implementation. This board level
"description" should be best kept as part of the dts file.
Signed-off-by: Benoit Parrot
---
Documentation/devicetree/bin
Pantelis Antoniou wrote on Wed [2014-Oct-29
18:42:48 +0200]:
> Hi Benoit,
>
> > On Oct 29, 2014, at 18:34 , Benoit Parrot wrote:
> >
> > Pantelis,
> >
> > Thanks for the feedback.
> >
> > Pantelis Antoniou wrote on Wed [2014-Oct-29
> &g
Maxime Ripard wrote on Wed [2014-Oct-29
17:47:46 +0100]:
> On Wed, Oct 29, 2014 at 11:41:22AM -0500, Benoit Parrot wrote:
> > Maxime Ripard wrote on Wed [2014-Oct-29
> > 11:45:59 +0100]:
> > > Hi,
> > >
> > > On Tue, Oct 21, 2014 at 03:09:58PM -0
2014 at 5:09 AM, Benoit Parrot wrote:
> > Based on Boris Brezillion work this is a reworked patch
> > of his initial GPIO hogging mechanism.
> > This patch provides a way to initally configure specific GPIO
> > when the gpio controller is probe.
>
> Typo nit: s/pro
Pantelis,
Thanks for the feedback.
Pantelis Antoniou wrote on Wed [2014-Oct-29
10:53:44 +0200]:
> Hi Benoit,
>
> > On Oct 21, 2014, at 23:09 , Benoit Parrot wrote:
> >
> > Based on Boris Brezillion work this is a reworked patch
> > of his initial GPIO hog
Maxime Ripard wrote on Wed [2014-Oct-29
11:45:59 +0100]:
> Hi,
>
> On Tue, Oct 21, 2014 at 03:09:58PM -0500, Benoit Parrot wrote:
> > Based on Boris Brezillion work this is a reworked patch
> > of his initial GPIO hogging mechanism.
> > This patch provides a way to
gards,
Benoit Parrot
Linus Walleij linaro.org> writes:
>
> On Wed, Jan 8, 2014 at 11:18 AM, boris brezillon
> overkiz.com> wrote:
>
> > Anyway, do you want me to rework the gpio hog as described below ?
>
> If you feel you have time, drive and a proper usecase for
Linus,
Thanks for the feedback.
To summarize the hog feature should be local to gpiolib-of.c, correct?
I also also need some clarifications, see below.
Linus Walleij wrote on Mon [2014-Nov-03 10:59:53
+0100]:
> On Tue, Oct 21, 2014 at 10:09 PM, Benoit Parrot wrote:
>
> >
Buffer: 2 Sequence: 119 Field: None Timestamp: 355.891493s
test MMAP: OK
test USERPTR: OK (Not Supported)
test DMABUF: Cannot test, specify --expbuf-device
Stream using all formats:
test MMAP for Format GRBG, Frame Size 1920x1080@30.00 Hz:
Stride 1
compliant.
Driver supports the following:
- V4L2 API using DMABUF/MMAP buffer access based on videobuf2 api
- Asynchronous sensor sub device registration
Signed-off-by: Benoit Parrot
Signed-off-by: Hans Verkuil
---
drivers/media/platform/Kconfig | 12 +
drivers/media/platform
Device Tree bindings for the DRA72 Camera Adaptation Layer (CAL)
H/W module.
Signed-off-by: Benoit Parrot
---
Documentation/devicetree/bindings/media/ti-cal.txt | 72 ++
1 file changed, 72 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/ti-cal.txt
> should not be considered an error.
>
> Reported-by: Benoit Parrot
> Signed-off-by: Javier Martinez Canillas
>
> ---
>
> drivers/media/v4l2-core/v4l2-async.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2
Tested-by: Benoit Parrot
Javier Martinez Canillas wrote on Tue [2016-Feb-16
17:03:21 -0300]:
> After sub-dev registration in v4l2_async_test_notify(), the v4l2-async
> core calls the registered_async callback but if a sub-dev driver does
> not implement it, v4l2_subdev_call() will
: warning: Using plain integer as NULL pointer
ti-vpe/cal.c:1844:16: warning: Using plain integer as NULL pointer
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/cal.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/media/platform/ti-vpe
Add GPIO hogging documentation to gpio.txt
Signed-off-by: Benoit Parrot
---
Changes since v1:
* Split the devicetree bindings documentation in its own patch.
Documentation/devicetree/bindings/gpio/gpio.txt | 25 +
1 file changed, 25 insertions(+)
diff --git a
es to switch various modes and combination.
Specific drivers should not necessarily need to be aware of
what accounts to a specific board implementation. This board level
"description" should be best kept as part of the dts file.
Signed-off-by: Benoit Parrot
---
Changes since v1:
* Refact
in its own patch.
* Refactor the gpio-hog mechanism as private functions meant to
be to invoked from of_gpiochip_add().
Benoit Parrot (2):
gpio: add GPIO hogging mechanism
gpio: Document GPIO hogging mechanism
Documentation/devicetree/bindings/gpio/gpio.txt | 25
drivers/gpio/gp
Alexandre Courbot wrote on Fri [2014-Nov-28 16:31:19 +0900]:
> On Fri, Nov 21, 2014 at 8:54 AM, Benoit Parrot wrote:
> > Add GPIO hogging documentation to gpio.txt
> >
> > Signed-off-by: Benoit Parrot
> > ---
> > Changes since v1:
> > * Split the devic
Alexandre Courbot wrote on Fri [2014-Nov-28 16:30:01 +0900]:
> On Fri, Nov 21, 2014 at 8:54 AM, Benoit Parrot wrote:
> > Based on Boris Brezillion's work this is a reworked patch
> > of his initial GPIO hogging mechanism.
> > This patch provides a way to initally config
Maxime Ripard wrote on Mon [2014-Dec-01
17:36:39 +0100]:
> Hi,
>
> On Fri, Nov 28, 2014 at 04:30:01PM +0900, Alexandre Courbot wrote:
> > > +/**
> > > + * do_gpio_hog - Given node is a GPIO hog configuration, handle it
> > > + * @np:device node to get GPIO from
> > > + *
> > > +
Thanks, for the patch.
Acked-by: Benoit Parrot
Arnd Bergmann wrote on Tue [2015-May-19 14:39:12 +0200]:
> The newly added ov2659 driver uses the v4l2 subdev API, but
> can be enabled even when that API is not part of the kernel,
> resulting in this build error:
>
> media/i
> On Sat, Dec 13, 2014 at 7:07 AM, Benoit Parrot wrote:
> > Based on Boris Brezillion's work this is a reworked patch
> > of his initial GPIO hogging mechanism.
> > This patch provides a way to initally configure specific GPIO
>
> s/initally/initially
>
> &g
es to switch various modes.
Specific drivers should not necessarily need to be aware of
what accounts to a specific board implementation. This board level
"description" should be best kept as part of the dts file.
Signed-off-by: Benoit Parrot
Reviewed-by: Alexandre Courbot
---
drivers/gp
s private functions meant to
be to invoked from of_gpiochip_add().
Benoit Parrot (2):
gpio: add GPIO hogging mechanism
gpio: Document GPIO hogging mechanism
Documentation/devicetree/bindings/gpio/gpio.txt | 23 +
drivers/gpio/gpiolib-of.c |
Add GPIO hogging documentation to gpio.txt
Signed-off-by: Benoit Parrot
Reviewed-by: Alexandre Courbot
---
Documentation/devicetree/bindings/gpio/gpio.txt | 23 +++
1 file changed, 23 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt
b
Laurent Pinchart wrote on Thu [2015-Feb-05
16:52:22 +0200]:
> Hi Prabhakar,
>
> (CC'ing Benoit Parrot)
>
> On Thursday 05 February 2015 11:55:28 Lad, Prabhakar wrote:
> > On Thu, Feb 5, 2015 at 11:53 AM, Laurent Pinchart wrote:
> > > On Wednesday 04 February
ase hogged gpio.
* Similarly to the hogging, the cleanup is performed as part of
of_gpiochip_remove
Changes since v1:
* Split the devicetree bindings documentation in its own patch.
* Refactor the gpio-hog mechanism as private functions meant to
be to invoked from of_gpiochip_add().
Benoi
Add GPIO hogging documentation to gpio.txt
Signed-off-by: Benoit Parrot
Reviewed-by: Alexandre Courbot
---
Documentation/devicetree/bindings/gpio/gpio.txt | 30 +
1 file changed, 30 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt
b
es to switch various modes.
Specific drivers should not necessarily need to be aware of
what accounts to a specific board implementation. This board level
"description" should be best kept as part of the dts file.
Signed-off-by: Benoit Parrot
Reviewed-by: Alexandre Courbot
---
drivers/gp
Gentle ping.
Is there any chance this will make it in 3.21?
Benoit
Parrot, Benoit wrote on Wed [2015-Feb-02 17:44:43 -0600]:
> This patch set re-introduces the gpio hogging concept first
> presented by Boris Brezillion.
> This patch set provides a way to initially configure spec
Thanks for the quick feedback.
Alexandre Courbot wrote on Fri [2014-Dec-12 17:54:06 +0900]:
> On Thu, Dec 11, 2014 at 8:48 AM, Benoit Parrot wrote:
> > Alexandre Courbot wrote on Wed [2014-Dec-10 20:19:51
> > +0900]:
> >> On Fri, Dec 5, 2014 at 6:02 AM, Benoit Parrot
moval
able to release hogged gpio.
* Similarly to the hogging, the cleanup is performed as part of
of_gpiochip_remove
Changes since v1:
* Split the devicetree bindings documentation in its own patch.
* Refactor the gpio-hog mechanism as private functions meant to
be to invoked from of_gp
es to switch various modes and combination.
Specific drivers should not necessarily need to be aware of
what accounts to a specific board implementation. This board level
"description" should be best kept as part of the dts file.
Signed-off-by: Benoit Parrot
---
Changes since v3:
* Reloc
Add GPIO hogging documentation to gpio.txt
Signed-off-by: Benoit Parrot
---
Changes since v3:
* Renamed the "direction" DT properties to "state".
Documentation/devicetree/bindings/gpio/gpio.txt | 23 +++
1 file changed, 23 insertions(+)
diff -
ld: None Timestamp: 355.891493s
test MMAP: OK
test USERPTR: OK (Not Supported)
test DMABUF: Cannot test, specify --expbuf-device
Stream using all formats:
test MMAP for Format GRBG, Frame Size 1920x1080@30.00 Hz:
Stride 1920, Field None: OK
Device Tree bindings for the Camera Adaptation Layer (CAL) driver
Signed-off-by: Benoit Parrot
---
Documentation/devicetree/bindings/media/ti-cal.txt | 70 ++
1 file changed, 70 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/ti-cal.txt
diff --git
compliant.
Driver supports the following:
- V4L2 API using DMABUF/MMAP buffer access based on videobuf2 api
- Asynchronous sensor sub device registration
- DT support
Signed-off-by: Benoit Parrot
---
drivers/media/platform/Kconfig | 12 +
drivers/media/platform/Makefile
.847541s
Buffer: 1 Sequence: 118 Field: None Timestamp: 355.869517s
Buffer: 2 Sequence: 119 Field: None Timestamp: 355.891493s
test MMAP: OK
test USERPTR: OK (Not Supported)
test DMABUF: Cannot test, specify --expbuf-device
Stream using all
compliant.
Driver supports the following:
- V4L2 API using DMABUF/MMAP buffer access based on videobuf2 api
- Asynchronous sensor sub device registration
- DT support
Signed-off-by: Benoit Parrot
Signed-off-by: Hans Verkuil
---
drivers/media/platform/Kconfig | 12 +
drivers
Device Tree bindings for the Camera Adaptation Layer (CAL) driver
Signed-off-by: Benoit Parrot
---
Documentation/devicetree/bindings/media/ti-cal.txt | 70 ++
1 file changed, 70 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/ti-cal.txt
diff --git
Rob Herring wrote on Mon [2015-Nov-16 09:26:16 -0600]:
> On Sun, Nov 15, 2015 at 05:53:48PM -0600, Benoit Parrot wrote:
> > Device Tree bindings for the Camera Adaptation Layer (CAL) driver
>
> Bindings are for h/w blocks, not drivers...
OK I'll fix that.
>
> &g
and
restoring context.
Signed-off-by: Dave Gerlach
Signed-off-by: Benoit Parrot
---
drivers/media/platform/am437x/am437x-vpfe.c | 44 ++---
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/media/platform/am437x/am437x-vpfe.c
b/drivers/media/platform/am437x
Switch to SPDX licensing and drop the redundant GPL text.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/am437x/am437x-vpfe.c | 14 +-
drivers/media/platform/am437x/am437x-vpfe.h | 14 +-
drivers/media/platform/am437x/am437x-vpfe_regs.h | 10
turns out that print_fourcc can be safely replace by using
"%4.4s" instead and casting the pointer to the fourcc code
into a (char *).
Signed-off-by: Benoit Parrot
---
drivers/media/platform/am437x/am437x-vpfe.c | 34 ++---
1 file changed, 10 insertions(+), 24 deletion
had to
be reworked.
When calculating the bytesperline/stride and sizeimage format
member we don't need to locally store the current value of
bytesperpixel as it can easily get derived dynamically.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/am437x/am437x-vpfe.c
checkpatch.pl nows reports several:
WARNING: Prefer using '"%s...", __func__' to using '',
this function's name, in a string
So fix these for the whole driver.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/am437x/am437x-vpfe.c | 70 ++---
we would wait for the next Vsync before disabling the hardware.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/am437x/am437x-vpfe.c | 52 ++---
drivers/media/platform/am437x/am437x-vpfe.h | 3 ++
2 files changed, 29 insertions(+), 26 deletions(-)
diff --git a/drivers
The bus related static data include in the vpfe_fmt
static table can be derived dynamically instead.
This simplify the table and it's use.
We instead replace the per bus data info with just
the usual bit per pixel value for each supported
pixel format.
Signed-off-by: Benoit Parrot
---
dr
Keep a reference to the currently selected struct vpfe_fmt * object.
By doing so we rename the current struct v4l2_format * member from
fmt to v_fmt.
The added struct vpfe_fmt * reference is set to "const" so we also
constify all accesses and related helper functions.
Signed-off-by: Ben
Previous generation of this driver were hard coded to handle
encoder/decoder were the first line never contains any data and
was therefore always skipped, however when dealing with actual
camera sensor the first line is always present.
Signed-off-by: Benoit Parrot
---
drivers/media/platform
VIDIOC_S_STD should not return an error if the value is identical
to the current one.
This error was highlighted by the v4l2-compliance test.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/am437x/am437x-vpfe.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/media
Using a statically defined format array would cause issue when
multiple vpfe instance would be connected to sub-device of
different capabilities. We need to use an instance based array
instead to properly maintain a per port/instance format list.
Signed-off-by: Benoit Parrot
---
drivers/media
missed by the global script thus far.
Benoit Parrot (12):
media: am437x-vpfe: Fix missing first line
media: am437x-vpfe: Rework ISR routine for clarity
media: am437x-vpfe: Wait for end of frame before tear-down
media: am437x-vpfe: Streamlined vb2 buffer cleanup
media: am437x-vpfe: Setting
Make the ISR code simpler to follow by removing goto and
relocating/eliminating duplicate spinlock accesses.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/am437x/am437x-vpfe.c | 128 ++--
1 file changed, 66 insertions(+), 62 deletions(-)
diff --git a/drivers/media
Returning queued vb2 buffers back to user space is a common
task best handled by a helper function.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/am437x/am437x-vpfe.c | 54 ++---
1 file changed, 26 insertions(+), 28 deletions(-)
diff --git a/drivers/media/platform
Joe Perches wrote on Mon [2019-Sep-09 09:39:37 -0700]:
> On Mon, 2019-09-09 at 11:27 -0500, Benoit Parrot wrote:
> > print_fourcc helper function was used for debug log the
> > convert a pixel format code into its readable form for display
> > purposes. But since it used a si
Joe Perches wrote on Mon [2019-Sep-09 09:54:56 -0700]:
> On Mon, 2019-09-09 at 11:27 -0500, Benoit Parrot wrote:
> > checkpatch.pl nows reports several:
> > WARNING: Prefer using '"%s...", __func__' to using '',
> > this function's name
Hans Verkuil wrote on Tue [2019-Sep-10 12:42:51 +0200]:
> Hi Benoit,
>
> On 9/9/19 6:27 PM, Benoit Parrot wrote:
> > This patch series is a collection of patches we have been carrying for a
> > while.
> >
> > A few patches do fix actual bug and v4l2-complian
powerdown gpio.
Since these camera are removable on some board we alos need the driver
to actually fail when there is no hardware present so the driver is
actually removed.
Finally, we update the licensing statement to use SPDX licensing.
Benoit Parrot (6):
media: i2c: ov2659: Fix for image w
for the 720p case.
Signed-off-by: Benoit Parrot
---
drivers/media/i2c/ov2659.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
index c64f73bef336..fbe624457fbc 100644
--- a/drivers/media/i2c/ov2659.c
+++ b/drivers/media/i2c/ov2659.c
Switch to SPDX licensing and drop the redundant GPL text.
Signed-off-by: Benoit Parrot
---
drivers/media/i2c/ov2659.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
index fbe624457fbc..946bed29900a
On some board it is possible that the sensor 'powerdown'
pin might be controlled with a gpio instead of being
tied to always powered.
This patch add support to specify an optional gpio
which will be set at probe time and remained on.
Signed-off-by: Benoit Parrot
---
drivers/media/i
Add powerdown-gpios to the list of optional properties for the OV2659
camera sensor.
Signed-off-by: Benoit Parrot
---
Documentation/devicetree/bindings/media/i2c/ov2659.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/ov2659.txt
b
Make sure that if the expected sensor device id register
is not recognized properly the failure is propagated
up so devices are not left partially initialized.
Signed-off-by: Benoit Parrot
Signed-off-by: Jyri Sarha
---
drivers/media/i2c/ov2659.c | 5 +++--
1 file changed, 3 insertions(+), 2
Based on recently found sensor configuration examples, it was
discovered that when scaling and binning are used for the lower
resolutions (i.e. 640x480, 320x240) the read offset has to be
increased otherwise the image appears to be wrapped around.
Signed-off-by: Benoit Parrot
Signed-off-by: Jyri
Thanks for the reviews.
Hans Verkuil wrote on Fri [2019-Sep-13 14:59:28 +0200]:
> On 9/9/19 6:27 PM, Benoit Parrot wrote:
> > From: Dave Gerlach
> >
> > Currently if vpfe is not active then it returns immediately in the
> > suspend and resume handlers. Change this
Hans Verkuil wrote on Fri [2019-Sep-13 15:00:08 +0200]:
> On 9/9/19 6:27 PM, Benoit Parrot wrote:
> > Previous generation of this driver were hard coded to handle
> > encoder/decoder were the first line never contains any data and
>
> were -> where
>
> > was
Hans Verkuil wrote on Fri [2019-Sep-13 15:07:29 +0200]:
> On 9/9/19 6:27 PM, Benoit Parrot wrote:
> > Using a statically defined format array would cause issue when
> > multiple vpfe instance would be connected to sub-device of
> > different capabilities. We need to use an
Hans Verkuil wrote on Fri [2019-Sep-13 15:14:45 +0200]:
> On 9/9/19 6:27 PM, Benoit Parrot wrote:
> > Keep a reference to the currently selected struct vpfe_fmt * object.
> > By doing so we rename the current struct v4l2_format * member from
> > fmt to v_fmt.
> >
Hans Verkuil wrote on Fri [2019-Sep-13 15:19:52 +0200]:
> On 9/9/19 6:27 PM, Benoit Parrot wrote:
> > The bus related static data include in the vpfe_fmt
> > static table can be derived dynamically instead.
> > This simplify the table and it's use.
>
> simp
Hans Verkuil wrote on Fri [2019-Sep-13 15:34:28 +0200]:
> On 9/13/19 3:32 PM, Benoit Parrot wrote:
> > Hans Verkuil wrote on Fri [2019-Sep-13 15:14:45 +0200]:
> >> On 9/9/19 6:27 PM, Benoit Parrot wrote:
> >>> Keep a reference to the currently selected struct vpfe_f
Lad, Prabhakar wrote on Sat [2019-Sep-14 11:11:02
+0100]:
> Hi Benoit,
>
> Thank you for the patch.
>
> On Thu, Sep 12, 2019 at 1:58 PM Benoit Parrot wrote:
> >
> > Add powerdown-gpios to the list of optional properties for the OV2659
> > camera sensor.
>
Lad, Prabhakar wrote on Sat [2019-Sep-14 11:33:42
+0100]:
> Hi Benoit,
>
> On Thu, Sep 12, 2019 at 1:58 PM Benoit Parrot wrote:
> >
> > On some board it is possible that the sensor 'powerdown'
> > pin might be controlled with a gpio instead of being
>
1 - 100 of 440 matches
Mail list logo
