devices, it doesn't
really matter.
--
Corentin Chary
http://xf.iksaif.net
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
This adds the chromeos_laptop driver. It supports
the Cypress APA SMBUS touchpad as well as the isl29018 i2c ambient
light sensor on the Samsung Series 5 550 Chromebook.
Signed-off-by: Benson Leung ble...@chromium.org
Reviewed-by: Olof Johansson o...@lixom.net
---
Version history :
v2 : * Added
Spun another version of this patch. Thanks Coretin for your feedback.
I've incorporated your suggestions.
v2 : * Added MODULE_DEVICE_TABLE for the dmi table.
* Made __init and __initdata position consistent across this file.
* Made prefix static const char *
* Made strncmp
Acked-by: Benson Leung ble...@chromium.org
On Thu, Apr 18, 2013 at 2:55 PM, Olof Johansson o...@lixom.net wrote:
If chromeos_laptop is loaded before the DRM driver, the i2c busses will
not yet be available. Defer probe for that case and try again later.
Trickling the error up to the module
Add a feature to update trackpad firmware via request_firmware to cyapa.
The last patch in the series adds sysfs attributses useful for version
and product identification that a user mode utility will need to
keep track of the current firmware on the device.
This is used today on Chromebook
cyapa_check_is_operational and cyapa_create_input_dev are common to
the probe and firmware update paths. Pull those out into
cyapa_detect.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/input/mouse/cyapa.c | 57 +++--
1 file changed, 39
Allow the name of the designated firmware to be passed as the
argument to update_fw from user space. This will allow user space
to specify which firmware to load.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/input/mouse/cyapa.c | 9 -
1 file changed, 8 insertions(+), 1
Add attributes to expose the product_id and firmware_version read
from the device firmware.
Signed-off-by: Dudley Du d...@cypress.com
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/input/mouse/cyapa.c | 24
1 file changed, 24 insertions(+)
diff --git
...@chromium.org
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/input/mouse/cyapa.c | 351
1 file changed, 351 insertions(+)
diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c
index a631aca..e622c25 100644
--- a/drivers
, which
our team is actively working on as well, also has an update_fw sysfs
for a lot of the same reasons.
Thanks,
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
Add support for a touchpad variant in the atmel_mxt_ts driver.
Then, add platform data for the 224s trackpad and the 1664s touchscreen
in chromeos_laptop so that the existing version of the driver will
probe these devices correctly.
v3 : Add platform data for is_tp and key_map. Remove dependence
data key_map array.
key_map[x] should contain the KEY or BTN code to send when processing
GPIOx from T19. To specify a GPIO as not an input source, populate
with KEY_RESERVED, or 0.
Signed-off-by: Daniel Kurtz djku...@chromium.org
Signed-off-by: Benson Leung ble...@chromium.org
Signed-off
Add basic platform data to get the current upstream driver working
with the 224s touchpad and 1664s touchscreen.
We will be using NULL config so we will use the settings from the
devices' NVRAMs.
Signed-off-by: Benson Leung ble...@chromium.org
Tested-by: Olof Johansson o...@lixom.net
---
v3: Add
On Thu, Mar 7, 2013 at 7:43 PM, Benson Leung ble...@chromium.org wrote:
+static void mxt_input_button(struct mxt_data *data, struct mxt_message
*message)
+{
+ struct device *dev = data-client-dev;
Oops. I missed a warning: unused variable 'dev' here.
+ struct input_dev *input
gmbus is now as fast
as with busy-looping gmbus at 28 ms here (with negligible cpu
overhead).
Reviewed-by: Imre Deak imre.d...@intel.com
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
Is there anything I can do to help debug this some more?
--
Benson Leung
Software Engineer
Add support for an atmel_mxt_tp variant in the atmel_mxt_ts.c driver.
Then, add platform data for the 224s trackpad and the 1664s touchscreen
in chromeos_laptop so that the existing version of the driver will
probe these devices correctly.
v2 : Minor bugfix in patch 1. Cleanup client_id from
Add basic platform data to get the current upstream driver working
with the 224s touchpad and 1664s touchscreen.
We will be using NULL config so we will use the settings from the
devices' NVRAMs.
Signed-off-by: Benson Leung ble...@chromium.org
Tested-by: Olof Johansson o...@lixom.net
---
v2
,
platform data should specify the configuration of the buttons.
They can be configured via a future platform data change to
specify optional middle and right buttons, as well as other possible
uses for the GPIO object T19.
Signed-off-by: Daniel Kurtz djku...@chromium.org
Signed-off-by: Benson Leung ble
Hi Daniel,
I've just tried drm-intel-fixes merged into v3.9-rc1, and so far it's
looking good. No suspicious timeouts.
Thanks for the quick response!
Benson
On Wed, Mar 6, 2013 at 12:14 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote:
On Wed, Mar 6, 2013 at 3:35 AM, Benson Leung ble
trackpad
CYTRA-101003-00 - HP Pavilion 14 Chromebook trackpad
Signed-off-by: Dudley Du d...@cypress.com
Signed-off-by: Benson Leung ble...@chromium.org
Reviewed-by: Daniel Kurtz djku...@chromium.org
---
v2 : Minor style cleanup. Removed unused struct device *dev declarations.
---
drivers/input/mouse
This patch will add an entry for one more Chromebook that was released
last week: HP's Pavilion 14 Chromebook.
This will instatiate that system's Cypress APA trackpad, very similar
to the one in the Samsung 550 and Acer C7.
This should be merged after the previous patch series of 4:
Platform:
Add support for the HP Pavilion 14 Chromebook's trackpad, which is a reuse
of the Samsung Series 5 550 trackpad.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/platform/x86
trackpad
Signed-off-by: Dudley Du d...@cypress.com
Signed-off-by: Benson Leung ble...@chromium.org
Reviewed-by: Daniel Kurtz djku...@chromium.org
---
drivers/input/mouse/cyapa.c | 184 ++--
1 file changed, 179 insertions(+), 5 deletions(-)
diff --git a/drivers
This patch series will add support for the following devices on
the following laptops:
Acer C7 Chromebook - Cypress APA Smbus Trackpad
Acer AC700 - Taos tsl2563 light sensor
Samsung Series 5 Chromebook - Taos tsl2583 light sensor
Cr-48 - Taos tsl2563 light sensor
Cheers,
Benson
--
To
The Cypress trackpad on smbus is used on other systems
as well. Lets make the name more generic.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86
Two legacy Chromebooks, the Cr-48, and the Acer AC700,
are equipped with a Taos tsl2563 light sensor.
This will instantiate the sensor on those laptops.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 26 ++
1 file changed, 26
The Samsung Series 5 Chromebook is equipped with a Taos tsl2583
light sensor. Instatiate it here.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/platform/x86
Add support for the Acer C7's trackpad, which is a reuse
of the Samsung Series 5 550 trackpad.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/platform/x86/chromeos_laptop.c
b/drivers
Add support for an atmel_mxt_tp variant in the atmel_mxt_ts.c driver.
Then, add platform data for the 224s trackpad and the 1664s touchscreen
in chromeos_laptop so that the existing version of the driver will
probe these devices correctly.
[PATCH 1/2] Input: atmel_mxt_ts - add device id for
Add basic platform data to get the current upstream driver working
with the 224s touchpad and 1664s touchscreen.
We will be using NULL config so we will use the settings from the
devices' NVRAMs.
Signed-off-by: Benson Leung ble...@chromium.org
Change-Id: I712bf4726fb4b194fbde44ad200c54d13dc3bdb9
,
platform data should specify the configuration of the buttons.
They can be configured via a future platform data change to
specify optional middle and right buttons, as well as other possible
uses for the GPIO object T19.
Signed-off-by: Daniel Kurtz djku...@chromium.org
Signed-off-by: Benson Leung ble
object table or input device.
In particular:
1) mxt_remove calls input_unregister_device on input_dev.
2) mxt_suspend/resume reads and writes from the object table.
3) Spurious or bootloader induced interrupts
Signed-off-by: Benson Leung ble...@chromium.org
Signed-off-by: Daniel Kurtz djku
Thanks again, Dmitry and Henrik!
On Thu, Feb 14, 2013 at 9:19 AM, Henrik Rydberg rydb...@euromail.se wrote:
On Wed, Feb 13, 2013 at 08:26:35PM -0800, Dmitry Torokhov wrote:
On Sun, Feb 10, 2013 at 12:15:40PM -0800, Benson Leung wrote:
This patch adds support for the Cypress APA Smbus
Hi Len,
Please take a look at this patch to the x86_energy_perf_policy that allows
the tool to work when built for i686 with PIC enabled.
Thanks,
Benson
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
x86_energy_perf_policy reads cpuid using the cpuid instruction.
On i686, when building with PIC, this clobbers ebx, the PIC register.
Fixed using the same cpuid accessor function that vap...@gentoo.org
created for i7z:
http://code.google.com/p/i7z/issues/detail?id=31
Signed-off-by: Benson Leung
Thanks Len and Mike for your comments. I've fixed the style problems so this
is now checkpatch clean.
I've also moved to Mike's better cpuid from ltp.
Thanks,
Benson
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
-by: Benson Leung ble...@chromium.org
Signed-off-by: Mike Frysinger vap...@gentoo.org
---
v4 : Cleaned up checkpatch.pl style errors. Used vapier's newer better cpuid.
v3 : No changes.
v2 : make cpuid static inline. Remove unused eax from validate_cpuid and
clean up return variables from cpuid
This will allow us to assign devices to buses by the type enum.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/chromeos_laptop.c
b/drivers
Instantiate the atmel mxt224s trackpad on this system.
The trackpad may appear at two possible addresses:
0x4b in operational mode.
0x25 in bootloader mode.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 29 +
1 file
This will allow support for devices that may appear at more than
one i2c address at boot time. The specific example is the atmel_mxt touch
devices, which may appear at a different address if it comes up
in bootloader mode.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86
From: Yufeng Shen mile...@chromium.org
Instantiate the atmel mxt1664s touchscreen on this system.
The touchscreen may appear at two possible addresses:
0x4a in operational mode.
0x26 in bootloader mode.
Signed-off-by: Yufeng Shen mile...@chromium.org
Signed-off-by: Benson Leung ble
The following patch series will add support for the isl light sensor,
atmel mxt touchpad, and atmel mxt touchscreen on the Chromebook Pixel.
[PATCH 1/6] Platform: x86: chromeos_laptop - add i915 gmbuses to
[PATCH 2/6] Platform: x86: chromeos_laptop - Add a more general
[PATCH 3/6] Platform: x86:
The Chromebook Pixel uses an isl29023 ambient light sensor on the PANEL
GMBus.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/platform/x86/chromeos_laptop.c
b/drivers
Add the two other i2c buses (vga and panel) from i915.
Chromebook Pixel has input and light sensor devices on these busses.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/platform/x86
},
{ 0x25, 0x4b },
{ 0x26, 0x4c },
{ 0x27, 0x4d },
{ 0x34, 0x5a },
{ 0x35, 0x5b },
+#endif
};
static bool mxt_object_readable(unsigned int type)
--
1.7.10.4
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from
device *dev, const char
*fn)
goto release_firmware;
}
+ mxt_wait_for_chg(data);
ret = mxt_check_bootloader(data, MXT_FRAME_CRC_PASS);
if (ret) {
retry++;
--
1.7.10.4
--
Benson
, we use the same atmel_mxt_ts driver for a
1664S device and a 224SL.
The 1664S has the pair 0x26 and 0x4a, while the 224SL has 0x25 and
0x4b.
If I put a bootloader address override in the platform data will that meet
your requirements?
--
Benson Leung
Software Engineer, Chrom* OS
ble
;
unsigned long irqflags;
+ u8(*read_chg) (void);
};
#endif /* __LINUX_ATMEL_MXT_TS_H */
--
1.7.10.4
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
);
+
+ if (timeout_counter count) {
+ dev_err(data-client-dev, mxt_wait_for_chg() timeout!\n);
+ return -EIO;
+ }
+
+ return 0;
+}
+
--
1.7.10.4
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list
If a button is configured to wake the system, report a pm wakeup event.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/input/keyboard/gpio_keys.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/input/keyboard/gpio_keys.c
b/drivers/input/keyboard
at 10:50 PM, Dmitry Torokhov
dmitry.torok...@gmail.com wrote:
Hi Benson,
On Wed, Jul 25, 2012 at 11:11:53PM -0700, Benson Leung wrote:
If a button is configured to wake the system, report a pm wakeup event.
Thank you for your patch, however I applied more complete patch sent by
NeilBrown
Actually, I take it back. It doesn't look like it's necessary.
Benson
On Mon, Jul 30, 2012 at 12:28 PM, Benson Leung ble...@chromium.org wrote:
Hi Dmitry,
Yes I see Neil's changes. Thank you for letting me know.
By the way, looking at Neil's changes, would it make sense to check
request_firmware.
Signed-off-by: Dudley Du d...@cypress.com
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/input/mouse/Kconfig | 13 +
drivers/input/mouse/Makefile |1 +
drivers/input/mouse/cyapa.c | 1493 ++
3 files changed, 1507 insertions(+), 0
This adds the chromeos_laptop driver. It supports
the Cypress APA SMBUS touchpad as well as the isl29018 i2c ambient
light sensor on the Samsung Series 5 550 Chromebook.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/Kconfig | 11 ++
drivers/platform/x86
Thanks for the patience on this driver. I have stripped out firmware update,
the sysfs properties around firmware version, hardware version, update_fw,
and power state.
I have incorporated rydberg's suggestions for cleanup.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
...@chromium.org
Signed-off-by: Benson Leung ble...@chromium.org
---
Version history :
v2 : * Removed firmware update.
* Removed sysfs properties related to firmware update and power mode.
* Folded cyapa_detect into cyapa_probe.
* Added support for middle and right mechanical buttons
with MT protocol type B, providing identifiable
contacts.
Signed-off-by: Dudley Du d...@cypress.com
Signed-off-by: Daniel Kurtz djku...@chromium.org
Signed-off-by: Benson Leung ble...@chromium.org
---
Version history :
v2 : * Removed firmware update.
* Removed sysfs properties related
Thanks Dmitry, Jean, and Henrik.
Here's V3, which I have confirms compiles on input-next, and works
well on my Chromebook.
v3 : * Handle pointer emulation and unused slots in core
* Fix compile fail on 3.7 for input_mt_init_slots (Thanks Rydberg)
* Set BUTTONPAD property only if is a
...@chromium.org
Signed-off-by: Benson Leung ble...@chromium.org
---
Version history :
v3 : * Handle pointer emulation and unused slots in core
* Fix compile fail on 3.7 for input_mt_init_slots (Thanks Rydberg)
* Set BUTTONPAD property only if is a buttonpad based on capabilities.
* Removed
Thanks Henrik.
Hello Dmitry, do you have any comments on V3?
On Sat, Dec 8, 2012 at 4:42 AM, Henrik Rydberg rydb...@euromail.se wrote:
On Fri, Dec 07, 2012 at 03:24:16PM -0800, Benson Leung wrote:
This patch introduces a driver for Cypress All Points Addressable
I2C Trackpad, including
+++-
1 file changed, 194 insertions(+), 232 deletions(-)
--
1.7.10.4
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
for all
supported i2c adapters. The approach may work for Pixel, but as I
mentioned in my other email, it causes failed probes on other systems.
It would be my preference to continue to use i2c_new_probed_device,
and explicitly describe each Chromebook system
--
Benson Leung
Software Engineer
The following patch series refactors the dmi check system and
returns -EPROBE_DEFER when an expected i2c adapter is not present
at probe time.
This will allow the touchpad, touchscreen, and light sensors on
Pixel to load even if the i915 DDC and PANEL buses are instantiated
after chromeos_laptop.
inits, the deferred
probe will instantiate the peripherals when the bus appears.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 139 +++--
1 file changed, 98 insertions(+), 41 deletions(-)
diff --git a/drivers/platform/x86
matching sequences
as well making it easier to add new boards.
Signed-off-by: Aaron Durbin adur...@chromium.org
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 197 +
1 file changed, 126 insertions(+), 71 deletions(-)
diff
making
any other changes, and adds appropriate Kconfig entries for the new
directory. It also adds a MAINTAINERS entry for the new subdir.
Signed-off-by: Olof Johansson o...@lixom.net
Reviewed-by: Benson Leung ble...@chromium.org
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
Allow wakeup_trigger to be defined per gpio button. Currently, all
gpio buttons are set up as IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING.
It may be more appropriate to only wake the system on one edge, for example
if the gpio is for a Lid Switch.
Signed-off-by: Benson Leung ble...@chromium.org
here (through a sysfs knob) -
key down, key up, key down or up.
Thanks for your feedback. I agree with your suggestions. I will move
this from platform data and DT to a sysfs property with three settings
: rising, falling, both.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
for
stable), or if this is just a precaution.
We ran into this on HP Chromebook 14 (Falco). The port reset flag
would be set after a suspend/resume cycle with nothing attached.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line
Add the Haswell ULT device IDs for i2c-designware-pci. These are used,
for example, in Haswell generation Chromebooks, the HP Chromebook 14
and the Acer C720.
[PATCH 1/2] i2c-designware-pci: Add Haswell ULT device IDs
[PATCH 2/2] i2c-designware-pci: Index Haswell ULT bus names from 0
--
To
assigned.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/i2c/busses/i2c-designware-pcidrv.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c
b/drivers/i2c/busses/i2c-designware-pcidrv.c
index e4cbbdf
From: Duncan Laurie dlau...@chromium.org
Add the necessary PCI Device IDs to use the Haswell ULT
I2C controller in PCI mode.
Set the bus numbers to -1 so it will use dynamic assignment
rather than hardcoded.
Signed-off-by: Duncan Laurie dlau...@chromium.org
Signed-off-by: Benson Leung ble
The designware-pci i2c busses will be named i2c-designware-pci-0
and i2c-designware-pci-1 accordingly.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/platform/x86/chromeos_laptop.c
b
Add the Acer C720 entries for trackpad and light sensor.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/platform/x86/chromeos_laptop.c
b/drivers/platform/x86
Add support for the trackpad on HP Chromebook 14.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/platform/x86/chromeos_laptop.c
b/drivers/platform/x86/chromeos_laptop.c
index
__initdata tag should be placed between the variable name and equal
sign for the variable to be placed in the intended .init.data section.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
inits, the deferred
probe will instantiate the peripherals when the bus appears.
Signed-off-by: Benson Leung ble...@chromium.org
Reviewed-by: Aaron Durbin adur...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 144 +++--
1 file changed, 101 insertions(+), 43
matching sequences
as well making it easier to add new boards.
Signed-off-by: Aaron Durbin adur...@chromium.org
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/x86/chromeos_laptop.c | 197 +
1 file changed, 126 insertions(+), 71 deletions(-)
diff
The following patch series refactors the dmi check system and
returns -EPROBE_DEFER when an expected i2c adapter is not present
at probe time.
This will allow the touchpad, touchscreen, and light sensors on
Pixel to load even if the i915 DDC and PANEL buses are instantiated
after chromeos_laptop.
-off-by: Olof Johansson o...@lixom.net
Cc: Benson Leung ble...@chromium.org
Reviewed-by: Benson Leung ble...@chromium.org
Thanks,
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
on the other patches in the same directory.
Sounds good to me. Thanks for applying the patches.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
that the names of each of
the adapters correspond to how they are referred to on various
schematics and datasheets.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
On Mon, Jan 6, 2014 at 7:08 PM, Duson Lin duson...@emc.com.tw wrote:
This driver adds support for elan i2c/smbus touchpad found on some laptops PC
Signed-off-by: Duson Lin duson...@emc.com.tw
Reviewed-by: Benson Leung ble...@chromium.org
--
Benson Leung
Software Engineer, Chrom* OS
ble
On Thu, Feb 6, 2014 at 4:21 PM, Benson Leung ble...@chromium.org wrote:
On Fri, Jan 10, 2014 at 12:30 PM, Benson Leung ble...@chromium.org wrote:
On Mon, Jan 6, 2014 at 7:08 PM, Duson Lin duson...@emc.com.tw wrote:
This driver adds support for elan i2c/smbus touchpad found on some laptops
PC
sensible to name them 0 and 1 since that's how they are referred
to on schematics.
In the chromeos_laptop driver, I do by-name matching of i2c busses to
find busses and instantiate devices, so there is value to have each
named something predictable.
--
Benson Leung
Software Engineer, Chrom* OS
,
+ .clk_khz = 25000,
The input clock for I2C in Haswell is 100MHz, not 25MHz.
Thanks for catching that. I will fix it.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
Fixed 25Mhz clock instead of 100Mhz clock in 1/2 and a warning in 2/2.
[PATCH v2 1/2] i2c-designware-pci: Add Haswell ULT device IDs
[PATCH v2 2/2] i2c-designware-pci: Index Haswell ULT bus names from 0
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
assigned.
Signed-off-by: Benson Leung ble...@chromium.org
---
v2: Fixed warning.
v1: Initial
---
drivers/i2c/busses/i2c-designware-pcidrv.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c
b/drivers/i2c/busses/i2c
From: Duncan Laurie dlau...@chromium.org
Add the necessary PCI Device IDs to use the Haswell ULT
I2C controller in PCI mode.
Set the bus numbers to -1 so it will use dynamic assignment
rather than hardcoded.
Signed-off-by: Duncan Laurie dlau...@chromium.org
Signed-off-by: Benson Leung ble
...@vger.kernel.org
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/base/core.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index c7cfadc..34bd546 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2026,6
...@vger.kernel.org
Signed-off-by: Benson Leung ble...@chromium.org
Reviewed-by: Ming Lei ming@canonical.com
---
v2 : Saved a few lines as suggested by Ming Lei.
v1 : Initial
---
drivers/base/core.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/base/core.c b
On Tue, Sep 24, 2013 at 6:14 PM, Ming Lei ming@canonical.com wrote:
It is better to save one line by below:
parent = get_device(dev-parent);
Done.
Reviewed-by: Ming Lei ming@canonical.com
Thank you!
--
Benson Leung
Software Engineer, Chrom* OS
ble
that bus 0 is going to have the touchpad, and we know that bus
1 is going to have the touchscreen and light sensor. I'd prefer not to
send extra probes for all of the combination of devices that don't
exist.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from
between
the lid and devices that must be power managed differently depending
on the state of the lid, rather than leaving it to user space to
manage the power management of these devices in real time and open up
the possibility of race conditions there if user space is too slow.
Thanks!
--
Benson
Looks like -rc1 is here, so I'll respin these and send them out again.
On Tue, Jun 3, 2014 at 3:59 PM, Olof Johansson o...@lixom.net wrote:
Hi,
On Tue, Jun 3, 2014 at 3:44 PM, Benson Leung ble...@chromium.org wrote:
This patch series should be applied after Mika Westerberg's patch here
-review.googlesource.com/#/c/65320/
https://chromium-review.googlesource.com/#/c/174664/
Signed-off-by: Mohammed Habibulla m...@chromium.org
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/chrome/chromeos_laptop.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/platform
for this and then register both C720 touchpad and light sensor.
This code is based on following patch from Benson Leung:
https://patchwork.kernel.org/patch/3074411/
Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com
Tested-by: Kirill A. Shutemov kirill.shute...@linux.intel.com
Signed-off-by: Benson
This patch series will add support for the cypress touchpads on the
HP Chromebook 14, Dell Chromebook 11, and Toshiba CB35.
Based on the work here by Mika Westerberg, which this series incorporates :
https://patchwork.kernel.org/patch/4288591/
[PATCHv2 1/4] platform/chrome: chromeos_laptop -
://chromium-review.googlesource.com/173445
Signed-off-by: Gene Chen gene.c...@intel.com
Signed-off-by: Benson Leung ble...@chromium.org
Tested-by: Scot Doyle lkm...@scotdoyle.com
---
drivers/platform/chrome/chromeos_laptop.c | 15 +++
1 file changed, 15 insertions(+)
diff --git
Add support for the trackpad on HP Chromebook 14.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/chrome/chromeos_laptop.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b/drivers/platform/chrome
1 - 100 of 755 matches
Mail list logo
