[GIT PULL] PCI fixes for v3.19

2015-01-23 Thread Bjorn Helgaas
Hi Linus, These are fixes for: - A resource management problem that causes a Radeon Fatal error during GPU init on machines where the BIOS programmed an invalid Root Port window. This was a regression in v3.16. - An Atheros AR93xx device that doesn't handle PCI bus resets

Re: [PATCH 07/16] ARM: integrator: convert PCI to use generic config accesses

2015-01-26 Thread Bjorn Helgaas
On Thu, Jan 22, 2015 at 02:33:36PM -0600, Bjorn Helgaas wrote: On Mon, Jan 12, 2015 at 01:05:12AM +0100, Linus Walleij wrote: On Sat, Jan 10, 2015 at 10:53 PM, Arnd Bergmann a...@arndb.de wrote: On Saturday 10 January 2015 22:40:22 Linus Walleij wrote: static int v3_read_config(struct

Re: [PATCH] PCI: quirks: DMA alias quirk for Adaptec 3405

2015-01-23 Thread Bjorn Helgaas
On Tue, Jan 13, 2015 at 11:26:50AM -0700, Alex Williamson wrote: As noted in the added comment, this device is actually an Intel 80333 I/O processor where the exposed device at 0e.0 is actually the address translation unit of the I/O processor and a hidden, private device at 01.0 masters the

Re: [PATCH] PCI: Add Wellsburg (X99) to Intel PCH root port ACS quirk

2015-01-23 Thread Bjorn Helgaas
On Thu, Jan 22, 2015 at 11:15:43AM -0700, Alex Williamson wrote: Intel has confirmed that the Wellsburg chipset, while not reporting ACS, does provide the proper isolation through the RCBA/BSPR registers, so the same quirk works for this set of device IDs. Signed-off-by: Alex Williamson

Re: [PATCH v4 5/6] PCI: update dma configuration from DT

2015-01-23 Thread Bjorn Helgaas
configuration. Cc: Joerg Roedel j...@8bytes.org Cc: Grant Likely grant.lik...@linaro.org Cc: Rob Herring robh...@kernel.org Cc: Bjorn Helgaas bhelg...@google.com Cc: Will Deacon will.dea...@arm.com Cc: Russell King li...@arm.linux.org.uk Cc: Arnd Bergmann a...@arndb.de Cc: Suravee

Re: [PATCH][v3] PCI / PM: Avoid resuming PCI devices during system suspend

2015-01-23 Thread Bjorn Helgaas
profess to understand this, and it seems like something you could merge via your PM tree. So I trust you to do the right thing with it :) Acked-by: Bjorn Helgaas bhelg...@google.com --- This version actually builds and need not be an RFC any more I suppose. --- drivers/pci/pci-acpi.c

Re: [PATCH v3 09/16] pci: add pci_iomap_range

2015-01-23 Thread Bjorn Helgaas
On Wed, Jan 14, 2015 at 07:27:54PM +0200, Michael S. Tsirkin wrote: Virtio drivers should map the part of the BAR they need, not necessarily all of it. Cc: Bjorn Helgaas bhelg...@google.com Cc: linux-...@vger.kernel.org Acked-by: Arnd Bergmann a...@arndb.de Signed-off-by: Michael S

Re: [PATCH v3 08/16] mn10300: drop dead code

2015-01-23 Thread Bjorn Helgaas
from an old kernel. It's not really needed: the generic pci_iomap does the right thing here. The new file isn't compiled so it's safe to drop. Cc: Bjorn Helgaas bhelg...@google.com Cc: linux-...@vger.kernel.org Cc: triv...@kernel.org Cc: David Howells dhowe...@redhat.com Signed-off

Re: [PATCH] PCI: xgene: Include clk.h instead of clk-private.h

2015-01-23 Thread Bjorn Helgaas
On Thu, Jan 22, 2015 at 11:25:54AM -0800, Stephen Boyd wrote: This driver should be including clk.h as it's a clock consumer, not a clock provider that needs to register clocks early. Cc: Tanmay Inamdar tinam...@apm.com Signed-off-by: Stephen Boyd sb...@codeaurora.org Applied provisionally

Re: [PATCH] PCI: keystone: fix incorrect annotations on probe and remove

2015-01-23 Thread Bjorn Helgaas
On Thu, Jan 08, 2015 at 02:17:36PM -0800, Dmitry Torokhov wrote: Even though platform bus is not hot-pluggable, devices on it can be unbound from the driver and bound back to it via sysfs, so we should not be using __init annotations on probe() and __exit annotations on remove() methods.

Re: [PATCH] PCI: keystone: fix incorrect annotations on probe and remove

2015-01-23 Thread Bjorn Helgaas
[+cc Fabio] On Thu, Jan 08, 2015 at 02:17:36PM -0800, Dmitry Torokhov wrote: Even though platform bus is not hot-pluggable, devices on it can be unbound from the driver and bound back to it via sysfs, so we should not be using __init annotations on probe() and __exit annotations on remove()

Re: [PATCH] PCI: quirks: DMA alias quirk for Adaptec 3405

2015-01-23 Thread Bjorn Helgaas
On Tue, Jan 13, 2015 at 11:26:50AM -0700, Alex Williamson wrote: As noted in the added comment, this device is actually an Intel 80333 I/O processor where the exposed device at 0e.0 is actually the address translation unit of the I/O processor and a hidden, private device at 01.0 masters the

Re: [PATCH] PCI: quirks: DMA alias quirk for Adaptec 3405

2015-01-23 Thread Bjorn Helgaas
On Fri, Jan 23, 2015 at 4:30 PM, Alex Williamson alex.william...@redhat.com wrote: On Fri, 2015-01-23 at 15:50 -0600, Bjorn Helgaas wrote: On Tue, Jan 13, 2015 at 11:26:50AM -0700, Alex Williamson wrote: As noted in the added comment, this device is actually an Intel 80333 I/O processor

Re: [GIT PULL] PCI fixes for v3.19

2015-01-26 Thread Bjorn Helgaas
On Mon, Jan 26, 2015 at 1:58 PM, Tony Luck tony.l...@gmail.com wrote: I'm seeing these new messages in v3.19-rc6 on ia64: Hi Tony, Sorry for the inconvenience. Can you collect a complete dmesg log and lspci -vv output, too (from the kernel with the reverted commit)? That will have more useful

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-04 Thread Bjorn Helgaas
On Wed, Feb 4, 2015 at 10:25 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Feb 04, 2015 at 09:53:28AM -0600, Bjorn Helgaas wrote: On Wed, Feb 4, 2015 at 4:48 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Moreover, __weak is positively harmful when you

Re: [PATCH] PCI: Expand quirk's handling of CS553x devices

2015-02-03 Thread Bjorn Helgaas
/TechDocs/31506_cs5535_databook.pdf Link: http://support.amd.com/TechDocs/33238G_cs5536_db.pdf Reported-and-tested-by: Nix n...@esperi.org.uk Signed-off-by: Myron Stowe myron.st...@redhat.com Signed-off-by: Bjorn Helgaas bhelg...@google.com CC: sta...@vger.kernel.org # v.2.6.27+ diff

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-04 Thread Bjorn Helgaas
On Wed, Feb 4, 2015 at 4:48 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Moreover, __weak is positively harmful when you consider it adds bloat and dead code - the overriden __weak function is left behind in the resulting final image. Huh, I didn't realize that. Is that a linker

Re: [PATCH v2 00/30] Refine PCI scan interfaces and make generic pci host bridge

2015-01-30 Thread Bjorn Helgaas
On Fri, Jan 30, 2015 at 3:10 AM, Yijing Wang wangyij...@huawei.com wrote: Hi Bjorn, Any comments for this series ? I'm so sorry to bother you. :) It's next in my queue after Wei Yang's powerpc sriov series. Here's the queue I work from:

Re: [GIT PULL] PCI fixes for v3.19

2015-01-30 Thread Bjorn Helgaas
On Tue, Jan 27, 2015 at 6:54 PM, Yinghai Lu ying...@kernel.org wrote: On Tue, Jan 27, 2015 at 3:24 PM, Tony Luck tony.l...@gmail.com wrote: On Mon, Jan 26, 2015 at 7:43 PM, Yinghai Lu ying...@kernel.org wrote: Can you please get boot bog with debug ignore_logleve? we should get print out from

Re: [PATCH 0/6] PCI: MMCONFIG clean up

2015-02-02 Thread Bjorn Helgaas
On Wed, Nov 19, 2014 at 05:04:45PM +0100, Tomasz Nowicki wrote: MMCFG ACPI table has no arch dependencies so it can be used across all architectures. Currently MMCONFIG related code resides in arch/x86 directories. This patch set is goint to isolate non-architecure specific code and make it

Re: [PATCH] 3.19-rc7: add quirk for 1c28:0122 (rev 14) SATA controller

2015-02-02 Thread Bjorn Helgaas
On Mon, Feb 2, 2015 at 2:15 PM, Tim Sander t...@krieglstein.org wrote: Hi Bjorn Am Montag 02 Februar 2015, 08:55:33 schrieb Bjorn Helgaas: [+cc Alex] On Mon, Feb 2, 2015 at 5:29 AM, Tim Sander t...@krieglstein.org wrote: The long name for this device is Lite-On IT Corp. / Plextor M6e PCI

Re: [PATCH] 3.19-rc7: add quirk for 1c28:0122 (rev 14) SATA controller

2015-02-02 Thread Bjorn Helgaas
[+cc Alex] On Mon, Feb 2, 2015 at 5:29 AM, Tim Sander t...@krieglstein.org wrote: The long name for this device is Lite-On IT Corp. / Plextor M6e PCI Express SSD [Marvell 88SS9183] (rev 14) Background: the error description on bugzilla https://bugzilla.kernel.org/show_bug.cgi?id=42679

Re: [PATCH] PCI: Fix pcibios_update_irq misuse of irq number

2015-02-02 Thread Bjorn Helgaas
On Wed, Jan 28, 2015 at 8:51 AM, Marc Zyngier marc.zyng...@arm.com wrote: pcibios_update_irq writes an irq number into the config space of a given PCI device, but ignores the fact that this number is a virtual interrupt number, which might be a very different value from what the underlying

Re: [PATCH] PCI: Fix pcibios_update_irq misuse of irq number

2015-02-02 Thread Bjorn Helgaas
On Mon, Feb 2, 2015 at 10:15 AM, Marc Zyngier marc.zyng...@arm.com wrote: On 28/01/15 15:43, Bjorn Helgaas wrote: On Wed, Jan 28, 2015 at 9:27 AM, Marc Zyngier marc.zyng...@arm.com wrote: Hi Gerry, On 28/01/15 15:21, Jiang Liu wrote: On 2015/1/28 22:51, Marc Zyngier wrote

Re: [PATCH] 3.19-rc7: add quirk for 1c28:0122 (rev 14) SATA controller

2015-02-03 Thread Bjorn Helgaas
On Tue, Feb 3, 2015 at 3:27 AM, Tim Sander t...@krieglstein.org wrote: Hi Bjorn Am Montag, 2. Februar 2015, 08:55:33 schrieb Bjorn Helgaas: [+cc Alex] On Mon, Feb 2, 2015 at 5:29 AM, Tim Sander t...@krieglstein.org wrote: The long name for this device is Lite-On IT Corp. / Plextor M6e

Re: [3.18.3 BISECTED REGRESSION] scx200_acb / cs5535-smb / geodewdt / cs5535-clockevt torpedoed

2015-02-03 Thread Bjorn Helgaas
On Mon, Feb 2, 2015 at 11:36 AM, Nix n...@esperi.org.uk wrote: On 2 Feb 2015, Myron Stowe verbalised: Nix: Thanks for the work you've already done with the bisection. Let's see if we can get to the bottom of this. Would you capture two couple sets of logs, one without the issue and

Re: [PATCH v6 0/7] PCI: get DMA configuration from parent device

2015-02-06 Thread Bjorn Helgaas
On Fri, Feb 6, 2015 at 9:28 AM, Murali Karicheri m-kariche...@ti.com wrote: On 02/06/2015 10:15 AM, Catalin Marinas wrote: On Thu, Feb 05, 2015 at 09:52:52PM +, Murali Karicheri wrote: This patch add an important capability to PCI driver on Keystone. I hope to have this merged to the

Re: [PATCH v2 04/10] PCI, frv: clip firmware assigned resource under parent bridge's

2015-01-15 Thread Bjorn Helgaas
On Wed, Jan 14, 2015 at 08:51:22PM -0800, Yinghai Lu wrote: On Wed, Jan 14, 2015 at 8:31 PM, Yinghai Lu ying...@kernel.org wrote: Some bios put range that is not fully coverred by root bus resources. Try to clip them and update them in pci bridge bars. We'd like to fix other arches

Re: [PATCH 0/4] PCI: Reset exclusions

2015-01-15 Thread Bjorn Helgaas
On Fri, Nov 21, 2014 at 11:24:02AM -0700, Alex Williamson wrote: This is really 2 sets of 2 patches, but they both add bits to dev_flags so are included together. This fixes two problems we've seen with resets. The first is for devices that advertise a PM reset mechanism, but it doesn't

Re: [PATCH 10/10] PCI, sparc: clip firmware assigned resource under parent bridge's

2015-01-15 Thread Bjorn Helgaas
On Mon, Jan 12, 2015 at 11:31:09PM +0100, Kjetil Oftedal wrote: Hi, Am I missing something or is this just code to get the the resource subsystem to accept the bus resources, not caring if the resources are actually usable? PCI BARs usually have a given size for a reason? Hi Kjetil, This

Re: [PATCH v2 00/10] PCI: clip firmware assigned resources

2015-01-15 Thread Bjorn Helgaas
On Wed, Jan 14, 2015 at 08:31:27PM -0800, Yinghai Lu wrote: During the fix https://bugzilla.kernel.org/show_bug.cgi?id=85491, Bjorn suggest that we should clip the resources instead of just reject them. We should only need first two for x86. others for related arches to keep them

Re: [PATCH 13/28] pci: host: drop owner assignment from platform_drivers

2015-01-15 Thread Bjorn Helgaas
[+cc Julia] On Sun, Dec 21, 2014 at 10:14:34PM +0100, Wolfram Sang wrote: This platform_driver does not need to set an owner, it will be populated by the driver core. Signed-off-by: Wolfram Sang w...@the-dreams.de I already applied the equivalent patch from Julia for v3.20, thanks! (I

Re: [PATCH] Avoid an infinite loop in pci_get_rom_size()

2015-01-17 Thread Bjorn Helgaas
[+cc Michel] On Sat, Jan 17, 2015 at 7:50 AM, Federico federic...@gmail.com wrote: There's a soft_lockup triggered on boot by the radeon driver when it calls pci_get_rom_size() on a certain AMD Radeon R7 250X PCIe discrete graphics card. Kernel does not boot as it loops forever unless

Re: [PATCH 0/4] PCI: Reset exclusions

2015-01-16 Thread Bjorn Helgaas
On Thu, Jan 15, 2015 at 06:28:02PM -0600, Bjorn Helgaas wrote: On Fri, Nov 21, 2014 at 11:24:02AM -0700, Alex Williamson wrote: This is really 2 sets of 2 patches, but they both add bits to dev_flags so are included together. This fixes two problems we've seen with resets. The first

Re: [PATCH 02/10] PCI, x86: clip firmware assigned resource under parent bridge's

2015-01-14 Thread Bjorn Helgaas
On Mon, Jan 12, 2015 at 11:23:12AM -0800, Yinghai Lu wrote: Some bios put range that is not fully coverred by root bus resources. Try to clip them and update them in pci bridge bars. Link: https://bugzilla.kernel.org/show_bug.cgi?id=85491 Reported-by: Marek Kordik kordikma...@gmail.com

Re: [PATCH 07/16] ARM: integrator: convert PCI to use generic config accesses

2015-01-22 Thread Bjorn Helgaas
. The config read and write functions are already protected with a spinlock and no access can occur during the .pre_init function. Signed-off-by: Rob Herring r...@kernel.org Signed-off-by: Bjorn Helgaas bhelg...@google.com Acked-by: Linus Walleij linus.wall...@linaro.org CC

Re: [PATCH 00/16] PCI generic configuration space accessors

2015-01-22 Thread Bjorn Helgaas
On Fri, Jan 09, 2015 at 08:34:34PM -0600, Rob Herring wrote: This series adds common accessor functions for PCI configuration space accesses. This supports most PCI hosts with memory mapped configuration space like ECAM or hosts with memory mapped address/data registers. ECAM is not

Re: [GIT PULL] PCI fixes for v3.19

2015-02-11 Thread Bjorn Helgaas
[+cc lists, etc.; sorry, this has been merged already, but I forgot to cc: everybody the first time] On Wed, Feb 4, 2015 at 1:18 PM, Bjorn Helgaas bhelg...@google.com wrote: Hi Linus, These are a regression fix for read-only BARs, a DesignWare fix that keeps drivers from using MSI-X (which

Re: [PATCH] drivers: of: pci: remove duplicate kfree in of_pci_get_host_bridge_resources

2015-02-11 Thread Bjorn Helgaas
@linux.intel.com Cc: Bjorn Helgaas bhelg...@google.com Cc: Rafael J. Wysocki r...@rjwysocki.net I applied this to for-linus, and will ask Linus to put it in before v3.20-rc1, thanks! Rafael, I applied d2be00c0fb5a, where the bug originally came from, but I see that you fixed it with 5c493df25a0d

[GIT PULL] PCI fixes for v3.20

2015-02-18 Thread Bjorn Helgaas
Hi Linus, This fixes a double kfree in some code we merged for v3.20. Bjorn The following changes since commit 872912352c5be930e9568e5f3b6d73107d9f278d: Merge tag 'pm+acpi-3.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm (2015-02-10 15:09:41 -0800) are available

Re: [PATCH 3/6] x86, acpi, pci: Move PCI config space accessors.

2015-02-18 Thread Bjorn Helgaas
On Tue, Feb 17, 2015 at 02:03:01PM +0100, Tomasz Nowicki wrote: On 11.12.2014 00:17, Bjorn Helgaas wrote: On Wed, Nov 19, 2014 at 05:04:48PM +0100, Tomasz Nowicki wrote: We are going to use mmio_config_{} name convention across all architectures. mmio_config_*() are workarounds for an AMD

Re: [PATCH 3.2 015/152] PCI: Restore detection of read-only BARs

2015-02-17 Thread Bjorn Helgaas
Signed-off-by: Bjorn Helgaas bhelg...@google.com CC: Matthew Wilcox wi...@linux.intel.com Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/pci/probe.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -175,14 +175,17 @@ int

Re: [PATCH RESEND] x86:pci: Change sta2x11_dma_ops stucture to use switolb_dma_supported as it's dma_supported function in sta2x11-fixup.c

2015-02-16 Thread Bjorn Helgaas
On Sun, Feb 15, 2015 at 1:54 PM, Nicholas Krause xerofo...@gmail.com wrote: This changes the structure sta2x11_dma_ops stucture to use switolb_dma_supported as it's function for dma_supported hardware verus setting this value to NULL as this should be set correctly for when dma_supported

Re: [PATCH] usb: dwc3: Moved PCI IDS to linux/pci_ids.h

2015-02-16 Thread Bjorn Helgaas
On Sun, Feb 15, 2015 at 6:17 PM, Joseph Kogut joseph.ko...@gmail.com wrote: Moved DWC3 PCI IDS to linux/pci_ids.h per the FIXME. Signed-off-by: Joseph Kogut joseph.ko...@gmail.com --- drivers/usb/dwc3/dwc3-pci.c | 10 +- include/linux/pci_ids.h | 8 2 files changed, 9

Re: [PATCH RESEND v2 7/7] PCI/hotplug: PowerPC PowerNV PCI hotplug driver

2015-02-18 Thread Bjorn Helgaas
[+cc linux-mm, linux-kernel] For context, the start of this discussion was here: http://lkml.kernel.org/r/1424157203-691-8-git-send-email-gws...@linux.vnet.ibm.com where Gavin is adding a new PCI hotplug driver for PowerNV. That new driver calls vm_unmap_aliases() the same way we do in the

Re: [GIT PULL] PCI fixes for v3.19

2015-01-26 Thread Bjorn Helgaas
On Mon, Jan 26, 2015 at 01:24:51PM -0800, Tony Luck wrote: On Mon, Jan 26, 2015 at 1:02 PM, Bjorn Helgaas bhelg...@google.com wrote: Sorry for the inconvenience. Can you collect a complete dmesg log and lspci -vv output, too (from the kernel with the reverted commit)? That will have more

Re: [PATCH v4 4/6] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-26 Thread Bjorn Helgaas
On Mon, Jan 26, 2015 at 5:25 PM, Murali Karicheri m-kariche...@ti.com wrote: On 01/23/2015 06:41 PM, Bjorn Helgaas wrote: On Fri, Jan 23, 2015 at 05:32:37PM -0500, Murali Karicheri wrote: Add of_pci_dma_configure() to allow updating the dma configuration of the pci device using

Re: [PATCH 2/6] PCI/MSI: add hooks to populate the msi_domain field

2015-01-26 Thread Bjorn Helgaas
On Mon, Dec 08, 2014 at 08:12:19PM +, Marc Zyngier wrote: In order to be able to populate the device msi_domain field, add the necesary hooks to propagate the PHB msi_domain across secondary busses to devices. So far, nobody populates the initial msi_domain. Signed-off-by: Marc

Re: [PATCH 3/6] PCI/MSI: of: add support for OF-provided msi_domain

2015-01-26 Thread Bjorn Helgaas
On Mon, Dec 08, 2014 at 08:12:20PM +, Marc Zyngier wrote: In order to populate the PHB msi_domain, use the msi-parent attribute to lookup a corresponding irq domain. If found, this is our MSI domain. This gets plugged into the core PCI code. Signed-off-by: Marc Zyngier

Re: [PATCH 2/6] PCI/MSI: add hooks to populate the msi_domain field

2015-01-26 Thread Bjorn Helgaas
On Mon, Jan 26, 2015 at 06:40:05PM -0600, Bjorn Helgaas wrote: On Mon, Dec 08, 2014 at 08:12:19PM +, Marc Zyngier wrote: In order to be able to populate the device msi_domain field, add the necesary hooks to propagate the PHB msi_domain across secondary busses to devices. So far

Re: [GIT PULL] PCI fixes for v3.19

2015-01-27 Thread Bjorn Helgaas
On Mon, Jan 26, 2015 at 9:55 PM, Yinghai Lu ying...@kernel.org wrote: On Mon, Jan 26, 2015 at 3:53 PM, Bjorn Helgaas bhelg...@google.com wrote: On Mon, Jan 26, 2015 at 01:24:51PM -0800, Tony Luck wrote: On Mon, Jan 26, 2015 at 1:02 PM, Bjorn Helgaas bhelg...@google.com wrote: Sorry

Re: [PATCH v4 4/6] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-27 Thread Bjorn Helgaas
On Tue, Jan 27, 2015 at 12:14 PM, Murali Karicheri m-kariche...@ti.com wrote: On 01/26/2015 06:59 PM, Bjorn Helgaas wrote: On Mon, Jan 26, 2015 at 5:25 PM, Murali Karicherim-kariche...@ti.com wrote: On 01/23/2015 06:41 PM, Bjorn Helgaas wrote: On Fri, Jan 23, 2015 at 05:32:37PM -0500

Re: [PATCH] PCI: Fix pcibios_update_irq misuse of irq number

2015-01-28 Thread Bjorn Helgaas
On Wed, Jan 28, 2015 at 9:27 AM, Marc Zyngier marc.zyng...@arm.com wrote: Hi Gerry, On 28/01/15 15:21, Jiang Liu wrote: On 2015/1/28 22:51, Marc Zyngier wrote: pcibios_update_irq writes an irq number into the config space of a given PCI device, but ignores the fact that this number is a

Re: [Patch v2 18/22] PCI: Use common resource list management code instead of private implementation

2015-01-28 Thread Bjorn Helgaas
On Wed, Jan 28, 2015 at 06:57:36PM +0800, Jiang Liu wrote: Use common resource list management data structure and interfaces instead of private implementation. Signed-off-by: Jiang Liu jiang@linux.intel.com Acked-by: Bjorn Helgaas bhelg...@google.com --- arch/arm/kernel/bios32.c

Re: [Patch v2 19/22] x86/PCI/ACPI: Use common ACPI resource interfaces to simplify implementation

2015-01-28 Thread Bjorn Helgaas
On Wed, Jan 28, 2015 at 06:57:37PM +0800, Jiang Liu wrote: Use common ACPI resource discovery interfaces to simplify PCI host bridge resource enumeration. It also fixes the issue discovered by Thomas that function setup_resource() incorrectly validates IO port resources against

Re: [Patch v2 20/22] x86/PCI: Refine the way to release PCI IRQ resources

2015-01-28 Thread Bjorn Helgaas
On Wed, Jan 28, 2015 at 06:57:38PM +0800, Jiang Liu wrote: Some PCI device drivers assume that pci_dev-irq won't change after calling pci_disable_device() and pci_enable_device() during suspend and resume. Commit c03b3b0738a56cf283b0d05256988d5e3c8bd719 (x86, irq, mpparse: Cosmetic: please

Re: [Patch v2 19/22] x86/PCI/ACPI: Use common ACPI resource interfaces to simplify implementation

2015-01-28 Thread Bjorn Helgaas
iomem_resource. Signed-off-by: Jiang Liu jiang@linux.intel.com Nice cleanups, thanks. A few more trival comments below. Acked-by: Bjorn Helgaas bhelg...@google.com --- arch/x86/pci/acpi.c | 296 --- 1 file changed, 94 insertions(+), 202 deletions

Re: [Patch v2 09/22] ACPI: Fix a bug in parsing ACPI Memroy24 resource

2015-01-28 Thread Bjorn Helgaas
Memory24, not Memroy24, in subject. On Wed, Jan 28, 2015 at 06:57:27PM +0800, Jiang Liu wrote: According to ACPI spec 5, section 6.4.3.1 24-Bit Memory Range Descriptor, minimum, maximum and address_length field in struct acpi_resource_memory24 is in granularity of 256-bytes. So shift 8-bit

Re: PCIe 32-bit MMIO exhaustion

2015-01-29 Thread Bjorn Helgaas
[+cc Yinghai] Hi Daniel, On Wed, Jan 28, 2015 at 2:42 AM, Daniel J Blueman dan...@numascale.com wrote: With systems with a large number of PCI devices, we're seeing lack of 32-bit MMIO space, eg one quad-port NetXtreme-2 adapter takes 128MB of space [1]. An errata to the PCIe 2.1 spec

Re: [PATCH 06/16] ARM: cns3xxx: convert PCI to use generic config accesses

2015-01-29 Thread Bjorn Helgaas
On Thu, Jan 29, 2015 at 12:16 AM, Krzysztof Hałasa khal...@piap.pl wrote: Rob Herring r...@kernel.org writes: Convert the cns3xxx PCI driver to use the generic config access functions. This changes accesses from __raw_readl/__raw_writel to readl/writel. arch/arm/mach-cns3xxx/pcie.c | 52

Re: [GIT PULL] PCI fixes for v3.19

2015-01-30 Thread Bjorn Helgaas
On Fri, Jan 30, 2015 at 3:49 PM, Yinghai Lu ying...@kernel.org wrote: On Fri, Jan 30, 2015 at 8:56 AM, Bjorn Helgaas bhelg...@google.com wrote: On Tue, Jan 27, 2015 at 6:54 PM, Yinghai Lu ying...@kernel.org wrote: On Tue, Jan 27, 2015 at 3:24 PM, Tony Luck tony.l...@gmail.com wrote: On Mon

Re: [GIT PULL] PCI fixes for v3.19

2015-01-30 Thread Bjorn Helgaas
On Fri, Jan 30, 2015 at 12:01 PM, Tony Luck tony.l...@gmail.com wrote: On Fri, Jan 30, 2015 at 8:56 AM, Bjorn Helgaas bhelg...@google.com wrote: Tony, does the system work as it did before? Is the only problem that now we have more warnings than we did before? Yup - things seem to be working

Re: [PATCH v2] pci: Fix infinite loop with ROM image of size 0

2015-01-23 Thread Bjorn Helgaas
On Mon, Jan 19, 2015 at 05:53:20PM +0900, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com If the image size would ever read as 0, pci_get_rom_size could keep processing the same image over and over again. Reported-by: Federico federic...@gmail.com Cc:

Re: [RFC PATCH v3 2/2] arm: kernel: fix pci_mmap_page_range() offset calculation

2015-01-23 Thread Bjorn Helgaas
...@arm.com Acked-by: Bjorn Helgaas bhelg...@google.com --- arch/arm/kernel/bios32.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c index 17a26c1..b56fa2d 100644 --- a/arch/arm/kernel/bios32.c +++ b/arch/arm

Re: [PATCH v4 4/6] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-23 Thread Bjorn Helgaas
...@linaro.org Cc: Rob Herring robh...@kernel.org Cc: Bjorn Helgaas bhelg...@google.com Cc: Will Deacon will.dea...@arm.com Cc: Russell King li...@arm.linux.org.uk Cc: Arnd Bergmann a...@arndb.de Cc: Suravee Suthikulpanit suravee.suthikulpa...@amd.com Signed-off-by: Murali Karicheri m-kariche

Re: [RFC PATCH v3 1/2] drivers: pci: fix pci_mmap_fits() implementation for procfs mmap

2015-01-23 Thread Bjorn Helgaas
On Wed, Jan 21, 2015 at 06:44:56PM +, Lorenzo Pieralisi wrote: Hi Bjorn, On Fri, Nov 21, 2014 at 05:51:14PM +, Bjorn Helgaas wrote: On Thu, Nov 13, 2014 at 11:19:15AM +, Lorenzo Pieralisi wrote: The introduction of pci_mmap_fits() in commit

Re: [PATCH v2 0/8] Introducing per-device MSI domain

2015-01-26 Thread Bjorn Helgaas
On Thu, Jan 08, 2015 at 05:06:04PM +, Marc Zyngier wrote: MSI-like interrupts are starting to creep out of the PCI world, and can now be seen into a number of platform-type busses. The MSI domain patches recognise that fact, and start providing a way to implement this. Another problem

Re: [PATCH v2] PCI/sysfs: off by two when checking the limit on driver_override length

2015-01-10 Thread Bjorn Helgaas
new device binding path using pci_dev.driver_override) Cc: Alex Williamson alex.william...@redhat.com Cc: Bjorn Helgaas bhelg...@google.com Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com Cc: Alexander Graf ag...@suse.de Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off

Re: [PATCH] PCI/ASPM: use standard parsing functions for sysfs setters

2015-01-09 Thread Bjorn Helgaas
On Fri, Dec 05, 2014 at 05:02:42PM -0600, Chris J Arges wrote: The functions link_state_store, clk_ctl_store had just subtracted ASCII '0' from input which could lead to undesired results. Instead, use linux string functions to safely parse input. Signed-off-by: Chris J Arges

Re: [PATCH] PCI: Add disabling pm async quirk for JMicron chips

2015-01-09 Thread Bjorn Helgaas
On Fri, Dec 05, 2014 at 02:18:40PM -0500, Alan Stern wrote: On Fri, 5 Dec 2014, Chuansheng Liu wrote: Some history from commit e6b7e41cdd8c (ata: Disabling the async PM for JMicron chip 363/361) == Since v3.15, the PM feature of async noirq commit 76569faa62c4 (PM / sleep:

Re: [PATCH] PCI: Generate uppercase hex for modalias var in uevent

2015-01-09 Thread Bjorn Helgaas
yourself when posting the patch, too :) Bjorn On Fri, Jan 9, 2015 at 6:27 PM, Bjorn Helgaas bhelg...@google.com wrote: On Tue, Dec 02, 2014 at 05:35:04PM +0100, Ricardo Ribalda Delgado wrote: Some implementations of modprobe fail to load the driver for a PCI device automatically because

Re: [PATCH 2/20] PCI: keystone: fix misspelling of current function in string

2015-01-09 Thread Bjorn Helgaas
On Sun, Dec 07, 2014 at 08:20:44PM +0100, Julia Lawall wrote: Replace a misspelled function name by %s and then __func__. The function name contains pcie, not pci as in the string. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes.

Re: [PATCH] PCI: Generate uppercase hex for modalias var in uevent

2015-01-09 Thread Bjorn Helgaas
, as we already do for the Vendor ID, Device ID, Class, etc. Commit 89ec3dcf17fd (PCI: Generate uppercase hex for modalias interface class) fixed only half of the problem. Some udev implementations relays on the uevent file and not in the modalias file. CC: Bjorn Helgaas bhelg...@google.com CC

Re: [PATCH 4/4] PCI: quirk Atheros AR93xx to avoid bus reset

2015-01-12 Thread Bjorn Helgaas
On Mon, Jan 12, 2015 at 1:15 PM, Andreas Hartmann andihartm...@freenet.de wrote: Hello Alex! Alex Williamson wrote: On Mon, 2015-01-12 at 16:20 +0100, Andreas Hartmann wrote: Alex Williamson wrote: On Thu, 2015-01-08 at 09:07 -0700, Bjorn Helgaas wrote: On Fri, Nov 21, 2014 at 11:24:27AM

Re: [PATCH 4/4] PCI: quirk Atheros AR93xx to avoid bus reset

2015-01-08 Thread Bjorn Helgaas
On Thu, Jan 8, 2015 at 1:30 PM, Alex Williamson alex.william...@redhat.com wrote: On Thu, 2015-01-08 at 09:07 -0700, Bjorn Helgaas wrote: On Fri, Nov 21, 2014 at 11:24:27AM -0700, Alex Williamson wrote: Reports against the TL-WDN4800 card indicate that PCI bus reset of this Atheros device

Re: [PATCH 4/5] PCI: qcom: Add Qualcomm PCIe controller driver

2015-01-12 Thread Bjorn Helgaas
On Fri, Dec 12, 2014 at 07:14:00PM +0200, Stanimir Varbanov wrote: The PCIe driver reuse the Designware common code for host and MSI initialization, and also program the Qualcomm application specific registers. Signed-off-by: Stanimir Varbanov svarba...@mm-sol.com ---

Re: [PATCH 3/5] PCI: st: Provide support for the sti PCIe controller

2015-01-12 Thread Bjorn Helgaas
On Wed, Dec 17, 2014 at 11:34:44AM +0100, Gabriel FERNANDEZ wrote: sti pcie is built around a Synopsis Designware PCIe IP. Signed-off-by: Fabrice Gasnier fabrice.gasn...@st.com Signed-off-by: Gabriel Fernandez gabriel.fernan...@linaro.org --- drivers/pci/host/Kconfig | 5 +

[GIT PULL] PCI changes for v3.20

2015-02-09 Thread Bjorn Helgaas
surprise add even if surprise removal isn't supported (Bjorn Helgaas) Virtualization - Mark AMD/ATI VGA devices that don't reset on D3hot-D0 transition (Alex Williamson) - Add DMA alias quirk for Adaptec 3405 (Alex Williamson) - Add Wellsburg (X99) to Intel PCH root port ACS quirk

Re: [PATCH 4/4] PCI: quirk Atheros AR93xx to avoid bus reset

2015-01-08 Thread Bjorn Helgaas
On Fri, Nov 21, 2014 at 11:24:27AM -0700, Alex Williamson wrote: Reports against the TL-WDN4800 card indicate that PCI bus reset of this Atheros device cause system lock-ups and resets. I've also been able to confirm this behavior on multiple systems. The device never returns from reset and

Re: [PATCH 0/3] PCI/x86: Interface for testing multivector MSI support

2015-01-08 Thread Bjorn Helgaas
On Fri, Nov 21, 2014 at 03:08:27PM -0700, Alex Williamson wrote: I'd like to make vfio-pci capable of manipulating the device exposed to the user such that if the host can only support a single MSI vector then we hide the fact that the device itself may actually be able to support more. When

Re: [PATCH v3 0/4] PCI: get DMA configuration from parent device

2015-01-07 Thread Bjorn Helgaas
On Wed, Jan 7, 2015 at 5:05 PM, Murali Karicheri m-kariche...@ti.com wrote: On 01/07/2015 01:49 PM, Murali Karicheri wrote: PCI devices on Keystone doesn't have correct dma_pfn_offset set. This patch add capability to set the dma configuration such as dma-mask, dma_pfn_offset, and dma ops

Re: Hit a deadlock: between AER and pcieport/pciehp

2015-03-17 Thread Bjorn Helgaas
[+cc Rafael] Hi Rajat, On Tue, Mar 17, 2015 at 2:11 PM, Rajat Jain rajatxj...@gmail.com wrote: Hello, I was wondering if any one has a any suggestions to make here. I believe this is a pretty serious deadlock - and I'm looking for ideas on what should be the right way to fix this. I agree,

Re: [PATCH] ARM: add PCI hotplug support

2015-03-20 Thread Bjorn Helgaas
with a TI XIO3130 PCIe bridge (with hotplug enabled) and fixes for IRQ assignment added. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk I assume this will be handled via an ARM tree, but if you want it: Acked-by: Bjorn Helgaas bhelg...@google.com -- CC: Linux ARM Kernel list linux-arm-ker

Re: [Bugfix] x86/PCI: Release PCI IRQ resource only if PCI device is disabled when unbinding

2015-03-20 Thread Bjorn Helgaas
On Thu, Mar 19, 2015 at 10:09 PM, Jiang Liu jiang@linux.intel.com wrote: On 2015/3/19 22:08, Bjorn Helgaas wrote: There are two other possibilities I can see: 1) Decide that a driver that captures the IRQ and then calls pci_enable_device() is just broken, and fix those drivers to re

Re: [Bugfix] x86/PCI: Release PCI IRQ resource only if PCI device is disabled when unbinding

2015-03-19 Thread Bjorn Helgaas
On Thu, Mar 19, 2015 at 6:29 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Thursday, March 19, 2015 03:49:33 PM Jiang Liu wrote: On 2015/3/19 6:11, Bjorn Helgaas wrote: On Tue, Mar 17, 2015 at 03:37:12PM +0800, Jiang Liu wrote: To support IOAPIC hot-removal, we need to release PCI

Re: [PATCH - v7] of: Move of_dma_configure() to device.c to help re-use

2015-03-19 Thread Bjorn Helgaas
On Tue, Mar 03, 2015 at 05:54:25PM -0500, Murali Karicheri wrote: On 03/03/2015 03:53 PM, Bjorn Helgaas wrote: [+cc linux-pci] On Tue, Mar 3, 2015 at 11:55 AM, Murali Karicherim-kariche...@ti.com wrote: On 03/02/2015 10:43 PM, Bjorn Helgaas wrote: On Mon, Mar 2, 2015 at 3:59 PM, Murali

Re: [PATCH v1] of/pci : fix of_pci_dma_configure parent ptr NULL

2015-03-19 Thread Bjorn Helgaas
On Wed, Mar 11, 2015 at 12:40:03PM -0400, Murali Karicheri wrote: On some platforms such as that based on x86, ia64 etc, root bus is created with parent node passed in as NULL to pci_create_root_bus(). On these platforms, the patch series PCI: get DMA configuration from parent device when

Re: PCIe 32-bit MMIO exhaustion

2015-03-19 Thread Bjorn Helgaas
On Wed, Mar 04, 2015 at 11:01:59AM -0600, Bjorn Helgaas wrote: On Wed, Mar 04, 2015 at 03:12:04PM +0800, Daniel J Blueman wrote: Your patch solves the conflicts nicely [1] with: From f835b16b0758a1dde6042a0e4c8aa5a2e8be5f21 Mon Sep 17 00:00:00 2001 From: Daniel J Blueman dan

Re: [PATCH v7 0/4] pci: iproc: Add Broadcom iProc PCIe support

2015-03-19 Thread Bjorn Helgaas
[+cc Florian] On Thu, Mar 12, 2015 at 05:48:48PM -0700, Ray Jui wrote: This patch series adds the support for Broadcom iProc PCIe controller pcie-iproc.c servers as the common core driver, and front-end bus interface needs to be added to support different bus interfaces pcie-iproc-pltfm.c

Re: Linux XIA - merge proposal

2015-03-20 Thread Bjorn Helgaas
[+cc Arnd] On Fri, Mar 20, 2015 at 1:46 PM, Michel Machado mic...@digirati.com.br wrote: On 03/18/2015 06:27 AM, Oded Gabbay wrote: Hi Michel, If you want an example of how to break a fairly medium+ code-base/driver, I believe amdkfd is a good example. Originally, I had dumped 80+ patches,

Re: [PCI] BUG: unable to handle kernel

2015-03-09 Thread Bjorn Helgaas
On Mon, Mar 9, 2015 at 9:17 AM, Murali Karicheri m-kariche...@ti.com wrote: On 03/06/2015 12:58 PM, Murali Karicheri wrote: On 03/06/2015 11:55 AM, Guenter Roeck wrote: On Fri, Mar 06, 2015 at 10:48:59AM -0500, Murali Karicheri wrote: [ ... ] From 098b4f5e4ab9407fbdbfcca3a91785c17e25cf03

Re: [Patch v2 resend] apple-gmux: lock iGP IO to protect from vgaarb changes

2015-03-09 Thread Bjorn Helgaas
. It is expected to load/probe gmux prior to graphics drivers. Fixes: ce027dac592c0ada241ce0f95ae65856828ac450 # nvidia interaction Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=86121 Reported-by: Petri Hodju petriho...@yahoo.com Tested-by: Petri Hodju petriho...@yahoo.com Cc: Bjorn

Re: [PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-11 Thread Bjorn Helgaas
On Wed, Mar 11, 2015 at 3:14 PM, Alex Williamson alex.william...@redhat.com wrote: On Fri, 2015-03-06 at 16:11 -0600, Bjorn Helgaas wrote: On Wed, Mar 04, 2015 at 01:02:43PM -0700, Alex Williamson wrote: This copies the same support from pci-stub for exactly the same purpose, enabling a set

Re: [PATCH v6 03/30] PCI: Export busn_resource to drivers/pci

2015-03-11 Thread Bjorn Helgaas
On Mon, Mar 09, 2015 at 10:34:00AM +0800, Yijing Wang wrote: Export out busn_resource. Xen pcifront module need it. Signed-off-by: Yijing Wang wangyij...@huawei.com --- drivers/pci/pci.h |2 ++ drivers/pci/probe.c |3 ++- 2 files changed, 4 insertions(+), 1 deletions(-) diff

Re: [PATCH v6 04/30] xen/PCI: Don't use deprecated function pci_scan_bus_parented()

2015-03-11 Thread Bjorn Helgaas
Wilk konrad.w...@oracle.com CC: xen-de...@lists.xenproject.org Signed-off-by: Bjorn Helgaas bhelg...@google.com --- drivers/pci/xen-pcifront.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c index

Re: [PATCH] PCI: xgene: fix breakage from generic config usage

2015-03-06 Thread Bjorn Helgaas
On Wed, Mar 04, 2015 at 05:24:24PM -0500, Mark Salter wrote: Commit 350f8be5bb402 (PCI: xgene: Convert to use generic config accessors) breaks PCI on the X-Gene platform. It creates two problems with the xgene_pcie_map_bus() function. First, it returns an int but should return a void __iomem

Re: [PATCH v2 0/9] PCI: MMCONFIG clean up

2015-03-06 Thread Bjorn Helgaas
On Fri, Feb 27, 2015 at 04:00:35PM +0100, Tomasz Nowicki wrote: MCFG ACPI table and PCI ECAM standard have no arch dependencies so it can be used across all architectures. Currently MMCONFIG related code resides in arch/x86 directories. This patch set is going to isolate non-architecure

Re: [PATCH v2] PCI/AER: Avoid info leak in __print_tlp_header

2015-03-06 Thread Bjorn Helgaas
On Thu, Feb 26, 2015 at 09:55:03AM +0100, Rasmus Villemoes wrote: Commit fab4c256a58b (PCI/AER: Add a TLP header print helper) introduced the helper function __print_tlp_header, but contrary to the intention, the behaviour did change: Since we're taking the address of the parameter t, the

Re: [PATCH 0/2] PCI: pci_unignore_hotplug()

2015-03-06 Thread Bjorn Helgaas
On Tue, Feb 24, 2015 at 03:23:27PM -0500, Alex Deucher wrote: On Tue, Feb 24, 2015 at 3:12 PM, Alex Williamson alex.william...@redhat.com wrote: I'd kinda like to use pci_ignore_hotplug() for devices in use by a user via vfio-pci, but the interface seems only partially implemented since we

Re: [PATCH v3] pci: spear: Drop __initdata from spear13xx_pcie_driver

2015-03-06 Thread Bjorn Helgaas
On Thu, Feb 19, 2015 at 08:41:48PM +0300, Matwey V. Kornilov wrote: spear13xx_pcie_driver.driver is allocated in text.init section and then the pointer to it is passed futher. This patch is to avoid crashes like the following, when freed memory is used. Also, __init has been dropped from the

  1   2   3   4   5   6   7   8   9   10   >