Re: Wrong free clusters count on FAT32

2007-04-19 Thread Boaz Harrosh
DervishD wrote: Hi all :) I have a portable device with a FAT32 formatted hard disk in it, and everytime I delete a file in the device *using the device itself to do it* the device increases its count of free space and if I plug the device in a Windows system, Windows agrees on the

Re: mcdx -- do_request(): non-read command to cd!!

2007-04-02 Thread Boaz Harrosh
Pekka J Enberg wrote: On Mon, 2 Apr 2007, Jens Axboe wrote: But as I wrote earlier, it'll take lots more to make this driver close to functional. Heh, looking at the driver, that's quite an understatement =). Rene, here's an untested attempt to use a mutex instead of the horribly broken

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2008-01-07 Thread Boaz Harrosh
On Mon, Jan 07 2008 at 8:53 +0200, FUJITA Tomonori [EMAIL PROTECTED] wrote: On Sun, 23 Dec 2007 13:09:05 +0200 Boaz Harrosh [EMAIL PROTECTED] wrote: On Fri, Dec 21 2007 at 4:30 +0200, Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: The sense buffer ins scsi_cmnd can nowadays be DMA'ed

Re: [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl

2008-01-10 Thread Boaz Harrosh
On Thu, Jan 10 2008 at 21:45 +0200, Andre Noll [EMAIL PROTECTED] wrote: On 20:29, Andi Kleen wrote: Sure, I can do that if James likes the idea. Since not all case statements need the BKL, we could add it only to those for which it isn't clear that it is unnecessary. And this would

Re: [PATCH] ata_sg_setup_one vs ata_sg_setup?

2007-11-14 Thread Boaz Harrosh
On Wed, Nov 14 2007 at 6:40 +0200, Rusty Russell [EMAIL PROTECTED] wrote: Hi Jeff, Was looking through libata, and it seems to me that ata_sg_setup is a superset of ata_sg_setup_one. Am I missing something? Seems like it could be simplified. My machine never seems to do an

Re: 2.6.24-rc2-mm1

2007-11-15 Thread Boaz Harrosh
the patches from Boaz Harrosh) srb-resid got replaced by scsi_get_resid() it I see that right. I'm CC'ing the author , he will know I think. The replacement looks, to my eye, to be logically correct. The patch was pretty clean. Then again, I haven't looked at what is under the hood

Re: INITIO scsi driver fails to work properly

2007-12-17 Thread Boaz Harrosh
On Mon, Dec 17 2007 at 13:41 +0200, Filippos Papadopoulos [EMAIL PROTECTED] wrote: On Dec 17, 2007 1:18 PM, Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 17 Dec 2007 11:39:47 +0200 Filippos Papadopoulos [EMAIL PROTECTED] wrote: Hi, I have got an INITIO 9100 UW SCSI Controller with an IBM

Re: INITIO scsi driver fails to work properly

2007-12-17 Thread Boaz Harrosh
On Mon, Dec 17 2007 at 14:18 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: On Mon, Dec 17 2007 at 13:41 +0200, Filippos Papadopoulos [EMAIL PROTECTED] wrote: On Dec 17, 2007 1:18 PM, Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 17 Dec 2007 11:39:47 +0200 Filippos Papadopoulos [EMAIL

Re: INITIO scsi driver fails to work properly

2007-12-17 Thread Boaz Harrosh
On Mon, Dec 17 2007 at 15:05 +0200, Alan Cox [EMAIL PROTECTED] wrote: initio doesn't seem to have a maintainer... Are you able to identify any earlier kernel which worked OK? Maybe it's a new device? If you can get the `lspci -vvxx' output for that device we can take a look. If I

Re: INITIO scsi driver fails to work properly

2007-12-17 Thread Boaz Harrosh
On Mon, Dec 17 2007 at 17:03 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2007-12-17 at 14:36 +, Alan Cox wrote: On Mon, 17 Dec 2007 16:40:53 +0200 Boaz Harrosh [EMAIL PROTECTED] wrote: On Mon, Dec 17 2007 at 15:05 +0200, Alan Cox [EMAIL PROTECTED] wrote: initio doesn't seem

Re: INITIO scsi driver fails to work properly

2007-12-17 Thread Boaz Harrosh
On Mon, Dec 17 2007 at 18:20 +0200, Olivier Galibert [EMAIL PROTECTED] wrote: On Mon, Dec 17, 2007 at 06:08:59PM +0200, Boaz Harrosh wrote: Below fixes a deadly typo. Might as well be included in 2.6.24 You're sure ? scsi_for_each_sg includes a (sg)++ already

Re: INITIO scsi driver fails to work properly

2007-12-19 Thread Boaz Harrosh
On Wed, Dec 19 2007 at 10:48 +0200, Filippos Papadopoulos [EMAIL PROTECTED] wrote: On Dec 17, 2007 2:18 PM, Boaz Harrosh [EMAIL PROTECTED] wrote: I have found one problem. Please try patch [2] below and report. If it still fails try to enable debugging by setting with patch [1] these values

Re: [PATCH 0/5] sg_ring for scsi

2007-12-20 Thread Boaz Harrosh
On Thu, Dec 20 2007 at 9:58 +0200, Jens Axboe [EMAIL PROTECTED] wrote: On Thu, Dec 20 2007, Rusty Russell wrote: On Thursday 20 December 2007 18:07:41 FUJITA Tomonori wrote: On Thu, 20 Dec 2007 16:45:18 +1100 Rusty Russell [EMAIL PROTECTED] wrote: OK, some fixes since last time, as I wade

[PATCH 1/3] SG: Move functions to lib/scatterlist.c and add sg chaining allocator helpers

2007-12-20 Thread Boaz Harrosh
Manually doing chained sg lists is not trivial, so add some helpers to make sure that drivers get it right. Signed-off-by: Jens Axboe [EMAIL PROTECTED] --- include/linux/scatterlist.h | 125 --- lib/Makefile|2 +- lib/scatterlist.c | 281

[PATCH 2/3] SG: Convert SCSI to use scatterlist helpers for sg chaining

2007-12-20 Thread Boaz Harrosh
From: Jens Axboe [EMAIL PROTECTED] Signed-off-by: Jens Axboe [EMAIL PROTECTED] --- drivers/scsi/libsrp.c|2 +- drivers/scsi/scsi_error.c|4 +- drivers/scsi/scsi_lib.c | 150 +- drivers/usb/storage/isd200.c |4 +-

[PATCH 3/3] SG: Update ide/ to use sg_table

2007-12-20 Thread Boaz Harrosh
From: Jens Axboe [EMAIL PROTECTED] Signed-off-by: Jens Axboe [EMAIL PROTECTED] --- drivers/ide/arm/icside.c |6 +++--- drivers/ide/cris/ide-cris.c |2 +- drivers/ide/ide-dma.c |8 drivers/ide/ide-io.c |2 +- drivers/ide/ide-probe.c |6

Re: [PATCH 1/3] SG: Move functions to lib/scatterlist.c and add sg chaining allocator helpers

2007-12-20 Thread Boaz Harrosh
A small comment in body On Thu, Dec 20 2007 at 16:00 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: Manually doing chained sg lists is not trivial, so add some helpers to make sure that drivers get it right. Signed-off-by: Jens Axboe [EMAIL PROTECTED] --- include/linux/scatterlist.h | 125

Re: [PATCH 2/3] SG: Convert SCSI to use scatterlist helpers for sg chaining

2007-12-20 Thread Boaz Harrosh
On Thu, Dec 20 2007 at 16:03 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: From: Jens Axboe [EMAIL PROTECTED] Signed-off-by: Jens Axboe [EMAIL PROTECTED] --- drivers/scsi/libsrp.c|2 +- drivers/scsi/scsi_error.c|4 +- drivers/scsi/scsi_lib.c | 150

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2007-12-23 Thread Boaz Harrosh
On Fri, Dec 21 2007 at 4:30 +0200, Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: The sense buffer ins scsi_cmnd can nowadays be DMA'ed into directly by some low level drivers (that typically happens with USB mass storage). This is a problem on non cache coherent architectures such as

Re: 2.6.24-rc3-mm2: Result: hostbyte=0x01 driverbyte=0x00\nend_request: I/O error

2007-11-29 Thread Boaz Harrosh
On Thu, Nov 29 2007 at 1:36 +0200, Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 28 Nov 2007 16:14:21 -0700 Matthew Wilcox [EMAIL PROTECTED] wrote: On Wed, Nov 28, 2007 at 01:40:36PM -0800, Andrew Morton wrote: On Wed, 28 Nov 2007 23:01:31 +0300 Alexey Dobriyan [EMAIL PROTECTED] wrote:

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-04 Thread Boaz Harrosh
On Sat, Dec 01 2007 at 1:35 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote: This patch converts bidi of scsi mid-layer to use blk_end_request(). rq-next_rq represents a pair of bidi requests. (There are no other use of 'next_rq' of struct request.) For both requests in the pair,

Re: [PATCH 01/28] blk_end_request: add new request completion interface (take 3)

2007-12-04 Thread Boaz Harrosh
On Sat, Dec 01 2007 at 1:24 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote: This patch adds 2 new interfaces for request completion: o blk_end_request() : called without queue lock o __blk_end_request() : called with queue lock held Some device drivers call some generic functions below

Re: [PATCH 00/28] blk_end_request: full I/O completion handler (take 3)

2007-12-04 Thread Boaz Harrosh
On Tue, Dec 04 2007 at 14:16 +0200, Jens Axboe [EMAIL PROTECTED] wrote: On Fri, Nov 30 2007, Kiyoshi Ueda wrote: Hello Jens, The following is the updated patch-set for blk_end_request(). Changes since the last version are only minor updates to catch up with the base kernel changes. Do you

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-06 Thread Boaz Harrosh
On Thu, Dec 06 2007 at 2:26 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote: Hi Boaz, On Tue, 04 Dec 2007 15:39:12 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: On Sat, Dec 01 2007 at 1:35 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote: This patch converts bidi of scsi mid-layer to use

Re: 2.6.24-rc3-mm2

2007-11-28 Thread Boaz Harrosh
8f21118911efce786fc1707644a4e6323521a92f Mon Sep 17 00:00:00 2001 From: Boaz Harrosh [EMAIL PROTECTED] Date: Sun, 9 Sep 2007 21:31:21 +0300 Subject: [PATCH] [SCSI] arm: convert to accessors and !use_sg cleanup - convert to accessors and !use_sg cleanup Signed-off-by: Boaz Harrosh [EMAIL

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-09 Thread Boaz Harrosh
On Thu, Dec 06 2007 at 21:44 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote: Hi Boaz, Jens, On Thu, 06 Dec 2007 11:24:44 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: Index: 2.6.24-rc3-mm2/drivers/scsi/scsi_lib.c snip No I don't like it. The only client left for blk_end_request_callback

Re: [PATCH 20/30] blk_end_request: changing xsysace (take 4)

2007-12-12 Thread Boaz Harrosh
Kiyoshi Ueda wrote: This patch converts xsysace to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. xsysace is a little bit different from normal drivers. xsysace driver has a state machine in it. It calls end_that_request_first() and

Re: 2.6.24-rc3-mm1

2007-12-12 Thread Boaz Harrosh
On Tue, Dec 11 2007 at 18:33 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2007-11-26 at 22:15 -0800, Andrew Morton wrote: OK, thanks. I'll assume that James and Hannes have this in hand (or will have, by mid-week) and I won't do anything here. Just to confirm what I think I'm

[PATCH] REQ-flags to/from BIO-flags bugfix

2007-12-12 Thread Boaz Harrosh
- BIO flags bio-bi_rw and REQ flags req-cmd_flags no longer match. Remove comments and do a proper translation between the 2 systems. (Please look in ll_rw_blk.c/blk_rq_bio_prep() below if we need more flags) Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- block/ll_rw_blk.c

Re: [PATCH] REQ-flags to/from BIO-flags bugfix

2007-12-12 Thread Boaz Harrosh
On Wed, Dec 12 2007 at 17:18 +0200, Matthew Wilcox [EMAIL PROTECTED] wrote: On Wed, Dec 12, 2007 at 01:03:10PM +0200, Boaz Harrosh wrote: - BIO flags bio-bi_rw and REQ flags req-cmd_flags no longer match. Remove comments and do a proper translation between the 2 systems. I'd rather see

Re: [PATCH 20/30] blk_end_request: changing xsysace (take 4)

2007-12-12 Thread Boaz Harrosh
On Wed, Dec 12 2007 at 19:06 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote: Hi, On Wed, 12 Dec 2007 11:09:12 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: Index: 2.6.24-rc4/drivers/block/xsysace.c === --- 2.6.24-rc4.orig/drivers

Re: [ANNOUNCE] qgit-2.1 and qgit-1.5.8

2007-12-31 Thread Boaz Harrosh
On Mon, Dec 31 2007 at 13:58 +0200, Marco Costalba [EMAIL PROTECTED] wrote: On Dec 31, 2007 11:59 AM, Filippo Zangheri [EMAIL PROTECTED] wrote: Hi, I git-cloned qgit-2.1 from your repository, then ran `qmake qgit.pro`, but `make` gave me errors. Yes, you need qmake of Qt4 not the Qt3 one.

Re: [ANNOUNCE] qgit-2.1 and qgit-1.5.8

2007-12-31 Thread Boaz Harrosh
On Mon, Dec 31 2007 at 20:07 +0200, Marco Costalba [EMAIL PROTECTED] wrote: On Dec 31, 2007 6:47 PM, Boaz Harrosh [EMAIL PROTECTED] wrote: On Mon, Dec 31 2007 at 13:58 +0200, Marco Costalba [EMAIL PROTECTED] wrote: On Dec 31, 2007 11:59 AM, Filippo Zangheri [EMAIL PROTECTED] wrote: Hi, I

WARNING: do not add new typedefs - is that for real?

2008-01-01 Thread Boaz Harrosh
I have this code: c_code /* * osd-r10 4.12.5 Data-In and Data-Out buffer offsets * byte offset = mantissa * (2^(exponent+8)) */ typedef __be32 osd_cdb_offset; osd_cdb_offset __osd_encode_offset(u64 offset, unsigned *padding, int min_shift, int max_shift); struct

Re: WARNING: do not add new typedefs - is that for real?

2008-01-02 Thread Boaz Harrosh
On Wed, Jan 02 2008 at 12:08 +0200, Christoph Hellwig [EMAIL PROTECTED] wrote: On Tue, Jan 01, 2008 at 06:15:46PM +0200, Boaz Harrosh wrote: I have this code: c_code /* * osd-r10 4.12.5 Data-In and Data-Out buffer offsets * byte offset = mantissa * (2^(exponent+8)) */ typedef __be32

Re: [patch 2/3] CONFIG_HIGHPTE vs. sub-page page tables.

2008-01-03 Thread Boaz Harrosh
On Thu, Jan 03 2008 at 15:12 +0200, Andi Kleen [EMAIL PROTECTED] wrote: Can we please just nuke CONFIG_HIGHPTE? There's only been a small amount of 32bit machines It's unfortunately a larger amount :/ And for unknown reasons a lot of people still install 32bit kernels on new perfectly

Re: [2.6 patch] scsi/seagate.c: remove dead code

2007-10-29 Thread Boaz Harrosh
On Sun, Oct 28 2007 at 17:51 +0200, Adrian Bunk [EMAIL PROTECTED] wrote: This patch removes obviously dead code. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/scsi/seagate.c |2 -- 1 file changed, 2 deletions(-) Actually I have sent a patch to completely remove this

Re: [PATCH] SCSI/gdth: kill unneeded 'irq' argument

2007-10-29 Thread Boaz Harrosh
On Fri, Oct 26 2007 at 11:40 +0200, Jeff Garzik [EMAIL PROTECTED] wrote: Neither gdth_get_status() nor __gdth_interrupt() need their 'irq' argument, so remove it. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] --- drivers/scsi/gdth.c | 21 + 1 files changed, 9

Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops

2007-10-30 Thread Boaz Harrosh
On Mon, Oct 29 2007 at 22:16 +0200, Jens Axboe [EMAIL PROTECTED] wrote: On Fri, Oct 26 2007, Herbert Xu wrote: [CRYPTO] tcrypt: Move sg_init_table out of timing loops This patch moves the sg_init_table out of the timing loops for hash algorithms so that it doesn't impact on the speed test

Re: [PATCH] killing sg_last(), and discussion

2007-10-31 Thread Boaz Harrosh
On Wed, Oct 31 2007 at 10:49 +0200, Jeff Garzik [EMAIL PROTECTED] wrote: I looked into killing sg_last(), but really, this is the best its gonna get (moving sg_last to libata-core.c). You could maybe kill one use with caching, but in the other sg_last() callsites there isn't another s/g loop

Re: [PATCH] killing sg_last(), and discussion

2007-10-31 Thread Boaz Harrosh
On Wed, Oct 31 2007 at 12:29 +0200, Jeff Garzik [EMAIL PROTECTED] wrote: Boaz Harrosh wrote: On Wed, Oct 31 2007 at 10:49 +0200, Jeff Garzik [EMAIL PROTECTED] wrote: I looked into killing sg_last(), but really, this is the best its gonna get (moving sg_last to libata-core.c). You could maybe

[PATCH] Use relative symbolic links for bzImge in x86 ARCHs

2007-10-18 Thread Boaz Harrosh
OK One more problem with a patch this time --- From: Benny Halevy [EMAIL PROTECTED] use relative paths in the symlink to bzImage to make it NFS export safe. Signed-off-by: Benny Halevy [EMAIL PROTECTED] diff --git a/arch/i386/Makefile b/arch/i386/Makefile index f036d2d..396146e 100644 ---

Re: [PATCH] Use relative symbolic links for bzImge in x86 ARCHs

2007-10-18 Thread Boaz Harrosh
://git.kernel.org/?p=linux/kernel/git/tglx/linux-2.6-x86.git;a=commit;h=a0075a509bd955ff6fc6e071efabb926e14bf19c This is in the mm branch awaiting some more testing before Thomas push it to Linus. Sam NP, as long as it's fixed I'm happy Tested-by: Boaz Harrosh [EMAIL PROTECTED] Thanks

Re: Query about Bio submission / Direct IO

2007-10-22 Thread Boaz Harrosh
On Fri, Oct 19 2007 at 8:17 +0200, Shreyansh Jain [EMAIL PROTECTED] wrote: Hi List, I have tried this on kernelnewbies http://article.gmane.org/gmane.linux.kernel.kernelnewbies/23166 but it seems I am not good at explaining well. trying here again. Question: Is there a limitation

Re: [PATCH 09/10] Change table chaining layout

2007-10-23 Thread Boaz Harrosh
for the complete kernel, (I know I helped a bit) and it is a fraction of the size of all the patches that where submitted after that. And it does not have all the problems that we still have now with slob allocators, stack, and such. OK Just my $0.2 Boaz Harrosh - diff --git a/include/linux

Re: [PATCH 09/10] Change table chaining layout

2007-10-23 Thread Boaz Harrosh
On Tue, Oct 23 2007 at 11:41 +0200, Jens Axboe [EMAIL PROTECTED] wrote: On Tue, Oct 23 2007, Boaz Harrosh wrote: On Mon, Oct 22 2007 at 23:47 +0200, Linus Torvalds [EMAIL PROTECTED] wrote: On Mon, 22 Oct 2007, Alan Cox wrote: For structures, not array elements or stack objects. Does gcc now

Re: [PATCH 09/10] Change table chaining layout

2007-10-23 Thread Boaz Harrosh
On Tue, Oct 23 2007 at 11:55 +0200, Jens Axboe [EMAIL PROTECTED] wrote: On Tue, Oct 23 2007, Boaz Harrosh wrote: On Tue, Oct 23 2007 at 11:41 +0200, Jens Axboe [EMAIL PROTECTED] wrote: On Tue, Oct 23 2007, Boaz Harrosh wrote: On Mon, Oct 22 2007 at 23:47 +0200, Linus Torvalds [EMAIL PROTECTED

Re: [PATCH 09/10] Change table chaining layout

2007-10-23 Thread Boaz Harrosh
On Mon, Oct 22 2007 at 20:11 +0200, Jens Axboe [EMAIL PROTECTED] wrote: Change the page member of the scatterlist structure to be an unsigned long, and encode more stuff in the lower bits: - Bits 0 and 1 zero: this is a normal sg entry. Next sg entry is located at sg + 1. - Bit 0 set:

Re: HIGHMEM64G Kernel (2.6.23.1) makes system crawl

2007-10-24 Thread Boaz Harrosh
On Wed, Oct 24 2007 at 12:26 +0200, Rajkumar S [EMAIL PROTECTED] wrote: Hello, I am using a Core 2 Duo E6750 CPU on an intel DG33FB mother board with 4GB Ram, running Debian Lenny. Since the box has 4 GB ram I compiled a big mem kernel, but the machine is very slow while running big mem

Re: HIGHMEM64G Kernel (2.6.23.1) makes system crawl

2007-10-24 Thread Boaz Harrosh
On Wed, Oct 24 2007 at 18:35 +0200, [EMAIL PROTECTED] (Lennart Sorensen) wrote: On Wed, Oct 24, 2007 at 04:41:16PM +0200, Boaz Harrosh wrote: I thought that for 4GB of memory the CONFIG_HIGHMEM4G=y CONFIG_HIGHMEM64G is not set would be enough. From looking in source code

Re: scsi/arm/fas216.c compile error

2008-02-10 Thread Boaz Harrosh
On Sat, Feb 09 2008 at 2:04 +0200, Adrian Bunk [EMAIL PROTECTED] wrote: Commit 30b0c37b27485a9cb897bfe3824f6f517b8c80d6 causes the following compile error: -- snip -- ... CC drivers/scsi/arm/fas216.o /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/scsi/arm/fas216.c: In

Re: scsi/arm/fas216.c compile error

2008-02-10 Thread Boaz Harrosh
On Sun, Feb 10 2008 at 15:58 +0200, Russell King [EMAIL PROTECTED] wrote: On Sun, Feb 10, 2008 at 03:07:09PM +0200, Boaz Harrosh wrote: It's in mainline 84ac86ca8c6787f9efff28bc04b1b65fe0a5c310 [SCSI] arm: convert to accessors and !use_sg cleanup Thanks for checking. This patch was in scsi

Re: scsi/arm/fas216.c compile error

2008-02-11 Thread Boaz Harrosh
On Mon, Feb 11 2008 at 12:02 +0200, Russell King [EMAIL PROTECTED] wrote: On Mon, Feb 11, 2008 at 11:47:57AM +0200, Boaz Harrosh wrote: On Mon, Feb 11 2008 at 0:44 +0200, James Bottomley [EMAIL PROTECTED] wrote: Andrew this patch was in -mm for two month or so. I was under the impression

Re: scsi/arm/fas216.c compile error

2008-02-11 Thread Boaz Harrosh
, Boaz Harrosh wrote: It's in mainline 84ac86ca8c6787f9efff28bc04b1b65fe0a5c310 [SCSI] arm: convert to accessors and !use_sg cleanup Thanks for checking. This patch was in scsi-pending tree since forever, And we were unable to get a responsive maintainer to ACK on them. until the breakage

[BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-12 Thread Boaz Harrosh
gdth _exit would first remove all cards then stop the timer and would not sync with the timer function. This caused a crash in gdth_timer() when module was unloaded. del_timer_sync the timer before we delete the cards. NOT YET TESTED Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- drivers

[BUGFIX 1/2] gdth: scan for scsi devices

2008-02-12 Thread Boaz Harrosh
The patch: gdth: switch to modern scsi host registration missed one simple fact when moving a way from scsi_module.c. That is to call scsi_scan_host() on the probed host. With this the gdth driver from 2.6.24 is again able to see drives and boot. Signed-off-by: Boaz Harrosh [EMAIL PROTECTED

[BUGFIXES 0/2] gdth: fix 2.6.24 driver breakage

2008-02-12 Thread Boaz Harrosh
On Thu, Jan 31 2008 at 12:08 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: On Wed, Jan 30 2008 at 21:47 +0200, Sven Köhler [EMAIL PROTECTED] wrote: Hi, so i have upgraded a system to kernel 2.6.24. After that, it failed to boot with the usual message telling, that the rootfs on device /dev

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-12 Thread Boaz Harrosh
On Tue, Feb 12 2008 at 18:22 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-12 at 11:31 -0300, Sergio Luis wrote: Fix compilation warning in drivers/scsi/gdth.c, using deprecated pci_find_device. Change it into using pci_get_device instead: drivers/scsi/gdth.c:645: warning:

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-13 Thread Boaz Harrosh
On Wed, Feb 13 2008 at 2:17 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-12 at 20:48 -0300, Sergio Luis wrote: reposting an updated version of it. Please check if it's ok. Looks fine, thanks! You added an extra space at the end of while ((pdev = pci_get_device(vendor,

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-13 Thread Boaz Harrosh
On Wed, Feb 13 2008 at 9:06 +0200, Stefan Priebe - allied internet ag [EMAIL PROTECTED] wrote: Hello! I've tested this patch now - and it works fine. Now rmmod, halt and reboot also works. Stefan Priebe This is grate news Stefan. Thank you very much for all your time and effort, with

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-13 Thread Boaz Harrosh
On Tue, Feb 12 2008 at 19:40 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: gdth _exit would first remove all cards then stop the timer and would not sync with the timer function. This caused a crash in gdth_timer() when module was unloaded. del_timer_sync the timer before we delete the cards

Re: [PATCH] gdth: convert to PCI hotplug API

2008-02-13 Thread Boaz Harrosh
: [PATCH] gdth: convert to PCI hotplug API Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- drivers/scsi/gdth.c | 143 ++ 1 files changed, 86 insertions(+), 57 deletions(-) diff --git a/drivers/scsi

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-13 Thread Boaz Harrosh
On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote: -gdth_flush(ha); - This piece doesn't look right. gdth_flush() forces the internal cache to disk backing. If you remove it, you're taking the chance

[PATCH ver2] gdth: bugfix for the at-exit problems

2008-02-13 Thread Boaz Harrosh
. And would crash. So remove gdth_halt and the reboot notifier registration. Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- drivers/scsi/gdth.c | 64 +++--- 1 files changed, 9 insertions(+), 55 deletions(-) diff --git a/drivers/scsi/gdth.c b/drivers

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-13 Thread Boaz Harrosh
On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote: - gdth_flush(ha); - This piece doesn't look right. gdth_flush() forces the internal

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-13 Thread Boaz Harrosh
On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote: On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Tue

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-13 Thread Boaz Harrosh
On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote: On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote: On Wed, Feb 13 2008 at 17:54

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-13 Thread Boaz Harrosh
On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote: On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote: On Wed, Feb 13 2008 at 17:54

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-14 Thread Boaz Harrosh
On Wed, Feb 13 2008 at 19:36 +0200, James Bottomley [EMAIL PROTECTED] wrote: snip --- From: Boaz Harrosh [EMAIL PROTECTED] Subject: [PATCH] gdth: bugfix for the at-exit problems gdth_exit would first remove all cards then stop the timer and would not sync with the timer function. This caused

[PATCH] gdth: bugfix for the at-exit problems

2008-02-14 Thread Boaz Harrosh
notifier function would crash. So unify the exit and halt functions with a gdth_shutdown() that's called by both. Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- drivers/scsi/gdth.c | 90 -- 1 files changed, 36 insertions(+), 54 deletions(-) diff --git

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-14 Thread Boaz Harrosh
On Wed, Feb 13 2008 at 21:38 +0200, Jan Engelhardt [EMAIL PROTECTED] wrote: On Feb 13 2008 11:03, Boaz Harrosh wrote: I've tested this patch now - and it works fine. Now rmmod, halt and reboot also works. Stefan Priebe This is grate news Stefan. Thank you very much for all your time

Re: [PATCH] gdth: bugfix for the at-exit problems

2008-02-14 Thread Boaz Harrosh
On Thu, Feb 14 2008 at 18:10 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Thu, 2008-02-14 at 13:58 +0200, Boaz Harrosh wrote: This is a bugfix for the 2.6.24.x stable releases. gdth_exit would first remove all cards then stop the timer and would not sync with the timer function

Re: [PATCH 1/3] bdi: Track users that require stable page writes

2012-11-01 Thread Boaz Harrosh
On 11/01/2012 12:58 AM, Darrick J. Wong wrote: This creates a per-backing-device counter that tracks the number of users which require pages to be held immutable during writeout. Eventually it will be used to waive wait_for_page_writeback() if nobody requires stable pages. There is two

Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Boaz Harrosh
On 11/01/2012 12:58 AM, Darrick J. Wong wrote: Fix up the filesystems that provide their own -page_mkwrite handlers to provide stable page writes if necessary. Signed-off-by: Darrick J. Wong darrick.w...@oracle.com --- fs/9p/vfs_file.c |1 + fs/afs/write.c |4 ++--

Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Boaz Harrosh
On 11/01/2012 01:22 PM, Jeff Layton wrote: Hmm...I don't know... I've never been crazy about using the page lock for this, but in the absence of a better way to guarantee stable pages, it was what I ended up with at the time. cifs_writepages will hold the page lock until kernel_sendmsg

Re: [PATCH 1/3] bdi: Track users that require stable page writes

2012-11-01 Thread Boaz Harrosh
On 11/01/2012 11:57 AM, Darrick J. Wong wrote: On Thu, Nov 01, 2012 at 11:21:22AM -0700, Boaz Harrosh wrote: On 11/01/2012 12:58 AM, Darrick J. Wong wrote: This creates a per-backing-device counter that tracks the number of users which require pages to be held immutable during writeout

Re: [PATCH 02/16] f2fs: add on-disk layout

2012-10-05 Thread Boaz Harrosh
On 10/05/2012 10:54 AM, Dan Luedtke wrote: On Fri, 2012-10-05 at 20:56 +0900, 김재극 wrote: +__le32 i_atime; /* Access time */ +__le32 i_ctime; /* inode Change time */ +__le32 i_mtime; /* Modification time */ +__le32 i_btime;

Re: [PATCH 1/8] exofs: drop lock/unlock super

2012-10-08 Thread Boaz Harrosh
this patch, and it is completely independent and can go through my tree. Please tell me what do you want to do with this patch, should I push it? Or are you pushing it through Al Thanks Boaz Acked-by: Artem Bityutskiy artem.bityuts...@linux.intel.com Acked-by: Boaz Harrosh bharr...@panasas.com

Re: [PATCH] VFS: add config options to enable link restrictions

2012-10-26 Thread Boaz Harrosh
On 10/26/2012 01:23 PM, Kees Cook wrote: Every distro will ship with this enabled (except perhaps Damn Vulnerable Linux), so why make it harder? So please remind me why can't it be on by default in code. And the normal sysctl to turn it off for these who want to experiment with filesystem

Re: [PATCH] SUNRPC: Prevent kernel stack corruption on long values of flush

2012-10-17 Thread Boaz Harrosh
On 07/18/2012 01:55 PM, Jim Rees wrote: Dave Jones wrote: Unsigned long isn't necessarily 32 bits. On 64-bit systems %lu can be up to 18446744073709551615 Thanks. You caught me thinking Intel. How embarrassing. What? why even on Intel-64 long is 64bit. long is always the same or

Re: howto boost write(2) performance?

2007-10-09 Thread Boaz Harrosh
On Tue, Oct 09 2007 at 16:56 +0200, Andi Kleen [EMAIL PROTECTED] wrote: Michael Stiller [EMAIL PROTECTED] writes: The write(2) performance is not good enough, the writer threads take to much time, and i ask you for ideas, howto to boost the write performance. You could use an O_DIRECT

Re: [PATCH 3/7] blk_end_request: changing normal drivers

2007-09-05 Thread Boaz Harrosh
On Sat, Sep 01 2007 at 1:42 +0300, Kiyoshi Ueda [EMAIL PROTECTED] wrote: This patch converts normal drivers, which complete request in a standard way shown below, to use blk_end_request(). a) end_that_request_{chunk/first} spin_lock_irqsave() (add_disk_randomness(),

Re: [patch] scsi: fix crash in gdth_timeout()

2007-10-15 Thread Boaz Harrosh
On Mon, Oct 15 2007 at 19:57 +0200, Jeff Garzik [EMAIL PROTECTED] wrote: Linus Torvalds wrote: On Mon, 15 Oct 2007, Ingo Molnar wrote: A further problem is probably that the GDTH timer is not stopped by a failed GDTH probe? Indeed. Maybe this is a better fix? That driver is pretty messy,

Re: [GIT PATCH] SCSI updates for 2.6.24

2007-10-16 Thread Boaz Harrosh
bugs in gdth and fc4 for which I'm hoping to sweep fixes into the next update. Boaz Harrosh (12): NCR5380: Use scsi_eh API for REQUEST_SENSE invocation This change broke compilation of the mac_scsi.c driver: | linux/drivers/scsi/NCR5380.c: In function 'NCR5380_information_transfer

Re: 2.6.23-git8 missing include file - [Resending the patch]

2007-10-16 Thread Boaz Harrosh
On Tue, Oct 16 2007 at 8:27 +0200, Kamalesh Babulal [EMAIL PROTECTED] wrote: Kamalesh Babulal wrote: Hi, The build fails with following error CC drivers/usb/storage/scsiglue.o CC drivers/usb/storage/protocol.o CC drivers/usb/storage/transport.o In file included from

slight annoyance with new x86 arch

2007-10-17 Thread Boaz Harrosh
Make system is a bit broken in the sense that it recompiles and links right after a build even if nothing changed. I have # CONFIG_LOCALVERSION_AUTO is not set make output after a fully built tree: { // these are expected off course GEN

Re: linux-next: failed to fetch the osd tree

2013-04-12 Thread Boaz Harrosh
That old server has finally crapped out on me. It is being replaced by a new machine. It will take few days to set up and run. So expect failure for the next few days Thanks Boaz On 11/04/13 02:43, Stephen Rothwell wrote: HI Boaz, On Tue, 26 Mar 2013 10:17:17 +1100 Stephen Rothwell

Re: [PATCH 6/6] ubifs: Wait for page writeback to provide stable pages

2013-02-21 Thread Boaz Harrosh
On 02/21/2013 05:48 AM, Darrick J. Wong wrote: On Wed, Jan 23, 2013 at 01:43:12PM -0800, Andrew Morton wrote: On Fri, 18 Jan 2013 17:13:16 -0800 Darrick J. Wong darrick.w...@oracle.com wrote: When stable pages are required, we have to wait if the page is just going to disk and we want to

[RFC 3/6] bidi support: bidirectional request

2007-01-21 Thread Boaz Harrosh
-by: Boaz Harrosh [EMAIL PROTECTED] --- block/elevator.c |7 +--- block/ll_rw_blk.c | 113 ++-- include/linux/blkdev.h | 49 - 3 files changed, 149 insertions(+), 20 deletions(-) diff --git a/block/elevator.c b

[RFC 4/6] bidi support: bidirectional SCSI layer

2007-01-21 Thread Boaz Harrosh
- Add bidi members to struct scsi_cmnd. - Add API at the SCSI level for bidirectional commands. - Implement support for BIDI requests in scsi_setup_blk_pc_cmnd() and scsi_io_completion(). Signed-off-by: Benny Halevy [EMAIL PROTECTED] Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- drivers

[RFC 5/6] bidi support: varlen + OSD support

2007-01-21 Thread Boaz Harrosh
- Add support for varlen CDBs or large vendor specific commands in struct request. - Add support for above at SCSI level API's and devices. - Add the OSD device type. Signed-off-by: Benny Halevy [EMAIL PROTECTED] Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- block/ll_rw_blk.c

[RFC 6/6] bidi support: iSCSI bidi varlen CDBs

2007-01-21 Thread Boaz Harrosh
and will be removed in actual patches] Signed-off-by: Benny Halevy [EMAIL PROTECTED] Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- drivers/infiniband/ulp/iser/iscsi_iser.c |4 +- drivers/scsi/iscsi_tcp.c | 190 +++--- drivers/scsi/iscsi_tcp.h

[RFC 0/6] bidi support: block, SCSI, and iSCSI layers

2007-01-21 Thread Boaz Harrosh
Following are 6 (large) patches that introduce support for bidirectional requests in the kernel. Since all this is going to interfere with everyone's work, let us all comment on the implementation, naming, and future directions. (or forever hold your peace). The submitted work is against

[RFC 2/6] bidi support: request_io_part

2007-01-23 Thread Boaz Harrosh
. - Change all users to new API. At this stage it is all still uni-directional but the intention is clear. Signed-off-by: Benny Halevy [EMAIL PROTECTED] Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- arch/um/drivers/ubd_kern.c | 12 +- block/as-iosched.c | 16 ++-- block

[RFC 2/6] bidi support: request_io_part

2007-01-23 Thread Boaz Harrosh
. - Change all users to new API. At this stage it is all still uni-directional but the intention is clear. Signed-off-by: Benny Halevy [EMAIL PROTECTED] Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- arch/um/drivers/ubd_kern.c | 12 +- block/as-iosched.c | 16 ++-- block

Re: [ 16/46] NFSv4.1: Remove a bogus BUG_ON() in nfs4_layoutreturn_done

2012-09-19 Thread Boaz Harrosh
On 09/17/2012 04:05 PM, Myklebust, Trond wrote: -Original Message- From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] Sent: Sunday, September 16, 2012 12:37 PM To: Ben Hutchings Cc: Myklebust, Trond; linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Boaz Harrosh

Re: [PATCH 12/25] userns: Convert exofs to use kuid/kgid where appropriate

2012-09-20 Thread Boaz Harrosh
On 09/20/2012 02:41 PM, Eric W. Biederman wrote: From: Eric W. Biederman ebied...@xmission.com Cc: Boaz Harrosh bharr...@panasas.com Cc: Benny Halevy bhal...@tonian.com Acked-by: Serge Hallyn serge.hal...@canonical.com Acked-by: Boaz Harrosh bharr...@panasas.com Signed-off-by: Eric W

Re: virtio(-scsi) vs. chained sg_lists (was Re: [PATCH] scsi: virtio-scsi: Fix address translation failure of HighMem pages used by sg list)

2012-07-25 Thread Boaz Harrosh
On 07/25/2012 08:43 PM, Paolo Bonzini wrote: Il 25/07/2012 17:28, Boaz Harrosh ha scritto: 1) what I get is a scsi_cmnd which contains an N-element scatterlist. 2) virtio-scsi has to build the packet that is passed to the hardware (it does not matter that the hardware is virtual

Re: virtio(-scsi) vs. chained sg_lists (was Re: [PATCH] scsi: virtio-scsi: Fix address translation failure of HighMem pages used by sg list)

2012-07-25 Thread Boaz Harrosh
On 07/25/2012 11:06 PM, Paolo Bonzini wrote: Il 25/07/2012 21:16, Boaz Harrosh ha scritto: The picture confused me. It looked like the first element is the virtio_scsi_cmd_req not an sgilist-element that points to the struct's buffer. In that case then yes your plan of making a two

Re: virtio(-scsi) vs. chained sg_lists (was Re: [PATCH] scsi: virtio-scsi: Fix address translation failure of HighMem pages used by sg list)

2012-07-26 Thread Boaz Harrosh
On 07/26/2012 10:23 AM, Paolo Bonzini wrote: In the meanwhile, we still have a bug to fix, and we need to choose between Sen Wang's v1 (sg_set_page) or v2 (value assignment). I'm still leaning more towards v2, if only because I already tested that one myself. It's your call, you know

  1   2   3   4   5   6   7   8   9   10   >