Re: Re: collect2: error: ld returned 1 exit status

2015-11-24 Thread Breno Leitao
Hi Fengguang, On 11/23/2015 10:45 AM, Fengguang Wu wrote: > I'm using Debian's cross gcc 5.2.1: > > gcc-powerpc64le-linux-gnu5.2.1-14+really5.2.1-13 > > It may take some time for debian to catchup up with the newer version. I already opened a Debian bug to track the backport

Re: [PATCH v9 44/51] selftest/vm: powerpc implementation for generic abstraction

2017-11-10 Thread Breno Leitao
Hi Ram, On Thu, Nov 09, 2017 at 03:37:46PM -0800, Ram Pai wrote: > On Thu, Nov 09, 2017 at 04:47:15PM -0200, Breno Leitao wrote: > > On Mon, Nov 06, 2017 at 12:57:36AM -0800, Ram Pai wrote: > > > @@ -206,12 +209,14 @@ void signal_handler(int signum, siginfo_t *si, void

[PATCH] scripts: Add ppc64le support for checkstack.pl

2017-11-28 Thread Breno Leitao
t function, and this is the value checkstack.pl will find the stack size for each function. This patch also simplifies the entire Powerpc section, since just two type of instructions are used, 'stdu' for 64 bits and 'stwu' for 32 bits platform. Signed-off-by: Breno Leitao <lei...@debian.org> --- scripts/ch

Re: [PATCH v9 44/51] selftest/vm: powerpc implementation for generic abstraction

2017-11-09 Thread Breno Leitao
Hi Ram, On Mon, Nov 06, 2017 at 12:57:36AM -0800, Ram Pai wrote: > @@ -206,12 +209,14 @@ void signal_handler(int signum, siginfo_t *si, void > *vucontext) > > trapno = uctxt->uc_mcontext.gregs[REG_TRAPNO]; > ip = uctxt->uc_mcontext.gregs[REG_IP_IDX]; > - fpregset =

[PATCH] scripts: Add ppc64le support for checkstack.pl

2017-11-28 Thread Breno Leitao
t function, and this is the value checkstack.pl will find the stack size for each function. This patch also simplifies the entire Powerpc section, since just two type of instructions are used, 'stdu' for 64 bits and 'stwu' for 32 bits platform. Signed-off-by: Breno Leitao --- scripts/checkstack.pl | 11 -

Re: [PATCH v9 44/51] selftest/vm: powerpc implementation for generic abstraction

2017-11-09 Thread Breno Leitao
Hi Ram, On Mon, Nov 06, 2017 at 12:57:36AM -0800, Ram Pai wrote: > @@ -206,12 +209,14 @@ void signal_handler(int signum, siginfo_t *si, void > *vucontext) > > trapno = uctxt->uc_mcontext.gregs[REG_TRAPNO]; > ip = uctxt->uc_mcontext.gregs[REG_IP_IDX]; > - fpregset =

Re: [PATCH v9 44/51] selftest/vm: powerpc implementation for generic abstraction

2017-11-10 Thread Breno Leitao
Hi Ram, On Thu, Nov 09, 2017 at 03:37:46PM -0800, Ram Pai wrote: > On Thu, Nov 09, 2017 at 04:47:15PM -0200, Breno Leitao wrote: > > On Mon, Nov 06, 2017 at 12:57:36AM -0800, Ram Pai wrote: > > > @@ -206,12 +209,14 @@ void signal_handler(int signum, siginfo_t *si, void

Re: Re: collect2: error: ld returned 1 exit status

2015-11-24 Thread Breno Leitao
Hi Fengguang, On 11/23/2015 10:45 AM, Fengguang Wu wrote: > I'm using Debian's cross gcc 5.2.1: > > gcc-powerpc64le-linux-gnu5.2.1-14+really5.2.1-13 > > It may take some time for debian to catchup up with the newer version. I already opened a Debian bug to track the backport

[PATCH v5 06/12] x86/bugs: Rename SLS to CONFIG_MITIGATION_SLS

2023-10-19 Thread Breno Leitao
. Rename the Kconfig entry from SLS to MITIGATION_SLS. Suggested-by: Josh Poimboeuf Signed-off-by: Breno Leitao --- arch/x86/Kconfig | 2 +- arch/x86/Makefile | 2 +- arch/x86/include/asm/linkage.h | 4 ++-- arch/x86/kernel/alternative.c | 4 ++-- arch/x86/kernel/ftrace.c

Re: [PATCH net-next v3] net: dqs: add NIC stall detector based on BQL

2024-02-14 Thread Breno Leitao
On Wed, Feb 14, 2024 at 04:41:36PM +0100, Eric Dumazet wrote: > On Wed, Feb 14, 2024 at 3:45 PM Breno Leitao wrote: > > > > On Tue, Feb 13, 2024 at 10:04:57AM -0800, Jakub Kicinski wrote: > > > On Tue, 13 Feb 2024 14:57:49 +0100 Eric Dumazet wrote: > > > >

Re: [PATCH net-next v3] net: dqs: add NIC stall detector based on BQL

2024-02-14 Thread Breno Leitao
On Tue, Feb 13, 2024 at 10:04:57AM -0800, Jakub Kicinski wrote: > On Tue, 13 Feb 2024 14:57:49 +0100 Eric Dumazet wrote: > > Please note that adding other sysfs entries is expensive for workloads > > creating/deleting netdev and netns often. > > > > I _think_ we should find a way for not creating

Re: [PATCH net-next v3] net: dqs: add NIC stall detector based on BQL

2024-02-14 Thread Breno Leitao
On Wed, Feb 14, 2024 at 05:58:37PM +0100, Eric Dumazet wrote: > On Wed, Feb 14, 2024 at 5:49 PM Breno Leitao wrote: > > > > On Wed, Feb 14, 2024 at 04:41:36PM +0100, Eric Dumazet wrote: > > > On Wed, Feb 14, 2024 at 3:45 PM Breno Leitao wrote: > > > > > &

Re: [PATCH net-next v3] net: dqs: add NIC stall detector based on BQL

2024-02-13 Thread Breno Leitao
On Tue, Feb 06, 2024 at 12:40:13PM +0100, Paolo Abeni wrote: > On Fri, 2024-02-02 at 08:53 -0800, Breno Leitao wrote: > > From: Jakub Kicinski > > > > softnet_data->time_squeeze is sometimes used as a proxy for > > host overload or indication of sc

[PATCH net-next v3] net: dqs: add NIC stall detector based on BQL

2024-02-02 Thread Breno Leitao
ike their stall metrics to be 0 may prefer higher value. Signed-off-by: Jakub Kicinski Signed-off-by: Breno Leitao --- Changelog: v1: * https://lore.kernel.org/netdev/202306172057.jx7yhliu-...@intel.com/T/ v2: * Fix the documentation file in patch 0001, since patch 0002 will touch it la

[PATCH net v2 2/2] net: dqs: add NIC stall detector based on BQL

2024-01-31 Thread Breno Leitao
ike their stall metrics to be 0 may prefer higher value. Signed-off-by: Jakub Kicinski Signed-off-by: Breno Leitao --- .../ABI/testing/sysfs-class-net-queues| 23 +++ include/linux/dynamic_queue_limits.h | 35 +++ include/trace/events/napi.h |

[PATCH v6 06/13] x86/bugs: Rename SLS to CONFIG_MITIGATION_SLS

2023-11-21 Thread Breno Leitao
. Rename the Kconfig entry from SLS to MITIGATION_SLS. Suggested-by: Josh Poimboeuf Signed-off-by: Breno Leitao --- arch/x86/Kconfig | 2 +- arch/x86/Makefile | 2 +- arch/x86/include/asm/linkage.h | 4 ++-- arch/x86/kernel/alternative.c | 4 ++-- arch/x86/kernel/ftrace.c

[PATCH net-next v4] net: dqs: add NIC stall detector based on BQL

2024-03-04 Thread Breno Leitao
ike their stall metrics to be 0 may prefer higher value. Signed-off-by: Jakub Kicinski Signed-off-by: Breno Leitao --- v1: * https://lore.kernel.org/netdev/202306172057.jx7yhliu-...@intel.com/T/ v2: * Fix the documentation file in patch 0001, since patch 0002 will touch it later. *

[PATCH net-next 1/2] net/vsockmon: Leverage core stats allocator

2024-02-23 Thread Breno Leitao
e free happens in the right spot, etc). This is core responsibility now. Remove the allocation in the vsockmon driver and leverage the network core allocation instead. Signed-off-by: Breno Leitao --- drivers/net/vsockmon.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(

[PATCH net-next 2/2] net/vsockmon: Do not set zeroed statistics

2024-02-23 Thread Breno Leitao
Do not set rtnl_link_stats64 fields to zero, since they are zeroed before ops->ndo_get_stats64 is called in core dev_get_stats() function. Signed-off-by: Breno Leitao --- drivers/net/vsockmon.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/vsockmon.c b/drivers/net/vsockmo

[PATCH] virtio_net: Do not send RSS key if it is not supported

2024-03-21 Thread Breno Leitao
_is_broken() does not look at the qemu `vdev->broken`, so, it never realizes that the vitio is broken at QEMU side. Fix it by not sending the key scatter-gatter key if it is not set. Fixes: c7114b1249fa ("drivers/net/virtio_net: Added basic RSS support.") Signed-off-by: Breno Lei

Re: [PATCH] virtio_net: Do not send RSS key if it is not supported

2024-03-22 Thread Breno Leitao
Hello Xuan, On Fri, Mar 22, 2024 at 10:00:22AM +0800, Xuan Zhuo wrote: > On Thu, 21 Mar 2024 09:54:30 -0700, Breno Leitao wrote: > > 4) Since the command above does not have a key, then the last > >scatter-gatter entry will be zeroed, since rss_key_size == 0. > >

Re: [PATCH] virtio_net: Do not send RSS key if it is not supported

2024-03-25 Thread Breno Leitao
Hello Xuan, On Mon, Mar 25, 2024 at 01:57:53PM +0800, Xuan Zhuo wrote: > On Fri, 22 Mar 2024 03:21:21 -0700, Breno Leitao wrote: > > Hello Xuan, > > > > On Fri, Mar 22, 2024 at 10:00:22AM +0800, Xuan Zhuo wrote: > > > On Thu, 21 Mar 2024 09:54:30 -0700, Breno Leita

[PATCH net v3] virtio_net: Do not send RSS key if it is not supported

2024-03-29 Thread Breno Leitao
gt;broken`, so, it never realizes that the vitio is broken at QEMU side. Fix it by not sending RSS commands if the feature is not available in the device. Fixes: c7114b1249fa ("drivers/net/virtio_net: Added basic RSS support.") Cc: sta...@vger.kernel.org Cc: qemu-de...@nongnu.org Signed-off-by:

Re: [PATCH net v3] virtio_net: Do not send RSS key if it is not supported

2024-04-03 Thread Breno Leitao
On Sun, Mar 31, 2024 at 04:20:30PM -0400, Michael S. Tsirkin wrote: > On Fri, Mar 29, 2024 at 10:16:41AM -0700, Breno Leitao wrote: > > @@ -3814,13 +3815,24 @@ static int virtnet_set_rxfh(struct net_device *dev, > > return -EOPNOTSUPP; > > &g

[PATCH net v4] virtio_net: Do not send RSS key if it is not supported

2024-04-03 Thread Breno Leitao
gt;broken`, so, it never realizes that the vitio is broken at QEMU side. Fix it by not sending RSS commands if the feature is not available in the device. Fixes: c7114b1249fa ("drivers/net/virtio_net: Added basic RSS support.") Cc: sta...@vger.kernel.org Cc: qemu-de...@nongnu.org Signed

Re: [PATCH net v2 1/2] virtio_net: Do not set rss_indir if RSS is not supported

2024-03-28 Thread Breno Leitao
> > On Wed, Mar 27, 2024 at 09:37:43AM +0800, Xuan Zhuo wrote: > > > On Tue, 26 Mar 2024 08:19:08 -0700, Breno Leitao > > > wrote: > > > > Do not set virtnet_info->rss_indir_table_size if RSS is not available > > > > for the device. >

Re: [PATCH net v2 2/2] virtio_net: Do not send RSS key if it is not supported

2024-03-27 Thread Breno Leitao
On Wed, Mar 27, 2024 at 10:27:58AM +0800, Heng Qi wrote: > > > 在 2024/3/26 下午11:19, Breno Leitao 写道: > > There is a bug when setting the RSS options in virtio_net that can break > > the whole machine, getting the kernel into an infinite loop. > > > > Running

Re: [PATCH net v2 1/2] virtio_net: Do not set rss_indir if RSS is not supported

2024-03-27 Thread Breno Leitao
Hello Xuan, On Wed, Mar 27, 2024 at 09:37:43AM +0800, Xuan Zhuo wrote: > On Tue, 26 Mar 2024 08:19:08 -0700, Breno Leitao wrote: > > Do not set virtnet_info->rss_indir_table_size if RSS is not available > > for the device. > > > > Currently, rss_indir_table

[PATCH net v2 1/2] virtio_net: Do not set rss_indir if RSS is not supported

2024-03-26 Thread Breno Leitao
est has indirection table set, but virtnet does not support RSS. Suggested-by: Heng Qi Signed-off-by: Breno Leitao --- drivers/net/virtio_net.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index c22d1118a

[PATCH net v2 2/2] virtio_net: Do not send RSS key if it is not supported

2024-03-26 Thread Breno Leitao
gt;broken`, so, it never realizes that the vitio is broken at QEMU side. Fix it by not sending RSS commands if the feature is not available in the device. Fixes: c7114b1249fa ("drivers/net/virtio_net: Added basic RSS support.") Cc: sta...@vger.kernel.org Cc: qemu-de...@nongnu.org Signed-off-by: