Re: [PATCH] nvme: fabrics: fix ctrl_loss_tmo < 0 to reconnect forever

Looks good to me. Just 's/supplics/supplies/'. Without looking into the entire code, If we can change the type of max_reconnect and nr_reconnects to unsigned int then we can just get away with the one comparison (ctrl->nr_reconnects < ctrl->opts->max_reconnects). Reviewed-b

Re: [RFC PATCH 00/37] block: introduce bio_init_fields()

On 1/20/21 7:01 PM, Julian Calaby wrote: > Hi Chaitanya, > > On Tue, Jan 19, 2021 at 5:01 PM Chaitanya Kulkarni > wrote: >> Hi, >> >> This is a *compile only RFC* which adds a generic helper to initialize >> the various fields of the bio that is repeated all

Re: [PATCH] block: Fix an error handling in add_partition

On 1/15/21 11:34 PM, Dinghao Liu wrote: > Once we have called device_initialize(), we should > use put_device() to give up the reference on error, > just like what we have done on failure of device_add(). > > Signed-off-by: Dinghao Liu Please consider having following commit message, since above

Re: [RFC PATCH 00/37] block: introduce bio_init_fields()

On 1/18/21 21:06, Chaitanya Kulkarni wrote: > Hi, > > This is a *compile only RFC* which adds a generic helper to initialize > the various fields of the bio that is repeated all the places in > file-systems, block layer, and drivers. > > The new helper allows callers to initi

Re: [RFC PATCH 31/37] eros: use bio_init_fields in data

On 1/19/21 20:06, Gao Xiang wrote: > Hi Chaitanya, > > (drop in-person Cc..) > > On Mon, Jan 18, 2021 at 09:06:25PM -0800, Chaitanya Kulkarni wrote: > > ...it would be nice if you could update the subject line to > "erofs: use bio_init_fields " Sure, if new

Re: [PATCH] [v3] block: Fix an error handling in add_partition

On 1/17/21 1:00 AM, Dinghao Liu wrote: > Once we have called device_initialize(), we should use put_device() to > give up the reference on error, just like what we have done on failure > of device_add(). > > Signed-off-by: Dinghao Liu Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH] scsi: target: iscsi: Fix typo in comment

On 1/14/21 11:10 PM, Valdis Klētnieks wrote: > Correct the spelling of Nagle's name in a comment. > > Signed-off-by: Valdis Kletnieks Looks good. Reviewed-by: Chaitanya Kulkarni

[RFC PATCH 12/37] zonefs: use bio_init_fields in append

Signed-off-by: Chaitanya Kulkarni --- fs/zonefs/super.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c index bec47f2d074b..3117a89550f6 100644 --- a/fs/zonefs/super.c +++ b/fs/zonefs/super.c @@ -682,10 +682,9 @@ static ssize_t

[RFC PATCH 13/37] drdb: use bio_init_fields in actlog

Signed-off-by: Chaitanya Kulkarni --- drivers/block/drbd/drbd_actlog.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/block/drbd/drbd_actlog.c b/drivers/block/drbd/drbd_actlog.c index 7227fc7ab8ed..733679cf456b 100644 --- a/drivers/block/drbd/drbd_actlog.c +++ b

[RFC PATCH 09/37] iomap: use bio_init_fields in buffered-io

Signed-off-by: Chaitanya Kulkarni --- fs/iomap/buffered-io.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index 16a1e82e3aeb..d256799569cf 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -1222,10

[RFC PATCH 08/37] gfs2: use bio_init_fields in ops_fstype

Signed-off-by: Chaitanya Kulkarni --- fs/gfs2/ops_fstype.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index 61fce59cb4d3..32506d5615f4 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -255,12 +255,9

[RFC PATCH 15/37] drdb: use bio_init_fields in receiver

Signed-off-by: Chaitanya Kulkarni --- drivers/block/drbd/drbd_receiver.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 09c86ef3f0fd..2715081a4603 100644 --- a/drivers/block/drbd

[RFC PATCH 33/37] jfs: use bio_init_fields in metadata

Signed-off-by: Chaitanya Kulkarni --- fs/jfs/jfs_metapage.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c index 176580f54af9..5cea9c137a48 100644 --- a/fs/jfs/jfs_metapage.c +++ b/fs/jfs/jfs_metapage.c

[RFC PATCH 35/37] ocfs: use bio_init_fields in heartbeat

Signed-off-by: Chaitanya Kulkarni --- fs/ocfs2/cluster/heartbeat.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c index 0179a73a3fa2..dd37aaac4f32 100644 --- a/fs/ocfs2/cluster/heartbeat.c +++ b/fs/ocfs2/cluster

[RFC PATCH 27/37] nvmet: use bio_init_fields in bdev-ns

Signed-off-by: Chaitanya Kulkarni --- drivers/nvme/target/io-cmd-bdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c index 125dde3f410e..302ec6bc2a55 100644 --- a/drivers/nvme/target/io-cmd-bdev.c

[RFC PATCH 02/37] fs: use bio_init_fields in block_dev

Signed-off-by: Chaitanya Kulkarni --- fs/block_dev.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/fs/block_dev.c b/fs/block_dev.c index 3e5b02f6606c..44b992976ee5 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -239,12 +239,9

[RFC PATCH 04/37] btrfs: use bio_init_fields in volumes

Signed-off-by: Chaitanya Kulkarni --- fs/btrfs/volumes.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index ee086fc56c30..836167212252 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -6371,14 +6371,12 @@ static void

[RFC PATCH 10/37] iomap: use bio_init_fields in direct-io

Signed-off-by: Chaitanya Kulkarni --- fs/iomap/direct-io.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 933f234d5bec..3756dbf51909 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -190,10

[RFC PATCH 11/37] jfs: use bio_init_fields in logmgr

Signed-off-by: Chaitanya Kulkarni --- fs/jfs/jfs_logmgr.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index 9330eff210e0..ee7407ca32c0 100644 --- a/fs/jfs/jfs_logmgr.c +++ b/fs/jfs/jfs_logmgr.c @@ -1980,15

[RFC PATCH 07/37] gfs2: use bio_init_fields in meta_io

Signed-off-by: Chaitanya Kulkarni --- fs/gfs2/meta_io.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c index 2db573e31f78..822489b10aec 100644 --- a/fs/gfs2/meta_io.c +++ b/fs/gfs2/meta_io.c @@ -217,8 +217,8 @@ static void

[RFC PATCH 18/37] bcache: use bio_init_fields in journal

Signed-off-by: Chaitanya Kulkarni --- drivers/md/bcache/journal.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/md/bcache/journal.c b/drivers/md/bcache/journal.c index aefbdb7e003b..0aabcb5cf2ad 100644 --- a/drivers/md/bcache/journal.c +++ b

[RFC PATCH 22/37] dm-crypt: use bio_init_fields

Signed-off-by: Chaitanya Kulkarni --- drivers/md/dm-crypt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index 53791138d78b..b03dbcbff491 100644 --- a/drivers/md/dm-crypt.c +++ b/drivers/md/dm-crypt.c @@ -1764,9 +1764,7

[RFC PATCH 29/37] btrfs: use bio_init_fields in scrub

Signed-off-by: Chaitanya Kulkarni --- fs/btrfs/scrub.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index 5f4f88a4d2c8..1e533966ccf1 100644 --- a/fs/btrfs/scrub.c +++ b/fs/btrfs/scrub.c @@ -1650,10 +1650,8 @@ static int

[RFC PATCH 28/37] target: use bio_init_fields in iblock

Signed-off-by: Chaitanya Kulkarni --- drivers/target/target_core_iblock.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c index 8ed93fd205c7..ec65a9494bee 100644 --- a/drivers/target

[RFC PATCH 32/37] eros: use bio_init_fields in zdata

Signed-off-by: Chaitanya Kulkarni --- fs/erofs/zdata.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c index 6cb356c4217b..f7cdae88982a 100644 --- a/fs/erofs/zdata.c +++ b/fs/erofs/zdata.c @@ -1236,12 +1236,9 @@ static void

[RFC PATCH 20/37] bcache: use bio_init_fields in writeback

Signed-off-by: Chaitanya Kulkarni --- drivers/md/bcache/writeback.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c index a129e4d2707c..e2b769bbdb14 100644 --- a/drivers/md/bcache/writeback.c +++ b

[RFC PATCH 30/37] fs: use bio_init_fields in buffer

Signed-off-by: Chaitanya Kulkarni --- fs/buffer.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index 32647d2011df..32e9f780e134 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -3027,16 +3027,13 @@ static int submit_bh_wbc(int op, int op_flags

[RFC PATCH 17/37] pktcdvd: use bio_init_fields

Signed-off-by: Chaitanya Kulkarni --- drivers/block/pktcdvd.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index b8bb8ec7538d..47eb4e0bd4c3 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c

[RFC PATCH 23/37] dm-zoned: use bio_init_fields metadata

Signed-off-by: Chaitanya Kulkarni --- drivers/md/dm-zoned-metadata.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c index b298fefb022e..f114d595ce23 100644 --- a/drivers/md/dm-zoned-metadata.c

[RFC PATCH 25/37] dm-zoned: use bio_init_fields

Signed-off-by: Chaitanya Kulkarni --- drivers/md/md.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index ca409428b4fc..b331c81f3a12 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -1001,11 +1001,9 @@ void md_super_write(struct

[RFC PATCH 24/37] dm-zoned: use bio_init_fields target

Signed-off-by: Chaitanya Kulkarni --- drivers/md/dm-zoned-target.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c index 697f9de37355..8b232b9e3386 100644 --- a/drivers/md/dm-zoned-target.c +++ b/drivers/md

[RFC PATCH 26/37] dm log writes: use bio_init_fields

Signed-off-by: Chaitanya Kulkarni --- drivers/md/dm-log-writes.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c index e3d35c6c9f71..35c2e0418561 100644 --- a/drivers/md/dm-log-writes.c +++ b

[RFC PATCH 03/37] btrfs: use bio_init_fields in disk-io

Signed-off-by: Chaitanya Kulkarni --- fs/btrfs/disk-io.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 765deefda92b..9a65432fc5e9 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -3637,10 +3637,8 @@ static

[RFC PATCH 06/37] gfs2: use bio_init_fields in lops

Signed-off-by: Chaitanya Kulkarni --- fs/gfs2/lops.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c index 3922b26264f5..9f8a9757b086 100644 --- a/fs/gfs2/lops.c +++ b/fs/gfs2/lops.c @@ -264,10 +264,8 @@ static struct bio

[RFC PATCH 19/37] bcache: use bio_init_fields in super

Signed-off-by: Chaitanya Kulkarni --- drivers/md/bcache/super.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index a4752ac410dc..b4ced138a0c0 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md

[RFC PATCH 14/37] drdb: use bio_init_fields in bitmap

Signed-off-by: Chaitanya Kulkarni --- drivers/block/drbd/drbd_bitmap.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/block/drbd/drbd_bitmap.c b/drivers/block/drbd/drbd_bitmap.c index df53dca5d02c..4fd9746af469 100644 --- a/drivers/block/drbd/drbd_bitmap.c +++ b

[RFC PATCH 16/37] floppy: use bio_init_fields

Signed-off-by: Chaitanya Kulkarni --- drivers/block/floppy.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index dfe1dfc901cc..1237b64bb37b 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -4219,13

[RFC PATCH 05/37] ext4: use bio_init_fields in page_io

Signed-off-by: Chaitanya Kulkarni --- fs/ext4/page-io.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index 03a44a0de86a..53a79a7aac15 100644 --- a/fs/ext4/page-io.c +++ b/fs/ext4/page-io.c @@ -400,10 +400,8 @@ static void

[RFC PATCH 01/37] block: introduce bio_init_fields() helper

code. Subsequent patches use this function to reduce repeated code. Signed-off-by: Chaitanya Kulkarni --- block/blk-lib.c | 13 + include/linux/bio.h | 13 + 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/block/blk-lib.c b/block/blk-lib.c index

[RFC PATCH 21/37] dm-bufio: use bio_init_fields

Signed-off-by: Chaitanya Kulkarni --- drivers/md/dm-bufio.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c index 9c1a86bde658..1295e7e33e06 100644 --- a/drivers/md/dm-bufio.c +++ b/drivers/md/dm-bufio.c @@ -633,11 +633,8

[RFC PATCH 00/37] block: introduce bio_init_fields()

shows code level benefits of this helper :- ??38 files changed, 124 insertions(+), 236 deletions(-) -ck Chaitanya Kulkarni (37): block: introduce bio_init_fields() helper fs: use bio_init_fields in block_dev btrfs: use bio_init_fields in disk-io btrfs: use bio_init_fields in volumes ext4

[RFC PATCH 36/37] xfs: use bio_init_fields in xfs_buf

Signed-off-by: Chaitanya Kulkarni --- fs/xfs/xfs_buf.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index f8400bbd6473..1c157cfc5f8f 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1508,10 +1508,8 @@ xfs_buf_ioapply_map

[RFC PATCH 31/37] eros: use bio_init_fields in data

Signed-off-by: Chaitanya Kulkarni --- fs/erofs/data.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/erofs/data.c b/fs/erofs/data.c index ea4f693bee22..15f3a3f01fa3 100644 --- a/fs/erofs/data.c +++ b/fs/erofs/data.c @@ -220,10 +220,8 @@ static inline struct bio

[RFC PATCH 34/37] nfs: use bio_init_fields in blocklayout

Signed-off-by: Chaitanya Kulkarni --- fs/nfs/blocklayout/blocklayout.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/nfs/blocklayout/blocklayout.c b/fs/nfs/blocklayout/blocklayout.c index 3be6836074ae..7ac96519c8b7 100644 --- a/fs/nfs/blocklayout/blocklayout.c

[RFC PATCH 37/37] xfs: use bio_init_fields in xfs_log

Signed-off-by: Chaitanya Kulkarni --- fs/xfs/xfs_log.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c index fa2d05e65ff1..062ee664a910 100644 --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c @@ -1702,10 +1702,8 @@ xlog_write_iclog

Re: [PATCH blktests v2 02/11] common/xfs: Create common helper to check for XFS support

On 9/30/20 11:54, Logan Gunthorpe wrote: > > requires() { > _nvme_requires > - _have_program mkfs.xfs && _have_fio > + _have_xfs > + _have_fio Can you make _have_xfs return true false ? so it can be used with && ?

Re: [PATCH blktests v2 03/11] common/xfs: Create common helper to verify block device with xfs

On 9/30/20 11:54, Logan Gunthorpe wrote: > Make a common helper from the code in tests nvme/012 and nvme/013 > to run an fio verify on a XFS file system backed by the > specified block device. > > While we are at it, all the output is redirected to $FULL instead of > /dev/null. > > Signed-off-by:

Re: [PATCH blktests v2 04/11] nvme: Search for specific subsysnqn in _find_nvme_loop_dev

On 9/30/20 11:54, Logan Gunthorpe wrote: > This ensures we find the correct nvme loop device if others exist on a > given system (which is generally not expected on test systems). > > Additionally, this will be required in the upcomming test nvme/037 which > will have controllers racing with ones

Re: [PATCH blktests v2 05/11] nvme: Add common helpers for passthru tests

On 9/30/20 12:01, Logan Gunthorpe wrote: > Add some simple helpers to setup a passthru target that passes through > to a nvme test device. > > Signed-off-by: Logan Gunthorpe > --- > tests/nvme/rc | 76 +++ > 1 file changed, 76 insertions(+) > >

Re: [PATCH blktests v2 02/11] common/xfs: Create common helper to check for XFS support

On 10/6/20 16:51, Logan Gunthorpe wrote: > _have_xfs() does return true/false and can be used with && or in a > conditional. > > Per [1], my opinion is that using && in the requires() function where > the return value is ignored is confusing so I prefer not to do it in new > code. > > If we want

[PATCH] nvmet: fix opps in nvmet_execute_passthru_cmd()

Signed-off-by: Chaitanya Kulkarni --- drivers/nvme/target/passthru.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/target/passthru.c b/drivers/nvme/target/passthru.c index 89d91dc999a6..b56292c9a76c 100644 --- a/drivers/nvme/target/passthru.c +++ b/drivers/n

Re: [PATCH] nvmet: fix opps in nvmet_execute_passthru_cmd()

On 8/5/20 18:09, Sagi Grimberg wrote: > >> This patch adds a check in nvmet_execute_passthru_cmd() to prevent the >> following oops :- > > Why LKML and not linux-nvme? > My bad (+linux-nvme).

Re: [PATCH] nvmet: fix opps in nvmet_execute_passthru_cmd()

On 8/5/20 18:15, Sagi Grimberg wrote: > It doesn't have the patch. can you resend? Okay.

Re: [PATCH v2] nvme: Use spin_lock_irq() when taking the ctrl->lock

__do_softirq+0x118/0x595 > run_ksoftirqd+0x35/0x50 > smpboot_thread_fn+0x1d3/0x310 > kthread+0x1e7/0x210 > ret_from_fork+0x22/0x30 > > Fixes: be93e87e7802 ("nvme: support for multiple Command Sets Supported and > Effects log pages") > Signed-off-by: Logan Gunthorpe Thanks for this fix, looks good. Tested-by: Chaitanya Kulkarni Reviewed-by: Chaitanya Kulkarni

Re: [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request()

Zhang Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH] nvmet-passthru: Reject commands with non-sgl flags set

On 7/29/20 12:10, Logan Gunthorpe wrote: > Any command with a non-SGL flag set (like fuse flags) should be > rejected. > > Fixes: c1fef73f793b ("nvmet: add passthru code to process commands") > Signed-off-by: Logan Gunthorpe Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH blktests 00/11] NVMe Target Passthru Block Tests

On 8/27/20 12:49, Logan Gunthorpe wrote: > From: Logan Gunthorpe > > Hi, > > Now that the passthru patches are in Linus's tree, I wanted to get > the blktest changes that test them out there for some review. > > I know that Sagi has a series in progress to allow for running tests > with other

Re: [PATCH] drivers: block: skd: remove skd_pci_info()

On 12/11/20 08:45, Puranjay Mohan wrote: > PCI core calls __pcie_print_link_status() for every device, it prints > both the link width and the link speed. skd_pci_info() does the same > thing again, hence it can be removed. > > Signed-off-by: Puranjay Mohan > --- > drivers/block/skd_main.c | 31

Re: [PATCH] drivers: block: skd: remove skd_pci_info()

sure without any documentation why does it print "unknown" and I attributed that to probable firmware issue (since we all knowhow creative firmware can get ;)). That makes it the problem with original code more so than with this patch. In that case I was proposing just keep the original behavior. But maybe we should apply patch and if any user(s) comes up with the problem then we can deal with it. Whoever is going to apply they can add :- Reviewed-by: Chaitanya Kulkarni

Re: [PATCH] nvme: hwmon: fix crash on device teardown

Enzo, On 12/9/20 13:39, Enzo Matsumiya wrote: > Fix a possible NULL pointer dereference when trying to read > hwmon sysfs entries associated to NVMe-oF devices that were > hot-removed or disconnected. > > Unregister the NVMe hwmon device upon controller teardown > (nvme_stop_ctrl()). > >

Re: [PATCH] [v2] blk-mq-tag: make blk_mq_tag_busy() return void

On 12/9/20 22:06, Xianting Tian wrote: > As no one cares about the return value of blk_mq_tag_busy() and > __blk_mq_tag_busy(), so make them return void. > > Other change is to simplify blk_mq_tag_idle(). > > Signed-off-by: Xianting Tian > Reviewed-by: Ming Lei > --- > block/blk-mq-tag.c | 4

Re: [RFC V2] block: reject I/O for same fd if block size changed

On 12/30/20 08:03, Minwoo Im wrote: > Let's say, for example of NVMe device, Format command to change out > LBA format to another logical block size and BLKRRPART to re-read > partition information with a same file descriptor like: > > fd = open("/dev/nvme0n1", O_RDONLY); > >

Re: [RFC V2] block: reject I/O for same fd if block size changed

On 12/30/20 08:03, Minwoo Im wrote: > > diff --git a/block/genhd.c b/block/genhd.c > index 73faec438e49..c3a73cba7c88 100644 > --- a/block/genhd.c > +++ b/block/genhd.c > @@ -81,6 +81,7 @@ bool set_capacity_and_notify(struct gendisk *disk, sector_t > size) >*/ > if (!capacity ||

Re: [PATCH] nvmet: Kconfig: Fix spelling mistake "incuding" -> "including"

On 11/26/20 14:40, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in the Kconfig help text. Fix it. > > Signed-off-by: Colin Ian King Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH blktests 01/11] common/fio: Remove state file in common helper

On 8/27/20 12:49, Logan Gunthorpe wrote: > Instead of each individual test removing this file, just do it > in the common helper. > > Signed-off-by: Logan Gunthorpe Nice cleanup, looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH] nvme-pci: Disable Write Zeroes on Sandisk Skyhawk

irmware bug on specific device ? If yes then looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH] nvme: convert sysfs sprintf/snprintf family to sysfs_emit

: use scnprintf or sprintf. > ./drivers/nvme/host/core.c:3526:8-16: WARNING: use scnprintf or sprintf. > ./drivers/nvme/host/core.c:2833:8-16: WARNING: use scnprintf or sprintf. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH v3 1/1] loop: scale loop device by introducing per device lock

On 1/25/21 12:15 PM, Pavel Tatashin wrote: > Currently, loop device has only one global lock: > loop_ctl_mutex. Above line can be :- Currently, loop device has only one global lock: loop_ctl_mutex. Also please provide a complete discretion what are the members it protects, i.e. how big the size

[COMPILE ONLY RFC PATCH] loop: avoid page allocation in the fast path

version. Signed-off-by: Chaitanya Kulkarni --- drivers/block/loop.c | 22 -- drivers/block/loop.h | 1 + 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 578fc034db3f..08bd17afbdff 100644 --- a/drivers/block/loop.c

[RFC PATCH 03/34] drdb: use bio_new in drdb

Signed-off-by: Chaitanya Kulkarni --- drivers/block/drbd/drbd_receiver.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 09c86ef3f0fd..e1cd3427b28b 100644 --- a/drivers/block/drbd

[RFC PATCH 04/34] drdb: use bio_new() in submit_one_flush

Signed-off-by: Chaitanya Kulkarni --- drivers/block/drbd/drbd_receiver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index e1cd3427b28b..b86bbf725cbd 100644 --- a/drivers/block/drbd

[RFC PATCH 33/34] mm: use bio_new in swap_readpage

Signed-off-by: Chaitanya Kulkarni --- mm/page_io.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index 25b321489703..7579485ccb5e 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -342,7 +342,7 @@ int __swap_writepage(struct page *page

[RFC PATCH 31/34] iomap: use bio_new in iomap_readpage_actor

Signed-off-by: Chaitanya Kulkarni --- fs/iomap/buffered-io.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index 16a1e82e3aeb..08d119b62cf5 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c

[RFC PATCH 29/34] power/swap: use bio_new in hib_submit_io

Signed-off-by: Chaitanya Kulkarni --- kernel/power/swap.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/kernel/power/swap.c b/kernel/power/swap.c index c73f2e295167..e92e36c053a6 100644 --- a/kernel/power/swap.c +++ b/kernel/power/swap.c @@ -271,13 +271,12 @@ static

[RFC PATCH 26/34] xfs: use bio_new in xfs_rw_bdev

Signed-off-by: Chaitanya Kulkarni --- fs/xfs/xfs_bio_io.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/xfs/xfs_bio_io.c b/fs/xfs/xfs_bio_io.c index e2148f2d5d6b..e4644f22ebe6 100644 --- a/fs/xfs/xfs_bio_io.c +++ b/fs/xfs/xfs_bio_io.c @@ -26,11 +26,8

[RFC PATCH 27/34] xfs: use bio_new in xfs_buf_ioapply_map

Signed-off-by: Chaitanya Kulkarni --- fs/xfs/xfs_buf.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index f8400bbd6473..3ff6235e4f94 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1507,12 +1507,10 @@ xfs_buf_ioapply_map

[RFC PATCH 24/34] fs/nilfs: use bio_new nilfs_alloc_seg_bio

Signed-off-by: Chaitanya Kulkarni --- fs/nilfs2/segbuf.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c index 1e75417bfe6e..df352cab7a93 100644 --- a/fs/nilfs2/segbuf.c +++ b/fs/nilfs2/segbuf.c @@ -383,15 +383,9 @@ static

[RFC PATCH 23/34] fs/mpage.c: use bio_new mpage_alloc

Signed-off-by: Chaitanya Kulkarni --- fs/mpage.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/fs/mpage.c b/fs/mpage.c index 830e6cc2a9e7..01725126e81f 100644 --- a/fs/mpage.c +++ b/fs/mpage.c @@ -68,25 +68,21 @@ static struct bio *mpage_bio_submit(int

[RFC PATCH 07/34] dm: use bio_new in dm-log-writes

Signed-off-by: Chaitanya Kulkarni --- drivers/md/dm-log-writes.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c index e3d35c6c9f71..7ca9af407647 100644 --- a/drivers/md/dm-log-writes.c

[RFC PATCH 02/34] block: introduce and use bio_new

-by: Chaitanya Kulkarni --- block/blk-lib.c | 6 +- include/linux/bio.h | 25 + 2 files changed, 26 insertions(+), 5 deletions(-) diff --git a/block/blk-lib.c b/block/blk-lib.c index fb486a0bdb58..ec29415f00dd 100644 --- a/block/blk-lib.c +++ b/block/blk-lib.c @@ -14,17

[RFC PATCH 28/34] zonefs: use bio_new

Signed-off-by: Chaitanya Kulkarni --- fs/zonefs/super.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c index ab68e27bb322..620d67965a22 100644 --- a/fs/zonefs/super.c +++ b/fs/zonefs/super.c @@ -661,6 +661,7 @@ static const struct

[RFC PATCH 25/34] ocfs/cluster: use bio_new in dm-log-writes

Signed-off-by: Chaitanya Kulkarni --- fs/ocfs2/cluster/heartbeat.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c index 0179a73a3fa2..b34518036446 100644 --- a/fs/ocfs2/cluster/heartbeat.c +++ b/fs/ocfs2

[RFC PATCH 21/34] fs/jfs/jfs_metapage.c: use bio_new in metapage_writepage

Signed-off-by: Chaitanya Kulkarni --- fs/jfs/jfs_metapage.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c index 176580f54af9..3fa09d9a0b94 100644 --- a/fs/jfs/jfs_metapage.c +++ b/fs/jfs/jfs_metapage.c @@ -416,12 +416,11

[RFC PATCH 09/34] dm-zoned: use bio_new in dmz_write_mblock

Signed-off-by: Chaitanya Kulkarni --- drivers/md/dm-zoned-metadata.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c index e6252f48a49c..fa0ee732c6e9 100644 --- a/drivers/md/dm-zoned-metadata.c +++ b

[RFC PATCH 12/34] scsi: target/iblock: use bio_new

Signed-off-by: Chaitanya Kulkarni --- drivers/target/target_core_iblock.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c index 8ed93fd205c7..f1264918aee1 100644 --- a/drivers/target

[RFC PATCH 13/34] block: use bio_new in __blkdev_direct_IO

Signed-off-by: Chaitanya Kulkarni --- fs/block_dev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/block_dev.c b/fs/block_dev.c index 9d4b1a884d76..f3e3247894d7 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -367,6 +367,8 @@ __blkdev_direct_IO(struct kiocb

[RFC PATCH 08/34] dm-zoned: use bio_new in get_mblock_slow

Signed-off-by: Chaitanya Kulkarni --- drivers/md/dm-zoned-metadata.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c index 039d17b28938..e6252f48a49c 100644 --- a/drivers/md/dm-zoned-metadata.c +++ b

[RFC PATCH 06/34] zram: use bio_new

Signed-off-by: Chaitanya Kulkarni --- drivers/block/zram/zram_drv.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index d7018543842e..5d744e528d4f 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers

[RFC PATCH 01/34] block: move common code into blk_next_bio()

to the blk_next_bio() to reduce the duplication. In the next patch we introduce bio_new(), this prepration patch allows us to call it inside blk_next_bio(). Signed-off-by: Chaitanya Kulkarni --- block/blk-lib.c | 36 +++- block/blk-zoned.c | 4 +--- block/blk.h | 5

[RFC PATCH 32/34] mm: use bio_new in __swap_writepage

Signed-off-by: Chaitanya Kulkarni --- mm/page_io.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index 92f7941c6d01..25b321489703 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -342,10 +342,8 @@ int __swap_writepage(struct page *page

[RFC PATCH 30/34] hfsplus: use bio_new in hfsplus_submit_bio()

Signed-off-by: Chaitanya Kulkarni --- fs/hfsplus/wrapper.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c index 0350dc7821bf..8341ee6c9b31 100644 --- a/fs/hfsplus/wrapper.c +++ b/fs/hfsplus/wrapper.c @@ -64,10 +64,7 @@ int

[RFC PATCH 19/34] fs/jfs/jfs_logmgr.c: use bio_new in lbmRead

Signed-off-by: Chaitanya Kulkarni --- fs/jfs/jfs_logmgr.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index 9330eff210e0..4481f3e33a3f 100644 --- a/fs/jfs/jfs_logmgr.c +++ b/fs/jfs/jfs_logmgr.c @@ -1979,17 +1979,14

[RFC PATCH 05/34] xen-blkback: use bio_new

Create a wrapper on the tio of the bio_new() named get_new_bio() & use it in the dispatch_rw_block_io(). p Signed-off-by: Chaitanya Kulkarni --- drivers/block/xen-blkback/blkback.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/block/xen-blk

[RFC PATCH 00/34] block: introduce bio_new()

and gfp_mask by encapsulating new bio allocation with bio alloc with initialization at one place. The objective of this RFC is to only start a discussion, this it not completely tested at all. -ck Chaitanya Kulkarni (34): block: move common code into blk_next_bio

[RFC PATCH 22/34] fs/jfs/jfs_metapage.c: use bio_new in metapage_readpage

Signed-off-by: Chaitanya Kulkarni --- fs/jfs/jfs_metapage.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c index 3fa09d9a0b94..c7be3a2773bf 100644 --- a/fs/jfs/jfs_metapage.c +++ b/fs/jfs/jfs_metapage.c @@ -495,13 +495,11

[RFC PATCH 15/34] fscrypt: use bio_new in fscrypt_zeroout_range

Signed-off-by: Chaitanya Kulkarni --- fs/crypto/bio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/crypto/bio.c b/fs/crypto/bio.c index b048a0e38516..20dab9bdf098 100644 --- a/fs/crypto/bio.c +++ b/fs/crypto/bio.c @@ -148,12 +148,11 @@ int fscrypt_zeroout_range

[RFC PATCH 20/34] fs/jfs/jfs_logmgr.c: use bio_new in lbmStartIO

Signed-off-by: Chaitanya Kulkarni --- fs/jfs/jfs_logmgr.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index 4481f3e33a3f..bb25737d52f6 100644 --- a/fs/jfs/jfs_logmgr.c +++ b/fs/jfs/jfs_logmgr.c @@ -2121,16 +2121,14 @@ static

[RFC PATCH 34/34] mm: add swap_bio_new common bio helper

Signed-off-by: Chaitanya Kulkarni --- mm/page_io.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index 7579485ccb5e..cc30c9a0b0a7 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -287,6 +287,17 @@ static void

[RFC PATCH 16/34] fs/direct-io: use bio_new in dio_bio_alloc

Signed-off-by: Chaitanya Kulkarni --- fs/crypto/bio.c | 2 +- fs/direct-io.c | 6 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/crypto/bio.c b/fs/crypto/bio.c index 20dab9bdf098..28cd62ce853e 100644 --- a/fs/crypto/bio.c +++ b/fs/crypto/bio.c @@ -148,7 +148,7 @@ int

[RFC PATCH 17/34] iomap: use bio_new in iomap_dio_zero

Signed-off-by: Chaitanya Kulkarni --- fs/iomap/direct-io.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index ea1e8f696076..f6c557a1bd25 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -189,15 +189,13

  1   2   3   >