Re: [PATCH] regulator: core: Move regulator release to avoid deadlock

2012-10-31 Thread Charles Keepax
On Wed, Oct 31, 2012 at 04:03:59PM +0530, Laxman Dewangan wrote: On Monday 29 October 2012 09:44 PM, Mark Brown wrote: * PGP Signed by an unknown key On Mon, Oct 29, 2012 at 09:33:33AM +, Charles Keepax wrote: regulator_put function was called whilst holding the regulator_list_mutex

Re: [PATCH] regulator: core: avoid memory access after freeing it

2012-11-06 Thread Charles Keepax
On Tue, Nov 06, 2012 at 04:04:09PM +0530, Laxman Dewangan wrote: When regulator_register() failed due to non availability of mutex_unlock(regulator_list_mutex); ... } EXPORT_SYMBOL_GPL(regulator_put); @@ -3453,11 +3460,10 @@ scrub: gpio_free(rdev-ena_gpio);

[PATCH] mfd: Only unregister platform devices allocated by the mfd core

2012-11-08 Thread Charles Keepax
device pointer. This patch defines a device_type for mfd devices and checks this is present from mfd_remove_devices_fn before processing the device. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/mfd/mfd-core.c | 15 +-- 1 files changed, 13 insertions

[PATCH 1/2] mfd: arizona: Use correct array for ARRAY_SIZE in mfd_add_devices call

2012-10-25 Thread Charles Keepax
wm5102_devs array was used for ARRAY_SIZE whilst adding the wm5110 devices. This change corrects this to get the size from the wm5110_devs array. As both arrays are the same size no issues should have been caused by this bug. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com

[PATCH 2/2] mfd: arizona: Correctly report when AIF2/AIF1 is underclocked

2012-10-25 Thread Charles Keepax
In the interrupt handler for an underclocked event, whilst checking for the source of the interrupt, AIF3 was checked twice and AIF1 was not checked. This change correctly checks the AIF1 underclocked bit and reports the correct error messages for all cases. Signed-off-by: Charles Keepax ckee

[PATCH] ASoC: wm5102: Correct micbias DAPM supplies

2012-10-25 Thread Charles Keepax
ARIZONA_MICB1_ENA_SHIFT was used for micbias 2 and 3. This change correctly uses the ARIZONA_MICBX_ENA_SHIFT for each corresponding DAPM supply. This should not have caused any problems as the micbias enables are in the same place in each register. Signed-off-by: Charles Keepax ckee

[PATCH] regulator: core: Move regulator release to avoid deadlock

2012-10-29 Thread Charles Keepax
the supply. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/regulator/core.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 5c4829c..e68754c 100644 --- a/drivers/regulator/core.c

[PATCH v2] mfd: Only unregister platform devices allocated by the mfd core

2012-11-09 Thread Charles Keepax
device pointer. This patch defines a device_type for mfd devices and checks this is present from mfd_remove_devices_fn before processing the device. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/mfd/mfd-core.c | 15 +-- 1 files changed, 13 insertions

[PATCH] mfd: arizona: Move chip reset to before register patch

2012-11-12 Thread Charles Keepax
-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/mfd/arizona-core.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 1b48f20..1d241ea 100644 --- a/drivers/mfd/arizona-core.c +++ b

Re: [PATCH] mfd: arizona: Move chip reset to before register patch

2012-11-13 Thread Charles Keepax
On Tue, Nov 13, 2012 at 02:56:20PM +0900, Mark Brown wrote: On Mon, Nov 12, 2012 at 05:56:48PM +, Charles Keepax wrote: In the absence of a physical reset line the chip is reset by writing the first register, this was done after the register patch was applied which negates the settings

[PATCH] regulator: core: Add locked version of regulator_put to avoid deadlock

2012-11-13 Thread Charles Keepax
holding the mutex, replacing the aforementioned call. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com Cc: Laxman Dewangan ldewan...@nvidia.com --- I hope this isn't bad etiquette but I took the liberaty of fixing up the patch as per the comments and taking into account

[PATCH 1/3] ASoC: arizona: Add support for multiplexer with no associated mixer

2012-11-13 Thread Charles Keepax
support multiplexed single input blocks into the Arizona platform. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- sound/soc/codecs/arizona.h | 40 1 files changed, 20 insertions(+), 20 deletions(-) diff --git a/sound/soc/codecs

[PATCH 2/3] ASoC: wm5102: Remove mixer widgets on the ASRC

2012-11-13 Thread Charles Keepax
There is no mixer attached to the ASRC on the wm5102 only a multiplexer to select the source for the single input line. This change correctly defines this in the wm5102 CODEC driver. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- sound/soc/codecs/wm5102.c | 24

[PATCH 3/3] ASoC: wm5110: Remove mixer widgets on the ASRC

2012-11-13 Thread Charles Keepax
There is no mixer attached to the ASRC on the wm5110 only a multiplexer to select the source for the single input line. This change correctly defines this in the wm5110 CODEC driver. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- sound/soc/codecs/wm5110.c | 24

Re: [PATCH v2] regulator: core: Avoid deadlock when regulator_register fails

2012-11-14 Thread Charles Keepax
the aforementioned call. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com Cc: Laxman Dewangan ldewan...@nvidia.com --- drivers/regulator/core.c | 28 +--- 1 files changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator

Re: [PATCH] mfd: arizona: Move chip reset to before register patch

2012-11-14 Thread Charles Keepax
On Wed, Nov 14, 2012 at 10:20:09AM +0900, Mark Brown wrote: On Tue, Nov 13, 2012 at 01:12:19PM +, Charles Keepax wrote: On Tue, Nov 13, 2012 at 02:56:20PM +0900, Mark Brown wrote: No, we should never write to the chip until we have successfully identified it. Do a sync or similar

Re: [PATCH v2] mfd: arizona: Sync regcache after reset

2012-11-14 Thread Charles Keepax
In the absence of a physical reset line the chip is reset by writing the first register, which is done after the register patch has been applied. This patch synchronises the register cache after the reset to preserve any register changes that had been applied. Signed-off-by: Charles Keepax ckee

[PATCH v2] mfd: arizona: Sync regcache after reset

2012-11-14 Thread Charles Keepax
In the absence of a physical reset line the chip is reset by writing the first register, which is done after the register patch has been applied. This patch synchronises the register cache after the reset to preserve any register changes that had been applied. Signed-off-by: Charles Keepax ckee

[PATCH] kbuild: Remove reference to uninitialised variable

2012-10-15 Thread Charles Keepax
Verbose output variable is unnecessary because the command's echo is already surpressed. Additionally because the block defines skip-makefile the variable Q is not defined within the makefile, which can cause problems if Q is defined in the users environment. Signed-off-by: Charles Keepax ckee

[PATCH] ARM: S3C64XX: Clear DMA flags on channel request

2013-03-08 Thread Charles Keepax
This patch clears the DMA flags when a DMA channel is requested. This is necessary because otherwise the channel may inherit incompatible settings from its last usage. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- arch/arm/mach-s3c64xx/dma.c |1 + 1 files changed, 1

Re: [PATCH] mfd: wm5102: Correct default for LDO1_CONTROL_2

2012-11-29 Thread Charles Keepax
On Wed, Nov 28, 2012 at 06:47:28PM +, Mark Brown wrote: Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/mfd/wm5102-tables.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c index 50bbe15..065ffd3

[PATCH 1/2] extcon: arizona: Remove additional increment for jack flips

2013-02-05 Thread Charles Keepax
Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 3aacacc..5f91711 100644 --- a/drivers/extcon

[PATCH 2/2] extcon: arizona: Clear _trig_sts bits after jack detection

2013-02-05 Thread Charles Keepax
It is important to clear the wake trigger status bits otherwise DCVDD will be held high independent of the state of the LDOENA line. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c |7 +++ include/linux/mfd/arizona/registers.h

[PATCH v3] mfd: arizona: Sync regcache after reset

2012-11-15 Thread Charles Keepax
In the absence of a physical reset line the chip is reset by writing the first register, which is done after the register patch has been applied. This patch synchronises the register cache after the reset to preserve any register changes that had been applied. Signed-off-by: Charles Keepax ckee

[PATCH v2] extcon: arizona: Clear trig_sts bits on all paths

2013-08-07 Thread Charles Keepax
on the duplicate detection code path. Reported-by: Ryo Tsutsui ryo.tsut...@wolfsonmicro.com Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers

[PATCH] extcon: arizona: Correct typo in headphone detect range transitions

2013-08-13 Thread Charles Keepax
We should move range when the measured value is greater than or equal to the max value not when greater than. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH] gpio: arizona: Add wm8997 support to probe

2013-09-11 Thread Charles Keepax
Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- A bit of confusion with merging this last time because I messed up the CCs, is safe to merge this patch on its own now. drivers/gpio/gpio-arizona.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[PATCH 1/4] extcon: arizona: Add defines for microphone detection levels

2013-11-08 Thread Charles Keepax
Improve readability by creating a define for each microphone detection level. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 21 - include/linux/mfd/arizona/registers.h |9 + 2 files changed, 25

[PATCH 2/4] extcon: arizona: Fix reset of HPDET after race with removal

2013-11-08 Thread Charles Keepax
We need to make sure we reset back to our starting state, especially making sure that we have disabled poll in the register cache. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions

[PATCH 3/4] extcon: arizona: Fix race with microphone detection and removal

2013-11-08 Thread Charles Keepax
The microphone detection code is run as delayed work to provide additional debounce, it is possible that the jack could have been removed by the time we process the microphone detection. Turn this case into a no op. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers

[PATCH 4/4] extcon: arizona: Eliminate dead error handling code

2013-11-08 Thread Charles Keepax
this clause. Whilst this clause is not currently hit removing it makes the code fragile. It will not be obvious whilst editing arizona_hpdet_do_id that you shouldn't add a return value other than 0 or -EAGAIN. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon

[RFC PATCH] regulator: core: Add ability to create a lookup alias for supply

2013-10-02 Thread Charles Keepax
. It this case it is necessary for each sub device to locate their supply data on the main device. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- Hi Mark, Following our discussions around the Arizona regulator bindings here is an effort at putting a mechanism

[PATCH] mfd: arizona: Correct handling of device tree gpio defaults

2013-10-03 Thread Charles Keepax
-by: Heather Lomond heather.lom...@wolfsonmicro.com Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/mfd/arizona-core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 5ac3aa4..e13355b 100644

[PATCH v2] mfd: arizona: Correct handling of device tree gpio defaults

2013-10-03 Thread Charles Keepax
ensure that we handle the gpio default as either an out of range value or a zero value rather than both one after the other. Reported-by: Heather Lomond heather.lom...@wolfsonmicro.com Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- Hi, Added a bit more explanation I hope

[PATCH v3] mfd: arizona: Correct handling of device tree gpio defaults

2013-10-03 Thread Charles Keepax
-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- Hi, Sorry, your explanation is certainly fine with me. Thanks, Charles drivers/mfd/arizona-core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index

Re: [RFC PATCH] regulator: core: Add ability to create a lookup alias for supply

2013-10-03 Thread Charles Keepax
On Wed, Oct 02, 2013 at 08:50:29PM +0100, Mark Brown wrote: Bulk versions of the API would also make sense - it's likely that more than one supply will need to be mapped - and please also add managed versions so people don't have to write cleanup code. For the bulk API would you prefer taking

[PATCH] mfd: arizona: Update volatile registers for WM5110 DSP

2013-09-16 Thread Charles Keepax
Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/mfd/wm5110-tables.c | 18 -- 1 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c index 2a79723..92c6ea6 100644 --- a/drivers/mfd

Re: [PATCH] mfd: arizona: Update volatile registers for WM5110 DSP

2013-09-17 Thread Charles Keepax
at 08:24:25AM +0100, Lee Jones wrote: On Mon, 16 Sep 2013, Charles Keepax wrote: Any chance of a little more information in the commit message? What are scratch registers and why are they required now where they weren't before? Why are the control and clocking regulators no longer needed

[PATCH v2] mfd: arizona: Update registers for WM5110 DSP

2013-09-17 Thread Charles Keepax
DSPx_CONTROL_1 and DSPx_CLOCKING_1 are not volatile registers and are incorrectly marked as such, fix this. Also add the DSP scratch registers, which are frequently used to output debug info from the DSP core. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- Version 2

[PATCH] mfd: wm5110: Update noise gate default to match the patch file

2013-09-17 Thread Charles Keepax
The default value for the noise gate control register is changed in the patch file, we need to reflect this in the defaults array, this patch does so. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/mfd/wm5110-tables.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH] clk: s3c64xx: Correct spi bus clock hookups

2013-10-16 Thread Charles Keepax
+ samsung soc mailing list On Wed, Oct 16, 2013 at 12:52:42AM +0200, Tomasz Figa wrote: Hi Charles, On Tuesday 15 of October 2013 13:26:22 Charles Keepax wrote: ALIAS(SCLK_MMC1, s3c-sdhci.1, mmc_busclk.2), ALIAS(SCLK_MMC0, s3c-sdhci.0, mmc_busclk.2), - ALIAS(SCLK_SPI1, s3c6410

Re: [PATCH] clk: s3c64xx: Correct spi bus clock hookups

2013-10-16 Thread Charles Keepax
On Wed, Oct 16, 2013 at 11:10:59AM +0200, Tomasz Figa wrote: If you have hardware to test this, especially with possibility of checking the SPI frequency I would really appreciate this, as I unfortunately don't have such. I might not be able to get around to it this week, but I certainly

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-26 Thread Charles Keepax
On Fri, Nov 08, 2013 at 09:59:28AM -0700, Stephen Warren wrote: On 11/08/2013 02:49 AM, Florian Meier wrote: In order to find I2C devices in the device tree, the platform nodes have to be known by the I2C core. Analogous to the i2c-omap driver this requires setting the dev.of_node parameter

[PATCH] mfd: wm5110: Give new AIF2 registers defaults and mark as readable

2013-11-27 Thread Charles Keepax
The registers associated with the new channels on AIF2 were accidentally missing defaults and not marked as readable this patch fixes this. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- This patch depends on the patch: ASoC: wm5110: Add extra AIF2 channels Which

Re: [PATCH] mfd: wm5110: Give new AIF2 registers defaults and mark as readable

2013-11-27 Thread Charles Keepax
On Wed, Nov 27, 2013 at 01:24:42PM +, Lee Jones wrote: The registers associated with the new channels on AIF2 were accidentally missing defaults and not marked as readable this patch fixes this. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- This patch

[PATCH] mfd: arizona: Mark missing AOD registers as volatile

2013-10-14 Thread Charles Keepax
-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/mfd/wm5102-tables.c |1 - drivers/mfd/wm5110-tables.c |3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c index 802dd3c..1e9a4b2 100644 --- a/drivers/mfd

[PATCH] cpufreq: s3c64xx: Rename index to driver_data

2013-10-14 Thread Charles Keepax
The index field of cpufreq_frequency_table has been renamed to driver data in this commit: commit 5070158804b5339c71809f5e673cea1cfacd804d cpufreq: rename index as driver_data in cpufreq_frequency_table This patch updates the s3c64xx driver to match. Signed-off-by: Charles Keepax ckee

[PATCH] USB: OHCI: Only use ohci_driver_overrides if they are defined

2013-10-15 Thread Charles Keepax
Overrides are optional and many drivers pass NULL, in this case don't process the overrides so we don't deference a NULL pointer. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/usb/host/ohci-hcd.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff

[PATCH] clk: s3c64xx: Correct spi bus clock hookups

2013-10-15 Thread Charles Keepax
. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/clk/samsung/clk-s3c64xx.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/clk/samsung/clk-s3c64xx.c b/drivers/clk/samsung/clk-s3c64xx.c index 7d2c842..f6ac974 100644 --- a/drivers/clk

Re: [PATCH] USB: OHCI: Only use ohci_driver_overrides if they are defined

2013-10-15 Thread Charles Keepax
Apologies looks like I was on an earlier RC there and the users that did this have been removed. I assume this patch can be ignored sorry for the noise. Thanks, Charles -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

[PATCH 0/3 v2] Add regulator supply alias

2013-10-15 Thread Charles Keepax
versions for all the calls - Registration of the aliases is added to the MFD framework rather than done in the driver probe Charles Keepax (3): regulator: core: Add ability to create a lookup alias for supply mfd: Allow mapping regulator supplies to MFD device from children mfd: arizona: Specify

[PATCH 2/3 v2] mfd: Allow mapping regulator supplies to MFD device from children

2013-10-15 Thread Charles Keepax
which might have no knowledge of MFD to lookup supplies on its behalf the supply will not be found. This patch adds a list of supplies that should be looked up on the parent rather than the child as part of the mfd_cell structure. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com

[PATCH 3/3 v2] mfd: arizona: Specify supply mappings for Arizona CODECs

2013-10-15 Thread Charles Keepax
The CODEC power supplies should be looked up on the Arizona device as they will be created here by device tree also update the only user of non-device tree bindings. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- arch/arm/mach-s3c64xx/mach-crag6410.c | 12

[PATCH 1/3 v2] regulator: core: Add ability to create a lookup alias for supply

2013-10-15 Thread Charles Keepax
. It this case it is necessary for each sub device to locate their supply data on the main device. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/regulator/core.c | 170 drivers/regulator/devres.c | 163

[PATCH 0/3 v2] Add regulator supply alias

2013-10-15 Thread Charles Keepax
versions for all the calls - Registration of the aliases is added to the MFD framework rather than done in the driver probe Charles Keepax (3): regulator: core: Add ability to create a lookup alias for supply mfd: Allow mapping regulator supplies to MFD device from children mfd: arizona: Specify

[PATCH 1/3 v2] regulator: core: Add ability to create a lookup alias for supply

2013-10-15 Thread Charles Keepax
. It this case it is necessary for each sub device to locate their supply data on the main device. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/regulator/core.c | 170 drivers/regulator/devres.c | 163

[PATCH 3/3 v2] mfd: arizona: Specify supply mappings for Arizona CODECs

2013-10-15 Thread Charles Keepax
The CODEC power supplies should be looked up on the Arizona device as they will be created here by device tree also update the only user of non-device tree bindings. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- arch/arm/mach-s3c64xx/mach-crag6410.c | 12

[PATCH 2/3 v2] mfd: Allow mapping regulator supplies to MFD device from children

2013-10-15 Thread Charles Keepax
which might have no knowledge of MFD to lookup supplies on its behalf the supply will not be found. This patch adds a list of supplies that should be looked up on the parent rather than the child as part of the mfd_cell structure. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com

Re: [PATCH] mfd: wm831x: Use PM ops for shutdown

2013-11-09 Thread Charles Keepax
On Fri, Nov 08, 2013 at 06:51:26PM +, Mark Brown wrote: From: Mark Brown broo...@linaro.org This helps move us towards removing the bus custom operations. Signed-off-by: Mark Brown broo...@linaro.org Acked-by: Charles Keepax ckee...@opensource.wolfsonmicro.com Thanks, Charles

Re: [PATCH 4/4] extcon: arizona: Eliminate dead error handling code

2013-11-11 Thread Charles Keepax
On Mon, Nov 11, 2013 at 09:00:14AM +, Lee Jones wrote: As a small disclaimer I would personally prefer to not merge this patch. I have added it based on previous code review of the other patches in this chain. I'd prefer the functionally redundant 'else if' over the comment. I'm

Re: [PATCH 1/4] extcon: arizona: Add defines for microphone detection levels

2013-11-11 Thread Charles Keepax
On Mon, Nov 11, 2013 at 10:53:56AM +, Lee Jones wrote: On 11/08/2013 10:19 PM, Charles Keepax wrote: Improve readability by creating a define for each microphone detection level. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon

Re: [PATCH 1/4] extcon: arizona: Add defines for microphone detection levels

2013-11-12 Thread Charles Keepax
On Mon, Nov 11, 2013 at 11:26:38AM +, Lee Jones wrote: I'm inclined to agree with you though, so if you want to send a patch based on v3.14-rc1 I'd be happy to accept it. Apologies for causing confusion here I checked your tree for the patch and didn't see it, so I assumed you

Re: [PATCH 4/4] extcon: arizona: Eliminate dead error handling code

2013-11-12 Thread Charles Keepax
On Tue, Nov 12, 2013 at 09:15:29AM +0900, Chanwoo Choi wrote: Hi CHarles, On 11/08/2013 10:19 PM, Charles Keepax wrote: As a small disclaimer I would personally prefer to not merge this patch. I have added it based on previous code review of the other patches in this chain

[PATCH 1/7] extcon: arizona: Add defines for microphone detection levels

2013-11-13 Thread Charles Keepax
Improve readability by creating a define for each microphone detection level. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 19 ++- include/linux/mfd/arizona/registers.h |9 + 2 files changed, 23

[PATCH 3/7] extcon: arizona: Fix race with microphone detection and removal

2013-11-13 Thread Charles Keepax
The microphone detection code is run as delayed work to provide additional debounce, it is possible that the jack could have been removed by the time we process the microphone detection. Turn this case into a no op. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers

[PATCH 6/7] extcon: arizona: Factor out different headphone detection IPs

2013-11-13 Thread Charles Keepax
This patch factors out each headphone detection IP in a seperate function this makes the code a little more readable and prevents us getting to excessive levels of indentation. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 213

[PATCH 7/7] extcon: arizona: Improve headphone detection error handling

2013-11-13 Thread Charles Keepax
of cases where this was not the case. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 82 -- 1 files changed, 60 insertions(+), 22 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers

[PATCH 5/7] extcon: arizona: Add support for headphone detection on wm5110 rev D

2013-11-13 Thread Charles Keepax
wm5110 rev D is the first chip to use headphone detection IP 2, specify such and make a small correction as the impedance value is actually read in 0.5 ohm increments now. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 11 +++ 1

[PATCH 2/7] extcon: arizona: Fix reset of HPDET after race with removal

2013-11-13 Thread Charles Keepax
We need to make sure we reset back to our starting state, especially making sure that we have disabled poll in the register cache. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions

[PATCH 4/7] extcon: arizona: No need to switch back down HPDET ranges

2013-11-13 Thread Charles Keepax
No point in revisiting ranges the detection will be no more accurate the second time simply report that the resistance is right on the range boundry. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 21 +++-- 1 files

Re: [PATCH 1/7] extcon: arizona: Add defines for microphone detection levels

2013-11-14 Thread Charles Keepax
On Thu, Nov 14, 2013 at 09:38:30PM +0900, Chanwoo Choi wrote: Hi Charles, I tried to apply this patch[1-4]. But happen fail of 'git am'. Did you develop this patchset based on extcon-next tree? Also, you should add version information of patch subject as following: - [PATCHv2 1/7] extcon:

[PATCH v2 1/7] extcon: arizona: Add defines for microphone detection levels

2013-11-14 Thread Charles Keepax
Improve readability by creating a define for each microphone detection level. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 19 ++- include/linux/mfd/arizona/registers.h |9 + 2 files changed, 23

[PATCH v2 7/7] extcon: arizona: Improve headphone detection error handling

2013-11-14 Thread Charles Keepax
of cases where this was not the case. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 82 -- 1 files changed, 60 insertions(+), 22 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers

[PATCH v2 6/7] extcon: arizona: Factor out different headphone detection IPs

2013-11-14 Thread Charles Keepax
This patch factors out each headphone detection IP in a seperate function this makes the code a little more readable and prevents us getting to excessive levels of indentation. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 215

[PATCH v2 5/7] extcon: arizona: Add support for headphone detection on wm5110 rev D

2013-11-14 Thread Charles Keepax
wm5110 rev D is the first chip to use headphone detection IP 2, specify such and make a small correction as the impedance value is actually read in 0.5 ohm increments now. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 12 1

[PATCH v2 3/7] extcon: arizona: Fix race with microphone detection and removal

2013-11-14 Thread Charles Keepax
The microphone detection code is run as delayed work to provide additional debounce, it is possible that the jack could have been removed by the time we process the microphone detection. Turn this case into a no op. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers

[PATCH v2 4/7] extcon: arizona: No need to switch back down HPDET ranges

2013-11-14 Thread Charles Keepax
No point in revisiting ranges the detection will be no more accurate the second time simply report that the resistance is right on the range boundry. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 21 +++-- 1 files

[PATCH v2 2/7] extcon: arizona: Fix reset of HPDET after race with removal

2013-11-14 Thread Charles Keepax
We need to make sure we reset back to our starting state, especially making sure that we have disabled poll in the register cache. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions

Re: [PATCH v2 1/7] extcon: arizona: Add defines for microphone detection levels

2013-11-14 Thread Charles Keepax
On Thu, Nov 14, 2013 at 02:36:06PM +, Lee Jones wrote: On Thu, 14 Nov 2013, Charles Keepax wrote: Improve readability by creating a define for each microphone detection level. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c

[PATCH v3 2/7] extcon: arizona: Fix reset of HPDET after race with removal

2013-11-14 Thread Charles Keepax
We need to make sure we reset back to our starting state, especially making sure that we have disabled poll in the register cache. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions

[PATCH v3 3/7] extcon: arizona: Fix race with microphone detection and removal

2013-11-14 Thread Charles Keepax
The microphone detection code is run as delayed work to provide additional debounce, it is possible that the jack could have been removed by the time we process the microphone detection. Turn this case into a no op. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers

[PATCH v3 1/7] extcon: arizona: Add defines for microphone detection levels

2013-11-14 Thread Charles Keepax
Improve readability by creating a define for each microphone detection level. Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 19 ++- include/linux/mfd/arizona/registers.h

[PATCH v3 6/7] extcon: arizona: Factor out different headphone detection IPs

2013-11-14 Thread Charles Keepax
This patch factors out each headphone detection IP in a seperate function this makes the code a little more readable and prevents us getting to excessive levels of indentation. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 215

[PATCH v3 7/7] extcon: arizona: Improve headphone detection error handling

2013-11-14 Thread Charles Keepax
of cases where this was not the case. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 82 -- 1 files changed, 60 insertions(+), 22 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers

[PATCH v3 4/7] extcon: arizona: No need to switch back down HPDET ranges

2013-11-14 Thread Charles Keepax
No point in revisiting ranges the detection will be no more accurate the second time simply report that the resistance is right on the range boundry. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 21 +++-- 1 files

[PATCH v3 5/7] extcon: arizona: Add support for headphone detection on wm5110 rev D

2013-11-14 Thread Charles Keepax
wm5110 rev D is the first chip to use headphone detection IP 2, specify such and make a small correction as the impedance value is actually read in 0.5 ohm increments now. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/extcon/extcon-arizona.c | 12 1

[PATCH 1/2] regulator: arizona-micsupp: Convert to use linear ranges

2013-11-15 Thread Charles Keepax
Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/regulator/arizona-micsupp.c | 52 +++--- 1 files changed, 11 insertions(+), 41 deletions(-) diff --git a/drivers/regulator/arizona-micsupp.c b/drivers/regulator/arizona-micsupp.c index

[PATCH 2/2] regulator: arizona-micsupp: Correct wm5110 voltage selection

2013-11-15 Thread Charles Keepax
wm5110 provides different voltage configurations than the other Arizona parts, this patch adds support for this into the regulator driver. Also fixup the default for the configuration register for wm5110. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/mfd/wm5110

[PATCH v2 1/2] regulator: arizona-micsupp: Convert to use linear ranges

2013-11-15 Thread Charles Keepax
Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/regulator/arizona-micsupp.c | 52 +++--- 1 files changed, 11 insertions(+), 41 deletions(-) diff --git a/drivers/regulator/arizona-micsupp.c b/drivers/regulator/arizona-micsupp.c index

[PATCH v2 2/2] regulator: arizona-micsupp: Correct wm5110 voltage selection

2013-11-15 Thread Charles Keepax
wm5110 provides different voltage configurations than the other Arizona parts, this patch adds support for this into the regulator driver. Also fixup the default for the configuration register for wm5110. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/regulator

[PATCH] mfd: wm5110: Correct default for register LDO2 Control 1

2013-11-15 Thread Charles Keepax
Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/mfd/wm5110-tables.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c index bf8b3b5..d3d7531 100644 --- a/drivers/mfd/wm5110-tables.c

[PATCH] mfd: wm5110: Add register patch for rev D chip

2013-11-19 Thread Charles Keepax
Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/mfd/wm5110-tables.c | 30 +- 1 files changed, 29 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c index daf2fe8..bd9c3c9 100644

[PATCH v2] mfd: wm5110: Add register patch for rev D chip

2013-11-19 Thread Charles Keepax
Evaluation of revision D of WM5110 suggests updates to the register patch for optimal performance. For the sake of clarity rev C of the chip does not require a register patch. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- Updated the commit message to give a little more

[PATCH 1/4] mfd: wm5110: Make DSP memories readable

2013-11-19 Thread Charles Keepax
Expose the memory regions used by the DSP cores on WM5110 as readable and volatile. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/mfd/wm5110-tables.c | 69 -- 1 files changed, 65 insertions(+), 4 deletions(-) diff --git

[PATCH 0/4] *** SUBJECT HERE ***

2013-11-19 Thread Charles Keepax
through ASoC. Thanks, Charles Charles Keepax (3): mfd: wm5110: Make DSP memories readable ASoC: wm5110: Add basic support for ISRCs ASoC: wm5110: Expose input high pass filter controls Mark Brown (1): ASoC: wm5110: Hook up ADSP2 cores drivers/mfd/wm5110-tables.c | 73

[PATCH 4/4] ASoC: wm5110: Expose input high pass filter controls

2013-11-19 Thread Charles Keepax
Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/mfd/wm5110-tables.c |4 +++ include/linux/mfd/arizona/registers.h | 37 + sound/soc/codecs/arizona.c| 10 + sound/soc/codecs/arizona.h

[PATCH 1/4] mfd: wm5110: Make DSP memories readable

2013-11-19 Thread Charles Keepax
Expose the memory regions used by the DSP cores on WM5110 as readable and volatile. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/mfd/wm5110-tables.c | 69 -- 1 files changed, 65 insertions(+), 4 deletions(-) diff --git

[PATCH 4/4] ASoC: wm5110: Expose input high pass filter controls

2013-11-19 Thread Charles Keepax
Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/mfd/wm5110-tables.c |4 +++ include/linux/mfd/arizona/registers.h | 37 + sound/soc/codecs/arizona.c| 10 + sound/soc/codecs/arizona.h

[PATCH 3/4] ASoC: wm5110: Add basic support for ISRCs

2013-11-19 Thread Charles Keepax
Add support for the ISRCs that matches the current support on the w5102. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- sound/soc/codecs/wm5110.c | 178 + 1 files changed, 178 insertions(+), 0 deletions(-) diff --git a/sound

[PATCH 8/8] regulator: arizona-ldo1: Correct default regulator init_data

2014-03-18 Thread Charles Keepax
. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/regulator/arizona-ldo1.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/arizona-ldo1.c b/drivers/regulator/arizona-ldo1.c index a67013f..9a3c292 100644 --- a/drivers/regulator

  1   2   3   4   5   6   7   8   9   10   >