[PATCH] Input: elan_i2c - +200 ms delay before setting to ABS mode

. "elan_i2c i2c-ELAN1000:00: invalid report id data (1)" This change is from ELAN's correction. It needs 200ms delay before set_mode() so that the mode setting will correctly take effect. Signed-off-by: Chris Chiu <c...@endlessm.com> --- drivers/input/mouse/elan_i2c_core.c | 12 +++-

[PATCH] drm/nouveau: fix unknown chipset for GTX 1060

Nouveau driver shows unknown chipset (136000a1) for GTX 1060, so it only gives VGA resolution on screen. Use the same chipset as nv134 then it shows FullHD. This commit copies fields from nv134_chipset to nv136_chipset for GTX 1060. Signed-off-by: Chris Chiu <c...@endlessm.com> --- drive

[PATCH] HID: add Asus macrokey support for Asus "Republic of Gamers" laptop

rified on GL553VD/VE, GL753VD/VE. Signed-off-by: Chris Chiu <c...@endlessm.com> Reported-by: Yukai Li <yuka...@gmail.com> --- drivers/hid/Kconfig| 11 +++ drivers/hid/Makefile | 1 + drivers/hid/hid-asus-rog.c | 80 ++ drivers/hid

Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of Gamers" laptop

On Wed, Dec 14, 2016 at 6:20 PM, Jiri Kosina <ji...@kernel.org> wrote: > On Mon, 12 Dec 2016, Chris Chiu wrote: > > [ ... snip ... ] >> +static const struct hid_device_id asus_rog_devices[] = { >> + { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, >> US

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

Hi Mika, Yes, that’s the most weird part. Chris 從我的 iPhone 傳送 > Mika Westerberg <mika.westerb...@linux.intel.com> 於 2017年11月15日 下午4:04 寫道： > >> On Tue, Nov 14, 2017 at 06:41:36PM +0800, Chris Chiu wrote: >> The touchpad in the Asus laptop model X540NA is unres

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

On Tue, Nov 21, 2017 at 8:04 PM, Mika Westerberg <mika.westerb...@linux.intel.com> wrote: > On Tue, Nov 21, 2017 at 07:54:26PM +0800, Chris Chiu wrote: >> Yup, I checked the value of the corresponded pin. It shows following before >> suspend >> pin 18 (GPIO_18)

GemniLake laptops goes power off directly after performing suspend

Hi, I have 2 GemniLake laptops from ASUS, named X441MB and X507MA, both go power off after I do "systemctl suspend" on top of kerne head fd6d2e506ce6 (Merge tag 'docs-4.15-fixes' of git://git.lwn.net/linux). I then wipe it out and install Windows RS3 instead, also goes to power off after

Re: [Intel-gfx] GemniLake laptops goes power off directly after performing suspend

On Tue, Dec 12, 2017 at 9:32 PM, Imre Deak <imre.d...@intel.com> wrote: > On Fri, Dec 08, 2017 at 10:31:30AM +, Daniel Drake wrote: >> Hi, >> >> Adding intel-gfx list in case i915 developers can help. Updated summary >> below. >> >>

r8169 take too long to complete driver initialization

Hi, We've hit a suspend/resume issue on a Acer desktop caused by r8169 driver. The dmseg https://gist.github.com/mschiu77/b741849b5070281daaead8dfee312d1a shows it's still in msleep() within a mutex lock. After looking into the code, it's caused by the rtl8168ep_stop_cmac() which is

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

On Fri, Nov 17, 2017 at 5:13 PM, Chris Chiu <c...@endlessm.com> wrote: > On Fri, Nov 17, 2017 at 5:11 PM, Mika Westerberg > <mika.westerb...@linux.intel.com> wrote: >> On Fri, Nov 17, 2017 at 04:27:39PM +0800, Chris Chiu wrote: >>> On Thu, Nov 16, 2017 at 9:07 PM,

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

On Fri, Nov 17, 2017 at 2:49 PM, Mika Westerberg <mika.westerb...@linux.intel.com> wrote: > On Thu, Nov 16, 2017 at 09:27:51PM +0800, Chris Chiu wrote: >> On Thu, Nov 16, 2017 at 8:44 PM, Mika Westerberg >> <mika.westerb...@linux.intel.com> wrote: >> > On W

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

The dmesg log is here https://gist.github.com/mschiu77/5dfe91ef319de16fb343c5d907b2cbc5 And the acpidump is here https://gist.github.com/mschiu77/d9b72d89a6a21efb616f153f164c0d18 On Fri, Nov 17, 2017 at 4:27 PM, Chris Chiu <c...@endlessm.com> wrote: > On Thu, Nov 16, 2017 at 9:07

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

On Fri, Nov 17, 2017 at 5:11 PM, Mika Westerberg <mika.westerb...@linux.intel.com> wrote: > On Fri, Nov 17, 2017 at 04:27:39PM +0800, Chris Chiu wrote: >> On Thu, Nov 16, 2017 at 9:07 PM, Mika Westerberg >> <mika.westerb...@linux.intel.com> wrote: >> > On T

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

On Thu, Nov 16, 2017 at 8:44 PM, Mika Westerberg <mika.westerb...@linux.intel.com> wrote: > On Wed, Nov 15, 2017 at 06:19:56PM +0800, Chris Chiu wrote: >> Hi Mika, >> I've confirmed with Asus and they said it's the latest BIOS for >> shipment and verified OK on

[PATCH] platform/x86: Add Acer Wireless Radio Control driver

} } Based on code from asus-wireless Signed-off-by: Chris Chiu <c...@endlessm.com> Reviewed-by: João Paulo Rechi Vita <jprv...@endlessm.com> --- drivers/platform/x86/Kconfig | 14 ++ drivers/platform/x86/Makefile| 1 + drivers/platf

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

On Fri, Nov 17, 2017 at 7:00 PM, Mika Westerberg <mika.westerb...@linux.intel.com> wrote: > On Fri, Nov 17, 2017 at 06:01:27PM +0800, Chris Chiu wrote: >> Hi Mika, >> Here's the full dmesg log you need. The touchpad stop reporting at >> the last of the log. >>

[PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

connects to touchpad interrupt is in ACPI mode after resume and no longer work as IRQ. Fix this by saving HOSTSW_OWN register during suspend and restore them at resume. Signed-off-by: Chris Chiu <c...@endlessm.com> --- drivers/pinctrl/intel/pinctrl-intel.c | 22 +- 1 file c

Re: [PATCH] pinctrl: intel: Initialize GPIO properly when used through irqchip

pin to GPIO mode also when it is > used directly through irqchip. > > Reported-by: Daniel Drake <dr...@endlessm.com> > Reported-by: Chris Chiu <c...@endlessm.com> > Signed-off-by: Mika Westerberg <mika.westerb...@linux.intel.com> > --- > Chris, Daniel, > >

Re: [PATCH] platform/x86: Add Acer Wireless Radio Control driver

On Mon, Nov 20, 2017 at 8:24 PM, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > On Mon, Nov 20, 2017 at 8:31 AM, Chris Chiu <c...@endlessm.com> wrote: >> On Fri, Nov 17, 2017 at 10:25 PM, Andy Shevchenko >> <andy.shevche...@gmail.com> wrote: >>> On T

[PATCH v2] platform/x86: Add Acer Wireless Radio Control driver

} } Based on code from asus-wireless Signed-off-by: Chris Chiu <c...@endlessm.com> Reviewed-by: João Paulo Rechi Vita <jprv...@endlessm.com> --- Notes: v2: less code and no redundant data structure drivers/platform/x86/Kconfig | 14 +++ driv

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

On Tue, Nov 21, 2017 at 6:52 PM, Mika Westerberg <mika.westerb...@linux.intel.com> wrote: > On Fri, Nov 17, 2017 at 04:11:31PM +0800, Chris Chiu wrote: >> On Fri, Nov 17, 2017 at 2:49 PM, Mika Westerberg >> <mika.westerb...@linux.intel.com> wrote: >> > On T

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

On Fri, Nov 17, 2017 at 9:52 PM, Mika Westerberg wrote: > On Fri, Nov 17, 2017 at 03:35:18PM +0200, Mika Westerberg wrote: >> > pin 18 (GPIO_18) GPIO 0x40900100 0x00024075 > > Hmm, > > If I decode 0x40900100 correctly PADCFG0_GPIROUTIOXAPIC (BIT 20) flag is > set

Re: [PATCH] platform/x86: Add Acer Wireless Radio Control driver

On Fri, Nov 17, 2017 at 10:25 PM, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > On Thu, Nov 16, 2017 at 3:44 PM, Chris Chiu <c...@endlessm.com> wrote: >> New Acer laptops in 2018 will have a separate ACPI device for >> notifications from the airplane m

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

4:08:32PM +0800, Chris Chiu wrote: >> Yes, that’s the most weird part. > > Sounds pretty much like a BIOS issue. Do you know if there is a newer > BIOS and have you tried that already?

Re: GemniLake laptops goes power off directly after performing suspend

On Tue, Dec 5, 2017 at 11:01 PM, Rafael J. Wysocki <raf...@kernel.org> wrote: > On Tue, Dec 5, 2017 at 11:32 AM, Chris Chiu <c...@endlessm.com> wrote: >> Hi, >> I have 2 GemniLake laptops from ASUS, named X441MB and X507MA, >> both go power off after I do &q

Re: GemniLake laptops goes power off directly after performing suspend

On Wed, Dec 6, 2017 at 9:34 PM, Rafael J. Wysocki <raf...@kernel.org> wrote: > On Wed, Dec 6, 2017 at 10:33 AM, Chris Chiu <c...@endlessm.com> wrote: >> On Wed, Dec 6, 2017 at 5:56 AM, Rafael J. Wysocki <r...@rjwysocki.net> wrote: >>> On Tuesday, December 5,

Re: GemniLake laptops goes power off directly after performing suspend

On Wed, Dec 6, 2017 at 5:56 AM, Rafael J. Wysocki <r...@rjwysocki.net> wrote: > On Tuesday, December 5, 2017 5:19:03 PM CET Chris Chiu wrote: >> On Tue, Dec 5, 2017 at 11:01 PM, Rafael J. Wysocki <raf...@kernel.org> wrote: >> > On Tue, Dec 5, 2017 at 11:32 AM, Chris

TPM driver breaks S3 suspend

Hi, We have a desktop which has S3 suspend (to RAM) problem due to error messages as follows. [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend [ 198.908289] __pnp_bus_suspend(): tpm_pm_suspend+0x0/0x160 returns 38 [ 198.908293] dpm_run_callback(): pnp_bus_suspend+0x0/0x20

Re: TPM driver breaks S3 suspend

On Thu, Dec 21, 2017 at 5:22 PM, Paul Menzel wrote: > Dear Chris, > > > Thank you for bringin gup the issue. > >> We have a desktop which has S3 suspend (to RAM) problem due to >> error messages as follows. >> [ 198.908282] tpm tpm0: Error (38) sending savestate

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

On Fri, May 4, 2018 at 2:55 PM, Jian-Hong Pan wrote: > Hi, > > We have an ASUS X580GD (Intel(R) Core(TM) i5-8300H CPU @ 2.30GHz) laptop > equipped with ELAN1200 touchpad which does not work totally, but the > external mouse works fine. > > We have checked the input devices

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

On Mon, May 14, 2018 at 10:20 PM, Jarkko Nikula <jarkko.nik...@linux.intel.com> wrote: > On 05/10/2018 03:03 PM, Chris Chiu wrote: >> >> Report from guys who can access scope. If i2c-sda-falling-time-ns=400ns >> , HCNT increase to 117, the SCL high duration i

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

On Tue, May 8, 2018 at 11:47 PM, Daniel Drake wrote: > On Tue, May 8, 2018 at 8:31 AM, Jarkko Nikula > wrote: >>> Some update, we can make the touchpad work by simply modifying the >>> clk_rate of spt_i2c_info from 12000 to 13300 in

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

On Thu, May 17, 2018 at 3:48 PM, Jarkko Nikula <jarkko.nik...@linux.intel.com> wrote: > Hi > > On 05/15/2018 01:20 PM, Jarkko Nikula wrote: >> >> On 05/15/2018 06:22 AM, Chris Chiu wrote: >>> >>> What if I change the 120MHz to 180MHz and then make su

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Tue, May 22, 2018 at 5:18 PM, Andy Shevchenko wrote: > On Tue, May 15, 2018 at 4:41 PM, Benjamin Berg wrote: > >> I had a quick chat with Bastien about this. The conclusion was that >> reusing the TOGGLE key may be problematic for

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Tue, May 22, 2018 at 9:48 PM, Daniel Drake <dr...@endlessm.com> wrote: > On Tue, May 22, 2018 at 4:11 AM, Chris Chiu <c...@endlessm.com> wrote: >> On Tue, May 22, 2018 at 5:18 PM, Andy Shevchenko >>> Btw, I mistakenly thought that patch in the queue for-next, whi

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

On Mon, Jun 11, 2018 at 3:18 PM, Chris Chiu wrote: > Make asus-wmi notify on hotkey kbd brightness changes, listen for > brightness events and update the brightness directly in the driver. > For this purpose, bound check on brightness in kbd_led_set must be > based on the sa

[PATCH v2 2/2] platform/x86: asus-wmi: Add keyboard backlight toggle support

the brightness for each keypress, then toggle(off) the LED when it already reached the max level. Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-wmi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index

[PATCH v2 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

by led_classdev_notify_brightness_hw_changed. This will allow userspace to monitor (poll) for brightness changes on the LED without reporting via input keymapping. Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-wmi.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

On Wed, Jun 13, 2018 at 8:49 PM, Andy Shevchenko wrote: > On Mon, Jun 11, 2018 at 10:18 AM, Chris Chiu wrote: >> Make asus-wmi notify on hotkey kbd brightness changes, listen for >> brightness events and update the brightness directly in the driver. > >> For t

[PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

by led_classdev_notify_brightness_hw_changed. This will allow userspace to monitor (poll) for brightness changes on the LED without reporting via input keymapping. Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-nb-wmi.c | 2 -- drivers/platform/x86/asus-wmi.c| 21 +++-- 2 files

[PATCH 2/2] platform/x86: asus-wmi: Add keyboard backlight toggle support

the brightness for each keypress, then toggle(off) the LED when it already reached the max level. Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-wmi.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus

Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart wrote: > On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote: >> Hi, >> >> On 04-06-18 15:51, Daniel Drake wrote: >> > On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote: >> > > Is this really a case of the hardware itself processing the >>

Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

On Tue, Jun 5, 2018 at 7:06 PM, Hans de Goede wrote: > Hi, > > > On 05-06-18 12:46, Benjamin Berg wrote: >> >> Hey, >> >> On Tue, 2018-06-05 at 12:31 +0200, Hans de Goede wrote: >>> >>> On 05-06-18 12:14, Bastien Nocera wrote: On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote:

Re: [PATCH v3 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

On Wed, Jun 20, 2018 at 10:46 PM, Chris Chiu wrote: > Make asus-wmi notify on hotkey kbd brightness changes, listen for > brightness events and update the brightness directly in the driver. > Create new do_kbd_led_set function for in-driver update, and leave > kbd_led_set

[PATCH] platform/x86: asus-wmi: Add keyboard backlight toggle support

to KEY_KBDILLUMUP to increment the brightness, then pass KEY_KBDILLUMTOGGLE to user space after the brightness max been reached for switching the led off. https://phabricator.endlessm.com/T21390 Signed-off-by: Chris Chiu <c...@endlessm.com> --- drivers/platform/x86/asus-nb-wmi.c | 1 + d

Re: [PATCH] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Wed, May 2, 2018 at 10:29 PM, Puma D. <pum...@web.de> wrote: > On 02.05.2018 08:02, Chris Chiu wrote: >> >> Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard >> backlight toggle. In this UX550GE, the hotkey incremet the level >> of brightn

[PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

to KEY_KBDILLUMUP to increment the brightness, then pass KEY_KBDILLUMTOGGLE to user space after the brightness max been reached for switching the led off. Signed-off-by: Chris Chiu <c...@endlessm.com> Signed-off-by: Jian-Hong Pan <jian-h...@endlessm.com> Tested-by: Jian-Hong Pan <jian-h.

Re: TPM driver breaks S3 suspend

On Thu, Dec 21, 2017 at 6:19 PM, wrote: >> Hi, >> We have a desktop which has S3 suspend (to RAM) problem due to >> error messages as follows. >> [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend >> [ 198.908289] __pnp_bus_suspend():

Re: TPM driver breaks S3 suspend

On Mon, Dec 25, 2017 at 4:33 AM, Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> wrote: > On Thu, Dec 21, 2017 at 04:04:56PM +0800, Chris Chiu wrote: >> Hi, >> We have a desktop which has S3 suspend (to RAM) problem due to >> error messages as follows. >> [

Re: r8169 take too long to complete driver initialization

On Wed, Dec 20, 2017 at 4:41 PM, Chris Chiu <c...@endlessm.com> wrote: > Hi, > We've hit a suspend/resume issue on a Acer desktop caused by r8169 > driver. The dmseg > https://gist.github.com/mschiu77/b741849b5070281daaead8dfee312d1a > shows it's still in msleep(

Re: r8169 take too long to complete driver initialization

g for incorrect register bit? Can you help work out a patch for this? Chris >> -Original Message- >> From: Chris Chiu [mailto:c...@endlessm.com] >> Sent: Monday, January 29, 2018 6:12 PM >> To: nic_swsd <nic_s...@realtek.com>; net...@vger.kernel.org; Linux >

Re: r8169 take too long to complete driver initialization

On Fri, Jan 5, 2018 at 10:17 AM, Chris Chiu <c...@endlessm.com> wrote: > On Wed, Dec 20, 2017 at 4:41 PM, Chris Chiu <c...@endlessm.com> wrote: >> Hi, >> We've hit a suspend/resume issue on a Acer desktop caused by r8169 >> driver. The dmseg &g

Re: r8169 take too long to complete driver initialization

On Tue, Jan 30, 2018 at 8:07 PM, Chris Chiu <c...@endlessm.com> wrote: > On Mon, Jan 29, 2018 at 11:24 PM, Hau <h...@realtek.com> wrote: >> Hi Chris, >> >> Could you test following patch? >> >> DECLARE_RTL_COND(rtl_ocp_tx_cond) >>

Re: r8169 take too long to complete driver initialization

On Fri, Feb 2, 2018 at 7:49 PM, Hau <h...@realtek.com> wrote: > >> -Original Message- >> From: Chris Chiu [mailto:c...@endlessm.com] >> Sent: Friday, February 2, 2018 10:03 AM >> To: Hau <h...@realtek.com> >> Cc: nic_swsd <nic_s...@realt

ipmi_si fails to get BMC ID

Hi, We are working with a new desktop Acer Veriton Z4640G and get stumbled on failing to enter S3 suspend with kernel version 4.14 even the latest 4.15+. Here's the kernel log https://gist.github.com/mschiu77/76888f1fd4eb56aa8959d76759a912bb. As you see, it is due to

Re: ipmi_si fails to get BMC ID

On Thu, Feb 8, 2018 at 11:53 PM, Corey Minyard <miny...@acm.org> wrote: > On 02/07/2018 09:01 PM, Chris Chiu wrote: >> >> Hi, >> We are working with a new desktop Acer Veriton Z4640G and get >> stumbled on failing to enter S3 suspend with kernel version 4.14

Re: ipmi_si fails to get BMC ID

On Fri, Feb 9, 2018 at 9:34 PM, Corey Minyard <miny...@acm.org> wrote: > On 02/08/2018 09:09 PM, Chris Chiu wrote: >> >> On Thu, Feb 8, 2018 at 11:53 PM, Corey Minyard <miny...@acm.org> wrote: >>> >>> On 02/07/2018 09:01 PM, Chris Chiu wrote: >&

Re: ipmi_si fails to get BMC ID

On Thu, Feb 15, 2018 at 1:17 AM, Corey Minyard <miny...@acm.org> wrote: > I'm removing Greg and Arnd from the email, I don't think this requires their > participation. > > > > > On 02/13/2018 08:44 PM, Chris Chiu wrote: >> >> On Fri, Feb 9, 2018 at 9:34 PM

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

On Wed, Jun 20, 2018 at 12:46 AM, Daniel Drake wrote: > Hi, > > On Thu, Jun 14, 2018 at 1:58 AM, Chris Chiu wrote: >> >> On Wed, Jun 13, 2018 at 8:49 PM, Andy Shevchenko >> wrote: >> > On Mon, Jun 11, 2018 at 10:18 AM, Chris Chiu wrote: >> >&g

[PATCH v3 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

by led_classdev_notify_brightness_hw_changed. This will allow userspace to monitor (poll) for brightness changes on the LED without reporting via input keymapping. Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-wmi.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git

[PATCH v3 2/2] platform/x86: asus-wmi: Add keyboard backlight toggle support

the brightness for each keypress, then toggle(off) the LED when it already reached the max level. Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-wmi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

On Thu, Jun 14, 2018 at 2:58 PM, Chris Chiu wrote: > On Wed, Jun 13, 2018 at 8:49 PM, Andy Shevchenko > wrote: >> On Mon, Jun 11, 2018 at 10:18 AM, Chris Chiu wrote: >>> Make asus-wmi notify on hotkey kbd brightness changes, listen for >>> brightness events and

Built in PS2 keyboard in new ASUS/acer laptops can not wake up system after s2idle

Hi guys, We have some new laptops with Intel new Intel WiskyLake CPU come in and they all have the same problem. They all have the so-called "Modern Standby" feature which is s2idle in Linux. The problem is the built-in keyboard no longer wake up the system after it goes to s2idle. Only

Re: [PATCH v3 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

On Mon, Jul 2, 2018 at 8:10 PM, Andy Shevchenko wrote: > On Wed, Jun 27, 2018 at 1:27 PM, Chris Chiu wrote: >> On Wed, Jun 20, 2018 at 10:46 PM, Chris Chiu wrote: >>> Make asus-wmi notify on hotkey kbd brightness changes, listen for >>> brightness events and upd

Re: [PATCH v3 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

On Wed, Aug 15, 2018 at 5:45 PM, Andy Shevchenko wrote: > On Wed, Aug 15, 2018 at 12:34 PM, Chris Chiu wrote: >> On Mon, Jul 2, 2018 at 8:10 PM, Andy Shevchenko >> wrote: >>> On Wed, Jun 27, 2018 at 1:27 PM, Chris Chiu wrote: >>>> On Wed, Jun 20, 2018 at 10:

Keyboard lost after exit s2idle on ASUS UX433FN

Hi, We recently hit a weird problem on the ASUS laptop UX433FN with latest Intel Core i7-8565U CPU on kernel 4.18. The keyboard stops functioning after exit s2idle. It stops firing interrupts after resume on any keypress. We thought it should be something wrong with i8042 driver or even atkbd

Re: Keyboard lost after exit s2idle on ASUS UX433FN

On Thu, Aug 16, 2018 at 3:26 PM, Rafael J. Wysocki wrote: > On Thu, Aug 16, 2018 at 4:45 AM Chris Chiu wrote: >> >> Hi, >> We recently hit a weird problem on the ASUS laptop UX433FN with >> latest Intel Core i7-8565U CPU on kernel 4.18. The keyboard stops >&

Re: Keyboard lost after exit s2idle on ASUS UX433FN

On Thu, Aug 16, 2018 at 4:54 PM, Rafael J. Wysocki wrote: > On Thu, Aug 16, 2018 at 10:18 AM Chris Chiu wrote: >> >> On Thu, Aug 16, 2018 at 3:26 PM, Rafael J. Wysocki wrote: >> > On Thu, Aug 16, 2018 at 4:45 AM Chris Chiu wrote: >> >> >> >&g

Re: Built in PS2 keyboard in new ASUS/acer laptops can not wake up system after s2idle

On Mon, Aug 6, 2018 at 5:37 PM, Rafael J. Wysocki wrote: > On Friday, August 3, 2018 10:04:09 AM CEST Chris Chiu wrote: >> Hi guys, >> We have some new laptops with Intel new Intel WiskyLake CPU come >> in and they all have the same problem. They all have the so-call

Intel GemniLake xHCI connected devices can never wake up the system from suspend

Hi, I have a ASUS AIO V222GA and another Acer Desktop XC-830 both have Intel CPU J5005 and they both hit the same problem. The XHCI connected USB keyboard/mouse can never wakeup the system from suspend. It reminds me that similiar thing happens on ApolloLake too which needs the

Re: Intel GemniLake xHCI connected devices can never wake up the system from suspend

On Thu, Mar 15, 2018 at 7:46 PM, Mathias Nyman <mathias.ny...@linux.intel.com> wrote: > On 15.03.2018 06:40, Chris Chiu wrote: >> >> Hi, >> I have a ASUS AIO V222GA and another Acer Desktop XC-830 both >> have Intel CPU J5005 and they both hit the same p

[PATCH] ACPI / PM: Fix wake up by PS2 keyboard fail on ASUS UX331UA

interrupt completion. Signed-off-by: Chris Chiu <c...@endlessm.com> --- drivers/acpi/sleep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index 8082871..c6e1b4b 100644 --- a/drivers/acpi/sleep.c +++ b/drivers/acpi/sleep.c @@

[PATCH] ACPI / PM: Fix wake up by PS2 keyboard fail on ASUS UX331UA

interrupt completion. Signed-off-by: Chris Chiu <c...@endlessm.com> https://phabricator.endlessm.com/T21599 --- drivers/acpi/sleep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index 8082871..c6e1b4b 100644 --- a/drivers/acpi/s

[PATCH 1/2] HID: use macros in IS_INPUT_APPLICATION

Add missing definition for HID_DG_WHITEBOARD then replace the hid usage hex with macros for better readibility. Signed-off-by: Chris Chiu --- include/linux/hid.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/include/linux/hid.h b/include/linux/hid.h index a355d61940f2

[PATCH 2/2] HID: input: support Microsoft wireless radio control hotkey

the HID I2C vendor and product id to the quirk list and apply HID_QUIRK_HIDINPUT_FORCE to make it work. But it makes more sense to support it as a generic input application. Signed-off-by: Chris Chiu --- include/linux/hid.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include

Re: [PATCH] HID: input: support Microsoft wireless radio control hotkey

On Wed, Dec 5, 2018 at 8:56 AM Chris Chiu wrote: > > On Fri, Nov 30, 2018 at 7:18 PM Benjamin Tissoires > wrote: > > > > On Fri, Nov 30, 2018 at 7:46 AM Chris Chiu wrote: > > > > > > The ASUS laptops start to support the airplane mode radio management

[PATCH] HID: input: support Microsoft wireless radio control hotkey

to add the HID I2C vendor and product id to the quirk list and apply HID_QUIRK_HIDINPUT_FORCE to make it work. But it can be more generic to support such kind of application on PC. Signed-off-by: Chris Chiu --- include/linux/hid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] HID: input: support Microsoft wireless radio control hotkey

On Fri, Nov 30, 2018 at 7:18 PM Benjamin Tissoires wrote: > > On Fri, Nov 30, 2018 at 7:46 AM Chris Chiu wrote: > > > > The ASUS laptops start to support the airplane mode radio management > > to replace the original machanism of airplane mode toggle hotkey. > > On

Intel GemniLake xHCI connected devices can never wake up the system from suspend

Hi, I have a ASUS AIO V222GA and another Acer Desktop XC-830 both have Intel CPU J5005 and they both hit the same problem. The XHCI connected USB keyboard/mouse can never wakeup the system from suspend. It reminds me that similiar thing happens on ApolloLake too which needs the

Re: ipmi_si fails to get BMC ID

On Fri, Feb 9, 2018 at 9:34 PM, Corey Minyard wrote: > On 02/08/2018 09:09 PM, Chris Chiu wrote: >> >> On Thu, Feb 8, 2018 at 11:53 PM, Corey Minyard wrote: >>> >>> On 02/07/2018 09:01 PM, Chris Chiu wrote: >>>> >>>> Hi, >>>>

Re: Intel GemniLake xHCI connected devices can never wake up the system from suspend

On Thu, Mar 15, 2018 at 7:46 PM, Mathias Nyman wrote: > On 15.03.2018 06:40, Chris Chiu wrote: >> >> Hi, >> I have a ASUS AIO V222GA and another Acer Desktop XC-830 both >> have Intel CPU J5005 and they both hit the same problem. The XHCI >> connected US

Re: ipmi_si fails to get BMC ID

On Thu, Feb 15, 2018 at 1:17 AM, Corey Minyard wrote: > I'm removing Greg and Arnd from the email, I don't think this requires their > participation. > > > > > On 02/13/2018 08:44 PM, Chris Chiu wrote: >> >> On Fri, Feb 9, 2018 at 9:34 PM, Corey Minyard wrot

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

On Mon, May 14, 2018 at 10:20 PM, Jarkko Nikula wrote: > On 05/10/2018 03:03 PM, Chris Chiu wrote: >> >> Report from guys who can access scope. If i2c-sda-falling-time-ns=400ns >> , HCNT increase to 117, the SCL high duration is 576ns as follows >> https:

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

On Fri, May 4, 2018 at 2:55 PM, Jian-Hong Pan wrote: > Hi, > > We have an ASUS X580GD (Intel(R) Core(TM) i5-8300H CPU @ 2.30GHz) laptop > equipped with ELAN1200 touchpad which does not work totally, but the > external mouse works fine. > > We have checked the input devices by "cat

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

On Tue, May 8, 2018 at 11:47 PM, Daniel Drake wrote: > On Tue, May 8, 2018 at 8:31 AM, Jarkko Nikula > wrote: >>> Some update, we can make the touchpad work by simply modifying the >>> clk_rate of spt_i2c_info from 12000 to 13300 in intel-lpss-pci.c for >>> specific PCI ID 8086:a368 ~

[PATCH] platform/x86: asus-wmi: Add keyboard backlight toggle support

to KEY_KBDILLUMUP to increment the brightness, then pass KEY_KBDILLUMTOGGLE to user space after the brightness max been reached for switching the led off. https://phabricator.endlessm.com/T21390 Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-nb-wmi.c | 1 + drivers/platform/x86/asus-wmi.c

Re: [PATCH] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Wed, May 2, 2018 at 10:29 PM, Puma D. wrote: > On 02.05.2018 08:02, Chris Chiu wrote: >> >> Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard >> backlight toggle. In this UX550GE, the hotkey incremet the level >> of brightness for each keypress f

[PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

to KEY_KBDILLUMUP to increment the brightness, then pass KEY_KBDILLUMTOGGLE to user space after the brightness max been reached for switching the led off. Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan Tested-by: Jian-Hong Pan --- Notes: v2: - Remove redundant 'else' branch logic

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

On Thu, May 17, 2018 at 3:48 PM, Jarkko Nikula wrote: > Hi > > On 05/15/2018 01:20 PM, Jarkko Nikula wrote: >> >> On 05/15/2018 06:22 AM, Chris Chiu wrote: >>> >>> What if I change the 120MHz to 180MHz and then make sure that the I2C >>> operates

r8169 take too long to complete driver initialization

Hi, We've hit a suspend/resume issue on a Acer desktop caused by r8169 driver. The dmseg https://gist.github.com/mschiu77/b741849b5070281daaead8dfee312d1a shows it's still in msleep() within a mutex lock. After looking into the code, it's caused by the rtl8168ep_stop_cmac() which is

TPM driver breaks S3 suspend

Hi, We have a desktop which has S3 suspend (to RAM) problem due to error messages as follows. [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend [ 198.908289] __pnp_bus_suspend(): tpm_pm_suspend+0x0/0x160 returns 38 [ 198.908293] dpm_run_callback(): pnp_bus_suspend+0x0/0x20

Re: r8169 take too long to complete driver initialization

On Wed, Dec 20, 2017 at 4:41 PM, Chris Chiu wrote: > Hi, > We've hit a suspend/resume issue on a Acer desktop caused by r8169 > driver. The dmseg > https://gist.github.com/mschiu77/b741849b5070281daaead8dfee312d1a > shows it's still in msleep() within a mutex lock. >

GemniLake laptops goes power off directly after performing suspend

Hi, I have 2 GemniLake laptops from ASUS, named X441MB and X507MA, both go power off after I do "systemctl suspend" on top of kerne head fd6d2e506ce6 (Merge tag 'docs-4.15-fixes' of git://git.lwn.net/linux). I then wipe it out and install Windows RS3 instead, also goes to power off after

Re: GemniLake laptops goes power off directly after performing suspend

On Tue, Dec 5, 2017 at 11:01 PM, Rafael J. Wysocki wrote: > On Tue, Dec 5, 2017 at 11:32 AM, Chris Chiu wrote: >> Hi, >> I have 2 GemniLake laptops from ASUS, named X441MB and X507MA, >> both go power off after I do "systemctl suspend" on top of kerne head &

Re: GemniLake laptops goes power off directly after performing suspend

On Wed, Dec 6, 2017 at 5:56 AM, Rafael J. Wysocki wrote: > On Tuesday, December 5, 2017 5:19:03 PM CET Chris Chiu wrote: >> On Tue, Dec 5, 2017 at 11:01 PM, Rafael J. Wysocki wrote: >> > On Tue, Dec 5, 2017 at 11:32 AM, Chris Chiu wrote: >> >> Hi, >> >>

Re: TPM driver breaks S3 suspend

On Thu, Dec 21, 2017 at 5:22 PM, Paul Menzel wrote: > Dear Chris, > > > Thank you for bringin gup the issue. > >> We have a desktop which has S3 suspend (to RAM) problem due to >> error messages as follows. >> [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend >> [

Re: TPM driver breaks S3 suspend

On Thu, Dec 21, 2017 at 6:19 PM, wrote: >> Hi, >> We have a desktop which has S3 suspend (to RAM) problem due to >> error messages as follows. >> [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend >> [ 198.908289] __pnp_bus_suspend(): tpm_pm_suspend+0x0/0x160 returns >> 38

Re: TPM driver breaks S3 suspend

On Mon, Dec 25, 2017 at 4:33 AM, Jarkko Sakkinen wrote: > On Thu, Dec 21, 2017 at 04:04:56PM +0800, Chris Chiu wrote: >> Hi, >> We have a desktop which has S3 suspend (to RAM) problem due to >> error messages as follows. >> [ 198.908282] tpm tpm0: Error (38) sendi

[PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

connects to touchpad interrupt is in ACPI mode after resume and no longer work as IRQ. Fix this by saving HOSTSW_OWN register during suspend and restore them at resume. Signed-off-by: Chris Chiu --- drivers/pinctrl/intel/pinctrl-intel.c | 22 +- 1 file changed, 21 insertions

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

On Fri, Nov 17, 2017 at 9:52 PM, Mika Westerberg wrote: > On Fri, Nov 17, 2017 at 03:35:18PM +0200, Mika Westerberg wrote: >> > pin 18 (GPIO_18) GPIO 0x40900100 0x00024075 > > Hmm, > > If I decode 0x40900100 correctly PADCFG0_GPIROUTIOXAPIC (BIT 20) flag is > set for the pin. This means the

  1   2   3   4   >