[PATCH] usb: Fix typo in `struct usb_host_interface' comment

The descriptor member `bNumEndpoints' is plural. Signed-off-by: Chris Rorvick --- include/linux/usb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/usb.h b/include/linux/usb.h index f89c24a..4add566 100644 --- a/include/linux/usb.h +++ b/include/linux/

Re: [PATCH] usb: Fix typo in `struct usb_host_interface' comment

On Thu, Jan 15, 2015 at 5:03 AM, Oliver Neukum wrote: > On Wed, 2015-01-14 at 21:52 -0600, Chris Rorvick wrote: >> The descriptor member `bNumEndpoints' is plural. > > I am afraid that is not a good idea. The name of a > member of a structure mentioned in the specificatio

Re: [PATCH] usb: Fix typo in `struct usb_host_interface' comment

On Thu, Jan 15, 2015 at 6:54 AM, Chris Rorvick wrote: > On Thu, Jan 15, 2015 at 5:03 AM, Oliver Neukum wrote: >> On Wed, 2015-01-14 at 21:52 -0600, Chris Rorvick wrote: >>> The descriptor member `bNumEndpoints' is plural. >> >> I am afraid that is not a good

[PATCH 00/25] line6usb cleanup

idate configuration settings into the properties entries and use function pointers setup at initialization to remove much of the conditional logic. I have a TonePort UX2 that I've used for testing, meaning that some of this is really only compile-tested. Regards, Chris Chris Rorvick (25): stag

[PATCH 15/25] staging: line6: Filter on Pocket POD interface

The driver only supports interface 1 of the Pocket POD. Use the device table to filter on this. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/staging/line6/driver.c b/drivers/staging

[PATCH 06/25] staging: line6: Index properties array with device type

c and use the device type (via the .driver_info member) instead. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c index 2797e41..c0

[PATCH 02/25] staging: line6: Remove line6_pod_transmit_paramter()

This function was no longer used as of commit 2807904441d4 (staging: line6: drop MIDI parameter sysfs attrs). Signed-off-by: Chris Rorvick --- drivers/staging/line6/pod.c | 9 - drivers/staging/line6/pod.h | 2 -- 2 files changed, 11 deletions(-) diff --git a/drivers/staging/line6

[PATCH 01/25] staging: line6: Remove `device_bit' from properties

The `device_bit' member was no longer used as of commit 2807904441d4 (staging: line6: drop MIDI parameter sysfs attrs). Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 44 +++--- drivers/staging/line6/driver.h | 5 drivers/staging/line6/

[PATCH 23/25] staging: line6: Call *_process_message() via pointer

Which *_process_message() function (if any) to call when data is received is known at initialization. Add a function pointer to the `usb_line6' struct and use to call into the appropriate logic instead of evaluating the conditional logic for each message. Signed-off-by: Chris Ro

[PATCH 25/25] staging: line6: Make *_disconnect() functions static

Remove declarations from the header and move the definitions up in the source so they need not be forward declared. Signed-off-by: Chris Rorvick --- drivers/staging/line6/pod.c | 58 ++-- drivers/staging/line6/pod.h | 1 - drivers/staging/line6/podhd.c

[PATCH 22/25] staging: line6: Pass *_process_message() `usb_line6' pointers

Casting the `struct usb_line6' pointer at the call point makes the code difficult to read. This is substantially cleaned up by moving the cast into the callees. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 13 - drivers/staging/line6/pod.c| 3 ++- dr

[PATCH 19/25] staging: line6: Remove stale Pocket POD PCM endpoints

Commit 1027f476f507 (staging: line6: sync with upstream) removed PCM from the Pocket POD capabilities but left the endpoint configuration. Signed-off-by: Chris Rorvick --- drivers/staging/line6/pcm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/line6/pcm.c b/drivers

[PATCH 21/25] staging: line6: Pass *_init() `usb_line6' pointers

Casting the `struct usb_line6' pointer at the call point makes the code difficult to read. This is substantially cleaned up by moving the cast into the callees. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 21 ++--- drivers/staging/line6/pod.c

[PATCH 24/25] staging: line6: Call *_disconnect() via pointer

Which *_disconnect() to call on disconnect is known at initialization. Add a function pointer to the `usb_line6' struct and use to call into the appropriate logic instead of evaluating the conditional logic. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c

[PATCH 20/25] staging: line6: Move audio endpoints to properties

The device type can now be used to determine the addresses of the audio endpoints for the interface. Drop the conditional logic and make these values properties. Signed-off-by: Chris Rorvick --- drivers/staging/line6/capture.c | 9 drivers/staging/line6/driver.c | 38

[PATCH 17/25] staging: line6: Move altsetting to properties

The device type can now be used to determine the altsetting for the interface. Drop the conditional logic and make this value a property. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 74 +- drivers/staging/line6/driver.h | 2 ++ 2

[PATCH 18/25] staging: line6: Move control endpoints to properties

The device type can now be used to determine the addresses of the control endpoints for the interface. Drop the conditional logic and make these values properties. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 73 +- drivers/staging

[PATCH 14/25] staging: line6: Split out POD HD500 interfaces

The driver uses a different altsetting depending on the interface. Add device type entries for each of these. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 41 - drivers/staging/line6/driver.h | 3 ++- drivers/staging/line6/pcm.c

[PATCH 13/25] staging: line6: Split out PODxt Live interfaces

The PODxt Live device has both a POD and a Variax interface. Add device type entries for each of these. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 112 - drivers/staging/line6/driver.h | 8 +-- drivers/staging/line6/pcm.c

[PATCH 16/25] staging: line6: Filter on UX2 interfaces

The driver only supports interface 0 of the TonePort UX2 and POD Studio UX2 devices. Use the device table to filter on this. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/staging

[PATCH 05/25] staging: line6: Define a device type enum

Define an enum containing the supported devices and associate each entry in the device table to the respective value. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 54 -- drivers/staging/line6/driver.h | 21 2 files

[PATCH 12/25] staging: line6: List out capabilities individually

igned-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 54 +++-- drivers/staging/line6/usbdefs.h | 4 --- 2 files changed, 36 insertions(+), 22 deletions(-) diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c index c988b78..6f

[PATCH 11/25] staging: line6: Use explicit indexes when defining properties

Specify the index of the properties entry explicitly to define this structure more robustly. Also, drop the `L6PROP' macro in favor of initializing each member explicitly on its own line since horizontal space is limited and more attributes will be added later. Signed-off-by: Chris Ro

[PATCH 10/25] staging: line6: Rename capability macros

Including "BIT" in the macro name is pointless. Replace with "CAP" to provide some context for what its value represents. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 8 drivers/staging/line6/midi.c | 2 +- drivers/staging/line6/pcm.c

[PATCH 04/25] staging: line6: Cleanup device table

Wrap USB_DEVICE to avoid repeating the Line 6 vendor ID. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c

[PATCH 08/25] staging: line6: Remove idVendor and idProduct macros

These are now only used to build the device table. Each entry in this table is already clearly documented as to what device it maps to so the macros become unnecessary indirection. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 56

[PATCH 09/25] staging: line6: Remove useless comments

Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c index 6dc8a0d..acde205 100644 --- a/drivers/staging/line6/driver.c +++ b/drivers/staging/line6/driver.c @@ -61,7

[PATCH 03/25] staging: line6: Remove unsupported X3 devices

Support for these devices appears to have never been completed. Remove them from the device table along with a minimal amount of supporting code. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 26 -- drivers/staging/line6/pcm.c | 2 -- drivers

[PATCH 07/25] staging: line6: Key off of device type

hat map to specific interfaces on the device so that this conditional logic can be flattened out. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 203 --- drivers/staging/line6/driver.h | 4 +- drivers/staging/line6/pcm.c | 38 ---

Re: [PATCH] checkpatch: Update git commit message

orgetting to quote the commit summary. Running checkpatch with this makes the problem clear. Tested-by: Chris Rorvick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.o

Re: [PATCH 00/25] line6usb cleanup

> At Fri, 9 Jan 2015 23:35:46 -0600, > Chris Rorvick wrote: >> >> I have a TonePort UX2 that I've used for testing, meaning that some of >> this is really only compile-tested. > > If anyone is responsible for testing with real hardware, I'll happily >

[PATCH v4 0/2] lprocfs_write_frac_u64_helper cleanup

mult'. Compile tested only. Chris Rorvick (2): staging: lustre: Use mult if units not specified staging: lustre: Track sign separately drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.1.0 -- To unsubscribe from

[PATCH v4 1/2] staging: lustre: Use mult if units not specified

hat it only applies when units are specified. Signed-off-by: Chris Rorvick Reviewed-by: Andreas Dilger --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b

[PATCH v4 2/2] staging: lustre: Track sign separately

suffix is specified, but having the effect of taking the absolute value of the user-provided data. Signed-off-by: Chris Rorvick Reviewed-by: Andreas Dilger --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/st

Re: [PATCH] tipc: link: Remove unused function

On Sat, Jan 17, 2015 at 10:13 AM, Rickard Strandqvist wrote: > Remove the function tipc_link_get_max_pkt() that is not used anywhere. This is already in the next tree: commit 54fef04ad05f15984082c225fe47ce6af8ea1c5c Author: Ying Xue Date: Fri Jan 9 15:27:03 2015 +0800 tipc: remove unused

[RFC RESEND 00/10] Create separate header for ehci-dbgp driver

parameters. Regards, Chris Rorvick Chris Rorvick (10): usb: Create separate header for ehci-dbgp fusbh200: Make Xen notificaiton consistent with EHCI fusbh200: Remove superfluous macro definitions fusbh200: Remove duplicate ehci-dbgp declarations fusbh200: Use ehci_dbg_port struct fot

[RFC RESEND 10/10] usb: Remove __init from early_dbgp_init() prototype

: https://lkml.org/lkml/2006/1/14/305 Signed-off-by: Chris Rorvick --- include/linux/usb/ehci-dbgp.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/usb/ehci-dbgp.h b/include/linux/usb/ehci-dbgp.h index 796c1cd..7344d9e 100644 --- a/include/linux/usb/ehci

[RFC RESEND 09/10] fotg210: Use ehci_dbg_port struct

The FUSBH200 debug port has a EHCI-compatible register layout so there is no need to define a custom struct. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/fotg210.h b/drivers/usb

[RFC RESEND 08/10] fotg210: Remove duplicate ehci-dbgp declarations

Now that ehci-dbgp has its own header, use it rather than duplicating the declarations, etc. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 40 ++-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/usb/host/fotg210.h b

[RFC RESEND 03/10] fusbh200: Remove superfluous macro definitions

The fusbh200_dbg_port struct is a copy of the ehci_dbg_port definition in the header. Embedded in this definition are a number of macros which came along for the ride. These macros are not used in the fusbh200 driver and will conflict those in the new header. Signed-off-by: Chris Rorvick

[RFC RESEND 07/10] fotg210: Remove superfluous macro definitions

The fotg210_dbg_port struct is a copy of the ehci_dbg_port definition in the header. Embedded in this definition are a number of macros which came along for the ride. These macros are not used in the fotg210 driver and will conflict those in the new header. Signed-off-by: Chris Rorvick

[RFC RESEND 01/10] usb: Create separate header for ehci-dbgp

first step towards removing this redundancy. Signed-off-by: Chris Rorvick --- include/linux/usb/ehci-dbgp.h | 84 +++ include/linux/usb/ehci_def.h | 65 ++--- 2 files changed, 86 insertions(+), 63 deletions(-) create mode 100644

[RFC RESEND 04/10] fusbh200: Remove duplicate ehci-dbgp declarations

Now that ehci-dbgp has its own header, use it rather than duplicating the declarations, etc. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 40 ++-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/usb/host/fusbh200.h b

[RFC RESEND 06/10] fotg210: Make Xen notificaiton consistent with EHCI

consistent with ehci-dbgp as a step towards consolidating this code duplication. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/host/fotg210.h b/drivers/usb/host/fotg210.h index ac6cd1b..98c9670 100644 --- a/drivers

[RFC RESEND 05/10] fusbh200: Use ehci_dbg_port struct

The FUSBH200 debug port has a EHCI-compatible register layout so there is no need to define a custom struct. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/fusbh200.h b/drivers/usb

[RFC RESEND 02/10] fusbh200: Make Xen notificaiton consistent with EHCI

fusbh200 consistent with ehci-dbgp as a step towards consolidating this code duplication. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/host/fusbh200.h b/drivers/usb/host/fusbh200.h index 6b719e0..6e7b8c1 100644 --- a

[RFC 04/10] fusbh200: Remove duplicate ehci-dbgp declarations

Now that ehci-dbgp has its own header, use it rather than duplicating the declarations, etc. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 40 ++-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/usb/host/fusbh200.h b

[RFC 10/10] usb: Remove __init from early_dbgp_init() prototype

: https://lkml.org/lkml/2006/1/14/305 Signed-off-by: Chris Rorvick --- include/linux/usb/ehci-dbgp.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/usb/ehci-dbgp.h b/include/linux/usb/ehci-dbgp.h index 796c1cd..7344d9e 100644 --- a/include/linux/usb/ehci

[RFC 06/10] fotg210: Make Xen notificaiton consistent with EHCI

consistent with ehci-dbgp as a step towards consolidating this code duplication. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/host/fotg210.h b/drivers/usb/host/fotg210.h index ac6cd1b..98c9670 100644 --- a/drivers

[RFC 09/10] fotg210: Use ehci_dbg_port struct

The FUSBH200 debug port has a EHCI-compatible register layout so there is no need to define a custom struct. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/fotg210.h b/drivers/usb

[RFC 05/10] fusbh200: Use ehci_dbg_port struct

The FUSBH200 debug port has a EHCI-compatible register layout so there is no need to define a custom struct. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/fusbh200.h b/drivers/usb

[RFC 07/10] fotg210: Remove superfluous macro definitions

The fotg210_dbg_port struct is a copy of the ehci_dbg_port definition in the header. Embedded in this definition are a number of macros which came along for the ride. These macros are not used in the fotg210 driver and will conflict those in the new header. Signed-off-by: Chris Rorvick

[RFC 08/10] fotg210: Remove duplicate ehci-dbgp declarations

Now that ehci-dbgp has its own header, use it rather than duplicating the declarations, etc. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 40 ++-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/usb/host/fotg210.h b

[RFC 02/10] fusbh200: Make Xen notificaiton consistent with EHCI

fusbh200 consistent with ehci-dbgp as a step towards consolidating this code duplication. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/host/fusbh200.h b/drivers/usb/host/fusbh200.h index 6b719e0..6e7b8c1 100644 --- a

[RFC 03/10] fusbh200: Remove superfluous macro definitions

The fusbh200_dbg_port struct is a copy of the ehci_dbg_port definition in the header. Embedded in this definition are a number of macros which came along for the ride. These macros are not used in the fusbh200 driver and will conflict those in the new header. Signed-off-by: Chris Rorvick

[RFC 01/10] usb: Create separate header for ehci-dbgp

first step towards removing this redundancy. Signed-off-by: Chris Rorvick --- include/linux/usb/ehci-dbgp.h | 84 +++ include/linux/usb/ehci_def.h | 65 ++--- 2 files changed, 86 insertions(+), 63 deletions(-) create mode 100644

[RFC 00/10] Create separate header for ehci-dbgp driver

solidation. As I said above, I am not able to actually test these changes on either controller. First time submission, so I look forward to any feedback. If this is of any interest I will work on testing the various configations and boot parameters. Regards, Chris Rorvick Chris Rorvick (

[PATCH 10/10] usb: Remove __init from early_dbgp_init() prototype

: https://lkml.org/lkml/2006/1/14/305 Signed-off-by: Chris Rorvick --- include/linux/usb/ehci-dbgp.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/usb/ehci-dbgp.h b/include/linux/usb/ehci-dbgp.h index 796c1cd..7344d9e 100644 --- a/include/linux/usb/ehci

[PATCH 08/10] fotg210: Remove duplicate ehci-dbgp declarations

Now that ehci-dbgp has its own header, use it rather than duplicating the declarations, etc. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 40 ++-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/usb/host/fotg210.h b

[PATCH 05/10] fusbh200: Use ehci_dbg_port struct

The FUSBH200 debug port has a EHCI-compatible register layout so there is no need to define a custom struct. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/fusbh200.h b/drivers/usb

[PATCH 09/10] fotg210: Use ehci_dbg_port struct

The FUSBH200 debug port has a EHCI-compatible register layout so there is no need to define a custom struct. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/fotg210.h b/drivers/usb

[PATCH 07/10] fotg210: Remove superfluous macro definitions

The fotg210_dbg_port struct is a copy of the ehci_dbg_port definition in the header. Embedded in this definition are a number of macros which came along for the ride. These macros are not used in the fotg210 driver and will conflict those in the new header. Signed-off-by: Chris Rorvick

[PATCH 06/10] fotg210: Make Xen notification consistent with EHCI

consistent with ehci-dbgp as a step towards consolidating this code duplication. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/host/fotg210.h b/drivers/usb/host/fotg210.h index ac6cd1b..98c9670 100644 --- a/drivers

[PATCH 02/10] fusbh200: Make Xen notificaiton consistent with EHCI

fusbh200 consistent with ehci-dbgp as a step towards consolidating this code duplication. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/host/fusbh200.h b/drivers/usb/host/fusbh200.h index 6b719e0..6e7b8c1 100644 --- a

[PATCH 04/10] fusbh200: Remove duplicate ehci-dbgp declarations

Now that ehci-dbgp has its own header, use it rather than duplicating the declarations, etc. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 40 ++-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/usb/host/fusbh200.h b

[PATCH 00/10] Create separate header for ehci-dbgp driver

necessary declarations from , each driver copies this code into their own header. The goal of this series is to pull the ehci-dbgp related code into its own header to remove the need for this redundancy. Regards, Chris Rorvick Chris Rorvick (10): usb: Create separate header for ehci-dbgp

[PATCH 01/10] usb: Create separate header for ehci-dbgp

first step towards removing this redundancy. Signed-off-by: Chris Rorvick --- include/linux/usb/ehci-dbgp.h | 84 +++ include/linux/usb/ehci_def.h | 65 ++--- 2 files changed, 86 insertions(+), 63 deletions(-) create mode 100644

[PATCH 03/10] fusbh200: Remove superfluous macro definitions

The fusbh200_dbg_port struct is a copy of the ehci_dbg_port definition in the header. Embedded in this definition are a number of macros which came along for the ride. These macros are not used in the fusbh200 driver and will conflict those in the new header. Signed-off-by: Chris Rorvick

Re: [RFC RESEND 00/10] Create separate header for ehci-dbgp driver

On Mon, Nov 3, 2014 at 5:09 PM, Greg Kroah-Hartman wrote: > It deletes lines of code overall, which looks good to me. Feel free to > resend without the "RFC" and I will queue it up. > > thanks, > > greg k-h Done. I went through the patches by hand to double check spelling based on Daniele catch

[PATCH] oprofile: Fix grammar in Kconfig help.

"user" does not start with a vowel sound, thus "a user" is correct. https://owl.english.purdue.edu/owl/resource/591/01/ Signed-off-by: Chris Rorvick --- arch/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/Kconfig b/arch/Kconfig index 97f

[RFC RESEND 01/10] usb: Create separate header for ehci-dbgp

first step towards removing this redundancy. Signed-off-by: Chris Rorvick --- include/linux/usb/ehci-dbgp.h | 84 +++ include/linux/usb/ehci_def.h | 65 ++--- 2 files changed, 86 insertions(+), 63 deletions(-) create mode 100644

[RFC RESEND 10/10] usb: Remove __init from early_dbgp_init() prototype

: https://lkml.org/lkml/2006/1/14/305 Signed-off-by: Chris Rorvick --- include/linux/usb/ehci-dbgp.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/usb/ehci-dbgp.h b/include/linux/usb/ehci-dbgp.h index 796c1cd..7344d9e 100644 --- a/include/linux/usb/ehci

[RFC RESEND 08/10] fotg210: Remove duplicate ehci-dbgp declarations

Now that ehci-dbgp has its own header, use it rather than duplicating the declarations, etc. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 40 ++-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/usb/host/fotg210.h b

[RFC RESEND 04/10] fusbh200: Remove duplicate ehci-dbgp declarations

Now that ehci-dbgp has its own header, use it rather than duplicating the declarations, etc. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 40 ++-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/usb/host/fusbh200.h b

[RFC RESEND 09/10] fotg210: Use ehci_dbg_port struct

The FUSBH200 debug port has a EHCI-compatible register layout so there is no need to define a custom struct. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/fotg210.h b/drivers/usb

[RFC RESEND 02/10] fusbh200: Make Xen notificaiton consistent with EHCI

fusbh200 consistent with ehci-dbgp as a step towards consolidating this code duplication. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/host/fusbh200.h b/drivers/usb/host/fusbh200.h index 6b719e0..6e7b8c1 100644 --- a

[RFC RESEND 07/10] fotg210: Remove superfluous macro definitions

The fotg210_dbg_port struct is a copy of the ehci_dbg_port definition in the header. Embedded in this definition are a number of macros which came along for the ride. These macros are not used in the fotg210 driver and will conflict those in the new header. Signed-off-by: Chris Rorvick

[RFC RESEND 06/10] fotg210: Make Xen notificaiton consistent with EHCI

consistent with ehci-dbgp as a step towards consolidating this code duplication. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/host/fotg210.h b/drivers/usb/host/fotg210.h index ac6cd1b..98c9670 100644 --- a/drivers

[RFC RESEND 03/10] fusbh200: Remove superfluous macro definitions

The fusbh200_dbg_port struct is a copy of the ehci_dbg_port definition in the header. Embedded in this definition are a number of macros which came along for the ride. These macros are not used in the fusbh200 driver and will conflict those in the new header. Signed-off-by: Chris Rorvick

[RFC RESEND 00/10] Create separate header for ehci-dbgp driver

parameters. Regards, Chris Rorvick Chris Rorvick (10): usb: Create separate header for ehci-dbgp fusbh200: Make Xen notificaiton consistent with EHCI fusbh200: Remove superfluous macro definitions fusbh200: Remove duplicate ehci-dbgp declarations fusbh200: Use ehci_dbg_port struct fotg210

[RFC RESEND 05/10] fusbh200: Use ehci_dbg_port struct

The FUSBH200 debug port has a EHCI-compatible register layout so there is no need to define a custom struct. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/fusbh200.h b/drivers/usb

Re: frequent lockups in 3.18rc4

On Tue, Dec 2, 2014 at 10:14 PM, Linus Torvalds wrote: > Put another way: "bad" is generally more trustworthy (because you > actively saw the bug), Makes sense, but ... > while a "good" _before_ a subsequent bad is > also trustworthy (because if the "good" kernel contained the bug and > you shou

[PATCH v3 0/2] lprocfs_write_frac_u64_helper cleanup

Added Andreas as reviewer (thanks!) v2: Added a second patch to address Dan Carpenter's concern with the complexity of passing the sign through `mult'. Compile tested only. Chris Rorvick (2): drivers: staging: lustre: Use mult if units not specified drivers: staging: lustre:

[PATCH v3 2/2] drivers: staging: lustre: Track sign separately

suffix is specified, but having the effect of taking the absolute value of the user-provided data. Signed-off-by: Chris Rorvick Reviewed-by: Andreas Dilger --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/st

[PATCH v3 1/2] drivers: staging: lustre: Use mult if units not specified

hat it only applies when units are specified. Signed-off-by: Chris Rorvick Reviewed-by: Andreas Dilger --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b

[PATCH] fib_trie: Add proc entry for next-hop exceptions

Exceptions are added to the FIB in response to ICMP redirects and to account for PMTU, but there is little visibility into what the current exceptions are. Add a proc entry for listing the current next-hop exceptions Signed-off-by: Chris Rorvick --- I wrote this patch while looking into some

Re: [PATCH] fib_trie: Add proc entry for next-hop exceptions

On Tue, Feb 24, 2015 at 11:33 PM, David Miller wrote: > From: Chris Rorvick > Date: Tue, 24 Feb 2015 23:27:12 -0600 > >> Exceptions are added to the FIB in response to ICMP redirects and to >> account for PMTU, but there is little visibility into what the current >>

Re: [PATCH 3/4] ALSA: line6: Pass driver name to line6_probe()

On Fri, Feb 6, 2015 at 11:23 AM, Takashi Iwai wrote: > At Fri, 06 Feb 2015 16:04:42 +0100, Takashi Iwai wrote: >> >> At Fri, 6 Feb 2015 08:51:11 -0600, Chris Rorvick wrote: >> > >> > Provide a descriptive name for each driver instead of calling all of >> &g

[PATCH v2 0/3] More Line 6 cleanup

Changes in v2: * return true/false instead of 1/0 * do not include spaces in driver name * drop patch altering struct names (unnecessary) Chris Rorvick (3): ALSA: line6: Add toneport_has_source_select() ALSA: line6: Pass toneport pointer to toneport_has_led() ALSA: line6: Pass driver

[PATCH v2 3/3] ALSA: line6: Pass driver name to line6_probe()

Provide a unique name for each driver instead of using "line6usb" for all of them. This will allow for different configurations based on the driver type. Signed-off-by: Chris Rorvick --- sound/usb/line6/driver.c | 3 ++- sound/usb/line6/driver.h | 3 +-- sound/usb/line6/pod.

[PATCH v2 2/3] ALSA: line6: Pass toneport pointer to toneport_has_led()

It is unlikely this function would ever be used in a context without a pointer to a `struct usb_line6_toneport', so grab the device type from it rather than having the caller do it. Signed-off-by: Chris Rorvick --- sound/usb/line6/toneport.c | 19 --- 1 file change

[PATCH v2 1/3] ALSA: line6: Add toneport_has_source_select()

Add a predicate for testing if the device supports source selection to make the conditional logic around this a bit cleaner. Signed-off-by: Chris Rorvick --- sound/usb/line6/toneport.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/sound

[PATCH 0/4] More Line 6 cleanup

ocess. :-) Regards, Chris Chris Rorvick (4): ALSA: line6: Add toneport_has_source_select() ALSA: line6: Pass toneport pointer to toneport_has_led() ALSA: line6: Pass driver name to line6_probe() ALSA: line6: Remove `usb_' prefix from structs sound/usb/line6/capture.c | 2 +-

[PATCH 3/4] ALSA: line6: Pass driver name to line6_probe()

Provide a descriptive name for each driver instead of calling all of them "line6usb". Signed-off-by: Chris Rorvick --- sound/usb/line6/driver.c | 3 ++- sound/usb/line6/driver.h | 3 +-- sound/usb/line6/pod.c | 2 +- sound/usb/line6/podhd.c| 2 +- sound/usb/line6/tone

[PATCH 4/4] ALSA: line6: Remove `usb_' prefix from structs

It is just noise that makes lines longer. Signed-off-by: Chris Rorvick --- sound/usb/line6/capture.c | 2 +- sound/usb/line6/driver.c | 42 +++--- sound/usb/line6/driver.h | 22 ++-- sound/usb/line6/midi.c | 24

[PATCH 2/4] ALSA: line6: Pass toneport pointer to toneport_has_led()

It is unlikely this function would ever be used in a context without a pointer to a `struct usb_line6_toneport', so grab the device type from it rather than having the caller do it. Signed-off-by: Chris Rorvick --- sound/usb/line6/toneport.c | 19 --- 1 file change

[PATCH 1/4] ALSA: line6: Add toneport_has_source_select()

Add a predicate for testing if the device supports source selection to make the conditional logic around this a bit cleaner. Signed-off-by: Chris Rorvick --- sound/usb/line6/toneport.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/sound

Re: [PATCH 1/4] ALSA: line6: Add toneport_has_source_select()

On Fri, Feb 6, 2015 at 8:56 AM, Takashi Iwai wrote: > At Fri, 6 Feb 2015 08:51:09 -0600, Chris Rorvick wrote: >> --- a/sound/usb/line6/toneport.c >> +++ b/sound/usb/line6/toneport.c >> @@ -343,6 +343,20 @@ static void toneport_remove_leds(struct >> u

Re: [PATCH 0/2] Remove unused functions

On Sun, Feb 1, 2015 at 2:37 AM, Takashi Iwai wrote: > At Sun, 1 Feb 2015 01:01:07 -0600, Chris Rorvick wrote: >> >> Found a couple more things to rip out. > > Thanks, applied both (with removals of the declarations in midibuf.h, > too). Oops, thanks for fixing up

[PATCH 6/6] ALSA: line6: toneport: Use explicit type for firmware version

The firmware version is a single byte so have the variable type agree. Since the address to this member is passed to the read function, using an int is not even portable. Signed-off-by: Chris Rorvick --- sound/usb/line6/toneport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

  1   2   >