Re: [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block

2015-10-06 Thread Code Kipper
On 6 October 2015 at 11:00, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Fri, Oct 02, 2015 at 08:44:03AM +0200, Code Kipper wrote: >> >> +config SND_SOC_SUNXI_DAI_SPDIF >> >> +tristate >> >> + depends on OF >&g

Re: [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block

2015-10-02 Thread Code Kipper
>> +config SND_SOC_SUNXI_DAI_SPDIF >> +tristate >> + depends on OF >> +select SND_SOC_GENERIC_DMAENGINE_PCM >> +select REGMAP_MMIO >> + >> +config SND_SOC_SUNXI_MACHINE_SPDIF >> +tristate "APB on-chip sun4i/sun5i/sun7i SPDIF" >> + depends on OF >> +

Re: [PATCH v2 1/4] dt-bindings: add sunxi SPDIF transceiver bindings

2015-10-01 Thread Code Kipper
>> + >> + - compatible : should be one of the following: >> +- "allwinner,sun4i-a10-spdif": for the Allwinner A10 SoC >> +- "allwinner,sun7i-a20-spdif": for the Allwinner A20 SoC >> +- "allwinner,sun6i-a31-spdif": for the Allwinner A31 SoC > > Are all these compatibles

Re: [linux-sunxi][alsa-devel][PATCH 3/3] ASOC: sunxi: Add support for the spdif block

2015-09-28 Thread Code Kipper
On 28 September 2015 at 10:25, Maxime Ripard wrote: > On Thu, Sep 24, 2015 at 04:30:05PM +0200, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The sun4i, sun6i and sun7i SoC families have an SPDIF >> block which is capable of

Re: [linux-sunxi][alsa-devel][PATCH 0/3]Add SPDIF support for Allwinner SoCs

2015-09-23 Thread Code Kipper
Hi All, I'm getting a "fatal: 'send-email'" response with the last patch(even though the dry run of the patch series worked) and I've not been able to work around it. I'll post it as soon as I can work out what the issue is, BR, CK On 23 September 2015 at 20:04, wrote: >

Re: [linux-sunxi][alsa-devel][PATCH 0/3]Add SPDIF support for Allwinner SoCs

2015-09-24 Thread Code Kipper
On 23 September 2015 at 20:41, Code Kipper <codekip...@gmail.com> wrote: > Hi All, > I'm getting a "fatal: 'send-email'" response with the last patch(even > though the dry run of the patch series worked) and I've not been able > to work around it. I'll post it as

Re: [linux-sunxi][alsa-devel][PATCH 3/3] ASOC: sunxi: Add support for the spdif block

2015-09-24 Thread Code Kipper
On 24 September 2015 at 19:29, Mark Brown wrote: > On Thu, Sep 24, 2015 at 04:30:05PM +0200, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The sun4i, sun6i and sun7i SoC families have an SPDIF >> block which is capable of playback and capture.

Re: [PATCH v2 1/4] dt-bindings: add sunxi SPDIF transceiver bindings

2015-10-05 Thread Code Kipper
On 5 October 2015 at 10:41, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Fri, Oct 02, 2015 at 07:24:20AM +0200, Code Kipper wrote: >> >> + >> >> + - compatible : should be one of the following: >> >> +- "all

Re: [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver

2016-06-02 Thread Code Kipper
snip > + > + /* Always favor the highest oversampling rate */ > + for (i = (ARRAY_SIZE(sun4i_i2s_oversample_rates) - 1); i >= 0; i--) { > + unsigned int oversample_rate = sun4i_i2s_oversample_rates[i]; > + > + bclk_div = sun4i_i2s_get_bclk_div(i2s,

Re: [PATCH v5 0/2] ASoC: Add SPDIF support for Allwinner SoCs

2016-02-08 Thread Code Kipper
NAK...last bunch of changes introduced a warning which slipped through, I'll fix that and send a new patch series. CK On 8 February 2016 at 16:26, wrote: > From: Marcus Cooper > > This patch set adds support for the Allwinner SPDIF transceiver. > >

Re: [PATCH v4 2/2] ASoC: sunxi: Add support for the SPDIF block

2016-02-05 Thread Code Kipper
On 5 February 2016 at 10:27, Maxime Ripard wrote: > Hi, > > On Thu, Feb 04, 2016 at 12:09:22PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The sun4i, sun5i and sun7i SoC families have an SPDIF >> block which is capable

Re: [PATCH v3 2/2] ASOC: sunxi: Add support for the SPDIF block

2016-02-03 Thread Code Kipper
On 2 February 2016 at 22:17, Maxime Ripard wrote: > Hi, > > It looks mostly good on my side, a few comments though. > > On Tue, Feb 02, 2016 at 03:49:54PM +0100, codekip...@gmail.com wrote: >> +#ifdef CONFIG_PM >> +static int sun4i_spdif_runtime_suspend(struct

Re: [PATCH v3 1/2] dt-bindings: add sun4i SPDIF transceiver bindings

2016-02-02 Thread Code Kipper
On 2 February 2016 at 23:31, Maxime Ripard wrote: > Hi, > > On Tue, Feb 02, 2016 at 03:49:53PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> Add devicetree bindings for the SPDIF transceiver found on >> found on Allwinners

Re: [linux-sunxi] Re: [PATCH v7 0/2] ASoC: Add SPDIF support for Allwinner SoCs

2016-02-21 Thread Code Kipper
On 22 February 2016 at 04:12, Mark Brown wrote: > On Sun, Feb 21, 2016 at 12:13:36PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> For now just the SPDIF transmitter has been tested on a Mele A2000(A10) >> and a Itead Ibox(A20). > >

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-12 Thread Code Kipper
Hi Danny, I've got some patches to go which covers pretty much everything that we can manage with the sun4i-codec. I'm only lacking testing of certain bits as I don't have capable hardware(i.e. FM capture). I've ignored the phone out part of the A20 as I couldn't find the pins. I'll try to upload

Re: [PATCH 1/2] ASoC: sunxi: Add bindings for sun6i to SPDIF

2016-07-30 Thread Code Kipper
On 30 July 2016 at 17:17, Maxime Ripard wrote: > On Sat, Jul 30, 2016 at 04:27:15PM +0200, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The A31 SoC uses the same SPDIF block as found in earlier SoCs, but its >> reset is

Re: [linux-sunxi] Re: [PATCH] ASoC: sunxi: Add bindings for sun8i to SPDIF

2017-01-17 Thread Code Kipper
On 17 January 2017 at 19:15, Mark Brown wrote: > On Thu, Jan 12, 2017 at 06:33:43PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The H3 SoC uses the same SPDIF block as found in earlier SoCs, but the >> transmit fifo is at a different

Re: [linux-sunxi] Re: [PATCH] ASoC: sunxi: Add bindings for sun8i to SPDIF

2017-01-19 Thread Code Kipper
On 19 January 2017 at 18:03, Mark Brown <broo...@kernel.org> wrote: > On Wed, Jan 18, 2017 at 08:09:00AM +0100, Code Kipper wrote: > >> I missed the binding documentation on the patch for the driver so I >> pushed it separately instead of pushing a new patch version.

Re: [linux-sunxi] [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

2016-08-30 Thread Code Kipper
On 29 August 2016 at 20:03, Danny Milosavljevic wrote: > > Note: Mic1 Capture Volume is in a different register on A20 than on A10. > Note: Mic2 Capture Volume is in a different register on A20 than on A10. > --- > sound/soc/sunxi/sun4i-codec.c | 256 >

Re: [PATCH 07/14] ASoC: Add sun8i audio card

2016-10-05 Thread Code Kipper
On 4 October 2016 at 11:46, Mylène Josserand wrote: > Add the audio card for sun8i SoC. This card links the codec driver > (digital part) with the DAI driver. The analog codec driver is > added as an aux_device. > > Signed-off-by: Mylène Josserand

Re: [PATCH 07/14] ASoC: Add sun8i audio card

2016-10-04 Thread Code Kipper
On 4 October 2016 at 11:46, Mylène Josserand wrote: > Add the audio card for sun8i SoC. This card links the codec driver > (digital part) with the DAI driver. The analog codec driver is > added as an aux_device. > > Signed-off-by: Mylène Josserand

Re: [PATCH 04/14] ASoC: Add sun8i analog codec driver

2016-10-04 Thread Code Kipper
On 4 October 2016 at 11:46, Mylène Josserand wrote: > Add the analog part of the sun8i (A33) codec driver. This driver > implements all the analog part of the codec using PRCM registers. > > The read/write regmap functions must be handled in a custom way as >

Re: [PATCH 03/14] ASoC: sun4i-i2s: Add apb reset

2016-10-04 Thread Code Kipper
On 4 October 2016 at 11:46, Mylène Josserand wrote: > Add APB deassert function for sun4i-i2s driver. > > Signed-off-by: Mylène Josserand > --- > sound/soc/sunxi/sun4i-i2s.c | 16 +++- > 1 file changed, 15

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: sun8i-h3: Set CLK_SET_RATE_PARENT for audio module clocks

2016-11-11 Thread Code Kipper
On 11 November 2016 at 11:05, Chen-Yu Tsai wrote: > The audio module clocks are supposed to be set according to the sample > rate of the audio stream. The audio PLL provides the clock signal for > thees module clocks, and only it is freely tunable. nick! these CK > > Set

Re: [PATCH] ASoC: sun4i-i2s: Add quirks for newer SoCs

2016-12-20 Thread Code Kipper
On 20 December 2016 at 20:16, Maxime Ripard wrote: > Hi, > > On Tue, Dec 20, 2016 at 03:55:24PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> Newer SoCs have additional functionality so a quirks structure >> has been added

Re: [linux-sunxi] [PATCH v3 00/12] ASoC: Add I2S support for Allwinner H3 SoCs

2017-07-31 Thread Code Kipper
On 31 July 2017 at 09:05, Olliver Schinagl wrote: > Hey Marcus, > > On 29-07-17 16:17, codekip...@gmail.com wrote: >> >> From: Marcus Cooper >> >> Hi All, >> please find attached a series of patches to bring i2s support to the >> Allwinner H3 SoC.

Re: [linux-sunxi] [PATCH v3 11/11] ASoC: sun4i-i2s: Add support for H3

2017-08-15 Thread Code Kipper
On 12 August 2017 at 14:27, Chen-Yu Tsai wrote: > On Sat, Aug 12, 2017 at 7:00 PM, wrote: >> From: Marcus Cooper >> >> The sun8i-h3 introduces a lot of changes to the i2s block such >> as different register locations, extended clock

Re: [PATCH v2 2/2] ASoC: sun4i-i2s: Add support for H3

2017-07-25 Thread Code Kipper
On 25 July 2017 at 16:36, Maxime Ripard wrote: > Hi, > > On Sat, Jul 22, 2017 at 08:53:52AM +0200, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The sun8i-h3 introduces a lot of changes to the i2s block such >> as different

Re: [PATCH v2 1/2] ASoC: sun4i-i2s: Add more quirks for newer SoCs

2017-07-25 Thread Code Kipper
On 25 July 2017 at 07:52, Maxime Ripard wrote: > Hi Markus, > > On Sat, Jul 22, 2017 at 08:53:51AM +0200, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> In preparation for changing this driver to support newer SoC >>

Re: [PATCH 3/3] ASoC: sun4i-i2s: Add support for H3

2017-07-05 Thread Code Kipper
On 5 July 2017 at 18:20, Maxime Ripard wrote: > On Wed, Jul 05, 2017 at 05:43:24PM +0200, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> There are a lot of changes to the sun8i-h3 i2s block but not enough >> to warrant to a new

Re: [linux-sunxi] [PATCH v3 02/12] ASoC: sun4i-i2s: Add clkdiv offsets to quirks

2017-08-07 Thread Code Kipper
On 1 August 2017 at 04:55, Chen-Yu Tsai wrote: > On Sat, Jul 29, 2017 at 10:17 PM, wrote: >> From: Marcus Cooper >> >> The BCLKDIV and MCLKDIV found on newer SoCs start from an offset of 1. >> Add the functionality to adjust the

Re: [linux-sunxi] [PATCH v3 05/12] ASoC: sun4i-i2s: Add regmap fields for channels

2017-08-07 Thread Code Kipper
On 1 August 2017 at 10:31, Chen-Yu Tsai wrote: > On Sat, Jul 29, 2017 at 10:17 PM, wrote: >> From: Marcus Cooper >> >> On the original i2s block the channel mapping and selection were >> configured for stereo audio by default: This is

Re: [PATCH v2] arm64: allwinner: h5: add support for NanoPi NEO Plus 2

2017-08-25 Thread Code Kipper
On 25 August 2017 at 12:32, Antony Antony wrote: > Add initial DT support for NanoPi NEO Plus 2 by FriendlyELEC > Allwinner quad core H5 Cortex A53 with an ARM Mali-450MP GPU > 1 GB DDR3 RAM > 8GB eMMC flash (Samsung

Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64

2017-08-31 Thread Code Kipper
On 31 August 2017 at 01:36, Stefan Brüns wrote: > The A64 SoC has the same dma engine as the H3 (sun8i), with a > reduced amount of physical channels. Add the proper config data > and compatible string to support it. > > Signed-off-by: Stefan Brüns

Re: [PATCH v5 0/8] ASoC: Add I2S support for Allwinner H3 SoCs

2017-08-31 Thread Code Kipper
On 31 August 2017 at 13:50, Code Kipper <codekip...@gmail.com> wrote: > Hi Mark, > > Wens has given this patch series his blessing so it's good to go. > > Let us know if you need me to resubmit, I take that back as I can see that's all been submitted. Thanks, CK > > B

Re: [PATCH v5 0/8] ASoC: Add I2S support for Allwinner H3 SoCs

2017-08-31 Thread Code Kipper
Hi Mark, Wens has given this patch series his blessing so it's good to go. Let us know if you need me to resubmit, BR, CK On 19 August 2017 at 14:48, wrote: > From: Marcus Cooper > > Hi All, > please find attached a series of patches to bring i2s

Re: [linux-sunxi] Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64

2017-08-31 Thread Code Kipper
On 31 August 2017 at 16:52, Maxime Ripard wrote: > On Thu, Aug 31, 2017 at 01:36:09AM +0200, Stefan Brüns wrote: >> The A64 SoC has the same dma engine as the H3 (sun8i), with a >> reduced amount of physical channels. Add the proper config data >> and compatible

Re: [PATCH] ASoC: sun4i-i2s: Show detailed error when DAI configuration callbacks fail

2017-12-14 Thread Code Kipper
On 14 December 2017 at 08:29, Chen-Yu Tsai wrote: > When any of the DAI hardware configuration callbacks (.hw_param, > .set_fmt, .set_sysclk) fails, there is no explanation about why it > failed. This is particularly confusing for .hw_param, which covers > many parameters of the

Re: [PATCH 3/3] ASoC: sun4i-i2s: Add regmap field to sign extend sample

2018-01-25 Thread Code Kipper
On 25 January 2018 at 09:41, Maxime Ripard wrote: > Hi, > > On Wed, Jan 24, 2018 at 03:11:01PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> On the newer SoCs this is set by default to transfer a 0 after >> each sample in

Re: [PATCH 3/3] ASoC: sun4i-i2s: Add regmap field to sign extend sample

2018-01-24 Thread Code Kipper
On 24 January 2018 at 15:11, wrote: > From: Marcus Cooper > > On the newer SoCs this is set by default to transfer a 0 after > each sample in each slot. Add the regmap field to configure this > and set it so that it pads the sample with 0s. > >

Re: [linux-sunxi] [PATCH 1/3] ASoC: sun4i-i2s: Add set_tdm_slot functionality

2018-01-28 Thread Code Kipper
On 29 January 2018 at 02:50, Chen-Yu Tsai wrote: > On Wed, Jan 24, 2018 at 10:10 PM, wrote: >> From: Marcus Cooper >> >> Some codecs require a different amount of a bit clocks per frame than >> what is calculated by the sample width.

Re: [linux-sunxi] [PATCH 1/3] ASoC: sun4i-i2s: Add set_tdm_slot functionality

2018-01-28 Thread Code Kipper
On 29 January 2018 at 08:38, Chen-Yu Tsai <w...@csie.org> wrote: > On Mon, Jan 29, 2018 at 3:34 PM, Code Kipper <codekip...@gmail.com> wrote: >> On 29 January 2018 at 02:50, Chen-Yu Tsai <w...@csie.org> wrote: >>> On Wed, Jan 24, 2018 at 10:10 PM, <codekip

Re: [linux-sunxi] [PATCH 1/3] ASoC: sun4i-i2s: Add set_tdm_slot functionality

2018-01-29 Thread Code Kipper
On 29 January 2018 at 12:32, Mark Brown <broo...@kernel.org> wrote: > On Mon, Jan 29, 2018 at 08:34:00AM +0100, Code Kipper wrote: > >> I'm not sure..I was looking for a clean example of being able to >> override the number of bclks in the lrclk width and some other &g

Re: [PATCH v2 4/6] ASoC: sun4i-i2s: Add multi-lane functionality

2018-03-13 Thread Code Kipper
On 13 March 2018 at 09:00, Maxime Ripard wrote: > On Mon, Mar 12, 2018 at 04:57:51PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The i2s block supports multi-lane i2s output however this functionality >> is only possible in

Re: [PATCH v2 4/6] ASoC: sun4i-i2s: Add multi-lane functionality

2018-03-13 Thread Code Kipper
On 13 March 2018 at 09:23, Maxime Ripard <maxime.rip...@bootlin.com> wrote: > On Tue, Mar 13, 2018 at 09:15:49AM +0100, Code Kipper wrote: >> On 13 March 2018 at 09:00, Maxime Ripard <maxime.rip...@bootlin.com> wrote: >> > On Mon, Mar 12, 2018 at 04:57:51PM +01