Hi, list!
I have a question about coding style in linux kernel. In
Documention/CodingStyle, it is said that Linux style for comments is
the C89 /* ... */ style. Don't use C99-style // ... comments.
_But_ I see a lot of '//' style comments in current kernel code.
Which is wrong? The documentions
2007/3/12, Jan Engelhardt [EMAIL PROTECTED]:
On Mar 11 2007 22:15, Cong WANG wrote:
I have a question about coding style in linux kernel. In
Documention/CodingStyle, it is said that Linux style for comments is
the C89 /* ... */ style. Don't use C99-style // ... comments.
_But_ I see a lot
Use NULL to indicate we are returning a pointer rather than an integer
and to eliminate some sparse warnings.
Signed-off-by: Cong WANG [EMAIL PROTECTED]
---
--- drivers/kvm/kvm_main.c.orig 2007-03-11 21:41:23.0 +0800
+++ drivers/kvm/kvm_main.c 2007-03-12 14:26:17.0 +0800
Use NULL to indicate we are returning a pointer rather than an integer
and to eliminate some sparse warnings.
Signed-off-by: Cong WANG [EMAIL PROTECTED]
---
--- drivers/kvm/vmx.c.orig 2007-03-11 21:41:03.0 +0800
+++ drivers/kvm/vmx.c 2007-03-12 14:25:11.0 +0800
@@ -98,7
2007/3/12, David Schwartz [EMAIL PROTECTED]:
NULL has the same bit pattern as the number zero. (I'm not saying the bit
pattern is all zeroes. And I am not even sure if NULL ought to
have the same
pattern as zero.) So C++ could use (void *)0, if it would let itself :p
They don't have to
I am sorry. I forgot to CC to the list.
2007/3/14, Nicolas Boichat wrote:
Hello,
snip
+static ssize_t applesmc_show_fan_manual(struct device *dev, char *buf,
+ int offset)
+{
+ int ret;
+ u16 manual = 0;
+ u8
2007/3/14, Cong WANG wrote:
I am sorry. I forgot to CC to the list.
2007/3/14, Nicolas Boichat wrote:
Hello,
snip
+static ssize_t applesmc_show_fan_manual(struct device *dev, char *buf,
+ int offset)
+{
+ int ret
Typo and tiny mistakes in comments of include/linux/poll.h.
Signed-off-by: WANG Cong [EMAIL PROTECTED]
--- include/linux/poll.h.orig 2007-02-13 10:25:43.0 +0800
+++ include/linux/poll.h2007-02-13 10:27:10.0 +0800
@@ -24,7 +24,7 @@
struct poll_table_struct;
/*
- *
Style fix in fs/select.c.
Signed-off-by: WANG Cong [EMAIL PROTECTED]
--- fs/select.c.orig2007-02-13 12:42:37.0 +0800
+++ fs/select.c 2007-02-13 12:46:44.0 +0800
@@ -65,7 +65,7 @@ EXPORT_SYMBOL(poll_initwait);
static void free_poll_entry(struct poll_table_entry *entry)
2007/3/29, [EMAIL PROTECTED] [EMAIL PROTECTED]:
hello ,
i am programming a trial firewall based on netfilter ,which needs the module to
access the data of user space ,so i use copy_from_user() but it can't work ,the
code(simple test code) is like this:
---user space program-
#include
2007/3/29, Russ Meyerriecks [EMAIL PROTECTED]:
Hi all,
I've been hacking on the Linux kernel all semester for my OS:
Internals class. We are given full autonomy in picking our final
programming project and I would love for mine to be /useful/ for the
Linux kernel and not just a theoretical
Since kobject_add, sysfs_create_link and sysfs_create_file are marked
as '__must_check', so we must always check their return values, or gcc
will give us warnings.
Signed-off-by: Cong WANG [EMAIL PROTECTED]
---
--- fs/partitions/check.c.orig 2007-03-30 21:35:45.0 +0800
+++ fs
2007/3/31, Adrian Bunk [EMAIL PROTECTED]:
On Thu, Mar 29, 2007 at 11:16:39PM -0400, Kyle Moffett wrote:
On Mar 28, 2007, at 16:14:54, Andrew Morton wrote:
On Wed, 28 Mar 2007 19:23:32 +0200 (CEST)
Jiri Kosina [EMAIL PROTECTED] wrote:
blockdev: bd_claim_by_kobject() could check value of
2007/3/31, Pedram M [EMAIL PROTECTED]:
Do i submit that here?
-
No. Please submit by [EMAIL PROTECTED].
--
So Dark The Con Of Man.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
2007/3/31, Pedram M [EMAIL PROTECTED]:
Ok thanks,
I've sent one already, could you please double check:
@@ -4590,7 +4590,7 @@
printk(stli_findpcibrds()\n);
#endif
- while ((dev = pci_find_device(PCI_VENDOR_ID_STALLION,
+ while ((dev =
2007/4/1, Andrew Morton [EMAIL PROTECTED]:
On Sat, 31 Mar 2007 10:30:31 +0800 Cong WANG [EMAIL PROTECTED] wrote:
Since kobject_add, sysfs_create_link and sysfs_create_file are marked
as '__must_check', so we must always check their return values, or gcc
will give us warnings.
Signed-off
2007/4/1, Andrew Morton [EMAIL PROTECTED]:
On Sun, 1 Apr 2007 14:20:46 +0800 Cong WANG [EMAIL PROTECTED] wrote:
Also, please always prepare patches in `patch -p1' form, as per
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt, thanks.
Sorry. I am confused with this. Does
Since kobject_add, sysfs_create_link and sysfs_create_file are marked
as '__must_check', we must always check their return values.
Signed-off-by: Cong WANG [EMAIL PROTECTED]
---
--- linux-2.6.21-rc5-mm3/fs/partitions/check.c.orig 2007-03-30
21:35:45.0 +0800
+++ linux-2.6.21-rc5-mm3
On Tue, 30 Oct 2012 at 02:47 GMT, Zheng Li zheng.x...@oracle.com wrote:
+ struct slave *tmp_slave = NULL;
+ int i = 0, found_mac = 0;
+ bond_for_each_slave(bond, tmp_slave, i) {
+ if
[3] http://marc.info/?l=linux-netdevm=134902691421670w=2
Signed-off-by: Paolo Valente paolo.vale...@unimore.it
Tested-by: Cong Wang amw...@redhat.com
Acked-by: Stephen Hemminger shemmin...@vyatta.com
David, could you take this patch? Stephen acked it.
Thanks!
--
To unsubscribe from
On Mon, Oct 22, 2012 at 6:35 AM, Cruz Julian Bishop
cruzjbis...@gmail.com wrote:
Hi everyone,
I was just wondering - Since (last time I looked, anyway),
/scripts/* has no maintainer, who would I send patches to?
Would I just send them to the mailing list, or is there a
sort of catch-all
On Tue, Oct 9, 2012 at 6:05 AM, Richard W.M. Jones rjo...@redhat.com wrote:
Let's move this to LKML ...
On Mon, Oct 08, 2012 at 10:53:25PM +0100, Richard W.M. Jones wrote:
On Mon, Oct 08, 2012 at 10:50:30PM +0100, Richard W.M. Jones wrote:
[.. discussion on gnulib test-cloexec test snipped
On Thu, Oct 11, 2012 at 3:23 AM, Joe Perches j...@perches.com wrote:
Reduces object size and should be slightly faster.
allyesconfig:
$ size net/core/pktgen.o*
textdata bss dec hex filename
522844321 11840 68445 10b5d net/core/pktgen.o.new
523104293
paolo.vale...@unimore.it
Please respect people who helps you to test it:
Tested-by: Cong Wang amw...@redhat.com
I tested it again just in case...
By the way, one nit below:
+ if (unlikely(cl-lmax qdisc_pkt_len(skb))) {
+ pr_notice(qfq: increasing maxpkt from %u to %u for class
On 10/29/2012 07:24 PM, Paolo Valente wrote:
Il 29/10/2012 12:08, Cong Wang ha scritto:
Please respect people who helps you to test it:
Tested-by: Cong Wang amw...@redhat.com
Oops, really sorry about that. I did not mean to hide your contribution.
I am just not familiar with the process
need revert both of these two commits.
Tested kdump on physical and virutual machines.
Looks good to me,
Acked-by: Cong Wang xiyou.wangc...@gmail.com
Thanks for the fix!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
On Thu, 2012-07-12 at 13:22 -0700, Alex Kelly wrote:
Sorry it took me so long to reply to this:
1. *Should* I change the option to CONFIG_CORE_DUMP ? I agree with Josh
that in terms of the existing codebase, either way makes sense, but I'll
defer to your judgment if you think I should change
On Sun, Jul 15, 2012 at 5:22 PM, rakesh singh rks.linux...@gmail.com wrote:
make -C /usr/src/linux-headers-2.6.38-8-generic/
SUBDIRS=/home/rakesh/Desktop/m modules
make[1]: Entering directory `/usr/src/linux-headers-2.6.38-8-generic'
CC [M] /home/rakesh/Desktop/m/hello.o
On Wed, 27 Feb 2013 at 17:55 GMT, Eliezer Tamir
eliezer.ta...@linux.jf.intel.com wrote:
+static inline void skb_mark_ll(struct napi_struct *napi, struct sk_buff *skb)
+{
+ skb-dev_ref = napi;
+}
+
+static inline void sk_mark_ll(struct sock *sk, struct sk_buff *skb)
+{
+ if
On 02/28/2013 01:55 AM, Eliezer Tamir wrote:
Open issues:
1. Find a way to avoid the need to change the sk and skb structs.
One big disadvantage of how we do this right now is that when a device is
removed, it's hard to prevent it from getting polled by a socket
which holds a stale reference.
(Cc'ing the right netdev mailing list...)
On 03/05/2013 08:01 AM, dormando wrote:
Hi!
I have a (core lockup?) with 3.7.6+ and 3.8.2 which appears to be under
ixgbe. The machine appears to still be up but network stays in a severely
hobbled state. Either lagging or not responding to the network
[Followup-To: header set to gmane.linux.network.]
On Thu, 07 Feb 2013 at 19:32 GMT, Sasha Levin sasha.le...@oracle.com wrote:
Hi guys,
I got the following while fuzzing with trinity inside a KVM tools guest:
[ 51.680236] ===
[ 51.681914] [ INFO: suspicious RCU
On Thu, 07 Feb 2013 at 19:32 GMT, Sasha Levin sasha.le...@oracle.com wrote:
Hi guys,
I got the following while fuzzing with trinity inside a KVM tools guest:
[ 51.680236] ===
[ 51.681914] [ INFO: suspicious RCU usage. ]
[ 51.683610]
On Tue, Feb 5, 2013 at 2:08 PM, Ben Pfaff b...@cs.stanford.edu wrote:
Stephen Hemminger step...@networkplumber.org writes:
On Tue, 29 Jan 2013 22:15:18 +0800
Cong Wang xiyou.wangc...@gmail.com wrote:
Hello, Rusty, Jesse,
I met an interesting problem when I compile openvswitch module
On 02/07/2013 07:02 AM, Michael S. Tsirkin wrote:
At the moment, macvtap crashes are observed if macvtap is attached
to an interface with LRO enabled.
The crash in question is BUG() in macvtap_skb_to_vnet_hdr.
This happens because several drivers set gso_size but not gso_type
in incoming skbs.
On Tue, 2013-01-15 at 12:55 +0200, Thomas Backlund wrote:
as it seemed to fix the libvirt case
but then asked it to be ignored after I tried to build connman,
and hit this conflict with glibc-2.17:
In file included from /usr/include/arpa/inet.h:22:0,
from
see this
before.
Thanks.
On Tue, 2013-01-15 at 12:55 +0200, Thomas Backlund wrote:
Cong Wang skrev 15.1.2013 12:11:
Does the following patch help?
$ git diff include/uapi/linux/if_bridge.h
diff --git a/include/uapi/linux/if_bridge.h
b/include/uapi/linux/if_bridge.h
index 5db2975
On Wed, 2013-01-16 at 14:22 -0500, Mike Frysinger wrote:
but this is still too vague. what headers/definitions do people want to see
simultaneously included ? changes would be needed on both sides (kernel C
library).
Hi, Mike,
Please take a look at my first email in this thread. The
On Thu, 2013-01-17 at 11:55 +0800, Jike Song wrote:
On Thu, Jan 17, 2013 at 2:59 AM, David Miller da...@davemloft.net wrote:
When GLIBC doesn't provide it's own definition of some networking
macros or interfaces that the kernel provides, people include the
kernel header.
Recently I
- Original Message -
I see no reason, even although I don't know why it is 46 instead of
40.
Ok, for ::::::255.255.255.255.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
On 02/20/2013 02:02 PM, Stephen Rothwell wrote:
Hi Andrew,
Today's linux-next merge of the akpm tree got a conflict in
net/core/dev.c between commit 900ff8c63214 (net: move procfs code to
net/core/net-procfs.c) from the net-next tree and commit hlist: drop
the node parameter from iterators from
On Tue, Sep 4, 2012 at 11:39 PM, Steven Rostedt rost...@goodmis.org wrote:
On Wed, 2012-08-29 at 09:28 +0800, Cong Wang wrote:
On Tue, Aug 28, 2012 at 2:22 AM, Steven Rostedt rost...@goodmis.org wrote:
The file feature-removal-schedule.txt is ignored by most people except
for people that add
On Tue, 2012-09-11 at 17:59 +0200, Oleg Nesterov wrote:
But, again, the caller does free_note_info(), so why
elf_note_info_init()
tries to handle the kmalloc failures? Afaics, we can simplify the code
and fix the bug.
What do you think about the patch below?
Looks reasonable and neat. :)
On 09/14/2012 07:18 AM, JA Magallón wrote:
Hi...
Probably it is a stupid question, but... I wan to count the number of
processors, cores and threads on a linux system. I do it by reading
/proc/cpuinfo.
...
Since when is it safe to read things the modern way (kernel version ?).
Is there a
On Sun, Sep 16, 2012 at 10:30 AM, Xiaodong Xu stid.s...@gmail.com wrote:
Hi All,
I found a bug in kernel PPPOE driver.
When PPPOE is running over a virtual ethernet interface (e.g., a
bonding interface) and the user tries to delete the interface in case
the PPPOE state is ZOMBIE, the kernel
On Fri, Jul 27, 2012 at 2:35 PM, Dirk Gouders
goud...@et.bocholt.fh-gelsenkirchen.de wrote:
Hi Jesse,
I would like to ask you to check if the documentation of nc in
netconsole.txt is still correct. I tried two different netcat packages
and both require -p to specify the listening port. I am
When a bridge interface deletes its underlying ports, it should
notify netconsole too, like what bonding interface does.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Cong Wang amw...@redhat.com
---
net/bridge/br_if.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff
With the previous patch applied, __netpoll_cleanup() is non-block now,
so we don't need to release the spin_lock before calling it.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Cong Wang amw...@redhat.com
---
drivers/net/netconsole.c |5 -
1 files changed, 0 insertions(+), 5
slave_enable_netpoll() and __netpoll_setup() may be called
with read_lock() held, so should use GFP_ATOMIC to allocate
memory.
Cc: David S. Miller da...@davemloft.net
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Cong Wang amw...@redhat.com
---
drivers/net/bonding
In __netpoll_rx(), it dereferences -npinfo without rcu_dereference_bh(),
this patch fixes it by using the 'npinfo' passed from netpoll_rx()
where it is already dereferenced with rcu_dereference_bh().
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Cong Wang amw...@redhat.com
---
include
-npinfo.
3. Rename arp_reply() to netpoll_arp_reply(), the former is too generic.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Cong Wang amw...@redhat.com
---
net/core/netpoll.c | 31 +--
1 files changed, 17 insertions(+), 14 deletions(-)
diff --git a/net/core
The logic of the code is same, just call netpoll_rx_on().
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Cong Wang amw...@redhat.com
---
include/linux/netpoll.h | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/include/linux/netpoll.h b/include
Like the previous patch, slave_disable_netpoll() and __netpoll_cleanup()
may be called with read_lock() held too, so we should make them
non-block, by moving the cleanup and kfree() to call_rcu_bh() callbacks.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Cong Wang amw...@redhat.com
!
Cong Wang (14):
jbd2: remove the second argument of kmap_atomic
frv: remove the second parameter of kmap_atomic_primary()
tile: remove usage of enum km_type
highmem: remove the deprecated form of kmap_atomic
arm: remove km_type definitions
powerpc: remove km_type definitions
frv: remove
On Fri, 2012-07-27 at 14:40 -0400, Neil Horman wrote:
Here, and above I see you using an rcu_head to defer cleanup, until after all
pointer uses are dropped, but I don't see any modification of code points that
dereference any struct netpoll pointers to include
On Fri, 2012-07-27 at 08:50 -0700, Stephen Hemminger wrote:
On Fri, 27 Jul 2012 23:38:01 +0800
Cong Wang amw...@redhat.com wrote:
When a bridge interface deletes its underlying ports, it should
notify netconsole too, like what bonding interface does.
Cc: David S. Miller da
On Tue, Aug 28, 2012 at 2:22 AM, Steven Rostedt rost...@goodmis.org wrote:
The file feature-removal-schedule.txt is ignored by most people except
for people that add to it. It's more of a global TODO list for
developers than being anything useful by anyone.
Add a feature removal of removing
On 09/03/2012 10:14 PM, yan wrote:
Signed-off-by: yan clouds@gmail.com
Please provide a changelog to explain why we need this patch.
---
fs/proc/generic.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index
On 08/30/2012 12:15 PM, Sachin Agarwalla wrote:
Dear Sir/Madam,
I have some questions on development of linux kernel as follows:-
1.I want to know the location of files in linux kernel source code that
contains timer initialization and scheduler part.
Scheduler source code is in
On 09/03/2012 02:26 AM, Jiri Kosina wrote:
On Sun, 2 Sep 2012, Xin Tong wrote:
3. can two different processes have their CR3 being the same value
even though they have different first level page tables ?
Yes, if they are created by clone(CLONE_VM). In such case they share the
same mm_struct,
On 09/04/2012 05:22 PM, yan yan wrote:
2012/9/4 Cong Wang xiyou.wangc...@gmail.com:
On 09/03/2012 10:14 PM, yan wrote:
Signed-off-by: yan clouds@gmail.com
Please provide a changelog to explain why we need this patch.
I think the title is self explained.
---
fs/proc/generic.c
On Wed, Sep 5, 2012 at 1:32 AM, Flavio Leitner f...@redhat.com wrote:
Hi folks,
I have system that no longer boots kdump kernel. Basically,
# echo c /proc/sysrq-trigger
to dump a vmcore doesn't work. It just hangs after showing the usual
panic messages. I've bisected the problem and the
On 08/13/2012 11:27 PM, Jiri Pirko wrote:
This lists are supposed to serve for storing pointers to all upper devices.
Eventually it will replace dev-master pointer which is used for
bonding, bridge, team but it cannot be used for vlan, macvlan where
there might be multiple masters present.
New
On 08/08/2012 06:57 PM, Jenny TC wrote:
Introduce a new API raw_notifier_chain_cond_register to
add a notifier to a raw notifier chain, only if notifier
not already present in the chain.
Forgot its declaration?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the
On 08/03/2012 02:33 PM, Dirk Gouders wrote:
From b3aec70d785d338b1b643fece6606cd32addaf0c Mon Sep 17 00:00:00 2001
From: Dirk Gouders goud...@et.bocholt.fh-gelsenkirchen.de
Date: Thu, 2 Aug 2012 22:20:16 +0200
Subject: [PATCH] netconsole.txt: revision of examples for the receiver of
kernel
On Sun, Aug 26, 2012 at 1:37 AM, Sebastian Andrzej Siewior
sebast...@breakpoint.cc wrote:
On Sat, Aug 25, 2012 at 11:51:23PM +0800, Cong Wang wrote:
From: Cong Wang xiyou.wangc...@gmail.com
It is scheduled to be removed in 3.6.
This should go via Greg and linux-usb and you should put Pete
On 08/02/2012 06:41 AM, Stephen Rothwell wrote:
Hi Ben,
Since I haven't been able to fetch these trees for quite some time and I
haven't heard from you about them, I am removing the following trees from
linux-next. If/When you have time to maintain these trees again, we can
add them back
On Fri, Aug 3, 2012 at 4:39 AM, Dirk Gouders
goud...@et.bocholt.fh-gelsenkirchen.de wrote:
From d756d2750e4cf07d3c0942dc3c491d57631d4338 Mon Sep 17 00:00:00 2001
From: Dirk Gouders goud...@et.bocholt.fh-gelsenkirchen.de
Date: Thu, 2 Aug 2012 22:20:16 +0200
Subject: [PATCH] netconsole.txt:
On Fri, 2012-08-03 at 11:17 +0200, Eric Dumazet wrote:
On Fri, 2012-07-27 at 23:37 +0800, Cong Wang wrote:
slave_enable_netpoll() and __netpoll_setup() may be called
with read_lock() held, so should use GFP_ATOMIC to allocate
memory.
Cc: David S. Miller da...@davemloft.net
Reported
On Fri, 2012-08-03 at 12:10 +0200, Eric Dumazet wrote:
I did this , just take it ;)
Do we have to pass gfp to -ndo_netpoll_setup() too? It seems no, so far
I don't think we have to do that.
Thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
From: WANG Cong xiyou.wangc...@gmail.com
This patch fixes the following warning:
usr/include/linux/string.h:8: userspace cannot reference function or variable
defined in the kernel
Cc: Akinobu Mita akinobu.m...@gmail.com
Signed-off-by: WANG Cong xiyou.wangc...@gmail.com
---
diff --git
On Mon, 2012-08-06 at 11:44 +0200, Eric Dumazet wrote:
On Mon, 2012-08-06 at 17:08 +0800, Cong Wang wrote:
On Fri, 2012-08-03 at 12:10 +0200, Eric Dumazet wrote:
I did this , just take it ;)
Do we have to pass gfp to -ndo_netpoll_setup() too? It seems no, so far
I don't think we
On Sat, Jul 7, 2012 at 1:32 AM, Scan Subscription
scan-subscript...@coverity.com wrote:
CID 200075: Free of array-typed value (BAD_FREE.array)
/linux/fs/splice.c: 317 ( array_assign)
311 struct page
Kfifo is a ring-buffer in kernel which can be used as a lock-free way
for concurrent read/write when there are only one producer and one
consumer. Details of its design can be found in kernel/kfifo.c and
include/linux/kfifo.h.
You will find that the 'in' and 'out' fields of 'struct kfifo' are
2007/2/9, Andrew Morton [EMAIL PROTECTED]:
On Thu, 8 Feb 2007 20:16:55 +0800 Cong WANG [EMAIL PROTECTED] wrote:
2007/2/8, Andrew Morton [EMAIL PROTECTED]:
On Thu, 8 Feb 2007 17:07:28 +0800 Cong WANG [EMAIL PROTECTED] wrote:
Kfifo is a ring-buffer in kernel which can be used as a lock
On Mon, 09 Jul 2012 at 08:46 GMT, Minchan Kim minc...@kernel.org wrote:
WARN_ON_ONCE would tell you what is trying to satisfy the allocation.
Do you mean that it would be better to use WARN_ON_ONCE rather than raw
printk?
If so, I would like to insist raw printk because WARN_ON_ONCE could
On Mon, Jul 9, 2012 at 10:12 PM, Minchan Kim minc...@kernel.org wrote:
Embedded can use CONFIG_PRINTK and !CONFIG_BUG for size optimization
and printk(pr_xxx) + dump_stack is common technic used in all over kernel
sources. Do you have any reason you don't like it?
No, I am just feeling like
.
I only noticed while bisecting for the reason I could not make a crash
kernel boot (which ended up on this patch).
Signed-off-by: Stefan Bader stefan.ba...@canonical.com
Cc: WANG Cong xiyou.wangc...@gmail.com
Cc: Yinghai Lu ying...@kernel.org
Cc: Tejun Heo t...@kernel.org
Acked-by: Cong
On Mon, 2012-07-23 at 20:22 +0900, Takao Indoh wrote:
(2012/07/23 19:00), Dave Young wrote:
On 07/17/2012 11:15 AM, Takao Indoh wrote:
Hi Cong,
When I tested kdump with 3.5.0-rc6 kernel, I found a problem of kdump
kernel's panic in find_early_table_space().
init_memory_mapping:
[-Wunused-variable]
These variables are only used when CONFIG_SYSCTL is defined,
so move them under #ifdef CONFIG_SYSCTL.
Reported-by: Fengguang Wu fengguang...@intel.com
Signed-off-by: Cong Wang amw...@redhat.com
Acked-by: Shan Wei davids...@tencent.com
Cc netdev...
On Wed, Nov 28, 2012 at 4:37 AM, Linda Walsh l...@tlinx.org wrote:
Is this a known problem / bug, or should I file a bug on it? It doesn't
cause a complete failure, and it happens multiple times (~28 times
in 2.5 days?... so maybe 10x/day?) about 8 start with ifup, and the
On Sun, Dec 23, 2012 at 9:19 PM, Sedat Dilek sedat.di...@gmail.com wrote:
The culprit commit here seems to be...
commit 9650388b5c56578fdccc79c57a8c82fb92b8e7f1
Author: Eric Dumazet eduma...@google.com
Date: Fri Dec 21 07:32:10 2012 +
ipv4: arp: fix a lockdep splat in
On Sun, Dec 23, 2012 at 10:14 PM, Sedat Dilek sedat.di...@gmail.com wrote:
[ CCing Eric ]
YES, thie fixes my problem.
But your patch was somehow malformed, so I attached mine.
Thanks for testing!
I knew it as I replied in wed Gmail. :) I will send a normal patch
with your Reported-by and
On Sun, Dec 23, 2012 at 10:10 PM, Julian Anastasov j...@ssi.bg wrote:
- memset(dst_ha, 0, dev-addr_len);
+ memcpy(dst_ha, dev-broadcast, MAX_ADDR_LEN);
Use dev-addr_len instead of MAX_ADDR_LEN or
better provide NULL ptr to arp_send as before the
ipv4: arp:
On Wed, Dec 26, 2012 at 12:08 AM, Sasha Levin levinsasha...@gmail.com wrote:
On Tue, Dec 18, 2012 at 10:20 AM, Josh Boyer jwbo...@gmail.com wrote:
On Wed, Nov 21, 2012 at 7:53 AM, Alan Cox a...@lxorguk.ukuu.org.uk wrote:
On Wed, 21 Nov 2012 07:45:45 -0500
Josh Boyer jwbo...@gmail.com wrote:
/msg00930.html
https://bugzilla.redhat.com/show_bug.cgi?id=895141
Yep,
and the commit breaking uapi headers is by using struct in6_addr ip6 is:
From ee07c6e7a6f8a25c18f0a6b18152fbd7499245f6 Mon Sep 17 00:00:00 2001
From: Cong Wang amw...@redhat.com
Date: Fri, 7 Dec 2012 00:04:48 +
On Fri, 2013-08-02 at 14:50 -0700, David Miller wrote:
From: Cong Wang amw...@redhat.com
Date: Fri, 2 Aug 2013 15:14:27 +0800
From: Cong Wang amw...@redhat.com
Introduce a generic IP address type, union inet_addr, so that
subsystems don't have to use their own definitions. Because
On Fri, 2013-08-02 at 03:31 -0700, Christoph Hellwig wrote:
On Fri, Aug 02, 2013 at 03:14:32PM +0800, Cong Wang wrote:
From: Cong Wang amw...@redhat.com
nfs and cifs define some helper functions for sockaddr,
they can use the generic functions for union inet_addr too.
Since some dlm
On Tue, 23 Jul 2013 at 17:58 GMT, Joe Perches j...@perches.com wrote:
Function prototypes don't need to be declared
extern in .h files. It's assumed by the compiler
and is as unnecessary as using auto is when
declaring automatic/local variables in a block.
Since we all know this, why bother
From: Cong Wang amw...@redhat.com
The %pIS specifier is for struct Sockaddr, since now we have union
inet_addr, rename it to '%pIA' so that it can accept union inet_addr*.
But struct sockaddr * can still safely passed to
'%pIA', since it is a union of it.
Cc: Daniel Borkmann dbork...@redhat.com
From: Cong Wang amw...@redhat.com
nfs and cifs define some helper functions for sockaddr,
they can use the generic functions for union inet_addr/struct sockaddr
too.
Since some dlm code needs to compare -sin_port, introduce a
generic function inet_addr_equal_strict() for it.
Cc: Steve French
From: Cong Wang amw...@redhat.com
selinux has some similar definition like union inet_addr,
it can re-use the generic union inet_addr too.
Cc: James Morris james.l.mor...@oracle.com
Cc: Stephen Smalley s...@tycho.nsa.gov
Cc: Eric Paris epa...@parisplace.org
Cc: Paul Moore pmo...@redhat.com
Cc
On Mon, 2013-08-19 at 14:42 -0700, Casey Schaufler wrote:
Well, they certainly don't appear to add any value on their own.
I also generally oppose doing clever things with data structures.
If you want to implement same thing for 5+ times, yes, it has no value
for you. Enjoy the following
On Tue, 2013-08-20 at 07:28 -0700, Casey Schaufler wrote:
I do use and enjoy all of these implementations! Thank you
for the fine implementations. In the end, if you're maintaining
the code it's your call. I question change that does not have
an obvious purpose because statistically every
On Thu, 2013-08-15 at 16:36 +0800, Tao Ma wrote:
From: Tao Ma boyu...@taobao.com
When we are using netpoll, we don't go through the normal
transmit process. In this case, bond_select_queue is not called
and qdisc_skb_cb(skb)-slave_dev_queue_mapping isn't set.
Yes?
In
On Thu, 01 Aug 2013 at 14:34 GMT, Sebastiano Spicuglia
spicuglia.sebasti...@gmail.com wrote:
The machine suddenly stops to be connected to the network.
Running ifdown eth0 ifup eth0 the network starts to work
again for few minutes and then the failure happens again.
It is not even possible
From: Cong Wang amw...@redhat.com
selinux has some similar definition like union inet_addr,
it can re-use the generic union inet_addr too.
Cc: James Morris james.l.mor...@oracle.com
Cc: Stephen Smalley s...@tycho.nsa.gov
Cc: Eric Paris epa...@parisplace.org
Cc: Paul Moore pmo...@redhat.com
Cc
From: Cong Wang amw...@redhat.com
nfs and cifs define some helper functions for sockaddr,
they can use the generic functions for union inet_addr too.
Since some dlm code needs to compare -sin_port, introduce a
generic function inet_addr_equal_strict() for it.
Cc: Steve French sfre...@samba.org
From: Cong Wang amw...@redhat.com
Introduce a generic IP address type, union inet_addr, so that
subsystems don't have to use their own definitions. Because
netpoll already defines union inet_addr, just move it to global.
Some of the helper functions will be used by VXLAN IPv6 code too
On Wed, Mar 12, 2014 at 1:46 PM, Vivek Goyal vgo...@redhat.com wrote:
@@ -1098,6 +1135,16 @@ static int unix_stream_connect(struct socket *sock,
struct sockaddr *uaddr,
if (newsk == NULL)
goto out;
+ err = init_peercgroup(newsk);
+ if (err)
+
1 - 100 of 1561 matches
Mail list logo
