us we can remove the
> zero check and also the dead-code non-zero case too.
>
> Detected by CoverityScan, CID#1411632 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
> ---
> drivers/scsi/aacraid/commsup.c | 6 +-
>
static const struct pci_error_handlers aac_pci_err_handler = {
> .error_detected = aac_pci_error_detected,
> .mmio_enabled = aac_pci_mmio_enabled,
> .slot_reset = aac_pci_slot_reset,
Acked-by: Dave Carroll <david.carr...@microsemi.com>
#1435473 ("Uninitialized scalar variable")
>
> Fixes: 423400e64d377 ("scsi: aacraid: Include HBA direct interface")
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
> ---
> drivers/scsi/aacraid/commctrl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Dave Carroll <david.carr...@microsemi.com>
---
> drivers/scsi/aacraid/linit.c | 20
> 1 file changed, 12 insertions(+), 8 deletions(-)
Reviewed-by: Dave Carroll <david.carr...@microsemi.com>
ut aacraid by that time.
>
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> ---
Reviewed-by: Dave Carroll <david.carr...@microsemi.com>
>
> On Thu, Jul 05, 2018 at 05:42:02PM +, Dave Carroll wrote:
> > > Remove the AAC_STAT_GOOD definition and open code it in the places
> > > it was used.
> > >
> > > This will make subsequent refactoring in this area easier.
> > >
> >
> -Original Message-
> From: Hans de Goede [mailto:hdego...@redhat.com]
> Sent: Thursday, March 29, 2018 8:51 AM
> To: dl-esc-Aacraid Linux Driver ; James E.J.
> Bottomley ; Martin K. Petersen
> ; SCSI development
aac_pci_err_handler = {
> .error_detected = aac_pci_error_detected,
> .mmio_enabled = aac_pci_mmio_enabled,
> .slot_reset = aac_pci_slot_reset,
Acked-by: Dave Carroll
init.c | 20
> 1 file changed, 12 insertions(+), 8 deletions(-)
Reviewed-by: Dave Carroll
> -Original Message-
> From: Hans de Goede [mailto:hdego...@redhat.com]
> Sent: Thursday, March 29, 2018 8:51 AM
> To: dl-esc-Aacraid Linux Driver ; James E.J.
> Bottomley ; Martin K. Petersen
> ; SCSI development list s...@vger.kernel.org>; Linux Kernel Mailing List
>
> Subject:
ut aacraid by that time.
>
> Signed-off-by: Arnd Bergmann
> ---
Reviewed-by: Dave Carroll
>
> On Thu, Jul 05, 2018 at 05:42:02PM +, Dave Carroll wrote:
> > > Remove the AAC_STAT_GOOD definition and open code it in the places
> > > it was used.
> > >
> > > This will make subsequent refactoring in this area easier.
> > >
> >
olin Ian King
> ---
> drivers/scsi/aacraid/commctrl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Dave Carroll
o check and also the dead-code non-zero case too.
>
> Detected by CoverityScan, CID#1411632 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King
> ---
> drivers/scsi/aacraid/commsup.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
Acked-by: Dave Carroll
14 matches
Mail list logo