> >>>> On 12/22/20 4:11 AM, Andy Shevchenko wrote:
> >>>>> On Mon, Dec 21, 2020 at 11:39:00PM -0800, David Gow wrote:
> >>>>>> kunit_tool relies on the UML console outputting printk() output to the
> >>>>>> tty in or
On Tue, Aug 4, 2020 at 6:15 PM Andrey Konovalov wrote:
>
> On Tue, Aug 4, 2020 at 12:59 AM David Gow wrote:
> >
> > On Sat, Aug 1, 2020 at 3:10 PM David Gow wrote:
> > >
> > > From: Patricia Alfonso
> > >
> > > Transfer all previous tests f
not
enabled, KUnit will print a statement to let the user know this test
was not run with KASAN_STACK enabled.
copy_user_test and kasan_rcu_uaf cannot be run in KUnit so there is a
separate test file for those tests, which can be run as before as a
module.
Signed-off-by: Patricia Alfonso
Sign
/20200702071416.1780522-1-david...@google.com/
Signed-off-by: David Gow
---
lib/Makefile| 6 +++---
lib/{test_kasan.c => kasan_kunit.c} | 0
2 files changed, 3 insertions(+), 3 deletions(-)
rename lib/{test_kasan.c => kasan_kunit.c} (100%)
diff --git a/lib/Makefile b/lib/Ma
/lkml/2020/7/31/571
[8]
https://lore.kernel.org/linux-kselftest/8d43e88e-1356-cd63-9152-209b81b16...@linuxfoundation.org/T/#u
David Gow (2):
kasan: test: Make KASAN KUnit test comply with naming guidelines
mm: kasan: Do not panic if both panic_on_warn and kasan_multishot set
Patricia Alfonso (4):
Ad
warnings show up).
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Brendan Higgins
---
mm/kasan/report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index e2c14b10bc81..00a53f1355ae 100644
--- a/mm/kasan/report.c
+++ b
From: Patricia Alfonso
Include documentation on how to test KASAN using CONFIG_TEST_KASAN_KUNIT
and CONFIG_TEST_KASAN_MODULE.
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Dmitry Vyukov
Acked-by: Brendan Higgins
---
Documentation/dev
resenting if a KASAN report is expected and if a
KASAN report is found
[1]
(https://lore.kernel.org/linux-kselftest/1583251361-12748-1-git-send-email-alan.magu...@oracle.com/T/#t)
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by:
From: Patricia Alfonso
In order to integrate debugging tools like KASAN into the KUnit
framework, add KUnit struct to the current task to keep track of the
current KUnit test.
Signed-off-by: Patricia Alfonso
Reviewed-by: Brendan Higgins
Signed-off-by: David Gow
---
include/linux/sched.h | 4
On Sat, Aug 8, 2020 at 4:51 PM Brendan Higgins
wrote:
>
> On Fri, Aug 7, 2020 at 10:45 PM David Gow wrote:
> >
> > On Sat, Aug 8, 2020 at 9:17 AM Brendan Higgins
> > wrote:
> > >
> > > Currently kunit_tool does not work correctly when executed from a
52-209b81b16...@linuxfoundation.org/T/#u
David Gow (2):
kasan: test: Make KASAN KUnit test comply with naming guidelines
mm: kasan: Do not panic if both panic_on_warn and kasan_multishot set
Patricia Alfonso (4):
Add KUnit Struct to Current Task
KUnit: KASAN Integration
KASAN: Po
From: Patricia Alfonso
In order to integrate debugging tools like KASAN into the KUnit
framework, add KUnit struct to the current task to keep track of the
current KUnit test.
Signed-off-by: Patricia Alfonso
Reviewed-by: Brendan Higgins
Tested-by: Andrey Konovalov
Signed-off-by: David Gow
resenting if a KASAN report is expected and if a
KASAN report is found
[1]
(https://lore.kernel.org/linux-kselftest/1583251361-12748-1-git-send-email-alan.magu...@oracle.com/T/#t)
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by:
not
enabled, KUnit will print a statement to let the user know this test
was not run with KASAN_STACK enabled.
copy_user_test and kasan_rcu_uaf cannot be run in KUnit so there is a
separate test file for those tests, which can be run as before as a
module.
Signed-off-by: Patricia Alfonso
Sign
/20200702071416.1780522-1-david...@google.com/
Signed-off-by: David Gow
Tested-by: Andrey Konovalov
---
lib/Makefile| 6 +++---
lib/{test_kasan.c => kasan_kunit.c} | 0
2 files changed, 3 insertions(+), 3 deletions(-)
rename lib/{test_kasan.c => kasan_kunit.c} (100%)
diff
warnings show up).
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Brendan Higgins
Tested-by: Andrey Konovalov
---
mm/kasan/report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index e2c14b10bc81..00a53f1355ae 100644
From: Patricia Alfonso
Include documentation on how to test KASAN using CONFIG_TEST_KASAN_KUNIT
and CONFIG_TEST_KASAN_MODULE.
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Dmitry Vyukov
Acked-by: Brendan Higgins
Tested-by: Andrey
On Thu, Aug 27, 2020 at 9:14 PM Marco Elver wrote:
>
> On Thu, Jul 02, 2020 at 12:14AM -0700, David Gow wrote:
> > As discussed in [1], KUnit tests have hitherto not had a particularly
> > consistent naming scheme. This adds documentation outlining how tests
> > and tes
/202006141005.BA19A9D3@keescook/t/#u
Signed-off-by: David Gow
Reviewed-by: Kees Cook
Reviewed-by: Brendan Higgins
---
This is v2 of the KUnit test nomenclature guidelines. The guidelines have
changed a bit in response to the discussion on the v1 thread which came
about after plumbers. The major
From: Patricia Alfonso
Include documentation on how to test KASAN using CONFIG_TEST_KASAN_KUNIT
and CONFIG_TEST_KASAN_MODULE.
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Dmitry Vyukov
Acked-by: Brendan Higgins
Tested-by: Andrey
3e88e-1356-cd63-9152-209b81b16...@linuxfoundation.org/T/#u
David Gow (1):
mm: kasan: Do not panic if both panic_on_warn and kasan_multishot set
Patricia Alfonso (4):
Add KUnit Struct to Current Task
KUnit: KASAN Integration
KASAN: Port KASAN Tests to KUnit
KASAN: Testing Documentation
Documenta
From: Patricia Alfonso
In order to integrate debugging tools like KASAN into the KUnit
framework, add KUnit struct to the current task to keep track of the
current KUnit test.
Signed-off-by: Patricia Alfonso
Reviewed-by: Brendan Higgins
Tested-by: Andrey Konovalov
Signed-off-by: David Gow
warnings show up).
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Brendan Higgins
Tested-by: Andrey Konovalov
---
mm/kasan/report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index e2c14b10bc81..00a53f1355ae 100644
not
enabled, KUnit will print a statement to let the user know this test
was not run with KASAN_STACK enabled.
copy_user_test and kasan_rcu_uaf cannot be run in KUnit so there is a
separate test file for those tests, which can be run as before as a
module.
Signed-off-by: Patricia Alfonso
Sign
resenting if a KASAN report is expected and if a
KASAN report is found
[1]
(https://lore.kernel.org/linux-kselftest/1583251361-12748-1-git-send-email-alan.magu...@oracle.com/T/#t)
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by:
On Tue, Sep 1, 2020 at 7:47 AM Kees Cook wrote:
>
> On Fri, Aug 28, 2020 at 12:17:05AM +0800, David Gow wrote:
> > On Thu, Aug 27, 2020 at 9:14 PM Marco Elver wrote:
> > > Just an idea: Maybe the names are also an opportunity to distinguish
> > > real _unit_
5] https://bugzilla.kernel.org/show_bug.cgi?id=206337
[6]
https://lore.kernel.org/linux-kselftest/20200620054944.167330-1-david...@google.com/
[7] https://lkml.org/lkml/2020/7/31/571
David Gow (1):
mm: kasan: Do not panic if both panic_on_warn and kasan_multishot set
Patricia Alfonso (4):
Add KUnit
resenting if a KASAN report is expected and if a
KASAN report is found
[1]
(https://lore.kernel.org/linux-kselftest/1583251361-12748-1-git-send-email-alan.magu...@oracle.com/T/#t)
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by:
From: Patricia Alfonso
In order to integrate debugging tools like KASAN into the KUnit
framework, add KUnit struct to the current task to keep track of the
current KUnit test.
Signed-off-by: Patricia Alfonso
Reviewed-by: Brendan Higgins
Signed-off-by: David Gow
---
include/linux/sched.h | 4
not
enabled, KUnit will print a statement to let the user know this test
was not run with KASAN_STACK enabled.
copy_user_test and kasan_rcu_uaf cannot be run in KUnit so there is a
separate test file for those tests, which can be run as before as a
module.
Signed-off-by: Patricia Alfonso
Sign
From: Patricia Alfonso
Include documentation on how to test KASAN using CONFIG_TEST_KASAN_KUNIT
and CONFIG_TEST_KASAN_MODULE.
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Dmitry Vyukov
Acked-by: Brendan Higgins
---
Documentation/dev
warnings show up).
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Brendan Higgins
---
mm/kasan/report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index e2c14b10bc81..00a53f1355ae 100644
--- a/mm/kasan/report.c
+++ b
On Fri, Jul 31, 2020 at 9:25 PM 'Andrey Konovalov' via kasan-dev
wrote:
>
> On Fri, Jul 31, 2020 at 6:43 AM David Gow wrote:
> >
> > This patchset contains everything needed to integrate KASAN and KUnit.
> >
> > KUnit will be able to:
> > (1) Fail tests w
On Sat, Aug 1, 2020 at 3:10 PM David Gow wrote:
>
> From: Patricia Alfonso
>
> Transfer all previous tests for KASAN to KUnit so they can be run
> more easily. Using kunit_tool, developers can run these tests with their
> other KUnit tests and see "pass" or "
warnings show up).
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Brendan Higgins
Tested-by: Andrey Konovalov
---
mm/kasan/report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index e2c14b10bc81..00a53f1355ae 100644
From: Patricia Alfonso
In order to integrate debugging tools like KASAN into the KUnit
framework, add KUnit struct to the current task to keep track of the
current KUnit test.
Signed-off-by: Patricia Alfonso
Reviewed-by: Brendan Higgins
Tested-by: Andrey Konovalov
Signed-off-by: David Gow
From: Patricia Alfonso
Include documentation on how to test KASAN using CONFIG_TEST_KASAN_KUNIT
and CONFIG_TEST_KASAN_MODULE.
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Dmitry Vyukov
Acked-by: Brendan Higgins
Tested-by: Andrey
not
enabled, KUnit will print a statement to let the user know this test
was not run with KASAN_STACK enabled.
copy_user_test and kasan_rcu_uaf cannot be run in KUnit so there is a
separate test file for those tests, which can be run as before as a
module.
Signed-off-by: Patricia Alfonso
Sign
/lkml/2020/7/31/571
[8]
https://lore.kernel.org/linux-kselftest/8d43e88e-1356-cd63-9152-209b81b16...@linuxfoundation.org/T/#u
[9] https://www.spinics.net/lists/kernel/msg3660451.html
David Gow (1):
mm: kasan: Do not panic if both panic_on_warn and kasan_multishot set
Patricia Alfonso (4):
Add KUnit
resenting if a KASAN report is expected and if a
KASAN report is found
[1]
(https://lore.kernel.org/linux-kselftest/1583251361-12748-1-git-send-email-alan.magu...@oracle.com/T/#t)
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by:
[+kasan-dev, +kunit-dev]
On Mon, Sep 14, 2020 at 3:01 PM Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the akpm-current tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> In file included from lib/test_kasan_module.c:16:
> lib/../mm/kasan/kasan.h:232:6:
/202006141005.BA19A9D3@keescook/t/#u
Signed-off-by: David Gow
Reviewed-by: Kees Cook
Reviewed-by: Brendan Higgins
Reviewed-by: Marco Elver
Reviewed-by: Tim Bird
---
This is v3 of the KUnit test naming guidelines. It's basically just v2
with some spelling fixes (thanks Marco).
Changelog:
v3
ash ('/') to a sub-directory
> name -- this is how the text mostly appears in other Kconfig files.
>
> Signed-off-by: Randy Dunlap
> Cc: David Gow
> Cc: linux-kselft...@vger.kernel.org
> Cc: kunit-...@googlegroups.com
> Cc: Shuah Khan
> Cc: Shuah Khan
> Cc: Brendan Higgins
diagnostic lines, so that
these statistics do not prevent the result from parsing.
Signed-off-by: David Gow
---
This is largely a follow-up to the discussion here:
https://lore.kernel.org/linux-kselftest/CABVgOSmy4n_LGwDS7yWfoLftcQzxv6S+iXx9Y=opcgg2gu0...@mail.gmail.com/T/#t
Does this seem like a sensib
Various helper functions were misspelling "diagnostic" in their names.
It finally got annoying, so fix it.
Signed-off-by: David Gow
---
tools/testing/kunit/kunit_parser.py | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/tools/tes
from the
> list for _every_ outer iteration.
>
> Signed-off-by: Daniel Latypov
> ---
Thanks! This works great here: I didn't time it to see how much faster
it is, but it's clearly an improvement.
Reviewed-by: David Gow
Cheers,
-- David
-by: David Gow
Fixes: 757055ae8ded ("init/console: Use ttynull as a fallback when there is no
console")
---
tools/testing/kunit/kunit_kernel.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/kunit/kunit_kernel.py
b/tools/testing/kunit/kunit_kerne
de
> guidance for testing many inputs") to show a minimal example of the new
> feature.
>
> Signed-off-by: Daniel Latypov
> ---
This looks good to me. Thanks!
Reviewed-by: David Gow
-- David
smime.p7s
Description: S/MIME Cryptographic Signature
On Wed, Dec 16, 2020 at 10:53 PM Quentin Monnet wrote:
>
> 2020-11-21 17:48 UTC+0800 ~ David Gow
> > On Sat, Nov 21, 2020 at 3:38 PM Andrii Nakryiko
> > wrote:
> >>
> >> On Thu, Nov 19, 2020 at 12:51 AM David Gow wrote:
> >>>
> >
/linux.git/tree/fs/ext4/inode-test.c
Signed-off-by: David Gow
Acked-by: OGAWA Hirofumi
---
Changes since v3:
https://lore.kernel.org/linux-kselftest/20201021061713.1545931-1-david...@google.com/
- Update the Kconfig entry to use "depends on" rather than "select", as
discus
On Fri, Oct 23, 2020 at 10:07 PM Theodore Y. Ts'o wrote:
>
> On Thu, Oct 22, 2020 at 04:52:52PM -0700, Brendan Higgins wrote:
> > So you, me, Luis, David, and a whole bunch of other people have been
> > thinking about this problem for a while. What if we just put
> > kunitconfig fragments in
/linux.git/tree/fs/ext4/inode-test.c
Signed-off-by: David Gow
Acked-by: OGAWA Hirofumi
---
Whoops! Sent out a broken early version of this as v4 instead.
Sorry about that!
-- David
Changes since v4:
https://lore.kernel.org/linux-kselftest/20201024052047.2526780-1-david...@google.com/
- Fix
/linux.git/tree/fs/ext4/inode-test.c
Signed-off-by: David Gow
Acked-by: OGAWA Hirofumi
---
I am _so_ sorry: I sent out the wrong version again! It's clearly not my
day! This version actually has the fix!
-- David
Changes since v4/v5:
https://lore.kernel.org/linux-kselftest
On Thu, Nov 12, 2020 at 12:55 AM Bird, Tim wrote:
>
>
>
> > -Original Message-
> > From: David Gow
> >
> > On Wed, Nov 11, 2020 at 1:02 AM Bird, Tim wrote:
> > >
> > > > -Original Message-
> > > > From:
Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
functions, it should depend on HAS_IOMEM.
This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
HAS_IOMEM.
Signed-off-by: David Gow
---
drivers/fpga/Kconfig
]:
- MFD_HI6421_SPMI [=y] && STAGING [=y] && OF [=y] && SPMI [=y]
By specifying HAS_IOMEM as a dependency for MFD_HI6421_SPMI (as
SPMI_HISI3670 already dows), this issue is resolved, and no such warning
appears when building on architectures without HAS_IOMEM.
Signed-off-by: David G
= in tools/scripts/Makefile.include.
Signed-off-by: David Gow
---
Hi all,
I'm not 100% sure this is the correct fix here -- it seems to work for
me, and makes some sense, but let me know if there's a better way.
One other thing worth noting is that I've been hitting this with
make allyesconfig
On Fri, Nov 20, 2020 at 2:27 PM Moritz Fischer wrote:
>
> Hi David,
>
> On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote:
> > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> > 'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
> &g
On Thu, Nov 12, 2020 at 8:37 PM Marco Elver wrote:
>
> On Thu, Nov 12, 2020 at 04:18PM +0800, David Gow wrote:
> > On Thu, Nov 12, 2020 at 12:55 AM Bird, Tim wrote:
> [...]
> > > > kunit_tool has a bug when parsing the comments / diagnostic lines,
> > > &
On Fri, Nov 13, 2020 at 6:31 PM Marco Elver wrote:
>
> On Fri, Nov 13, 2020 at 01:17PM +0800, David Gow wrote:
> > On Thu, Nov 12, 2020 at 8:37 PM Marco Elver wrote:
> [...]
> > > > (It also might be a little tricky with the current implementation to
&g
On Sat, Nov 14, 2020 at 9:38 AM Arpitha Raghunandan <98.a...@gmail.com> wrote:
>
> On 14/11/20 5:44 am, Marco Elver wrote:
> >
> > Arpitha: Do you want to send v7, but with the following modifications
> > from what I proposed? Assuming nobody objects.
> >
> > 1. Remove the num_params counter and
On Tue, Oct 20, 2020 at 6:46 AM Daniel Latypov wrote:
>
> Add basic test coverage for files that don't require any config options:
> * gcd.c
> * lcm.c
> * int_sqrt.c
> * reciprocal_div.c
> (Ignored int_pow.c since it's a simple textbook algorithm.)
>
I don't see a particular reason why int_pow.c
On Tue, Oct 20, 2020 at 2:51 PM OGAWA Hirofumi
wrote:
>
> David Gow writes:
>
> > diff --git a/fs/fat/misc.c b/fs/fat/misc.c
> > index f1b2a1fc2a6a..445ad3542e74 100644
> > --- a/fs/fat/misc.c
> > +++ b/fs/fat/misc.c
> > @@ -229,6 +229,7 @@ void fat_
dates the document for this.
>
> Fixes: 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module")
> Signed-off-by: SeongJae Park
Sorry for the delay in looking at this. Apart from another minuscule
typo below, this looks good to me.
Reviewed-by: David Gow
Cheers,
-- Davi
/linux.git/tree/fs/ext4/inode-test.c
Signed-off-by: David Gow
Acked-by: OGAWA Hirofumi
---
Changes since v2:
https://lore.kernel.org/linux-kselftest/20201020055856.1270482-1-david...@google.com/
- Comment that the export for fat_time_fat2unix() function is for KUnit
tests.
Changes since v1
JSON")
Signed-off-by: David Gow
---
This is a quick fix because kunit.py parse is completely broken: it
appears it was introduced in the rebase of the JSON parser after the
separation of concerns patch.
tools/testing/kunit/kunit.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Thu, Oct 22, 2020 at 5:15 AM Brendan Higgins
wrote:
>
> On Tue, Oct 20, 2020 at 12:37 AM Geert Uytterhoeven
> wrote:
> >
> > EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the
> > user may not want to enable. Fix this by making the test depend on
> > EXT4_FS instead.
> >
> Signed-off-by: Brendan Higgins
Excellent: this fixes all of the failing tests in kunit_tool_test.py for me.
Reviewed-by: David Gow
-- David
> ---
> tools/testing/kunit/kunit_tool_test.py| 32 ++
> .../test_data/test_config_printk_time.log | Bi
: 45ba7a893ad89114e773b3dc32f6431354c465d6 ("kunit: kunit_tool: Separate
out config/build/exec/parse")
Signed-off-by: David Gow
---
tools/testing/kunit/kunit_parser.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/kunit/kunit_parser.py
b/tools/testing/kunit/kunit_parser.py
index 8019e3dd4c32..744ee9cb0
est: EXPECTATION FAILED at
> lib/kunit/kunit-example-test.c:29
> [16:16:46] Expected 1 + 1 == 3, but
> [16:16:46] 1 + 1 == 2
> [16:16:46] 3 == 3
> [16:16:46] not ok 1 - example_simple_test
> [16:16:46]
>
> Signed-off-by: Daniel Latypov
> ---
Thanks! This
on ‘kunit_test_successful_try’:
> ../lib/kunit/kunit-test.c:19:2: error: unknown type name ‘invalid_type’
>19 | invalid_type *test = data;
> | ^~~~
> ...
>
> Signed-off-by: Daniel Latypov
> ---
Thanks a lot -- this was really bugging me, and works great.
Reviewed-by: David Gow
script runs, rather than have to
use mypy as a tool to verify it separately? Otherwise, maybe we can
run it automatically from the kunit_tool_test.py unit tests or
something similar?
Regardless, this is
Reviewed-by: David Gow
Cheers,
-- David
On Fri, Oct 30, 2020 at 1:41 PM Daniel Latypov wrote:
>
> On Thu, Oct 29, 2020 at 7:34 PM David Gow wrote:
> >
> > On Wed, Oct 21, 2020 at 7:32 AM Daniel Latypov wrote:
> > >
> > > For simplcity, strip all trailing whitespace from parsed output.
> > >
On Fri, Oct 30, 2020 at 2:17 PM Daniel Latypov wrote:
>
> Currently --raw_output means nothing gets shown.
> Why?
> Because `raw_output()` has a `yield` and therefore is a generator, which
> means it only executes when you ask it for a value.
>
> Given no one actually is using it as a generator
elftest/20201020233219.4146059-1-dlaty...@google.com/
>
> Signed-off-by: Daniel Latypov
> ---
Thanks!
I tried this out against everything I could (including the nastier
--alltests option), and didn't hit any problems, so it looks good to
go to me!
Reviewed-by: David Gow
Tested-by: David Gow
Cheers,
-- David
mmio resources in their own
feature drivers")
Signed-off-by: David Gow
---
Changes since v1:
(
https://lore.kernel.org/linux-fpga/20201119082209.3598354-1-david...@google.com/
)
- Add Fixes tag
drivers/fpga/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/fpga/Kconfig b/dr
On Sat, Nov 21, 2020 at 3:38 PM Andrii Nakryiko
wrote:
>
> On Thu, Nov 19, 2020 at 12:51 AM David Gow wrote:
> >
> > If BPF_PRELOAD is enabled, and an out-of-tree build is requested with
> > make O=, compilation seems to fail with:
> >
> > tools/scripts/M
On Mon, Nov 9, 2020 at 2:49 PM Arpitha Raghunandan <98.a...@gmail.com> wrote:
>
> On 07/11/20 3:36 pm, Marco Elver wrote:
> > On Sat, 7 Nov 2020 at 05:58, David Gow wrote:
> >> On Sat, Nov 7, 2020 at 3:22 AM Arpitha Raghunandan <98.a...@gmail.com>
>
] and the draft KTAP spec[2] are
expecting.
[1]: http://testanything.org/tap-specification.html
[2]:
https://lore.kernel.org/linux-kselftest/cy4pr13mb1175b804e31e502221bc8163fd...@cy4pr13mb1175.namprd13.prod.outlook.com/T/
Signed-off-by: David Gow
---
tools/testing/kunit/kunit_parser.py | 7 --
On Wed, Nov 11, 2020 at 1:02 AM Bird, Tim wrote:
>
>
>
> > -Original Message-
> > From: David Gow
> >
> > On Mon, Nov 9, 2020 at 2:49 PM Arpitha Raghunandan <98.a...@gmail.com>
> > wrote:
> > >
> > > On 07/11/20 3:36 pm, Ma
n be turned into subsubtest outputs.
>
> Signed-off-by: Arpitha Raghunandan <98.a...@gmail.com>
> Co-developed-by: Marco Elver
> Signed-off-by: Marco Elver
> ---
[Resending this because my email client re-defaulted to HTML! Aarrgh!]
This looks good to me! I tested it in UML an
debugfs results file. But
that's clearly not an issue with this patch, and the actual combined
result is still present (and the complete results should show up in
dmesg anyway).
Tested-by: David Gow
Reviewed-by: David Gow
Thanks!
-- David
typov
> ---
I won't pretend to be an expert on Python, but this seems good to me.
I tested it on my machine and it works fine.
So,
Reviewed-by: David Gow
-- Davkd
> tools/testing/kunit/kunit_tool_test.py | 14 ++
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
&
d the older code a
touch more easily.
In any case,
Reviewed-by: David Gow
-- David
On Tue, Dec 1, 2020 at 7:33 AM Daniel Latypov wrote:
>
> get_absolute_path() makes an attempt to allow for this.
> But that doesn't work as soon as os.chdir() gets called.
Can we explain why this doesn't work? It's because the test_data/
files are accessed with relative paths, so chdir breaks
On Tue, Dec 1, 2020 at 7:33 AM Daniel Latypov wrote:
>
> 1. the name is a lie. It gives relative paths, e.g. if I run from the
> same dir as the test file, it gives './test_data/'
>
> 2. it's only used for generating paths to tools/testing/kunit/test_data/
> So we can tersen things by making it
tty sensible from my rudimentary
python knowledge.
Reviewed-by: David Gow
Cheers,
-- David
On Mon, Nov 23, 2020 at 9:08 PM Marco Elver wrote:
>
> On Tue, 17 Nov 2020 at 08:21, David Gow wrote:
> > On Mon, Nov 16, 2020 at 1:41 PM Arpitha Raghunandan <98.a...@gmail.com>
> > wrote:
> > >
> > > Implementation of support for parameterized test
On Fri, Dec 4, 2020 at 3:41 AM Daniel Latypov wrote:
>
> LinuxSourceTree will unceremoniously crash if the user doesn't call
> read_kunitconfig() first in a number of functions.
This patch seems to partly be reverting the changes here, right:
3fc48259d525 ("kunit: Don't
> fail test suites if one of them is empty").
>
> Also slightly simplify the code and add type annotations.
>
> Signed-off-by: Daniel Latypov
> ---
Otherwise, the actual code changes all seem sensible, and it worked
fine when I tested it, so:
Reviewed-by: David Gow
-- David
s looks good to me: I gave it some quick testing, and reading
through it, all of the changes seem sensible.
I wasn't able to get pytype running here, but mypy worked fine.
Reviewed-by: David Gow
-- David
On Sat, Dec 5, 2020 at 2:18 AM Daniel Latypov wrote:
>
> On Thu, Dec 3, 2020 at 7:57 PM David Gow wrote:
> >
> > On Fri, Dec 4, 2020 at 3:41 AM Daniel Latypov wrote:
> > >
> > > LinuxSourceTree will unceremoniously crash if the user doesn't call
> &
On Wed, Dec 2, 2020 at 3:00 AM Daniel Latypov wrote:
>
> On Mon, Nov 30, 2020 at 11:33 PM David Gow wrote:
> >
> > On Tue, Dec 1, 2020 at 7:33 AM Daniel Latypov wrote:
> > >
> > > get_absolute_path() makes an attempt to allow for this.
> > > But
On Wed, Dec 2, 2020 at 6:06 PM Andy Shevchenko
wrote:
>
> On Wed, Dec 02, 2020 at 09:51:19AM +0530, Arpitha Raghunandan wrote:
> > On 01/12/20 4:36 pm, Andy Shevchenko wrote:
> > > On Tue, Dec 1, 2020 at 9:21 AM Arpitha Raghunandan <98.a...@gmail.com>
> > > wrote:
>
> ...
>
> > >> I ran both the
On Wed, Dec 2, 2020 at 8:21 PM Andy Shevchenko
wrote:
>
> On Wed, Dec 2, 2020 at 1:57 PM David Gow wrote:
> > On Wed, Dec 2, 2020 at 6:06 PM Andy Shevchenko
> > wrote:
> > > On Wed, Dec 02, 2020 at 09:51:19AM +0530, Arpitha Raghunandan wrote:
>
> ...
>
> &
ov
> ---
This patch hasn't changed since v1, right?
It's still:
Reviewed-by: David Gow
Cheers,
-- David
side.
>
> Do so to make the code more Pythonic.
>
> Signed-off-by: Daniel Latypov
> ---
Reviewed-by: David Gow
Cheers,
-- David
yg1wg0zddbtlosucob-gwmexlgvt...@mail.gmail.com/
>
> Fixes: 5578d008d9e0 ("kunit: tool: fix running kunit_tool from outside kernel
> tree")
> Signed-off-by: Daniel Latypov
> ---
Thanks: I much prefer this to v1. Having it work the same way as
test_tmpdir is a bonus.
Reviewed-by: David Gow
Cheers,
-- David
ck of exception types. self.assertRaises does this.
> * s/kall/call. There's no reason to name it this way.
> * This is probably a misunderstanding from the docs which uses it
> since `mock.call` is in scope as `call`.
>
> Signed-off-by: Daniel Latypov
> ---
Looks good, thanks!
Reviewed-by: David Gow
-- David
nit_parser: make parser more robust")
> Signed-off-by: Brendan Higgins
> ---
Reviewed-by: David Gow
Thanks. I wasn't able to find any issues which required those files to
be binary.
For the record, a link to the original issue, which appeared to be
with whitespace (spaces before tabs) i
1 - 100 of 201 matches
Mail list logo
