Re: [discuss] ide=reverse do we still need this?

2008-02-13 Thread Dirk GOUDERS
Hi, I'm reworking the pci device list logic (we currently keep all PCI devices in 2 lists, which isn't the nicest, we should be able to get away with only 1 list.) The only bother I've found so far is the pci_get_device_reverse() function, it's used in 2 places, IDE and the calgary driver.

Re: [discuss] ide=reverse do we still need this?

2008-02-13 Thread Dirk GOUDERS
Hm, so, to summarize: - you needed this option many years ago to get a box to work properly - you don't need this today I would summarize: - ide=reverse solved certain problems and I am not sure if there are users who still need this option So, if the option went away, you

Re: [discuss] ide=reverse do we still need this?

2008-02-13 Thread Dirk GOUDERS
Hm, so, to summarize: - you needed this option many years ago to get a box to work properly - you don't need this today So, if the option went away, you would not be inconvenienced? After having reanimated the old system and after comments of other persons I would not be inconvenienced

[BUG] Problem with commit cf03c5dac83609f09d9f0e9fa3c09d86daed614d

2012-07-26 Thread Dirk Gouders
Hi Seth, today, I noticed a problem with the current kernel (3.5.0-04773-gbdc0077): my laptop hangs during boot -- the last message on the console is printed just before invoking `udevadm trigger'. I bisected the problem and ended at commit cf03c5dac83609f09d9f0e9fa3c09d86daed614d (brcm80211:

Re: [BUG] Problem with commit cf03c5dac83609f09d9f0e9fa3c09d86daed614d

2012-07-26 Thread Dirk Gouders
Seth Forshee seth.fors...@canonical.com writes: On Thu, Jul 26, 2012 at 03:28:44PM +0200, Dirk Gouders wrote: Hi Seth, today, I noticed a problem with the current kernel (3.5.0-04773-gbdc0077): my laptop hangs during boot -- the last message on the console is printed just before invoking

Re: [BUG] Problem with commit cf03c5dac83609f09d9f0e9fa3c09d86daed614d

2012-07-26 Thread Dirk Gouders
Seth Forshee seth.fors...@canonical.com writes: On Thu, Jul 26, 2012 at 05:07:57PM +0200, Dirk Gouders wrote: Hi Seth, thanks for your reply and sorry for the noise. I followed your advice and tried to boot with the WLAN interface turned off, and the problem still exists. I'll start

Re: [BUG] Problem with commit cf03c5dac83609f09d9f0e9fa3c09d86daed614d

2012-07-27 Thread Dirk Gouders
Dirk Gouders goud...@et.bocholt.fh-gelsenkirchen.de writes: Seth Forshee seth.fors...@canonical.com writes: On Thu, Jul 26, 2012 at 05:07:57PM +0200, Dirk Gouders wrote: Hi Seth, thanks for your reply and sorry for the noise. I followed your advice and tried to boot with the WLAN

[RFC PATCH] netconsole.txt: nc needs -p to specify the listening port

2012-07-27 Thread Dirk Gouders
-off-by: Dirk Gouders goud...@et.bocholt.fh-gelsenkirchen.de --- Documentation/networking/netconsole.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/networking/netconsole.txt b/Documentation/networking/netconsole.txt index 8d02207..ffe30a7 100644

Re: [RFC PATCH] netconsole.txt: nc needs -p to specify the listening port

2012-07-27 Thread Dirk Gouders
Cong Wang xiyou.wangc...@gmail.com writes: On Fri, Jul 27, 2012 at 2:35 PM, Dirk Gouders goud...@et.bocholt.fh-gelsenkirchen.de wrote: Hi Jesse, I would like to ask you to check if the documentation of nc in netconsole.txt is still correct. I tried two different netcat packages and both

Re: [RFC PATCH] netconsole.txt: nc needs -p to specify the listening port

2012-07-28 Thread Dirk Gouders
Borislav Petkov b...@alien8.de writes: On Fri, Jul 27, 2012 at 11:24:53AM +0200, Dirk Gouders wrote: Cong Wang xiyou.wangc...@gmail.com writes: On Fri, Jul 27, 2012 at 2:35 PM, Dirk Gouders goud...@et.bocholt.fh-gelsenkirchen.de wrote: Hi Jesse, I would like to ask you to check

Re: [RFC] netconsole.txt: nc needs -p to specify the listening port

2012-07-29 Thread Dirk Gouders
Milton Miller milt...@bga.com writes: [adding Rob as Doc maintanier] On Sat, 28 Jul 2012 about 11:08:16 -, Dirk Gouders wrote: Borislav Petkov b...@alien8.de writes: On Fri, Jul 27, 2012 at 11:24:53AM +0200, Dirk Gouders wrote: Cong Wang xiyou.wangc...@gmail.com writes: On Fri

Re: [RFC] netconsole.txt: nc needs -p to specify the listening port

2012-08-09 Thread Dirk Gouders
Cong Wang xiyou.wangc...@gmail.com writes: On 08/03/2012 02:33 PM, Dirk Gouders wrote: From b3aec70d785d338b1b643fece6606cd32addaf0c Mon Sep 17 00:00:00 2001 From: Dirk Gouders goud...@et.bocholt.fh-gelsenkirchen.de Date: Thu, 2 Aug 2012 22:20:16 +0200 Subject: [PATCH] netconsole.txt

Re: [PATCH v2 4/6] menuconfig: Add jump keys to search results

2012-08-27 Thread Dirk Gouders
Benjamin Poirier bpoir...@suse.de writes: makes it possible to jump directly to the menu for a configuration entry after having searched for it with '/'. If this menu is not currently accessible we jump to the nearest accessible parent instead. After exiting this menu, the user is returned to

Re: [RFC] netconsole.txt: nc needs -p to specify the listening port

2012-08-01 Thread Dirk Gouders
Rob Landley r...@landley.net writes: On 07/29/2012 03:40 AM, Milton Miller wrote: [adding Rob as Doc maintanier] On Sat, 28 Jul 2012 about 11:08:16 -, Dirk Gouders wrote: Borislav Petkov b...@alien8.de writes: On Fri, Jul 27, 2012 at 11:24:53AM +0200, Dirk Gouders wrote: Cong Wang

Re: [RFC] netconsole.txt: nc needs -p to specify the listening port

2012-08-02 Thread Dirk Gouders
Dirk Gouders goud...@et.bocholt.fh-gelsenkirchen.de writes: Rob Landley r...@landley.net writes: On 07/29/2012 03:40 AM, Milton Miller wrote: [adding Rob as Doc maintanier] On Sat, 28 Jul 2012 about 11:08:16 -, Dirk Gouders wrote: Borislav Petkov b...@alien8.de writes: On Fri, Jul

Re: [RFC] netconsole.txt: nc needs -p to specify the listening port

2012-08-03 Thread Dirk Gouders
Cong Wang xiyou.wangc...@gmail.com writes: On Fri, Aug 3, 2012 at 4:39 AM, Dirk Gouders goud...@et.bocholt.fh-gelsenkirchen.de wrote: From d756d2750e4cf07d3c0942dc3c491d57631d4338 Mon Sep 17 00:00:00 2001 From: Dirk Gouders goud...@et.bocholt.fh-gelsenkirchen.de Date: Thu, 2 Aug 2012 22:20

[RFC] kconfig/mconf.c: revision of curses initialization.

2012-08-06 Thread Dirk Gouders
is better done in that function... Dirk From 1a4022eedbee6032dea16f67bbe4028a8d3d07a0 Mon Sep 17 00:00:00 2001 From: Dirk Gouders goud...@et.bocholt.fh-gelsenkirchen.de Date: Mon, 6 Aug 2012 16:48:23 +0200 Subject: [PATCH

Re: [RFC trivial] printk.c: /proc/vmcore instead of /proc/vmcoreinfo in comments?

2013-11-06 Thread Dirk Gouders
Joe Perches j...@perches.com writes: On Tue, 2013-10-22 at 14:15 +0200, Dirk Gouders wrote: Hello Joe, when having a look at printk.c, I noticed that two comments refer to /proc/vmcoreinfo and I wonder if that should not read /proc/vmcore. While at it, a typo in one of those coments

Re: [PATCH 4/4] kconfig: remove unused definition from scanner

2013-10-02 Thread Dirk Gouders
Martin Walch walch.mar...@web.de writes: From: Martin Walch walch.mar...@web.de Date: Wed, 2 Oct 2013 06:58:46 +0200 Subject: [PATCH 4/4] kconfig: remove unused definition from scanner The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion. Hi Martin, I think you should

Re: [PATCH 4/4] kconfig: remove unused definition from scanner

2013-10-03 Thread Dirk Gouders
Martin Walch walch.mar...@web.de writes: On Wednesday 02 October 2013 08:57:54 Yann E. MORIN wrote: On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote: I think you should also regenerate the scanner and add the new zconf.lex.c_shipped to this patch. I think sending the re-generated

[BUG bisected] WARNING: CPU: 0 PID: 1550 at net/wireless/chan.c:373 cfg80211_chandef_usable+0x30/0x15f()

2013-10-21 Thread Dirk Gouders
Hello Simon, all, Recently, I noticed many traces (find a sample attached) in situations when wpa_supplicant is running but no appropriate access-point available. I started a bisect and ended at commit 3aede78aad2a7e (mac80211: change IBSS channel state to chandef). Please let me know if you

tools/lib/lk: redefinition of _FORTIFY_SOURCE (gcc-4.7.2)

2013-05-22 Thread Dirk Gouders
Hello Borislav, I am having problems with building liblk, but opposed to the recent problem that Jiri noticed (commit b28b130719af6 Fix _FORTIFY_SOURCE builds) I am getting errors because _FORTIFY_SOURCE is redefined: command-line:0:0: error: _FORTIFY_SOURCE redefined [-Werror] debugfs.c:1:0:

Re: tools/lib/lk: redefinition of _FORTIFY_SOURCE (gcc-4.7.2)

2013-05-22 Thread Dirk Gouders
Dirk Gouders d...@gouders.net writes: What probably might help in any case is undefining _FORTIFY_SOURCE before defining it, because as far as I know, there is no problem with undefining something that is not yet defined, but I could imagine, others might have more elegant suggestions

Re: tools/lib/lk: redefinition of _FORTIFY_SOURCE (gcc-4.7.2)

2013-05-22 Thread Dirk Gouders
Borislav Petkov b...@suse.de writes: Hi, On Wed, May 22, 2013 at 12:00:21PM +0200, Dirk Gouders wrote: CFLAGS = -ggdb3 -Wall -Wextra -std=gnu99 -Werror -O6 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 $(EXTRA_WARNINGS) $(EXTRA_CFLAGS) -fPIC it seems someone else hit this already and fixed it too

Re: tools/lib/lk: redefinition of _FORTIFY_SOURCE (gcc-4.7.2)

2013-05-23 Thread Dirk Gouders
Hi Borislav, Borislav Petkov b...@suse.de writes: Hi, On Wed, May 22, 2013 at 12:00:21PM +0200, Dirk Gouders wrote: CFLAGS = -ggdb3 -Wall -Wextra -std=gnu99 -Werror -O6 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 $(EXTRA_WARNINGS) $(EXTRA_CFLAGS) -fPIC it seems someone else hit this already

[RFC trivial] printk.c: /proc/vmcore instead of /proc/vmcoreinfo in comments?

2013-10-22 Thread Dirk Gouders
:00:00 2001 From: Dirk Gouders d...@gouders.net Date: Tue, 22 Oct 2013 13:51:15 +0200 Subject: [PATCH] printk.c: comments should refer to /proc/vmcore instead of /proc/vmcoreinfo In one of those comments a typo was fixed, too. Signed-off-by: Dirk Gouders d...@gouders.net --- kernel/printk/printk.c

Re: [BUG bisected] WARNING: CPU: 0 PID: 1550 at net/wireless/chan.c:373 cfg80211_chandef_usable+0x30/0x15f()

2013-10-22 Thread Dirk Gouders
:40PM +0200, Dirk Gouders wrote: Hello Simon, all, Recently, I noticed many traces (find a sample attached) in situations when wpa_supplicant is running but no appropriate access-point available. I started a bisect and ended at commit 3aede78aad2a7e (mac80211: change IBSS channel state

Re: [BUG bisected] WARNING: CPU: 0 PID: 1550 at net/wireless/chan.c:373 cfg80211_chandef_usable+0x30/0x15f()

2013-10-22 Thread Dirk Gouders
Hi Simon, Simon Wunderlich s...@simonwunderlich.de writes: Hey Dirk, No need for censorship, I did some quick tests and stripped down my wpa_supplicant.conf to a single entry. With this configuration I get a lot of traces: ctrl_interface=/var/run/wpa_supplicant eapol_version=1

Re: [PATCH 3.12] cfg80211: fix ibss wext chandef creation

2013-10-22 Thread Dirk Gouders
it should be used. Thanks a lot, Simon, I don't see anymore traces here. Tested-by: Dirk Gouders d...@gouders.net Reported-by: Dirk Gouders d...@gouders.net Signed-off-by: Simon Wunderlich s...@simonwunderlich.de Cc: Johannes Berg johannes.b...@intel.com --- net/wireless/ibss.c | 15

Re: [PATCH 3.12] cfg80211: fix ibss wext chandef creation

2013-10-28 Thread Dirk Gouders
Johannes Berg johan...@sipsolutions.net writes: On Tue, 2013-10-22 at 22:02 +0200, Simon Wunderlich wrote: The wext internal chandefs for ibss should be created using the cfg80211_chandef_create() functions. Otherwise the center_freq1 field will not be set and cfg80211_chandef_valid() will

Re: [PATCH 3.12] cfg80211: fix ibss wext chandef creation

2013-10-28 Thread Dirk Gouders
Johannes Berg johan...@sipsolutions.net writes: On Tue, 2013-10-22 at 22:02 +0200, Simon Wunderlich wrote: The wext internal chandefs for ibss should be created using the cfg80211_chandef_create() functions. Otherwise the center_freq1 field will not be set and cfg80211_chandef_valid() will

Re: [PATCH wq/for-3.10-fixes] workqueue: workqueue_congested() shouldn't translate WORK_CPU_UNBOUND into node number

2013-05-14 Thread Dirk Gouders
Tejun Heo t...@kernel.org writes: From d3251859168b0b12841e1b90d6d768ab478dc23d Mon Sep 17 00:00:00 2001 From: Tejun Heo t...@kernel.org Date: Fri, 10 May 2013 11:10:17 -0700 df2d5ae499 (workqueue: map an unbound workqueues to multiple per-node pool_workqueues) made unbound workqueues to

Re: [PATCH] kbuild: Support split debug info

2014-02-09 Thread Dirk Gouders
Andi Kleen a...@linux.intel.com writes: This is an alternative approach to lower the overhead of debug info (as we discussed a few days ago) gcc 4.7+ and newer binutils have a new split debug info debug info model where the debug info is only written once into central .dwo files. This

Re: [PATCH 1/2] kbuild: Support split debug info v3

2014-07-24 Thread Dirk Gouders
Andi Kleen a...@firstfloor.org writes: echo time make -j4 -s KCFLAGS=-gsplit-dwarf time make -j4 -s KCFLAGS=-gsplit-dwarf echo time make -j4 -s KCFLAGS=-g time make -j4 -s KCFLAGS=-g echo time make -j4 -s KCFLAGS=-gsplit-dwarf time make -j4 -s KCFLAGS=-gsplit-dwarf echo time make -j4 -s

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-11 Thread Dirk Gouders
Bjorn Helgaas bhelg...@google.com writes: On Thu, Sep 11, 2014 at 2:33 PM, Dirk Gouders d...@gouders.net wrote: What I was currently trying was to construct a test-environment so that I do not need to do tests and diagnosis on a busy machine. I noticed that this problem seems to start

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-11 Thread Dirk Gouders
Bjorn Helgaas bhelg...@google.com writes: On Thu, Sep 11, 2014 at 3:24 PM, Dirk Gouders d...@gouders.net wrote: Bjorn Helgaas bhelg...@google.com writes: On Thu, Sep 11, 2014 at 2:33 PM, Dirk Gouders d...@gouders.net wrote: What I was currently trying was to construct a test-environment so

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-12 Thread Dirk Gouders
Dirk Gouders d...@gouders.net writes: Bjorn Helgaas bhelg...@google.com writes: On Thu, Sep 11, 2014 at 3:24 PM, Dirk Gouders d...@gouders.net wrote: Bjorn Helgaas bhelg...@google.com writes: On Thu, Sep 11, 2014 at 2:33 PM, Dirk Gouders d...@gouders.net wrote: What I was currently trying

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-12 Thread Dirk Gouders
Dirk Gouders d...@gouders.net writes: Dirk Gouders d...@gouders.net writes: Bjorn Helgaas bhelg...@google.com writes: On Thu, Sep 11, 2014 at 3:24 PM, Dirk Gouders d...@gouders.net wrote: Bjorn Helgaas bhelg...@google.com writes: On Thu, Sep 11, 2014 at 2:33 PM, Dirk Gouders d

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-12 Thread Dirk Gouders
Yinghai Lu ying...@kernel.org writes: On Fri, Sep 12, 2014 at 1:05 PM, Dirk Gouders d...@gouders.net wrote: Dirk Gouders d...@gouders.net writes: I now applied your patches and tested them: echo 1 /sys/bus/pci/devices/\:00\:0a.0/pcie_link_disable echo 0 /sys/bus/pci/devices/\:00

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-12 Thread Dirk Gouders
Yinghai Lu ying...@kernel.org writes: On Fri, Sep 12, 2014 at 1:54 PM, Dirk Gouders d...@gouders.net wrote: Yinghai Lu ying...@kernel.org writes: On Fri, Sep 12, 2014 at 1:05 PM, Dirk Gouders d...@gouders.net wrote: Dirk Gouders d...@gouders.net writes: -[:00]-+-01.0-[01-02]--+-0d.0-[02

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-12 Thread Dirk Gouders
Yinghai Lu ying...@kernel.org writes: On Fri, Sep 12, 2014 at 3:05 PM, Dirk Gouders d...@gouders.net wrote: Yinghai Lu ying...@kernel.org writes: On Fri, Sep 12, 2014 at 1:54 PM, Dirk Gouders d...@gouders.net wrote: Yinghai Lu ying...@kernel.org writes: On Fri, Sep 12, 2014 at 1:05 PM

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-13 Thread Dirk Gouders
. For that reason, I like fix 2, but we don't know whether it actually works, and we don't have a patch for it yet. This revert is fix 3, which also sweeps the LSI FC issue under the rug. Link: https://bugzilla.kernel.org/show_bug.cgi?id=84281 Reported-by: Dirk Gouders d

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-13 Thread Dirk Gouders
Dirk Gouders d...@gouders.net writes: Bjorn Helgaas bhelg...@google.com writes: I want to fix this regression before v3.17. Dirk, can you test the following patch on top of v3.17-rc2? I'm hoping you can try this on your test machine in conjunction with your acpi_pci_root_add

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-14 Thread Dirk Gouders
Andreas Noever andreas.noe...@gmail.com writes: This is an implementation of fix 1 (Add a quirk to fix the _CRS information based on what amd_bus.c read from the hardware) which makes pci=nocrs ignore bus numbers from crs. If this works then we can add the board to the crs blacklist (Dirk

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-14 Thread Dirk Gouders
Andreas Noever andreas.noe...@gmail.com writes: Updated version with dmi strings. Dirk can you test this (without pci=nocrs) and look for PCI: Ignoring host bridge windows from ACPI If it does not show up then I have messed up the DMI_MATCH macros. In that case please try to boot with

Re: [PATCH v2 1/2] kconfig: fix bad syntactic transformation in expr.c

2014-10-07 Thread Dirk Gouders
CC: Michal added Paul Bolle pebo...@tiscali.nl writes: On Mon, 2014-09-22 at 19:13 +0200, Martin Walch wrote: expr_eliminate_dups2() in scripts/kconfig/expr.c applies two bad inference rules: (FOO || BAR) (!FOO !BAR) - n (FOO BAR) || (!FOO || !BAR) - y They would be correct in

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-19 Thread Dirk Gouders
Yinghai Lu ying...@kernel.org writes: On Fri, Sep 12, 2014 at 5:11 PM, Dirk Gouders d...@gouders.net wrote: Yinghai Lu ying...@kernel.org writes: Yes, I skip them in pci_scan_device() to get the unused bus number space that 0a.0 and 0b.0 then can use when reconfiguration is triggered

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-19 Thread Dirk Gouders
Dirk Gouders d...@gouders.net writes: Yinghai Lu ying...@kernel.org writes: On Fri, Sep 12, 2014 at 5:11 PM, Dirk Gouders d...@gouders.net wrote: Yinghai Lu ying...@kernel.org writes: Yes, I skip them in pci_scan_device() to get the unused bus number space that 0a.0 and 0b.0 then can use

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-20 Thread Dirk Gouders
Bjorn Helgaas bhelg...@google.com writes: On Sat, Sep 13, 2014 at 09:41:34PM +0200, Dirk Gouders wrote: So, I did some tests on the VX50 which probably wasn't the worst idea, because it behaves different than the test machine. Summary: 1) Bjorn's back pocket patch works on the VX50

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-11 Thread Dirk Gouders
Yinghai Lu ying...@kernel.org writes: On Thu, Sep 11, 2014 at 10:30 AM, Bjorn Helgaas bhelg...@google.com wrote: [+cc linux-pci] On Thu, Sep 11, 2014 at 7:43 AM, Dirk Gouders d...@gouders.net wrote: Andreas Noever andreas.noe...@gmail.com writes: On Wed, Sep 3, 2014 at 2:47 PM, Dirk

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-11 Thread Dirk Gouders
Yinghai Lu ying...@kernel.org writes: On Thu, Sep 11, 2014 at 10:30 AM, Bjorn Helgaas bhelg...@google.com wrote: [+cc linux-pci] On Thu, Sep 11, 2014 at 7:43 AM, Dirk Gouders d...@gouders.net wrote: Andreas Noever andreas.noe...@gmail.com writes: On Wed, Sep 3, 2014 at 2:47 PM, Dirk

[BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-03 Thread Dirk Gouders
On a Tyan VX50 (B4985) I ran into problems when updating the kernel: the PCI FC Adapter is no longer recognized. Actually, this machine caused more problems, because I was not able to get it run with fedora, debian or ubuntu but I am somewhat sure that has to do with grub2 and now I am (again)

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-04 Thread Dirk Gouders
Andreas Noever andreas.noe...@gmail.com writes: On Wed, Sep 3, 2014 at 2:47 PM, Dirk Gouders d...@gouders.net wrote: Andreas Noever andreas.noe...@gmail.com writes: On Wed, Sep 3, 2014 at 12:57 PM, Dirk Gouders d...@gouders.net wrote: On a Tyan VX50 (B4985) I ran into problems when updating

Re: [PATCH] tools/lib/api/Makefile: Add feature check for _FORTIFY_SOURCE

2015-04-21 Thread Dirk Gouders
Bobby Powers bobbypow...@gmail.com writes: Hi, Dirk Gouders d...@gouders.net wrote: Yes, I was suggesting something similar (but without founded reasoning), some time ago [1]. I submitted a patch for this a few days ago, but I didn't realize I should CC linux-kbuild@ (my bad): https

[PATCH] tools/lib/api/Makefile: Add feature check for _FORTIFY_SOURCE

2015-04-20 Thread Dirk Gouders
For example on Gentoo systems where _FORTIFY_SOURCE is set by default, `make -C tools/perf' fails, because of the macro being redefined. Fix that by a feature-check analogous to tools/perf/config/Makefile. Signed-off-by: Dirk Gouders d...@gouders.net --- tools/lib/api/Makefile | 9 - 1

Re: [PATCH] tools/lib/api/Makefile: Add feature check for _FORTIFY_SOURCE

2015-04-20 Thread Dirk Gouders
Ingo Molnar mi...@kernel.org writes: * Dirk Gouders d...@gouders.net wrote: For example on Gentoo systems where _FORTIFY_SOURCE is set by default, `make -C tools/perf' fails, because of the macro being redefined. Fix that by a feature-check analogous to tools/perf/config/Makefile

[RFC PATCH] mconf: expand show_all_options to choices' checklist menus

2016-04-30 Thread Dirk Gouders
Boolean choices' checklist menus are currently immune against the 'z' key that toggles visibility of all options. Expansion of the 'z' toggle could be of use when debugging problems with comlex choice menus. A new tag 'z' for dialog_items was introduced for this purpose. Signed-off-by: Dirk

[RFC v2 0/1] Emacs-like isearch for mconf.

2018-06-07 Thread Dirk Gouders
*** BLURB HERE *** Hello, this is v2 of the isearch implementation, I also added Documentation changes which probably have to be split, because the older symbol-search also was undokumented in mconf (I basically copied the relevant documentation from Documentation/kbuild/kconfig.txt. I could

[RFC v3 1/1] Emacs-like isearch for mconf.

2018-06-08 Thread Dirk Gouders
# navigate to Device Drivers 3) ENTER# terminate isearch and enter submenu 4) \# start isearch 5) USB # navigate to USB support 6) ENTER# terminate isearch and enter submenu Signed-off-by: Dirk Gouders --- Documentation/kbuild

[RFC v3 0/1] Emacs-like isearch for mconf.

2018-06-08 Thread Dirk Gouders
with mismatches and matches above the current position were fixed. Dirk Gouders (1): Emacs-like isearch for mconf. Documentation/kbuild/kconfig.txt | 18 +++- scripts/kconfig/lxdialog/dialog.h | 6 ++ scripts/kconfig/lxdialog/menubox.c | 171 + scripts

Re: [RFC 0/1] mconf: Emacs-like isearch

2018-06-08 Thread Dirk Gouders
Sam Ravnborg writes: >> >> I'd say it's not important to start isearch with CTRL-s, I am just so >> used to it. So, I am open for suggestions. > > Today we have first or one of the first letters as shortcut to menus. > How about considering everything typed as search inputs. > Search is then

[RFC v4 0/1] i-search functionality for mconf

2018-06-08 Thread Dirk Gouders
mode, for a detailed description see 1/1. As stated earlier, this is just a prototype, documentation is missing and the code is not ready for a real commit. Dirk Dirk Gouders (1): Isearch functionality for mconf scripts/kconfig/lxdialog/dialog.h | 3 + scripts/kconfig/lxdialog/menubox.c

[RFC v4 1/1] i-search functionality for mconf

2018-06-08 Thread Dirk Gouders
This patch prototypes isearch functionality for mconf based on an idea of Sam Ravnborg: * mconf now distinguishes if the focus is on the menu items or the buttons below it. * At startup focus is on the menu items and alphanumeric characters or space entered are used to form a string that is

[RFC v7 0/1] mconf: global i-search in menu prompts

2018-06-17 Thread Dirk Gouders
characters and space terminates isearch and -- except ESC ESC -- is further processed, e.g. ENTER terminates isearch and is then used to navigate into a submenu. * Problems with mismatches and matches above the current position were fixed. Dirk Gouders (1): mconf: global i-search in menu

[RFC v7 1/1] mconf: global i-search in menu prompts

2018-06-17 Thread Dirk Gouders
o that calling functions can operate depending on that key. Signed-off-by: Dirk Gouders --- scripts/kconfig/lxdialog/checklist.c | 2 +- scripts/kconfig/lxdialog/dialog.h| 3 +- scripts/kconfig/lxdialog/inputbox.c | 2 +- scripts/kconfig/lxdialog/menubox.c | 181 +++

[RFC v6 1/1] mconf: global i-search in menu structure

2018-06-15 Thread Dirk Gouders
simply type 'n', 'f' and 's'. Hint: use the 'z' key with focus on buttons to search for invisible prompts. Signed-off-by: Dirk Gouders Suggested-by: Sam Ravnborg --- scripts/kconfig/lxdialog/checklist.c | 2 +- scripts/kconfig/lxdialog/dialog.h| 3 +- scripts/kconfig/lxdialog/inpu

[RFC v6 0/1] mconf: global i-search in menu structure

2018-06-15 Thread Dirk Gouders
terminates isearch and -- except ESC ESC -- is further processed, e.g. ENTER terminates isearch and is then used to navigate into a submenu. * Problems with mismatches and matches above the current position were fixed. Dirk Gouders (1): mconf: global i-search in menu structure scripts/kconfig

[RFC v5 1/1] i-search navigation for mconf

2018-06-11 Thread Dirk Gouders
# Enter the submenu Suggested-by: Sam Ravnborg Signed-off-by: Dirk Gouders --- scripts/kconfig/lxdialog/dialog.h | 3 + scripts/kconfig/lxdialog/menubox.c | 489 +++-- scripts/kconfig/lxdialog/util.c| 106 +++- scripts/kconfig/mconf.c|

[RFC v5 0/1] i-search navigation for mconf

2018-06-11 Thread Dirk Gouders
with mismatches and matches above the current position were fixed. Dirk Gouders (1): i-search navigation for mconf scripts/kconfig/lxdialog/dialog.h | 3 + scripts/kconfig/lxdialog/menubox.c | 489 +++-- scripts/kconfig/lxdialog/util.c| 106 +++- scripts

Re: [RFC v7 1/1] mconf: global i-search in menu prompts

2018-06-19 Thread Dirk Gouders
Randy Dunlap writes: > Hi Dirk, > > On 06/17/2018 05:15 AM, Dirk Gouders wrote: >> >> At any time, at most one i-search is active and the navigation path to >> the current menu is displayed in the subtitle, the second line in the >> menu window. > > Nic

Re: [RFC v7 1/1] mconf: global i-search in menu prompts

2018-06-19 Thread Dirk Gouders
Randy Dunlap writes: > On 06/19/2018 11:47 AM, Dirk Gouders wrote: >> Randy Dunlap writes: >> >>> Hi Dirk, >>> >>> On 06/17/2018 05:15 AM, Dirk Gouders wrote: >>>> >>>> At any time, at most one i-search is active and the nav

Re: [RFC v4 0/1] i-search functionality for mconf

2018-06-09 Thread Dirk Gouders
Sam Ravnborg writes: > Hi Dirk. > > On Fri, Jun 08, 2018 at 08:46:05PM +0200, Dirk Gouders wrote: >> Hello, >> >> this version is a prototype of the idea, Sam suggested -- I hope I >> undestood it correctly. >> >> This is a remarkable ch

Re: [RFC 0/1] mconf: Emacs-like isearch

2018-06-06 Thread Dirk Gouders
Randy Dunlap writes: > On 06/06/2018 02:56 PM, Dirk Gouders wrote: >> Hello, >> >> being an Emacs user, I frequently find myself pressing CTRL-s in mconf >> to search for some menu entry, especially in large menus. >> >> I decided to implement a basic

Re: [RFC 1/1] Emacs-like isearch for mconf.

2018-06-06 Thread Dirk Gouders
Segher Boessenkool writes: > On Wed, Jun 06, 2018 at 11:58:55PM +0200, Dirk Gouders wrote: >> @@ -332,6 +332,7 @@ int init_dialog(const char *backtitle) >> >> keypad(stdscr, TRUE); >> cbreak(); >> +raw(); /* Enable CTRL-sequence

[RFC 0/1] mconf: Emacs-like isearch

2018-06-06 Thread Dirk Gouders
anyone find this functionality useful. Thanks, Dirk Dirk Gouders (1): Emacs-like isearch for mconf. scripts/kconfig/lxdialog/dialog.h | 5 ++ scripts/kconfig/lxdialog/menubox.c | 140 - scripts/kconfig/lxdialog/util.c| 1 + 3 files changed, 145

[RFC 1/1] Emacs-like isearch for mconf.

2018-06-06 Thread Dirk Gouders
--- scripts/kconfig/lxdialog/dialog.h | 5 ++ scripts/kconfig/lxdialog/menubox.c | 140 - scripts/kconfig/lxdialog/util.c| 1 + 3 files changed, 145 insertions(+), 1 deletion(-) diff --git a/scripts/kconfig/lxdialog/dialog.h

Re: [RFC 0/1] mconf: Emacs-like isearch

2018-06-06 Thread Dirk Gouders
Randy Dunlap writes: > On 06/06/2018 03:32 PM, Dirk Gouders wrote: >> Randy Dunlap writes: >> >>> On 06/06/2018 02:56 PM, Dirk Gouders wrote: >>>> Hello, >>>> >>>> being an Emacs user, I frequently find myself pressing CTRL-s in m

Re: [RFC 0/1] mconf: Emacs-like isearch

2018-06-06 Thread Dirk Gouders
Masahiro Yamada writes: > 2018-06-07 8:54 GMT+09:00 Dirk Gouders : >> Randy Dunlap writes: >> >>> On 06/06/2018 03:32 PM, Dirk Gouders wrote: >>>> Randy Dunlap writes: >>>> >>>>> On 06/06/2018 02:56 PM, Dirk Gouders wrote: >

[RFC v9 1/1] mconf: global i-search in menu prompts

2018-06-23 Thread Dirk Gouders
d in combination with the parameter "width" it now makes sure that the whole region (width x height) is overwritten. * The function conf() now returns the key the user pressed so that calling functions can operate depending on that key. Signed-off-by: Dirk Gouders Tested-by: Randy Du

[RFC v9 0/1] mconf: global i-search in menu prompts

2018-06-23 Thread Dirk Gouders
-- is further processed, e.g. ENTER terminates isearch and is then used to navigate into a submenu. * Problems with mismatches and matches above the current position were fixed. Dirk Gouders (1): mconf: global i-search in menu prompts scripts/kconfig/lkc.h| 1 + scripts

Re: [RFC v8 1/1] mconf: global i-search in menu prompts

2018-06-20 Thread Dirk Gouders
Randy Dunlap writes: > Hi, > > On 06/20/2018 01:42 AM, Dirk Gouders wrote: >> >> Operation >> - >> The TAB key is reserved to toggle the focus between menu and bottons. >> Focus is on the buttons if one of the buttens (the active one) is >&

[RFC v8 1/1] mconf: global i-search in menu prompts

2018-06-20 Thread Dirk Gouders
d in combination with the parameter "width" it now makes sure that the whole region (width x height) is overwritten. * The function conf() now returns the key the user pressed so that calling functions can operate depending on that key. Signed-off-by: Dirk Gouders Tested-by: Randy Du

[RFC v8 0/1] mconf: global i-search in menu prompts

2018-06-20 Thread Dirk Gouders
h and is then used to navigate into a submenu. * Problems with mismatches and matches above the current position were fixed. Dirk Gouders (1): mconf: global i-search in menu prompts scripts/kconfig/lkc.h| 1 + scripts/kconfig/lxdialog/checklist.c | 2 +- scripts/kconfig/lxdial

Re: [RFC v8 1/1] mconf: global i-search in menu prompts

2018-06-21 Thread Dirk Gouders
Randy Dunlap writes: > On 06/20/2018 11:55 AM, Dirk Gouders wrote: >> Randy Dunlap writes: >> >>> Hi, >>> >>> On 06/20/2018 01:42 AM, Dirk Gouders wrote: >>>> >>>> Operation >>>> - >>>> The TAB

[PATCH] Kbuild: Makefile.modbuiltin: include auto.conf and tristate.conf mandatory

2018-08-02 Thread Dirk Gouders
The files auto.conf and tristate.conf are mandatory for building modules.builtin files, therefore include them as such. Usually, the top-level Makefile ensures that those files exist but we want to make sure we get noticed if they are missing for whatever reason. Signed-off-by: Dirk Gouders

Re: [PATCH v2 1/3] kconfig: error out when seeing recursive dependency

2018-08-15 Thread Dirk Gouders
a warning, which I guess was not intentional. > > Get it back to an error again. > > Also, rename the unit test directory "warn_recursive_dep" to > "err_recursive_dep" so that it matches to the behavior. > > Signed-off-by: Masahiro Yamada I tested v2 of this

Re: [PATCH 1/2] kconfig: report recursive dependency involving 'imply'

2018-08-15 Thread Dirk Gouders
Masahiro Yamada writes: > 2018-08-14 19:38 GMT+09:00 Dirk Gouders : >> Masahiro Yamada writes: >> >>> Currently, Kconfig does not report anything about the recursive >>> dependency where 'imply' keywords are involved. >>> >>>

Re: [PATCH 1/2] kconfig: report recursive dependency involving 'imply'

2018-08-14 Thread Dirk Gouders
Masahiro Yamada writes: > Currently, Kconfig does not report anything about the recursive > dependency where 'imply' keywords are involved. > > [Test Code] > > config A > bool "a" > > config B > bool "b" > imply A > depends on A Hello Masahiro,

Re: [PATCH 1/2] kconfig: report recursive dependency involving 'imply'

2018-08-14 Thread Dirk Gouders
Dirk Gouders writes: > Masahiro Yamada writes: > >> Currently, Kconfig does not report anything about the recursive >> dependency where 'imply' keywords are involved. >> >> [Test Code] >> >> config A >> bool "a"

[PATCH v2] checkpatch: kbuild: if_changed: check for multiple calls in targets

2018-07-20 Thread Dirk Gouders
U-BOOT image format) 684151a75bf25f5ae (sparc32: added U-Boot build target: uImage) Reviewed-by: Joe Perches Suggested-by: Masahiro Yamada Signed-off-by: Dirk Gouders --- v2: rework commit message and regular expression --- scripts/checkpatch.pl | 8 1 file changed, 8 insertions

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-20 Thread Dirk Gouders
Christoph Hellwig writes: > On Wed, Jul 18, 2018 at 12:06:26AM -0700, Randy Dunlap wrote: >> All $ARCH look equivalent except for microblaze and nios2. >> For those, the config SWAP in init/Kconfig (line 221) comes before (and >> hence takes precedence) over arch/$(SRCARCH)/Kconfig settings,

Re: [PATCH] kconfig: handle format string before calling conf_message_callback()

2018-07-17 Thread Dirk Gouders
Masahiro Yamada writes: > As you see in mconf.c and nconf.c, conf_message_callback() hooks are > likely to end up with the boilerplate of vsnprintf(). Process the > string format before calling conf_message_callback() so that it > receives a simple string. I looked at and tested this patch and

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-14 Thread Dirk Gouders
Masahiro Yamada writes: > 2018-07-12 20:32 GMT+09:00 Dirk Gouders : >> Masahiro Yamada writes: >> >>> 2018-07-09 20:39 GMT+09:00 Dirk Gouders : >>>> Dirk Gouders writes: >>>> >>>> I think, I solved the puzzle and perhaps, that saves

[PATCH] checkpatch: if_changed: check for multiple calls in targets

2018-07-16 Thread Dirk Gouders
-by: Masahiro Yamada Signed-off-by: Dirk Gouders --- scripts/checkpatch.pl | 8 1 file changed, 8 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 447857ffaf6b..b0aadf23148e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2911,6 +2911,14 @@ sub

Re: [PATCH] checkpatch: if_changed: check for multiple calls in targets

2018-07-17 Thread Dirk Gouders
Joe Perches writes: > On Mon, 2018-07-16 at 14:39 +0200, Dirk Gouders wrote: >> Because the kbuild function if_changed writes the command line to a >> .cmd file for later tests, multiple calls of that function within a >> target would result in overwrites of previous v

Re: [PATCH v3 00/12] kbuild/kconfig: do not update config during installation

2018-07-10 Thread Dirk Gouders
Masahiro Yamada writes: > The main motivation of this patch series is to suppress the syncconfig > during running installation targets. > > V1 consisted of only two patches: > https://patchwork.kernel.org/patch/10468105/ > https://patchwork.kernel.org/patch/10468103/ > > I noticed that

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-06 Thread Dirk Gouders
Masahiro Yamada writes: > syncconfig updates the .config only when sym_change_count > 0, i.e. > any change in config symbols has been detected. > > Not only symbols but also comments are contained in the .config file. > If only comments are updated, they are not fed back to the .config, > then

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-06 Thread Dirk Gouders
Dirk Gouders writes: > Masahiro Yamada writes: > >> syncconfig updates the .config only when sym_change_count > 0, i.e. >> any change in config symbols has been detected. >> >> Not only symbols but also comments are contained in the .config file

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-12 Thread Dirk Gouders
Dirk Gouders writes: > Masahiro Yamada writes: > >> 2018-07-09 20:39 GMT+09:00 Dirk Gouders : >>> Dirk Gouders writes: >>> >>>> Dirk Gouders writes: >>>> >>>>> Masahiro Yamada writes: >>>>> >>>>&g

Re: [PATCH v3 00/12] kbuild/kconfig: do not update config during installation

2018-07-13 Thread Dirk Gouders
Masahiro Yamada writes: > 2018-07-10 20:34 GMT+09:00 Dirk Gouders : >> Masahiro Yamada writes: >> >>> The main motivation of this patch series is to suppress the syncconfig >>> during running installation targets. >>> >>> V1 consisted of o

  1   2   3   >