[PATCH 0/5] staging: omap-thermal fixes

2012-11-13 Thread Eduardo Valentin
Hello Greg, Several compilation fixes and a couple of debugging prints added to the omap-thermal driver under staging area. Patches are also available here: g...@gitorious.org:thermal-framework/thermal-framework.git thermal_work/omap/omap-thermal-fixes Cheers, Eduardo Valentin (4): staging

[PATCH 1/5] staging: omap-thermal: fix compilation

2012-11-13 Thread Eduardo Valentin
Because we are not including asm/io.h, the driver is not compiling. This patch adds the missing header. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/staging/omap-thermal/omap-bandgap.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging

[PATCH 2/5] staging: omap-thermal: remove platform data nomenclature

2012-11-13 Thread Eduardo Valentin
Because the driver is not really using platform data, this patch removes the pdata nomenclature from this driver. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/staging/omap-thermal/omap-thermal-common.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 3/5] staging: omap-thermal: remove freq_clip table

2012-11-13 Thread Eduardo Valentin
table. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/staging/omap-thermal/omap-bandgap.h|9 --- drivers/staging/omap-thermal/omap-thermal-common.c | 63 +--- 2 files changed, 3 insertions(+), 69 deletions(-) diff --git a/drivers/staging/omap

[PATCH 4/5] staging: omap-thermal: add IRQ debugging messaging

2012-11-13 Thread Eduardo Valentin
For debugging purposes, print the IRQ event for the domain being processed. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/staging/omap-thermal/omap-bandgap.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap

[PATCH 5/5] staging: omap-thermal: fix context restore function

2012-11-13 Thread Eduardo Valentin
. Hence removed checking of the register value and restoring the context. Signed-off-by: Radhesh Fadnis radhesh.fad...@ti.com Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/staging/omap-thermal/omap-bandgap.c | 56 ++- 1 files changed, 21 insertions

Re: [PATCH 0/5] staging: omap-thermal fixes

2012-11-13 Thread Eduardo Valentin
Hello Greg, I will repost this series as I found I sent you wrong set of patches. Please check the next version. On 13-11-2012 11:43, Eduardo Valentin wrote: Hello Greg, Several compilation fixes and a couple of debugging prints added to the omap-thermal driver under staging area. Patches

[PATCHv2 0/5] staging: omap-thermal fixes

2012-11-13 Thread Eduardo Valentin
. Patches are also available here: g...@gitorious.org:thermal-framework/thermal-framework.git thermal_work/omap/omap-thermal-fixes_3.7 Cheers, Eduardo Valentin (4): staging: omap-thermal: fix compilation staging: omap-thermal: remove platform data nomenclature staging: omap-thermal: remove

[PATCHv2 1/5] staging: omap-thermal: fix compilation

2012-11-13 Thread Eduardo Valentin
Because we are not including linux/io.h, the driver is not compiling. This patch adds the missing header. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/staging/omap-thermal/omap-bandgap.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers

[PATCHv2 2/5] staging: omap-thermal: remove platform data nomenclature

2012-11-13 Thread Eduardo Valentin
Because the driver is not really using platform data, this patch removes the pdata nomenclature from this driver. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/staging/omap-thermal/omap-thermal-common.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCHv2 3/5] staging: omap-thermal: remove freq_clip table

2012-11-13 Thread Eduardo Valentin
table. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/staging/omap-thermal/omap-bandgap.h|9 --- drivers/staging/omap-thermal/omap-thermal-common.c | 63 +--- 2 files changed, 3 insertions(+), 69 deletions(-) diff --git a/drivers/staging/omap

[PATCHv2 4/5] staging: omap-thermal: add IRQ debugging messaging

2012-11-13 Thread Eduardo Valentin
For debugging purposes, print the IRQ event for the domain being processed. Signed-off-by: Enric Balletbo i Serra eballe...@gmail.com Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/staging/omap-thermal/omap-bandgap.c |5 + 1 files changed, 5 insertions(+), 0

[PATCHv2 5/5] staging: omap-thermal: fix context restore function

2012-11-13 Thread Eduardo Valentin
. Hence removed checking of the register value and restoring the context. Signed-off-by: Radhesh Fadnis radhesh.fad...@ti.com Signed-off-by: Enric Balletbo i Serra eballe...@gmail.com Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/staging/omap-thermal/omap-bandgap.c | 57

Re: [PATCHv2 0/5] staging: omap-thermal fixes

2012-11-13 Thread Eduardo Valentin
Hello, On Tue, Nov 13, 2012 at 02:09:59PM -0400, Eduardo Valentin wrote: Hello again Greg, So here is the correct set of changes. They now include the right version of the patches and with the fixes reported by Enric. Thanks Enric for the heads up. So, Several compilation fixes

Re: [PATCHv3 1/3] thermal: introduce thermal_zone_get_zone_by_name helper function

2013-04-15 Thread Eduardo Valentin
On 14-04-2013 21:43, Zhang Rui wrote: On Fri, 2013-04-05 at 08:32 -0400, Eduardo Valentin wrote: This patch adds a helper function to get a reference of a thermal zone, based on the zone type name. It will perform a zone name lookup and return a reference to a thermal zone device that matches

Re: [PATCHv3 2/3] thermal: expose thermal_zone_get_temp API

2013-04-15 Thread Eduardo Valentin
On 14-04-2013 21:43, Zhang Rui wrote: On Fri, 2013-04-05 at 08:32 -0400, Eduardo Valentin wrote: This patch exports the thermal_zone_get_temp API so that driver writers can fetch temperature of thermal zones managed by other drivers. Acked-by: Durgadoss R durgados...@intel.com Signed-off

Re: [PATCHv3 3/3] staging: ti-soc-thermal: remove external heat while extrapolating hotspot

2013-04-15 Thread Eduardo Valentin
On 14-04-2013 21:44, Zhang Rui wrote: On Fri, 2013-04-05 at 08:32 -0400, Eduardo Valentin wrote: For boards that provide a PCB sensor close to SoC junction temperature, it is possible to remove the cumulative heat reported by the SoC temperature sensor. This patch changes the extrapolation

Re: still in 3.9-rc6 - fan speed at 100% after suspend/resume regression

2013-04-15 Thread Eduardo Valentin
On 13-04-2013 19:46, Ville Syrjälä wrote: On Sun, Apr 14, 2013 at 12:44:00AM +0300, Ville Syrjälä wrote: On Sat, Apr 13, 2013 at 10:02:21AM -0600, Jake Edge wrote: Hi Zhang Rui, The problem reported in https://lkml.org/lkml/2012/12/4/428 (and incorrectly attributed to a suspend patch by me

[PATCH 01/30] thermal: cpu_cooling: remove unused headers

2013-04-17 Thread Eduardo Valentin
As this code is not a module nor a platform device driver, this patch removes some unused header files. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 3

[PATCH 02/30] thermal: cpu_cooling: remove trailing white spaces

2013-04-17 Thread Eduardo Valentin
Remove unnecessary white spaces. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers

[PATCH 03/30] thermal: cpu_cooling: fix kernel_doc for cpufreq_cooling_device

2013-04-17 Thread Eduardo Valentin
Simple fixes for making kernel_doc happy about struct cpufreq_cooling_device. Includes also a minor spelling fix. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal

[PATCH 04/30] thermal: cpu_cooling: use EXPORT_SYMBOL_GPL

2013-04-17 Thread Eduardo Valentin
Restrict the usage to GPL modules. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 05/30] thermal: cpu_cooling: remove compiler warning

2013-04-17 Thread Eduardo Valentin
level will be used only if GET_FREQ mode is requested. There is no potential harm with current code. But for cleaning the compilation log, this patch initializes level to zero. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo

[PATCH 06/30] thermal: cpu_cooling: standardize end of function

2013-04-17 Thread Eduardo Valentin
Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index bdc4233..68d5a2d 100644 --- a/drivers

[PATCH 07/30] thermal: cpu_cooling: fix kernel doc for is_cpufreq_valid

2013-04-17 Thread Eduardo Valentin
Update documentation for is_cpufreq_valid function so that kernel-doc does not complain about return value. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c

Re: From: Eduardo Valentin eduardo.valen...@ti.com

2013-04-17 Thread Eduardo Valentin
Rui, On 08-04-2013 12:07, Eduardo Valentin wrote: Here is a sequence of fixes and documentation improvements thermal code base. This should be first of a series of changes I am planing to send out. On this very first there is no change in functionality, as the patches only change symbol

[PATCH 08/30] thermal: cpu_cooling: add documentation for get_property

2013-04-17 Thread Eduardo Valentin
As this is one of the central functions of this file, it deserves a proper documentation. This patch improves the existing comment to format it as a kernel-doc style. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin

[PATCH 10/30] thermal: cpu_cooling: align on open parenthesis

2013-04-17 Thread Eduardo Valentin
Improve code readiness by remove checkpatch.pl warnings on get_property function. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 3 ++- 1 file changed, 2

[PATCH 09/30] thermal: cpu_cooling: standardize comment style

2013-04-17 Thread Eduardo Valentin
There are at least three patterns for oneline comments in this file. This patch changes them to one single pattern Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal

[PATCH 11/30] thermal: cpu_cooling: remove trailing blank line

2013-04-17 Thread Eduardo Valentin
Remove unnecessary blank line. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/thermal

[PATCH 12/30] thermal: cpu_cooling: document cpufreq_get_cooling_level

2013-04-17 Thread Eduardo Valentin
Add documentation for cpufreq_get_cooling_level. As this is an exported function, it has to be documented. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c

[PATCH 13/30] thermal: cpu_cooling: remove checkpatch.pl warning

2013-04-17 Thread Eduardo Valentin
Simple code style fix. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal

[PATCH 14/30] thermal: cpu_cooling: improve documentation for get_cpu_frequency

2013-04-17 Thread Eduardo Valentin
Fix kernel-doc warning on get_cpu_frequency and improve documentation comments. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 8 +++- 1 file changed

[PATCH 15/30] thermal: cpu_cooling: update documentation for cpufreq_apply_cooling

2013-04-17 Thread Eduardo Valentin
Update kernel-doc comments for cpufreq_apply_cooling function. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 6 ++ 1 file changed, 6 insertions

[PATCH 16/30] thermal: cpu_cooling: update documentation for cpufreq_thermal_notifier

2013-04-17 Thread Eduardo Valentin
Update kernel-doc comment and documentation for cpufreq_thermal_notifier. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 6 ++ 1 file changed, 6

[PATCH 17/30] thermal: cpu_cooling: update Kconfig entry

2013-04-17 Thread Eduardo Valentin
There is no support for hotplug or any other means of reducing temperature. So, this patch removes these references from Kconfig. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers

[PATCH 19/30] thermal: cpu_cooling: update documentation for cpufreq_get_max_state

2013-04-17 Thread Eduardo Valentin
Update documentation for cpufreq_get_max_state callback. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH 21/30] thermal: cpu_cooling: update documentation for cpufreq_set_cur_state

2013-04-17 Thread Eduardo Valentin
Update documentation for cpufreq_set_cur_state callback. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH 20/30] thermal: cpu_cooling: update documentation for cpufreq_get_cur_state

2013-04-17 Thread Eduardo Valentin
Update documentation for cpufreq_get_cur_state callback. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH 22/30] thermal: cpu_cooling: update kernel-doc for cpufreq_cooling_register

2013-04-17 Thread Eduardo Valentin
Add proper documentation for exported function cpufreq_cooling_register. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 7 +++ 1 file changed, 7

[PATCH 23/30] thermal: cpu_cooling: update kernel-doc comment for cpufreq_cooling_unregister

2013-04-17 Thread Eduardo Valentin
Update comments for this exported function. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers

[PATCH 24/30] thermal: cpu_cooling: use snprintf instead of sprintf

2013-04-17 Thread Eduardo Valentin
Limit the amount of bytes written to dev_name by secure writing with snprintf. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 3 ++- 1 file changed, 2

[PATCH 25/30] thermal: cpu_cooling: remove not needed curl brackets

2013-04-17 Thread Eduardo Valentin
Just for style purposes, remove extra curl brackets. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

[PATCH 26/30] thermal: cpu_cooling: remove unused symbols

2013-04-17 Thread Eduardo Valentin
The list is needed so far. Thus removing it. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/cpu_cooling.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff

[PATCH 29/30] thermal: cpu_cooling: remove unused symbols on cpu_cooling.h

2013-04-17 Thread Eduardo Valentin
Remove defines that are not in used. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- include/linux/cpu_cooling.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux

[PATCH 28/30] MAINTAINERS: update thermal entry by adding file cpu_cooling.h

2013-04-17 Thread Eduardo Valentin
Add cpu_cooling.h to thermal entry in MAINTAINERS. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH 27/30] thermal: cpu_cooling: add needed header for cpu_cooling.h

2013-04-17 Thread Eduardo Valentin
Update header list for cpu_cooling.h. Missing definition of cpumask. Cc: Zhang Rui rui.zh...@intel.com Cc: Durgadoss R durgados...@intel.com Cc: Amit Daniel Kachhap amit.kach...@linaro.org Cc: Andrew Morton a...@linux-foundation.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin

[PATCH 30/30] thermal: cpu_cooling: improve line breaking

2013-04-17 Thread Eduardo Valentin
To improve code readiness, change the way the lines are broken in this file. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- include/linux/cpu_cooling.h | 16 1 file

[PATCH 18/30] thermal: cpu_cooling: alignment improvements

2013-04-17 Thread Eduardo Valentin
Improve code readiness by changing alignments so that they match open parenthesis, like checkpatch.pl --strict suggests. Cc: Zhang Rui rui.zh...@intel.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal

Re: [PATCHv3 2/3] thermal: expose thermal_zone_get_temp API

2013-04-17 Thread Eduardo Valentin
On 15-04-2013 09:22, Eduardo Valentin wrote: On 14-04-2013 21:43, Zhang Rui wrote: On Fri, 2013-04-05 at 08:32 -0400, Eduardo Valentin wrote: This patch exports the thermal_zone_get_temp API so that driver writers can fetch temperature of thermal zones managed by other drivers. Acked

Re: [PATCHv3 1/3] thermal: introduce thermal_zone_get_zone_by_name helper function

2013-04-17 Thread Eduardo Valentin
On 15-04-2013 09:21, Eduardo Valentin wrote: On 14-04-2013 21:43, Zhang Rui wrote: On Fri, 2013-04-05 at 08:32 -0400, Eduardo Valentin wrote: This patch adds a helper function to get a reference of a thermal zone, based on the zone type name. It will perform a zone name lookup and return

Re: [PATCH RESEND 05/11] thermal: rename get_tz_trend to thermal_zone_trend_get

2013-04-17 Thread Eduardo Valentin
On 17-04-2013 11:10, Zhang Rui wrote: On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: To follow the prefix names used by the thermal exported functions, this patch renames get_tz_trend to thermal_zone_trend_get. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com NACK

Re: [PATCH RESEND 06/11] thermal: use EXPORT_SYMBOL_GPL

2013-04-17 Thread Eduardo Valentin
On 17-04-2013 11:20, Zhang Rui wrote: On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: Restrict usage of GPL modules. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com NACK for thermal_zone_trend_get/thermal_instance_get/thermal_cdev_update, for the reasons stated earlier

Re: [PATCH RESEND 07/11] thermal: update kernel-doc for thermal_zone_bind_cooling_device

2013-04-17 Thread Eduardo Valentin
On 17-04-2013 11:28, Zhang Rui wrote: On Wed, 2013-04-17 at 23:26 +0800, Zhang Rui wrote: On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: This patch updates the documentation for thermal_zone_bind_cooling_device and removes the warnings generated by scripts/kernel-doc -v. Signed

Re: [PATCH RESEND 04/11] thermal: rename get_thermal_instance to thermal_instance_get

2013-04-17 Thread Eduardo Valentin
On 17-04-2013 11:09, Zhang Rui wrote: On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: To follow the prefix names used by the thermal exported functions, this patch renames get_thermal_instance to thermal_instance_get. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com NACK

Re: [PATCH RESEND 09/11] thermal: update kernel-doc for thermal_cooling_device_register

2013-04-17 Thread Eduardo Valentin
On 17-04-2013 11:31, Zhang Rui wrote: On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: This patch updates the documentation for thermal_cooling_device_register and removes the warnings generated by scripts/kernel-doc -v. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com

Re: [PATCH RESEND 11/11] thermal: update kernel-doc for thermal_zone_device_register

2013-04-17 Thread Eduardo Valentin
On 17-04-2013 11:24, Zhang Rui wrote: On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: This patch updates the documentation for thermal_zone_device_register it is not enough. parameters including const struct thermal_zone_params *tzp, int passive_delay, and int polling_delay

[PATCH 1/3] arm: dts: introduce config HAS_BANDGAP

2013-04-17 Thread Eduardo Valentin
@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- arch/arm/Kconfig| 3 +++ arch/arm/mach-omap2/Kconfig | 1 + 2 files changed, 4 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index abf4467..04abc7c 100644 --- a/arch/arm/Kconfig +++ b/arch/arm

[PATCH 2/3] arm: dts: add bandgap entry for OMAP443x devices

2013-04-17 Thread Eduardo Valentin
@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- arch/arm/boot/dts/omap443x.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/omap443x.dtsi b/arch/arm/boot/dts/omap443x.dtsi index cccf39a..8d6c968 100644 --- a/arch/arm/boot/dts/omap443x.dtsi

[PATCH 3/3] arm: add bandgap entry for OMAP4460 devices

2013-04-17 Thread Eduardo Valentin
@vger.kernel.org Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- arch/arm/boot/dts/omap4460.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/omap4460.dtsi b/arch/arm/boot/dts/omap4460.dtsi index 7c2c23c..3808b5c 100644 --- a/arch/arm/boot/dts/omap4460.dtsi +++ b

Re: [PATCH 00/30] thermal: cpu_cooling: code improvements

2013-04-17 Thread Eduardo Valentin
On 17-04-2013 13:11, Eduardo Valentin wrote: Rui, Looks like I forgot to add the lists on patch 00. Doing so.. This is a series of patches to improve the code for cpu_cooling. Majority of these changes are actually kernel-doc updates, as they required to be revised. A part from

Re: [PATCHv2 1/3] thermal: introduce thermal_zone_get_zone_by_name helper function

2013-04-04 Thread Eduardo Valentin
On 04-04-2013 13:12, R, Durgadoss wrote: -Original Message- From: Eduardo Valentin [mailto:eduardo.valen...@ti.com] Sent: Thursday, April 04, 2013 3:43 AM To: Zhang, Rui Cc: linux...@vger.kernel.org; linux-kernel@vger.kernel.org; R, Durgadoss; Eduardo Valentin Subject: [PATCHv2 1/3

Re: [PATCH V2 1/3] Thermal: rename thermal_sys.c to thermal_core.c

2013-04-04 Thread Eduardo Valentin
On 29-03-2013 10:26, Zhang Rui wrote: this is the preparation work to build all the thermal core framework source file, like governors, cpu cooling, etc, into one module. No functional change in this patch. Signed-off-by: Zhang Rui rui.zh...@intel.com Durga and me have already reviewed and

[PATCHv3 0/3] thermal: lookup temperature

2013-04-05 Thread Eduardo Valentin
Hello Rui, Here is V3 of temperature lookup helper function. This has been split into two API as suggested on V1 and now the API returns an specific error code for multiple matches, as suggested in V2. The usage of it is exemplified on patch 03. Eduardo Valentin (3): thermal: introduce

[PATCHv3 2/3] thermal: expose thermal_zone_get_temp API

2013-04-05 Thread Eduardo Valentin
This patch exports the thermal_zone_get_temp API so that driver writers can fetch temperature of thermal zones managed by other drivers. Acked-by: Durgadoss R durgados...@intel.com Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/thermal_sys.c | 20

[PATCHv3 3/3] staging: ti-soc-thermal: remove external heat while extrapolating hotspot

2013-04-05 Thread Eduardo Valentin
For boards that provide a PCB sensor close to SoC junction temperature, it is possible to remove the cumulative heat reported by the SoC temperature sensor. This patch changes the extrapolation computation to consider an external sensor in the extrapolation equations. Signed-off-by: Eduardo

[PATCHv3 1/3] thermal: introduce thermal_zone_get_zone_by_name helper function

2013-04-05 Thread Eduardo Valentin
or if the required parameters are invalid, it will return the corresponding error code (ERR_PTR). Cc: Durgadoss R durgados...@intel.com Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/thermal_sys.c | 38 ++ include/linux/thermal.h |1

From: Eduardo Valentin eduardo.valen...@ti.com

2013-04-08 Thread Eduardo Valentin
. Eduardo Valentin (11): thermal: use strlcpy instead of strcpy thermal: update driver license thermal: rename notify_thermal_framework to thermal_notify_framework thermal: rename get_thermal_instance to thermal_instance_get thermal: rename get_tz_trend to thermal_zone_trend_get

[PATCH RESEND 01/11] thermal: use strlcpy instead of strcpy

2013-04-08 Thread Eduardo Valentin
For memory boundaries safety, use strlcpy instead of strcpy. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/thermal_sys.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c index

[PATCH RESEND 02/11] thermal: update driver license

2013-04-08 Thread Eduardo Valentin
As per the comment at the top of this file, this is a GPLv2 driver. This patch updates the driver license accordingly. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/thermal_sys.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers

[PATCH RESEND 03/11] thermal: rename notify_thermal_framework to thermal_notify_framework

2013-04-08 Thread Eduardo Valentin
To follow the prefix names used by the thermal exported functions, this patch renames notify_thermal_framework to thermal_notify_framework. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- Documentation/thermal/sysfs-api.txt |2 +- drivers/thermal/thermal_sys.c |6

[PATCH RESEND 04/11] thermal: rename get_thermal_instance to thermal_instance_get

2013-04-08 Thread Eduardo Valentin
To follow the prefix names used by the thermal exported functions, this patch renames get_thermal_instance to thermal_instance_get. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- Documentation/thermal/sysfs-api.txt |2 +- drivers/thermal/fair_share.c|2 +- drivers

[PATCH RESEND 06/11] thermal: use EXPORT_SYMBOL_GPL

2013-04-08 Thread Eduardo Valentin
Restrict usage of GPL modules. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/thermal_sys.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c index 242c82a

[PATCH RESEND 07/11] thermal: update kernel-doc for thermal_zone_bind_cooling_device

2013-04-08 Thread Eduardo Valentin
This patch updates the documentation for thermal_zone_bind_cooling_device and removes the warnings generated by scripts/kernel-doc -v. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/thermal_sys.c | 16 +--- 1 files changed, 13 insertions(+), 3 deletions

[PATCH RESEND 08/11] thermal: update kernel-doc for thermal_zone_unbind_cooling_device

2013-04-08 Thread Eduardo Valentin
This patch updates the documentation for thermal_zone_unbind_cooling_device and removes the warnings generated by scripts/kernel-doc -v. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/thermal_sys.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions

[PATCH RESEND 05/11] thermal: rename get_tz_trend to thermal_zone_trend_get

2013-04-08 Thread Eduardo Valentin
To follow the prefix names used by the thermal exported functions, this patch renames get_tz_trend to thermal_zone_trend_get. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- Documentation/thermal/sysfs-api.txt |2 +- drivers/thermal/step_wise.c |2 +- drivers/thermal

[PATCH RESEND 09/11] thermal: update kernel-doc for thermal_cooling_device_register

2013-04-08 Thread Eduardo Valentin
This patch updates the documentation for thermal_cooling_device_register and removes the warnings generated by scripts/kernel-doc -v. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/thermal_sys.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff

[PATCH RESEND 11/11] thermal: update kernel-doc for thermal_zone_device_register

2013-04-08 Thread Eduardo Valentin
This patch updates the documentation for thermal_zone_device_register and removes the warnings generated by scripts/kernel-doc -v. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/thermal_sys.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff

[PATCH RESEND 10/11] thermal: update kernel-doc for create_trip_attrs

2013-04-08 Thread Eduardo Valentin
This patch updates the documentation for create_trip_attrs and removes the warnings generated by scripts/kernel-doc -v. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/thermal_sys.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers

Re: [PATCH] Staging: omap-thermal: remove trailing whitespace from omap-bandgap.c

2013-04-08 Thread Eduardo Valentin
Tyrel, On 08-04-2013 14:24, edubez...@gmail.com wrote: Fixing to right email address. On Mon, Apr 8, 2013 at 1:22 PM, Greg KH gre...@linuxfoundation.org wrote: On Sun, Apr 07, 2013 at 06:47:20PM -0700, Tyrel Datwyler wrote: This patch removes trailing whitespace from a blank line in

Re: [PATCH] Staging: omap-thermal: remove trailing whitespace from omap-bandgap.c

2013-04-08 Thread Eduardo Valentin
On 08-04-2013 15:12, Dan Carpenter wrote: On Mon, Apr 08, 2013 at 02:27:13PM -0400, Eduardo Valentin wrote: Thanks, please keep sending your patches and copy my email address so I will give you a quick response. Please, send a patch adding yourself to the MAINTAINERS file so

Re: [PATCH] thermal: fix frequency table lookup bugs

2013-04-09 Thread Eduardo Valentin
Hi Andrew, On 08-04-2013 19:54, Andrew Bresticker wrote: The loops which are used to perform lookups in CPU frequency tables in cpu_cooling and the Exynos thermal driver do not update the loop counter if they encounter an invalid table entry, leading to an infinite loop in that case.

Re: [PATCH] thermal: step_wise: set throttle target within thermal instance limits

2013-04-09 Thread Eduardo Valentin
Hi Andrew, On 08-04-2013 19:56, Andrew Bresticker wrote: When selecting a target cooling state in get_target_state(), make sure that the state is at least as high as the minimum when the temperature is rising and at least as low as the maximum when the temperature is falling. Previously the

Re: [PATCH] thermal: step_wise: set throttle target within thermal instance limits

2013-04-09 Thread Eduardo Valentin
On 09-04-2013 13:09, Andrew Bresticker wrote: Hi Eduardo, On Tue, Apr 9, 2013 at 8:00 AM, Eduardo Valentin eduardo.valen...@ti.com wrote: Hi Andrew, On 08-04-2013 19:56, Andrew Bresticker wrote: When selecting a target cooling state in get_target_state(), make sure that the state

Re: [PATCH] thermal: fix frequency table lookup bugs

2013-04-09 Thread Eduardo Valentin
On 09-04-2013 13:02, Andrew Bresticker wrote: Hi Eduardo, On Tue, Apr 9, 2013 at 7:55 AM, Eduardo Valentin eduardo.valen...@ti.com wrote: Hi Andrew, On 08-04-2013 19:54, Andrew Bresticker wrote: The loops which are used to perform lookups in CPU frequency tables in cpu_cooling

Re: [PATCH] thermal: fix frequency table lookup bugs

2013-04-09 Thread Eduardo Valentin
On 09-04-2013 14:27, Andrew Bresticker wrote: You do two things in this change on cpu_cooling.c: (1) fix the case where the loop is kept running indefinitely. (2) Reserve a specific role for each index in this function. So the issue is that the changes are not independent. With just the fix

Re: [PATCH] thermal: step_wise: set throttle target within thermal instance limits

2013-04-10 Thread Eduardo Valentin
and hits a thermal trip point for the first time when it's frequency is much higher than the range specified by the thermal instance corresponding to the trip point. Signed-off-by: Andrew Bresticker abres...@chromium.org applied. Rui, Can you please add my: Acked-by: Eduardo Valentin eduardo.valen

Re: [PATCH 14/30] thermal/exynos: remove unnecessary header inclusions

2013-04-10 Thread Eduardo Valentin
them, so we can just remove the inclusions. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: linux...@vger.kernel.org Cc: Zhang Rui rui.zh...@intel.com This patch looks good to me. You can add my: Acked-by: Eduardo Valentin eduardo.valen...@ti.com [1] - http://marc.info/?l=linux-pmm

Re: [1/9] thermal: exynos: Adapt to temperature emulation core thermal framework

2013-04-11 Thread Eduardo Valentin
Hello Amit, Couple of comments inline. On 26-03-2013 07:33, Amit Daniel Kachhap wrote: This removes the driver specific sysfs support of the temperature emulation and uses the newly added core thermal framework for thermal emulation. An exynos platform specific handler is added to support

Re: [2/9] thermal: exynos: Add support for instance based register/unregister

2013-04-11 Thread Eduardo Valentin
Hey Amit, On 26-03-2013 07:33, Amit Daniel Kachhap wrote: This code modifies the thermal driver to have multiple thermal zone support by replacing the global thermal zone varibale with device data s/varibale/variable member of thermal_zone_device. Signed-off-by: Amit Daniel Kachhap

Re: [5/9] thermal: exynos: Make the zone handling dependent on trip count

2013-04-11 Thread Eduardo Valentin
On 26-03-2013 07:33, Amit Daniel Kachhap wrote: This code changes the zone handling to use the trip count passed by the TMU driver. This also helps in adding more zone support. Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- drivers/thermal/samsung/exynos_common.c | 56

Re: [6/9] thermal: exynos: small cleanups to prepare for adding exynos5440 driver

2013-04-11 Thread Eduardo Valentin
Amit, On 26-03-2013 07:33, Amit Daniel Kachhap wrote: Add calib mode, trigger types and trigger_enable array. This is needed for adding exynos5440 TMU driver. I dont think the above are small cleanups. I d rather split this patch into three, one per change and describe them properly.

Re: [7/9] thermal: exynos: Add support for exynos5440 TMU sensor.

2013-04-11 Thread Eduardo Valentin
Amit, On 26-03-2013 07:34, Amit Daniel Kachhap wrote: This sensor registers 3 instance of the tmu controller with the thermal zone and hence reports 3 temperature output. This driver supports upto five trip points. For critical threshold the driver uses the core driver thermal framework for

Re: [8/9] thermal: exynos: Parse the platform data from the device tree.

2013-04-11 Thread Eduardo Valentin
Amit, Copying Grant for the DT part discussion. On 26-03-2013 07:34, Amit Daniel Kachhap wrote: This patch adds code to parse the DT based platform data like threshold temp, sensor configuration parameters like gain, reference voltages, calibration modes etc. Signed-off-by: Amit Daniel

Re: [9/9] ARM: dts: Add device tree node for exynos5440 TMU controller

2013-04-11 Thread Eduardo Valentin
Amit, Copying Grant for DT. On 26-03-2013 07:34, Amit Daniel Kachhap wrote: This patch adds device node for TMU controller. There are 3 instances of the controllers so 3 nodes are created. Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- arch/arm/boot/dts/exynos5440.dtsi | 43

Re: [PATCH V2 1/3] Thermal: rename thermal_sys.c to thermal_core.c

2013-04-12 Thread Eduardo Valentin
On 11-04-2013 21:12, Zhang Rui wrote: On Thu, 2013-04-04 at 16:24 -0400, Eduardo Valentin wrote: On 29-03-2013 10:26, Zhang Rui wrote: this is the preparation work to build all the thermal core framework source file, like governors, cpu cooling, etc, into one module. No functional change

Re: [5/9] thermal: exynos: Make the zone handling dependent on trip count

2013-04-12 Thread Eduardo Valentin
On 12-04-2013 07:16, amit daniel kachhap wrote: Hi Eduardo, On Fri, Apr 12, 2013 at 2:18 AM, Eduardo Valentin eduardo.valen...@ti.com wrote: On 26-03-2013 07:33, Amit Daniel Kachhap wrote: This code changes the zone handling to use the trip count passed by the TMU driver. This also helps

[PATCHv2 0/3] thermal: lookup temperature

2013-04-03 Thread Eduardo Valentin
Hello Rui, Here is V2 of temperature lookup helper function. This has been split into two API as suggested on V1. The usage of it is exemplified on patch 03. Eduardo Valentin (3): thermal: introduce thermal_zone_get_zone_by_name helper function thermal: expose thermal_zone_get_temp API

[PATCHv2 1/3] thermal: introduce thermal_zone_get_zone_by_name helper function

2013-04-03 Thread Eduardo Valentin
or if the required parameters are invalid, it will return the corresponding error code (ERR_PTR). Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/thermal_sys.c | 34 ++ include/linux/thermal.h |1 + 2 files changed, 35 insertions(+), 0

[PATCHv2 2/3] thermal: expose thermal_zone_get_temp API

2013-04-03 Thread Eduardo Valentin
This patch exports the thermal_zone_get_temp API so that driver writers can fetch temperature of thermal zones managed by other drivers. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/thermal/thermal_sys.c | 20 +--- include/linux/thermal.h |1

  1   2   3   4   5   6   7   8   9   10   >