Re: [PATCH v2 1/3] ARM/dts: omap3: Add generic DT support for IGEP devices

2012-12-03 Thread Enric Balletbo Serra
2012/11/30 Javier Martinez Canillas javier.marti...@collabora.co.uk: Add a generic .dtsi device tree source file for the common characteristics across IGEP Technology devices. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Acked-by: Matthias Brugger

Re: [PATCH v2 2/3] ARM/dts: omap3: Add support for IGEPv2 board

2012-12-03 Thread Enric Balletbo Serra
2012/11/30 Javier Martinez Canillas javier.marti...@collabora.co.uk: ISEE IGEPv2 is an TI OMAP3 SoC based embedded board. This patch adds an initial device tree support to boot an IGEPv2 from the MMC/SD. Currently is working everything that is supported by DT on OMAP3 SoCs (MMC/SD, GPIO

Re: [PATCH v2 3/3] ARM/dts: omap3: Add support for IGEP COM Module

2012-12-03 Thread Enric Balletbo Serra
2012/11/30 Javier Martinez Canillas javier.marti...@collabora.co.uk: ISEE IGEP COM Module is an TI OMAP3 SoC computer on module. This patch adds an initial device tree support to boot an IGEP COM Module from the MMC/SD. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk

Re: [PATCHv2] phy: omap-usb2: Enable runtime PM of omap-usb2 phy properly

2014-11-11 Thread Enric Balletbo Serra
Hi all, 2014-11-04 0:29 GMT+01:00 Greg KH gre...@linuxfoundation.org: On Mon, Nov 03, 2014 at 04:51:41PM +0530, Kishon Vijay Abraham I wrote: Hi Greg, On Tuesday 07 October 2014 04:32 PM, Oussama Ghorbel wrote: The USB OTG port does not work since v3.16 on omap platform. This is a

Re: [PATCHv5 1/3] of: Add vendor prefix for Analogix Semiconductor, Inc.

2015-11-13 Thread Enric Balletbo Serra
Hi Rob, 2015-11-13 15:38 GMT+01:00 Rob Herring : > On Fri, Nov 13, 2015 at 01:01:02PM +0100, Enric Balletbo i Serra wrote: >> Analogix Semiconductor develops analog and mixed-signal devices for digital >> media and communications interconnect applications. >> >> Signed-off-by:

Re: [PATCH] [media] hdmi: added functions for MPEG InfoFrames

2015-11-16 Thread Enric Balletbo Serra
Hello Thierry, Many thanks for your comments. 2015-11-16 12:50 GMT+01:00 Thierry Reding : > On Sat, Nov 14, 2015 at 07:38:19PM +0100, Enric Balletbo i Serra wrote: >> The MPEG Source (MS) InfoFrame is in EIA/CEA-861B. It describes aspects of >> the compressed video stream

Re: [PATCH] [media] hdmi: added functions for MPEG InfoFrames

2015-11-17 Thread Enric Balletbo Serra
Hello Thierry, 2015-11-17 13:55 GMT+01:00 Thierry Reding <tred...@nvidia.com>: > On Mon, Nov 16, 2015 at 05:28:24PM +0100, Enric Balletbo Serra wrote: >> Hello Thierry, >> >> Many thanks for your comments. >> >> 2015-11-16 12:50 GMT+01:00 Thierry Reding &l

Re: [PATCH 3/3] staging: slimport: Add anx7814 driver support by analogix.

2015-09-06 Thread Enric Balletbo Serra
2015-09-07 1:27 GMT+02:00 Greg KH : > On Sun, Sep 06, 2015 at 11:14:02PM +0200, Enric Balletbo i Serra wrote: >> The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter >> designed for portable devices. >> >> This driver adds initial support and

Re: [PATCH] ARM: dts: omap3-igep: Move eth IRQ pinmux to IGEPv2 common dtsi

2015-09-07 Thread Enric Balletbo Serra
2015-09-07 18:24 GMT+02:00 Javier Martinez Canillas : > Only the IGEPv2 boards have a LAN9221i chip connected to the GPMC > so the pinmux configuration for the GPIO connected to the IRQ line > of the LAN chip should not be defined in the IGEP common dtsi but > in the one

Re: [PATCH 3/3] staging: slimport: Add anx7814 driver support by analogix.

2015-09-09 Thread Enric Balletbo Serra
Hi Dan, Many thanks for this first review. 2015-09-09 5:38 GMT+02:00 Daniel Kurtz : > Hi Eric, > > Thanks for starting to upstream this Analogix Slimport driver! > As Greg says, please move this driver to its intended directory, I presume: > /drivers/gpu/drm/bridge > I

Re: [PATCHv2 2/3] devicetree: Add new ANX7814 SlimPort transmitter binding.

2015-09-10 Thread Enric Balletbo Serra
Hi Rob, 2015-09-09 2:40 GMT+02:00 Rob Herring : > On 09/08/2015 02:25 AM, Enric Balletbo i Serra wrote: >> The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter >> designed for portable devices. >> >> You can add support to your board with current binding. >>

Re: [PATCHv3 2/3] devicetree: Add new ANX7814 SlimPort transmitter binding.

2015-09-10 Thread Enric Balletbo Serra
2015-09-10 18:35 GMT+02:00 Enric Balletbo i Serra : > The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter > designed for portable devices. > > You can add support to your board with current binding. > > Example: > > anx7814: anx7814@38 { >

Re: [PATCHv2 2/2] power_supply: Add support for tps65217-charger.

2015-09-24 Thread Enric Balletbo Serra
Hi, 2015-09-24 17:45 GMT+02:00 Sebastian Reichel : > Hi, > > On Thu, Sep 24, 2015 at 09:23:25AM +0200, Enric Balletbo i Serra wrote: >> This patch adds support for the tps65217 charger driver. This driver is >> responsible for controlling the charger aspect of the tps65217 mfd.

Re: [PATCH 3/3] mfd: Add battery charger as subdevice to the tps65217.

2015-09-22 Thread Enric Balletbo Serra
2015-09-20 6:19 GMT+02:00 Lee Jones : > On Tue, 08 Sep 2015, Enric Balletbo i Serra wrote: > >> Add tps65217 battery charger subdevice. >> >> Signed-off-by: Enric Balletbo i Serra >> --- >> drivers/mfd/tps65217.c | 4 >> 1 file changed, 4

Re: [PATCH 0/2] ARM: dts: Use MMC pwrseq instead regulators for IGEP WiFi init

2015-12-04 Thread Enric Balletbo Serra
2015-12-03 20:27 GMT+01:00 Tony Lindgren : > * Javier Martinez Canillas [151203 10:29]: >> Hello Tony, >> >> On 12/03/2015 03:16 PM, Tony Lindgren wrote: >> > * Javier Martinez Canillas [151203 10:03]: >> >> Hello, >> >> >> >>

Re: [PATCH 2/2] ARM: dts: omap3-igep0030: Use MMC pwrseq to init SDIO WiFi

2015-12-04 Thread Enric Balletbo Serra
< 10 GPIO_ACTIVE_LOW>; /* gpio_138 - > WIFI_PDN */ > }; > }; > > @@ -62,8 +54,8 @@ > { > pinctrl-names = "default"; > pinctrl-0 = <_pins _pins>; > - vmmc-supply = <_pdn>; > - vmmc_au

Re: [PATCH 1/2] ARM: dts: omap3-igep0020: Use MMC pwrseq to init SDIO WiFi

2015-12-04 Thread Enric Balletbo Serra
< 10 GPIO_ACTIVE_LOW>; /* gpio_138 - > WIFI_PDN */ > }; > }; > > @@ -51,8 +43,8 @@ > { > pinctrl-names = "default"; > pinctrl-0 = <_pins _pins>; > - vmmc-supply = <_pdn>; > - vmmc_aux-supply = &

Re: [PATCH] [media] hdmi: added functions for MPEG InfoFrames

2015-12-09 Thread Enric Balletbo Serra
Hello Thierry, 2015-11-19 13:29 GMT+01:00 Enric Balletbo Serra <eballe...@gmail.com>: > Hello Thierry, > > 2015-11-19 12:51 GMT+01:00 Thierry Reding <tred...@nvidia.com>: >> On Tue, Nov 17, 2015 at 11:55:53PM +0100, Enric Balletbo Serra wrote: >>> Hello Thierry

Re: [PATCHv6 5/5] drm: bridge: anx78xx: Add anx78xx driver support by analogix.

2015-12-09 Thread Enric Balletbo Serra
Hi Dan, Many thanks for your comments. 2015-12-07 9:09 GMT+01:00 Dan Carpenter : > On Fri, Dec 04, 2015 at 09:35:07AM +0100, Enric Balletbo i Serra wrote: >> +static int sp_wait_aux_op_finish(struct anx78xx *anx78xx) >> +{ >> + u8 errcnt; >> + u8 val; >> +

Re: [PATCHv2 1/2] ARM: multi_v7_defconfig: Enable Rockchip generic power domain.

2015-12-15 Thread Enric Balletbo Serra
Arght, I'm asleep, I need a coffee this now, there isn't patch 2/2, this patch is 1/1. Sorry for the noise. Enric 2015-12-15 9:20 GMT+01:00 Enric Balletbo i Serra : > In order to meet high performance an low power requirement for Rockchip > enable the power domain support.

Re: [PATCH] ARM: multi_v7_defconfig: Enable Rockchip generic power domain.

2015-12-14 Thread Enric Balletbo Serra
cc'ing: Heiko Stuebner (rockchip maintainer) 2015-12-14 18:17 GMT+01:00 Enric Balletbo i Serra : > In order to meet high performance an low power requirement for Rockchip > enable the power domain support. > > Signed-off-by: Enric Balletbo i Serra

Re: [PATCH] [media] hdmi: added functions for MPEG InfoFrames

2015-11-19 Thread Enric Balletbo Serra
Hello Thierry, 2015-11-19 12:51 GMT+01:00 Thierry Reding <tred...@nvidia.com>: > On Tue, Nov 17, 2015 at 11:55:53PM +0100, Enric Balletbo Serra wrote: >> Hello Thierry, >> >> 2015-11-17 13:55 GMT+01:00 Thierry Reding <tred...@nvidia.com>: >> > On Mo

Re: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file

2016-06-09 Thread Enric Balletbo Serra
2016-06-06 19:02 GMT+02:00 Javier Martinez Canillas : > From: Shengzhen Li > > Most cfg80211 operations are just a wrappers to functions defined in the > sta_ioctl.c file, so for consistency move the .get_tx_power logic there. > > Signed-off-by: Shengzhen

Re: [PATCH v2 3/3] mwifiex: add get_antenna support for cfg80211

2016-06-09 Thread Enric Balletbo Serra
2016-06-06 19:02 GMT+02:00 Javier Martinez Canillas : > From: Shengzhen Li > > Since commit de3bb771f471 ("cfg80211: add more warnings for inconsistent > ops") the wireless core warns if a driver implements a cfg80211 callback > but doesn't implements the

Re: [PATCH v2 1/3] mwifiex: add a cfg80211 .get_tx_power operation callback

2016-06-09 Thread Enric Balletbo Serra
2016-06-06 19:02 GMT+02:00 Javier Martinez Canillas : > The mwifiex driver implements a cfg80211 .set_tx_power operation handler > but doesn't have the inverse .get_tx_power callback. > > This not only has the effect that the Tx power can't be reported to user > space tools

Re: [PATCH V2 4/5] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2016-06-10 Thread Enric Balletbo Serra
Hi Peter, Only a few comments ;) 2016-06-09 18:25 GMT+02:00 Peter Senna Tschudin : > Add a driver that create a drm_bridge and a drm_connector for the LVDS > to DP++ display bridge of the GE B850v3. > > There are two physical bridges on the video signal pipeline: a >

Re: [PATCH 0/8] mwifiex: Fix some error handling issues in mwifiex_sdio_probe() function

2016-05-30 Thread Enric Balletbo Serra
Hi Javier, 2016-05-27 16:18 GMT+02:00 Javier Martinez Canillas : > Hello, > > While booting a system with a mwifiex WiFi card, I noticed the following > missleading error message: > > [ 12.480042] mwifiex_sdio mmc2:0001:1: sdio platform data not available > > This error

Re: [PATCH 4/5] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2016-05-31 Thread Enric Balletbo Serra
Hi Peter, Just some comments that I received when I submitted my bridge patches and that I think can help you ... 2016-05-30 18:39 GMT+02:00 Peter Senna Tschudin : > This driver creates a drm_bridge and a drm_connector for the LVDS to DP++ > display bridge of the GE

Re: [RESEND PATCH v2 1/1] mmc: dw_mmc: Wait for data transfer after response errors.

2016-06-21 Thread Enric Balletbo Serra
Hi Jaehoon, 2016-06-20 12:14 GMT+02:00 Jaehoon Chung : > Hi Enric, > > On 04/26/2016 05:03 PM, Enric Balletbo i Serra wrote: >> From: Doug Anderson >> >> According to the DesignWare state machine description, after we get a >> "response error" or

Re: [RESEND PATCH v2 0/1] mmc: dw_mmc: Fix UHS tuning on some brand of cards.

2016-06-20 Thread Enric Balletbo Serra
Hi Jaehoon, 2016-04-27 10:53 GMT+02:00 Enric Balletbo i Serra : > > > On 27/04/16 10:35, Jaehoon Chung wrote: >> On 04/26/2016 05:03 PM, Enric Balletbo i Serra wrote: >>> Hi, >>> >>> I introduced the cover letter to give some background about this. >>> >>> I have

Re: [PATCH 1/2] devicetree: Add UCS1002 USB Port Power Controller binding

2016-01-28 Thread Enric Balletbo Serra
Hi Rob, Thanks for the review. 2016-01-29 3:35 GMT+01:00 Rob Herring : > On Tue, Jan 26, 2016 at 10:12:20AM +0100, Enric Balletbo i Serra wrote: >> The UCS1002-2 provides a USB port power switch for precise control of up >> to 2.5 amperes continuous current. >> >> You can add

Re: [PATCH v1 2/3] media: VPU: support Rockchip VPU

2016-01-26 Thread Enric Balletbo Serra
Hi Jung, I'm interested in this patch series and I'll try to test on my RK3288 board. Please, see my comments below to improve some things that helped me to upstream some other patches, based on feedback from others maintainers. Also I tend to use checkpatch with --strict option, it's not a must

Re: [PATCH v1 0/3] Add VP8 deocder for rk3229 & rk3288

2016-01-26 Thread Enric Balletbo Serra
Hi Jung, 2016-01-26 10:30 GMT+01:00 Shawn Lin : > Hi jun, > > Where is the dt-bingding documentation about your VP8 controller? > > And would you please share some info about rk3229? I can just find > rk3228 in mainline, otherwise may someone think it's a misspell. > >

Re: [PATCH v1 1/3] media: v4l: Add VP8 format support in V4L2 framework

2016-01-27 Thread Enric Balletbo Serra
Hi Jung, Also, if I'm not wrong these changes are a mix of these three patches available in the chromium tree[1], it's a good practice cherry-pick the patches (removing the CHROMIUM tags, rebase against mainline...) cc the authors and maintain the author and the signed-off chain. Note also that

Re: [PATCH v4 0/2] Add UCS1002 USB Port Power Controller

2016-03-30 Thread Enric Balletbo Serra
2016-03-14 10:24 GMT+01:00 Enric Balletbo i Serra : > Dear all, > > This is the fourth version of the UCS1002 driver, a Programmable USB Port > Power Controller with Charger Emulation. > > Any comments are welcome. Thanks in advance. > > Enric Balletbo i Serra (2): >

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

2016-03-30 Thread Enric Balletbo Serra
2016-03-24 17:22 GMT+01:00 Russell King - ARM Linux : > On Thu, Mar 24, 2016 at 09:06:45AM -0700, Doug Anderson wrote: >> Russell, > ... >> Presumably this is similar to what you saw: the host saw the CRC error >> but the card knew nothing about it. Sending the stop

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

2016-03-31 Thread Enric Balletbo Serra
2016-03-31 4:03 GMT+02:00 Jaehoon Chung <jh80.ch...@samsung.com>: > On 03/31/2016 02:16 AM, Enric Balletbo Serra wrote: >> 2016-03-24 17:22 GMT+01:00 Russell King - ARM Linux <li...@arm.linux.org.uk>: >>> On Thu, Mar 24, 2016 at 09:06:45AM -0700, Dou

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

2016-03-24 Thread Enric Balletbo Serra
I fixed Javier Martinez email and removed tgih@samsung.com (delivery fail) Also cc'ing Russell King as I think might help (see my comment below) 2016-03-21 23:38 GMT+01:00 Doug Anderson <diand...@chromium.org>: > Enric, > > On Thu, Mar 17, 2016 at 5:12 AM, Enric Balletbo

[PATCH] mmc: dw_mmc: Wait for data transfer after response errors

2016-03-19 Thread Enric Balletbo Serra
Dear all, Seems the following thread[1] didn't go anywhere. I'd like to continue the discussion and share some tests that I did regarding the issue that the patch is trying to fix. First I reproduced the issue on my rockchip board and I tested the patch intensively, I can confirm that the patch

Re: [PATCH v2] mmc: dw_mmc: Wait for data transfer after response errors.

2016-04-25 Thread Enric Balletbo Serra
Oh, damn, I didn't include the proper tags, [PATCH v2] mmc: dw_mmc: Wait for data transfer after response errors. [PATCH v2] mmc: dw_mmc: Fix UHS tuning on some brand of cards should be [PATCH v2 0/1] mmc: dw_mmc: Fix UHS tuning on some brand of cards [PATCH v2 1/1] mmc: dw_mmc: Wait for data

Re: [PATCH v2] mmc: dw_mmc: Fix UHS tuning on some brand of cards.

2016-04-25 Thread Enric Balletbo Serra
Oh, damn, I didn't include the proper tags, [PATCH v2] mmc: dw_mmc: Wait for data transfer after response errors. [PATCH v2] mmc: dw_mmc: Fix UHS tuning on some brand of cards should be [PATCH v2 0/1] mmc: dw_mmc: Fix UHS tuning on some brand of cards [PATCH v2 1/1] mmc: dw_mmc: Wait for data

Re: [PATCH 1/2] ASoC: rockchip: i2s: separate capture and playback

2016-04-29 Thread Enric Balletbo Serra
Hi John, 2015-12-09 11:32 GMT+01:00 John Keeping : > If we only clear the tx/rx state when both are disabled it is not > possible to start/stop one multiple times while the other is running. > Since the two are independently controlled, treat them as such and > remove the false

Re: [PATCH v3] mmc: dw_mmc: rockchip: Set the drive phase properly

2016-05-19 Thread Enric Balletbo Serra
2016-05-13 0:52 GMT+02:00 Heiko Stuebner : > Am Donnerstag, 12. Mai 2016, 11:31:50 schrieb Douglas Anderson: > > [...] > >> In commit 7a03fe6f48f3 ("clk: rockchip: reset init state before mmc card >> initialization") we actually started setting this explicitly in the >> kernel,

Re: [alsa-devel] [PATCH v2 4/5] ARM: dts: rockchip: Add shared file for audio related nodes for veyron boards

2016-05-17 Thread Enric Balletbo Serra
Hi Heiko, 2016-05-16 0:06 GMT+02:00 Heiko Stuebner : > Am Montag, 9. Mai 2016, 12:46:34 schrieb Enric Balletbo i Serra: >> Set i2s block to "okay", add sound node for max98090 with gpios for >> HP and Mic detect and pinctrl, and add a max98090 device and ts3a227e to >> the

Re: [PATCH 2/2] ARM: dts: igep0020: Add SD card write-protect pin.

2016-05-17 Thread Enric Balletbo Serra
Hi Ladislav, 2016-05-13 14:37 GMT+02:00 Ladislav Michl : > Hi Enric! > > On Fri, May 06, 2016 at 11:02:34PM +0200, Enric Balletbo i Serra wrote: >> A host device that supports write protection should refuse to write to >> an SD card that is designated read-only when

Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: separate capture and playback

2016-05-03 Thread Enric Balletbo Serra
Hi all, 2016-05-03 6:12 GMT+02:00 sugar <sugar.zh...@rock-chips.com>: > Hi John, > > > On 4/30/2016 15:00, John Keeping Wrote: >> >> Hi Enric, >> >> On Fri, Apr 29, 2016 at 04:59:27PM +0200, Enric Balletbo Serra wrote: >>> >>>

Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: separate capture and playback

2016-05-03 Thread Enric Balletbo Serra
Hi John, 2016-05-03 11:43 GMT+02:00 John Keeping <j...@metanate.com>: > Hi Enric, > > On Tue, 3 May 2016 11:16:58 +0200, Enric Balletbo Serra wrote: >> 2016-05-03 6:12 GMT+02:00 sugar <sugar.zh...@rock-chips.com>: >> > On 4/30/2016 15:00, John Keeping Wrote:

Re: [PATCH 1/2] Revert "ASoC: rockchip: i2s: remove unused variables"

2016-05-04 Thread Enric Balletbo Serra
Hi John, Thanks for the patches. 2016-05-04 16:54 GMT+02:00 John Keeping : > This reverts commit 5938448b99275cba95167c3f9d39ca9225fdad38. > > It turns out that the commit that made these variables unused is wrong > so we're about to revert it. Bring back the variables in

Re: [RESEND PATCH v4 4/4] drm: bridge: anx78xx: Add anx78xx driver support.

2016-05-02 Thread Enric Balletbo Serra
Hi Thierry, 2016-05-02 16:22 GMT+02:00 Thierry Reding : > On Mon, May 02, 2016 at 09:54:26AM +0200, Enric Balletbo i Serra wrote: > [...] >> diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c >> b/drivers/gpu/drm/bridge/analogix-anx78xx.c > [...] >> +static int

Re: [PATCH 1/2] ASoC: rockchip: i2s: separate capture and playback

2016-05-02 Thread Enric Balletbo Serra
Hi John, Thanks for answer. 2016-04-30 9:00 GMT+02:00 John Keeping <j...@keeping.me.uk>: > Hi Enric, > > On Fri, Apr 29, 2016 at 04:59:27PM +0200, Enric Balletbo Serra wrote: >> 2015-12-09 11:32 GMT+01:00 John Keeping <j...@metanate.com>: >> > If we

Re: [PATCH v2 1/4] iio: cros_ec_sensors_core: Add common functions for the ChromeOS EC Sensor Hub.

2016-07-25 Thread Enric Balletbo Serra
Hi Jonathan, Many thanks for the review, some answers below. 2016-07-24 15:51 GMT+02:00 Jonathan Cameron : > On 20/07/16 10:22, Enric Balletbo i Serra wrote: >> Add the core functions to be able to support the sensors attached behind >> the ChromeOS Embedded Controller and used

Re: [PATCH v2 2/4] iio: cros_ec_sensors: add ChromeOS EC Contiguous Sensors driver

2016-07-28 Thread Enric Balletbo Serra
Hi Guenter, Thanks for the review, some answers below, just preparing next version that I'll send asap. 2016-07-25 19:25 GMT+02:00 Guenter Roeck : > On Wed, Jul 20, 2016 at 2:22 AM, Enric Balletbo i Serra > wrote: >> Handle 3d contiguous sensors

Re: [PATCH v3] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-07-28 Thread Enric Balletbo Serra
Hi Martyn, 2016-07-28 16:36 GMT+02:00 Martyn Welch : > > > On 28/07/16 11:37, Enric Balletbo i Serra wrote: >> >> This patch adds and entry to the sysfs to start firmware upload process >> on the specified device with the requested firmware. >> >> The uploading of

Re: [PATCH v3 1/4] iio: cros_ec_sensors_core: Add common functions for the ChromeOS EC Sensor Hub.

2016-08-01 Thread Enric Balletbo Serra
Hi Guenter, Thanks for the review tags and the comments. I'll send v4 asap. 2016-07-29 19:44 GMT+02:00 Guenter Roeck : > On Thu, Jul 28, 2016 at 6:49 AM, Enric Balletbo i Serra > wrote: >> Add the core functions to be able to support the sensors

Re: [PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge

2016-08-04 Thread Enric Balletbo Serra
2016-07-12 12:13 GMT+02:00 Daniel Vetter : > On Wed, Jun 29, 2016 at 6:31 AM, Daniel Kurtz wrote: >> On Fri, Jun 17, 2016 at 3:14 AM, Emil Velikov >> wrote: +static ssize_t ps8640_update_fw_store(struct device *dev, +

Re: [PATCH v2] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-07-21 Thread Enric Balletbo Serra
Correction 2016-07-21 10:59 GMT+02:00 Enric Balletbo Serra <eballe...@gmail.com>: > Hi Guenter, > > Many thanks for the review, I'm agree with your comments so I'll apply > the changes in next version that hopefully I'll send soon. Just some > questions below. > >

Re: [PATCH v2] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-07-21 Thread Enric Balletbo Serra
Hi Guenter, Many thanks for the review, I'm agree with your comments so I'll apply the changes in next version that hopefully I'll send soon. Just some questions below. 2016-07-21 5:42 GMT+02:00 Guenter Roeck : > On 07/20/2016 03:31 AM, Enric Balletbo i Serra wrote: >> >>

Re: [PATCH v2] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-07-21 Thread Enric Balletbo Serra
2016-07-21 15:24 GMT+02:00 Guenter Roeck <li...@roeck-us.net>: > On 07/21/2016 01:59 AM, Enric Balletbo Serra wrote: > > [ ... ] > >>>> >>>> +static ssize_t ziirave_wdt_sysfs_store_firm(struct device *dev, >>>> +

Re: [PATCH 02/10] mfd: cros_ec: update MOTIONSENSE definitions and commands.

2016-07-19 Thread Enric Balletbo Serra
Hi Jonathan, Many thanks for your comments. 2016-07-18 15:49 GMT+02:00 Jonathan Cameron : > On 18/07/16 08:02, Enric Balletbo i Serra wrote: >> Let's update the command header to include the definitions related to >> the sensors attached behind the ChromeOS Embedded Controller.

Re: [PATCH 2/2] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-07-20 Thread Enric Balletbo Serra
Hi Martyn, Many thanks for the review. 2016-07-18 23:43 GMT+02:00 Martyn Welch : > Few comments inline > > > On 17/06/16 11:52, Enric Balletbo i Serra wrote: >> >> This patch adds and entry to the sysfs to start firmware upload process >> on the specified device

Re: [PATCH 04/10] iio: cros_ec: Add common functions for cros_ec sensors.

2016-07-20 Thread Enric Balletbo Serra
Hi Peter and Jonathan, Thanks for the review, I'll add the changes in v2, some answers below ... 2016-07-18 17:51 GMT+02:00 Jonathan Cameron : > On 18/07/16 08:29, Peter Meerwald-Stadler wrote: >> >>> Add the core functions to be able to support the sensors attached behind >>>

Re: Applied "ASoC: rockchip-max98090: Fix NULL pointer dereference while accessing to jack." to the asoc tree

2016-07-04 Thread Enric Balletbo Serra
2016-07-04 10:47 GMT+02:00 Mark Brown <broo...@kernel.org>: > On Mon, Jul 04, 2016 at 09:24:12AM +0200, Enric Balletbo Serra wrote: > >> I just saw that these patches and the others in the patch series were >> not applied yet. As are fixes and were acce

Re: [PATCH V4 2/4] Documentation/devicetree/bindings: b850v3_lvds_dp

2016-08-05 Thread Enric Balletbo Serra
Hi Peter, 2016-08-05 0:36 GMT+02:00 Peter Senna Tschudin : > Devicetree bindings documentation for the GE B850v3 LVDS/DP++ > display bridge. > > Cc: Javier Martinez Canillas > Cc: Enric Balletbo i Serra > Cc: Philipp

Re: [PATCH V4 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2016-08-05 Thread Enric Balletbo Serra
Hi Peter, Only one comment below and one nitpick 2016-08-05 0:37 GMT+02:00 Peter Senna Tschudin : > Add a driver that create a drm_bridge and a drm_connector for the LVDS > to DP++ display bridge of the GE B850v3. > > There are two physical bridges on the video signal

Re: [PATCH v8 2/7] Input: cros_ec_keyb - Stop handling interrupts directly

2016-07-01 Thread Enric Balletbo Serra
Hi Tomeu, 2016-04-26 9:06 GMT+02:00 Tomeu Vizoso : > On 26 April 2016 at 08:57, Lee Jones wrote: >> On Tue, 26 Apr 2016, Tomeu Vizoso wrote: >> >>> On 25 April 2016 at 23:17, Dmitry Torokhov >>> wrote: >>> > On Tue,

Re: Applied "ASoC: rockchip-max98090: Fix NULL pointer dereference while accessing to jack." to the asoc tree

2016-07-04 Thread Enric Balletbo Serra
Hi Mark, 2016-05-10 20:50 GMT+02:00 Mark Brown : > The patch > >ASoC: rockchip-max98090: Fix NULL pointer dereference while accessing to > jack. > > has been applied to the asoc tree at > >git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git > > All being

Re: [PATCH v2 4/4] mfd: cros_ec: add RTC as mfd subdevice

2017-01-23 Thread Enric Balletbo Serra
Guess I forget to add one of the platform/chrome maintainers, as only his ack is pending for this series, cc'ing Benson Leung Thanks, Enric 2017-01-23 13:14 GMT+01:00 Lee Jones : > On Thu, 19 Jan 2017, Enric Balletbo i Serra wrote: > >> From: Stephen Barber

Re: [PATCHv2 2/2] iio: cros_ec_light_prox: add ChromeOS EC Light and Proximity Sensors

2017-01-20 Thread Enric Balletbo Serra
Hi Jonathan, Thanks for the review, I am preparing v3. Some answers to your questions below. 2017-01-14 14:06 GMT+01:00 Jonathan Cameron : > On 11/01/17 15:51, Enric Balletbo i Serra wrote: >> From: Gwendal Grignou >> >> Handle Light and Proximity sensors

Re: [PATCHv2 2/2] iio: cros_ec_light_prox: add ChromeOS EC Light and Proximity Sensors

2017-01-27 Thread Enric Balletbo Serra
Hi, 2017-01-23 19:18 GMT+01:00 Gwendal Grignou <gwen...@chromium.org>: > On Fri, Jan 20, 2017 at 6:23 AM, Enric Balletbo Serra > <eballe...@gmail.com> wrote: >> Hi Jonathan, >> >> Thanks for the review, I am preparing v3. Some answers to your questions >&g

Re: [PATCH 2/2] dt-bindings: power/supply: Add support for xmega16d4-battery

2017-02-23 Thread Enric Balletbo Serra
Ooops, sorry I forget to add the device tree maintainers so CC'ing Rob Herring and Mark Rutland 2017-02-23 18:38 GMT+01:00 Enric Balletbo i Serra : > Add the documentation for binding of Toby Churchill SBS battery monitor > driver. The device is connected via SPI

Re: [PATCH 0/6] ARM: dts: am335x-sl50: Update to new hardware

2017-01-16 Thread Enric Balletbo Serra
Hi Tony, 2017-01-16 18:41 GMT+01:00 Tony Lindgren : > * Enric Balletbo i Serra [170116 08:58]: >> Hi Tony, >> >> The following patches updates the device tree file for the SL50 device, there >> are few v1 boards and IMHO doesn't make sense to

Re: [PATCH v15 2/5] Documentation: bindings: add dt documentation for cdn DP controller

2017-02-27 Thread Enric Balletbo Serra
Hi all, 2016-09-10 4:15 GMT+02:00 Chris Zhong : > This patch adds a binding that describes the cdn DP controller for > rk3399. > > Signed-off-by: Chris Zhong > Acked-by: Rob Herring > Reviewed-by: Guenter Roeck > >

Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.

2017-02-27 Thread Enric Balletbo Serra
Bounce to Wolfram Sang 2017-02-22 15:01 GMT+01:00 Andrew Lunn : > On Wed, Feb 22, 2017 at 12:16:08PM +0100, Enric Balletbo i Serra wrote: >> Hi Andrew, >> >> Removing Bryan Freed from the loop as seems his email is not valid anymore. >> I already CC'ied Andrey which is doing the

Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.

2017-02-27 Thread Enric Balletbo Serra
2017-02-27 20:12 GMT+01:00 Wolfram Sang : > Hi, > >> >> > Rather than trying small and smaller transfers, would it not be better >> >> > to get the i2c core to expose the quirk info about transfer limits? >> >> > >> >> >> >> Sounds a good idea to me, I guess the quirk info can

Re: [PATCH] iio: light: acpi-als: Add a tuning parameter interface.

2016-09-06 Thread Enric Balletbo Serra
Hi Lars, 2016-09-06 12:31 GMT+02:00 Lars-Peter Clausen : > On 09/06/2016 12:25 PM, Enric Balletbo i Serra wrote: >> From: Bryan Freed >> >> Add IIO_CHAN_INFO_CALIBSCALE to the channel to scale up or down >> the raw measurements through the IIO framework. >>

Re: [PATCH 01/23] ARM: am335x: Add missing memory node in sl50 board

2016-08-31 Thread Enric Balletbo Serra
2016-08-31 12:35 GMT+02:00 Javier Martinez Canillas : > The skeleton.dtsi file was removed in ARM64 for different reasons as > explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi"). > > These also applies to ARM and it will also allow to get rid of the >

Re: [v17 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2016-11-10 Thread Enric Balletbo Serra
Hi Jitao, 2016-08-27 8:44 GMT+02:00 Jitao Shi : > This patch adds drm_bridge driver for parade DSI to eDP bridge chip. > > Signed-off-by: Jitao Shi > Reviewed-by: Daniel Kurtz > --- > Changes since v16: > - Disable ps8640

Re: [PATCH v4 0/4] Add support for cros-ec-sensors

2016-10-18 Thread Enric Balletbo Serra
Hi Jonathan, 2016-09-03 19:21 GMT+02:00 Jonathan Cameron : > On 01/09/16 08:24, Lee Jones wrote: Given this dependency I'm assuming the best route for these is via the MFD tree... Lee, shout if you want them to go a different route. >>>

Re: [v17 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2016-10-18 Thread Enric Balletbo Serra
Hi Jitao, 2016-08-27 8:44 GMT+02:00 Jitao Shi : > This patch adds drm_bridge driver for parade DSI to eDP bridge chip. > > Signed-off-by: Jitao Shi > Reviewed-by: Daniel Kurtz > --- > Changes since v16: > - Disable ps8640

Re: [PATCH] gpio: mcp23s08: Add option to configure pullups.

2016-10-26 Thread Enric Balletbo Serra
Hi Linus, 2016-10-24 8:13 GMT+02:00 Alexander Stein : > On Monday 24 October 2016 02:53:31, Linus Walleij wrote: >> On Fri, Oct 21, 2016 at 5:00 PM, Enric Balletbo i Serra >> >> wrote: >> > Default is without pullups, but if

Re: [PATCH RESEND 2/2] platform/chrome: cros_ec_lpc: Add support for mec1322 EC

2016-11-30 Thread Enric Balletbo Serra
Hi Thierry, I reviewed your patches and looks good to me, I only found a few style things that is up to maintainer decide if are needed or not, most of them are feedback I received on other subsystems. Ah, and I've a question about runtime detection of the EC (see below), but guess the answer is

Re: [PATCH] iio: cros_ec_light_prox: add ChromeOS EC Light and Proximity Sensors

2016-11-30 Thread Enric Balletbo Serra
Hi Jonathan, Many thanks for the review, I'm preparing v2. One question below. 2016-11-27 11:39 GMT+01:00 Jonathan Cameron : > On 25/11/16 12:03, Enric Balletbo i Serra wrote: >> From: Gwendal Grignou >> >> Handle Light and Proximity sensors presented by

Re: [PATCH v3 2/4] arm64: dts: rockchip: add Gru/Kevin DTS

2017-03-21 Thread Enric Balletbo Serra
2017-03-21 0:53 GMT+01:00 Brian Norris : > Kevin is part of a family of boards called Gru. As best as possible, the > properties shared by the Gru family are placed in rk3399-gru.dtsi, while > Kevin-specific bits are in rk3399-gru-kevin.dts. This does not add full >

Re: [PATCH v3 3/4] arm64: dts: rockchip: describe Gru/Kevin OPPs + CPU regulators

2017-03-21 Thread Enric Balletbo Serra
2017-03-21 0:53 GMT+01:00 Brian Norris : > Used for Gru/Kevin only, as they're the only ones which have a described > CPU regulator. Also, I'm not sure we've validated this table non-Gru > boards. > > At the same time, partially describe PWM regulators for Gru, so cpufreq

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-03 Thread Enric Balletbo Serra
2017-03-03 8:29 GMT+01:00 Mats Karrman : > On 2017-03-03 04:13, Guenter Roeck wrote: > >> On 03/02/2017 07:22 AM, Mats Karrman wrote: >>> >>> >>> Looking forward, one thing I have run into is how to connect the typec >>> driver with a >>> driver for an alternate mode.

Re: [PATCH 2/2] platform: x86: add ACPI driver for ChromeOS.

2017-08-02 Thread Enric Balletbo Serra
Hi Andy, 2017-08-01 17:17 GMT+02:00 Andy Shevchenko : > On Mon, Jul 31, 2017 at 4:03 PM, Enric Balletbo i Serra > wrote: > >> This driver attaches to the Chromeos ACPI device and the exports the values >> reported by the ACPI in a sysfs

Re: [PATCH v3 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.

2017-07-17 Thread Enric Balletbo Serra
Hi, 2017-07-17 10:54 GMT+02:00 Chanwoo Choi : > Hi Enric, > > When I tried to apply this patch, error happened as following: > (based on v4.13-rc1) > > Applying: extcon: cros-ec: Add extcon-cros-ec driver to support display out. > error: patch failed:

Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

2017-07-17 Thread Enric Balletbo Serra
Hi Gwendal, 2017-07-13 22:33 GMT+02:00 Gwendal Grignou : > On Wed, Jul 12, 2017 at 3:13 AM, Enric Balletbo i Serra > wrote: >> The cros_ec_dev driver should be used only to expose the Chrome OS Embedded >> Controller to user-space and should

Re: [PATCH v8 4/5] platform/x86: Enable Atom PMC platform clocks

2017-07-10 Thread Enric Balletbo Serra
Hi all, 2017-01-27 1:23 GMT+01:00 Stephen Boyd : > On 01/23, Pierre-Louis Bossart wrote: >> From: Irina Tirdea >> >> The BayTrail and CherryTrail platforms provide platform clocks >> through their Power Management Controller (PMC). >> >> The SoC

Re: [PATCH v2 1/4] dt-bindings: pwm-backlight: add pwm-delay-us property

2017-07-06 Thread Enric Balletbo Serra
Hi Rob, 2017-07-06 19:07 GMT+02:00 Rob Herring : > On Fri, Jun 30, 2017 at 6:21 AM, Enric Balletbo i Serra > wrote: >> From: huang lin >> >> Add a pwm-delay-us property to specify the delay between setting an >> initial

Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.

2017-07-12 Thread Enric Balletbo Serra
Hi Chanwoo, 2017-05-24 0:24 GMT+02:00 Benson Leung : > Hi Chanwoo, > > > On Tue, May 23, 2017 at 2:58 AM, Chanwoo Choi wrote: > >> OK. This patch must need the immutable branch. >> >> I expect that some maintainer will make the immutable branch >> and

Re: [PATCH v2 1/4] dt-bindings: pwm-backlight: add pwm-delay-us property

2017-07-13 Thread Enric Balletbo Serra
2017-07-13 9:39 GMT+02:00 Pavel Machek <pa...@ucw.cz>: > On Thu 2017-07-13 09:22:15, Enric Balletbo Serra wrote: >> Rob, >> >> 2017-07-06 20:23 GMT+02:00 Enric Balletbo Serra <eballe...@gmail.com>: >> > Hi Rob, >> > >> > 2017-07-06 19

Re: [PATCH v2 1/4] dt-bindings: pwm-backlight: add pwm-delay-us property

2017-07-13 Thread Enric Balletbo Serra
Rob, 2017-07-06 20:23 GMT+02:00 Enric Balletbo Serra <eballe...@gmail.com>: > Hi Rob, > > 2017-07-06 19:07 GMT+02:00 Rob Herring <robh...@kernel.org>: >> On Fri, Jun 30, 2017 at 6:21 AM, Enric Balletbo i Serra >> <enric.balle...@collabora.com> wrote: &

Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.

2017-07-13 Thread Enric Balletbo Serra
2017-07-13 12:26 GMT+02:00 Chanwoo Choi <cw00.c...@samsung.com>: > Hi Enric, > > On 2017년 07월 12일 19:28, Enric Balletbo Serra wrote: >> Hi Chanwoo, >> >> 2017-05-24 0:24 GMT+02:00 Benson Leung <ble...@chromium.org>: >>> Hi Chanwoo, >>> >

Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

2017-07-20 Thread Enric Balletbo Serra
Lee, 2017-07-18 11:19 GMT+02:00 Lee Jones <lee.jo...@linaro.org>: > On Mon, 17 Jul 2017, Enric Balletbo Serra wrote: > >> Hi Gwendal, >> >> 2017-07-13 22:33 GMT+02:00 Gwendal Grignou <gwen...@chromium.org>: >> > On Wed, Jul 12, 2017 at 3:13

Re: [PATCH v3 5/5] ARM: dts: rockchip: set PWM delay backlight settings for Minnie

2017-07-20 Thread Enric Balletbo Serra
Pavel, 2017-07-20 10:10 GMT+02:00 Pavel Machek : > On Mon 2017-07-17 23:28:11, Enric Balletbo i Serra wrote: >> The minnie devices comes with an AUO B101EAN01 panel which is different >> from default veyron devices, thus the power on/off timing sequence is >> slightly different. The

Re: [PATCH v2 2/2] thermal: core: Allow to disable polling when disabling thermal zone.

2017-06-30 Thread Enric Balletbo Serra
Hi Rui, 2017-06-30 7:05 GMT+02:00 Zhang Rui : > On Thu, 2017-06-29 at 18:50 +0200, Enric Balletbo i Serra wrote: >> Under each thermal zone there is a optional file called "mode". >> Writing >> enabled or disabled to this file allows a given thermal zone to be >> enabled >>

Re: [PATCH v2 2/4] pwm-backlight: add support for pwm-delay-us property

2017-07-06 Thread Enric Balletbo Serra
Hi Thierry, Many thanks for your comments, I'll send a v3. 2017-07-06 10:13 GMT+02:00 Thierry Reding : > On Fri, Jun 30, 2017 at 01:21:07PM +0200, Enric Balletbo i Serra wrote: >> From: huang lin >> >> Some panels (i.e. N116BGE-L41), in their power

Re: [PATCH] acpi: thermal: honor "mode" sysfs file setting

2017-06-29 Thread Enric Balletbo Serra
Hi Rui, 2017-06-29 7:19 GMT+02:00 Zhang Rui : > On Thu, 2017-06-29 at 00:14 +0200, Rafael J. Wysocki wrote: >> On Thursday, June 22, 2017 02:45:42 PM Enric Balletbo i Serra wrote: >> > >> > From: Sameer Nanda >> > >> > Under each thermal zone there is a

Re: [PATCH 1/2] dt-bindings: pwm-backlight: Add pwm-delay-us property

2017-06-28 Thread Enric Balletbo Serra
Hi Daniel, Pavel, 2017-06-28 15:30 GMT+02:00 Pavel Machek : > On Wed 2017-06-28 13:16:31, Enric Balletbo i Serra wrote: >> From: huang lin >> >> Add a pwm-delay-us property to specify the delay between setting an >> initial (non-zero) PWM value and enabling the

  1   2   3   4   5   6   >