Re: State of Linux graphics

2005-08-30 Thread Eric Anholt
expose more of the chip’s 3D capabilities." If people put effort into this because they see value in it, without breaking other people's code, why is this a "danger?" -- Eric Anholt [EMAIL PROTECTED] http://people.freebsd.org/~anholt/ [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part

Re: [RFC] [PATCH] DRM TTM Memory Manager patch

2007-05-02 Thread Eric Anholt
and map blocks on (write-flushed if necessary) fence completion. It is up to threads performing submit_buffers and maps on shared objects to arrange external synchronization to avoid deadlock." This has the advantage that those threads likely have some sort of protocol requirements for renderin

Re: [PATCH] ARM: dont specify STACKPROTECTOR in defconfigs

2016-07-21 Thread Eric Anholt
arch/arm/configs/bcm2835_defconfig:CONFIG_CC_STACKPROTECTOR_REGULAR=y >$ I don't see why rpi1 shoud be special, so for bcm2835: Acked-by: Eric Anholt signature.asc Description: PGP signature

[PATCH] arm64: Add BCM2835 (Raspberry Pi 3) support to the defconfig

2016-09-19 Thread Eric Anholt
Most of the drivers are included as modules, except for serial (needed for early console), WDT (required for reboot), and the dependency chain of RASPBERRYPI_POWER (which is currently not buildable as a module, but should be changed). Signed-off-by: Eric Anholt --- arch/arm64/configs/defconfig

[PATCH 3/3] arm64: Add the Raspberry Pi firmware's interface to the FXL6408.

2016-09-19 Thread Eric Anholt
This gets us hotplug detection of HDMI, so that graphics now works at boot. Tested with watching the output of xrandr while plugging and unplugging the HDMI cable. Signed-off-by: Eric Anholt --- arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts | 17 + 1 file changed, 17

[PATCH 2/3] gpio: Add a driver for the Raspberry Pi's firmware GPIO calls.

2016-09-19 Thread Eric Anholt
This driver will be used for accessing the FXL6408 GPIO exander on the Pi3. We can't drive it directly from Linux because the firmware is continuously polling one of the expander's lines to do its undervoltage detection. Signed-off-by: Eric Anholt --- drivers/gp

[PATCH 1/3] dt-bindings: Add a binding for the RPi firmware GPIO driver.

2016-09-19 Thread Eric Anholt
The RPi firmware exposes all of the board's GPIO lines through property calls. Linux chooses to control most lines directly through the pinctrl driver, but for the FXL6408 GPIO expander on the Pi3, we need to access them through the firmware. Signed-off-by: Eric Anholt --- .../bindings

Re: [PATCH 1/3] i2c: bcm2835: Fix hang for writing messages larger than 16 bytes

2016-09-19 Thread Eric Anholt
ing the logic from the downstream i2c-bcm2708 driver solved > the hang problem. > > Signed-off-by: Noralf Trønnes Patches 1, 3 are: Reviewed-by: Eric Anholt For patch 2 I followed some of it, but couldn't quite say it's a review. I trust your testing, and that the path has h

Re: [PATCH] clocksource: bcm2835_timer: Unmap region obtained by of_iomap

2016-09-21 Thread Eric Anholt
Arvind Yadav writes: > Free memory mapping, if bcm2835_timer_init is not successful. > > Signed-off-by: Arvind Yadav Reviewed-by: Eric Anholt signature.asc Description: PGP signature

[GIT PULL] bcm2835-defconfig-64-next-2016-09-22

2016-09-23 Thread Eric Anholt
). Eric Anholt (1): arm64: Add BCM2835 (Raspberry Pi 3) support to the defconfig arch/arm64/configs/defconfig | 16 1 file changed, 16 insertions(+)

Re: [PATCH 1/3] dt-bindings: Add a binding for the RPi firmware GPIO driver.

2016-09-23 Thread Eric Anholt
Linus Walleij writes: > On Mon, Sep 19, 2016 at 6:13 PM, Eric Anholt wrote: > >> The RPi firmware exposes all of the board's GPIO lines through >> property calls. Linux chooses to control most lines directly through >> the pinctrl driver, but for the FXL6408

Re: [PATCH 2/3] gpio: Add a driver for the Raspberry Pi's firmware GPIO calls.

2016-09-23 Thread Eric Anholt
Linus Walleij writes: > On Mon, Sep 19, 2016 at 6:13 PM, Eric Anholt wrote: > >> This driver will be used for accessing the FXL6408 GPIO exander on the >> Pi3. We can't drive it directly from Linux because the firmware is >> continuously polling one of t

Re: [PATCH 2/3] gpio: Add a driver for the Raspberry Pi's firmware GPIO calls.

2016-09-24 Thread Eric Anholt
Linus Walleij writes: > On Fri, Sep 23, 2016 at 3:15 PM, Eric Anholt wrote: >> Linus Walleij writes: >>>> diff --git a/include/soc/bcm2835/raspberrypi-firmware.h >>>> b/include/soc/bcm2835/raspberrypi-firmware.h >>>> index 3fb357193f09..671cc

Re: [PATCH 1/8] ARM: dts: bcm283x: Define standard pinctrl groups in the gpio node.

2016-09-07 Thread Eric Anholt
Stefan Wahren writes: > Hi Gerd, > >> Gerd Hoffmann hat am 7. September 2016 um 12:31 >> geschrieben: >> >> >> From: Eric Anholt >> >> The BCM2835-ARM-Peripherals.pdf documentation specifies what the >> function selects do for the pin

Re: [PATCH 1/8] ARM: dts: bcm283x: Define standard pinctrl groups in the gpio node.

2016-09-13 Thread Eric Anholt
Dave Stevenson writes: > On 09/09/16 22:20, Eric Anholt wrote: >> e<#secure method=pgpmime mode=sign> >> Gerd Hoffmann writes: >> >>>Hi, >>> >>>> According to this page [1] the pinctrl group for parallel display >>>

Re: [PATCH] drm/vc4: cleanup with list_first_entry_or_null()

2016-09-14 Thread Eric Anholt
Masahiro Yamada writes: > The combo of list_empty() check and return list_first_entry() > can be replaced with list_first_entry_or_null(). > > Signed-off-by: Masahiro Yamada That's a nice little cleanup. Applied to -next. Thanks! signature.asc Description: PGP signature

[GIT PULL] drm-vc4-fixes-2016-09-14

2016-09-14 Thread Eric Anholt
. Baoyou Xie (1): drm/vc4: mark vc4_bo_cache_purge() static Eric Anholt (1): drm/vc4: Allow some more signals to be packed with uniform resets. drivers/gpu/drm/vc4/vc4_bo.c | 2 +- drivers/gpu/drm/vc4

[PATCH] drm/vc4: Fall back to using an EDID probe in the absence of a GPIO.

2016-09-14 Thread Eric Anholt
we'll need to coordinate with it). As a stop-gap, if we don't have a GPIO line, use an EDID probe to detect connection. Fixes HDMI display on the pi3. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_hdmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/v

[PATCH] drm/vc4: Allow some more signals to be packed with uniform resets.

2016-09-02 Thread Eric Anholt
The intent was to make sure people don't sneak in a small immediate or something to change the interpretation of the uniform update args, but these signals are just fine. Fixes a validation failure in the current X server on some Render operation. Signed-off-by: Eric Anholt --- drivers/gp

Re: [GIT PULL 2/2] bcm2835-soc-next-2017-08-15

2017-08-17 Thread Eric Anholt
Florian Fainelli writes: > On 08/15/2017 11:03 AM, Eric Anholt wrote: >> The following changes since commit f29c256853b7412961d3ee80ca525bd2530573db: >> >> ARM: dts: bcm283x: Add 32-bit enable method for SMP (2017-08-14 20:09:44 >> +0200) >> >>

[PATCH] drm/vc4: Fix sleeps during the IRQ handler for DSI transactions.

2017-08-17 Thread Eric Anholt
e top half, and re-enable it from an irqthread. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_dsi.c | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index ec

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

2017-06-20 Thread Eric Anholt
Archit Taneja writes: > On 06/16/2017 08:13 PM, Eric Anholt wrote: >> Archit Taneja writes: >> >>> On 06/16/2017 02:11 AM, Eric Anholt wrote: >>>> If the panel-bridge is being set up after the drm_mode_config_reset(), >>>> then the connect

[PATCH 1/4] drm/vc4: Hook up plane prepare_fb to lookup dma-buf reservations.

2017-06-21 Thread Eric Anholt
This way drm_atomic_helper_wait_for_fences() will actually do something. The vc4_seqno_cb has been doing the fence waits on V3D manually, so far. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_plane.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/gpu

[PATCH 2/4] drm/vc4: Wait for fences interruptibly in blocking mode.

2017-06-21 Thread Eric Anholt
We should allow SIGIO and things to interrupt us before we get to the no-error stage of the commit process. This code is effectively copied from drm_atomic_helper_commit(). Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_kms.c | 10 ++ 1 file changed, 10 insertions(+) diff

[PATCH 3/4] drm/vc4: Use the atomic state's commit workqueue.

2017-06-21 Thread Eric Anholt
Now that we're using the atomic helpers for fence waits, we can use the same codepath as drm_atomic_helper_commit() does for async, getting rid of our custom vc4_commit struct. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_kms.c | 71 --- 1

[PATCH 4/4] drm/vc4: Remove dead vc4_event_pending().

2017-06-21 Thread Eric Anholt
It is no longer used as of commit 34c8ea400ff6 ("drm/vc4: Mimic drm_atomic_helper_commit() behavior") Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_crtc.c | 8 drivers/gpu/drm/vc4/vc4_drv.h | 1 - 2 files changed, 9 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc

[PATCH 1/2] drm/vc4: Skip ULPS latching when we're in that ULPS state already.

2017-10-31 Thread Eric Anholt
It seems that trying to go from unlatched to unlatched will time out waiting for STOP, and we can just skip that. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_dsi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c

[PATCH 2/2] drm/panel: Enable DSI transactions on the RPi panel.

2017-10-31 Thread Eric Anholt
It turns out that I had just mistaken what type of write the register writes were supposed to be, using DCS instead of generic long writes. Switching to transactions instead of using the atmel as a bridge also seems to resolve the sparkling pixels problem I've had. Signed-off-by: Eric A

Re: [GIT PULL 1/2] bcm2835-dt-fixes-2017-10-06

2017-11-01 Thread Eric Anholt
Matt Hart writes: > On 6 October 2017 at 23:14, Florian Fainelli wrote: >> >> On 10/06/2017 03:05 PM, Eric Anholt wrote: >> > Hi Florian. Here's a patch that's gone through a couple of revisions >> > on the list, that seriously fixes up the default

Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled

2017-11-13 Thread Eric Anholt
Stefan Schake writes: > The overflow mem work callback vc4_overflow_mem_work reenables its > associated interrupt upon completion. To ensure all interrupts are disabled > when we return from vc4_irq_uninstall, we need to disable it again if > cancel_work_sync indicated pending work. Is there a r

Re: [PATCH 1/2] drm/vc4: Account for interrupts in flight

2017-11-13 Thread Eric Anholt
Stefan Schake writes: > Synchronously disable the IRQ to make the following cancel_work_sync > invocation effective. > > An interrupt in flight could enqueue further overflow mem work. As we > free the binner BO immediately following vc4_irq_uninstall this caused > a NULL pointer dereference in t

[PATCH] drm/bridge: Fix lvds-encoder since the panel_bridge rework.

2017-11-14 Thread Eric Anholt
Signed-off-by: Eric Anholt Fixes: 13dfc0540a57 ("drm/bridge: Refactor out the panel wrapper from the lvds-encoder bri dge.") --- Note: I haven't actually tested this patch! Hope it helps, though. drivers/gpu/drm/bridge/lvds-encoder.c | 48 ++- 1 fi

Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled

2017-11-14 Thread Eric Anholt
Stefan Schake writes: > On Tue, Nov 14, 2017 at 1:18 AM, Eric Anholt wrote: >> Stefan Schake writes: >> >>> The overflow mem work callback vc4_overflow_mem_work reenables its >>> associated interrupt upon completion. To ensure all interrupts are

Re: [PATCH] drm/vc4: Convert timers to use timer_setup()

2017-11-03 Thread Eric Anholt
Kees Cook writes: > On Mon, Oct 30, 2017 at 4:49 PM, Eric Anholt wrote: >> Kees Cook writes: >> >>> In preparation for unconditionally passing the struct timer_list pointer to >>> all timer callbacks, switch to using the new timer_setup() and from_time

Re: [PATCH 12/12] hwrng: bcm63xx-rng: Remove since bcm2835-rng takes over

2017-11-03 Thread Eric Anholt
Florian Fainelli writes: > bcm2835-rng is now capable of supporting the BCM63xx hardware, so remove > the driver which duplicates the same functionality. > > Signed-off-by: Florian Fainelli > --- > drivers/char/hw_random/Kconfig | 13 --- > drivers/char/hw_random/Makefile | 1 - >

Re: [PATCH 08/12] hwrng: bcm2835-rng: Abstract I/O accessors

2017-11-03 Thread Eric Anholt
Florian Fainelli writes: > In preparation for allowing BCM63xx to use this driver, we abstract I/O > accessors such that we can easily change those later on. > > Signed-off-by: Florian Fainelli > --- > drivers/char/hw_random/bcm2835-rng.c | 27 +++ > 1 file changed, 19 i

Re: [PATCH] drm/vc4: Convert timers to use timer_setup()

2017-10-30 Thread Eric Anholt
Kees Cook writes: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Reviewed and applied to drm-misc-next. Thanks! signature.asc Description: PGP s

[PATCH v5] clk: bcm2835: Add support for programming the audio domain clocks.

2015-10-06 Thread Eric Anholt
e() results would be incorrect, but that's no worse than our current state where we used fixed clocks. The existing fixed clocks in the code are left in place to provide backwards compatibility with old device tree files. Signed-off-by: Eric Anholt Tested-by: Martin Sperl --- v2: Fix o

Re: [PATCH v4] clk: bcm2835: Add support for programming the audio domain clocks.

2015-10-06 Thread Eric Anholt
Stefan Wahren writes: > Hi Eric, > > Am 02.10.2015 um 21:54 schrieb Eric Anholt: >> This adds support for enabling, disabling, and setting the rate of the >> audio domain clocks. It will be necessary for setting the pixel clock >> for HDMI in the VC4 driver and le

Re: bcm2835 (Raspberry Pi) KMS driver

2015-10-12 Thread Eric Anholt
Stephen Warren writes: > On 10/11/2015 06:39 AM, Stefan Wahren wrote: >> Am 09.10.2015 um 23:27 schrieb Eric Anholt: >>> This is a respin of the Raspberry Pi KMS series. Now that we've got a >>> real clock driver, I can actually set new video modes. Also in this

Re: [PATCH v3 7/7] ARM: bcm2835: Add VC4 to the device tree.

2015-10-12 Thread Eric Anholt
Stefan Wahren writes: > Am 09.10.2015 um 23:27 schrieb Eric Anholt: >> VC4 is the GPU (display and 3D) present on the 2835. >> >> Signed-off-by: Eric Anholt >> --- >> >> v2: Sort by register address, mark HDMI as disabled by default in the >> So

Re: [PATCH v3 1/7] drm/vc4: Add devicetree bindings for VC4.

2015-10-13 Thread Eric Anholt
Sebastian Reichel writes: > Hi, > > On Fri, Oct 09, 2015 at 02:27:42PM -0700, Eric Anholt wrote: >> VC4 is the GPU (display and 3D) subsystem present on the 2835 and some >> other Broadcom SoCs. >> >> This binding follows the model of msm, imx, sti, and othe

Re: [PATCH v3 3/7] drm/vc4: Add KMS support for Raspberry Pi.

2015-10-13 Thread Eric Anholt
Stefan Wahren writes: > Hi Eric, > > Am 09.10.2015 um 23:27 schrieb Eric Anholt: >> This is enough for fbcon and bringing up X using >> xf86-video-modesetting. It doesn't support the 3D accelerator or >> power management yet. >> >> Signed-off

Re: [PATCH v3 1/7] drm/vc4: Add devicetree bindings for VC4.

2015-10-13 Thread Eric Anholt
Rob Herring writes: > On Fri, Oct 9, 2015 at 4:27 PM, Eric Anholt wrote: >> --- >> >> v2: Extend the commit message, fix several nits from Stephen Warren. >> v3: Rename the compatibility strings, clean up node names, drop the >> unnecessary lists of compo

Raspberry Pi native clock driver

2015-09-06 Thread Eric Anholt
After my last firmware clocks posting, Gordon at Raspberry Pi pointed that you can, in fact, touch the clocks from the ARM side. This is the driver that resulted from that. With debug printfs at boot the clock frequencies from .recalc_rate() are looking good, a few are definitely corrected compar

[PATCH 1/4] clk: bcm2835: Move under bcm/ with other Broadcom SoC clk drivers.

2015-09-06 Thread Eric Anholt
clk-bcm2835.c predates the drivers under bcm/, but all the new BCM drivers are going in there so let's follow them. Signed-off-by: Eric Anholt --- drivers/clk/Makefile | 1 - drivers/clk/bcm/Makefile | 1 + drivers/clk/bcm/clk-bcm2835.c

[PATCH 4/4] ARM: bcm2835: Switch to using the new clock driver support.

2015-09-06 Thread Eric Anholt
but it turns out the firmware needed to change to running it at the 250Mhz core clock speed to avoid a bug in clock domain crossing. Additionally, anything using BCM2835_CLOCK_VPU will now have a correct clock rate if the user configures the boot-time core clock speed using config.txt. Signed

[PATCH 3/4] clk: bcm2835: Add support for programming the audio domain clocks.

2015-09-06 Thread Eric Anholt
e() results would be incorrect, but that's no worse than our current state where we used fixed clocks. The existing fixed clocks in the code are left in place to provide backwards compatibility with old device tree files. Signed-off-by: Eric Anholt --- drivers/clk

[PATCH 2/4] clk: bcm2835: Add binding docs for the new platform clock driver.

2015-09-06 Thread Eric Anholt
Previously we've only supported a few fixed clocks based on assumptions about how the firmware sets up the clocks, but this binding will let us control the actual (audio power domain) clock manager. Signed-off-by: Eric Anholt --- .../bindings/clock/brcm,bcm2835-cprman.txt

Re: [PATCH v5 0/6] bcm2835: auxiliar device support for spi

2015-09-08 Thread Eric Anholt
ker...@martin.sperl.org writes: > From: Martin Sperl > > The BCM2835 contains 3 auxiliar devices: > * spi1 > * spi2 > * uart1 > > All of those 3 devices are enabled/disabled via a shared register, > which is set by default to be disabled. > > Access to this register needs to get serialized. > > S

Re: [PATCH v5 4/6] spi: bcm2835: new driver implementing auxiliar spi1/spi2 on the bcm2835 soc

2015-09-08 Thread Eric Anholt
dependency Review comments as a diff, so you can git-am and squash them in if you like. If you take them all, you can add "Acked-by: Eric Anholt ". I didn't know anything about SPI before tonight, but I've looked through what you did and it looks solid when compared to the

Re: [PATCH v5 0/6] bcm2835: auxiliar device support for spi

2015-09-09 Thread Eric Anholt
Alexander Stein writes: > Hi, > On Tuesday 08 September 2015 18:48:07, Eric Anholt wrote: >> I finally had a chance to sit down and look at what the hardware's doing >> with the enable bit (also, I've read a whole lot more of the hardware >> now, so I'm a

Re: [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers

2015-10-14 Thread Eric Anholt
> {}, > }; > > +MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match); > + > static struct platform_driver bcm2835_i2s_driver = { > .probe = bcm2835_i2s_probe, > .driver = { > -- It looks like this should go through the asoc tr

[GIT PULL] DT changes for BCM2835 for 4.4

2015-10-15 Thread Eric Anholt
) because the DT changes to enable the clock driver need the driver itself to be present. Eric Anholt (6): clk: bcm2835: Move under bcm/ with other Broadcom SoC clk drivers. clk: bcm2835: Add binding docs for the new platform

[GIT PULL] SOC changes for BCM2835 for 4.4

2015-10-15 Thread Eric Anholt
. Eric Anholt (1): ARM: bcm2835: Add the Raspberry Pi firmware driver drivers/firmware/Kconfig | 7 + drivers/firmware/Makefile | 1 + drivers/firmware/raspberrypi.c | 260

Re: [PATCH v3 1/7] drm/vc4: Add devicetree bindings for VC4.

2015-10-21 Thread Eric Anholt
Rob Herring writes: > On Tue, Oct 13, 2015 at 1:17 PM, Eric Anholt wrote: >> Rob Herring writes: >> >>> On Fri, Oct 9, 2015 at 4:27 PM, Eric Anholt wrote: >>>> --- >>>> >>>> v2: Extend the commit message, fix several nits from Step

[GIT PULL] Raspberry Pi KMS driver

2015-10-21 Thread Eric Anholt
lpers drm/vc4: Allow vblank to be disabled Eric Anholt (2): drm/vc4: Add devicetree bindings for VC4. drm/vc4: Add KMS support for Raspberry Pi. .../devicetree/bindings/display/brcm,bcm-vc4.txt | 65 ++ drivers/gpu/drm/Kconfig| 2 + drivers/gp

Re: [GIT PULL] RPi DT changes due for v4.3

2015-09-04 Thread Eric Anholt
Lee Jones writes: > On Fri, 14 Aug 2015, Eric Anholt wrote: >> Olof Johansson writes: >> > On Tue, Aug 11, 2015 at 05:06:42PM +0100, Lee Jones wrote: >> >> ARM SoC Chaps, >> >> >> >> Please find a couple of simple RPi changes pertaining

Re: [RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters.

2015-10-20 Thread Eric Anholt
code into a separate > function called drm_of_component_probe() in order to increase code > reuse. > > Cc: David Airlie > Signed-off-by: Liviu Dudau Acked-by: Eric Anholt I'm unimpressed with of-graph, but this will really help me in trying it out for vc4. signature.asc Description: PGP signature

[PATCH 3/6] drm/vc4: fix itnull.cocci warnings

2015-10-23 Thread Eric Anholt
From: Julia Lawall Connector cannot be null because it is a list entry, ie accessed at an offset from the positions of the list structure pointers themselves. Generated by: scripts/coccinelle/iterators/itnull.cocci Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall Signed-off-by: Eric

[PATCH 1/6] drm/vc4: vc4_plane_duplicate_state() can be static

2015-10-23 Thread Eric Anholt
From: kbuild test robot Signed-off-by: Fengguang Wu Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_plane.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c index cdd8b10..2db5092 100644 --- a

[PATCH 6/6] drm/vc4: Add support for more a few more RGB display plane formats.

2015-10-23 Thread Eric Anholt
These were all touch-tested with modetest. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_plane.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c index 887f3ca..b31dfce 100644 --- a/drivers/gpu/drm

[PATCH 5/6] drm/vc4: Make sure that planes aren't scaled.

2015-10-23 Thread Eric Anholt
We would scan out the memory around them if an upscale was attempted, and would just scan out incorrectly for downscaling. Signed-off-by: Eric Anholt --- It looks like, while modetest only wants to set scaling on overlay planes, one could do so on our primary/cursor planes if the fd was in

[PATCH 4/6] drm/vc4: Fix some failure to track __iomem decorations on pointers.

2015-10-23 Thread Eric Anholt
Caught by the kbuild test robot. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_crtc.c | 3 ++- drivers/gpu/drm/vc4/vc4_hvs.c | 8 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index a3a77dd

[PATCH 2/6] drm/vc4: fix platform_no_drv_owner.cocci warnings

2015-10-23 Thread Eric Anholt
Lawall Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 6e73060..d5db9e0 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.c +++ b/drivers/gpu/drm/vc4/vc4_drv.c @@ -259,7 +259,6

VC4 fixes for -next

2015-10-23 Thread Eric Anholt
Merging vc4 to drm-next got a few automatic sparse and coccinelle warning reports generated. The first 3 patches come from the maintainers of those systems (thanks!), and the last 3 are fixes I've come up with in the last few days. -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH 4/6] drm/vc4: Fix some failure to track __iomem decorations on pointers.

2015-10-23 Thread Eric Anholt
Ilia Mirkin writes: > On Oct 23, 2015 6:32 AM, "Eric Anholt" wrote: >> >> Caught by the kbuild test robot. >> >> Signed-off-by: Eric Anholt >> --- >> drivers/gpu/drm/vc4/vc4_crtc.c | 3 ++- >> drivers/gpu/drm/vc4/vc4_hvs.c | 8 +++

[PATCH v4] clk: bcm2835: Add support for programming the audio domain clocks.

2015-10-02 Thread Eric Anholt
e() results would be incorrect, but that's no worse than our current state where we used fixed clocks. The existing fixed clocks in the code are left in place to provide backwards compatibility with old device tree files. Signed-off-by: Eric Anholt Tested-by: Martin Sperl --- This is the

Re: [PATCH v3 3/4] clk: bcm2835: Add support for programming the audio domain clocks.

2015-10-02 Thread Eric Anholt
Stephen Boyd writes: > On 09/28, Eric Anholt wrote: >> + >> +static const char *bcm2835_clock_per_parents[] = { >> +static const char *bcm2835_clock_vpu_parents[] = { >> +static const char *bcm2835_clock_osc_parents[] = { > > Can these parent arrays be const char

[PATCH] drm/vc4: Make sure to emit a tile coordinates between two MSAA loads.

2018-08-07 Thread Eric Anholt
The HW only executes a load once the tile coordinates packet happens, and only tracks one at a time, so by emitting our two MSAA loads back to back we would end up with an undefined color or Z buffer. Fixes dEQP-EGL.functional.render.multi_context.gles2.rgb888_window Signed-off-by: Eric Anholt

Re: [PATCH v2] arm: bcm2835: Add the PMU to the devicetree.

2018-06-21 Thread Eric Anholt
Stefan Wahren writes: >> Eric Anholt hat am 21. Mai 2018 um 20:39 geschrieben: >> >> >> This only probes on arm64 so far, but hopefully that driver will be >> generalized soon. >> >> Signed-off-by: Eric Anholt > > Acked-by: Stefan Wahren Mer

Re: [PATCH AUTOSEL for 4.14 001/100] drm/vc4: Account for interrupts in flight

2018-01-24 Thread Eric Anholt
upport for drawing 3D frames.") > Signed-off-by: Eric Anholt > Reviewed-by: Eric Anholt > Link: > https://patchwork.freedesktop.org/patch/msgid/1510275907-993-2-git-send-email-stsch...@gmail.com > Signed-off-by: Sasha Levin We found a bug, and this patch also needs: commit

[PATCH v2 3/7] drm/vc4: Switch DPI to using the panel-bridge helper.

2017-05-11 Thread Eric Anholt
Another 100 lines of boilerplate gone, while allowing for bridges to be connected in the display chain. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_dpi.c | 164 -- 1 file changed, 30 insertions(+), 134 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 7/7] drm/atmel-hlcdc: Replace the panel usage with drm_panel_bridge.

2017-05-11 Thread Eric Anholt
This cuts 135 lines of boilerplate, at the cost of losing the filtering of get_modes() using atmel_hlcdc_dc_mode_valid(). The atomic check will still check that we don't set an invalid mode, though. Signed-off-by: Eric Anholt --- This patch is just a proposal for atmel-hlcdc if you li

[PATCH v2 1/7] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-11 Thread Eric Anholt
hould just be the panel's dev, move kerneldoc up a level and document _remove(). Signed-off-by: Eric Anholt Acked-by: Daniel Vetter --- Documentation/gpu/drm-kms-helpers.rst | 6 ++ drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/bridge/Kconfig| 11 +- drivers

[PATCH v2 4/7] drm/mediatek: Use the panel-bridge helper.

2017-05-11 Thread Eric Anholt
may be issues here. Signed-off-by: Eric Anholt --- Note that I haven't tested this change, and am not committed to this patch. It's just an optional cleanup, if it works for you. drivers/gpu/drm/mediatek/mtk_dsi.c | 125 - 1 file changed, 13

[PATCH v2 2/7] drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.

2017-05-11 Thread Eric Anholt
The newer version of the RPi panel driver is going to be a combination of a bridge and a panel, but we should also support panels without a bridge, so the panel-bridge layer lets us do that cleanly. v2: Drop "dev" argument. Signed-off-by: Eric Anholt Acked-by: Daniel Vetter --- d

[PATCH v2 6/7] drm/atmel-hlcdc: Drop custom encoder cleanup func.

2017-05-11 Thread Eric Anholt
drm_encoder_cleanup() finishes with memsetting it to 0, already. Signed-off-by: Eric Anholt --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu/drm/atmel

[PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper.

2017-05-11 Thread Eric Anholt
Another 100 lines of boilerplate gone. Bridges aren't supported yet, but will be trivial to add later. Signed-off-by: Eric Anholt --- Also untested. drivers/gpu/drm/stm/ltdc.c | 128 + drivers/gpu/drm/stm/ltdc.h | 2 +- 2 files change

[PATCH 4/4] drm/panel: Add the Raspberry Pi 7" touchscreen's panel.

2017-05-11 Thread Eric Anholt
The timings are those that the firmware defines as the baseline, which will be modified by the bridge/host as necessary to get the clocking to work. Signed-off-by: Eric Anholt --- drivers/gpu/drm/panel/panel-simple.c | 30 ++ 1 file changed, 30 insertions(+) diff

[PATCH 3/4] drm/bridge: Add support for the Raspberry Pi 7" Touchscreen.

2017-05-11 Thread Eric Anholt
: disable_touchscreen=1 ignore_lcd=2 mask_gpu_interrupt1=0x1000 This means that the firmware won't power on the panel at boot time (no rainbow) and the touchscreen input won't work. A native input driver for the touchscreen still needs to be written. Signed-off-by: Eric Anholt --- drive

[PATCH 2/4] dt-bindings: Document the Raspberry Pi Touchscreen nodes.

2017-05-11 Thread Eric Anholt
nodes (DSI device, I2C device, panel). Input will be left to a separate binding later, as it will be a basic I2C client device. Signed-off-by: Eric Anholt --- .../raspberrypi,7inch-touchscreen-bridge.txt | 68 ++ .../panel/raspberrypi,7inch-touchscreen-panel.txt | 7 ++

[PATCH 1/4] drm/vc4: Adjust modes in DSI to work around the integer PLL divider.

2017-05-11 Thread Eric Anholt
BCM2835's PLLD_DSI1 divider doesn't give us many choices for our pixel clocks, so to support panels on the Raspberry Pi we need to set a higher pixel clock rate than requested and adjust the mode we program to extend out the HFP so that the refresh rate matches. Signed-off-by: E

[PATCH 0/4] Raspberry Pi Touchscreen bridge/panel drivers

2017-05-11 Thread Eric Anholt
;t managed to resolve it. Still, I think this driver stack is useful to have, and I assume that fixing this will be a small bugfix somewhere later. Eric Anholt (4): drm/vc4: Adjust modes in DSI to work around the integer PLL divider. dt-bindings: Document the Raspberry Pi Touchscreen nodes

Re: [PATCH] phy: work around 'phys' references to usb-phy devices

2018-01-11 Thread Eric Anholt
Arnd Bergmann writes: > On Thu, Jan 11, 2018 at 2:30 PM, Kishon Vijay Abraham I wrote: >> On Thursday 11 January 2018 02:27 AM, Arnd Bergmann wrote: >>> On Mon, Jan 8, 2018 at 7:32 PM, Kishon Vijay Abraham I >>> wrote: On Monday 08 January 2018 06:31 PM, Arnd Bergmann wrote: > Stefan

[PATCH] drm: Print the pid when debug logging an ioctl error.

2018-01-30 Thread Eric Anholt
When we debug print what ioctl we're calling into, we include the pid. If you have multiple processes rendering simulataneously, the error return also needs the pid so you can see which of the ioctl calls was the one to fail. Signed-off-by: Eric Anholt --- drivers/gpu/drm/drm_ioctl.c | 2

Re: [RFC] Per file OOM badness

2018-01-18 Thread Eric Anholt
Michal Hocko writes: > On Thu 18-01-18 18:00:06, Michal Hocko wrote: >> On Thu 18-01-18 11:47:48, Andrey Grodzovsky wrote: >> > Hi, this series is a revised version of an RFC sent by Christian König >> > a few years ago. The original RFC can be found at >> > https://lists.freedesktop.org/archive

Re: [RFC] Per file OOM badness

2018-01-20 Thread Eric Anholt
Michel Dänzer writes: > On 2018-01-19 11:02 AM, Michel Dänzer wrote: >> On 2018-01-19 10:58 AM, Christian König wrote: >>> Am 19.01.2018 um 10:32 schrieb Michel Dänzer: On 2018-01-19 09:39 AM, Christian König wrote: > Am 19.01.2018 um 09:20 schrieb Michal Hocko: >> OK, in that case I

Re: [PATCH v2 05/19] drm/vc4: Use the alpha format field in drm_format_info

2018-01-22 Thread Eric Anholt
Maxime Ripard writes: > Now that the drm_format_info has a alpha field to tell if a format embeds > an alpha component in it, let's use it. > > Cc: Eric Anholt > Reviewed-by: Daniel Vetter > Signed-off-by: Maxime Ripard I had sent my r-b for the last version o

Re: [PATCH] Revert "ARM: dts: bcm283x: Fix DTC warnings about missing phy-cells"

2018-01-07 Thread Eric Anholt
Stefan Wahren writes: > This reverts commit 014d6da6cb2525d7f48fb08c705cb130cc7b5f4a. > > The DT clean up could trigger an endless deferred probe of DWC2 USB driver > on the Raspberry Pi 2/3. So revert the change until we fixed the probing > issue. Why's that? I found that I needed to enable th

Re: [PATCH] drm/vc4: Flush the caches before the bin jobs, as well.

2018-01-17 Thread Eric Anholt
Eric Anholt writes: > If the frame samples from a render target that was just written, its > cache flush during the binning step may have occurred before the > previous frame's RCL was completed. Flush the texture caches again > before starting each RCL job to make sure that th

Re: [PATCH 05/19] drm/vc4: Use the alpha format helper

2018-01-09 Thread Eric Anholt
Maxime Ripard writes: > Now that the core has a drm format helper to tell if a format embeds an > alpha component in it, let's use it. > > Cc: Eric Anholt > Signed-off-by: Maxime Ripard Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH v3 3/6] dt-bindings: soc: Add a binding for the Broadcom VCHIQ services. (v3)

2018-03-09 Thread Eric Anholt
Stefan Wahren writes: > Hi Eric, > >> Eric Anholt hat am 9. März 2018 um 19:44 geschrieben: >> >> >> The VCHIQ communication channel can be provided by BCM283x and Capri >> SoCs, to communicate with the VPU-side OS services. >> >> Signed-of

[PATCH] drm/vc4: Fix oops dereferencing DPI's connector since panel_bridge.

2018-03-09 Thread Eric Anholt
ed to the bridge, instead. Signed-off-by: Eric Anholt Fixes: 7b1298e05310 ("drm/vc4: Switch DPI to using the panel-bridge helper.") Cc: Boris Brezillon --- drivers/gpu/drm/vc4/vc4_dpi.c | 27 +++ 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/driv

[PATCH] drm/panel: simple: Fix the bus_format for the Ontat panel.

2018-03-09 Thread Eric Anholt
This fixes bad color output. When I was first testing the device I had the DPI hardware set to 666 mode, but apparently in the refactor to use the bus_format information from the panel driver, I failed to actually update the panel. Signed-off-by: Eric Anholt Fixes: e8b6f561b2ee ("drm/

[PATCH] ARM: bcm2835: Add the DPI hardware to the device tree.

2018-03-09 Thread Eric Anholt
It's currently marked disabled, as it's not useful without a panel associated with it and the GPIO pins routed to ALT2. Signed-off-by: Eric Anholt --- This patch got misplaced as part of the original VC4 DPI work (which included the binding). I've got a full branch demoing a

Re: [PATCH v4 2/3] pinctrl: bcm2835: Add support for generic pinctrl binding

2018-03-12 Thread Eric Anholt
ed to create new node properties in the device trees. > > The logic of this change maintain the old brcm legacy binding support in order > to keep the ABI stable. > > Signed-off-by: Matheus Castello 2-3 are: Reviewed-by: Eric Anholt signature.asc Description: PGP signature

[PATCH 3/5] dt-bindings: soc: Add a binding for the Broadcom VCHI services.

2018-03-05 Thread Eric Anholt
The VCHI communication channel can be provided by BCM283x and Capri SoCs, to communicate with the VPU-side OS services. Signed-off-by: Eric Anholt --- .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt | 18 ++ 1 file changed, 18 insertions(+) create mode 100644

[PATCH 2/5] staging: vc04_services: Remove cache-line-size property.

2018-03-05 Thread Eric Anholt
This was just a way for the DT-passed value to get out of sync with what Linux has configured the ARM for. Signed-off-by: Eric Anholt --- .../interface/vchiq_arm/vchiq_2835_arm.c | 25 +++--- .../interface/vchiq_arm/vchiq_pagelist.h | 1 - 2 files changed, 8

[PATCH 1/5] staging: vc04_services: Remove dead FRAGMENTS_T

2018-03-05 Thread Eric Anholt
It's not used in-tree, or in the downstream tree. Signed-off-by: Eric Anholt --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_pagelist.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_pagelist.h b/drivers/st

  1   2   3   4   5   6   7   8   9   10   >