Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-06 Thread Florent Flament
Hi Benjamin, Nestor, On Tue, 2018-03-06 at 00:31 +0100, Florent Flament wrote: > On Mon, 2018-03-05 at 18:26 +0100, Benjamin Tissoires wrote: > > Hi Florent, > > Hi Benjamin, > > > > > On Mon, Mar 5, 2018 at 10:31 AM, Nestor Lopez Casado > > <nlope

[PATCH] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-04 Thread Florent Flament
is pressed. The keyboard mode is set through the fn_mode module parameter: when set to 1 (default setting) the keyboard behaves as with the generic HID driver, when set to 0 the keyboard is configured to work as standard keyboards. Signed-off-by: Florent Flament <cont...@florentflament.com> --- d

Re: [PATCH] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-04 Thread Florent Flament
On Sat, 2018-03-03 at 18:08 +0200, Andy Shevchenko wrote: > On Sat, Mar 3, 2018 at 12:04 AM, Florent Flament > <cont...@florentflament.com> wrote: > > With the generic HID driver, K290 keyboards' F1 to F12 keys send > > multimedia events by default, and standard keycod

[PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-04 Thread Florent Flament
is pressed. The keyboard mode is set through the fn_mode module parameter: when set to 1 (default setting) the keyboard behaves as with the generic HID driver, when set to 0 the keyboard is configured to work as standard keyboards. Signed-off-by: Florent Flament <cont...@florentflament.com> --- d

[PATCH v2 0/1] Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-04 Thread Florent Flament
Changes in v2: * Using SPDX ID instead of licence statement * Removed unnecessary includes (linux/moduleparam.h and linux/mod_devicetable.h) ps: Sorry for having broken the previous thread and sent the previous mail without proper versioning of the patch. Florent Flament (1): HID: Logitech

[PATCH] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-02 Thread Florent Flament
is pressed. The keyboard mode is set through the fn_mode module parameter: when set to 1 (default setting) the keyboard behaves as with the generic HID driver, when set to 0 the keyboard is configured to work as standard keyboards. Signed-off-by: Florent Flament <cont...@florentflament.com> --- d

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-05 Thread Florent Flament
r and send multimedia > > > events > > > when the function key is pressed. The keyboard mode is set > > > through the > > > fn_mode module parameter: when set to 1 (default setting) the > > > keyboard > > > behaves as with the generic HID driv

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-05 Thread Florent Flament
On Mon, 2018-03-05 at 10:31 +0100, Nestor Lopez Casado wrote: > Hello Florent, Hi Nestor, > In my view, this driver may not be a good idea. The default behaviour > of K290 is 'send multimedia keycodes' with the user given the choice > to change that behaviour via vendor commands. Putting a

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-05 Thread Florent Flament
On Mon, 2018-03-05 at 10:31 +0100, Nestor Lopez Casado wrote: > Hello Florent, Hi Nestor, > In my view, this driver may not be a good idea. The default behaviour > of K290 is 'send multimedia keycodes' with the user given the choice > to change that behaviour via vendor commands. Putting a

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-05 Thread Florent Flament
t; > One other thing I do not like in this submission of the driver is the > direct use of USB while we have a full transport agnostic layer > called > HID. Fair enough, I didn't have a look at how hid-logitech-hidpp is working yet. I'll dig into that to see if this driver can me

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-06 Thread Florent Flament
Hi Benjamin, Nestor, On Tue, 2018-03-06 at 00:31 +0100, Florent Flament wrote: > On Mon, 2018-03-05 at 18:26 +0100, Benjamin Tissoires wrote: > > Hi Florent, > > Hi Benjamin, > > > > > On Mon, Mar 5, 2018 at 10:31 AM, Nestor Lopez Casado > > wrote: > >

[PATCH] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-02 Thread Florent Flament
is pressed. The keyboard mode is set through the fn_mode module parameter: when set to 1 (default setting) the keyboard behaves as with the generic HID driver, when set to 0 the keyboard is configured to work as standard keyboards. Signed-off-by: Florent Flament --- drivers/hid/Kconfig | 18

Re: [PATCH] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-04 Thread Florent Flament
On Sat, 2018-03-03 at 18:08 +0200, Andy Shevchenko wrote: > On Sat, Mar 3, 2018 at 12:04 AM, Florent Flament > wrote: > > With the generic HID driver, K290 keyboards' F1 to F12 keys send > > multimedia events by default, and standard keycodes when the > > function > &g

[PATCH] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-04 Thread Florent Flament
is pressed. The keyboard mode is set through the fn_mode module parameter: when set to 1 (default setting) the keyboard behaves as with the generic HID driver, when set to 0 the keyboard is configured to work as standard keyboards. Signed-off-by: Florent Flament --- drivers/hid/Kconfig | 18

[PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-04 Thread Florent Flament
is pressed. The keyboard mode is set through the fn_mode module parameter: when set to 1 (default setting) the keyboard behaves as with the generic HID driver, when set to 0 the keyboard is configured to work as standard keyboards. Signed-off-by: Florent Flament --- drivers/hid/Kconfig | 18

[PATCH v2 0/1] Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-04 Thread Florent Flament
Changes in v2: * Using SPDX ID instead of licence statement * Removed unnecessary includes (linux/moduleparam.h and linux/mod_devicetable.h) ps: Sorry for having broken the previous thread and sent the previous mail without proper versioning of the patch. Florent Flament (1): HID: Logitech