Re: acked-by meaning

2012-11-13 Thread Frank Rowand
On 11/11/12 19:47, Randy Dunlap wrote: On 11/11/2012 05:40 PM, Thiago Farina wrote: Hi, What is the meaning of 'Acked-by:' line? Is the same of LGTM? How it differs from 'Reviewed-by:'? Reviewed-by: is stronger than Acked-by:. If someone replies with Reviewed-by, they also accept some

[PATCH] Realtime preempt support for PPC

2005-02-16 Thread Frank Rowand
pn_smp PREEMPT_VOLUNTARY pv pv_smp PREEMPT_DESKTOP pd pd_smp PREEMPT_RTpr pr_smp Any comments, suggestions, needed changes, etc are welcome. Thanks, -Frank Frank Rowand [EMAIL PROTECTED] MontaVista Software, Inc Source: MontaVista Software

Re: [PATCH] Realtime preempt support for PPC

2005-02-17 Thread Frank Rowand
Ingo Molnar wrote: * Frank Rowand [EMAIL PROTECTED] wrote: I have attached a patch to add realtime support for PowerPC (32 bit only). [...] two comments: - why is us_to_tb needed? It just seems to add alot of unnecessary clutter to the patch, while it's not used anywhere. Sorry, the usage

Re: [PATCH 0/5] ppc RT: Realtime preempt support for PPC

2005-03-21 Thread Frank Rowand
Ingo Molnar wrote: hi Frank - sorry about the late reply, was busy with other things. Your My turn to be late, but now I'm back from vacation :-). ppc patches look mostly mergeable, with some small details still open: * Frank Rowand [EMAIL PROTECTED] wrote: The patches are: 1/5 ppc_rt.patch

[PATCH 0/5] ppc RT: Realtime preempt support for PPC

2005-03-07 Thread Frank Rowand
lat_pd_smp PREEMPT_RTpr pr_smp lat_pr lat_pr_smp Any comments, suggestions, needed changes, etc are welcome. Thanks, -Frank -- Frank Rowand [EMAIL PROTECTED] MontaVista Software, Inc config_tar.gz Description: GNU Zip compressed data

[PATCH 1/5] ppc RT: ppc_rt.patch

2005-03-07 Thread Frank Rowand
Source: MontaVista Software, Inc. Signed-off-by: Frank Rowand [EMAIL PROTECTED] Index: linux-2.6.10/arch/ppc/Kconfig === --- linux-2.6.10.orig/arch/ppc/Kconfig +++ linux-2.6.10/arch/ppc/Kconfig @@ -17,9 +17,16 @@ config

[PATCH 4/5] ppc RT: ibm_emac_core.patch

2005-03-07 Thread Frank Rowand
Source: MontaVista Software, Inc. Signed-off-by: Frank Rowand [EMAIL PROTECTED] Index: linux-2.6.10/drivers/net/ibm_emac/ibm_emac_core.c === --- linux-2.6.10.orig/drivers/net/ibm_emac/ibm_emac_core.c +++ linux-2.6.10/drivers/net

[PATCH 3/5] ppc RT: ppc_mcount.patch

2005-03-07 Thread Frank Rowand
Source: MontaVista Software, Inc. Signed-off-by: Frank Rowand [EMAIL PROTECTED] Index: linux-2.6.10/arch/ppc/kernel/entry.S === --- linux-2.6.10.orig/arch/ppc/kernel/entry.S +++ linux-2.6.10/arch/ppc/kernel/entry.S @@ -1018,3

[PATCH 5/5] ppc RT: smp405.patch

2005-03-07 Thread Frank Rowand
Source: MontaVista Software, Inc. Signed-off-by: Frank Rowand [EMAIL PROTECTED] Index: linux-2.6.10/arch/ppc/kernel/head_4xx.S === --- linux-2.6.10.orig/arch/ppc/kernel/head_4xx.S +++ linux-2.6.10/arch/ppc/kernel/head_4xx.S

[PATCH 2/5] ppc RT: ppc_cpu_khz.patch

2005-03-07 Thread Frank Rowand
Source: MontaVista Software, Inc. Signed-off-by: Frank Rowand [EMAIL PROTECTED] Index: linux-2.6.10/arch/ppc/platforms/prpmc800.c === --- linux-2.6.10.orig/arch/ppc/platforms/prpmc800.c +++ linux-2.6.10/arch/ppc/platforms/prpmc800.c

Re: [PATCH 0/5] ppc RT: Realtime preempt support for PPC

2005-03-30 Thread Frank Rowand
Frank Rowand wrote: Ingo Molnar wrote: hi Frank - sorry about the late reply, was busy with other things. Your My turn to be late, but now I'm back from vacation :-). ppc patches look mostly mergeable, with some small details still open: * Frank Rowand [EMAIL PROTECTED] wrote: The patches

Re: [PATCH 0/5] ppc RT: Realtime preempt support for PPC

2005-04-01 Thread Frank Rowand
Ingo Molnar wrote: * Frank Rowand [EMAIL PROTECTED] wrote: more stuff deleted I'm working on the architecture support for realtime on PPC64 now. If the lock field of struct raw_rwlock_t is a long instead of int then /proc/meminfo shows MemFree decreasing from 485608 kB to 485352 kB. Do you

Re: PPC RT Patch..

2005-02-23 Thread Frank Rowand
sets of eyes have agreed. Frank's patch may have missed some EXPORT_SYMBOL()s in arch/ppc/lib/locks.c. I'll check those over again tomorrow. -john -Frank -- Frank Rowand [EMAIL PROTECTED] MontaVista Software, Inc - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-13 Thread Frank Rowand
On 07/13/12 14:55, Dave Jones wrote: On Fri, Jul 13, 2012 at 11:50:25PM +0200, Paul Bolle wrote: But just removing all the certainly unused macros probably wouldn't have made a noticeable difference to anyone using those defconfig files anyway. My point is that I don't think there's

[BUG] bisected: PandaBoard smsc95xx ethernet driver error from USB timeout

2013-03-20 Thread Frank Rowand
Hi All, Not quite sure quite where the problem is (USB, OMAP, smsc95xx driver, other???), so casting the nets wide... The PandaBoard frequently fails to boot with an eth0 error when mounting the root file system via NFS (ethernet driver fails due to a USB timeout; no ethernet means NFS won't

Re: [BUG] bisected: PandaBoard smsc95xx ethernet driver error from USB timeout

2013-03-21 Thread Frank Rowand
On 03/21/13 07:41, Alan Stern wrote: On Wed, 20 Mar 2013, Frank Rowand wrote: Hi All, Not quite sure quite where the problem is (USB, OMAP, smsc95xx driver, other???), so casting the nets wide... The PandaBoard frequently fails to boot with an eth0 error when mounting the root file

Re: [BUG] bisected: PandaBoard smsc95xx ethernet driver error from USB timeout

2013-03-21 Thread Frank Rowand
On 03/21/13 02:00, Ming Lei wrote: Hi Frank, On Thu, Mar 21, 2013 at 11:29 AM, Frank Rowand frank.row...@am.sony.com wrote: I found the problem on 3.6.11, but have not replicated it on 3.9-rcX yet because my config fails to build on 3.9-rc1 and 3.9-rc2. I'll try to work on that issue

Re: linux-3.6.11-rt30 smoke test on ARM

2013-03-21 Thread Frank Rowand
On 03/12/13 17:44, Frank Rowand wrote: On 03/11/13 10:34, Sebastian Andrzej Siewior wrote: * Frank Rowand | 2013-03-07 20:03:18 [-0800]: panda boot often fails due to a usb timeout, while sending a command on behalf of the smsc95xx ethernet driver. This patch is a temporary hack to force

Re: [BUG] bisected: PandaBoard smsc95xx ethernet driver error from USB timeout

2013-03-21 Thread Frank Rowand
On 03/21/13 13:25, Frank Rowand wrote: On 03/21/13 02:00, Ming Lei wrote: snip -- There are some timeout messages that I am not positive are symptoms of the problem. With these messages, the smsc95xx driver initialization is successful, so the ethernet device is available

Re: [BUG] bisected: PandaBoard smsc95xx ethernet driver error from USB timeout

2013-03-21 Thread Frank Rowand
On 03/21/13 07:41, Alan Stern wrote: On Wed, 20 Mar 2013, Frank Rowand wrote: Hi All, Not quite sure quite where the problem is (USB, OMAP, smsc95xx driver, other???), so casting the nets wide... The PandaBoard frequently fails to boot with an eth0 error when mounting the root file

Re: [BUG] bisected: PandaBoard smsc95xx ethernet driver error from USB timeout

2013-03-22 Thread Frank Rowand
On 03/22/13 03:03, Mats Liljegren wrote: Frank Rowand wrote: On 03/21/13 07:41, Alan Stern wrote: On Wed, 20 Mar 2013, Frank Rowand wrote: Hi All, Not quite sure quite where the problem is (USB, OMAP, smsc95xx driver, other???), so casting the nets wide... The PandaBoard frequently

linux-3.0.66-rt93 smoke test on ARM

2013-03-07 Thread Frank Rowand
linux-3.0.66-rt93 builds and boots on some ARM boards (PandaBoard, Realview) for: - SMP, PREEMPT_RT_FULL - SMP, PREEMPT_NONE - UP, PREEMPT_RT_FULL - UP, PREEMPT_NONE -Frank -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

linux-3.4.33-rt47 smoke test on ARM

2013-03-07 Thread Frank Rowand
linux-3.4.33-rt47 builds and boots on some ARM boards (PandaBoard, Realview) for: - SMP, PREEMPT_RT_FULL - SMP, PREEMPT_NONE - UP, PREEMPT_RT_FULL - UP, PREEMPT_NONE -Frank -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

linux-3.2.39-rt59 smoke test on ARM

2013-03-07 Thread Frank Rowand
linux-3.2.39-rt59 builds and boots on some ARM boards (PandaBoard, Realview) for: - SMP, PREEMPT_RT_FULL - SMP, PREEMPT_NONE - UP, PREEMPT_RT_FULL - UP, PREEMPT_NONE -Frank -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: linux-3.6.11-rt30 smoke test on ARM

2013-03-07 Thread Frank Rowand
On 03/07/13 19:55, Frank Rowand wrote: linux-3.6.11-rt30 builds and boots on some ARM boards (PandaBoard, Realview) for: - SMP, PREEMPT_RT_FULL - SMP, PREEMPT_NONE - UP, PREEMPT_RT_FULL - UP, PREEMPT_NONE The PandaBoard frequently fails to boot with an eth0 error. I have

linux-3.6.11-rt30 smoke test on ARM

2013-03-07 Thread Frank Rowand
linux-3.6.11-rt30 builds and boots on some ARM boards (PandaBoard, Realview) for: - SMP, PREEMPT_RT_FULL - SMP, PREEMPT_NONE - UP, PREEMPT_RT_FULL - UP, PREEMPT_NONE The PandaBoard frequently fails to boot with an eth0 error. I have only seen this for SMP, PREEMPT_NONE. This same

Re: linux-3.6.11-rt30 smoke test on ARM

2013-03-12 Thread Frank Rowand
On 03/11/13 10:34, Sebastian Andrzej Siewior wrote: * Frank Rowand | 2013-03-07 20:03:18 [-0800]: panda boot often fails due to a usb timeout, while sending a command on behalf of the smsc95xx ethernet driver. This patch is a temporary hack to force a retry when the timeout occurs

Re: 3.6.7-rt18 ARM BUG_ON() at kernel/sched/core.c:3817

2012-11-29 Thread Frank Rowand
On 11/28/12 19:31, Frank Rowand wrote: 3.6.7-rt18: kernel BUG at .../kernel/sched/core.c:3817! Grant reported this same problem for 3.6.5-rt15. I am seeing it on a different arm board. Here is the BUG_ON(): asmlinkage void __sched preempt_schedule_irq(void) { struct

Re: [ANNOUNCE] 3.0.53-rt77

2012-11-29 Thread Frank Rowand
On 11/27/12 18:44, Steven Rostedt wrote: Dear RT Folks, I'm pleased to announce the 3.0.53-rt77 stable release. 3.0.53-rt77 builds and boots on some ARM boards (PandaBoard, Realview) for: - SMP, PREEMPT_RT_FULL - SMP, PREEMPT_NONE - UP, PREEMPT_RT_FULL - UP, PREEMPT_NONE -Frank

linux-3.6.7-rt18 smoke test on ARM

2012-11-29 Thread Frank Rowand
3.6.7-rt18 builds and boots on some ARM boards (PandaBoard, Realview) for: - SMP, PREEMPT_RT_FULL - SMP, PREEMPT_NONE - UP, PREEMPT_RT_FULL - UP, PREEMPT_NONE A patch is required to resolve a BUG_ON() from preempt_schedule_irq(). The patch is available at

[PATCH RT 0/2][RFC] fix RCU stall warning on ARM

2012-12-04 Thread Frank Rowand
The RCU stall warning functions call trigger_all_cpu_backtrace() to print a backtrace on each cpu. This function is only implemented for x86. Add a version for ARM. With CONFIG_PREEMPT_RT_FULL enabled, flushing the output from printk() is inhibited in some contexts to avoid increasing real time

[PATCH RT 1/2][RFC] ARM version of arch_trigger_all_cpu_backtrace()

2012-12-04 Thread Frank Rowand
The RCU stall warning functions print_cpu_stall() and print_other_cpu_stall() call trigger_all_cpu_backtrace() to print a backtrace on each cpu. This function is only implemented for x86. Add a version for ARM. Signed-off-by: Frank Rowand frank.row...@am.sony.com --- arch/arm/include/asm

[PATCH RT 2/2][RFC] let RCU stall messages escape with CONFIG_PREEMPT_RT_FULL

2012-12-04 Thread Frank Rowand
-by: Frank Rowand frank.row...@am.sony.com --- kernel/printk.c |53 + 2 - 0 ! kernel/rcutree.c | 1414 +0 - 0 ! 2 files changed, 17 insertions(+), 2 deletions(-) Index: b/kernel/printk.c

Re: [PATCH RT 0/2][RFC] fix RCU stall warning on ARM

2012-12-04 Thread Frank Rowand
print_cpu_stall() echo 1 /proc/sys/kernel/zzz_debug_print_stall_once # test print_other_cpu_stall() echo 2 /proc/sys/kernel/zzz_debug_print_stall_once Signed-off-by: Frank Rowand frank.row...@am.sony.com --- kernel/rcutree.c | 2626 +0 - 0 ! kernel/sysctl.c | 11

Re: [PATCH RT 0/2][RFC] fix RCU stall warning on ARM

2012-12-04 Thread Frank Rowand
On 12/04/12 20:47, Frank Rowand wrote: The RCU stall warning functions call trigger_all_cpu_backtrace() to print a backtrace on each cpu. This function is only implemented for x86. Add a version for ARM. With CONFIG_PREEMPT_RT_FULL enabled, flushing the output from printk() is inhibited

Re: [PATCH RT 0/2] [ANNOUNCE] 3.0.42-rt64-rc1 stable review

2012-09-13 Thread Frank Rowand
On 09/13/12 11:52, Steven Rostedt wrote: Dear RT Folks, This is the RT stable review cycle of patch 3.0.42-rt64-rc1. Tested on: - ARM mpcore - ARM panda For configurations: - SMP CONFIG_PREEMPT_NONE - UP CONFIG_PREEMPT_NONE - SMP CONFIG_PREEMPT_RT_FULL - UP

Re: [PATCH RT 0/2] [ANNOUNCE] 3.2.28-rt43-rc1 stable review

2012-09-16 Thread Frank Rowand
On 09/13/12 11:57, Steven Rostedt wrote: Dear RT Folks, This is the RT stable review cycle of patch 3.2.28-rt43-rc1. Tested on: - ARM mpcore - ARM panda For configurations: - SMP CONFIG_PREEMPT_NONE - UP CONFIG_PREEMPT_NONE - SMP CONFIG_PREEMPT_RT_FULL - UP

[PATCH RT v2] cpu unplug with PREEMPT_LL

2012-07-26 Thread Frank Rowand
in the RT patch set but it may be useful to anyone determined to use cpu hotplug with PREEMPT_LL. This patch was tested on 3.0.36-rt58 since that release has the latest hotplug patches. I will rework and test this on 3.5-rtX when that is available. Signed-off-by: Frank Rowand frank.row

Re: [PATCH RT 05/12] slab: Prevent local lock deadlock

2012-07-26 Thread Frank Rowand
On 07/18/12 15:39, Steven Rostedt wrote: From: Thomas Gleixner t...@linutronix.de On RT we avoid the cross cpu function calls and take the per cpu local locks instead. Now the code missed that taking the local lock on the cpu which runs the code must use the proper local lock functions and

Re: [PATCH RT 05/12] slab: Prevent local lock deadlock

2012-07-30 Thread Frank Rowand
On 07/30/12 18:22, Steven Rostedt wrote: On Thu, 2012-07-26 at 17:15 -0700, Frank Rowand wrote: Config is from arch/arm/configs/omap2plus_defconfig plus: CONFIG_USB_EHCI_HCD=y CONFIG_USB_NET_SMSC95XX=y CONFIG_PREEMPT_RT_FULL=y Interesting, I just booted my panda board

Re: [PATCH RT 05/12] slab: Prevent local lock deadlock

2012-07-31 Thread Frank Rowand
On 07/30/12 19:32, Steven Rostedt wrote: On Mon, 2012-07-30 at 19:22 -0700, Frank Rowand wrote: On 07/30/12 18:22, Steven Rostedt wrote: On Thu, 2012-07-26 at 17:15 -0700, Frank Rowand wrote: Config is from arch/arm/configs/omap2plus_defconfig plus: CONFIG_USB_EHCI_HCD=y

Re: [PATCH RT 2/2] fix printk flush of messages

2012-08-21 Thread Frank Rowand
added recipients... On 08/21/12 07:30, Michael Thalmeier wrote: Frank Rowand frank.rowand at am.sony.com writes: Updates console-make-rt-friendly.patch #ifdef CONFIG_PREEMPT_RT_FULL, printk() output is never flushed by printk() because: ... On system boot some printk() output

Re: [PATCH RT 0/2] [ANNOUNCE] 3.0.41-rt62-rc1 stable review

2012-08-27 Thread Frank Rowand
-allow-immediate-magic-sysrq-output-for-preempt_rt_full.patch It is not a big deal if the reversal patch gets left out of the stable releases, but it is cleaner if it is included. This also applies to 3.2.28-rt42-rc1 snip Changes from 3.0.41-rt61: --- Frank Rowand (1): fix printk

Re: [PATCH RT 05/12] slab: Prevent local lock deadlock

2012-07-31 Thread Frank Rowand
On 07/31/12 12:11, Steven Rostedt wrote: On Tue, 2012-07-31 at 12:00 -0700, Frank Rowand wrote: Yeah, my root fs is on the sdcard. Did you get this bug every time or was it sporadic? I get it every boot. Can you try it with an SD card? I can set it up for nfs as well, but that would

[PATCH] lost softirq, 2.6.24-rc7

2008-01-15 Thread Frank Rowand
From: Frank Rowand [EMAIL PROTECTED] (Ingo, there is a question for you after the description, just before the patch.) When running an interrupt and network intensive stress test with PREEMPT_RT enabled, the target system stopped processing received network packets. skbs from received packets

[PATCH 0/4] RT: fixes for kernel build errors on MIPS RBTX4927, 2.6.24-rc7

2008-01-15 Thread Frank Rowand
From: Frank Rowand [EMAIL PROTECTED] This patch series is a few small fixes to kernel build errors for the Toshiba RBTX4927 MIPS board in the 2.6.24-rc7 kernel, with the 2.6.24-rc7-rt2 patch previously applied. These patches are directly related to the -rt2 patch, not to the vanilla MIPS tree

[PATCH 1/4] RT: remove duplicate time/Kconfig

2008-01-15 Thread Frank Rowand
From: Frank Rowand [EMAIL PROTECTED] time/Kconfig added by preempt-realtime-mips.patch duplicates other entry, resulting in kernel make error: Signed-off-by: Frank Rowand [EMAIL PROTECTED] --- arch/mips/Kconfig |2 0 + 2 - 0 ! 1 files changed, 2 deletions(-) Index: linux

[PATCH 2/4] RT: remove conflicting rtc_lock declaration

2008-01-15 Thread Frank Rowand
From: Frank Rowand [EMAIL PROTECTED] Declaration of rtc_lock in arch/mips/kernel/time.c conflicts with time.h, remove from include/asm-mips/time.h. Signed-off-by: Frank Rowand [EMAIL PROTECTED] --- include/asm-mips/time.h |2 0 + 2 - 0 ! 1 files changed, 2 deletions

[PATCH 3/4] RT: remove finish_arch_switch

2008-01-15 Thread Frank Rowand
From: Frank Rowand [EMAIL PROTECTED] This is probably just a temporary workaround for one procssor - the MIPS community will most likely want to architect a solution to this issue. Make of preempt kernel barfs in kernel/sched.c ifdef finish_arch_switch. Remove the finish_arch_switch() for boards

[PATCH 4/4] RT: change from raw_spinlock_t to __raw_spinlock_t

2008-01-15 Thread Frank Rowand
From: Frank Rowand [EMAIL PROTECTED] Fix compile warning (which becomes compile error due to -Werror), by changing from raw_spinlock_t to __raw_spinlock_t. Signed-off-by: Frank Rowand [EMAIL PROTECTED] --- arch/mips/kernel/gdb-stub.c |2 1 + 1 - 0 ! 1 files changed, 1 insertion

Re: [PATCH 1/4] RT: remove duplicate time/Kconfig

2008-01-16 Thread Frank Rowand
On Wed, 2008-01-16 at 20:29 -0500, Steven Rostedt wrote: On Wed, 16 Jan 2008, Frank Rowand wrote: time/Kconfig added by preempt-realtime-mips.patch duplicates other entry, resulting in kernel make error: Signed-off-by: Frank Rowand [EMAIL PROTECTED] --- arch/mips/Kconfig |2

Re: [08/36] AArch64: Kernel booting and initialisation

2012-07-24 Thread Frank Rowand
On 07/24/12 11:53, Arnd Bergmann wrote: On Tuesday 24 July 2012, Catalin Marinas wrote: On Mon, Jul 23, 2012 at 09:52:22PM +0100, Christopher Covington wrote: Hi Catalin and Stephen, Catalin Marinas - July 8, 2012, 9:18 a.m. On Fri, Jul 06, 2012 at 10:32:54PM +0100, Stephen Warren wrote:

[PATCH RT] cpu unplug with PREEMPT_LL

2012-07-24 Thread Frank Rowand
in the RT patch set but it may be useful to anyone determined to use cpu hotplug with PREEMPT_LL. This patch was tested on 3.0.36-rt58 since that release has the latest hotplug patches. I will re-test this on 3.5-rtX when that is available. Signed-off-by: Frank Rowand frank.row...@am.sony.com

Re: [PATCH RT 2/2][RFC] let RCU stall messages escape with CONFIG_PREEMPT_RT_FULL

2012-12-10 Thread Frank Rowand
On 12/10/12 06:29, Paul E. McKenney wrote: On Tue, Dec 04, 2012 at 08:52:21PM -0800, Frank Rowand wrote: The printk()s in RCU stall warnings do not get flushed to the console on ARM. Add the oops_in_progress flag back into the special trylock case in console_trylock_for_printk(), and set

Re: [RFC][PATCH RT 3/4] sched/rt: Use IPI to trigger RT task push migration instead of pulling

2012-12-10 Thread Frank Rowand
On 12/07/12 15:56, Steven Rostedt wrote: When debugging the latencies on a 40 core box, where we hit 300 to 500 microsecond latencies, I found there was a huge contention on the runqueue locks. Investigating it further, running ftrace, I found that it was due to the pulling of RT tasks.

Re: [RFC][PATCH RT 3/4] sched/rt: Use IPI to trigger RT task push migration instead of pulling

2012-12-10 Thread Frank Rowand
On 12/10/12 16:48, Frank Rowand wrote: On 12/07/12 15:56, Steven Rostedt wrote: When debugging the latencies on a 40 core box, where we hit 300 to 500 microsecond latencies, I found there was a huge contention on the runqueue locks. Investigating it further, running ftrace, I found

3.6.7-rt18 ARM BUG_ON() at kernel/sched/core.c:3817

2012-11-28 Thread Frank Rowand
3.6.7-rt18: kernel BUG at .../kernel/sched/core.c:3817! Grant reported this same problem for 3.6.5-rt15. I am seeing it on a different arm board. Here is the BUG_ON(): asmlinkage void __sched preempt_schedule_irq(void) { struct thread_info *ti = current_thread_info();

Re: memory binding issues

2013-09-17 Thread Frank Rowand
On 9/17/2013 9:43 AM, Olof Johansson wrote: On Tue, Sep 17, 2013 at 09:56:39AM +0200, Tomasz Figa wrote: I'm afraid that I must disagree. For consistency I'd rather go with what Ben said. Please see ePAPR chapter 2.2.1.1, which clearly defines how nodes should be named. 2.2.1.1 is there

[PATCH] gpio: null pointer dereference in error handling in gpiolib.c

2013-08-29 Thread Frank Rowand
that explained the cause of one example of panic when desc-chip is NULL and fixed that example (http://lkml.indiana.edu/hypermail/linux/kernel/1308.3/01473.html) was accepted. This patch fixes the remaining locations which have the same problem. Signed-off-by: Frank Rowand frank.row...@sonymobile.com

[PATCH] slub: Proper kmemleak tracking if CONFIG_SLUB_DEBUG disabled

2013-09-27 Thread Frank Rowand
under CONFIG_SLUB_DEBUG. Signed-off-by: Roman Bobniev roman.bobn...@sonymobile.com Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- mm/slub.c |6 3 + 3 - 0 ! 1 file changed, 3 insertions(+), 3 deletions(-) Index: b/mm/slub.c

Re: [PATCH RFC 1/2] MAINTAINERS: Add R: designated-reviewers tag

2014-06-05 Thread Frank Rowand
On 6/4/2014 9:01 PM, Dave Chinner wrote: On Tue, Jun 03, 2014 at 01:43:47PM -0400, Steven Rostedt wrote: On Tue, 3 Jun 2014 17:16:54 +1000 Dave Chinner da...@fromorbit.com wrote: If you take it to an extremes. Think about what you can test in 15 minutes. Or for larger patchsets, how long it

[RFC PATCH 0/3] devicetree, qcomm PMIC: fix node name conflict

2014-05-06 Thread Frank Rowand
An issue with the path of SPMI nodes under /sys/bus/... was reported in https://lkml.org/lkml/2014/4/23/312. The symptom is that two different grandchild nodes of the spmi with the same node-name@unit-address will result in attempting to create duplicate links at

[RFC PATCH 1/3] devicetree: set bus type same as parent

2014-05-06 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com This is a somewhat scary patch since it touches a path that is central to device creation based on the device tree. It should not be applied without careful consideration. I am not sure if this patch is a good idea, even if it does not break

[RFC PATCH 2/3] devicetree: provide hook to allow setting devicetree device name

2014-05-06 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Optionally push devicetree device naming into a function called dynamically by of_device_alloc(). TODO: Change made to of_device_alloc() could also be made to of_amba_device_create() Signed-off-by: Frank Rowand frank.row...@sonymobile.com

[RFC PATCH 3/3] devicetree, qcomm PMIC: use new hook to make PMIC device names unique

2014-05-06 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com The previous patch in the series does: Optionally push device naming into a function called dynamically by of_device_alloc(). This patch adds an example of using that capability. Signed-off-by: Frank Rowand frank.row...@sonymobile.com

Re: [RFC PATCH 0/3] devicetree, qcomm PMIC: fix node name conflict

2014-05-06 Thread Frank Rowand
On 5/6/2014 6:32 PM, Rob Herring wrote: On Tue, May 6, 2014 at 7:48 PM, Frank Rowand frowand.l...@gmail.com wrote: An issue with the path of SPMI nodes under /sys/bus/... was reported in https://lkml.org/lkml/2014/4/23/312. The symptom is that two different snip I think the primary

Re: [PATCH 0/4] DT platform device name collision fixes

2014-05-07 Thread Frank Rowand
. It is papering over a symptom, instead of dealing with the root cause. But despite my opinion, you can add to patches 2-4 (I did not test the self-test added in patch 1): Tested-by: Frank Rowand frank.row...@sonymobile.com The patches resolve the name conflict originally reported for the qcomm

Re: [PATCH 1/4] of/selftest: add testcase for nodes with same name and address

2014-05-07 Thread Frank Rowand
the original problem reported. This probably is not a big deal, but I'm trying to figure out if I can modify the test to also show the original problem. The test case also properly reports the failure. Once all 4 patches are applied, then the test case passes. Thus: Tested-by: Frank Rowand

Re: [PATCH 0/4] DT platform device name collision fixes

2014-05-07 Thread Frank Rowand
On 5/7/2014 3:52 PM, Frank Rowand wrote: On 5/7/2014 2:48 PM, Rob Herring wrote: From: Rob Herring r...@kernel.org This series fixes the device naming collisions that can occur with nultiple devices having the same name and non-translatable unit addresses. This issue was raised

Re: [PATCH 1/4] of/selftest: add testcase for nodes with same name and address

2014-05-08 Thread Frank Rowand
On 5/8/2014 1:59 AM, Grant Likely wrote: On Thu, May 8, 2014 at 3:51 AM, Frank Rowand frowand.l...@gmail.com wrote: On 5/7/2014 2:48 PM, Rob Herring wrote: From: Rob Herring r...@kernel.org Add a test case for nodes which have the same name and same non-translatable unit address. If I

Re: [PATCH 1/4] of/selftest: add testcase for nodes with same name and address

2014-05-08 Thread Frank Rowand
On 5/7/2014 7:51 PM, Frank Rowand wrote: On 5/7/2014 2:48 PM, Rob Herring wrote: From: Rob Herring r...@kernel.org Add a test case for nodes which have the same name and same non-translatable unit address. If I apply patch 1 and 2 without applying 3 and 4 then console warnings are printed

[RFC PATCH] OF: fix of_find_node_by_path() assumption that of_allnodes is root

2014-06-12 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com Pantelis Antoniou reports that of_find_node_by_path() is borked because of_allnodes is not guaranteed to contain the root of the tree after using any of the dynamic update functions because some other nodes ends up as of_allnodes. Fixes

Re: [RFC PATCH] OF: fix of_find_node_by_path() assumption that of_allnodes is root

2014-06-13 Thread Frank Rowand
On 6/13/2014 6:52 AM, Rob Herring wrote: On Fri, Jun 13, 2014 at 12:53 AM, Frank Rowand frowand.l...@gmail.com wrote: From: Frank Rowand frank.row...@sonymobile.com Pantelis Antoniou reports that of_find_node_by_path() is borked because of_allnodes is not guaranteed to contain the root

Re: [PATCH 2/3] of: Make of_find_node_by_path() handle /aliases

2014-05-20 Thread Frank Rowand
On 5/18/2014 2:27 AM, Grant Likely wrote: On Fri, 16 May 2014 11:54:44 +0100, Grant Likely grant.lik...@linaro.org wrote: On Thu, 15 May 2014 19:51:17 -0700, Frank Rowand frowand.l...@gmail.com wrote: On 5/13/2014 7:58 AM, Grant Likely wrote: Make of_find_node_by_path() handle aliases

Re: [PATCH 2/3] of: Make of_find_node_by_path() handle /aliases

2014-05-20 Thread Frank Rowand
On 5/20/2014 7:41 PM, Frank Rowand wrote: snip I will reply to this email with an additional patch that restores the original behavior. snip From: Frank Rowand frank.row...@sonymobile.com If __of_find_node_by_path() returns parent when the remaining portion of the path

Re: [PATCH 2/3] of: Make of_find_node_by_path() handle /aliases

2014-05-20 Thread Frank Rowand
is below. From: Frank Rowand frank.row...@sonymobile.com Do not apply this patch -- it is not a valid fix. The point of this patch is to confirm the cause of a bug. Problem seen on 3.15-rc1 with dragonboard platform patches added. The dragonboard hangs on boot the very first time

Re: [PATCH 2/3] of: Make of_find_node_by_path() handle /aliases

2014-05-21 Thread Frank Rowand
On 5/21/2014 9:09 AM, Grant Likely wrote: On Tue, 20 May 2014 19:55:45 -0700, Frank Rowand frowand.l...@gmail.com wrote: On 5/13/2014 7:58 AM, Grant Likely wrote: Make of_find_node_by_path() handle aliases as prefixes. To make this snip --- drivers/of/base.c | 60

Re: [PATCH 2/3] of: Make of_find_node_by_path() handle /aliases

2014-05-22 Thread Frank Rowand
On 5/21/2014 8:13 PM, Grant Likely wrote: On Tue, 20 May 2014 19:46:19 -0700, Frank Rowand frowand.l...@gmail.com wrote: On 5/20/2014 7:41 PM, Frank Rowand wrote: snip I will reply to this email with an additional patch that restores the original behavior. snip From: Frank Rowand

Re: [PATCH 2/3] of: Make of_find_node_by_path() handle /aliases

2014-05-22 Thread Frank Rowand
On 5/21/2014 6:16 PM, Grant Likely wrote: On Tue, 20 May 2014 19:41:22 -0700, Frank Rowand frowand.l...@gmail.com wrote: On 5/18/2014 2:27 AM, Grant Likely wrote: On Fri, 16 May 2014 11:54:44 +0100, Grant Likely grant.lik...@linaro.org wrote: On Thu, 15 May 2014 19:51:17 -0700, Frank

Re: [PATCH 1/3] lib: add glibc style strchrnul() variant

2014-05-15 Thread Frank Rowand
On 5/13/2014 7:58 AM, Grant Likely wrote: The strchrnul() variant helpfully returns a the end of the string instead of a NULL if the requested character is not found. This can simplify string parsing code since it doesn't need to expicitly check for a NULL return. If a valid string pointer is

Re: [PATCH 2/3] of: Make of_find_node_by_path() handle /aliases

2014-05-15 Thread Frank Rowand
On 5/13/2014 7:58 AM, Grant Likely wrote: Make of_find_node_by_path() handle aliases as prefixes. To make this work the name search is refactored to search by path component instead of by full string. This should be a more efficient search, and it makes it possible to start a search at a

Re: [PATCH 1/3] mfd: devicetree: bindings: Add Qualcomm RPM DT binding

2014-05-29 Thread Frank Rowand
On 5/29/2014 11:24 AM, Bjorn Andersson wrote: On Wed, May 28, 2014 at 9:34 AM, Kumar Gala ga...@codeaurora.org wrote: On May 27, 2014, at 12:28 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: Add binding for the Qualcomm Resource Power Manager (RPM) found in 8660, 8960 and 8064

Re: [PATCH 2/4] of/platform: return error on of_platform_device_create_pdata failure

2014-05-13 Thread Frank Rowand
, and that will make of_platform_populate terminate the loop. Be tolerant of that particlar error return value instead. Fixes: 52c75b64a374 ('of/platform: return error on of_platform_device_create_pdata failure') Cc: Frank Rowand frank.row...@sonymobile.com Signed-off-by: Olof Johansson o...@lixom.net

Re: [RFC PATCH] OF: fix of_find_node_by_path() assumption that of_allnodes is root

2014-06-14 Thread Frank Rowand
On 6/14/2014 8:00 AM, Grant Likely wrote: On Fri, Jun 13, 2014 at 4:06 PM, Grant Likely grant.lik...@linaro.org wrote: On Fri, Jun 13, 2014 at 2:52 PM, Rob Herring robherri...@gmail.com wrote: On Fri, Jun 13, 2014 at 12:53 AM, Frank Rowand frowand.l...@gmail.com wrote: From: Frank Rowand

Re: [RFC PATCH] OF: fix of_find_node_by_path() assumption that of_allnodes is root

2014-06-14 Thread Frank Rowand
From: Frank Rowand frank.row...@sonymobile.com of_find_node_by_path() is borked because of_allnodes is not guaranteed to contain the root of the tree after using any of the dynamic update functions because some other nodes ends up as of_allnodes. Fixes: c22e650e66b8 of: Make of_find_node_by_path

Re: [RFC PATCH] OF: fix of_find_node_by_path() assumption that of_allnodes is root

2014-06-14 Thread Frank Rowand
On 6/14/2014 8:39 PM, Frank Rowand wrote: From: Frank Rowand frank.row...@sonymobile.com of_find_node_by_path() is borked because of_allnodes is not guaranteed to contain the root of the tree after using any of the dynamic update functions because some other nodes ends up as of_allnodes

Re: [PATCH] sysfs, device-tree: aid for debugging device tree boot problems

2014-04-23 Thread Frank Rowand
On 4/22/2014 8:20 PM, Greg Kroah-Hartman wrote: On Tue, Apr 22, 2014 at 06:25:25PM -0700, Frank Rowand wrote: Create some infrastructure to aid trouble shooting device tree related boot issues. Add a %driver_name file to each device tree node sysfs directory which has had a driver bound

Re: [PATCH] sysfs, device-tree: aid for debugging device tree boot problems

2014-04-23 Thread Frank Rowand
On 4/23/2014 4:54 AM, Grant Likely wrote: On Tue, 22 Apr 2014 20:20:44 -0700, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Apr 22, 2014 at 06:25:25PM -0700, Frank Rowand wrote: Create some infrastructure to aid trouble shooting device tree related boot issues. Add

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-25 Thread Frank Rowand
On 4/23/2014 6:19 AM, Ivan T. Ivanov wrote: Hi, On Tue, 2014-04-22 at 17:31 -0700, Courtney Cavin wrote: From: Josh Cartwright jo...@codeaurora.org The Qualcomm 8941 and 8841 PMICs are components used with the Snapdragon 800 series SoC family. This driver exists largely as a glue mfd

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-25 Thread Frank Rowand
On 4/25/2014 5:40 PM, Courtney Cavin wrote: On Sat, Apr 26, 2014 at 02:28:06AM +0200, Frank Rowand wrote: On 4/23/2014 6:19 AM, Ivan T. Ivanov wrote: [...] +static int pm8x41_probe(struct spmi_device *sdev) +{ + struct regmap *regmap; + + regmap = devm_regmap_init_spmi_ext(sdev

[PATCH] sysfs, device-tree: aid for debugging device tree boot problems

2014-04-22 Thread Frank Rowand
with a bound driver: # output is: driver_name node_full_path # cd /proc/device-tree for k in `find . -name %driver_name` ; do echo `cat ${k}` `echo ${k} | sed -e 's|./||' -e 's|/%driver_name$||'` done | sort Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- Documentation/ABI

[DRIVER CORE] drivers/base/dd.c incorrect pr_debug() parameters

2014-04-16 Thread Frank Rowand
pr_debug() parameters are reverse order of format string Signed-off-by: Frank Rowand frank.row...@sonymobile.com --- drivers/base/dd.c |4 2 + 2 - 0 ! 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/base/dd.c

Re: [DRIVER CORE] drivers/base/dd.c incorrect pr_debug() parameters

2014-04-16 Thread Frank Rowand
On 4/16/2014 5:48 PM, Joe Perches wrote: On Wed, 2014-04-16 at 17:12 -0700, Frank Rowand wrote: pr_debug() parameters are reverse order of format string Another way to do this might be to change all the printks/pr_debugs to dev_level Yes, but if that is done, one may as well do all

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

2014-02-06 Thread Frank Rowand
On 1/15/2014 10:47 AM, Stephen Boyd wrote: The first breaks a reset-controller include ordering requirement. It got an ack so I think we're ok for it to go through the clock tree. snip checkpatch is whining about patches 4 5 6 7 8 (Just for completeness if someone thinks I did

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

2014-02-06 Thread Frank Rowand
On 2/6/2014 8:15 PM, Frank Rowand wrote: On 1/15/2014 10:47 AM, Stephen Boyd wrote: The first breaks a reset-controller include ordering requirement. It got an ack so I think we're ok for it to go through the clock tree. snip checkpatch is whining about patches snip Never mind

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

2014-02-07 Thread Frank Rowand
On 2/6/2014 9:11 PM, Joe Perches wrote: On Thu, 2014-02-06 at 20:15 -0800, Frank Rowand wrote: On 1/15/2014 10:47 AM, Stephen Boyd wrote: The first breaks a reset-controller include ordering requirement. It got an ack so I think we're ok for it to go through the clock tree. snip

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

2014-02-07 Thread Frank Rowand
On 2/7/2014 12:51 PM, Joe Perches wrote: On Fri, 2014-02-07 at 11:38 -0800, Frank Rowand wrote: On 2/6/2014 9:11 PM, Joe Perches wrote: For patch 1, what checkpatch bug might that be? [] Sorry, it is patch 2, not patch 1 ([PATCH v5 02/14] clk: Add set_rate_and_parent() op): WARNING

Re: [PATCH to be tested] serial: msm_serial: add missing sysrq handling

2014-08-13 Thread Frank Rowand
On 8/12/2014 5:23 PM, Stephen Boyd wrote: On 08/06/14 17:16, Frank Rowand wrote: Stephen, Can you test this patch on v 1.3 hardware? It works on my v 1.4. If you use kdmx2, the way to send a break is '~B'. The previous key pressed must be enter for the '~' escape to be recognized

Re: [PATCH to be tested] serial: msm_serial: add missing sysrq handling

2014-08-13 Thread Frank Rowand
On 8/13/2014 7:33 PM, Frank Rowand wrote: On 8/12/2014 5:23 PM, Stephen Boyd wrote: On 08/06/14 17:16, Frank Rowand wrote: snip The patches you sent are a little hard to read since they modify further code that my patch modified. So I have redone your patches, as if my patch

Re: [PATCH to be tested] serial: msm_serial: add missing sysrq handling

2014-08-13 Thread Frank Rowand
On 8/13/2014 7:33 PM, Frank Rowand wrote: On 8/12/2014 5:23 PM, Stephen Boyd wrote: On 08/06/14 17:16, Frank Rowand wrote: snip The patches you sent are a little hard to read since they modify further code that my patch modified. So I have redone your patches, as if my patch

  1   2   3   4   5   6   7   >