On 04/04/2013 07:41 PM, Tony Lindgren wrote:
* Roger Quadros [130404 00:39]:
On 04/04/2013 02:42 AM, Tony Lindgren wrote:
--- a/arch/arm/mach-omap2/cclock44xx_data.c
+++ b/arch/arm/mach-omap2/cclock44xx_data.c
@@ -27,6 +27,7 @@
#include
#include
#include
+#include
#include "soc.
ntime_suspend() and
serial_omap_runtime_resume().
Hence, fix it by allowing PM runtime only after all its parameters are
configured.
CC: Tony Lindgren
CC: Rajendra Nayak
CC: Felipe Balbi
CC: Kevin Hilman
Signed-off-by: Grygorii Strashko
---
tested on OMAP4 SDP with and without earlyprintk enabl
lists/arm-kernel/msg256828.html
[2] http://www.spinics.net/lists/arm-kernel/msg258062.html
[3] http://www.spinics.net/lists/arm-kernel/msg258040.html
CC: Tony Lindgren
CC: Rajendra Nayak
CC: Felipe Balbi
CC: Kevin Hilman
Signed-off-by: Grygorii Strashko
---
tested on OMAP4 SDP with and without
Hi Linus,
On 07/10/2013 11:36 PM, Linus Walleij wrote:
On Thu, Jun 27, 2013 at 4:01 PM, Grygorii Strashko
wrote:
I think, In the future the OMAP pinctrl configurations would be manged in
more flexible way then now (thanks to "pinctrl PM helpers" and you;))
- "Idle" state
On 04/15/2013 07:40 PM, Mark Brown wrote:
On Mon, Apr 15, 2013 at 07:21:25PM +0300, Andrii Tseglytskyi wrote:
On 04/15/2013 06:50 PM, Mark Brown wrote:
In addition, such locking scheme allows to have access to the supplier
regulator API from inside child's (consumer) regulator API.
I've still
On 04/18/2013 10:17 PM, Sourav Poddar wrote:
Hi Kevin,
On Thursday 18 April 2013 11:53 PM, Kevin Hilman wrote:
Hi Sourav,
Sourav Poddar writes:
Hi,
This patch series contains fixes and cleanups around the issue that
the console UART should not idled on suspend while using
"no_console_suspe
On 04/22/2013 04:43 PM, Sourav Poddar wrote:
Remove the "OMAP_DEVICE_NO_IDLE_ON_SUSPEND" check, since
driver should be able to prevent idling of an omap device
whenever required.
Cc: Santosh Shilimkar
Cc: Felipe Balbi
Cc: Rajendra nayak
Cc: Grygorii Strashko
Signed-off-by: Sou
On 04/22/2013 04:43 PM, Sourav Poddar wrote:
The driver manages "no_console_suspend" by preventing runtime PM
during the suspend path, which forces the console UART to stay awake.
Signed-off-by: Sourav Poddar
---
drivers/tty/serial/omap-serial.c |5 -
1 files changed, 4 insertions(+)
On 04/23/2013 08:19 AM, Sourav Poddar wrote:
Hi Kevin,
On Tuesday 23 April 2013 12:11 AM, Kevin Hilman wrote:
Grygorii Strashko writes:
On 04/22/2013 04:43 PM, Sourav Poddar wrote:
Remove the "OMAP_DEVICE_NO_IDLE_ON_SUSPEND" check, since
driver should be able to prevent idling
nit layer
instead of subsys init layer where initialization dependencies resolved
indirectly in drivers/Makefile now.
Grygorii Strashko (2):
i2c: omap: convert to module_platform_driver()
mfd: twl-core: convert to module_i2c_driver()
drivers/i2c/busses/i2c-omap.c | 14 +-
dr
linux-kernel@vger.kernel.org
Signed-off-by: Grygorii Strashko
---
drivers/mfd/twl-core.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index 4f3baad..f01340d 100644
--- a/drivers/mfd/twl-core.c
+++ b/drivers/m
<-->
pinctrl-single dependency is resolved in drivers/Makefile now.
Cc: Wolfram Sang
Cc: "Ben Dooks (embedded platforms)"
Cc: Santosh Shilimkar
Cc: linux-o...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Grygorii Strashko
---
driver
Hi Kevin,
On 06/01/2013 01:37 AM, Kevin Hilman wrote:
Currently, the RTC IRQ is never wakeup-enabled so is not capable of
bringing the system out of suspend.
On OMAP platforms, we have gotten by without this because the TWL RTC
is on an I2C-connected chip which is capable of waking up the OMAP
Hi Kevin,
On 06/03/2013 11:59 PM, Kevin Hilman wrote:
Grygorii Strashko writes:
The OMAP I2C driver has a relation to pinctrl-single driver. As result,
its probe will be deferred during system boot until late init time,
because the pinctrl-single is initizalized as moudle/device init time
Hi Kevin, Gururaja
On 05/31/2013 08:34 PM, Kevin Hilman wrote:
Hebbar Gururaja writes:
Amend the I2C omap pin controller to optionally take a pin control
handle and set the state of the pins to:
- "default" on boot, resume and before performing an i2c transfer
- "idle" after initial default,
(usually for embedded systems).
CC: linux-...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-o...@vger.kernel.org
Signed-off-by: Grygorii Strashko
---
drivers/i2c/Kconfig| 10 ++
drivers/i2c/i2c-core.c |6 ++
2 files changed, 16 insertions(+)
diff --git a/dri
Signed-off-by: Grygorii Strashko
---
drivers/rtc/rtc-twl.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
index bbda0fd..1698115 100644
--- a/drivers/rtc/rtc-twl.c
+++ b/drivers/rtc/rtc-twl.c
@@ -481,6 +481,11 @@
Pls, ignore this patch. It duplicates:
https://patchwork.kernel.org/patch/2448251/ - [v2,1/2] RTC: rtc-twl: Fix
rtc_reg_map initialization
from Peter Ujfalusi
On 06/05/2013 02:19 PM, Grygorii Strashko wrote:
The twl-rtc has the following dependencies from other drivers during the boot
On 06/04/2013 09:29 PM, Kevin Hilman wrote:
Grygorii Strashko writes:
Hi Kevin,
On 06/03/2013 11:59 PM, Kevin Hilman wrote:
Grygorii Strashko writes:
The OMAP I2C driver has a relation to pinctrl-single driver. As result,
its probe will be deferred during system boot until late init time
Hi Peter,
Tested on OMAP4460 SDP - see no issues during boot.
-grygorii
On 04/16/2013 11:30 AM, Peter Ujfalusi wrote:
Initialize the rtc_reg_map in platform_driver's probe function instead at
module_init time. This way we can make sure that the twl-core has been already
probed and initialized
On 06/04/2013 08:46 PM, Kevin Hilman wrote:
Grygorii Strashko writes:
Hi Kevin,
On 06/01/2013 01:37 AM, Kevin Hilman wrote:
Currently, the RTC IRQ is never wakeup-enabled so is not capable of
bringing the system out of suspend.
On OMAP platforms, we have gotten by without this because the
Hi
On 06/04/2013 08:49 PM, Wolfram Sang wrote:
On Tue, Jun 04, 2013 at 08:33:42PM +0300, Grygorii Strashko wrote:
Currently the I2C devices instantiation Method 3 "Probe an I2C bus for
certain devices" (see Documentation/i2c/instantiating-devices) is always
enabled for all platfor
On 06/05/2013 04:50 PM, Wolfram Sang wrote:
The similar patch already exists:
https://patchwork.kernel.org/patch/2448251/ - [v2,1/2] RTC: rtc-twl:
Fix rtc_reg_map initialization
from Peter Ujfalusi
So, I think it is best if you resend this patch after all the fixes it
needs are applied or you re
Hi Wolfram,
On 06/07/2013 12:06 PM, Wolfram Sang wrote:
3) Thinking about Mainline: To reach the same target - no I2C
detection - and taking
into account above assumption "No changes in default behavior"
the following will need to be done:
- change i2c-omap/i2c-gpio DT bindings and add parameter
Hi Wolfram,
On 06/19/2013 01:15 PM, Wolfram Sang wrote:
On Fri, Jun 07, 2013 at 11:09:26AM +0200, Wolfram Sang wrote:
Class based instantiation can cause huge delays when booting. This
mechanism was used when it was not possible to describe slaves on I2C
busses. We now have other mechanisms, so
On 06/07/2013 12:09 PM, Wolfram Sang wrote:
Class based instantiation can cause huge delays when booting. This
mechanism was used when it was not possible to describe slaves on I2C
busses. We now have other mechanisms, so most embedded I2C will not need
classes and it was explicitly not recommend
d I2C, so disable it by
leaving I2C adapter "class" field undefined (remove I2C_CLASS_HWMON and
I2C_CLASS_SPD) and add a deprecation warning to allow users, relying on this
mechanism, to switch to something better.
CC: Haavard Skinnemoen
Signed-off-by: Grygorii Strashko
---
drivers
ass" field undefined (remove I2C_CLASS_HWMON).
CC: Tony Lindgren
Signed-off-by: Grygorii Strashko
---
drivers/i2c/busses/i2c-omap.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index f06109f..ae2b27f 10064
On 06/07/2013 11:51 PM, Kevin Hilman wrote:
Grygorii Strashko writes:
From: Kevin Hilman
Currently, runtime PM is used to keep the device enabled only during
active transfers and for a configurable runtime PM autosuspend timout
after an xfer.
In addition to idling the device, driver&#
Hi Felipe,
On 06/07/2013 10:05 PM, Felipe Balbi wrote:
Hi,
On Fri, Jun 07, 2013 at 09:46:06PM +0300, Grygorii Strashko wrote:
ARDY|NACK and ARDY|AL are set together in OMAP_I2C_STAT_REG, which will be
Have you seen that happen ever ? AL is Arbitration Lost, we never put
OMAP in a multi-master
Hi Felipe,
On 06/07/2013 10:02 PM, Felipe Balbi wrote:
Hi,
On Fri, Jun 07, 2013 at 09:46:05PM +0300, Grygorii Strashko wrote:
Add runtime check at the beginning of omap_i2c_isr/omap_i2c_isr_thread
to be sure that i2c is enabled, before performing IRQ handling and accessing
I2C IP registers
Hi Felipe,
On 06/07/2013 10:07 PM, Felipe Balbi wrote:
Hi,
On Fri, Jun 07, 2013 at 09:46:08PM +0300, Grygorii Strashko wrote:
The omap_i2c_isr() does the irq check and schedules threaded handler if any of
enabled IRQs is active, but currently the I2C IRQs are enabled just once,
when I2C IP is
On 05/31/2013 01:13 PM, Hebbar Gururaja wrote:
Amend the I2C omap pin controller to optionally take a pin control
handle and set the state of the pins to:
- "default" on boot, resume and before performing an i2c transfer
- "idle" after initial default, after resume default, and after each
i2c xf
: use pinctrl PM helpers
https://patchwork.kernel.org/patch/2670291/
- mmc: omap_hsmmc: Remux pins to support SDIO interrupt and PM runtime
https://patchwork.kernel.org/patch/2690191/
- [PATCH 00/11] drivers: Add Pinctrl PM support
https://lkml.org/lkml/2013/5/31/210
CC: Hebbar Gururaja
CC: Linus Wall
ule/device layer where the i2c <-->
pinctrl-single dependency is resolved in drivers/Makefile now.
Signed-off-by: Grygorii Strashko
---
Hi Wolfram,
The prerequsite patch https://lkml.org/lkml/2013/6/6/98 has been merged
in linux-next, so re-send
11c506d drivers/rtc/rtc-twl.c:
se STP isn't generated.
Patch "i2c: omap: query STP always when NACK is received:" fixes this issue.
This patch series based on top of:
http://patchwork.ozlabs.org/patch/248188/
Grygorii Strashko (4):
i2c: omap: add runtime check in isr to be sure that i2c is enabled
i2c:
se STP isn't generated.
Patch "i2c: omap: query STP always when NACK is received:" fixes this issue.
This patch series based on top of:
http://patchwork.ozlabs.org/patch/248188/
Grygorii Strashko (4):
i2c: omap: add runtime check in isr to be sure that i2c is enabled
i2c:
behavior which was changed by commit:
1d7afc95946487945cc7f5019b41255b72224b70 "i2c: omap: ack IRQ in parts".
CC: Kevin Hilman
Signed-off-by: Grygorii Strashko
---
drivers/i2c/busses/i2c-omap.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/
K has been received
during the last message transmitting/recieving.
This may lead to stuck Bus in "Bus Busy" until I2C IP reset (idle/enable).
Hence, fix it by querying Stop condition (STP) always when NACK is received.
CC: Kevin Hilman
CC: Felipe Balbi
Signed-off-by: Grygorii Strash
C: Kevin Hilman
Signed-off-by: Grygorii Strashko
---
This is clean-up patch.
drivers/i2c/busses/i2c-omap.c | 33 +
1 file changed, 1 insertion(+), 32 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index b3daf3f..749f390 1006
return IRQ_NONE;
}
Produce warning in case if ISR called when i2c is disabled
CC: Kevin Hilman
Signed-off-by: Grygorii Strashko
---
drivers/i2c/busses/i2c-omap.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/buss
untime_suspend() |
|-omap_i2c_isr_thread()
|- oops is here - I2C module is in
idle state
Cc: Nishanth Menon
Signed-off-by: Kevin Hilman
Signed-off-by: Grygorii Strashko
---
drivers/i2c/busses/i2c-omap.c |4
1 file changed, 4 insertions(+)
diff --git a/driv
Hi All,
On 06/25/2013 09:58 AM, Tony Lindgren wrote:
* Linus Walleij [130624 05:13]:
On Fri, Jun 21, 2013 at 5:03 PM, Grygorii Strashko
wrote:
Hence, add pinctrl handling in omap_device core:
1) on PM runtime resume
- switch pinctrl state to "default" (todo: "active&quo
Picture format fixed. Sorry for that.
On 06/26/2013 04:20 PM, Grygorii Strashko wrote:
Hi All,
On 06/25/2013 09:58 AM, Tony Lindgren wrote:
* Linus Walleij [130624 05:13]:
On Fri, Jun 21, 2013 at 5:03 PM, Grygorii Strashko
wrote:
Hence, add pinctrl handling in omap_device core:
1) on PM
Hi Linus,
On 06/26/2013 10:31 PM, Linus Walleij wrote:
On Wed, Jun 26, 2013 at 3:20 PM, Grygorii Strashko
wrote:
The "Sleep" pinctrl state is optional - if "sleep" state isn't defined
then "Idle" pinctrl state will be used during suspend.
Why? If we have
On 06/27/2013 05:45 PM, Tony Lindgren wrote:
* Grygorii Strashko [130627 07:12]:
As you can see, from 12 pins only 3 pins need to be reconfigured
while switching from "active"->"idle" states and back (and as I
mentioned above for OMAP "idle" == "sleep&q
Hi All,
I have a question regarding this patch and IIO in general
- Does IIO provide sync mechanism with system wide suspend/resume or
this should be handled by each driver itself?
What if during system suspend iio_read_channel_raw() (or any other
consumer API) will be called after gpadc driv
Hi Hein, Felipe
On 07/16/2013 12:42 PM, Felipe Balbi wrote:
Hi,
On Tue, Jul 16, 2013 at 05:33:47PM +0800, Hein Tibosch wrote:
On 7/16/2013 5:03 PM, Felipe Balbi wrote:
Hi,
On Tue, Jul 16, 2013 at 04:19:35PM +0800, Hein Tibosch wrote:
Hi Vikram,
On a OMAP4460, i2c-bus-3:
A driver (lm75) is
Hi Felipe,
On 07/16/2013 02:27 PM, Felipe Balbi wrote:
Hi,
On Tue, Jul 16, 2013 at 02:01:11PM +0300, Grygorii Strashko wrote:
On a OMAP4460, i2c-bus-3:
A driver (lm75) is causing many 'timeout waiting for bus ready' errors.
SDA remains high (as it should), but SCL remains low af
Hi Tony,
This patch causes boot failure when I've applied my patch
"[RFC] ARM: OMAP2+: omap_device: add pinctrl handling"
https://lkml.org/lkml/2013/6/21/309
on top of it:
[0.264007] L310 cache controller enabled
[0.268310] l2x0: 16 ways, CACHE_ID 0x41c4, AUX_CTRL 0x7e47,
Cache
Hi Tony,
On 07/16/2013 04:41 PM, Tony Lindgren wrote:
* Grygorii Strashko [130716 06:22]:
Hi Tony,
This patch causes boot failure when I've applied my patch
"[RFC] ARM: OMAP2+: omap_device: add pinctrl handling"
https://lkml.org/lkml/2013/6/21/309
on top of it:
Hmm t
in in pinctrl_pm_select*() APIs.
CC: Linus Walleij
Cc: Stephen Warren
Signed-off-by: Grygorii Strashko
---
Seems this one can be squashed in series
[PATCH 0/4] improved support for runtime muxing for pinctrl"
http://www.spinics.net/lists/arm-kernel/msg258827.html
drivers/pinctrl/core.
s://lkml.org/lkml/2013/6/11/501
- [3/3] i2c: nomadik: use pinctrl PM helpers
https://patchwork.kernel.org/patch/2670291/
- mmc: omap_hsmmc: Remux pins to support SDIO interrupt and PM runtime
https://patchwork.kernel.org/patch/2690191/
- [PATCH 00/11] drivers: Add Pinctrl PM support
https://lkml.org/lkml
Add dynamic "active"/"idle" pin states for uart3/4 which will be applied
when uart3/4 state is switched from active to idle and back by Runtime
PM or during system suspend.
CC: Benoit Cousson
CC: Linus Walleij
CC: Stephen Warren
Signed-off-by: Grygorii Strashko
---
arc
e", "sleep" states).
Related discussions:
- [3/3] i2c: nomadik: use pinctrl PM helpers
https://patchwork.kernel.org/patch/2670291/
- mmc: omap_hsmmc: Remux pins to support SDIO interrupt and PM runtime
https://patchwork.kernel.org/patch/2690191/
- [PATCH 00/11] drivers: Add P
n how to do the muxing for
runtime PM.
I've posted my patch and tested this patch series.
Seems everything is ok (except patch "pinctrl: Remove duplicate code in
pinctrl_pm_select_state functions").
See http://www.spinics.net/lists/arm-kernel/msg259180.html
So, Tested-B
On 07/17/2013 02:57 PM, Roger Quadros wrote:
Hi Grygorii,
On 07/17/2013 02:41 PM, Grygorii Strashko wrote:
Hi Tony, Kevin
This patch series introduces dynamic pinctrl handling in OMAP device framework
in the same way as it was before switching to DT.
This allow OMAP devices driver&#
Hi,
On 07/17/2013 06:32 PM, Tony Lindgren wrote:
* Grygorii Strashko [130717 04:49]:
Add dynamic "active"/"idle" pin states for uart3/4 which will be applied
when uart3/4 state is switched from active to idle and back by Runtime
PM or during system suspend.
This is g
On 07/17/2013 06:38 PM, Tony Lindgren wrote:
* Grygorii Strashko [130717 04:49]:
Before switching to DT pinctrl states of OMAP IPs have been handled by hwmod
framework. After switching to DT-boot the pinctrl handling was dropped from
hwmod framework and, as it was recommended, OMAP IP&#
On 07/18/2013 11:09 AM, Tony Lindgren wrote:
* Grygorii Strashko [130717 09:48]:
Hi,
On 07/17/2013 06:32 PM, Tony Lindgren wrote:
* Grygorii Strashko [130717 04:49]:
Add dynamic "active"/"idle" pin states for uart3/4 which will be applied
when uart3/4 state is switched
On 08/19/2013 03:11 PM, Wolfram Sang wrote:
Hi,
Which means your original patch starts to make a lot more sense. I
wonder is this is really what we should be doing though - breaking out
of the loop, I mean.
Yup, that is fine. I applied the old patch with Acks from Hein and
Felipe to -next. Th
On 08/20/2013 11:18 AM, Samuel Ortiz wrote:
On Tue, Aug 20, 2013 at 08:13:54AM +0100, Graeme Gregory wrote:
On 20/08/13 02:01, Samuel Ortiz wrote:
Hi Grygorii,
On Thu, Jul 25, 2013 at 04:15:46PM +0300, Grygorii Strashko wrote:
This patch series intorduces twl6030-irq module rework to use
On 07/18/2013 11:14 AM, Tony Lindgren wrote:
* Grygorii Strashko [130717 10:11]:
On 07/17/2013 06:38 PM, Tony Lindgren wrote:
* Grygorii Strashko [130717 04:49]:
Before switching to DT pinctrl states of OMAP IPs have been handled by hwmod
framework. After switching to DT-boot the pinctrl
Hi Tony,
On 07/18/2013 12:04 PM, Tony Lindgren wrote:
* Grygorii Strashko [130718 02:01]:
On 07/18/2013 11:09 AM, Tony Lindgren wrote:
Don't think it's debug code - IO chain need to be rearmed after each
PRCM IO IRQ - otherwise IO wakeup events may be lost (at least on
OMAP4, OMAP
Hi Tony, Stephen
On 07/19/2013 10:39 AM, Tony Lindgren wrote:
* Stephen Warren [130718 12:33]:
On 07/18/2013 01:36 AM, Tony Lindgren wrote:
* Stephen Warren [130717 14:30]:
On 07/16/2013 03:05 AM, Tony Lindgren wrote:
...
Why shouldn't e.g. a pinctrl-based I2C mux also be able to do runti
On 07/19/2013 05:39 PM, Sergei Shtylyov wrote:
Hello.
On 19-07-2013 13:27, Oleksandr Kozaruk wrote:
GPADC is the general purpose ADC present on twl6030.
The dt data is interrupt used to trigger end of ADC
conversion.
Signed-off-by: Oleksandr Kozaruk
---
arch/arm/boot/dts/twl6030.dtsi | 6
The device_init_wakeup() should be called before rtc_device_register().
Otherwise, sysfs "sys/class/rtc/rtcX/wakealarm" attribute will not be
seen from User space.
CC: Kevin Hilman
CC: Tony Lindgren
Signed-off-by: Grygorii Strashko
---
drivers/rtc/rtc-twl.c |3 ++-
1 file
OMAP4430/TWL6030 and
OMAP4470/TWL6032.
Grygorii Strashko (2):
mfd: twl6030-irq: add error check when IRQs are masked initially
mfd: twl6030-irq: convert to use linear irq_domain
Naga Venkata Srikanth V (1):
mfd: twl6030-irq: migrate to IRQ threaded handler
Oleksandr Dmytryshyn (1):
mfd
Add a missed check for errors when TWL IRQs are masked
initially on probe and report an error in case of failure.
Signed-off-by: Grygorii Strashko
---
drivers/mfd/twl6030-irq.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/twl6030-irq.c b
From: Oleksandr Dmytryshyn
This patch adds interrupt mapping table for the twl6032.
Signed-off-by: Oleksandr Dmytryshyn
Signed-off-by: Grygorii Strashko
---
drivers/mfd/twl6030-irq.c | 49 -
1 file changed, 48 insertions(+), 1 deletion(-)
diff
irq_domain. So, IRQ mapping and descriptors
allocation will be performed dynamically basing on DT configuration.
The error message will be reported in case if unmapped IRQ is received by
TWL6030 (virq==0).
Signed-off-by: Grygorii Strashko
---
drivers/mfd/twl6030-irq.c | 114
TWL irq.
3) Removed I2C read-retry logic for the case when twl_i2c_read() is
failed inside IRQ handler - there is no sense to do that, so just report
an error and return.
Signed-off-by: Naga Venkata Srikanth V
Signed-off-by: Oleg_Kosheliev
Signed-off-by: Grygorii Strashko
---
drivers/mfd
On 07/23/2013 09:08 PM, Graeme Gregory wrote:
On 23/07/13 17:07, Grygorii Strashko wrote:
Add a missed check for errors when TWL IRQs are masked
initially on probe and report an error in case of failure.
Signed-off-by: Grygorii Strashko
---
drivers/mfd/twl6030-irq.c | 13 +
1
On 07/24/2013 01:49 PM, Lee Jones wrote:
On Tue, 23 Jul 2013, Grygorii Strashko wrote:
From: Naga Venkata Srikanth V
1) Removed request_irq() and replaced it with request_threaded_irq().
2) Removed generic_handle_irq() and replaced it with
handle_nested_irq().
Handling of these
On 07/24/2013 03:50 PM, Lee Jones wrote:
+ if (ret) {
+ pr_warn("%s: I2C error %d reading PIH ISR\n", __func__, ret);
Does the user really care which function we're returning from.
Would it be better if you replace '__func__' with the device name?
This module hasn't been
On 07/24/2013 02:52 PM, Lee Jones wrote:
On Tue, 23 Jul 2013, Grygorii Strashko wrote:
From: Oleksandr Dmytryshyn
This patch adds interrupt mapping table for the twl6032.
Repeating the $SUBJECT line is never helpful.
Signed-off-by: Oleksandr Dmytryshyn
Signed-off-by: Grygorii Strashko
On 07/24/2013 02:35 PM, Lee Jones wrote:
On Tue, 23 Jul 2013, Grygorii Strashko wrote:
Since the TWL6030 PMIC is used with OMAP4 SoCs only and OMAP4 legacy
boot is dropped there are no needs to allocate the range of IRQ
descriptors during system boot to support TWL6030 IRQs.
Hence, convert it
ot;mfd: twl6030-irq: convert to use linear irq_domain":
The irq_find_mapping() is used in twl6030_mmc_card_detect_config()
to get virtual IRQ number.
Based on v3.11-rc1
Tested generation of RTC_ALARM(3) and PWRON(0) IRQs on OMAP4430/TWL6030 and
OMAP4470/TWL6032.
Grygorii Strashko (3):
mfd
From: Oleksandr Dmytryshyn
The TWL6032 PMIC has different IRQ status bits meaning.
Hence, add interrupt mapping table for the twl6032.
Signed-off-by: Oleksandr Dmytryshyn
Signed-off-by: Grygorii Strashko
---
drivers/mfd/twl6030-irq.c | 48 -
1
irq_domain. So, IRQ mapping and descriptors
allocation will be performed dynamically basing on DT configuration.
The error message will be reported in case if unmapped IRQ is received by
TWL6030 (virq==0).
Signed-off-by: Grygorii Strashko
---
drivers/mfd/twl6030-irq.c | 119
Create "struct twl6030_irq" and place all local variables inside it.
Also allocate twl6030_irq structure dynamically during initialization.
Signed-off-by: Grygorii Strashko
---
drivers/mfd/twl6030-irq.c | 101 ++---
1 file changed, 59 inserti
as IRQS_PENDING.
Signed-off-by: Naga Venkata Srikanth V
Signed-off-by: Oleg_Kosheliev
Signed-off-by: Grygorii Strashko
---
drivers/mfd/twl6030-irq.c | 150 +++--
1 file changed, 50 insertions(+), 100 deletions(-)
diff --git a/drivers/mfd/twl6030-irq.c b
Add a missed check for errors when TWL IRQs are masked
initially on probe and report an error in case of failure.
Signed-off-by: Grygorii Strashko
---
Hi Graeme,
I've tried to use only one write to STS_A register to clear IRQ status bits,
but,
unfortunatelly, It is *not* working. Seems
On 04/23/2013 08:34 PM, Tony Lindgren wrote:
* Grygorii Strashko [130423 06:25]:
Hi
There are two public discussions now related to OMAP boot and drivers
initialization issues:
"Multiple issues with omap4 panda es in linux next"
http://www.spinics.net/lists/linux-omap/msg90241.
egy introduced here is simple: an clock node described in
typo: "an"->"a"
device tree blob is used to identify the exact clock provided in the SoC
specific data. This is then linked back using of_clk_add_provider to the
device node to be accessible by of_clk_get.
B
l/2013/2/27/414
Tested on K3.8 OMAP4 SDP/T2 (ABB+vcvp regulator) and
OMAP5 sevm (ABB+smps123(i2c) regulator):
- cpu freq & voltages was scaled.
Could you please review and advise? Does anyone else interested in or have
similar problems?
Grygorii Strashko (1):
regulator: core: introduce
.kernel.org
Cc: Mike Turquette
Cc: Nishanth Menon
Cc: Tero Kristo
Cc: linux-omap
Cc: linux-arm
Signed-off-by: Grygorii Strashko
---
drivers/regulator/core.c | 134 --
include/linux/regulator/driver.h |2 +
2 files changed, 88 insertions(+)
On 05/17/2013 01:58 AM, Tony Lindgren wrote:
* Samuel Ortiz [130516 15:22]:
Hi Grygorii,
On Tue, Apr 23, 2013 at 04:19:10PM +0300, Grygorii Strashko wrote:
Shift TWL initialization to module/device init layer, because I2C now is
not initialized on subsys init layer and shifted to module
next insmod
- need to use of_platform_depopulate() in cpsw_remove().
Grygorii Strashko (3):
net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()
drivers: net: cpsw: fix wrong regs access in cpsw_remove
drivers: net: cpsw: use of_platform_depopulate()
drivers/net/ethernet/ti/cpsw.c
deinitialization actions which require CPSW registers access. In case
of PM runtime error just leave cpsw_remove() as we can't do anything
anymore.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --
up of
OF_POPULATED flag.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index a4d6eb5..ca5890f 100644
--- a/drivers/net/ethernet/ti
spin_lock_irqsave(&ctlr->lock, flags); <- deadlock
The issue has not been observed before because CPDMA channels have
been destroyed manually by CPSW until commit d941ebe88a41 ("net:
ethernet: ti: cpsw: use destroy ctlr to destroy channels") was merged.
Signed-off-by: Grygorii S
On 07/26/2016 11:54 PM, ivan.khoronzhuk wrote:
>
>
> On 26.07.16 19:02, Grygorii Strashko wrote:
>> On 07/23/2016 09:24 AM, Ivan Khoronzhuk wrote:
>>>
>>>
>>> On 22.07.16 16:58, Grygorii Strashko wrote:
>>>> Fix deadlock in cpdma_ctlr_destro
next insmod
- need to use of_platform_depopulate() in cpsw_remove().
4) rmmod: system crash on omap_device removal
Tested on: am437x-idk, am57xx-beagle-x15
Changes in v2:
- build warning fixed
- added fix for correct omap_device removal
Link on v1:
https://lkml.org/lkml/2016/7/22/240
Grygorii
up of
OF_POPULATED flag.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index ec6f473..f0ed470 100644
--- a/drivers/net/ethernet/ti
deinitialization actions which require CPSW registers access. In case
of PM runtime error just leave cpsw_remove() as we can't do anything
anymore.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --
ve(&ctlr->lock, flags);
The issue has not been observed before because CPDMA channels have
been destroyed manually by CPSW until commit d941ebe88a41 ("net:
ethernet: ti: cpsw: use destroy ctlr to destroy channels") was merged.
Signed-off-by: Grygorii Strashko
---
drivers/net/
4/0x20c)
[] (SyS_delete_module) from [] (ret_fast_syscall+0x0/0x1c)
Code: e350 e92d4070 1590630c 01a06000 (e5d6300d)
Hence, fix it by using BUS_NOTIFY_REMOVED_DEVICE event for OMAP device
deletion which is sent when DD has finished processing of device
deletion.
Cc: Tony Lindgren
Cc: Tero K
On 07/29/2016 08:15 AM, Peter Ujfalusi wrote:
On 07/28/16 20:50, Grygorii Strashko wrote:
Below call chain causes system crash when OMAP device is
removed by calling of_platform_depopulate()/device_del():
Should you swap 3 <-> 4 in the series?
Currently patch 3 will introduce the cra
On 09/08/2016 02:00 PM, Felipe Balbi wrote:
>
> Hi,
>
> Arnd Bergmann writes:
>> On Thursday, September 8, 2016 12:43:06 PM CEST Felipe Balbi wrote:
>>> Arnd Bergmann writes:
On Thursday, September 8, 2016 11:29:04 AM CEST Felipe Balbi wrote:
>> If we do that, we have to put child devi
1 - 100 of 1629 matches
Mail list logo
