Re: [PATCH v2] clk: Add fractional scale clock support

2016-07-20 Thread Hoan Tran
On Fri, Jul 1, 2016 at 5:09 PM, Hoan Tran wrote: > > Hi Stephen, > > On Fri, Jul 1, 2016 at 11:38 AM, Stephen Boyd wrote: > > Sorry I replied offlist before. Pressed the wrong key. > > > > On 06/30, Hoan Tran wrote: > >> On Thu, Jun 30, 2016 at 1:23 PM, St

[PATCH v3 0/3] hwmon: xgene: Add support for X-Gene hwmon driver

2016-07-21 Thread Hoan Tran
Fix review comments from Guenter v1 - Initial Hoan Tran (3): Documentation: dtb: xgene: Add hwmon dts binding documentation hwmon: xgene: Add hwmon driver arm64: dts: apm: Add X-Gene SoC hwmon to device tree .../devicetree/bindings/hwmon/apm-xgene-hwmon.txt | 14 + Documentation/hw

[PATCH v3 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation

2016-07-21 Thread Hoan Tran
This patch adds the APM X-Gene hwmon device tree node documentation. Signed-off-by: Hoan Tran Acked-by: Rob Herring --- .../devicetree/bindings/hwmon/apm-xgene-hwmon.txt | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon

[PATCH v3 3/3] arm64: dts: apm: Add X-Gene SoC hwmon to device tree

2016-07-21 Thread Hoan Tran
This patch adds DT node to enable hwmon driver for APM X-Gene SoC. Signed-off-by: Hoan Tran --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 5 + arch/arm64/boot/dts/apm/apm-storm.dtsi | 5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi

[PATCH v3 2/3] hwmon: xgene: Add hwmon driver

2016-07-21 Thread Hoan Tran
This patch adds hardware temperature and power reading support for APM X-Gene SoC using the mailbox communication interface. Signed-off-by: Hoan Tran --- Documentation/hwmon/xgene-hwmon | 30 ++ drivers/hwmon/Kconfig | 7 + drivers/hwmon/Makefile | 1 + drivers/hwmon

[PATCH] ACPI: CPPC: Support PCC with interrupt flag

2016-07-21 Thread Hoan Tran
For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone() function to notify the mailbox framework about TX completion. Signed-off-by: Hoan Tran --- This patch is tested on top and depends on patch[1]: [1] http://www.spinics.net/lists/linux-acpi/msg66041.html - [PATCH v3] mailbox

Re: [PATCH v3 2/3] hwmon: xgene: Add hwmon driver

2016-07-21 Thread Hoan Tran
Hi Guenter, On Thu, Jul 21, 2016 at 3:09 PM, Guenter Roeck wrote: > On Thu, Jul 21, 2016 at 01:55:56PM -0700, Hoan Tran wrote: >> This patch adds hardware temperature and power reading support for >> APM X-Gene SoC using the mailbox communication interface. >> >&g

[PATCH v4 0/3] hwmon: xgene: Add support for X-Gene hwmon driver

2016-07-21 Thread Hoan Tran
for milli-Watt) - Remove power reading for SoC - Fix review comments from Guenter v1 - Initial Hoan Tran (3): Documentation: dtb: xgene: Add hwmon dts binding documentation hwmon: xgene: Add hwmon driver arm64: dts: apm: Add X-Gene SoC hwmon to device tree .../devicetree/bindings/hwmon/

[PATCH v4 3/3] arm64: dts: apm: Add X-Gene SoC hwmon to device tree

2016-07-21 Thread Hoan Tran
This patch adds DT node to enable hwmon driver for APM X-Gene SoC. Signed-off-by: Hoan Tran Acked-by: Guenter Roeck --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 5 + arch/arm64/boot/dts/apm/apm-storm.dtsi | 5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm64/boot

[PATCH v4 2/3] hwmon: xgene: Add hwmon driver

2016-07-21 Thread Hoan Tran
This patch adds hardware temperature and power reading support for APM X-Gene SoC using the mailbox communication interface. Signed-off-by: Hoan Tran Reviewed-by: Guenter Roeck --- Documentation/hwmon/xgene-hwmon | 30 ++ drivers/hwmon/Kconfig | 7 + drivers/hwmon/Makefile

[PATCH v4 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation

2016-07-21 Thread Hoan Tran
This patch adds the APM X-Gene hwmon device tree node documentation. Signed-off-by: Hoan Tran Acked-by: Rob Herring --- .../devicetree/bindings/hwmon/apm-xgene-hwmon.txt | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon

Re: [PATCH v4 0/3] hwmon: xgene: Add support for X-Gene hwmon driver

2016-07-22 Thread Hoan Tran
Hi Guenter, On Thu, Jul 21, 2016 at 6:30 PM, Guenter Roeck wrote: > On 07/21/2016 03:37 PM, Hoan Tran wrote: >> >> This patch set adds hardware temperature and power reading support for >> APM X-Gene SoC using the mailbox communication interface. >> For device tree, it

Re: hwmon: xgene: Add support for X-Gene hwmon driver

2016-07-23 Thread Hoan Tran
Hi Itaru, > On Jul 23, 2016, at 16:51, Itaru Kitayama wrote: > > Hi Hoan, > > I've been testing your patch set on a Rev B0 system with ACPI, in dmesg > I see: > > [1.546444] xgene-slimpro-i2c APMC0D40:00: i2c mailbox channel request > failed > [1.570062] xgene-slimpro-hwmon APMC0D29:

[PATCH v2] clk: Add fractional scale clock support

2016-06-20 Thread Hoan Tran
compile error by using DIV_ROUND_UP_ULL() macro * Remove DT binding document * Remove DT clk_fractional_scale_init() function v1 * Initial Signed-off-by: Hoan Tran Signed-off-by: Loc Ho --- drivers/clk/Makefile | 1 + drivers/clk/clk-fractional-scale.c | 195

Re: [PATCH v3 2/3] hwmon: xgene: Add hwmon driver

2016-08-01 Thread Hoan Tran
lp improve the system] > > url: > https://github.com/0day-ci/linux/commits/Hoan-Tran/hwmon-xgene-Add-support-for-X-Gene-hwmon-driver/20160725-015356 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git > hwmon-next > config: arm64-allmodconfig

[PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-06 Thread Hoan Tran
into invalid resource as unmapped PCC shared memory. This patch fixes this issue by saving this alarm message and scheduling a bottom handler after xgene_hwmon_probe() finish. Signed-off-by: Hoan Tran Reported-by: Itaru Kitayama --- drivers/hwmon/xgene-hwmon.c

Re: [PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-06 Thread Hoan Tran
Hi Guenter, Thank for your quick review ! On Tue, Sep 6, 2016 at 9:35 PM, Guenter Roeck wrote: > On 09/06/2016 08:46 PM, Hoan Tran wrote: >> >> The system crashes during probing xgene-hwmon driver when temperature >> alarm interrupt occurs before. >> It's

Re: [PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-06 Thread Hoan Tran
Hi Guenter, On Tue, Sep 6, 2016 at 10:50 PM, Guenter Roeck wrote: > On 09/06/2016 10:21 PM, Hoan Tran wrote: >> >> Hi Guenter, >> >> Thank for your quick review ! >> >> On Tue, Sep 6, 2016 at 9:35 PM, Guenter Roeck wrote: >>> >>> On

Re: [PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-07 Thread Hoan Tran
Hi Guenter, On Tue, Sep 6, 2016 at 11:39 PM, Guenter Roeck wrote: > On 09/06/2016 11:07 PM, Hoan Tran wrote: >> >> Hi Guenter, >> >> On Tue, Sep 6, 2016 at 10:50 PM, Guenter Roeck wrote: >>> >>> On 09/06/2016 10:21 PM, Hoan Tran wrote: >>>

Re: [PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-07 Thread Hoan Tran
Hi Guenter, On Wed, Sep 7, 2016 at 12:24 PM, Guenter Roeck wrote: > On Wed, Sep 07, 2016 at 11:55:06AM -0700, Hoan Tran wrote: >> Hi Guenter, >> >> On Tue, Sep 6, 2016 at 11:39 PM, Guenter Roeck wrote: >> > On 09/06/2016 11:07 PM, Hoan Tran wrote: >> >>

[PATCH v2] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-08 Thread Hoan Tran
valid resourse as unmapped PCC shared memory. This patch fixes this issue by saving this alarm message and scheduling a bottom handler after xgene_hwmon_probe() finish. Signed-off-by: Hoan Tran Reported-by: Itaru Kitayama --- v2 * Check hwmon_dev and resp_pending to determine the driver is not

Re: [PATCH v2] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-08 Thread Hoan Tran
Hi All, Please discard this patch. I'll resend another one soon. Thanks Hoan On Thu, Sep 8, 2016 at 8:31 AM, Hoan Tran wrote: > The system crashes during probing xgene-hwmon driver when temperature > alarm interrupt occurs before. > It's because > - xgene_hwmon_pr

[PATCH v3] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-08 Thread Hoan Tran
valid resourse as unmapped PCC shared memory. This patch fixes this issue by saving this alarm message and scheduling a bottom handler after xgene_hwmon_probe() finish. Signed-off-by: Hoan Tran Reported-by: Itaru Kitayama --- v3 * Replace IS_ERR by IS_ERR_OR_NULL v2 * Check hwmon_de

Re: [RESEND PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

2016-09-14 Thread Hoan Tran
On Mon, Sep 12, 2016 at 3:07 PM, Rafael J. Wysocki wrote: > On Monday, August 15, 2016 05:14:05 PM Hoan Tran wrote: >> ACPI 6.1 has a PCC HW-Reduced Communication Subspace type 2 intended for >> use on HW-Reduce ACPI Platform, which requires read-modify-write sequence >> to

Re: [PATCH] ACPI: CPPC: Support PCC with interrupt flag

2016-09-14 Thread Hoan Tran
On Tue, Aug 30, 2016 at 11:20 AM, Hoan Tran wrote: > On Thu, Jul 21, 2016 at 2:07 PM, Hoan Tran wrote: >> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone() >> function to notify the mailbox framework about TX completion. >> >> Signed-off-by: Hoan

[RESEND PATCH] ACPI: CPPC: Support PCC with interrupt flag

2016-09-14 Thread Hoan Tran
For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone() function to notify the mailbox framework about TX completion. Signed-off-by: Hoan Tran Reviewed-by: Prashanth Prakash --- drivers/acpi/cppc_acpi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a

Re: [PATCH] ACPI: CPPC: Support PCC with interrupt flag

2016-09-14 Thread Hoan Tran
On Wed, Sep 14, 2016 at 9:49 AM, Rafael J. Wysocki wrote: > On Wednesday, September 14, 2016 08:45:14 AM Hoan Tran wrote: >> On Tue, Aug 30, 2016 at 11:20 AM, Hoan Tran wrote: >> > On Thu, Jul 21, 2016 at 2:07 PM, Hoan Tran wrote: >> >> For PCC mailbox with in

Re: [PATCH v3 3/3] arm64: dts: xgene: Add DT node for APM X-Gene 2 CPU clocks

2016-09-14 Thread Hoan Tran
Hi Stephen, On Wed, Sep 14, 2016 at 1:55 PM, Stephen Boyd wrote: > On 09/12, Hoan Tran wrote: >> Add DT nodes to enable APM X-Gene 2 CPU clocks. >> >> Signed-off-by: Hoan Tran >> --- > > This can go through arm-soc? I'm not applying this. Yes,

Re: [PATCH v3 2/3] clk: xgene: Add PMD clock

2016-09-14 Thread Hoan Tran
On Wed, Sep 14, 2016 at 1:55 PM, Stephen Boyd wrote: > On 09/12, Hoan Tran wrote: >> Add X-Gene PMD clock support. >> >> PMD clock is implemented for a single register field. >> Output rate = parent_rate * (denominator - scale) / denominator >> with >>

[PATCH] cpufreq: CPPC: Avoid overflow when calculating desired_perf

2016-09-14 Thread Hoan Tran
This patch fixes overflow issue when calculating the desired_perf. Signed-off-by: Hoan Tran --- drivers/cpufreq/cppc_cpufreq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c index 894e465..3e0961e 100644

Re: [PATCH] cpufreq: CPPC: Avoid overflow when calculating desired_perf

2016-09-14 Thread Hoan Tran
Hi Rafael, On Wed, Sep 14, 2016 at 5:50 PM, Rafael J. Wysocki wrote: > On Wednesday, September 14, 2016 04:08:28 PM Hoan Tran wrote: >> This patch fixes overflow issue when calculating the desired_perf. >> >> Signed-off-by: Hoan Tran >> --- >> drivers/cpufreq/

Re: [PATCH v2] clk: Add fractional scale clock support

2016-08-08 Thread Hoan Tran
On Wed, Jul 20, 2016 at 11:36 AM, Hoan Tran wrote: > On Fri, Jul 1, 2016 at 5:09 PM, Hoan Tran wrote: >> >> Hi Stephen, >> >> On Fri, Jul 1, 2016 at 11:38 AM, Stephen Boyd wrote: >> > Sorry I replied offlist before. Pressed the wrong key. >> > >

Re: [PATCH v3 0/3] perf: xgene: Add support for SoC PMU version 3

2017-06-20 Thread Hoan Tran
Hi Mark and All, Do you have any comments on this patch set? Thank you! Hoan On Tue, Jun 6, 2017 at 11:02 AM, Hoan Tran wrote: > This patch set adds support for SoC-wide (AKA uncore) Performance Monitoring > Unit version 3. > > It can support up to > - 2 IOB PMU instances

Re: [PATCH v3] hwmon: xgene: Support hwmon v2

2017-10-13 Thread Hoan Tran
Hi Guenter, On Fri, Oct 13, 2017 at 9:28 PM, Guenter Roeck wrote: > On 10/13/2017 04:10 PM, Hoan Tran wrote: >> >> This patch supports xgene-hwmon v2 which uses the non-cachable memory >> as the PCC shared memory. >> >> Signed-off-by: Hoan Tran >> ---

Re: [PATCH v3] hwmon: xgene: Support hwmon v2

2017-10-13 Thread Hoan Tran
Hi On Fri, Oct 13, 2017 at 9:54 PM, Guenter Roeck wrote: > On 10/13/2017 09:38 PM, Hoan Tran wrote: >> >> Hi Guenter, >> >> On Fri, Oct 13, 2017 at 9:28 PM, Guenter Roeck wrote: >>> >>> On 10/13/2017 04:10 PM, Hoan Tran wrote: >>>> >&g

[PATCH v4] hwmon: xgene: Support hwmon v2

2017-10-17 Thread Hoan Tran
This patch supports xgene-hwmon v2 which uses the non-cachable memory as the PCC shared memory. Signed-off-by: Hoan Tran --- v4 - Initialize version variable v3 - Use local version variable - Use inline calls instead of the private map function v2 - Map PCC shared mem by ioremap() in case

Re: [PATCH v2 0/3] perf: xgene: Add support for SoC PMU version 3

2017-05-30 Thread Hoan Tran
Hi All, Ping again Thanks Hoan On Fri, May 5, 2017 at 8:48 AM, Hoan Tran wrote: > Ping! > > Thanks > Hoan > > On Thu, Apr 13, 2017 at 10:50 AM, Hoan Tran wrote: >> Hi All, >> >> Do you have any comments on this patch set? >> >> Thanks >>

Re: [PATCH v2] i2c: xgene-slimpro: Support v2

2017-10-31 Thread Hoan Tran
Hi Andy, On Tue, Oct 31, 2017 at 2:14 AM, Andy Shevchenko wrote: > On Mon, 2017-10-30 at 15:24 -0700, Hoan Tran wrote: >> This patch supports xgene-slimpro-i2c v2 which uses the non-cachable >> memory >> as the PCC shared memory. >> > > Reviewed-by: Andy Shevc

[PATCH] hwmon: xgene: Minor clean up of ifdef and acpi_match_table reference

2017-10-31 Thread Hoan Tran
This patch removes the un-necessary ifdef CONFIG_ACPI and directly uses the acpi_match_table from the driver pdev. Signed-off-by: Hoan Tran --- drivers/hwmon/xgene-hwmon.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/xgene-hwmon.c b/drivers/hwmon

Re: hwmon: xgene: Minor clean up of ifdef and acpi_match_table reference

2017-11-01 Thread Hoan Tran
On Wed, Nov 1, 2017 at 6:15 AM, Guenter Roeck wrote: > On Tue, Oct 31, 2017 at 01:58:07PM -0700, hotran wrote: >> This patch removes the un-necessary ifdef CONFIG_ACPI and directly >> uses the acpi_match_table from the driver pdev. >> >> Signed-off-by: Hoan Tran >

Re: [PATCH] i2c: xgene-slimpro: Support v2

2017-10-30 Thread Hoan Tran
Hi Andy, On Sat, Oct 28, 2017 at 12:37 PM, Andy Shevchenko wrote: > On Sat, 2017-10-28 at 14:11 +0200, Wolfram Sang wrote: >> Thanks for the patch! >> >> On Mon, Oct 23, 2017 at 03:12:20PM -0700, Hoan Tran wrote: >> > This patch supports xgene-slimpro-i2c

[PATCH v2] i2c: xgene-slimpro: Support v2

2017-10-30 Thread Hoan Tran
This patch supports xgene-slimpro-i2c v2 which uses the non-cachable memory as the PCC shared memory. Signed-off-by: Hoan Tran --- v2: - Remove un-necessary ifdef CONFIG_ACPI - Use acpi_match_table pointer from pdev - Use MEMREMAP_WT for non-cachable memory drivers/i2c/busses/i2c-xgene

Re: [PATCH v6] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-05-17 Thread Hoan Tran
Hi Lee, On 5/16/18, 11:25 PM, "Lee Jones" wrote: On Wed, 16 May 2018, Hoan Tran wrote: > Hi Phil, > > On 5/11/18, 1:31 AM, "Phil Edworthy" wrote: > > The DesignWare GPIO IP can be configured for either 1 interrupt or 1

[PATCH] perf: xgene: Add CPU hotplug support

2018-08-15 Thread Hoan Tran
ent (l3c0/cycle-count/). /bin/dmesg may provide additional information. No CONFIG_PERF_EVENTS=y kernel support configured? With this patch, when CPU0 is offline, PMU migrates to another online CPU and works on that CPU. Signed-off-by: Hoan Tran --- drivers/perf/xgene_pmu.c |

Re: [PATCH v5] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-04-26 Thread Hoan Tran
r single interrupt hardware. > > ACPI companion code provided by Hoan Tran . This was tested > on X-Gene by Hoan. > > Signed-off-by: Phil Edworthy > Reviewed-by: Rob Herring > Acked-by: Lee Jones > --- > One point to mention is that I have made it possible for users to h

[PATCH] perf: xgene: Fix IOB SLOW PMU parser error

2018-06-06 Thread Hoan Tran
character inside the PMU name. Signed-off-by: Hoan Tran --- drivers/perf/xgene_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c index 6bdb1da..0e31f13 100644 --- a/drivers/perf/xgene_pmu.c +++ b/drivers/perf/xgene_pmu.c @@

Re: [PATCH v6] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-05-16 Thread Hoan Tran
platform_get_irq() to get the DT interrupts as they are in the port sub-node and hence do not have an associated platform device. v5: - Rolled ACPI companion code provided by Hoan Tran into this patch. v4: - Use of_irq_get() instead of of_irq_parse_one()+irq_creat

[PATCH v2] mailbox: pcc: Support HW-Reduced Communication Subspace Type 2

2016-05-06 Thread Hoan Tran
* Remove unnecessary variable initialization * ISR returns IRQ_NONE in case of error v1 * Initial Signed-off-by: Hoan Tran --- drivers/mailbox/pcc.c | 395 +- 1 file changed, 296 insertions(+), 99 deletions(-) diff --git a/drivers/mailbox/pcc.c

Re: [PATCH v2] mailbox: pcc: Support HW-Reduced Communication Subspace Type 2

2016-05-09 Thread Hoan Tran
Hi Alexey, On Mon, May 9, 2016 at 2:43 AM, Alexey Klimov wrote: > Hi Hoan, > > On Fri, May 06, 2016 at 11:38:34AM -0700, Hoan Tran wrote: >> From: hotran >> >> ACPI 6.1 has a PCC HW-Reduced Communication Subspace Type 2 intended for >> use on HW-Reduce ACPI Pla

Re: [PATCH v2] mailbox: pcc: Support HW-Reduced Communication Subspace Type 2

2016-05-10 Thread Hoan Tran
Hi Alexey, On Tue, May 10, 2016 at 3:34 AM, Alexey Klimov wrote: > On Mon, May 09, 2016 at 10:38:24AM -0700, Hoan Tran wrote: >> Hi Alexey, >> >> On Mon, May 9, 2016 at 2:43 AM, Alexey Klimov wrote: >> > Hi Hoan, >> > >> > On Fri, May 06, 2016

Re: [PATCH v2] mailbox: pcc: Support HW-Reduced Communication Subspace Type 2

2016-05-10 Thread Hoan Tran
Hi Ashwin, Thanks for your review ! On Tue, May 10, 2016 at 5:00 AM, Ashwin Chaugule wrote: > Hello, > > On 6 May 2016 at 14:38, Hoan Tran wrote: >> From: hotran >> >> ACPI 6.1 has a PCC HW-Reduced Communication Subspace Type 2 intended for >> use on HW-Red

Re: [PATCH v2] mailbox: pcc: Support HW-Reduced Communication Subspace Type 2

2016-05-11 Thread Hoan Tran
Hi Ashwin, On Wed, May 11, 2016 at 4:57 AM, Ashwin Chaugule wrote: > On 11 May 2016 at 00:21, Hoan Tran wrote: >> Hi Ashwin, > > Hi, > >> On Tue, May 10, 2016 at 5:00 AM, Ashwin Chaugule >>> On 6 May 2016 at 14:38, Hoan Tran wrote: >>>> From: ho

Re: [PATCH 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation

2016-05-23 Thread Hoan Tran
Hi Rob, Thanks for your review ! On Mon, May 23, 2016 at 1:30 PM, Rob Herring wrote: > > On Mon, May 16, 2016 at 09:17:25AM -0700, Hoan Tran wrote: > > This patch adds the APM X-Gene hwmon device tree node documentation. > > > > Signed-off-by: Hoan Tran > > --

[PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

2016-05-19 Thread Hoan Tran
* Correct parsing subspace type 1 and subspace type 2 v2 * Remove changes inside "actbl3.h". This file is taken care by ACPICA. * Parse both subspace type 1 and subspace type 2 * Remove unnecessary variable initialization * ISR returns IRQ_NONE in case of error v1 * Initial Signed-of

[PATCH] acpi: cppc: Prevent cpc_desc_ptr points to the invalid data

2016-05-25 Thread Hoan Tran
When CPPC fails to request PCC channel, the CPC data is freed and cpc_desc_ptr points to the invalid data. This change prevents this issue by moving cpc_desc_ptr assignment after PCC channel request. Signed-off-by: Hoan Tran --- drivers/acpi/cppc_acpi.c | 6 +++--- 1 file changed, 3 insertions

Re: [PATCH] acpi: cppc: Prevent cpc_desc_ptr points to the invalid data

2016-05-27 Thread Hoan Tran
Thanks Hoan On Fri, May 27, 2016 at 9:10 AM, Ashwin Chaugule wrote: > On 25 May 2016 at 15:09, Hoan Tran wrote: >> When CPPC fails to request PCC channel, the CPC data is freed >> and cpc_desc_ptr points to the invalid data. This change prevents >> this issue by mo

Re: [PATCH v2] mailbox: pcc: Support HW-Reduced Communication Subspace Type 2

2016-05-13 Thread Hoan Tran
Hi Ashwin, On Fri, May 13, 2016 at 10:23 AM, Ashwin Chaugule wrote: > On 11 May 2016 at 14:15, Hoan Tran wrote: >> On Wed, May 11, 2016 at 4:57 AM, Ashwin Chaugule >> wrote: >>> On 11 May 2016 at 00:21, Hoan Tran wrote: >>>> On Tue, May 10, 2016 at 5:00 AM,

[PATCH 0/3] Add support for X-Gene hwmon driver

2016-05-16 Thread Hoan Tran
https://lkml.org/lkml/2016/5/6/482 - [PATCH v2] mailbox: pcc: Support HW-Reduced Communication Subspace Type 2 Hoan Tran (3): Documentation: dtb: xgene: Add hwmon dts binding documentation hwmon: xgene: Adds hwmon driver arm64: dts: apm: Add X-Gene SoC hwmon to device tree .../devicetree/bindings/

[PATCH 3/3] arm64: dts: apm: Add X-Gene SoC hwmon to device tree

2016-05-16 Thread Hoan Tran
This patch adds DT node to enable hwmon driver for APM X-Gene SoC. Signed-off-by: Hoan Tran --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 5 + arch/arm64/boot/dts/apm/apm-storm.dtsi | 5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi

[PATCH 2/3] hwmon: xgene: Adds hwmon driver

2016-05-16 Thread Hoan Tran
This patch adds hardware temperature and power reading support for APM X-Gene SoC's using the mailbox communication interface. Signed-off-by: Hoan Tran --- Documentation/hwmon/xgene-hwmon | 32 ++ drivers/hwmon/Kconfig | 7 + drivers/hwmon/Makefile | 1 + drivers/

[PATCH 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation

2016-05-16 Thread Hoan Tran
This patch adds the APM X-Gene hwmon device tree node documentation. Signed-off-by: Hoan Tran --- .../devicetree/bindings/hwmon/apm-xgene-hwmon.txt | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt

Re: [PATCH] mailbox: pcc: Support HW-Reduced Communication Subspace Type 2

2016-04-19 Thread Hoan Tran
nce >> to acknowledge doorbell interrupt. This patch provides the implementation >> for the Communication Subspace Type 2. >> >> Signed-off-by: Hoan Tran >> --- >> drivers/mailbox/pcc.c | 384 >> +- >>

Re: [PATCH v2] perf: xgene: Add CPU hotplug support

2018-10-02 Thread Hoan Tran
on practices.] > > > Hi Hoan, > > On Wed, Sep 19, 2018 at 06:44:30PM +, Hoan Tran wrote: >> This patch adds CPU hotplug support where the PMU migrates the context to >> another online CPU when its CPU is offline. >> &g

Re: [PATCH] perf: xgene: Add CPU hotplug support

2018-09-19 Thread Hoan Tran
on practices.] > > > On Wed, Aug 15, 2018 at 11:31:35AM -0700, Hoan Tran wrote: >> This patch adds CPU hotplug support where the PMU migrates the context to >> another online CPU when its CPU is offline. >> >> It fixes the be

[PATCH v2] perf: xgene: Add CPU hotplug support

2018-09-19 Thread Hoan Tran
ent (l3c0/cycle-count/). /bin/dmesg may provide additional information. No CONFIG_PERF_EVENTS=y kernel support configured? With this patch, when CPU0 is offline, PMU migrates to another online CPU and works on that CPU. Signed-off-by: Hoan Tran --- v2: * Remove the cpuhp instance w

Re: [PATCH v3] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-04-19 Thread Hoan Tran
Hi Phil, On Thu, Apr 19, 2018 at 3:03 AM, Phil Edworthy wrote: > Hi Hoan > > On 18 April 2018 08:03 Hoan Tran wrote: >> On Fri, Apr 13, 2018 at 9:47 AM, Phil Edworthy wrote: >> > On 13 April 2018 17:37 Hoan Tran wrote: >> >> On Fri, Apr 13, 2018 at 1:51

Re: [PATCH v3] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-04-13 Thread Hoan Tran
Hi Phil, On Fri, Apr 13, 2018 at 1:51 AM, Phil Edworthy wrote: > The DesignWare GPIO IP can be configured for either 1 interrupt or 1 > per GPIO in port A, but the driver currently only supports 1 interrupt. > See the DesignWare DW_apb_gpio Databook description of the > 'GPIO_INTR_IO' parameter.

Re: [PATCH v3] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-04-18 Thread Hoan Tran
Hi Phil, On Fri, Apr 13, 2018 at 9:47 AM, Phil Edworthy wrote: > Hi Hoan, > > On 13 April 2018 17:37 Hoan Tran wrote: >> On Fri, Apr 13, 2018 at 1:51 AM, Phil Edworthy wrote: >> > The DesignWare GPIO IP can be configured for either 1 interrupt or 1 >> > p

[PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC

2017-01-31 Thread Hoan Tran
Next generation of X-Gene SoC's GPIO hardware register map is very similar to DW GPIO. It only differs by a few register addresses. This patch modifies DW GPIO driver to accommodate the difference in a few register addresses. Signed-off-by: Hoan Tran --- drivers/gpio/gpio-dwapb.c

Re: [PATCH v2 2/3] hwmon: xgene: Add hwmon driver

2016-07-18 Thread Hoan Tran
Hi Guenter, On Sat, Jul 16, 2016 at 9:35 AM, Guenter Roeck wrote: > On 07/11/2016 05:30 PM, Hoan Tran wrote: >> >> This patch adds hardware temperature and power reading support for >> APM X-Gene SoC using the mailbox communication interface. >>

Re: [PATCH 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation

2016-06-23 Thread Hoan Tran
On Tue, Jun 7, 2016 at 11:05 AM, Hoan Tran wrote: > Hi Jassi, > > Thanks for your reply ! > > On Tue, Jun 7, 2016 at 10:20 AM, Jassi Brar wrote: >> On Tue, May 24, 2016 at 6:31 AM, Hoan Tran wrote: >>> Hi Rob, >>> >>> Thanks for your review ! >

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

2016-06-08 Thread Hoan Tran
Hi Ashwin, On Wed, Jun 8, 2016 at 5:18 AM, Ashwin Chaugule wrote: > + Prashanth (Can you please have a look as well?) > > On 31 May 2016 at 15:35, Hoan Tran wrote: >> Hi Ashwin, > > Hi, > > Sorry about the delay. I'm in the middle of switching jobs and >

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

2016-06-08 Thread Hoan Tran
Hi Prashanth, On Wed, Jun 8, 2016 at 5:32 PM, Prakash, Prashanth wrote: > > > On 6/8/2016 10:24 AM, Hoan Tran wrote: >> Hi Ashwin, >> >> On Wed, Jun 8, 2016 at 5:18 AM, Ashwin Chaugule >> wrote: >>> + Prashanth (Can you please have a look as well?)

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

2016-06-09 Thread Hoan Tran
Hi Ashwin and Prashanth, On Wed, Jun 8, 2016 at 5:41 PM, Hoan Tran wrote: > Hi Prashanth, > > > On Wed, Jun 8, 2016 at 5:32 PM, Prakash, Prashanth > wrote: >> >> >> On 6/8/2016 10:24 AM, Hoan Tran wrote: >>> Hi Ashwin, >>> >>>

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

2016-06-09 Thread Hoan Tran
Hi Prashanth, On Thu, Jun 9, 2016 at 3:25 PM, Prakash, Prashanth wrote: > > > On 6/9/2016 2:47 PM, Hoan Tran wrote: >> Hi Ashwin and Prashanth, >> >> On Wed, Jun 8, 2016 at 5:41 PM, Hoan Tran wrote: >>> Hi Prashanth, >>> >>> >>>

[PATCH] mailbox: pcc: Add PCC request and free channel declarations

2016-06-14 Thread Hoan Tran
As PCC will be used by other clients not only CPPC. This change exports pcc_mbox_request_channel() and pcc_mbox_free_channel() declarations Signed-off-by: Hoan Tran --- include/acpi/cppc_acpi.h | 4 include/linux/mailbox_client.h | 4 2 files changed, 4 insertions(+), 4

Re: [PATCH] mailbox: pcc: Add PCC request and free channel declarations

2016-06-15 Thread Hoan Tran
Hi Prashanth, On Wed, Jun 15, 2016 at 8:55 AM, Prakash, Prashanth wrote: > Hi Hoan, > > On 6/14/2016 5:12 PM, Hoan Tran wrote: >> As PCC will be used by other clients not only CPPC. >> This change exports pcc_mbox_request_channel() and pcc_mbox_free_channel() >> decla

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

2016-07-13 Thread Hoan Tran
Hi Rafael, On Mon, Jun 27, 2016 at 2:32 PM, Rafael J. Wysocki wrote: > On Monday, June 27, 2016 11:27:42 AM Hoan Tran wrote: >> Hi Jassi and Rafael, >> >> On Wed, Jun 15, 2016 at 9:19 AM, Prakash, Prashanth >> wrote: >> > >> > >> > On

Re: hwmon: xgene: Add support for X-Gene hwmon driver

2016-07-23 Thread Hoan Tran
need a newer version of Tianocore. > Also, if you or your folks can fold your patch set into APM's xgene-next > GitHub repo, that would help me to keep up with the development. xgene-next is currently used for device tree patch only. Thanks Hoan > > Itaru > > > On 7/24/16

Re: [PATCH v2] clk: Add fractional scale clock support

2016-07-01 Thread Hoan Tran
Hi Stephen, On Fri, Jul 1, 2016 at 11:38 AM, Stephen Boyd wrote: > Sorry I replied offlist before. Pressed the wrong key. > > On 06/30, Hoan Tran wrote: >> On Thu, Jun 30, 2016 at 1:23 PM, Stephen Boyd wrote: >> > >> > How is this different from clk-fractiona

[PATCH v2] mailbox: pcc: Add PCC request and free channel declarations

2016-07-04 Thread Hoan Tran
Exports pcc_mbox_request_channel() and pcc_mbox_free_channel() declarations into a pcc.h header file. v2 * Introduce pcc.h header file for pcc client methods v1 * Initial Signed-off-by: Hoan Tran --- include/acpi/cppc_acpi.h | 7 +-- include/acpi/pcc.h | 29

Re: [PATCH] acpi: cppc: Prevent cpc_desc_ptr points to the invalid data

2016-07-04 Thread Hoan Tran
On Tue, May 31, 2016 at 12:29 PM, Ashwin Chaugule wrote: > > On 27 May 2016 at 12:41, Hoan Tran wrote: > > Hi Ashwin, > > Hi, > > > > > Yes, I saw kernel crash. > > As cpc_desc_ptr is not NULL, cppc_cpufreq_init() still can pass then > > crash d

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

2016-07-04 Thread Hoan Tran
Hi Jassi and Rafael, On Wed, Jun 15, 2016 at 9:19 AM, Prakash, Prashanth wrote: > > > On 6/9/2016 4:43 PM, Hoan Tran wrote: >> Hi Prashanth, >> >> On Thu, Jun 9, 2016 at 3:25 PM, Prakash, Prashanth >> wrote: >>> >>> On 6/9/2016 2:4

[PATCH] mailbox: pcc: Add PCC request and free channel declarations

2016-07-04 Thread Hoan Tran
As PCC will be used by other clients not only CPPC. This change exports pcc_mbox_request_channel() and pcc_mbox_free_channel() declarations Signed-off-by: Hoan Tran --- include/acpi/cppc_acpi.h | 4 include/linux/mailbox_client.h | 4 2 files changed, 4 insertions(+), 4

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

2016-07-04 Thread Hoan Tran
Hi Ashwin and Prashanth, On Wed, Jun 8, 2016 at 5:41 PM, Hoan Tran wrote: > Hi Prashanth, > > > On Wed, Jun 8, 2016 at 5:32 PM, Prakash, Prashanth > wrote: >> >> >> On 6/8/2016 10:24 AM, Hoan Tran wrote: >>> Hi Ashwin, >>> >>>

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

2016-07-04 Thread Hoan Tran
Hi Prashanth, On Thu, Jun 9, 2016 at 3:25 PM, Prakash, Prashanth wrote: > > > On 6/9/2016 2:47 PM, Hoan Tran wrote: >> Hi Ashwin and Prashanth, >> >> On Wed, Jun 8, 2016 at 5:41 PM, Hoan Tran wrote: >>> Hi Prashanth, >>> >>> >>>

Re: [PATCH] mailbox: pcc: Add PCC request and free channel declarations

2016-07-04 Thread Hoan Tran
Hi Prashanth, On Wed, Jun 15, 2016 at 8:55 AM, Prakash, Prashanth wrote: > Hi Hoan, > > On 6/14/2016 5:12 PM, Hoan Tran wrote: >> As PCC will be used by other clients not only CPPC. >> This change exports pcc_mbox_request_channel() and pcc_mbox_free_channel() >> decla

[PATCH] ACPI: CPPC: Return error if _CPC is invalid on a CPU

2016-07-04 Thread Hoan Tran
Based on 8.4.7.1 section of ACPI 6.1 specification, if the platform supports CPPC, the _CPC object must exist under all processor objects. If cpc_desc_ptr pointer is invalid on any CPUs, acpi_get_psd_map() should return error and CPPC cpufreq driver can not be registered. Signed-off-by: Hoan Tran

Re: [2/3] hwmon: xgene: Adds hwmon driver

2016-05-31 Thread Hoan Tran
terface. >> > Please drop the "'". Yes, will remove it. > >> >> Signed-off-by: Hoan Tran >> --- >> Documentation/hwmon/xgene-hwmon | 32 ++ >> drivers/hwmon/Kconfig | 7 + >>

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

2016-05-31 Thread Hoan Tran
Hi Ashwin, Do you have any comments ? Thanks Hoan On Thu, May 19, 2016 at 5:32 PM, Hoan Tran wrote: > ACPI 6.1 has a PCC HW-Reduced Communication Subspace type 2 intended for > use on HW-Reduce ACPI Platform, which requires read-modify-write sequence > to acknowledge doorbell interr

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

2016-05-31 Thread Hoan Tran
Hi Ashwin, On Tue, May 31, 2016 at 12:05 PM, Ashwin Chaugule wrote: > Hi Hoan, > > On 19 May 2016 at 20:32, Hoan Tran wrote: >> ACPI 6.1 has a PCC HW-Reduced Communication Subspace type 2 intended for >> use on HW-Reduce ACPI Platform, which requires read-modify-write seque

Re: [PATCH] acpi: cppc: Prevent cpc_desc_ptr points to the invalid data

2016-05-31 Thread Hoan Tran
Hi Ashwin, On Tue, May 31, 2016 at 12:29 PM, Ashwin Chaugule wrote: > On 27 May 2016 at 12:41, Hoan Tran wrote: >> Hi Ashwin, > > Hi, > >> >> Yes, I saw kernel crash. >> As cpc_desc_ptr is not NULL, cppc_cpufreq_init() still can pass then >> crash duri

[PATCH v3] mailbox: PCC: Fix lockdep warning when request PCC channel

2016-10-27 Thread Hoan Tran
t too long. This patch releases spinlock before request_irq() and free_irq() to fix this issue as spinlock is only needed to protect the channel data. Signed-off-by: Hoan Tran --- v3 * Free mailbox irq before reset the channel data * Free channel if it fails to request the mailbox irq v2 * Re

[PATCH] i2c: xgene: Avoid dma_buffer overrun

2016-10-10 Thread Hoan Tran
SMBus block command uses the first byte of buffer for the data length. The dma_buffer should be increased by 1 to avoid the overrun issue. Reported-by: Phil Endecott Signed-off-by: Hoan Tran --- drivers/i2c/busses/i2c-xgene-slimpro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] cpufreq: CPPC: Correct desired_perf calculation

2016-10-11 Thread Hoan Tran
The desired_perf is an abstract performance number. Its value should be in the range of [lowest perf, highest perf] of CPPC. The correct calculation is desired_perf = freq * cppc_highest_perf / cppc_dmi_max_khz Signed-off-by: Hoan Tran --- drivers/cpufreq/cppc_cpufreq.c | 2 +- 1 file changed

Re: [PATCH] cpufreq: CPPC: Correct desired_perf calculation

2016-10-11 Thread Hoan Tran
Hi Rafael, On Tue, Oct 11, 2016 at 2:50 PM, Rafael J. Wysocki wrote: > On Tuesday, October 11, 2016 02:12:00 PM Hoan Tran wrote: >> The desired_perf is an abstract performance number. Its value should >> be in the range of [lowest perf, highest perf] of CPPC. >> The c

Re: [PATCH] cpufreq: CPPC: Correct desired_perf calculation

2016-10-12 Thread Hoan Tran
[Resend with plain text mode] Hi Prashanth, On Wed, Oct 12, 2016 at 8:36 AM, Prakash, Prashanth wrote: > Hi Hoan, > > On 10/11/2016 3:12 PM, Hoan Tran wrote: >> The desired_perf is an abstract performance number. Its value should >> be in the range of [lowest perf, highest

[PATCH v2] cpufreq: CPPC: Correct desired_perf calculation

2016-10-13 Thread Hoan Tran
old perf. Signed-off-by: Hoan Tran --- v2 * Return if desired_perf is the same with the old one (Prashanth's suggestion) drivers/cpufreq/cppc_cpufreq.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpuf

[PATCH v4] mailbox: PCC: Fix lockdep warning when request PCC channel

2016-11-14 Thread Hoan Tran
t too long. This patch releases spinlock before request_irq() and free_irq() to fix this issue as spinlock is only needed to protect the channel data. Signed-off-by: Hoan Tran --- v4 * Include acpi/pcc.h v3 * Free mailbox irq before reset the channel data * Free channel if it fails to reques

Re: [PATCH v3] mailbox: PCC: Fix lockdep warning when request PCC channel

2016-11-14 Thread Hoan Tran
Hi, On Sun, Nov 13, 2016 at 11:44 AM, Prakash, Prashanth wrote: > HI Hoan, > > On 11/9/2016 11:39 PM, Hoan Tran wrote: >> Hi All, >> >> On Thu, Oct 27, 2016 at 3:34 PM, Hoan Tran wrote: >>> This patch fixes the lockdep warning below >>> >>>

  1   2   3   >