[PATCH] staging: fsl-dpaa2/eth: Use named arguments in function definition

Checkpatch complains about unnamed arguments in a function prototype, so fix it. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h b

[PATCH 2/2] staging: fsl-dpaa2/eth: Remove unused driver version

We never really used the driver version, so no point in keeping it around. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 -- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 1 - drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 2 -- 3 files

[PATCH 1/2] staging: fsl-dpaa2/eth: Update default hash key

intention and makes most sense as a default. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 6 +++--- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 5 - 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet

[PATCH 1/4] staging: fsl-dpaa2/eth: Cleanup comments

Comments in file net.h are too fancy for their own good, so convert them to the regular format. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/net.h | 76 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/drivers/staging/fsl

[PATCH 2/4] staging: fsl-dpaa2/eth: Remove dead code

File net.h contains unused defines, so remove them. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/net.h | 85 1 file changed, 85 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/net.h b/drivers/staging/fsl-dpaa2/ethernet

[PATCH 0/4] staging: fsl-dpaa2/eth: Private header cleanup

Private header file net.h receives a cleanup and the remaining code is then merged into dpkg.h This patchset depends on: staging: fsl-dpaa2/eth: add SPDX license identifiers (https://lore.kernel.org/patchwork/patch/969402/) Ioana Radulescu (4): staging: fsl-dpaa2/eth: Cleanup comments

[PATCH 3/4] staging: fsl-dpaa2/eth: Use BIT() macro

File net.h has several bitmask defines that could be implemented more clearly using the BIT() macro. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/net.h | 448 +++ 1 file changed, 219 insertions(+), 229 deletions(-) diff --git a/drivers

[PATCH 4/4] staging: fsl-dpaa2/eth: Merge header files

File net.h contains definitions that are exclusively used by the key generator/classification API. Merge its contents with dpkg.h in order to reduce the number of private headers. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpkg.h | 350

[PATCH] staging: fsl-dpaa2/ethsw: Fix error message

Error message was referencing wrong function, fix it. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index 0d54564e

[PATCH] staging: fsl-dpaa2/eth: Remove unnecessary cast

There's no need to explicitly cast DPAA2_ETH_MFL to u16, so remove it. Signed-off-by: Ioana Radulescu Suggested-by: Dan Carpenter --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/

[PATCH 1/2] staging: fsl-mc/dpio: Add dpaa2_io_service_select() API

round-robin fashion from a list of available services. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 17 + drivers/staging/fsl-mc/include/dpaa2-io.h | 2 ++ 2 files changed, 19 insertions(+) diff --git a/drivers/staging/fsl-mc/bus/dp

[PATCH 2/2] staging: fsl-dpaa2/eth: Use affine DPIO services

argument mostly for uniformity, but this doesn't change the previous functionality. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 24 ++-- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 1 + 2 files changed, 15 insertions(+

[PATCH 0/2] staging: fsl-mc/dpio, fsl-dpaa2/eth: Use affine DPIO services

netperf (client), 256 flows: 17.27Gbps with 100% cpu load vs 18.78Gbps with 77.6% cpu load Ioana Radulescu (2): staging: fsl-mc/dpio: Add dpaa2_io_service_select() API staging: fsl-dpaa2/eth: Use affine DPIO services drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 24

[PATCH v2] staging: fsl-mc: Convert documentation to rst format

Update the doc file to comply with the rst format. It's not integrated into the documentation build structure yet, since it's still located in drivers/staging. Signed-off-by: Ioana Radulescu --- v2: patch generated with -M option .../staging/fsl-mc/{README.txt => overview.

[PATCH 2/5] staging: fsl-mc/dpio: Fix cast truncate warning

Sparse reports the following warning: drivers/staging/fsl-mc/include/dpaa2-fd.h:421:30: warning: cast truncates bits from constant value (7fff becomes 7fff) Fix this by explicitly masking the value with 0x. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-mc/include/dpaa2-fd.h

[PATCH 4/5] staging: fsl-mc/dpio: Fix incorrect masking

In qbman_swp_alt_fq_state(), we need to mask the fqid value before converting it to little endian, otherwise we write a wrong value to hardware when running in big endian mode. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-mc/bus/dpio/qbman-portal.c | 2 +- 1 file changed, 1 insertion

[PATCH 5/5] staging: fsl-mc/dpio: Remove dead code

Function qbman_pull_desc_set_token() is not used at all, so remove it. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-mc/bus/dpio/qbman-portal.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c b/drivers/staging/fsl-mc/bus/dpio

[PATCH 0/5] staging: fsl-mc/dpio: Fix sparse warnings

Some code cleanup and bug fixes based on warnings reported by sparse when building on x86. Ioana Radulescu (5): staging: fsl-mc/dpio: Fix incorrect cast staging: fsl-mc/dpio: Fix cast truncate warning staging: fsl-mc/dpio: Use __leXX types where needed staging: fsl-mc/dpio: Fix incorrect

[PATCH 3/5] staging: fsl-mc/dpio: Use __leXX types where needed

Structures that are mapped to hardware registers should explicitly specify the expected endianness for fields larger than 1 byte. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-mc/bus/dpio/qbman-portal.c | 16 drivers/staging/fsl-mc/bus/dpio/qbman-portal.h | 24

[PATCH 1/5] staging: fsl-mc/dpio: Fix incorrect cast

Move the cast in dpaa2_sg_get_addr() to the right place. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-mc/include/dpaa2-fd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/include/dpaa2-fd.h b/drivers/staging/fsl-mc/include/dpaa2-fd.h index

[PATCH v2] staging: fsl-dpaa2/eth: Defer probing if no MC portal available

MC portals may not be available at the initial probing attempt due to dependencies on other modules. Check the return value of the MC portal allocation function and defer probing in case it's not available yet. For all other error cases the behaviour stays the same. Signed-off-by:

[PATCH 4/9] staging: fsl-dpaa2/eth: Remove packed attribute

Structure dpaa2_fas is naturally aligned, so no need to use the __packed attribute explicitly. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h b

[PATCH 7/9] staging: fsl-dpaa2/eth: Cleanup TX frame freeing code

Cleanup code in free_tx_fd() that deals with S/G frames: - remove local variables that aren't really needed - in the frame sw annotation area, store the actual SG table buffer size, which is needed on free, rather then recompute it based on number of S/G entries Signed-off-by: Ioana Radu

[PATCH 9/9] staging: fsl-dpaa2/eth: Change max number of Tx queues

, whereas NR_CPUS is Kconfigurable and can be much higher. Avoid allocating memory we'll never use, by setting DPAA2_ETH_MAX_TX_QUEUES to 16. Same for DPAA2_ETH_MAX_DPCONS. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 4 ++-- 1 file changed, 2 inser

[PATCH 8/9] staging: fsl-dpaa2/eth: Fix SGT allocation

We mistakenly allocate space for too many entries in the scatter-gather table of multi buffer egress frames. While it doesn't have a negative impact from a functional point of view, it wastes resources so fix it. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-

[PATCH 6/9] staging: fsl-dpaa2/eth: Change link settings on the fly

Newer MC versions allow us to change link settings while the interface is up. Only check interface status if we are using an old version. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions

[PATCH 2/9] staging: fsl-dpaa2/eth: Move print message

Let the driver remove() function print an informative message after it finishes removing the network interface, not at an arbitrary point during cleanup. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH 5/9] staging: fsl-dpaa2/eth: Add DPNI version check

use on it. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 15 +++ drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 10 ++ drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 11 ++- 3 files changed, 27 insertions(+), 9

[PATCH 0/9] staging: fsl-dpaa2/eth: Cleanup

A set of cleanup patches with limited functional impact. Ioana Radulescu (9): staging: fsl-dpaa2/eth: Use generic irq handler staging: fsl-dpaa2/eth: Move print message staging: fsl-dpaa2/eth: Remove unused field staging: fsl-dpaa2/eth: Remove packed attribute staging: fsl-dpaa2/eth

[PATCH 3/9] staging: fsl-dpaa2/eth: Remove unused field

Remove dpio_id field in struct dpaa2_eth_channel, which wasn't used anywhere in the code. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h b/drivers/stagin

[PATCH 1/9] staging: fsl-dpaa2/eth: Use generic irq handler

For the link state interrupt, we used a dummy non-threaded irq handler, which had the same implementation as the generic irq_default_primary_handler() function. Give up on using our own irq handler and let the kernel use the generic one instead. Signed-off-by: Ioana Radulescu --- drivers

[PATCH] staging: fsl-dpaa2/eth: Use debug level for message

The driver remove() function prints a message when the operation is completed. Make this a debug level message to avoid polluting the kernel log wih too much information. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 0/2] fsl-dpaa2/eth: Enable multi-arch compile

on x86_64. Ioana Radulescu (2): staging: fsl-dpaa2/eth: Use __leXX types where needed staging: fsl-dpaa2/eth: allow the driver to compile multi-arch drivers/staging/fsl-dpaa2/Kconfig | 2 +- drivers/staging/fsl-dpaa2/ethernet/dpni-cmd.h | 4 ++-- 2 files changed, 3 insertions(+), 3

[PATCH v2 2/2] staging: fsl-dpaa2/eth: allow the driver to compile multi-arch

CONFIG_OF) - arm64 (defconfig) Signed-off-by: Ioana Radulescu --- v2: no change drivers/staging/fsl-dpaa2/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-dpaa2/Kconfig b/drivers/staging/fsl-dpaa2/Kconfig index dfff675..730fd6d 100644 --- a/drivers

[PATCH v2 1/2] staging: fsl-dpaa2/eth: Use __leXX types where needed

One MC command structure got away with using uXX fields instead of __leXX. Fix it. Signed-off-by: Ioana Radulescu --- v2: new patch drivers/staging/fsl-dpaa2/ethernet/dpni-cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpni

[PATCH 0/5] staging: fsl-dpaa2/eth: Cleanup and minor fixes

One bug fix, one small functional change and a couple of cleanup patches. Ioana Radulescu (5): staging: fsl-dpaa2/eth: Fix DMA mapping direction staging: fsl-dpaa2/eth: Remove obsolete reference staging: fsl-dpaa2/eth: Remove pointless instruction staging: fsl-dpaa2/eth: MTU cleanup

[PATCH 4/5] staging: fsl-dpaa2/eth: MTU cleanup

Don't set the lower MTU limit explicitly, since we use the default value anyway. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/dr

[PATCH 2/5] staging: fsl-dpaa2/eth: Remove obsolete reference

Commit 2b7c86eb7bf3 ("staging: fsl-dpaa2/eth: Don't enable FAS on Tx") removed the status field from the TX confirm frame annotation, but a reference to it remained in the description of free_tx_fd(). Remove it. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ether

[PATCH 5/5] staging: fsl-dpaa2/eth: Remove Rx frame size check

dware only once at probe time, with the largest possible value. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/dr

[PATCH 3/5] staging: fsl-dpaa2/eth: Remove pointless instruction

We don't need to call dev_set_drvdata(dev, NULL) on driver remove since core kernel code also performs this step. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-

[PATCH 1/5] staging: fsl-dpaa2/eth: Fix DMA mapping direction

We are using DMA_FROM_DEVICE when mapping RX frame buffers, but DMA_BIDIRECTIONAL for unmap. Fix the direction for DMA unmapping operation. Fixes: 87eb55e418b7 ("staging: fsl-dpaa2/eth: Fix potential endless loop") Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethe

[PATCH] staging: fsl-dpaa2/eth: Fix incorrect kfree

-off-by: Ioana Radulescu Reported-by: Dan Carpenter --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c index c81a01f

[RESEND PATCH] bus: fsl-mc: add DPCON object APIs

From: Ioana Radulescu This patch adds the command building/parsing wrapper functions for the DPCON object. The binary interface version is v3.2. Signed-off-by: Ioana Radulescu Signed-off-by: Ioana Ciornei Signed-off-by: Stuart Yoder --- This patch depends on the following patch series

[PATCH 1/8] staging: fsl-dpaa2/eth: Add Ethernet driver overview document

Add a README file describing the driver architecture, components and I/O interface. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/README | 186 + 1 files changed, 186 insertions(+), 0 deletions(-) create mode 100644 drivers/staging/fsl-dpaa2

[PATCH 3/8] staging: fsl-dpaa2/eth: Add Freescale DPAA2 Ethernet driver

(DPCONs). Signed-off-by: Ioana Radulescu Signed-off-by: Bogdan Hamciuc --- drivers/staging/fsl-dpaa2/ethernet/Makefile|2 +- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2460 drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 302 +++ 3 files changed, 2763

[PATCH 5/8] staging: fsl-dpaa2/eth: Add driver specific stats

Add custom statistics to be reported via ethtool -S. These include driver specific per-cpu statistics as well as queue and channel counters. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 42 - drivers/staging/fsl-dpaa2/ethernet/dpaa2

[PATCH 2/8] staging: fsl-dpaa2/eth: Add APIs for DPNI objects

Add the command build/parse APIs for operating on DPNI objects through the DPAA2 Management Complex. Signed-off-by: Ioana Radulescu --- drivers/staging/Kconfig |2 + drivers/staging/Makefile |1 + drivers/staging/fsl-dpaa2/Kconfig

[PATCH 4/8] staging: fsl-dpaa2/eth: Add ethtool support

Add support for several ethtool operations: show hardware statistics, get/set link settings, get hash configuration. Signed-off-by: Ioana Radulescu Signed-off-by: Bogdan Hamciuc --- drivers/staging/fsl-dpaa2/ethernet/Makefile|2 +- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c

[PATCH 0/8] staging: Introduce Freescale DPAA2 Ethernet driver

, add dpio https://www.spinics.net/lists/kernel/msg2396338.html [PATCH] bus: fsl-mc: add DPCON object APIs https://www.spinics.net/lists/kernel/msg2398182.html Ioana Radulescu (8): staging: fsl-dpaa2/eth: Add Ethernet driver overview document staging: fsl-dpaa2/eth: Add APIs for DPNI objects

[PATCH 8/8] staging: fsl-dpaa2/eth: Add maintainer for Ethernet driver

Signed-off-by: Ioana Radulescu --- MAINTAINERS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 312c582..da4a6fa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5057,6 +5057,12 @@ S: Maintained F: drivers/net/ethernet

[PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file

Add a list of TODO items for the Ethernet driver Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/TODO |9 + 1 files changed, 9 insertions(+), 0 deletions(-) create mode 100644 drivers/staging/fsl-dpaa2/ethernet/TODO diff --git a/drivers/staging/fsl-dpaa2

[PATCH 6/8] staging: fsl-dpaa2/eth: Add trace points

Add trace events in significant places of the data path. Useful for debuggging. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/Makefile|3 + .../staging/fsl-dpaa2/ethernet/dpaa2-eth-trace.h | 185 drivers/staging/fsl-dpaa2/ethernet

[PATCH v3 0/9] staging: Introduce Freescale DPAA2 Ethernet driver

driver is still in staging - minor updates in patch #4 due to networking API changes Ioana Radulescu (9): bus: fsl-mc: add DPCON object APIs staging: fsl-dpaa2/eth: Add Ethernet driver overview document staging: fsl-dpaa2/eth: Add APIs for DPNI objects staging: fsl-dpaa2/eth: Add

[PATCH v3 8/9] staging: fsl-dpaa2/eth: Add TODO file

Add a list of TODO items for the Ethernet driver Signed-off-by: Ioana Radulescu --- v3: Add contact info v2: Add note drivers/staging/fsl-dpaa2/ethernet/TODO | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 drivers/staging/fsl-dpaa2/ethernet/TODO diff --git a/drivers

[PATCH v3 9/9] staging: fsl-dpaa2/eth: Add maintainer for Ethernet driver

Signed-off-by: Ioana Radulescu --- v3: no changes v2: Remove "Freescale" from the driver name MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b38b42f96e6a..4368f67bb261 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4109,6 +41

[PATCH v3 2/9] staging: fsl-dpaa2/eth: Add Ethernet driver overview document

Add a README file describing the driver architecture, components and I/O interface. Signed-off-by: Ioana Radulescu --- v3: no changes v2: no changes drivers/staging/fsl-dpaa2/ethernet/README | 186 ++ 1 file changed, 186 insertions(+) create mode 100644 drivers

[PATCH v3 7/9] staging: fsl-dpaa2/eth: Add trace points

Add trace events in significant places of the data path. Useful for debuggging. Signed-off-by: Ioana Radulescu --- v3: no changes v2: no changes drivers/staging/fsl-dpaa2/ethernet/Makefile| 3 + .../staging/fsl-dpaa2/ethernet/dpaa2-eth-trace.h | 185 + drivers

[PATCH v3 6/9] staging: fsl-dpaa2/eth: Add driver specific stats

Add custom statistics to be reported via ethtool -S. These include driver specific per-cpu statistics as well as queue and channel counters. Signed-off-by: Ioana Radulescu --- v3: no changes v2: no changes drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 42 ++- drivers

[PATCH v3 5/9] staging: fsl-dpaa2/eth: Add ethtool support

Add support for several ethtool operations: show hardware statistics, get/set link settings, get hash configuration. Signed-off-by: Ioana Radulescu Signed-off-by: Bogdan Hamciuc --- v3: no changes v2: no changes drivers/staging/fsl-dpaa2/ethernet/Makefile| 2 +- drivers/staging/fsl

[PATCH v3 3/9] staging: fsl-dpaa2/eth: Add APIs for DPNI objects

Add the command build/parse APIs for operating on DPNI objects through the DPAA2 Management Complex. Signed-off-by: Ioana Radulescu --- v3: no changes v2: update #include paths drivers/staging/Kconfig |2 + drivers/staging/Makefile |1

[PATCH v3 4/9] staging: fsl-dpaa2/eth: Add Freescale DPAA2 Ethernet driver

(DPCONs). A more detailed description of the driver can be found in the associated README file. Signed-off-by: Ioana Radulescu Signed-off-by: Bogdan Hamciuc --- v3: no changes v2: - update #include paths - ndo_get_stats64() now returns void - skb_csum_off_chk_help_cmn() was removed in 4.10, so we

[PATCH v3 1/9] bus: fsl-mc: add DPCON object APIs

From: Ioana Radulescu This patch adds the command building/parsing wrapper functions for the DPCON object. The binary interface version is v3.2. A DPCON (DataPath Concentrator) is an aggregator object that allows ingress frames from multiple hardware queues to be seen as coming from a single

[PATCH] staging: fsl-mc/dpio: Fix early writing of valid bit

n in the swp command registers, after all other fields are filled in. The current implementation doesn't follow this rule for all commands, which may result in an incompletely configured command being processed by the hardware. Enforce the correct order of writes to avoid this situation. Signe

[PATCH v2 7/9] staging: fsl-dpaa2/eth: Add trace points

Add trace events in significant places of the data path. Useful for debuggging. Signed-off-by: Ioana Radulescu --- v2: no changes drivers/staging/fsl-dpaa2/ethernet/Makefile| 3 + .../staging/fsl-dpaa2/ethernet/dpaa2-eth-trace.h | 185 + drivers/staging/fsl

[PATCH v2 9/9] staging: fsl-dpaa2/eth: Add maintainer for Ethernet driver

Signed-off-by: Ioana Radulescu --- v2: Remove "Freescale" from the driver name MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b38b42f96e6a..4368f67bb261 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4109,6 +4109,12 @@ L:

[PATCH v2 1/9] bus: fsl-mc: add DPCON object APIs

From: Ioana Radulescu This patch adds the command building/parsing wrapper functions for the DPCON object. The binary interface version is v3.2. A DPCON (DataPath Concentrator) is an aggregator object that allows ingress frames from multiple hardware queues to be seen as coming from a single

[PATCH v2 8/9] staging: fsl-dpaa2/eth: Add TODO file

Add a list of TODO items for the Ethernet driver Signed-off-by: Ioana Radulescu --- v2: Add note drivers/staging/fsl-dpaa2/ethernet/TODO | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 drivers/staging/fsl-dpaa2/ethernet/TODO diff --git a/drivers/staging/fsl-dpaa2

[PATCH v2 0/9] staging: Introduce the DPAA2 Ethernet driver

updates in patch #4 due to networking API changes Ioana Radulescu (9): bus: fsl-mc: add DPCON object APIs staging: fsl-dpaa2/eth: Add Ethernet driver overview document staging: fsl-dpaa2/eth: Add APIs for DPNI objects staging: fsl-dpaa2/eth: Add Freescale DPAA2 Ethernet driver staging: fsl

[PATCH v2 3/9] staging: fsl-dpaa2/eth: Add APIs for DPNI objects

Add the command build/parse APIs for operating on DPNI objects through the DPAA2 Management Complex. Signed-off-by: Ioana Radulescu --- v2: update #include paths drivers/staging/Kconfig |2 + drivers/staging/Makefile |1 + drivers/staging/fsl

[PATCH v2 4/9] staging: fsl-dpaa2/eth: Add Freescale DPAA2 Ethernet driver

(DPCONs). A more detailed description of the driver can be found in the associated README file. Signed-off-by: Ioana Radulescu Signed-off-by: Bogdan Hamciuc --- v2: - update #include paths - ndo_get_stats64() now returns void - skb_csum_off_chk_help_cmn() was removed in 4.10, so we go back to

[PATCH v2 6/9] staging: fsl-dpaa2/eth: Add driver specific stats

Add custom statistics to be reported via ethtool -S. These include driver specific per-cpu statistics as well as queue and channel counters. Signed-off-by: Ioana Radulescu --- v2: no changes drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 42 ++- drivers/staging/fsl-dpaa2

[PATCH v2 5/9] staging: fsl-dpaa2/eth: Add ethtool support

Add support for several ethtool operations: show hardware statistics, get/set link settings, get hash configuration. Signed-off-by: Ioana Radulescu Signed-off-by: Bogdan Hamciuc --- v2: no changes drivers/staging/fsl-dpaa2/ethernet/Makefile| 2 +- drivers/staging/fsl-dpaa2/ethernet

[PATCH v2 2/9] staging: fsl-dpaa2/eth: Add Ethernet driver overview document

Add a README file describing the driver architecture, components and I/O interface. Signed-off-by: Ioana Radulescu --- v2: no changes drivers/staging/fsl-dpaa2/ethernet/README | 186 ++ 1 file changed, 186 insertions(+) create mode 100644 drivers/staging/fsl-dpaa2

[PATCH 2/2] staging: fsl-dpaa2/eth: Map Tx buffers as bidirectional

Gupta Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c index 3fee0d6f17e0..49c435bad706

[PATCH 1/2] staging: fsl-dpaa2/eth: Fix address translations

Use the correct mechanisms for translating a DMA-mapped IOVA address into a virtual one. Without this fix, once SMMU is enabled on Layerscape platforms, the Ethernet driver throws IOMMU translation faults. Signed-off-by: Nipun Gupta Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2

[PATCH] staging: fsl-dpaa2/eth: Remove dead code

All possible values of the switch statement are explicitly handled, so there's no need to have a default branch. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/

[PATCH] staging: fsl-dpaa2/eth: Defer probing if no MC portal available

MC portals may not be available at the initial probing attempt due to dependencies on other modules. Check the return value of the MC portal allocation function and defer probing in case it's not available yet. For all other error cases the behaviour stays the same. Signed-off-by:

[PATCH 4/4] staging: fsl-dpaa2/eth: allow the driver to compile multi-arch

CONFIG_OF) - arm64 (defconfig) Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-dpaa2/Kconfig b/drivers/staging/fsl-dpaa2/Kconfig index dfff675..730fd6d 100644 --- a/drivers/staging/fsl-dpaa2

[PATCH 2/4] staging: fsl-mc/dpio: allow the driver to compile multi-arch

CONFIG_OF) - arm64 (defconfig) Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-mc/bus/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/Kconfig b/drivers/staging/fsl-mc/bus/Kconfig index 5f4115d..3424530 100644 --- a/drivers/staging/fsl-mc

[PATCH 0/4] staging: fsl-mc/dpio, fsl-dpaa2/eth: Enable multi-arch compile

The DPAA2 DPIO and Ethernet drivers need only a couple of small fixes in order to compile correctly for 32b platforms. Update the drivers and remove ARCH_LAYERSCAPE from their Kconfig dependencies. Ioana Radulescu (4): staging: fsl-mc/dpio: Fix incorrect casts staging: fsl-mc/dpio: allow the

[PATCH 3/4] staging: fsl-dpaa2/eth: Fix incorrect casts

The DPAA2 Ethernet driver incorrectly assumes virtual addresses are always 64b long, which causes compiler errors when building for a 32b platform. Fix this by using explicit casts to uintptr_t where necessary. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c

[PATCH 1/4] staging: fsl-mc/dpio: Fix incorrect casts

The DPIO driver incorrectly assumes virtual addresses are always 64b long, which causes compiler errors when building for a 32b platform. Fix this by using explicit casts to uintptr_t where necessary. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 4

[PATCH 1/2] staging: fsl-dpaa2/eth: Flow affinity for IP forwarding

in the skb. In case of forwarded frames, this info will then be used for Tx and Tx confirmation hardware queue selection, ensuring all processing of the given frame is done on a single core. Signed-off-by: Bogdan Purcareata Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet

[PATCH 2/2] staging: fsl-dpaa2/eth: Flow affinity for non-forwarded traffic

netdevice queue affinity to the sending core. Signed-off-by: Bogdan Purcareata Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b

[PATCH 01/18] staging: fsl-dpaa2/eth: Add "static" keyword where needed

Make a couple of locally used functions and structures static. Issue found through static analysis tool. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 6 +++--- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 2 -- drivers/staging/fsl-dpaa2

[PATCH 02/18] staging: fsl-dpaa2/eth: Initialize variable before use

In dpni_get_irq_status(), status is both in and out parameter, so initialize before use. Issue found through static analysis tool. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 17/18] staging: fsl-dpaa2/eth: Refactor MAC address setup

The driver logic for allocating a MAC address to a net device is complicated enough to deserve a function of its own. While here, cleanup a bit the code comments. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 46 -- 1 file changed

[PATCH 10/18] staging: fsl-dpaa2/eth: Defer probing if no DPIOs found

If the Ethernet driver doesn't find any DPIO devices during probe, it may be either because there's none available or because they haven't been probed yet. Request deferred probing in case it's the latter. Signed-off-by: Bharat Bhushan Signed-off-by: Ioana Radulescu ---

[PATCH 11/18] staging: fsl-dpaa2/eth: Update ethtool stats names

Add a label to the ethtool statistics counters, to differentiate between hardware counters and driver specific ones. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 54 +++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a

[PATCH 12/18] staging: fsl-dpaa2/eth: Add accessor for FAS field

Introduce a helper macro for accessing the frame annotation status field in a frame buffer. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 31 -- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 6 + 2 files changed, 20

[PATCH 09/18] staging: fsl-dpaa2/eth: Reset dpbp

Reset the buffer pool object before using it, like we do for the other DPAA2 objects. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging

[PATCH 03/18] staging: fsl-dpaa2/eth: Fix return type of ndo_start_xmit

ndo_start_xmit() returns a value of type netdev_tx_t. Update our ndo function to use the correct type. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2

[PATCH 05/18] staging: fsl-dpaa2/eth: Add error message newlines

A few error/warning messages lacked a newline at the end of the text. Add it for improved consistency and cosmetics. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 14 +++--- drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 6 +++--- 2 files

[PATCH 14/18] staging: fsl-dpaa2/eth: Only store bpid in priv struct

We only need to know the buffer pool id, so save exactly that in the device's private structure, instead of the entire DPBP attributes struct. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 12 +++- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h

[PATCH 08/18] staging: fsl-dpaa2/eth: Always call napi_gro_receive()

The function itself checks whether GRO support is enabled and acts accordingly, so we don't need to verify it in the driver as well. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/dr

[PATCH 07/18] staging: fsl-dpaa2/eth: Don't use GFP_DMA

Don't use GFP_DMA when allocating memory for the hash key, as we don't actually need to allocate from the lowest zone. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 00/18] staging: fsl-dpaa2/eth: Code cleanup and minor fixes

This patch series contains fixes for a few minor bugs and code cleanup and cosmetics. No significant functional changes. Ioana Radulescu (18): staging: fsl-dpaa2/eth: Add "static" keyword where needed staging: fsl-dpaa2/eth: Initialize variable before use staging: fsl-dpaa2/eth:

[PATCH 06/18] staging: fsl-dpaa2/eth: Minor cleanup in dpaa2_eth_set_hash

We already have a variable for the DMA mapping device, so use that directly. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers

[PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields

Reorder fields in the device's private structure such that the ones most used on the hotpath are at the beginning of the structure. This brings a small performance improvement due to better cache usage. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h

[PATCH 16/18] staging: fsl-dpaa2/eth: Errors checking update

On the egress path, frame errors are reported using both a FD control field and the frame annotation status. The current code only handles FAS errors. Update to look at both fields when accounting Tx errors. Signed-off-by: Bogdan Purcareata Signed-off-by: Ioana Radulescu --- Note: Checkpatch

  1   2   >