Re: [1/2] PCI-Express Non-Transparent Bridge Support

Hi, it's good to see some NTB code getting into mainline! I have a few comments though. On Tue, 02 Oct 2012 21:26:16 -, Jon Mason jon.ma...@intel.com wrote: [...] +/** + * ntb_write_local_spad() - write to the secondary scratchpad register + * @ndev: pointer to ntb_device instance + * @idx:

[PATCH] fix kerneldoc of request_firmware_direct()

Fix trivial copy/paste error. Signed-off-by: Jakub Kicinski kubak...@wp.pl --- drivers/base/firmware_class.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index 58470c3..96d994a 100644 --- a/drivers/base

Re: [PATCH v2 23/27] rt2x00: move under ralink vendor directory

On Wed, 18 Nov 2015 16:46:02 +0200, Kalle Valo wrote: > Part of reorganising wireless drivers directory and Kconfig. > > Signed-off-by: Kalle Valo For Ralink you could probably drop the rt2x00 directory. RaLink Tech. doesn't exist any more and rt2x00 contains drivers for

[PATCH 1/2] add basic register-field manipulation macros

s standard Linux and GCC functions such as is_power_of_2() and __builtin_ffsll(). Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- include/linux/bitfield.h | 58 include/linux/log2.h | 6 + 2 files changed, 64 inserti

[PATCH 2/2] mt7601u: use linux/bitfield.h

Use the newly added linux/bitfield.h. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/wireless/mediatek/mt7601u/dma.h | 2 - drivers/net/wireless/mediatek/mt7601u/mt7601u.h | 5 +- drivers/net/wireless/mediatek/mt7601u/util.h

[PATCHv2 2/2] mt7601u: use linux/bitfield.h

Use the newly added linux/bitfield.h. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/wireless/mediatek/mt7601u/dma.h | 2 - drivers/net/wireless/mediatek/mt7601u/mt7601u.h | 5 +- drivers/net/wireless/mediatek/mt7601u/util.h

[PATCHv2 0/2] register-field manipulation macros

ew and advise on improvements. If accepted I think would be best to push this through Kalle's tree, since the only existing user is in drivers/net/wireless/. v2: - change Felix's email address. Jakub Kicinski (2): add basic register-field manipulation macros mt7601u: use linux/bitfield.h drivers

[PATCHv2 1/2] add basic register-field manipulation macros

s standard Linux and GCC functions such as is_power_of_2() and __builtin_ffsll(). Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- v2: - change Felix's email address. include/linux/bitfield.h | 58 include/linux/log2.h |

[PATCH 0/2] register-field manipulation macros

ew and advise on improvements. If accepted I think would be best to push this through Kalle's tree, since the only existing user is in drivers/net/wireless/. Jakub Kicinski (2): add basic register-field manipulation macros mt7601u: use linux/bitfield.h drivers/net/wireless/mediatek/mt7601u/d

Re: [PATCHv2 1/2] add basic register-field manipulation macros

On Tue, 14 Jun 2016 20:53:28 +0200, Arend van Spriel wrote: > On 14-06-16 13:44, Jakub Kicinski wrote: > > +#ifndef _LINUX_BITFIELD_H > > +#define _LINUX_BITFIELD_H > > + > > +#include > > +#include > > +#include > > + > > +#define _bf

Re: [PATCHv5 wl-drv-next 0/2] register-field manipulation macros

On Wed, 6 Jul 2016 17:19:35 +0100, Jakub Kicinski wrote: > Hi! > > I've added few lines about the compilation problems in > the commit message of patch 1. I would prefer the mass > rename of macros in mt7601u not to be part of this series > so patch 2 is left as it was and I

Re: [PATCHv5 wl-drv-next 0/2] register-field manipulation macros

On Tue, 26 Jul 2016 16:00:04 +0300, Kalle Valo wrote: > Jakub Kicinski <jakub.kicin...@netronome.com> writes: > > > On Wed, 6 Jul 2016 17:19:35 +0100, Jakub Kicinski wrote: > >> Hi! > >> > >> I've added few lines about the compilation problems in

[PATCHv4 wl-drv-next 0/2] register-field manipulation macros

epted I think would be best to push this through Kalle's tree, since the only existing user is in drivers/net/wireless/. v4: - add documentation in the header. v3: - don't use variables in statement expressions; - use __BUILD_BUG_ON_NOT_POWER_OF_2. v2: - change Felix's email address. Jakub Kicins

[PATCHv4 wl-drv-next 2/2] mt7601u: use linux/bitfield.h

Use the newly added linux/bitfield.h. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/wireless/mediatek/mt7601u/dma.h | 2 - drivers/net/wireless/mediatek/mt7601u/mt7601u.h | 5 +- drivers/net/wireless/mediatek/mt7601u/util.h

[PATCHv4 wl-drv-next 1/2] add basic register-field manipulation macros

t convenient I've seen so to limit code multiplication let's move the macros to a global header file. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- include/linux/bitfield.h | 109 +++ include/linux/bug.h | 3 ++ 2 files

Re: [PATCHv3 wl-drv-next 1/2] add basic register-field manipulation macros

On Tue, 5 Jul 2016 10:56:13 +, David Laight wrote: > From: Jakub Kicinski > > Sent: 01 July 2016 22:27 > > > > C bitfields are problematic and best avoided. Developers > > interacting with hardware registers find themselves searching > > for easy-to-u

[PATCHv5 wl-drv-next 2/2] mt7601u: use linux/bitfield.h

Use the newly added linux/bitfield.h. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/wireless/mediatek/mt7601u/dma.h | 2 - drivers/net/wireless/mediatek/mt7601u/mt7601u.h | 5 +- drivers/net/wireless/mediatek/mt7601u/util.h

[PATCHv5 wl-drv-next 1/2] add basic register-field manipulation macros

t convenient I've seen so to limit code multiplication let's move the macros to a global header file. Attempts to use static inlines instead of macros failed due to false positive triggering of BUILD_BUG_ON()s, especially with GCC < 6.0. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.

[PATCHv5 wl-drv-next 0/2] register-field manipulation macros

Kalle's tree, since the only existing user is in drivers/net/wireless/. v4: - add documentation in the header. v3: - don't use variables in statement expressions; - use __BUILD_BUG_ON_NOT_POWER_OF_2. v2: - change Felix's email address. Jakub Kicinski (2): add basic register-field manipu

[PATCHv3 wl-drv-next 2/2] mt7601u: use linux/bitfield.h

Use the newly added linux/bitfield.h. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/wireless/mediatek/mt7601u/dma.h | 2 - drivers/net/wireless/mediatek/mt7601u/mt7601u.h | 5 +- drivers/net/wireless/mediatek/mt7601u/util.h

[PATCHv3 wl-drv-next 0/2] register-field manipulation macros

epted I think would be best to push this through Kalle's tree, since the only existing user is in drivers/net/wireless/. v3: - don't use variables in statement expressions; - use __BUILD_BUG_ON_NOT_POWER_OF_2. v2: - change Felix's email address. Jakub Kicinski (2): add basic register-field manipu

[PATCHv3 wl-drv-next 1/2] add basic register-field manipulation macros

be used to define registers (which is usually less error-prone and easier to match with datasheets). This approach is the most convenient I've seen so to limit code multiplication let's move the macros to a global header file. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.co

Re: [PATCHv6 1/2] add basic register-field manipulation macros

On Wed, 17 Aug 2016 09:33:26 -0700, Linus Torvalds wrote: > On Wed, Aug 17, 2016 at 3:31 AM, Kalle Valo wrote: > > > > Are people ok with this? I think they are useful and I can take these > > through my tree, but I would prefer to get an ack from other maintainers > >

Re: [PATCHv2] firmware: Correct handling of fw_state_wait_timeout() return value

On Tue, Jan 17, 2017 at 8:21 AM, Luis R. Rodriguez wrote: >>> >>> retval = fw_state_wait_timeout(>fw_st, timeout); >>> - if (retval < 0) { >>> + if (retval == -ETIMEDOUT || retval == -ERESTARTSYS) { >>> mutex_lock(_lock); >>>

[PATCHv2] firmware: Correct handling of fw_state_wait_timeout() return value

tate_wait() return value") Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- v2: - improve commit message. --- drivers/base/firmware_class.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/firmware_class.c b/drivers/base/firmwa

Re: [PATCHv2] firmware: Correct handling of fw_state_wait_timeout() return value

On Tue, Jan 17, 2017 at 9:30 AM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > On Tue, Jan 17, 2017 at 08:30:37AM -0800, Jakub Kicinski wrote: >> On Tue, Jan 17, 2017 at 8:21 AM, Luis R. Rodriguez <mcg...@kernel.org> wrote: >> >>> >> >>>

Re: [PATCHv2] firmware: Correct handling of fw_state_wait_timeout() return value

On Tue, Jan 17, 2017 at 12:53 PM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > On Tue, Jan 17, 2017 at 10:04:20AM -0800, Jakub Kicinski wrote: >> On Tue, Jan 17, 2017 at 9:30 AM, Luis R. Rodriguez <mcg...@kernel.org> wrote: >> > On Tue, Jan 17, 2017 at 08:30:37

[PATCH driver-core/master] firmware: Correct handling of fw_state_wait_timeout() return value

otherwise the waking thread had already cleaned up for us. Fixes: 5d47ec02c37e ("firmware: Correct handling of fw_state_wait() return value") Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/base/firmware_class.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH driver-core/master] firmware: Correct handling of fw_state_wait_timeout() return value

On Mon, Jan 16, 2017 at 10:29 AM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > On Mon, Jan 16, 2017 at 02:57:06PM +0000, Jakub Kicinski wrote: >> Commit 5d47ec02c37e ("firmware: Correct handling of fw_state_wait() >> return value") made the assumpti

[RFC (v7)] add basic register-field manipulation macros

from bug.h by separating panic-related definitions into a new header. There were still cycles coming from the notifier.h which I had to include for panic notifier... Reviewed-by: Dinan Gunawardena <dinan.gunaward...@netronome.com> Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.

[PATCHv6 1/2] add basic register-field manipulation macros

t convenient I've seen so to limit code multiplication let's move the macros to a global header file. Attempts to use static inlines instead of macros failed due to false positive triggering of BUILD_BUG_ON()s, especially with GCC < 6.0. Signed-off-by: Jakub Kicinski <jakub.kicin...@netro

[PATCHv6 2/2] mt7601u: use linux/bitfield.h

Use the newly added linux/bitfield.h. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> Reviewed-by: Dinan Gunawardena <dinan.gunaward...@netronome.com> --- drivers/net/wireless/mediatek/mt7601u/dma.c | 2 +- drivers/net/wireless/mediatek/mt7601u/dma.h | 10 ++--

[PATCHv6 0/2] register-field manipulation macros

a full rename in patch 2. CC many people. v4: - add documentation in the header. v3: - don't use variables in statement expressions; - use __BUILD_BUG_ON_NOT_POWER_OF_2. v2: - change Felix's email address. Jakub Kicinski (2): add basic register-field manipulation macros mt7601u: use linux/bitfiel

Re: [PATCH] nfp: bpf: improve handling for disabled BPF syscall

("nfp: bpf: add hardware bpf offload") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks Arnd! static inline definitely missing there but if we can depend on dead code elimination to remove the symbol that's even cooler! Acked-by: Jakub Kicinski <jakub.kicin...@netronome.com>

Re: [PATCH net-next resend 10/13] debugfs: constify argument to debugfs_real_fops()

On Thu, 10 Nov 2016 15:25:59 +0100, Greg Kroah-Hartman wrote: > On Thu, Nov 03, 2016 at 05:12:06PM +0000, Jakub Kicinski wrote: > > seq_file users can only access const version of file pointer, > > because the ->file member of struct seq_operations is marked > >

Re: [PATCH] ARM: fix kmemleak for XIP_KERNEL

On Tue, Nov 22, 2016 at 6:28 AM, Arnd Bergmann wrote: > The newly added check for RO_AFTER_INIT_DATA in kmemleak breaks ARM whenever > XIP_KERNEL is enabled: > > mm/kmemleak.o: In function `kmemleak_scan': > kmemleak.c:(.text.kmemleak_scan+0x2e4): undefined reference to >

Re: [PATCH] userns: suppress kmemleak message

x2a/0x40t show > [] 0x > > Let's annotate the pointer as kmemleak_not_leak() to suppress the > kmemleak false positive. > > Reported-by: Jakub Kicinski <kubak...@wp.pl> > Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com>

Re: [PATCH] userns: suppress kmemleak message

On Thu, 03 Nov 2016 09:54:25 -0500, Eric W. Biederman wrote: > Dmitry Torokhov writes: > > > We do not ever intend to unregister "user" sysctl table, unfortunately > > it leads kmemleak to believe that we are leaking memory: > > Sounds like an issue with kmemleak

[PATCH net-next resend 10/13] debugfs: constify argument to debugfs_real_fops()

stian Lamparter <chunk...@gmail.com> CC: LKML <linux-kernel@vger.kernel.org> Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- include/linux/debugfs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/debugfs.h b/include/l

[RFC] make kmemleak scan __ro_after_init section (was: Re: [PATCH 0/5] genetlink improvements)

On Wed, 2 Nov 2016 13:30:34 -0700, Cong Wang wrote: > On Tue, Nov 1, 2016 at 11:56 AM, Jakub Kicinski <kubak...@wp.pl> wrote: > > On Tue, 1 Nov 2016 11:32:52 -0700, Cong Wang wrote: > >> On Tue, Nov 1, 2016 at 10:28 AM, Jakub Kicinski <kubak...@wp.pl> wrote

[PATCH] mm: kmemleak: scan .data.ro_after_init

_init"). Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> Reviewed-by: Catalin Marinas <catalin.mari...@arm.com> --- Since the RFC I dropped the use of VMLINUX_SYMBOL(). Please advise if it should be added back. --- arch/s390/kernel/vmlinux.lds.S| 2 ++ include/asm-gen

Re: [PATCH] sc16is7xx: Drop bogus use of IRQF_ONESHOT

ml could be beneficial but this is definitely a step in the right direction! Acked-by: Jakub Kicinski <kubak...@wp.pl> Thanks a lot Julia!

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

On Fri, 7 Oct 2016 22:04:34 -0400, Jarod Wilson wrote: > @@ -357,6 +356,8 @@ void ether_setup(struct net_device *dev) > dev->type = ARPHRD_ETHER; > dev->hard_header_len= ETH_HLEN; > dev->mtu= ETH_DATA_LEN; > + dev->min_mtu=

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

On Mon, 17 Oct 2016 12:49:54 -0400 (EDT), David Miller wrote: > From: Jakub Kicinski <kubak...@wp.pl> > Date: Mon, 17 Oct 2016 17:20:06 +0100 > > > Please correct me if I'm wrong but it seems like we are now limiting > > _all_ ethernet drivers to ETH_DATA_LEN in n

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

On Mon, 17 Oct 2016 18:00:27 +0100, Jakub Kicinski wrote: > On Mon, 17 Oct 2016 12:49:54 -0400 (EDT), David Miller wrote: > > From: Jakub Kicinski <kubak...@wp.pl> > > Date: Mon, 17 Oct 2016 17:20:06 +0100 > > > > > Please correct me if I'm wrong b

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

On Mon, 17 Oct 2016 13:15:13 -0400 (EDT), David Miller wrote: > From: Jakub Kicinski <kubak...@wp.pl> > Date: Mon, 17 Oct 2016 18:00:27 +0100 > > > On Mon, 17 Oct 2016 12:49:54 -0400 (EDT), David Miller wrote: > >> From: Jakub Kicinski <kubak...@wp.pl> > &

Re: [PATCH net-next 03/15] ethernet/intel: use core min/max MTU checking

Looks better, unfortunately, I can't test since net-next also seem to make nfs implode on my setup. On Mon, 17 Oct 2016 15:54:05 -0400, Jarod Wilson wrote: > @@ -7187,6 +7180,11 @@ static int e1000_probe(struct pci_dev *pdev, const > struct pci_device_id *ent) >

Re: [PATCH v3] add equivalent of BIT(x) for bitfields

On Wed, 7 Dec 2016 14:51:36 +0100, Sebastian Frias wrote: > On 07/12/16 13:38, Jakub Kicinski wrote: > > On Wed, 7 Dec 2016 12:23:56 +0100, Sebastian Frias wrote: > >> On 07/12/16 12:05, Jakub Kicinski wrote: > >>> On Wed, 7 Dec 2016 11:00:57 +0100, Sebastian Fr

Re: [PATCH v3] add equivalent of BIT(x) for bitfields

On Wed, 7 Dec 2016 11:00:57 +0100, Sebastian Frias wrote: > On 07/12/16 09:42, Kalle Valo wrote: > > Sebastian Frias writes: > > > >> Introduce GENVALUE(msb, lsb, value) macro to ease dealing with > >> continuous bitfields, just as BIT(x) does for single bits. > >> > >>

Re: [PATCH v3] add equivalent of BIT(x) for bitfields

On Wed, 7 Dec 2016 12:23:56 +0100, Sebastian Frias wrote: > On 07/12/16 12:05, Jakub Kicinski wrote: > > On Wed, 7 Dec 2016 11:00:57 +0100, Sebastian Frias wrote: > >> On 07/12/16 09:42, Kalle Valo wrote: > >>> Sebastian Frias <s...@laposte.net> writes: >

[PATCH driver-core] debugfs: improve formatting of debugfs_real_fops()

Type of debugfs_real_fops() is longer than parameters and the name, so there is no way to break the declaration nicely. We have to go over 80 characters. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- include/linux/debugfs.h | 3 +-- 1 file changed, 1 insertion(+), 2 del

4.10-rc3, firmware loading via user space helper crashes if firmware not present

Hi! If one requests a FW which does not exist in the FS and the user space helper is used then fw_load_abort() will be called twice which leads to NULL-deref. It will be called once in firmware_loading_store() (handling the -1 case) and then again in _request_firmware_load() because return value

Re: 4.10-rc3, firmware loading via user space helper crashes if firmware not present

On Fri, 13 Jan 2017 13:32:58 -0800, Jakub Kicinski wrote: > If one requests a FW which does not exist in the FS and the user space > helper is used then fw_load_abort() will be called twice which leads to > NULL-deref. > > It will be called once in firmware_loading_store() (handlin

Re: [net-next PATCH v2 5/6] i40e: Add TX and RX support in switchdev mode.

On Thu, Jan 5, 2017 at 12:08 PM, Or Gerlitz wrote: > On Tue, Jan 3, 2017 at 8:07 PM, Sridhar Samudrala > wrote: >> A host based switching entity like a linux bridge or OVS redirects these >> frames >> to the right VFs via VFPR netdevs. Any

Re: [PATCH] mm: fix section name for .data..ro_after_init

ro_after_init") > > The latter adds incorrect wrapping around the existing s390 section, > and came later. I'd prefer the s390 naming, so this moves the > s390-specific name up to the asm-generic/sections.h and renames the > section as used by kmemleak (and in the future,

Re: [PATCH 1/1] mt7601u: check return value of alloc_skb

Bian <bianpan2...@163.com> Acked-by: Jakub Kicinski <kubak...@wp.pl> Thanks!

Re: [PATCH][-next] nfp: don't dereference a null nn->eth_port to print a warning

n printing the > warning message. > > Detected by CoverityScan, CID#1426198 ("Dereference after null check") > > Fixes: ce22f5a2cbe3c627 ("nfp: separate high level and low level NSP headers") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Jakub Kicinski <jakub.kicin...@netronome.com> Thanks!

Re: [PATCH net-next V2 3/3] tap: XDP support

On Fri, 11 Aug 2017 19:41:18 +0800, Jason Wang wrote: > This patch tries to implement XDP for tun. The implementation was > split into two parts: > > - fast path: small and no gso packet. We try to do XDP at page level > before build_skb(). For XDP_TX, since creating/destroying queues > were

[PATCH net] jhash: fix -Wimplicit-fallthrough warnings

GCC 7 added a new -Wimplicit-fallthrough warning. It's only enabled with W=1, but since linux/jhash.h is included in over hundred places (including other global headers) it seems worthwhile fixing this warning. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- If it look

Re: [PATCH] aic7xxx: fix firmware build with O=path

On Tue, 18 Jul 2017 21:45:49 -0400, Martin K. Petersen wrote: > Jakub, > > > I just noticed this patch got marked as "Deferred, archived" in > > patchwork. I'm not entirely sure by whom and why? Could someone > > explain what is the issue? I would really appreciate if we could > > merge this

Re: [PATCH] aic7xxx: fix firmware build with O=path

On Wed, 28 Jun 2017 21:17:16 -0700, Jakub Kicinski wrote: > Building firmware with O=path was apparently broken in aic7 for ever. > Message of the previous commit to the Makefile (from 2008) mentions > this unfortunate state of affairs already. Fix this, mostly to make > randconfig

Re: [PATCH v3 net-next 03/12] nfp: change bpf verifier hooks to match new verifier data structures

On Tue, 27 Jun 2017 13:57:34 +0100, Edward Cree wrote: > Signed-off-by: Edward Cree <ec...@solarflare.com> Acked-by: Jakub Kicinski <jakub.kicin...@netronome.com> Sorry about the delay.

[PATCH] aic7xxx: fix firmware build with O=path

Building firmware with O=path was apparently broken in aic7 for ever. Message of the previous commit to the Makefile (from 2008) mentions this unfortunate state of affairs already. Fix this, mostly to make randconfig builds more reliable. Signed-off-by: Jakub Kicinski <jakub.ki

[PATCH] hashtable: remove repeated phrase from a comment

"in a rcu enabled hashtable" is repeated twice in a comment. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- I'm not sure who would take this :S include/linux/hashtable.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/hashtable.h b/include/l

Re: [PATCH 2/4] swait: add the missing killable swaits

On Thu, 29 Jun 2017 21:44:55 +0200, Luis R. Rodriguez wrote: > On Thu, Jun 29, 2017 at 09:40:15PM +0200, Luis R. Rodriguez wrote: > > On Thu, Jun 29, 2017 at 11:59:29AM -0700, Linus Torvalds wrote: > > > On Thu, Jun 29, 2017 at 11:33 AM, Davidlohr Bueso > > > wrote: > > >

Re: [PATCH 2/4] swait: add the missing killable swaits

On Fri, 30 Jun 2017 00:50:03 +0200, Luis R. Rodriguez wrote: > On Thu, Jun 29, 2017 at 01:58:22PM -0700, Jakub Kicinski wrote: > > On Thu, 29 Jun 2017 21:44:55 +0200, Luis R. Rodriguez wrote: > > > > Since this swake_up() --> swake_up_all() reportedly *fixed*

Re: [PATCH 2/4] swait: add the missing killable swaits

On Thu, 29 Jun 2017 16:00:32 -0700, Luis R. Rodriguez wrote: > On Thu, Jun 29, 2017 at 3:53 PM, Jakub Kicinski > <jakub.kicin...@netronome.com> wrote: > > On Fri, 30 Jun 2017 00:50:03 +0200, Luis R. Rodriguez wrote: > >> On Thu, Jun 29, 2017 at 01:58:22PM

Re: 'skb' buffer address information leakage

On Tue, 4 Jul 2017 13:12:18 +0800, Dison River wrote: > drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c:167 > seq_printf(file, " frag=%p", skb); FWIW that's actually not a skb pointer. The structure is defined like this: struct nfp_net_tx_buf { union {

Re: [PATCH] aic7xxx: fix firmware build with O=path

On Wed, 28 Jun 2017 21:17:16 -0700, Jakub Kicinski wrote: > Building firmware with O=path was apparently broken in aic7 for ever. > Message of the previous commit to the Makefile (from 2008) mentions > this unfortunate state of affairs already. Fix this, mostly to make > randconfig

Re: [PATCH] firmware: wake all waiters

On Tue, 27 Jun 2017 18:39:42 +0200, Luis R. Rodriguez wrote: > On Mon, Jun 26, 2017 at 07:10:09PM -0700, Jakub Kicinski wrote: > > On Mon, 26 Jun 2017 23:20:36 +0200, Luis R. Rodriguez wrote: > > > > In that case we will make them all use the same struct firmware_buf.

Re: [PATCH] firmware: wake all waiters

On Wed, 28 Jun 2017 00:24:19 +0200, Luis R. Rodriguez wrote: > On Tue, Jun 27, 2017 at 02:25:53PM -0700, Jakub Kicinski wrote: > > On Tue, 27 Jun 2017 18:39:42 +0200, Luis R. Rodriguez wrote: > > > > > > > The problem is that advanced NICs are quite programm

Re: [PATCH net-next 3/3] tap: XDP support

On Thu, 27 Jul 2017 17:25:33 +0800, Jason Wang wrote: > This patch tries to implement XDP for tun. The implementation was > split into two parts: > > - fast path: small and no gso packet. We try to do XDP at page level > before build_skb(). For XDP_TX, since creating/destroying queues > were

Re: [PATCH v2] net: inet: diag: expose sockets cgroup classid

On Thu, 27 Jul 2017 18:11:32 +, Levin, Alexander (Sasha Levin) wrote: > This is useful for directly looking up a task based on class id rather than > having to scan through all open file descriptors. > > Signed-off-by: Sasha Levin > --- > > Changes in V2: > -

Re: [PATCH net-next 3/3] tap: XDP support

On Fri, 28 Jul 2017 06:46:40 +0300, Michael S. Tsirkin wrote: > On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: > > > > + old_prog = rtnl_dereference(tun->xdp_prog); > > > > + if (old_prog) > > > > + bpf_prog_put(old_prog); > > > > +

Re: [oss-drivers] [PATCH] nfp: fix infinite loop on umapping cleanup

tected by CoverityScan, CID#1357309 ("Infinite loop") > > Fixes: 4c3523623dc0 ("net: add driver for Netronome NFP4000/NFP6000 NIC VFs") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Jakub Kicinski <jakub.kicin...@netronome.com> Thanks!

Re: [PATCH v5 15/17] dt-bindings: qca7000: append UART interface to binding

On Thu, 11 May 2017 21:12:22 +0200, Michael Heimpold wrote: > Am Mittwoch, 10. Mai 2017, 10:53:26 CEST schrieb Stefan Wahren: > > This merges the serdev binding for the QCA7000 UART driver (Ethernet over > > UART) into the existing document. > > > > Signed-off-by: Stefan Wahren

Re: [PATCH v5 15/17] dt-bindings: qca7000: append UART interface to binding

On Fri, 12 May 2017 06:15:52 +, Michael Heimpold wrote: > Hi, > > Zitat von Jakub Kicinski <kubak...@wp.pl>: > > > On Thu, 11 May 2017 21:12:22 +0200, Michael Heimpold wrote: > >> Am Mittwoch, 10. Mai 2017, 10:53:26 CEST schrieb Stefan Wahren: >

[PATCH] firmware: wake all waiters

Multiple devices may be waiting for firmware with the same name. In that case we will make them all use the same struct firmware_buf. When wake up happens make sure it's propagated to all of them. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/base/firmware_class

Re: [PATCH] firmware: wake all waiters

On Mon, 26 Jun 2017 23:20:36 +0200, Luis R. Rodriguez wrote: > > In that case we will make them all use the same struct firmware_buf. > > When wake up happens make sure it's propagated to all of them. > > > > Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome

Re: [PATCH] pci: iov: use device lock to protect IOV sysfs accesses

On Fri, 26 May 2017 18:47:26 -0500, Bjorn Helgaas wrote: > On Mon, May 22, 2017 at 03:50:23PM -0700, Jakub Kicinski wrote: > > PCI core sets the driver pointer before calling ->probe() and only > > clears it after ->remove(). This means driver's ->sriov_configure() > &

[PATCH] pci: iov: use device lock to protect IOV sysfs accesses

s, or try detecting races in all drivers, but it seems simpler and cleaner to just hold the device lock instead of special SR-IOV lock, since that lock is already supposed to synchronize the driver callbacks. Remove the iov lock completely, since we remove the last user. Signed-off-by: Jakub

Re: [PATCH] pci: iov: use device lock to protect IOV sysfs accesses

On Tue, 30 May 2017 18:07:18 -0500, Bjorn Helgaas wrote: > On Fri, May 26, 2017 at 04:58:20PM -0700, Jakub Kicinski wrote: > > On Fri, 26 May 2017 18:47:26 -0500, Bjorn Helgaas wrote: > > > On Mon, May 22, 2017 at 03:50:23PM -0700, Jakub Kicinski wrote: > > > > PC

Re: [PATCH net-next] nfp: add MAY_USE_DEVLINK dependency

On Wed, 31 May 2017 10:16:50 +0200, Arnd Bergmann wrote: > When devlink is configured as a loadable module, a built-in nfp driver > causes a link error: > > drivers/net/built-in.o: In function `nfp_devlink_port_register': > (.text+0xb8b05): undefined reference to `devlink_port_type_eth_set' >

Re: [PATCH] pci: iov: use device lock to protect IOV sysfs accesses

On Tue, 30 May 2017 16:34:29 -0700, Jakub Kicinski wrote: > On Tue, 30 May 2017 18:07:18 -0500, Bjorn Helgaas wrote: > > On Fri, May 26, 2017 at 04:58:20PM -0700, Jakub Kicinski wrote: > > > On Fri, 26 May 2017 18:47:26 -0500, Bjorn Helgaas wrote: > > > > On M

Re: [PATCH v2] bitfield.h: include instead of

On Mon, 18 Sep 2017 11:12:55 +0900, Masahiro Yamada wrote: > Since commit bc6245e5efd7 ("bug: split BUILD_BUG stuff out into > "), #include is better > to pull minimal headers needed for BUILG_BUG() family. > > Signed-off-by: Masahiro Yamada <yamada.masah...@soc

Re: [PATCH] bitfield.h: remove 32bit from FIELD_GET comment block

On Thu, 21 Sep 2017 00:39:35 +0900, Masahiro Yamada wrote: > I do not see anything that restricts this macro to 32 bit width. > > Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> Acked-by: Jakub Kicinski <jakub.kicin...@netronome.com> Looks like a leftove

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

On Wed, 4 Oct 2017 17:38:22 -0700, Manoj Gupta wrote: > On Wed, Oct 4, 2017 at 4:25 PM, Jakub Kicinski wrote: > > On Wed, 4 Oct 2017 16:16:49 -0700, Matthias Kaehlcke wrote: > >> > > Thanks for the suggestion. This seems a viable alternative if David > >> > &

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

On Wed, 4 Oct 2017 18:50:04 -0700, Manoj Gupta wrote: > On Wed, Oct 4, 2017 at 5:56 PM, Jakub Kicinski wrote: > > On Wed, 4 Oct 2017 17:38:22 -0700, Manoj Gupta wrote: > >> On Wed, Oct 4, 2017 at 4:25 PM, Jakub Kicinski wrote: > >> > On Wed, 4 Oct 2017 16:16:49

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

On Tue, 3 Oct 2017 13:05:46 -0700, Matthias Kaehlcke wrote: > nfp_eth_set_bit_config() is marked as __always_inline to allow gcc to > identify the 'mask' parameter as known to be constant at compile time, > which is required to use the FIELD_GET() macro. > > The forced inlining does the trick

Re: [PATCH] bitfield: Use __ffs64(x) to fix missing __ffsdi2()

gt; Fixes: 3e9b3112ec74f192 ("add basic register-field manipulation macros") > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Jakub Kicinski <jakub.kicin...@netronome.com> Thanks!

Re: [PATCH] bitfield: Use __ffs64(x) to fix missing __ffsdi2()

On Tue, 10 Oct 2017 09:03:50 +0200, Geert Uytterhoeven wrote: > Hi Jakub, > > On Tue, Oct 10, 2017 at 12:53 AM, Jakub Kicinski > <jakub.kicin...@netronome.com> wrote: > > On Mon, 9 Oct 2017 10:40:49 +0200, Geert Uytterhoeven wrote: > >> On most architectu

Apparmor memory leak reports

Hi! I'm seeing a lot of kmemleak reports like this on 4.13.0-rc6: unreferenced object 0x88045e62ab08 (size 1024): comm "apparmor_parser", pid 802, jiffies 4294913386 (age 4794.692s) hex dump (first 32 bytes): 0c 1b 30 6b 04 88 ff ff 0c 1b 30 6b 04 88 ff ff ..0k..0k 18 ab

Module removal-related regression?

Hi! I'm having trouble with modules on linux/master. rmmod succeeds but the module is still loaded and the refcount goes to 1: #rmmod nfp; insmod ./src/nfp.ko nfp_pf_netdev=0 ; \ /opt/netronome/bin/nfp-hwinfo -n 2 assembly.partno \ lsmod | grep nfp; \ rmmod nfp; \

Re: [bisected] Re: Module removal-related regression?

On Sat, 9 Sep 2017 12:55:51 -0700, Dmitry Torokhov wrote: > On Sat, Sep 9, 2017 at 12:27 PM, Jakub Kicinski <kubak...@wp.pl> wrote: > > On Sat, 9 Sep 2017 19:41:21 +0200, Jakub Kicinski wrote: > >> Hi! > >> > >> I'm having trouble with modules on linux/m

[bisected] Re: Module removal-related regression?

On Sat, 9 Sep 2017 19:41:21 +0200, Jakub Kicinski wrote: > Hi! > > I'm having trouble with modules on linux/master. rmmod succeeds but the > module is still loaded and the refcount goes to 1: > > #rmmod nfp; insmod ./src/nfp.ko nfp_pf_netdev=0 ; \ > /opt/netronom

Re: [bisected] Re: Module removal-related regression?

On Sat, 9 Sep 2017 12:55:51 -0700, Dmitry Torokhov wrote: > On Sat, Sep 9, 2017 at 12:27 PM, Jakub Kicinski <kubak...@wp.pl> wrote: > > On Sat, 9 Sep 2017 19:41:21 +0200, Jakub Kicinski wrote: > >> Hi! > >> > >> I'm having trouble with modules on linux/m

Re: [bisected] Re: Module removal-related regression?

On Sat, 09 Sep 2017 13:59:25 -0700, Dmitry Torokhov wrote: > On September 9, 2017 1:17:26 PM PDT, Jakub Kicinski <kubak...@wp.pl> wrote: > >On Sat, 9 Sep 2017 12:55:51 -0700, Dmitry Torokhov wrote: > >> On Sat, Sep 9, 2017 at 12:27 PM, Jakub Kicinski <kubak...@wp.pl&g

Re: [bisected] Re: Module removal-related regression?

On Tue, 12 Sep 2017 11:52:11 -0700, Dmitry Torokhov wrote: > On Tue, Sep 12, 2017 at 02:00:41PM +0200, Jakub Kicinski wrote: > > On Mon, 11 Sep 2017 11:29:26 -0700, Dmitry Torokhov wrote: > > > > > > That is an option, but maybe we could have the patch below fo

Re: [bisected] Re: Module removal-related regression?

On Sun, 10 Sep 2017 09:21:11 -0700, Dmitry Torokhov wrote: > On Sun, Sep 10, 2017 at 12:03:38AM +0200, Jakub Kicinski wrote: > > On Sat, 09 Sep 2017 13:59:25 -0700, Dmitry Torokhov wrote: > > > On September 9, 2017 1:17:26 PM PDT, Jakub Kicinski <kubak...@wp.pl> > &g

Re: [bisected] Re: Module removal-related regression?

On Sun, 10 Sep 2017 11:12:17 -0700, Dmitry Torokhov wrote: > On September 10, 2017 11:00:10 AM PDT, Jakub Kicinski <kubak...@wp.pl> wrote: > >On Sun, 10 Sep 2017 09:21:11 -0700, Dmitry Torokhov wrote: > >> On Sun, Sep 10, 2017 at 12:03:38AM +0200, Jakub Kicinski wrote:

  1   2   3   4   5   6   7   8   9   10   >