kswapd high CPU usage with no swap

2007-09-24 Thread Jan Kundrát
Hi folks, I use a 2.6.22-gentoo-r2 SMP kernel with fglrx 8.40.4 [1], tp_smapi-0.32 and ipw3945-1.2.0 on a Thinkpad T60 with dual core Intel Core CPU. My root filesystem is XFS stored on an internal SATA disk, and I have 1GB of RAM and no swap. After several suspend to RAM/resume cycles, the X

Re: kswapd high CPU usage with no swap

2007-09-25 Thread Jan Kundrát
Rik van Riel wrote: How much memory did you have in cached when you looked with top (and no swap enabled) ? Hi Rik, it was pretty low number (several thousands, or maybe tens of thousands). In the meanwhile, I've come across your patch [1] (prevent kswapd from freeing excessive amounts of

Re: kswapd high CPU usage with no swap

2007-09-26 Thread Jan Kundrát
Rik van Riel wrote: Could you try out the attached patch, too? Sorry, I wasn't able to apply it against 2.6.22-gentoo-r3 and vanilla 2.6.22.7; I don't have the order member in the struct scan_control and also the bit about if (sync_writeback == PAGEOUT_IO_SYNC may_enter_fs) was missing so there

Re: kswapd high CPU usage with no swap

2007-09-26 Thread Jan Kundrát
When this is sorted out, should I keep the previous patch [1] applied as well? That doesn't hurt. OK, I've used just the latter patch (because I somehow believe the first one lowers the probability of bad behavior), so let's see if kswapd consumes CPU again. I don't have any test patter to

Re: [PATCH] serial: max310x: Delete an error message for a failed memory allocation in max310x_probe()

2017-12-08 Thread Jan Kundrát
ch because I'm also making some modifications to this driver. This patch makes sense; other drivers also simply return ENOMEM. Tested on ARM, Armada 388; the "good" code path still obviously works :). Reviewed-by: Jan Kundrát <jan.kund...@cesnet.cz>

Re: [PATCH] gpio: Add missing open drain/source handling to gpiod_set_value_cansleep()

2018-01-11 Thread Jan Kundrát
commit(desc, value); + __gpiod_set_value_nocheck(desc, value); } EXPORT_SYMBOL_GPL(gpiod_set_value_cansleep); I realize that I'm late to the party (a merge request has been sent), but I can confirm that I tested that this still works for a bitbang I2C over GPIO pins connected to MAX14830 managed by max310x. Tested-By: Jan Kundrát <jan.kund...@cesnet.cz> Cheers, Jan

Re: [PATCH v4] spi: orion: cosmetics - alias long direct_access variables

2018-08-24 Thread Jan Kundrát
status = -ENOMEM; goto out_rel_axi_clk; } - spi->child[cs].direct_access.size = PAGE_SIZE; + dir_acc->size = PAGE_SIZE; dev_info(>dev, "CS%d configured for direct access\n", cs); } Reviewed-by: Jan Kundrát

Re: [PATCH v2 1/3] spi: Introduce one new field to set word delay

2018-08-29 Thread Jan Kundrát
On čtvrtek 16. srpna 2018 14:54:49 CEST, Baolin Wang wrote: + * @word_delay: clock cycles to inter word delay after each word size + * (set by bits_per_word) transmission. I need a similar functionality for talking to a SPI device from userspace -- see my attempt for implementing this in

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-10-01 Thread Jan Kundrát
On pondělí 24. září 2018 16:52:18 CEST, Thomas Petazzoni wrote: Hello, On Mon, 24 Sep 2018 15:15:12 +0100, Lorenzo Pieralisi wrote: I understand that, I wanted to make sure we come up with a fix asap and what I put forward would cover everything discussed in this thread, at least temporarily,

Re: [PATCH] spidev: Enable the Liebherr's BK4 board to work with spidev driver

2018-10-01 Thread Jan Kundrát
On pátek 28. září 2018 0:31:52 CEST, Lukasz Majewski wrote: With this commit the DSPI driver on the BK4 board can be used for SPI transmission managed from user space (via /dev/spidev0.0). Hi Lukasz, I tried submitting a similar patch for another devicem but got no reaction [1]. In the

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-24 Thread Jan Kundrát
have zero familiarity with Linux' PCI code. Tested-by: Jan Kundrát Thanks for the testing. I'll wait for Russell to say if he is happy (or not) with the addition of pci_unmap_io() in the ARM code, if that's the case, I'll send a proper patch to fix the issue. Hi Thomas, Russell, is there a pr

[BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-12 Thread Jan Kundrát
Hi, since commit ee1604381a371b3ea6aec7d5e43b6e3f5e153854 ("PCI: mvebu: Only remap I/O space if configured"), my board (Solidrun Clearfog Base) won't finish booting with 4.18-rc3 won't boot: [1.741458] Internal error: Oops - undefined instruction: 0 [#1] SMP ARM [1.748182] CPU: 1

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-12 Thread Jan Kundrát
You mean '4.19-rc3', right? Right, sorry. [1.741458] Internal error: Oops - undefined instruction: 0 [#1] SMP ARM [1.748182] CPU: 1 PID: 72 Comm: kworker/1:2 Tainted: G W 4.19.0-rc3 #1 The 'W' taint means that there was a kernel warning before. Which warning was

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-13 Thread Jan Kundrát
g/pub/scm/linux/kernel/git/helgaas/pci"). Disclaimer: I have zero familiarity with Linux' PCI code. Tested-by: Jan Kundrát With kind regards, Jan

kswapd high CPU usage with no swap

2007-09-24 Thread Jan Kundrát
Hi folks, I use a 2.6.22-gentoo-r2 SMP kernel with fglrx 8.40.4 [1], tp_smapi-0.32 and ipw3945-1.2.0 on a Thinkpad T60 with dual core Intel Core CPU. My root filesystem is XFS stored on an internal SATA disk, and I have 1GB of RAM and no swap. After several suspend to RAM/resume cycles, the X

Re: kswapd high CPU usage with no swap

2007-09-25 Thread Jan Kundrát
Rik van Riel wrote: > How much memory did you have in "cached" when you looked > with top (and no swap enabled) ? Hi Rik, it was pretty low number (several thousands, or maybe tens of thousands). In the meanwhile, I've come across your patch [1] ("prevent kswapd from freeing excessive amounts of

Re: kswapd high CPU usage with no swap

2007-09-26 Thread Jan Kundrát
Rik van Riel wrote: > Could you try out the attached patch, too? Sorry, I wasn't able to apply it against 2.6.22-gentoo-r3 and vanilla 2.6.22.7; I don't have the "order" member in the "struct scan_control" and also the bit about "if (sync_writeback == PAGEOUT_IO_SYNC && may_enter_fs)" was missing

Re: kswapd high CPU usage with no swap

2007-09-26 Thread Jan Kundrát
>> When this is sorted out, should I keep the previous patch [1] applied >> as well? > > That doesn't hurt. OK, I've used just the latter patch (because I somehow believe the first one lowers the probability of bad behavior), so let's see if kswapd consumes CPU again. I don't have any test

Re: [PATCH] gpio: Add missing open drain/source handling to gpiod_set_value_cansleep()

2018-01-11 Thread Jan Kundrát
_gpiod_set_value_nocheck(desc, value); } EXPORT_SYMBOL_GPL(gpiod_set_value_cansleep); I realize that I'm late to the party (a merge request has been sent), but I can confirm that I tested that this still works for a bitbang I2C over GPIO pins connected to MAX14830 managed by max310x. Tested-By: Jan Kundrát Cheers, Jan

Re: [PATCH] serial: max310x: Delete an error message for a failed memory allocation in max310x_probe()

2017-12-08 Thread Jan Kundrát
sense; other drivers also simply return ENOMEM. Tested on ARM, Armada 388; the "good" code path still obviously works :). Reviewed-by: Jan Kundrát

Re: [PATCH v2] serial: max310x: rework RX interrupt handling

2020-10-28 Thread Jan Kundrát
and 5%. That's cool :). Tested-by: Jan Kundrát Reviewed-by: Jan Kundrát (but see below, please) + /* Enable LSR, RX FIFO trigger, CTS change interrupts */ + val = MAX310X_IRQ_LSR_BIT | MAX310X_IRQ_RXFIFO_BIT | MAX310X_IRQ_TXEMPTY_BIT; max310x_port_write(port, MAX310X_IRQEN_REG

Re: [PATCH] pinctrl-mcp23s08: Fix property-name in dt-example

2019-08-29 Thread Jan Kundrát
. Without "microchip," on the front, the driver will print "missing spi-present-mask" when it initializes. Update the device-tree example with the correct property-name. Signed-off-by: Peter Vernia Reviewed-by: Jan Kundrát --- Documentation/devicetree/bindings/pinctrl/pinctr

Re: [PATCH v1] tty: serial: max310x: Add optional reset gpio

2019-07-02 Thread Jan Kundrát
On pátek 14. června 2019 16:11:12 CEST, Mylène Josserand wrote: --- a/Documentation/devicetree/bindings/serial/maxim,max310x.txt +++ b/Documentation/devicetree/bindings/serial/maxim,max310x.txt @@ -15,6 +15,7 @@ Required properties: "osc" if an external clock source is used. Optional

Re: [PATCH v4] spi: orion: cosmetics - alias long direct_access variables

2018-08-24 Thread Jan Kundrát
status = -ENOMEM; goto out_rel_axi_clk; } - spi->child[cs].direct_access.size = PAGE_SIZE; + dir_acc->size = PAGE_SIZE; dev_info(>dev, "CS%d configured for direct access\n", cs); } Reviewed-by: Jan Kundrát

Re: [PATCH v2 1/3] spi: Introduce one new field to set word delay

2018-08-29 Thread Jan Kundrát
On čtvrtek 16. srpna 2018 14:54:49 CEST, Baolin Wang wrote: + * @word_delay: clock cycles to inter word delay after each word size + * (set by bits_per_word) transmission. I need a similar functionality for talking to a SPI device from userspace -- see my attempt for implementing this in

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-24 Thread Jan Kundrát
have zero familiarity with Linux' PCI code. Tested-by: Jan Kundrát Thanks for the testing. I'll wait for Russell to say if he is happy (or not) with the addition of pci_unmap_io() in the ARM code, if that's the case, I'll send a proper patch to fix the issue. Hi Thomas, Russell, is there a pr

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-10-01 Thread Jan Kundrát
On pondělí 24. září 2018 16:52:18 CEST, Thomas Petazzoni wrote: Hello, On Mon, 24 Sep 2018 15:15:12 +0100, Lorenzo Pieralisi wrote: I understand that, I wanted to make sure we come up with a fix asap and what I put forward would cover everything discussed in this thread, at least temporarily,

Re: [PATCH] spidev: Enable the Liebherr's BK4 board to work with spidev driver

2018-10-01 Thread Jan Kundrát
On pátek 28. září 2018 0:31:52 CEST, Lukasz Majewski wrote: With this commit the DSPI driver on the BK4 board can be used for SPI transmission managed from user space (via /dev/spidev0.0). Hi Lukasz, I tried submitting a similar patch for another devicem but got no reaction [1]. In the

Re: [PATCH] pinctrl: mcp23s08: Allocate irq_chip dynamic

2019-03-08 Thread Jan Kundrát
On pátek 8. března 2019 10:15:50 CET, Linus Walleij wrote: On Tue, Mar 5, 2019 at 4:19 PM Jan Kundrát wrote: This commit should probably go to 5.0-stable and 4.20-stable as well I doubt that this commit is fixing a regression, but who knows... If I cherry-pick the following two commits

Re: [PATCH] pinctrl: mcp23s08: Allocate irq_chip dynamic

2019-03-05 Thread Jan Kundrát
: "detected irqchip that is shared with multiple gpiochips: please fix the driver." Hence, move the irq_chip definition from being driver static into the struct mcp23s08. So a unique irq_chip is used for each gpiochip instance. Signed-off-by: Lars Poeschel Patch applied. Tested-by: Jan Kund

Re: [PATCH] serial: max310x: Use struct_size() in devm_kzalloc()

2019-03-07 Thread Jan Kundrát
) + -sizeof(struct max310x_one) * devtype->nr, GFP_KERNEL); + s = devm_kzalloc(dev, struct_size(s, p, devtype->nr), GFP_KERNEL); if (!s) { dev_err(dev, "Error allocating port structure\n"); return -ENOMEM; Reviewed-by: Jan

[BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-12 Thread Jan Kundrát
Hi, since commit ee1604381a371b3ea6aec7d5e43b6e3f5e153854 ("PCI: mvebu: Only remap I/O space if configured"), my board (Solidrun Clearfog Base) won't finish booting with 4.18-rc3 won't boot: [1.741458] Internal error: Oops - undefined instruction: 0 [#1] SMP ARM [1.748182] CPU: 1

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-12 Thread Jan Kundrát
You mean '4.19-rc3', right? Right, sorry. [1.741458] Internal error: Oops - undefined instruction: 0 [#1] SMP ARM [1.748182] CPU: 1 PID: 72 Comm: kworker/1:2 Tainted: G W 4.19.0-rc3 #1 The 'W' taint means that there was a kernel warning before. Which warning was

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-13 Thread Jan Kundrát
g/pub/scm/linux/kernel/git/helgaas/pci"). Disclaimer: I have zero familiarity with Linux' PCI code. Tested-by: Jan Kundrát With kind regards, Jan

Re: [PATCH 3/7] hwmon: (max31790) Allow setting pulses

2021-03-05 Thread Jan Kundrát
@@ -285,6 +295,9 @@ static int max31790_write_fan(struct device *dev, u32 attr, int channel, MAX31790_REG_FAN_CONFIG(channel), data->fan_config[channel]); break; + case hwmon_fan_pulses: +