On 1/12/07, Nick Piggin [EMAIL PROTECTED] wrote:
Jaya Kumar wrote:
- write so get page_mkwrite where we add this page to a list
- also schedules a workqueue task to be run after a delay
- app continues writing to that page with no additional cost
- the workqueue task comes in and unmaps
Hi James, Geert, lkml and mm,
This patch adds support for the Hecuba/E-Ink display with deferred IO.
The changes from the previous version are to switch to using a mutex
and lock_page. I welcome your feedback and advice.
Signed-off-by: Jaya Kumar [EMAIL PROTECTED]
---
drivers/video/Kconfig
On 2/17/07, Peter Zijlstra [EMAIL PROTECTED] wrote:
On Sat, 2007-02-17 at 11:42 +0100, Jaya Kumar wrote:
Hi James, Geert, lkml and mm,
Hi Jaya,
This patch adds support for the Hecuba/E-Ink display with deferred IO.
The changes from the previous version are to switch to using a mutex
On 2/17/07, Paul Mundt [EMAIL PROTECTED] wrote:
On Sat, Feb 17, 2007 at 08:25:07AM -0500, Jaya Kumar wrote:
On 2/17/07, Peter Zijlstra [EMAIL PROTECTED] wrote:
And, as Andrew suggested last time around, could you perhaps push this
fancy new idea into the FB layer so that more drivers can make
On 2/18/07, Paul Mundt [EMAIL PROTECTED] wrote:
Given that, this would have to be something that's dealt with at the
subsystem level rather than in individual drivers, hence the desire to
see something like this more generically visible.
Hi Peter, Paul, fbdev folk,
Ok. Here's what I'm
On 2/19/07, Paul Mundt [EMAIL PROTECTED] wrote:
On Mon, Feb 19, 2007 at 11:13:04PM -0500, Jaya Kumar wrote:
Ok. Here's what I'm thinking for abstracting this:
fbdev drivers would setup fb_mmap with their own_mmap as usual. In
own_mmap, they would do what they normally do and setup a vm_ops
On 2/20/07, Jaya Kumar [EMAIL PROTECTED] wrote:
On 2/19/07, Paul Mundt [EMAIL PROTECTED] wrote:
That works for me, though I'd prefer for struct page_list to be done with
a scatterlist, then it's trivial to setup from the workqueue context
without having to shuffle things around.
Ok
On 2/20/07, Geert Uytterhoeven [EMAIL PROTECTED] wrote:
Don't you need a way to specify the maximum deferral time? E.g. a field in
fb_info.
You are right. I will need that. I could put that into struct
fb_deferred_io. So drivers would setup like:
static struct fb_deferred_io hecubafb_defio =
On 2/21/07, James Simmons [EMAIL PROTECTED] wrote:
Could you make it work without the framebuffer. There are embedded LCD
displays that have internal memory that need data flushed to them.
I'm not sure I understand. What the current implementation does is to
use host based framebuffer
On 2/21/07, Antonino A. Daplas [EMAIL PROTECTED] wrote:
On Wed, 2007-02-21 at 11:55 -0500, Jaya Kumar wrote:
You are right. I will need that. I could put that into struct
fb_deferred_io. So drivers would setup like:
Is it also possible to let the drivers do the 'deferred_io'
themselves
Signed-off-by: Jaya Kumar [EMAIL PROTECTED]
---
Documentation/fb/deferred_io.txt | 114
drivers/video/Kconfig| 20 +
drivers/video/Makefile |2
drivers/video/fb_defio.c | 104 +++
drivers/video/fbmem.c|2
drivers/video
On 2/24/07, Antonino A. Daplas [EMAIL PROTECTED] wrote:
On Fri, 2007-02-23 at 07:32 +0100, Jaya Kumar wrote:
Can you create 2 separate patches, one for the deferred_io and another
for the driver that uses it?
Will do.
+static struct vm_operations_struct hecubafb_vm_ops = {
+ .nopage
On 2/23/07, Paul Mundt [EMAIL PROTECTED] wrote:
On Fri, Feb 23, 2007 at 07:32:28AM +0100, Jaya Kumar wrote:
This is a first pass at abstracting deferred IO out from hecubafb and
into fbdev as was discussed before:
http://marc.theaimsgroup.com/?l=linux-fbdev-develm=117187443327466w=2
Please
000..5ed9053
--- /dev/null
+++ b/drivers/video/fb_defio.c
@@ -0,0 +1,137 @@
+/*
+ * linux/drivers/video/fb_defio.c
+ *
+ * Copyright (C) 2006 Jaya Kumar
+ *
+ * This file is subject to the terms and conditions of the GNU General Public
+ * License. See the file COPYING in the main directory
This patch implements support for the E-Ink/hecuba display device. It uses
deferred IO support.
Thanks,
jaya
Signed-off-by: Jaya Kumar [EMAIL PROTECTED]
---
hecubafb.c | 480 +
1 file changed, 480 insertions(+)
---
diff --git
On 3/1/07, Paul Mundt [EMAIL PROTECTED] wrote:
On Sun, Feb 25, 2007 at 06:13:12AM +0100, Jaya Kumar wrote:
This patch implements deferred IO support in fbdev. Deferred IO is a way to
delay and repurpose IO. This implementation is done using mm's page_mkwrite
and page_mkclean hooks in order
On 10/29/07, Andrew Morton [EMAIL PROTECTED] wrote:
On Mon, 22 Oct 2007 16:40:57 +0200 Stefani Seibold [EMAIL PROTECTED] wrote:
The problem original occurs with the fb_defio driver
(driver/video/fb_defio.c).
This driver use the vm_ops.page_mkwrite() handler for tracking the modified
On 10/29/07, Peter Zijlstra [EMAIL PROTECTED] wrote:
On Mon, 2007-10-29 at 01:17 -0700, Jaya Kumar wrote:
An aside, I just tested that deferred IO works fine on 2.6.22.10/pxa255.
I understood from the thread that PeterZ is looking into page_mkclean
changes which I guess went into 2.6.23
On 10/29/07, Peter Zijlstra [EMAIL PROTECTED] wrote:
[ also, remap_vmalloc_range() suffers similar issues, only file and anon
have proper rmap ]
I'm not sure we want full rmap for remap_pfn/vmalloc_range, but perhaps
we could assist drivers in maintaining and using vma lists.
I think
On 10/30/07, Peter Zijlstra [EMAIL PROTECTED] wrote:
So page-index does what you want it to, identify which part of the
framebuffer this particular page belongs to.
Ok. I'm attempting to walk the code sequence. Here's what I think:
- driver loads
- driver vmalloc()s its fb
- this creates the
On Oct 30, 2007 11:47 AM, Hugh Dickins [EMAIL PROTECTED] wrote:
I don't understand why you suggested an anon_vma, nor why Jaya is
suggesting a private list. All vmas mapping /dev/fb0 will be kept
in the prio_tree rooted in its struct address_space (__vma_link_file
in mm/mmap.c). And
to be the same, it would be nice to hear success/failure
reports from someone with a 5535.
The patches look good. I'm traveling till Sep 2nd so can't test on
5535 yet. Thanks very much for your efforts Andres.
Thanks,
jaya
Acked-by: Jaya Kumar [EMAIL PROTECTED]
-
To unsubscribe from this list
On 12/13/06, Franck Bui-Huu [EMAIL PROTECTED] wrote:
On 12/12/06, Jaya Kumar [EMAIL PROTECTED] wrote:
I think that PTEs set up by vmalloc are marked cacheable and via the
above nopage end up as cacheable. I'm not doing DMA. So the accesses
are through the cache so I don't think cache aliasing
On 12/22/06, Franck Bui-Huu [EMAIL PROTECTED] wrote:
Well thinking more about it, this wouldn't work for all cache types.
For example, if your cache is not a direct maped one, this workaround
won't work. So this is definitely not a portable solution.
From asking peterz on #mm, I think
This patch adds support for the Hecuba/E-Ink display with deferred IO.
I welcome your feedback and advice.
Signed-off-by: Jaya Kumar [EMAIL PROTECTED]
---
drivers/video/Kconfig| 13 +
drivers/video/Makefile |1
drivers/video/hecubafb.c | 568
On 1/11/07, Andrew Morton [EMAIL PROTECTED] wrote:
That's all very interesting.
Please don't dump a bunch of new implementation concepts like this on us
with no description of what it does, why it does it and why it does it in
this particular manner.
Hi Andrew,
Actually, I didn't dump
On 12/11/06, Franck Bui-Huu [EMAIL PROTECTED] wrote:
[EMAIL PROTECTED] wrote:
+ atomic_t ref_count;
+ atomic_t vma_count;
what purpose do these counters deserve ?
You are right. I can remove them.
+
+void hcb_wait_for_ack(struct hecubafb_par *par)
+{
+
+ int timeout;
+
] fbdev: defio and Metronomefb
From: Jaya Kumar [EMAIL PROTECTED]
Date: 2008-02-18 13:41:26
Signed-off-by: Jaya Kumar [EMAIL PROTECTED]
Signed-off-by: Markus Armbruster [EMAIL PROTECTED]
---
drivers/video/fb_defio.c | 22 --
1 file changed, 20 insertions
On Thu, Feb 21, 2008 at 5:43 PM, Markus Armbruster [EMAIL PROTECTED] wrote:
+config XEN_FBDEV_FRONTEND
+ select FB_DEFERRED_IO
Groovy. :-)
Thanks,
jaya
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo
On Mon, Feb 25, 2008 at 8:03 AM, Markus Armbruster [EMAIL PROTECTED] wrote:
Subject: [PATCH 1/1 2.6.24] fbdev: defio and Metronomefb
From: Jaya Kumar [EMAIL PROTECTED]
Date: 2008-02-18 13:41:26
Hi Markus,
Andrew pointed out that there may be race conditions associated
On Tue, Feb 26, 2008 at 9:45 AM, Markus Armbruster [EMAIL PROTECTED] wrote:
What about pushing the fb_defio fixes independently of any new
fb_defio users? If fb_defio was worth merging into Linus's tree, it
should be worth fixing there, whether new users are in shape already
or not.
I
On Nov 4, 2007 5:24 AM, Geert Uytterhoeven [EMAIL PROTECTED] wrote:
On Sat, 3 Nov 2007, Jaya Kumar wrote:
+ interface. Please read file:Documentation/fb/metronomefb.txt
Documentation/fb/metronomefb.txt is missing?
Oops. I forgot to write that document. Ok, will do.
Thanks,
jaya
On 12/22/06, Franck Bui-Huu <[EMAIL PROTECTED]> wrote:
Well thinking more about it, this wouldn't work for all cache types.
For example, if your cache is not a direct maped one, this workaround
won't work. So this is definitely not a portable solution.
From asking peterz on #mm, I think
This patch adds support for the Hecuba/E-Ink display with deferred IO.
I welcome your feedback and advice.
Signed-off-by: Jaya Kumar <[EMAIL PROTECTED]>
---
drivers/video/Kconfig| 13 +
drivers/video/Makefile |1
drivers/video/hecubafb.c
On 1/11/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
That's all very interesting.
Please don't dump a bunch of new implementation concepts like this on us
with no description of what it does, why it does it and why it does it in
this particular manner.
Hi Andrew,
Actually, I didn't dump
On 12/11/06, Franck Bui-Huu <[EMAIL PROTECTED]> wrote:
[EMAIL PROTECTED] wrote:
> + atomic_t ref_count;
> + atomic_t vma_count;
what purpose do these counters deserve ?
You are right. I can remove them.
> +
> +void hcb_wait_for_ack(struct hecubafb_par *par)
> +{
> +
> + int
On 12/13/06, Franck Bui-Huu <[EMAIL PROTECTED]> wrote:
On 12/12/06, Jaya Kumar <[EMAIL PROTECTED]> wrote:
> I think that PTEs set up by vmalloc are marked cacheable and via the
> above nopage end up as cacheable. I'm not doing DMA. So the accesses
> are through the cache s
Signed-off-by: Jaya Kumar <[EMAIL PROTECTED]>
---
Documentation/fb/deferred_io.txt | 114
drivers/video/Kconfig| 20 +
drivers/video/Makefile |2
drivers/video/fb_defio.c | 104 +++
drivers/video/fbmem.c|2
drivers
On 2/24/07, Antonino A. Daplas <[EMAIL PROTECTED]> wrote:
On Fri, 2007-02-23 at 07:32 +0100, Jaya Kumar wrote:
Can you create 2 separate patches, one for the deferred_io and another
for the driver that uses it?
Will do.
> +static struct vm_operations_struct hecuba
On 2/23/07, Paul Mundt <[EMAIL PROTECTED]> wrote:
On Fri, Feb 23, 2007 at 07:32:28AM +0100, Jaya Kumar wrote:
> This is a first pass at abstracting deferred IO out from hecubafb and
> into fbdev as was discussed before:
> http://marc.theaimsgroup.com/?l=linux-fbdev-devel=11
fio.c b/drivers/video/fb_defio.c
new file mode 100644
index 000..5ed9053
--- /dev/null
+++ b/drivers/video/fb_defio.c
@@ -0,0 +1,137 @@
+/*
+ * linux/drivers/video/fb_defio.c
+ *
+ * Copyright (C) 2006 Jaya Kumar
+ *
+ * This file is subject to the terms and conditions of the GNU General
This patch implements support for the E-Ink/hecuba display device. It uses
deferred IO support.
Thanks,
jaya
Signed-off-by: Jaya Kumar <[EMAIL PROTECTED]>
---
hecubafb.c | 480 +
1 file changed, 480 insertions(+)
---
diff
On 3/1/07, Paul Mundt <[EMAIL PROTECTED]> wrote:
On Sun, Feb 25, 2007 at 06:13:12AM +0100, Jaya Kumar wrote:
> This patch implements deferred IO support in fbdev. Deferred IO is a way to
> delay and repurpose IO. This implementation is done using mm's page_mkwrite
> and pag
On 1/12/07, Nick Piggin <[EMAIL PROTECTED]> wrote:
Jaya Kumar wrote:
> - write so get page_mkwrite where we add this page to a list
> - also schedules a workqueue task to be run after a delay
> - app continues writing to that page with no additional cost
> - the wo
Hi James, Geert, lkml and mm,
This patch adds support for the Hecuba/E-Ink display with deferred IO.
The changes from the previous version are to switch to using a mutex
and lock_page. I welcome your feedback and advice.
Signed-off-by: Jaya Kumar <[EMAIL PROTECTED]>
---
drivers/video/K
On 2/17/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote:
On Sat, 2007-02-17 at 11:42 +0100, Jaya Kumar wrote:
> Hi James, Geert, lkml and mm,
Hi Jaya,
> This patch adds support for the Hecuba/E-Ink display with deferred IO.
> The changes from the previous version are to switch t
On 2/17/07, Paul Mundt <[EMAIL PROTECTED]> wrote:
On Sat, Feb 17, 2007 at 08:25:07AM -0500, Jaya Kumar wrote:
> On 2/17/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote:
> >And, as Andrew suggested last time around, could you perhaps push this
> >fancy new idea into the FB
On 2/18/07, Paul Mundt <[EMAIL PROTECTED]> wrote:
Given that, this would have to be something that's dealt with at the
subsystem level rather than in individual drivers, hence the desire to
see something like this more generically visible.
Hi Peter, Paul, fbdev folk,
Ok. Here's what I'm
On 2/19/07, Paul Mundt <[EMAIL PROTECTED]> wrote:
On Mon, Feb 19, 2007 at 11:13:04PM -0500, Jaya Kumar wrote:
>
> Ok. Here's what I'm thinking for abstracting this:
>
> fbdev drivers would setup fb_mmap with their own_mmap as usual. In
> own_mmap, they would do what they
On 2/20/07, Jaya Kumar <[EMAIL PROTECTED]> wrote:
On 2/19/07, Paul Mundt <[EMAIL PROTECTED]> wrote:
> That works for me, though I'd prefer for struct page_list to be done with
> a scatterlist, then it's trivial to setup from the workqueue context
> without having to shuffle
On 2/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
Don't you need a way to specify the maximum deferral time? E.g. a field in
fb_info.
You are right. I will need that. I could put that into struct
fb_deferred_io. So drivers would setup like:
static struct fb_deferred_io hecubafb_defio
On 2/21/07, James Simmons <[EMAIL PROTECTED]> wrote:
Could you make it work without the framebuffer. There are embedded LCD
displays that have internal memory that need data flushed to them.
I'm not sure I understand. What the current implementation does is to
use host based framebuffer
On 2/21/07, Antonino A. Daplas <[EMAIL PROTECTED]> wrote:
On Wed, 2007-02-21 at 11:55 -0500, Jaya Kumar wrote:
>
> You are right. I will need that. I could put that into struct
> fb_deferred_io. So drivers would setup like:
>
Is it also possible to let the drivers d
the 5535
> data sheet claims to be the same, it would be nice to hear success/failure
> reports from someone with a 5535.
The patches look good. I'm traveling till Sep 2nd so can't test on
5535 yet. Thanks very much for your efforts Andres.
Thanks,
jaya
Acked-by: Jaya Kumar <[EMAIL PRO
On 10/29/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Mon, 22 Oct 2007 16:40:57 +0200 Stefani Seibold <[EMAIL PROTECTED]> wrote:
> >
> > The problem original occurs with the fb_defio driver
> > (driver/video/fb_defio.c).
> > This driver use the vm_ops.page_mkwrite() handler for tracking the
On 10/29/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote:
> On Mon, 2007-10-29 at 01:17 -0700, Jaya Kumar wrote:
> > An aside, I just tested that deferred IO works fine on 2.6.22.10/pxa255.
> >
> > I understood from the thread that PeterZ is looking into page_mkclean
>
On 10/29/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote:
>
> [ also, remap_vmalloc_range() suffers similar issues, only file and anon
> have proper rmap ]
>
> I'm not sure we want full rmap for remap_pfn/vmalloc_range, but perhaps
> we could assist drivers in maintaining and using vma lists.
>
> I
On 10/30/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote:
> So page->index does what you want it to, identify which part of the
> framebuffer this particular page belongs to.
Ok. I'm attempting to walk the code sequence. Here's what I think:
- driver loads
- driver vmalloc()s its fb
- this creates
On Oct 30, 2007 11:47 AM, Hugh Dickins <[EMAIL PROTECTED]> wrote:
>
> I don't understand why you suggested an anon_vma, nor why Jaya is
> suggesting a private list. All vmas mapping /dev/fb0 will be kept
> in the prio_tree rooted in its struct address_space (__vma_link_file
> in mm/mmap.c). And
On Nov 4, 2007 5:24 AM, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> On Sat, 3 Nov 2007, Jaya Kumar wrote:
> > + interface. Please read
>
> Documentation/fb/metronomefb.txt is missing?
Oops. I forgot to write that document. Ok, will do.
Thanks,
jaya
-
To unsub
On Mon, Feb 25, 2008 at 8:03 AM, Markus Armbruster <[EMAIL PROTECTED]> wrote:
>
> Subject: [PATCH 1/1 2.6.24] fbdev: defio and Metronomefb
> From: Jaya Kumar <[EMAIL PROTECTED]>
> Date: 2008-02-18 13:41:26
Hi Markus,
Andrew pointed out that there may be ra
On Tue, Feb 26, 2008 at 9:45 AM, Markus Armbruster <[EMAIL PROTECTED]> wrote:
>
> What about pushing the fb_defio fixes independently of any new
> fb_defio users? If fb_defio was worth merging into Linus's tree, it
> should be worth fixing there, whether new users are in shape already
> or
ect: [PATCH 1/1 2.6.24] fbdev: defio and Metronomefb
> From: Jaya Kumar <[EMAIL PROTECTED]>
> Date: 2008-02-18 13:41:26
>
> Signed-off-by: Jaya Kumar <[EMAIL PROTECTED]>
> Signed-off-by: Markus Armbruster <[EMAIL PROTECTED]>
>
> ---
>
> drive
On Thu, Feb 21, 2008 at 5:43 PM, Markus Armbruster <[EMAIL PROTECTED]> wrote:
> +config XEN_FBDEV_FRONTEND
> + select FB_DEFERRED_IO
Groovy. :-)
Thanks,
jaya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More
64 matches
Mail list logo
