`/usr/src/linux/mm'
make[1]: *** [first_rule] Error 2
make[1]: Leaving directory `/usr/src/linux/mm'
make: *** [_dir_mm] Error 2
--
Jeff Layton ([EMAIL PROTECTED])
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More
/2.4.2/kernel/net/ipv6/netfilter/ip6t_limit.o
depmod: .umul
depmod: .udiv
depmod: *** Unresolved symbols in
/lib/modules/2.4.2/kernel/net/sunrpc/sunrpc.o
depmod: .umul
depmod: .udiv
--
Jeff Layton ([EMAIL PROTECTED])
"In order for you to profit from your mis
Yep the module loaded fine. Must be a problem with depmod then. Thanks for
the info!
caladan:~# modprobe ip_conntrack
caladan:~# lsmod
Module Size Used by
ip_conntrack 19840 0 (unused)
--
Jeff Layton ([EMAIL PROTECTED])
"In order for you to profit from
length prior to actually calculating it, particularly with
schemes like spkm3.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c
index f61142a..7d47c16 100644
--- a/fs/nfsd/nfs3proc.c
+++ b/fs/nfsd/nfs3proc.c
@@ -175,7 +175,7 @@ nfsd3_proc_read(struct
, and set any write bits allowed by the
mnt_file_mode.
This logic seems reasonable, but I'm not certain that there aren't cases where
it would fall down. Comments and/or ACK's appreciated...
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index 86b9dbb
.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
diff --git a/fs/inode.c b/fs/inode.c
index 23fc1fd..90e7587 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -689,21 +689,18 @@ ino_t iunique(struct super_block *sb, ino_t max_reserved)
struct inode *inode;
struct hlist_head * head
the svc_rqst structs.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
include/linux/sunrpc/svc.h |2 ++
net/sunrpc/svc.c | 43
+++ 2 files changed, 33
insertions(+), 12 deletions(-)
diff --git a/include/linux/sunrpc/svc.h b
, Neil. I'll see if I can get a new patchset done
in the next few days.
Cheers,
--
Jeff Layton [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 08 Jan 2008 10:52:19 -0500
Wendy Cheng [EMAIL PROTECTED] wrote:
Jeff Layton wrote:
The previous patch removes a kill_proc(... SIGKILL), this one
adds it back.
That makes me wonder if the intermediate state is 'correct'.
But I also wonder what correct means.
Do we want all
allocations fail.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
include/linux/sunrpc/svc.h |2 +
net/sunrpc/svc.c | 59 +++
2 files changed, 44 insertions(+), 17 deletions(-)
diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc
Needed since the plan is to not have a svc_create_thread helper and to
have current users of that function just call kthread_run directly.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
net/sunrpc/svcsock.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/sunrpc
lockd makes itself freezable, but never calls try_to_freeze(). Have it
call try_to_freeze() within the main loop.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index
lockd to check the refcount itself and to return if it goes to
0. We do the checking and exit while holding the nlmsvc_mutex to make
sure that a new lockd is not started until the old one is down.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c | 50
lockd_start_done is a global var that can be reused if lockd is
restarted, but it's never reinitialized. On all but the first use,
wait_for_completion isn't actually waiting on it since it has
already completed once.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c |1 +
1
to make this
cleanly bisectable, but have only really tested the final result.
Many thanks to Trond Myklebust, Chuck Lever, Neil Brown and Christoph
Hellwig for their guidance on this.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe linux
loop.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c | 93
1 files changed, 40 insertions(+), 53 deletions(-)
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index 03a83a0..0777a4e 100644
--- a/fs/lockd/svc.c
+++ b/fs/lockd
is that we make sure this is behavior we
can count on in the future and not just an artifact of the current
kthread implementation. If that's the case, then I'll plan to remove it
on the next respin.
--
Jeff Layton [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe linux
On Wed, 9 Jan 2008 17:45:06 +
Christoph Hellwig [EMAIL PROTECTED] wrote:
On Tue, Jan 08, 2008 at 02:33:17PM -0500, Jeff Layton wrote:
- struct svc_serv * serv;
- int error = 0;
+ struct svc_serv *serv;
+ struct svc_rqst *rqstp;
+ int
On Wed, 9 Jan 2008 17:47:07 +
Christoph Hellwig [EMAIL PROTECTED] wrote:
On Tue, Jan 08, 2008 at 02:33:18PM -0500, Jeff Layton wrote:
...and only have lockd exit when the last reference is dropped.
The problem is this:
When a lock that a client is blocking on comes free, lockd
On Wed, 9 Jan 2008 18:48:14 +
Christoph Hellwig [EMAIL PROTECTED] wrote:
On Wed, Jan 09, 2008 at 01:36:21PM -0500, Jeff Layton wrote:
I don't see a good alternative though. We need to be able to drop
the and check the refcount in nlmsvc_unlink_block. That function is
called from lockd
that, but the logic in
all of this is pretty convoluted. I'll see if I can cook up a new
patchset that does this instead.
--
Jeff Layton [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Needed since the plan is to not have a svc_create_thread helper and to
have current users of that function just call kthread_run directly.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
net/sunrpc/svcsock.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/sunrpc
allocations fail.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
include/linux/sunrpc/svc.h |2 +
net/sunrpc/svc.c | 59 +++
2 files changed, 44 insertions(+), 17 deletions(-)
diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc
lockd makes itself freezable, but never calls try_to_freeze(). Have it
call try_to_freeze() within the main loop.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index
the nlm_hosts anyway, then it doesn't make
sense to allow RPC calls to linger. Allowing them to do so can mean
that the RPC calls can outlive the currently running lockd and can lead
to the above use after free situation and possibly others.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd
, Neil Brown and Christoph
Hellwig for their guidance on this.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
loop.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c | 113 +--
1 files changed, 43 insertions(+), 70 deletions(-)
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index 6ee8bed..1ecf551 100644
--- a/fs/lockd/svc.c
+++ b/fs/lockd
at this point, so comments and suggestions
are appreciated...
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
include/linux/sched.h |2 ++
kernel/kthread.c | 33 +
2 files changed, 15 insertions(+), 20 deletions(-)
diff --git a/include/linux/sched.h b
On Thu, 10 Jan 2008 13:01:34 -0500
Jeff Layton [EMAIL PROTECTED] wrote:
lockd makes itself freezable, but never calls try_to_freeze(). Have it
call try_to_freeze() within the main loop.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c |3 +++
1 files changed, 3
On Wed, 9 Jan 2008 17:35:42 +
Christoph Hellwig [EMAIL PROTECTED] wrote:
On Tue, Jan 08, 2008 at 02:33:15PM -0500, Jeff Layton wrote:
lockd_start_done is a global var that can be reused if lockd is
restarted, but it's never reinitialized. On all but the first use,
wait_for_completion
bisectable, but have only really tested the final result.
Many thanks to Trond Myklebust, Chuck Lever, Neil Brown and Christoph
Hellwig for their guidance on this.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
loop.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c | 131 ---
1 files changed, 57 insertions(+), 74 deletions(-)
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index 82e2192..55fdd97 100644
--- a/fs/lockd/svc.c
+++ b/fs/lockd
Needed since the plan is to not have a svc_create_thread helper and to
have current users of that function just call kthread_run directly.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
net/sunrpc/svcsock.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/sunrpc
If we're shutting down all the nlm_hosts anyway, then it doesn't make
sense to allow RPC calls to linger. Allowing them to do so can mean
that the RPC calls can outlive the currently running lockd and can lead
to a use after free situation.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs
allocations fail.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
include/linux/sunrpc/svc.h |2 +
net/sunrpc/svc.c | 59 +++
2 files changed, 44 insertions(+), 17 deletions(-)
diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc
On Sun, 13 Jan 2008 18:17:43 +
Christoph Hellwig [EMAIL PROTECTED] wrote:
On Sun, Jan 13, 2008 at 08:27:18AM -0500, Jeff Layton wrote:
I've been hitting an intermittent null pointer dereference ever
since I've made this change:
The first thing lockd does is to call lock_kernel
When making a directory with POSIX mkdir calls, cifs_mkdir does not
respect the umask. This moves the AND'ing of the mode with the umask
to higher in the function so that the POSIX mkdir creates with the
correct mode.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/cifs/inode.c |2 +-
1
On Fri, 14 Sep 2007 20:25:45 +1000
Greg Banks [EMAIL PROTECTED] wrote:
On Tue, Sep 04, 2007 at 10:37:04AM -0400, Jeff Layton wrote:
If the ATTR_KILL_S*ID bits are set then any mode change is only for
clearing the setuid/setgid bits. For NFS skip the mode change and
let the server handle
On Fri, 14 Sep 2007 23:09:24 +1000
Greg Banks [EMAIL PROTECTED] wrote:
On Fri, Sep 14, 2007 at 07:02:58AM -0400, Jeff Layton wrote:
On Fri, 14 Sep 2007 20:25:45 +1000
Greg Banks [EMAIL PROTECTED] wrote:
I'm curious about the reasons behind this change. You mention
credential issues
On Sat, 15 Sep 2007 00:40:33 +1000
Greg Banks [EMAIL PROTECTED] wrote:
On Fri, Sep 14, 2007 at 09:38:46AM -0400, Jeff Layton wrote:
On Fri, 14 Sep 2007 23:09:24 +1000
Greg Banks [EMAIL PROTECTED] wrote:
On Fri, Sep 14, 2007 at 07:02:58AM -0400, Jeff Layton wrote:
On Fri, 14 Sep
On Sat, 15 Sep 2007 01:43:45 +1000
Greg Banks [EMAIL PROTECTED] wrote:
On Fri, Sep 14, 2007 at 10:58:38AM -0400, Jeff Layton wrote:
On Sat, 15 Sep 2007 00:40:33 +1000
Greg Banks [EMAIL PROTECTED] wrote:
Ok, you convinced me.
Right. When I was first looking at this, I considered
that it should
be removed.
--
Jeff Layton [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Mon, 17 Sep 2007 08:06:15 +0530
Satyam Sharma [EMAIL PROTECTED] wrote:
On 9/17/07, Jeff Layton [EMAIL PROTECTED] wrote:
On Mon, 17 Sep 2007 00:58:54 +0530
Satyam Sharma [EMAIL PROTECTED] wrote:
Hi Jeff,
I think commit 866b04fccbf125cd39f2bdbcfeaa611d39a061a8 was wrong
,
and the comment in notify_change is now a bit more descriptive. I've also
moved the description of the main rationale for the patch into patch 5.
Andrew, would it be possible to go ahead and get this committed to -mm?
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
-
To unsubscribe from this list: send
This patch makes sure ecryptfs doesn't trip the BUG() in notify_change.
It also allows the lower filesystem to interpret ATTR_KILL_S*ID in its
own way.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/ecryptfs/inode.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff
*ID. Just fix up the mode to have the same effect. Also, move
locking the i_mutex to lower in the function. It's not needed until it
checks the i_size.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/unionfs/inode.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git
reiserfs_setattr can call notify_change recursively using the same
iattr struct. This could cause it to trip the BUG() in notify_change.
Fix reiserfs to clear those bits near the beginning of the function.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/reiserfs/inode.c |6 +-
1
If the ATTR_KILL_S*ID bits are set then any mode change is only for
clearing the setuid/setgid bits. For NFS, skip the mode change and
let the server handle it.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/nfs/inode.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff
change was only for the purposes of clearing these bits.
This means that we now have an implicit assumption that notify_change is
never called with ATTR_MODE and either ATTR_KILL_S*ID bit set. Nothing
currently enforces that, so this patch also adds a BUG() if that occurs.
Signed-off-by: Jeff Layton
If the ATTR_KILL_S*ID bits are set then any mode change is only for
clearing the setuid/setgid bits. For CIFS, skip the mode change and
let the server handle it.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/cifs/inode.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff
It's theoretically possible for a single SETATTR call to come in that
sets the mode and the uid/gid. In that case, don't set the ATTR_KILL_S*ID
bits since that would trip the BUG() in notify_change. Just fix up the
mode to have the same effect.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs
On Mon, 17 Sep 2007 07:29:05 -0400
Jeff Layton [EMAIL PROTECTED] wrote:
This patchset is the latest one for fixing the clearing of setuid/setgid
bits in networked filesystems. It should apply cleanly to 2.6.23-rc4-mm1.
This is basically the same patchset as take 5. The main differences
is being submitted for inclusion into -mm.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
Make sure ecryptfs doesn't trip the BUG() in notify_change. This also
allows the lower filesystem to interpret ATTR_KILL_S*ID in its own way.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/ecryptfs/inode.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/fs
It's theoretically possible for a single SETATTR call to come in that
sets the mode and the uid/gid. In that case, don't set the ATTR_KILL_S*ID
bits since that would trip the BUG() in notify_change. Just fix up the
mode to have the same effect.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs
Don't allow unionfs_setattr to trip the BUG() in notify_change. Clear
ATTR_MODE if the either ATTR_KILL_S*ID is set. This also allows the
lower filesystem to interpret these bits in its own way.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/unionfs/inode.c |7 +++
1 files changed
change was only for the purposes of clearing these bits.
This means that we now have an implicit assumption that notify_change is
never called with ATTR_MODE and either ATTR_KILL_S*ID bit set. Nothing
currently enforces that, so this patch also adds a BUG() if that occurs.
Signed-off-by: Jeff Layton
If the ATTR_KILL_S*ID bits are set then any mode change is only for
clearing the setuid/setgid bits. For NFS, skip the mode change and
let the server handle it.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/nfs/inode.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff
If the ATTR_KILL_S*ID bits are set then any mode change is only for
clearing the setuid/setgid bits. For CIFS, skip the mode change and
let the server handle it.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/cifs/inode.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff
reiserfs_setattr can call notify_change recursively using the same
iattr struct. This could cause it to trip the BUG() in notify_change.
Fix reiserfs to clear those bits near the beginning of the function.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/reiserfs/inode.c |6 +-
1
changes.
4) makes cifs_writepages accurately distinguish between EIO and ENOSPC
errors when writing out pages.
Some simple testing indicates that the patch works as expected and that
it fixes the reproducer for the known problem.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/cifs/cifsfs.c
to clean that up would probably be a good thing. We likely
don't need to do a reconnect here.
--
Jeff Layton [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
On Mon, 19 Nov 2007 14:23:13 +0100
Petr Tesarik [EMAIL PROTECTED] wrote:
On Mon, 2007-11-19 at 06:42 -0500, Jeff Layton wrote:
On Mon, 19 Nov 2007 10:30:45 +0100
Petr Tesarik [EMAIL PROTECTED] wrote:
Hi,
while merging commits f01d5e14e764b14b6bf5512678523d009254b209
main loop a bit.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c | 64 +++
1 files changed, 27 insertions(+), 37 deletions(-)
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index 03a83a0..28c290c 100644
--- a/fs/lockd/svc.c
+++ b
of
svc_create_kthread must now call it (or do the equivalent to set up
the svc_rqst.
Tested against the reproducer I have for the main issue (detailed in
patch #7). As always, comments and suggestions are appreciated.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line
lockd makes itself freezable, but never calls try_to_freeze(). Have it
call try_to_freeze() within the main loop.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index
lockd_start_done is a global var that can be reused if lockd is
restarted, but it's never reinitialized. On all but the first use,
wait_for_completion isn't actually waiting on it since it has
already completed once.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c |1 +
1
svc_pool_map_set_cpumask will only affect current as of now. Add a
new arg so that it can change the cpumask on any given task. Also if
we're not changing current we don't care what the oldmask was, so
allow it to be a NULL pointer.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
net/sunrpc
Add a new function svc_create_kthread that spawns svc threads using the
kthread API.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
include/linux/sunrpc/svc.h |2 ++
net/sunrpc/sunrpc_syms.c |1 +
net/sunrpc/svc.c | 19 +++
3 files changed, 22 insertions
Move the initialzation in __svc_create_thread that happens prior to
thread creation to a new function. Export the function so that when
we replace __svc_create_thread with a kthread version, callers will
have complete control over this initialization.
Signed-off-by: Jeff Layton [EMAIL PROTECTED
lockd to check the refcount itself and to return if it goes to
0. We do the checking and exit while holding the nlmsvc_mutex to make
sure that a new lockd is not started until the old one is down.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c | 51
svc_pool_map_set_cpumask will only affect current as of now. Add a
new arg so that it can change the cpumask on any given task. Also if
we're not changing current we don't care what the oldmask was, so
allow it to be a NULL pointer.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
net/sunrpc
lockd_start_done is a global var that can be reused if lockd is
restarted, but it's never reinitialized. On all but the first use,
wait_for_completion isn't actually waiting on it since it has
already completed once.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c |1 +
1
lockd to check the refcount itself and to return if it goes to
0. We do the checking and exit while holding the nlmsvc_mutex to make
sure that a new lockd is not started until the old one is down.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c | 51
main loop a bit.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c | 76 +--
1 files changed, 35 insertions(+), 41 deletions(-)
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index 03a83a0..bb98711 100644
--- a/fs/lockd/svc.c
+++ b
Move the initialzation in __svc_create_thread that happens prior to
thread creation to a new function. Export the function so that when
we replace __svc_create_thread with a kthread version, callers will
have complete control over this initialization.
Signed-off-by: Jeff Layton [EMAIL PROTECTED
Needed since the plan is to not have a svc_create_thread helper and to
have current users of that function just call kthread_run directly.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
net/sunrpc/sunrpc_syms.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/sunrpc
made some changes to the function prototype for
the lockd function to eliminate the need for casting the function
pointer.
Tested against the reproducer I have for the main issue (detailed in
patch #7). As always, comments and suggestions are appreciated.
Signed-off-by: Jeff Layton [EMAIL
lockd makes itself freezable, but never calls try_to_freeze(). Have it
call try_to_freeze() within the main loop.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index
take the nlmsvc_mutex when checking the
nlmsvc_ref and holding it until exit if the ref has gone to 0. With
this, there's no reason to have lockd_down wait for lockd to come down,
so it now returns immediately after sending the signal.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c
.
Currently sending a SIGKILL to lockd tells it to drop all of its locks
without exiting. If we change lockd to use kthreads, will we have to
change that to use a different mechanism?
--
Jeff Layton [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
on itself
since it will deadlock.
Is there a way to gracefully allow a kthread to shut itself down?
Alternately, I suppose I could schedule_work() the kthread_stop, though
that seems sort of ugly...
--
Jeff Layton [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe linux
counting that's needed
to fix the original problem.
Unfortunately, moving the refcounting outside of the thread altogether
isn't feasible for reasons outlined in description of the 6th patch.
Comments and suggestions appreciated...
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
--
To unsubscribe from
svc_pool_map_set_cpumask will only affect current as of now. Add a
new arg so that it can change the cpumask on any given task. Also if
we're not changing current we don't care what the oldmask was, so
allow it to be a NULL pointer.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
net/sunrpc
of the callers to the
kthread API, at which point we can drop __svc_create_thread.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
include/linux/sunrpc/svc.h |2 +
net/sunrpc/sunrpc_syms.c |1 +
net/sunrpc/svc.c | 69 +++
3 files changed, 65
lockd_start_done is a global var that can be reused if lockd is
restarted, but it's never reinitialized. On all but the first use,
wait_for_completion isn't actually waiting on it since it has
already completed once.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c |1 +
1
lockd makes itself freezable, but never calls try_to_freeze(). Have it
call try_to_freeze() within the main loop.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index
main loop a bit.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c | 53 -
1 files changed, 16 insertions(+), 37 deletions(-)
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index 03a83a0..1303ce8 100644
--- a/fs/lockd/svc.c
+++ b/fs
and exit while holding the nlmsvc_mutex to make sure that a
new lockd is not started until the old one is down.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c | 51 --
fs/lockd/svclock.c |5
include/linux/lockd
On Thu, 13 Dec 2007 21:06:44 +
Christoph Hellwig [EMAIL PROTECTED] wrote:
On Thu, Dec 13, 2007 at 03:40:24PM -0500, Jeff Layton wrote:
Move the initialization that happens prior to thread creation to a
new function (svc_prepare_thread) so that we can call it from a new
thread creation
Move the initialzation in __svc_create_thread that happens prior to
thread creation to a new function. Export the function to allow
services to have better control over the svc_rqst structs.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
include/linux/sunrpc/svc.h |2 ++
net/sunrpc/svc.c
and Christoph Hellwig for
their guidance on this.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
lockd makes itself freezable, but never calls try_to_freeze(). Have it
call try_to_freeze() within the main loop.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index
lockd to check the refcount itself and to return if it goes to
0. We do the checking and exit while holding the nlmsvc_mutex to make
sure that a new lockd is not started until the old one is down.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c | 51
lockd_start_done is a global var that can be reused if lockd is
restarted, but it's never reinitialized. On all but the first use,
wait_for_completion isn't actually waiting on it since it has
already completed once.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/lockd/svc.c |1 +
1
Fix some warnings with SMBFS_DEBUG_* builds. This patch makes it so
that builds with -Werror don't fail.
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/smbfs/file.c |7 ---
fs/smbfs/inode.c |2 +-
fs/smbfs/proc.c |2 +-
fs/smbfs/smbiod.c |2 +-
4 files changed, 7
that should represent the
amount of unread data in the response.
I think this is correct, but an ACK or NACK from someone more familiar
with this code would be appreciated...
Signed-off-by: Jeff Layton [EMAIL PROTECTED]
---
fs/smbfs/sock.c |5 ++---
1 files changed, 2 insertions(+), 3
do so. That may be the
problem here.
--
Jeff Layton [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
On Tue, 30 Oct 2012 12:14:29 -0400
J. Bruce Fields bfie...@fieldses.org wrote:
On Sat, Oct 27, 2012 at 08:33:18AM -0400, Jeff Layton wrote:
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/namei.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git
On Tue, 30 Oct 2012 15:28:09 -0400
J. Bruce Fields bfie...@fieldses.org wrote:
On Tue, Oct 30, 2012 at 12:33:55PM -0400, Jeff Layton wrote:
On Tue, 30 Oct 2012 12:14:29 -0400
J. Bruce Fields bfie...@fieldses.org wrote:
On Sat, Oct 27, 2012 at 08:33:18AM -0400, Jeff Layton wrote
1 - 100 of 4603 matches
Mail list logo
