Error/bug in the "tulip" network driver from the 2.4.0-test11 kernel, when
detecting media type.
The bug is quite simple. When detecting the media type, it's possible to
access data outside/beyond the array "medianame[]". This leads to an
kernel panic Oops.
I detected the bug, when using
Help people reading the percpu_counter code, to notice the ifdef
else statement that seperates CONFIG_SMP.
Signed-off-by: Jesper Dangaard Brouer bro...@redhat.com
Acked-by: Tejun Heo t...@kernel.org
---
include/linux/percpu_counter.h |2 +-
1 files changed, 1 insertions(+), 1 deletions
Help people reading the percpu_counter code, to notice the ifdef
else statement that seperates CONFIG_SMP.
Signed-off-by: Jesper Dangaard Brouer bro...@redhat.com
---
include/linux/percpu_counter.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux
100Mbit/s.
(ps. I'm the original author of http://www.adsl-optimizer.dk/ and
http://sourceforge.net/projects/adsl-optimizer/)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com
On Tue, 20 Aug 2013 08:16:50 -0700
Greg Kroah-Hartman gre...@linuxfoundation.org wrote:
On Tue, Aug 20, 2013 at 01:26:29PM +0200, Jesper Dangaard Brouer wrote:
[...]
If there are issues with 3.10, that's a different story.
Refactor improvements (v3.11-rc1):
commit 130d3d68b52
On Wed, 21 Aug 2013 11:20:23 -0700 (PDT)
David Miller da...@davemloft.net wrote:
From: Jesper Dangaard Brouer bro...@redhat.com
Date: Wed, 21 Aug 2013 14:03:50 +0200
On Tue, 20 Aug 2013 08:16:50 -0700
Greg Kroah-Hartman gre...@linuxfoundation.org wrote:
On Tue, Aug 20, 2013 at 01:26
On Thu, 22 Aug 2013 01:23:48 -0700 (PDT)
David Miller da...@davemloft.net wrote:
From: Jesper Dangaard Brouer bro...@redhat.com
Date: Thu, 22 Aug 2013 10:04:26 +0200
So, for future reference:
Stable patches for the networking tree, I should:
1) check http://patchwork.ozlabs.org
nf_exp_event_notifier __rcu *nf_expect_event_cb;
- struct nf_ip_netnf_ct_proto;
+
#if defined(CONFIG_NF_CONNTRACK_LABELS)
unsigned intlabels_used;
u8 label_words;
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red
touches it if it's empty.
This a good fix, and better than my earlier attempt at fixing this.
Thanks!
Signed-off-by: Jesper Dangaard Brouer bro...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
://www.linuxvirtualserver.org/software/ipvs.html#kernel-2.6
http://www.linuxvirtualserver.org/software/kernel-2.6/
Maintainers:
Simon Horman ho...@verge.net.au
Jesper Dangaard Brouer bro...@redhat.com
Wensong Zhang wens...@linux-vs.org
The development have slowed down over the past years, as the tool and
kernel
);
+ else
+ atomic_dec((pkt_dev-skb-users));
pkt_dev-last_ok = 0;
}
unlock:
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com
On Fri, 02 May 2014 07:00:00 -0700
John Fastabend john.r.fastab...@intel.com wrote:
On 5/2/2014 6:19 AM, Jesper Dangaard Brouer wrote:
On Fri, 2 May 2014 15:18:12 +0800
Zhouyi Zhou zhouzho...@gmail.com wrote:
As http://www.spinics.net/lists/netdev/msg165015.html
pktgen generates
Signed-off-by: Jesper Dangaard Brouer bro...@redhat.com
---
include/linux/percpu-refcount.h |2 +-
net/rds/af_rds.c|2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/percpu-refcount.h b/include/linux/percpu-refcount.h
index 95961f0
.
Am I right to do this ?
Appreciate any comments and reply.
Perhaps we could get rid of unconfirmed list handling in get_next_corpse?
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http
On Wed, 10 Dec 2014 13:51:32 -0600 (CST)
Christoph Lameter c...@linux.com wrote:
On Wed, 10 Dec 2014, Jesper Dangaard Brouer wrote:
One of the building blocks for achieving this speedup is a cmpxchg
based Lock-Free queue that supports bulking, named alf_queue for
Array-based Lock-Free
(is_pointer_to_page(page, c-freelist))) {
set_freepointer(s, object, c-freelist);
if (unlikely(!this_cpu_cmpxchg_double(
[1]
https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/time_bench_kmem_cache1.c
--
Best regards,
Jesper Dangaard Brouer
://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/time_bench_kmem_cache1.c
[2]
https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/mm/qmempool_bench.c
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http
On Thu, 11 Dec 2014 09:03:24 -0600 (CST)
Christoph Lameter c...@linux.com wrote:
On Thu, 11 Dec 2014, Jesper Dangaard Brouer wrote:
It looks like an impressive saving 116 - 60 cycles. I just don't see
the same kind of improvements with my similar tests[1][2].
This is particularly
Warning, I'm getting crashes with this patchset, during my network load testing.
I don't have a nice crash dump to show, yet, but it is in the slub code.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
On Thu, 11 Dec 2014 11:18:31 -0600 (CST)
Christoph Lameter c...@linux.com wrote:
On Thu, 11 Dec 2014, Jesper Dangaard Brouer wrote:
I was expecting to see at least (specifically) 4.291 ns improvement, as
this is the measured[1] cost of preempt_{disable,enable] on my system.
Right. Those
On Thu, 11 Dec 2014 18:37:58 +0100
Jesper Dangaard Brouer bro...@redhat.com wrote:
Warning, I'm getting crashes with this patchset, during my network load
testing.
I don't have a nice crash dump to show, yet, but it is in the slub code.
Crash/OOM during IP-forwarding network overload test[1
stack. Now,
Christoph and I are trying to integrate some of the ideas into the slub
allocator.
[1] http://thread.gmane.org/gmane.linux.network/342347/focus=126138
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
(kernel 3.18.0-net-next+ SMP PREEMPT on top of f96fe225677)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
--
To unsubscribe from this list: send the line
there is a multiplication in the fast path.
Could we pre-calculate the value (page-objects * s-size) and e.g store it
in struct kmem_cache, thus saving the imul ?
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn
-pattern with 256 elements
Type:qmempool alloc+free N-pattern Per elem: 62 cycles(tsc) 24.955 ns (step:0)
- (measurement period time:0.638871008 sec time_interval:638871008)
- (invoke count:2560 tsc_interval:1597176303)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel
,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
/prototype-kernel/blob/master/kernel/mm/qmempool_bench.c
[3]: http://thread.gmane.org/gmane.linux.network/342347
[4]: https://github.com/netoptimizer/prototype-kernel
---
Jesper Dangaard Brouer (3):
net: use qmempool in-front of sk_buff kmem_cache
mm: qmempool - quick queue based memory
concurrency).
IP-forward MULTI flow/cpu (12 CPUs E5-2695 no-HT, 12 HWQs):
* baseline: 11,946,666 pps
* qmempool: 11,988,042 pps
- Diff to baseline: +41376 pps = -0.29 ns
Signed-off-by: Jesper Dangaard Brouer bro...@redhat.com
---
include/linux/skbuff.h |4 +++-
net/core/dev.c |5
- 7.837 ns - 18.536 ns
N(256)-pattern: 45.039 ns - 11.782 ns - 24.186 ns
A significant win for usage from softirq, and a smaller win for
none-softirq which requires taking local_bh_{disable,enable}.
Signed-off-by: Jesper Dangaard Brouer bro...@redhat.com
---
include/linux/qmempool.h | 205
On Wed, 10 Dec 2014 14:22:22 +
David Laight david.lai...@aculab.com wrote:
From: Jesper Dangaard Brouer
The network stack have some use-cases that puts some extreme demands
on the memory allocator. One use-case, 10Gbit/s wirespeed at smallest
packet size[1], requires handling a packet
-- 1.109 ns
Joint work with Hannes Frederic Sowa.
Signed-off-by: Jesper Dangaard Brouer bro...@redhat.com
Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org
---
Correctness of memory barries on different arch's need to be evaluated.
The API might need some adjustments/discussions
On Wed, 10 Dec 2014 09:17:32 -0600 (CST)
Christoph Lameter c...@linux.com wrote:
On Wed, 10 Dec 2014, Jesper Dangaard Brouer wrote:
Patch1: alf_queue (Lock-Free queue)
For some reason that key patch is not in my linux-mm archives nor in my
inbox.
That is very strange! I did notice
of the kmem_cache is only known to the
allocator itself.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
--
To unsubscribe from this list: send the line unsubscribe linux
/watch?v=3XG9-X777Jo
LWN: Toward a more efficient slab allocator
- http://lwn.net/Articles/629152/
- YouTube: https://www.youtube.com/watch?v=s0lZzP1jOzI
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
compile warning in modprobe_ipvs
Hibari Michiro (1):
ipvsadm: enable displaying of IPv6 hostnames in listing
Jesper Dangaard Brouer (1):
Release: Version 1.28
Julian Anastasov (3):
ipvsadm: restrict different address family
ipvsadm: allow different address family
On Thu, 15 Jan 2015 16:40:32 +0900
Joonsoo Kim iamjoonsoo@lge.com wrote:
[...]
I saw roughly 5% win in a fast-path loop over kmem_cache_alloc/free
in CONFIG_PREEMPT. (14.821 ns - 14.049 ns)
Below is the result of Christoph's slab_test reported by
Jesper Dangaard Brouer.
[...]
Acked
On Wed, 11 Feb 2015 13:07:24 -0600 (CST)
Christoph Lameter c...@linux.com wrote:
On Wed, 11 Feb 2015, Jesper Dangaard Brouer wrote:
+
+
+ spin_lock_irqsave(n-list_lock, flags);
This is quite an expensive lock with irqsave.
Yes but we take it for all partial pages.
Sure
On Wed, 11 Feb 2015 16:06:50 -0600 (CST)
Christoph Lameter c...@linux.com wrote:
On Thu, 12 Feb 2015, Jesper Dangaard Brouer wrote:
This is quite an expensive lock with irqsave.
[...]
We can require that interrupt are off when the functions are called. Then
we can avoid the save part
this alloc_array have likely ran out of elems (from
it's local store/prev-call) and need to handout one elem immediately
after this call returns.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http
:-)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
buik - bulk
+ */
+int __kmem_cache_alloc_array(struct kmem_cache *s,
+ gfp_t flags, size_t nr, void **p)
+{
[...]
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http
be used to provide the objects required.
I'll volunteer to performance benchmark the different allocators
optimized functions in this area. (I'll have time after April 13th).
Signed-off-by: Christoph Lameter c...@linux.com
Acked-by: Jesper Dangaard Brouer bro...@redhat.com
--
Best regards
.
Signed-off-by: Christoph Lameter c...@linux.com
Cc: Jesper Dangaard Brouer bro...@redhat.com
Cc: Christoph Lameter c...@linux.com
Cc: Pekka Enberg penb...@kernel.org
Cc: David Rientjes rient...@google.com
Cc: Joonsoo Kim iamjoonsoo@lge.com
Signed-off-by: Andrew Morton a...@linux
On Tue, 16 Jun 2015 15:52:09 +0200 Jan Kara j...@suse.cz wrote:
On Tue 16-06-15 13:33:18, Jesper Dangaard Brouer wrote:
Caught by kmemcheck.
Don't know the fix... just pointed at the bug.
Introduced in commit 7053aee26a3 (fsnotify: do not share
events between notification groups
-# Burst allow us to avoid measuring SKB alloc/free overhead
+# Burst allows us to avoid measuring SKB alloc/free overhead
pg_set $dev burst $BURST
Acked-by: Jesper Dangaard Brouer bro...@redhat.com
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
On Wed, 17 Jun 2015 10:13:19 +0200
Jan Kara j...@suse.cz wrote:
On Tue 16-06-15 22:22:34, Jesper Dangaard Brouer wrote:
On Tue, 16 Jun 2015 15:52:09 +0200 Jan Kara j...@suse.cz wrote:
On Tue 16-06-15 13:33:18, Jesper Dangaard Brouer wrote:
Caught by kmemcheck.
Don't know
Caught by kmemcheck.
Don't know the fix... just pointed at the bug.
Introduced in commit 7053aee26a3 (fsnotify: do not share
events between notification groups).
---
fs/notify/inotify/inotify_fsnotify.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
the main Linux Kernel Mailing List
(linux-kernel@vger.kernel.org) with a trivial patch like this. Sending
it to the network developers should be enough (net...@vger.kernel.org).
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv
.
- */
- return compound_head_fast(page);
+ return compound_head(page);
}
I hope this does not slow down the SLAB/slub allocator?
(which calls virt_to_head_page() frequently)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv
: between 61-73 (average: 68.10 stddev:+/-2.9)
This: between 90-104(average: 94.91 stddev:+/-2.1)
[1]
https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/mm/slab_bulk_test02.c
[2] https://github.com/rustyrussell/stats
Signed-off-by: Jesper Dangaard Brouer bro...@redhat.com
---
bulk
of
page bulking into __slab_free(). While running the worse-case
testing module slab_bulk_test03.c
---
Jesper Dangaard Brouer (3):
slub: extend slowpath __slab_free() to handle bulk free
slub: optimize bulk slowpath free by detached freelist
slub: build detached freelist with look
the same
slab-page) to be free'ed using a single locked cmpxchg_double.
Micro benchmarking showed no performance reduction due to this change.
Signed-off-by: Jesper Dangaard Brouer bro...@redhat.com
---
V2: Per request of Christoph Lameter
* Made it more clear that freelist objs must exist within
. Splitting them up, because I want to be able to
benchmark the simple against the advanced approach.
Signed-off-by: Jesper Dangaard Brouer bro...@redhat.com
---
bulk- Fallback - Bulk API
1 - 64 cycles(tsc) 16.109 ns - 47 cycles(tsc) 11.894 - improved 26.6%
2 - 56 cycles(tsc
In function fail_dump() printk output of the attributes interval and
probability got swapped. This was introduced in commit
6adc4a22f20b ("fault-inject: add ratelimit option").
Fixes: 6adc4a22f20b ("fault-inject: add ratelimit option")
Signed-off-by: Jesper Dangaard Broue
Disregard this patch... Florian already fixed it in:
bb387002693e ("fault-inject: fix inverted interval/probability values in
printk")
$ git describe --contains bb387002693e
v4.3-rc7~11^2~1
On Tue, 17 Nov 2015 12:48:37 +0100
Jesper Dangaard Brouer <bro...@redhat.com> wrote
> +
> +static inline int skb_array_peek_len(struct skb_array *a)
> +{
> + return PTR_RING_PEEK_CALL(>ring, __skb_array_len_with_tag);
> +}
> +
[...]
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
in_lock_bh()
> + ptr = __ptr_ring_consume(r);
> + spin_unlock(>consumer_lock);
and spin_unlock_bh()
> +
> + return ptr;
> +}
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
array_XXX APIs with a spinlock,
> so this should not be an issue for them.
I would like to see some bulking support...
As my experiments[1] show that alf_queue (primarily) can beat skb_array due
to bulking support. It seems like an obvious optimization for the virt
tun use-case to bulk dequeue SK
On Thu, 2 Jun 2016 20:47:25 +0200
Jesper Dangaard Brouer <bro...@redhat.com> wrote:
> On Tue, 24 May 2016 23:34:14 +0300
> "Michael S. Tsirkin" <m...@redhat.com> wrote:
>
> > On Tue, May 24, 2016 at 07:03:20PM +0200, Jesper Dangaard Brouer wrote:
> >
ppers around ptr_array.
^
It is called "ptr_ring" not "ptr_array".
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
t; destroy now scans the array and frees all queued skbs
>
> changes since v5
> implemented a generic ptr_ring api, and
> made skb_array a type-safe wrapper
> apis for taking the spinlock in different contexts
> following expected usecase
On Mon, 13 Jun 2016 23:54:50 +0300
"Michael S. Tsirkin" <m...@redhat.com> wrote:
> Update skb_array after ptr_ring API changes.
>
> Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
Acked-by: Jesper Dangaard Brouer <bro...@redhat.com>
Tested-by: Jesp
ains destructor callback such that
> all pointers in queue can be cleaned up.
>
> This changes some APIs but we don't have any users yet,
> so it won't break bisect.
>
> Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
Acked-by: Jesper Dangaard Brouer <bro...@redhat
On Mon, 13 Jun 2016 23:54:31 +0300
"Michael S. Tsirkin" <m...@redhat.com> wrote:
> A simple array based FIFO of pointers. Intended for net stack which
> commonly has a single consumer/producer.
>
> Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
Ack
kin <m...@redhat.com>
Acked-by: Jesper Dangaard Brouer <bro...@redhat.com>
Tested-by: Jesper Dangaard Brouer <bro...@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
On Tue, 24 May 2016 23:34:14 +0300
"Michael S. Tsirkin" <m...@redhat.com> wrote:
> On Tue, May 24, 2016 at 07:03:20PM +0200, Jesper Dangaard Brouer wrote:
> >
> > On Tue, 24 May 2016 12:28:09 +0200
> > Jesper Dangaard Brouer <bro...@redhat.com> wrot
t got the below dmesg and the first bad commit is
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>
> commit a1fd55538cae9f411059c9b067a3d48c41aa876b
> Author: Jesper Dangaard Brouer <bro...@redhat.com>
> AuthorDate: Thu Jan 28 09:47:16 20
On Sun, 31 Jan 2016 13:15:06 +1100
Stephen Rothwell <s...@canb.auug.org.au> wrote:
> Hi Jesper,
>
> On Sat, 30 Jan 2016 18:46:46 +0100 Jesper Dangaard Brouer <bro...@redhat.com>
> wrote:
> >
> > Let me know, if the linux-next tree need's an explicit fix?
On Sat, 30 Jan 2016 02:09:30 -0500
valdis.kletni...@vt.edu wrote:
> On Thu, 28 Jan 2016 18:47:49 +0100, Jesper Dangaard Brouer said:
> > I cannot reproduce below problem... have enabled all kind of debugging
> > and also lockdep.
> >
> > Can I get a version of the .c
se
the NAPI call, if you indeed are running in NAPI/BH context.
> else
> - return kmalloc(pp->frag_size, GFP_ATOMIC);
> + return kmalloc(frag_size, GFP_ATOMIC);
> }
> +EXPORT_SYMBOL_GPL(mvneta_frag_alloc);
--
Best regards,
Jesper Dangaar
pr_warn("Adding %d buffers to the %d current buffers will
> overflow\n",
> + buf_num, bm_pool->buf_num);
> + return 0;
> + }
> +
> + for (i = 0; i < buf_num; i++) {
> + err = hwbm_pool_refill(bm_p
stpath is here:
https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/mm/slab_bulk_test01.c
And I also carry a version of Christoph's slab bench tool:
https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/mm/slab_test.c
--
Best regards,
Jesper Dangaard Brouer
MSc.CS,
the absolute
numbers are not that important.
Oh, maybe this was because I ran the test with SLUB... recompiling with
SLAB... and the results are comparable to your numbers (on my 8 core
i7-4790K CPU @ 4.00GHz)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
On Mon, 7 Mar 2016 12:54:13 -0500
Willem de Bruijn <willemdebruijn.ker...@gmail.com> wrote:
> On Mon, Mar 7, 2016 at 10:36 AM, Jesper Dangaard Brouer
> <jbro...@redhat.com> wrote:
> > Hi Google,
> >
> > While playing with RPS, I needed to read stats from
> &
statistics from /proc/net/softnet_stat.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
[1] https://www.redhat.com/archives/rhl-list/2007-September/msg03735.html
[2] https
ire_slab")) {
> + if (retry_count++ < RETRY_COUNT) {
> + new.frozen = 0;
> + goto again;
> + }
> return NULL;
> + }
>
> remove_partial(n, page);
> WARN_ON(!freelist);
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
On Wed, 18 May 2016 19:26:38 +0300
"Michael S. Tsirkin" <m...@redhat.com> wrote:
> On Wed, May 18, 2016 at 10:13:59AM +0200, Jesper Dangaard Brouer wrote:
> > I agree. It is sad to see everybody is implementing the same thing,
> > open coding an array/circula
.o
^^^^^^^ ^^^^^
> +skb_array: skb_array.o main.o
> clean:
> -rm main.o
> -rm ring.o ring
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
On Mon, 23 May 2016 23:52:47 +0300
"Michael S. Tsirkin" <m...@redhat.com> wrote:
> On Mon, May 23, 2016 at 03:09:18PM +0200, Jesper Dangaard Brouer wrote:
> > On Mon, 23 May 2016 13:43:46 +0300
> > "Michael S. Tsirkin" <m...@redhat.com> wrote:
&g
On Tue, 24 May 2016 12:28:09 +0200
Jesper Dangaard Brouer <bro...@redhat.com> wrote:
> I do like perf, but it does not answer my questions about the
> performance of this queue. I will code something up in my own
> framework[2] to answer my own performance questions.
>
> Li
my experience, yes, adding a modulus does affect performance.
> > If yes, round it up to next power of two.
>
> Right, this sounds a good solution.
Good idea.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-
On Wed, 18 May 2016 11:21:59 +0300
"Michael S. Tsirkin" <m...@redhat.com> wrote:
> On Wed, May 18, 2016 at 10:16:31AM +0200, Jesper Dangaard Brouer wrote:
> >
> > On Tue, 17 May 2016 09:38:37 +0800 Jason Wang <jasow...@redhat.com> wrote:
> >
> &
ure.
You cannot use my alf_queue directly as your "struct tun_desc" is
larger than one-pointer (which the alf_queue works with). But it
should be possible to extend to handle larger "objects".
Maybe Steven Rostedt have an even better ring queue implementation
already avail in the kernel?
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
8 cycles
Parallel-CPUs:7 page order:3(32768B/x8) ave 8436 cycles per-4096B 1054 cycles
Parallel-CPUs:8 page order:3(32768B/x8) ave 9589 cycles per-4096B 1198 cycles
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
On Tue, 8 Mar 2016 10:50:56 +0100
Jesper Dangaard Brouer <jbro...@redhat.com> wrote:
> On Mon, 7 Mar 2016 12:54:13 -0500
> Willem de Bruijn <willemdebruijn.ker...@gmail.com> wrote:
>
> > On Mon, Mar 7, 2016 at 10:36 AM, Jesper Dangaard Brouer
> > <jbro...@
Describe what eBPF maps are, how to create them, and how to
interact with them.
Thanks to Quentin Monnet <quentin.mon...@6wind.com> for improving
this document by fixing many typos and early review.
Signed-off-by: Jesper Dangaard Brouer <bro...@redhat.com>
---
Documentation/bpf/e
com> for improving
this document with areas eBFP is used in and early review.
Signed-off-by: Jesper Dangaard Brouer <bro...@redhat.com>
---
Documentation/bpf/index.rst | 66 +++
Documentation/index.rst |1 +
2 files changed, 67 insertions(+)
It is worth mentioning BCC (BPF Compiler Collection) in-order
to direct developers into that community.
Reviewed-by: Alexander Alemayhu <alexan...@alemayhu.com>
Signed-off-by: Jesper Dangaard Brouer <bro...@redhat.com>
---
Documentation/bpf/bcc_tool_chai
The purpose is to help choose the right map type based on the
individual use-case.
To start with, only BPF_MAP_TYPE_ARRAY is described. It is the plan
that all types should have descriptions here.
Signed-off-by: Jesper Dangaard Brouer <bro...@redhat.com>
---
Documentation/bpf/ebpf_ma
x.net>
Quentin Monnet <quentin.mon...@6wind.com>
---
Jesper Dangaard Brouer (4):
doc/bpf: start eBPF documentation tree bpf/
doc/bpf: document interacting with eBPF maps
doc/bpf: describes the different types of eBPF maps available
doc/bpf: describe BCC the
On Tue, 7 Feb 2017 08:37:17 -0700
Jonathan Corbet <cor...@lwn.net> wrote:
> On Tue, 07 Feb 2017 15:30:11 +0100
> Jesper Dangaard Brouer <bro...@redhat.com> wrote:
>
> > Question: What kernel tree should this go into???
> >
> > If going through Jona
On Tue, 7 Feb 2017 09:46:08 -0700
Jonathan Corbet <cor...@lwn.net> wrote:
> On Tue, 7 Feb 2017 17:09:08 +0100
> Jesper Dangaard Brouer <bro...@redhat.com> wrote:
>
> > > > Question: What kernel tree should this go into???
> > > >
> > > >
On Tue, 07 Feb 2017 17:43:38 +0100
Daniel Borkmann <dan...@iogearbox.net> wrote:
> Hi Jesper,
>
> On 02/07/2017 03:30 PM, Jesper Dangaard Brouer wrote:
> > Question: What kernel tree should this go into???
> >
> > If going through Jonathan Corbet, will it
On Tue, 7 Feb 2017 14:23:23 -0700
Jonathan Corbet <cor...@lwn.net> wrote:
> On Tue, 7 Feb 2017 21:51:49 +0100
> Jesper Dangaard Brouer <bro...@redhat.com> wrote:
>
> > I sounds like Daniel (see other email) have bigger plans for what
> > Documentation/BPF/ sh
tistics(preferred_zone, zone, gfp_flags);
Word-of-warning: The zone_statistics() call changed number of
parameters in commit 41b6167e8f74 ("mm: get rid of __GFP_OTHER_NODE").
(Not sure what tree you are based on)
> + }
> + local_irq_restore(flags);
> + return page
> It shows a roughly 50-60% reduction in the cost of allocating pages.
> The free paths are not improved as much but relatively little can be batched
> there. It's not quite as fast as it could be but taking further shortcuts
> would require making a lot of assumptions about the state of the page and
> the context of the caller.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
On Wed, 31 Aug 2016 13:42:30 -0700
Eric Dumazet <eric.duma...@gmail.com> wrote:
> On Wed, 2016-08-31 at 21:40 +0200, Jesper Dangaard Brouer wrote:
>
> > I can confirm the improvement of approx 900Kpps (no wonder people have
> > been complaining about DoS
:21.53 netserver
10784 24.3 0:21.53 netserver
10785 24.3 0:21.52 netserver
10786 24.3 0:21.50 netserver
3 2.7 3:12.18 ksoftirqd/0
> Reported-by: Paolo Abeni <pab...@redhat.com>
> Reported-by: Hannes Frederic Sowa <han...@stressinduktion.org>
> Signed-off-by: Eri
On Wed, 31 Aug 2016 23:51:16 +0200
Jesper Dangaard Brouer <jbro...@redhat.com> wrote:
> On Wed, 31 Aug 2016 13:42:30 -0700
> Eric Dumazet <eric.duma...@gmail.com> wrote:
>
> > On Wed, 2016-08-31 at 21:40 +0200, Jesper Dangaard Brouer wrote:
> >
> > &g
ax queue of 47MBytes, and worse an average standing queue of
25Mbytes, which is really bad for the latency seen by the
application. And having this much outstanding memory is also bad for
CPU cache size effects, and stressing the memory allocator.
I'm actually using this huge queue "misco
1 - 100 of 555 matches
Mail list logo
