Help people reading the percpu_counter code, to notice the ifdef
else statement that seperates CONFIG_SMP.
Signed-off-by: Jesper Dangaard Brouer
Acked-by: Tejun Heo
---
include/linux/percpu_counter.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux
Help people reading the percpu_counter code, to notice the ifdef
else statement that seperates CONFIG_SMP.
Signed-off-by: Jesper Dangaard Brouer
---
include/linux/percpu_counter.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/percpu_counter.h b/include
://www.linuxvirtualserver.org/software/ipvs.html#kernel-2.6
http://www.linuxvirtualserver.org/software/kernel-2.6/
Maintainers:
Simon Horman
Jesper Dangaard Brouer
Wensong Zhang
The development have slowed down over the past years, as the tool and
kernel in this area have stabilized. As can be seen by the
d system, which this commit
removed, would get inaccurate at rates above 100Mbit/s.
(ps. I'm the original author of http://www.adsl-optimizer.dk/ and
http://sourceforge.net/projects/adsl-optimizer/)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at
On Tue, 20 Aug 2013 08:16:50 -0700
Greg Kroah-Hartman wrote:
> On Tue, Aug 20, 2013 at 01:26:29PM +0200, Jesper Dangaard Brouer wrote:
[...]
> If there are issues with 3.10, that's a different story.
>
> > Refactor improvements (v3.11-rc1):
> > com
On Wed, 21 Aug 2013 11:20:23 -0700 (PDT)
David Miller wrote:
> From: Jesper Dangaard Brouer
> Date: Wed, 21 Aug 2013 14:03:50 +0200
>
> >
> > On Tue, 20 Aug 2013 08:16:50 -0700
> > Greg Kroah-Hartman wrote:
> >> On Tue, Aug 20, 2013 at 01:26:29PM
On Thu, 22 Aug 2013 01:23:48 -0700 (PDT)
David Miller wrote:
> From: Jesper Dangaard Brouer
> Date: Thu, 22 Aug 2013 10:04:26 +0200
>
> > So, for future reference:
> >
> > Stable patches for the networking tree, I should:
> > 1) check http://patchwork.ozla
agment into hash
> and inet_frag_lru_move() doesn't touches it if it's empty.
This a good fix, and better than my earlier attempt at fixing this.
Thanks!
Signed-off-by: Jesper Dangaard Brouer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the b
Error/bug in the "tulip" network driver from the 2.4.0-test11 kernel, when
detecting media type.
The bug is quite simple. When detecting the media type, it's possible to
access data outside/beyond the array "medianame[]". This leads to an
kernel panic Oops.
I detected the bug, when using th
ur
script...
The mentioned commit: d0ecd894e3d5f768a84 removes a call point to
__slab_free() and instead call slab_free(). It does not make sense to
my, why this results in a linker error on this ARCH=microblaze.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
! It is a very important fix, as least
for networking.
This is your git tree, right:
https://git.kernel.org/cgit/linux/kernel/git/peterz/queue.git/
Doesn't look like you pushed it yet, or do I need to look at a specific
branch?
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Ke
3 netserver
10785 24.3 0:21.52 netserver
10786 24.3 0:21.50 netserver
3 2.7 3:12.18 ksoftirqd/0
> Reported-by: Paolo Abeni
> Reported-by: Hannes Frederic Sowa
> Signed-off-by: Eric Dumazet
> Cc: David Miller Cc: Jesper Dangaard Brouer
> Cc: Peter Zijlstra
> Cc:
On Wed, 31 Aug 2016 13:42:30 -0700
Eric Dumazet wrote:
> On Wed, 2016-08-31 at 21:40 +0200, Jesper Dangaard Brouer wrote:
>
> > I can confirm the improvement of approx 900Kpps (no wonder people have
> > been complaining about DoS against UDP/DNS servers).
> >
>
87.698
I see max queue of 47MBytes, and worse an average standing queue of
25Mbytes, which is really bad for the latency seen by the
application. And having this much outstanding memory is also bad for
CPU cache size effects, and stressing the memory allocator.
I'm actually using this huge queue
On Wed, 31 Aug 2016 23:51:16 +0200
Jesper Dangaard Brouer wrote:
> On Wed, 31 Aug 2016 13:42:30 -0700
> Eric Dumazet wrote:
>
> > On Wed, 2016-08-31 at 21:40 +0200, Jesper Dangaard Brouer wrote:
> >
> > > I can confirm the improvement of approx 900Kpps (no
On Thu, 1 Sep 2016 13:53:56 +0200
Peter Zijlstra wrote:
> On Thu, Sep 01, 2016 at 01:02:31PM +0200, Jesper Dangaard Brouer wrote:
> >PID S %CPU TIME+ COMMAND
> > 3 R 50.0 29:02.23 ksoftirqd/0
> > 10881 R 10.7 1:01.61 udp_sink
> > 10837
On Thu, 1 Sep 2016 14:29:25 +0200
Jesper Dangaard Brouer wrote:
> On Thu, 1 Sep 2016 13:53:56 +0200
> Peter Zijlstra wrote:
>
> > On Thu, Sep 01, 2016 at 01:02:31PM +0200, Jesper Dangaard Brouer wrote:
> > >PID S %CPU TIME+ COMMAND
> > >
On Thu, 1 Sep 2016 14:48:39 +0200
Peter Zijlstra wrote:
> On Thu, Sep 01, 2016 at 02:38:59PM +0200, Jesper Dangaard Brouer wrote:
> > On Thu, 1 Sep 2016 14:29:25 +0200
> > Jesper Dangaard Brouer wrote:
> >
> > > On Thu, 1 Sep 2016 13:53:56 +02
On Thu, 1 Sep 2016 17:28:02 +0200
Peter Zijlstra wrote:
> On Thu, Sep 01, 2016 at 03:30:42PM +0200, Jesper Dangaard Brouer wrote:
> > Still... enabled!
> > Hmmm.. more idea how to disable this???
>
> I think you ought to be able to assign yourself to the root cgr
c(data, src_mac, dest_mac);
> + value = bpf_map_lookup_elem(&rxcnt, &ipproto);
> + if (value)
> + *value += 1;
> + return bpf_redirect(forward_to, 0);
Notice that using bpf_redirect() is slow, while using bpf_redirect_
eing said, feel free to add
> Acked-by: Michal Hocko
I will also happily ACK this patch, you can add:
Acked-by: Jesper Dangaard Brouer
> Thanks. The whole patch including the changelog follows below.
>
> On Wed 11-07-18 13:58:55, Aaron Lu wrote:
> > To improve page allocat
nt.
Next time you submit read[1] and [2], especially howto indicate which
tree (bpf vs. bpf-next) the patch is against, as this helps the
workflow of the maintainers.
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/tree/Documentation/bpf/bpf_devel_QA.txt
[2] Documentation/netwo
ng on the same CPU. But in some cases this is
not what you want, so as the also commit mentions, the admin can now
more easily tune process scheduling parameters if needed, to adjust for
such use-cases (it was not really an admin choice before).
> For example, we didn't hav
out this change, the header files are install as executables files (755).
Fixes: eb54e522a000 ("bpf: install libbpf headers on 'make install'")
Signed-off-by: Jesper Dangaard Brouer
---
tools/lib/bpf/Makefile |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
It seems like an oversight not to install the header file for libbpf,
given the libbpf.so + libbpf.a files are installed.
Signed-off-by: Jesper Dangaard Brouer
---
tools/lib/bpf/Makefile |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/lib/bpf/Makefile b/tools/lib
This patchset contains some small improvements and cleanup for
the Makefile in tools/lib/bpf/.
It worries me that the libbpf.so shared library is not versioned, but
it not addressed in this patchset.
---
Jesper Dangaard Brouer (3):
libbpf: install the header file libbpf.h
libbpf
("bpf tools: Introduce 'bpf' library and add bpf feature
check")
Signed-off-by: Jesper Dangaard Brouer
---
tools/lib/bpf/Makefile | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
index 543706
org:80/wiki/index.php/Lab_Setup
[4]
http://web.archive.org/web/20150328234459/http://www.iptv-analyzer.org:80/wiki/index.php/Multicast_Signal_on_Linux
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
on or tshark on libreelec so I can't
> provide further logs.
Do you have perf or trace-cmd on the box? Maybe we could come up with
some kernel functions to trace, to measure/show the latency spikes?
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
On Mon, 8 Jan 2018 22:44:27 +0100
Peter Zijlstra wrote:
> On Mon, Jan 08, 2018 at 10:31:09PM +0100, Jesper Dangaard Brouer wrote:
> > I did expected the issue to get worse, when you load the Pi with
> > network traffic, as now the softirq time-budget have to be shared
> > b
ey use PREEMPT?
LibreELEC:~ # uname -a
Linux LibreELEC 4.14.10 #1 SMP Tue Jan 9 17:35:03 GMT 2018 armv7l GNU/Linux
[2]
https://forum.libreelec.tv/thread/4235-dvb-issue-since-le-switched-to-kernel-4-9-x/?postID=76999#post76999
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Princi
alloc_rx_queues':
> net/core/dev.c:7633:29: error:
> 'struct net_device' has no member named 'num_rx_queues'
>
> [ and so on ]
Hi Guenter,
This is caused by CONFIG_SYSFS is not set in your config. I'm
preparing a patch... can I ask you to test it, as
eported-by: Guenter Roeck
Signed-off-by: Jesper Dangaard Brouer
---
include/linux/netdevice.h |3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 440b000f07f4..b308793c64ce 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdev
ts/
p.s. Regarding quote[1] point "1.", after Paolo Abeni optimized the UDP
code, that statement is no longer true. It now (significantly) faster to
run/pin your UDP application to another CPU than the RX-CPU.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
to understand retpoline at ASM level read this:
https://support.google.com/faqs/answer/7625886
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
!?
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
Build error#1:
--
clang -nostdinc -isystem /usr/lib/gcc/x86_64-redhat-linux/7/include
-I./arch/x86/include -I./arch/x86/include/generated -I./include
>
> git://git.infradead.org/users/hch/misc.git dma-direct-calls
>
> Gitweb:
>
>
> http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dma-direct-calls
>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
ches I just
tested with my XDP forward workload?
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
7,581 | 101,945
|
| 9,610,088 | 2,568,064| 2,001,369| 566,683
|
|| | |
|
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
On Fri, 7 Dec 2018 16:44:35 +0100
Jesper Dangaard Brouer wrote:
> On Fri, 7 Dec 2018 02:21:42 +0100
> Christoph Hellwig wrote:
>
> > On Thu, Dec 06, 2018 at 08:24:38PM +, Robin Murphy wrote:
> > > On 06/12/2018 20:00, Christoph Hellwig wrote:
> > >>
he dma-mapping tree, so you probably want to
> want this git tree for testing:
>
> git://git.infradead.org/users/hch/misc.git dma-direct-calls.2
>
> Gitweb:
>
>
> http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dma-direct-calls.2
You can add my:
Te
88812c3f01c0
> raw: 88809fa64fc1 88809fa64000 0001003f
> page dumped because: kasan: bad access detected
>
> Memory state around the buggy address:
> 88809fa64e00: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
> 88809fa64e80: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
> > 88809fa64f00: fb fb fb fb fc fc fc fc 00 fc fc fc fc fc fc fc
>^
> 88809fa64f80: 06 fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
> 88809fa65000: fc fc fc fc fc fc fc fc 00 00 00 00 00 00 00 00
> ==
>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
; Acked-by: Thomas Graf
> > Acked-by: Roman Gushchin
> > Acked-by: Wang Nan
> > Acked-by: Yonghong Song
>
> Applied to bpf-next, thanks!
For the public record:
Acked-by: Jesper Dangaard Brouer
I do know, this ack will not reach the git-log, but given I have cod
On 02/02/2024 13.11, Liang Chen wrote:
The RSS hash report is a feature that's part of the virtio specification.
Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost
(still a work in progress as per [1]) support this feature. While the
capability to obtain the RSS hash has
On 13/04/2024 06.10, Liang Chen wrote:
The RSS hash report is a feature that's part of the virtio specification.
Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost
(still a work in progress as per [1]) support this feature. While the
capability to obtain the RSS hash has
GTM
Acked-by: Jesper Dangaard Brouer
On 11/06/2024 22.11, Yan Zhai wrote:
skb does not include enough information to find out receiving
sockets/services and netns/containers on packet drops. In theory
skb->dev tells about netns, but it can get cleared/reused, e.g. by TCP
stack for OOO packet lookup. Similarly, skb->sk often ident
often identifies a local
sender, and tells nothing about a receiver.
Allow passing an extra receiving socket to the tracepoint to improve
the visibility on receiving drops.
Signed-off-by: Yan Zhai
---
v4->v5: rename rx_skaddr -> rx_sk as Jesper Dangaard Brouer suggested
v3->v4: adjusted the
s(-)
Acked-by: Jesper Dangaard Brouer
On 17/06/2024 20.09, Yan Zhai wrote:
Replace kfree_skb_reason with sk_skb_reason_drop and pass the receiving
socket to the tracepoint.
Signed-off-by: Yan Zhai
---
net/ipv4/ping.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Jesper Dangaard Brouer
Dangaard Brouer
ort tags
---
net/ipv4/syncookies.c | 2 +-
net/ipv4/tcp_input.c | 2 +-
net/ipv4/tcp_ipv4.c | 6 +++---
net/ipv6/syncookies.c | 2 +-
net/ipv6/tcp_ipv6.c | 6 +++---
5 files changed, 9 insertions(+), 9 deletions(-)
Acked-by: Jesper Dangaard Brouer
ort tags
---
net/ipv4/udp.c | 10 +-
net/ipv6/udp.c | 10 +-
2 files changed, 10 insertions(+), 10 deletions(-)
Acked-by: Jesper Dangaard Brouer
zed sk, added missing report tags.
---
net/packet/af_packet.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Acked-by: Jesper Dangaard Brouer
-a1297871.xz
kernel image:
https://storage.googleapis.com/syzbot-assets/db09a1fa448c/bzImage-a1297871.xz
The issue was bisected to:
commit 21c38a3bd4ee3fb7337d013a638302fb5e5f9dc2
Author: Jesper Dangaard Brouer
Date: Wed May 1 14:04:11 2024 +
cgroup/rstat: add cgroup_rstat_cpu_lock
On 10/09/2024 12.46, Yunsheng Lin wrote:
On 2024/9/10 1:28, Mina Almasry wrote:
On Mon, Sep 9, 2024 at 2:25 AM Yunsheng Lin wrote:
The testing is done by ensuring that the page allocated from
the page_pool instance is pushed into a ptr_ring instance in
a kthread/napi binded to a specified
On 11/09/2024 06.43, Daniel Xu wrote:
[cc Jesper]
On Tue, Sep 10, 2024, at 8:31 PM, Daniel Xu wrote:
On Tue, Sep 10, 2024 at 05:39:55PM GMT, Andrii Nakryiko wrote:
On Tue, Sep 10, 2024 at 4:44 PM Daniel Xu wrote:
On Tue, Sep 10, 2024 at 03:21:04PM GMT, Andrii Nakryiko wrote:
On Tue, Sep
On 11/09/2024 20.53, Daniel Xu wrote:
On Wed, Sep 11, 2024 at 10:32:56AM GMT, Jesper Dangaard Brouer wrote:
On 11/09/2024 06.43, Daniel Xu wrote:
[cc Jesper]
On Tue, Sep 10, 2024, at 8:31 PM, Daniel Xu wrote:
On Tue, Sep 10, 2024 at 05:39:55PM GMT, Andrii Nakryiko wrote:
On Tue, Sep 10
bits-wirespeed.html
[2]:
https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/mm/qmempool_bench.c
[3]: http://thread.gmane.org/gmane.linux.network/342347
[4]: https://github.com/netoptimizer/prototype-kernel
---
Jesper Dangaard Brouer (3):
net: use qmempool in-front of sk_buff kmem
ess the alf_queue's concurrency).
IP-forward MULTI flow/cpu (12 CPUs E5-2695 no-HT, 12 HWQs):
* baseline: 11,946,666 pps
* qmempool: 11,988,042 pps
- Diff to baseline: +41376 pps => -0.29 ns
Signed-off-by: Jesper Dangaard Brouer
---
include/linux/skbuff.h |4 +++-
net/core/dev.c
- 7.837 ns - 18.536 ns
N(256)-pattern: 45.039 ns - 11.782 ns - 24.186 ns
A significant win for usage from softirq, and a smaller win for
none-softirq which requires taking local_bh_{disable,enable}.
Signed-off-by: Jesper Dangaard Brouer
---
include/linux/qmempool.h | 205
On Wed, 10 Dec 2014 14:22:22 +
David Laight wrote:
> From: Jesper Dangaard Brouer
> > The network stack have some use-cases that puts some extreme demands
> > on the memory allocator. One use-case, 10Gbit/s wirespeed at smallest
> > packet size[1], requires handling a
552 ns -- 1.109 ns
Joint work with Hannes Frederic Sowa.
Signed-off-by: Jesper Dangaard Brouer
Signed-off-by: Hannes Frederic Sowa
---
Correctness of memory barries on different arch's need to be evaluated.
The API might need some adjustments/discussions regarding:
1) the semantics of enq/
On Wed, 10 Dec 2014 09:17:32 -0600 (CST)
Christoph Lameter wrote:
> On Wed, 10 Dec 2014, Jesper Dangaard Brouer wrote:
>
> > Patch1: alf_queue (Lock-Free queue)
>
> For some reason that key patch is not in my linux-mm archives nor in my
> inbox.
That is very strange! I d
On Wed, 10 Dec 2014 13:51:32 -0600 (CST)
Christoph Lameter wrote:
> On Wed, 10 Dec 2014, Jesper Dangaard Brouer wrote:
>
> > One of the building blocks for achieving this speedup is a cmpxchg
> > based Lock-Free queue that supports bulking, named alf_queue for
> > Arr
>freelist);
>
> if (unlikely(!this_cpu_cmpxchg_double(
[1]
https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/time_bench_kmem_cache1.c
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.ip
it is not as high as I would have expected.
(CPU E5-2695)
[1]
https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/time_bench_kmem_cache1.c
[2]
https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/mm/qmempool_bench.c
--
Best regards,
Jesper Dangaard Brouer
MS
On Thu, 15 Jan 2015 16:40:32 +0900
Joonsoo Kim wrote:
[...]
>
> I saw roughly 5% win in a fast-path loop over kmem_cache_alloc/free
> in CONFIG_PREEMPT. (14.821 ns -> 14.049 ns)
>
> Below is the result of Christoph's slab_test reported by
> Jesper Dangaard Brouer.
n if all objects in slab pages
> can be used to provide the objects required.
I'll volunteer to performance benchmark the different allocators
optimized functions in this area. (I'll have time after April 13th).
> Signed-off-by: Christoph Lameter
Acked-by: Jesper Dangaard Brouer
kernel developers nitpick? ;-)
And usually you don't need to Cc the "main" Linux Kernel Mailing List
(linux-kernel@vger.kernel.org) with a trivial patch like this. Sending
it to the network developers should be enough (net...@vger.kernel.org).
--
Best regards,
Jesper Dangaard Brouer
; thread < $THREADS; thread++)); do
> # Inject packet into RX path of stack
> pg_set $dev "xmit_mode netif_receive"
>
> -# Burst allow us to avoid measuring SKB alloc/free overhead
> +# Burst allows us to avoid measuring SKB alloc/free overhead
> pg_set $de
Caught by kmemcheck.
Don't know the fix... just pointed at the bug.
Introduced in commit 7053aee26a3 ("fsnotify: do not share
events between notification groups").
---
fs/notify/inotify/inotify_fsnotify.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/notify/inotify/
On Tue, 16 Jun 2015 15:52:09 +0200 Jan Kara wrote:
> On Tue 16-06-15 13:33:18, Jesper Dangaard Brouer wrote:
> > Caught by kmemcheck.
> >
> > Don't know the fix... just pointed at the bug.
> >
> > Introduced in commit 7053aee26a3 ("fsnotify: do not s
On Wed, 17 Jun 2015 10:13:19 +0200
Jan Kara wrote:
> On Tue 16-06-15 22:22:34, Jesper Dangaard Brouer wrote:
> >
> > On Tue, 16 Jun 2015 15:52:09 +0200 Jan Kara wrote:
> >
> > > On Tue 16-06-15 13:33:18, Jesper Dangaard Brouer wrote:
> > > > Caught
> enabled. Note also that the requirement of having interrupts disabled
> > avoids having to do processor flag operations.
> >
> > Allocate as many objects as possible in the fast way and then fall back to
> > the generic implementation for the rest of
e a difference between the
loaded BPF program that got loaded at boot-time with systemd (no
constant blinding) and when someone reloads that systemd service after
/etc/sysctl.conf have been evaluated and setting bpf_jit_harden (now
slower due to constant blinding). This is inconsistent behavior.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
unsigned int tlen = len + vi->hdr_len;
> - u16 num_buf = 1;
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
kb_shared_info which breaks XDP assumption. Other complaints are, the
> complex linearize logic and EWMA estimation may increase the
> possibility of linearizing.
This patch also have the intermixing issues, I mentioned for patch 2/2.
On Thu, 1 Mar 2018 09:02:06 +0100
Jesper Dangaard Brouer
ion).
It should actually be fairly easy to implement:
* Simply extend xdp_buff with a "data_hard_end" pointer.
Now cpumap is more safe... instead of crashing, it can now know/see when
it is safe to create an SKB using build_skb (could fallback to
dev_alloc_skb).
--
Best regards,
Jespe
de paths to the egress device. (1) XDP
native via ndp_xdp_xmit via direct delivery into a lockfree/dedicated
TX queue, (2) via normal network stack which can involve being queue in
a qdisc. Do you see the possibility of the reorder now?
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal
On Thu, 1 Mar 2018 17:23:37 +0800
Jason Wang wrote:
> On 2018年03月01日 17:10, Jesper Dangaard Brouer wrote:
> > On Thu, 1 Mar 2018 11:19:03 +0800
> > Jason Wang wrote:
> >
> >> This series tries to re-enable XDP_REDIRECT for mergeable buffer which
> >>
On Thu, 1 Mar 2018 21:15:36 +0800
Jason Wang wrote:
> On 2018年03月01日 18:35, Jesper Dangaard Brouer wrote:
> > On Thu, 1 Mar 2018 17:23:37 +0800
> > Jason Wang wrote:
> >
> >> On 2018年03月01日 17:10, Jesper Dangaard Brouer wrote:
> >>> On Thu, 1 Mar 2
/Documentation/bpftool-prog.rst
https://github.com/torvalds/linux/blob/master/tools/bpf/bpftool/Documentation/bpftool-map.rst
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
below diff.
Is this a know problem?
Have others experienced this too?
This happens for me on two different (x86_64) testlab machines...
I also tested on Linus'es tree at v4.17-rc2, and problem also exists
for me there.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel
On Tue, 24 Apr 2018 13:04:23 -0700
Linus Torvalds wrote:
> On Tue, Apr 24, 2018 at 12:54 PM, Jesper Dangaard Brouer
> wrote:
> > Hi all,
> >
> > I'm experiencing boot failures with net-next git-tree after it got
> > rebased/merged with Linus'es tree a
On Mon, 25 Feb 2019 08:55:40 -0800
Joe Perches wrote:
> On Mon, 2019-02-25 at 09:39 +0100, Jesper Dangaard Brouer wrote:
> > On Sat, 23 Feb 2019 01:47:00 +0100
> > Daniel Borkmann wrote:
> >
> > > On 02/22/2019 10:45 PM, Jakub Kicinski wrote:
> > > &g
to any other users.
If you change local_irq_save(flags) to local_irq_disable() then you can
likely get better performance for 1 page requests via this API. This
limits the API to be used in cases where IRQs are enabled (which is
most cases). (For my use-case I will not do 1 page requests).
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
This is a followup to Mel Gorman's patchset:
- Message-Id: <20210224102603.19524-1-mgor...@techsingularity.net>
-
https://lore.kernel.org/netdev/20210224102603.19524-1-mgor...@techsingularity.net/
Showing page_pool usage of the API for alloc_pages_bulk().
---
Jesper Dangaar
In preparation for next patch, move the dma mapping into its own
function, as this will make it easier to follow the changes.
Signed-off-by: Jesper Dangaard Brouer
---
net/core/page_pool.c | 49 +
1 file changed, 29 insertions(+), 20 deletions
(3,677,958 pps -> 4,368,926 pps).
[1]
https://github.com/xdp-project/xdp-project/blob/master/areas/mem/page_pool06_alloc_pages_bulk.org
Signed-off-by: Jesper Dangaard Brouer
---
net/core/page_pool.c | 65 --
1 file changed, 41 insertions(+),
exchange a 3-cycle imul with a
1-cycle shl, saving 2-cycles. It does trade some space to do this.
Used: gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2)
Signed-off-by: Jesper Dangaard Brouer
---
include/linux/mmzone.h |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/inclu
*/
> > > skb_release_all(skb);
> > >
> > > - /* record skb to CPU local list */
> > > + kasan_poison_object_data(skbuff_head_cache, skb);
> > > nc->skb_cache[nc->skb_count++] = skb;
> > >
> > > -#ifdef CONFIG_SLUB
> > >
--git a/net/core/skbuff.c b/net/core/skbuff.c
> index 860a9d4f752f..9e1a8ded4acc 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -120,6 +120,8 @@ static void skb_under_panic(struct sk_buff *skb, unsigned
> int sz, void *addr)
> }
>
> #define NAPI_SKB_C
>
> On Wed, Feb 24, 2021 at 07:56:51PM +0100, Jesper Dangaard Brouer wrote:
> > Avoid multiplication (imul) operations when accessing:
> > zone->free_area[order].nr_free
> >
> > This was really tricky to find. I was puzzled why perf reported that
> > r
On Wed, 24 Feb 2021 22:15:22 +0200
Ilias Apalodimas wrote:
> Hi Jesper,
>
> On Wed, Feb 24, 2021 at 07:56:46PM +0100, Jesper Dangaard Brouer wrote:
> > There are cases where the page_pool need to refill with pages from the
> > page allocator. Some workloads cause the page_
On Thu, 25 Feb 2021 15:38:15 +
Mel Gorman wrote:
> On Thu, Feb 25, 2021 at 04:16:33PM +0100, Jesper Dangaard Brouer wrote:
> > > On Wed, Feb 24, 2021 at 07:56:51PM +0100, Jesper Dangaard Brouer wrote:
> > > > Avoid multiplication (imul) operations when accessing:
,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
$ ./tools/bpf/resolve_btfids/resolve_btfids -vv vmlinux.err.bak
section(1) .text, size 12588824, link 0, flags 6, type=1
section(2) .rodata, size 4424758, link 0, flags 3, type=1
ols/build/Makefile solves the issue locally in
tools/build/, but this isn't triggered when calling make clean in other tools
directories that use the feature tests.
What is the correct make clean fix?
- -
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Ha
On Tue, 18 Aug 2020 15:45:43 +0200
Jiri Olsa wrote:
> On Tue, Aug 18, 2020 at 12:56:08PM +0200, Jiri Olsa wrote:
> > On Tue, Aug 18, 2020 at 11:14:10AM +0200, Jiri Olsa wrote:
> > > On Tue, Aug 18, 2020 at 10:55:55AM +0200, Jesper Dangaard Brouer wrote:
> > > >
9.3.1 20200408 (Red Hat 9.3.1-2)
Intent is for Mel to pickup these patches.
---
Jesper Dangaard Brouer (3):
net: page_pool: refactor dma_map into own function page_pool_dma_map
net: page_pool: use alloc_pages_bulk in refill code path
net: page_pool: convert to use alloc_pages_bulk_
1 - 100 of 362 matches
Mail list logo
