Re: [it really is text/plain :P] dual port onboard 82546EB checksum errors

please copy netdev, or better yet [EMAIL PROTECTED] in the future for e1000 issues like this. Feel free to move the conversation there, if you would like. On 4/19/07, David Ford [EMAIL PROTECTED] wrote: I have a rackmount server that has a dual port onboard 82546EB card. I've googled and seen

Re: -rc5: e1000 resume weirdness

On 3/26/07, Ingo Molnar [EMAIL PROTECTED] wrote: hm, on a T60, after suspend/resume, i get an e1000 timeout: e1000: eth0: e1000_watchdog: NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang Tx Queue 0 TDH

Re: [BUG] ethX misnumbered and one missing in mii-tool

added netdev. On 3/29/07, Andrei Popa [EMAIL PROTECTED] wrote: In a dual core 2 server with an intel motherboard and 5 network cards(two onboard) and 1 pci express card with two slots and one pci-x pci64 card the kernel sees all of them in dmesg but in mii-tool are misnumbered and one card is

Re: eepro100/e100 broken in 2.6.13-rc3

On 7/13/05, Mikhail Kshevetskiy [EMAIL PROTECTED] wrote: symptom === modprobe e100 ifconfig eth0 ip netmask netmask result: === SIOCADDRT: Network is unreachable There were no such error in 2.6.13-rc2 odd, both e100 and eepro100 are broken? This might indicate something wierd

Re: Very strange Marvell/Yukon Gigabit NIC networking problems

on 2.6.11/12 when it isn't working maybe you should send us the output of lspci -vvv just a hint, I'm guessing its power management related, and / or something to do with the pci bus code. On 8/30/05, Daniel Drake [EMAIL PROTECTED] wrote: Forwarding on, please reply-to-all in future. Steve

Re: Soft lockup in e100 driver ?

On 8/11/05, Stephen D. Williams [EMAIL PROTECTED] wrote: The chipset is an Intel 8x0 something. Unfortunately, there is a heatsink semi-permanently installed over everything. Is there a /proc pseudofile that will give me good identifying chipset info to report here? you can show the chipset

Re: [2.6 patch] the scheduled eepro100 removal

On 1/2/07, Eric Piel [EMAIL PROTECTED] wrote: Hi, I've been using e100 for years with no problem, however more by curiosity than necessity I'd like to know how will be handled the devices which are (supposedly) supported by eepro100 and not by e100? According to modinfo eepro100 and modinfo

Re: [patch 2.6.13-rc3] pci: restore BAR values after D3hot-D0 for devices that need it

On 7/27/05, John W. Linville [EMAIL PROTECTED] wrote: Some PCI devices (e.g. 3c905B, 3c556B) lose all configuration (including BARs) when transitioning from D3hot-D0. This leaves such a device in an inaccessible state. The patch below causes the BARs to be restored when enabling such a

Re: Network drivers that don't suspend on interface down

On 12/20/06, Arjan van de Ven [EMAIL PROTECTED] wrote: Yeah, I guess that's a problem. From a user perspective, the functionality is only really useful if the latency is very small. I think where possible we'd want to power down the chip while keeping the phy up, but it would be nice to

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

someone else is testing this kernel on this nic chipset. Upon some further investigation with Allen, I got this info, and it appears that his system is not freeing MSI irq's correctly. from our discussion: Allen wrote: Jesse Brandeburg wrote: I believe you may have an interrupt delivery problem

Re: Intel 82559 NIC corrupted EEPROM

On 12/1/06, John [EMAIL PROTECTED] wrote: can you try adding mdelay(100); in e100_eeprom_load before the for loop, and then change the multiple udelay(4) to mdelay(1) in e100_eeprom_read I applied the attached patch. Loading the driver now takes around one minute :-) ouch, but yep, thats

Re: Intel 82559 NIC corrupted EEPROM

On 11/27/06, John [EMAIL PROTECTED] wrote: John wrote: -0009 : System RAM 000a-000b : Video RAM area 000f-000f : System ROM 0010-0ffe : System RAM 0010-00296a1a : Kernel code 00296a1b-0031bbe7 : Kernel data 0fff-0fff2fff : ACPI Non-volatile

Re: Intel 82559 NIC corrupted EEPROM

On 11/29/06, John [EMAIL PROTECTED] wrote: Let's go ahead and print the output from e100_load_eeprom debug patch attached. Loading (then unloading) e100.ko fails the first few times (i.e. the driver claims one of the EEPROMs is corrupted). Thereafter, sometimes it fails, other times it works.

Re: e100 breakage located

sorry for the delay, your mail got marked as spam. In the future please copy networking issues to netdev@vger.kernel.org, and be sure to copy the maintainers of the driver you're having problems with (they are in the MAINTAINERS file) On 11/22/06, Amin Azez [EMAIL PROTECTED] wrote: I notice a

Re: 2.6.19-rc6: irq 48: nobody cared

On 11/16/06, Krzysztof Sierota [EMAIL PROTECTED] wrote: Hi, I'm getting the following in dmesg with 2.6.19-rc5 and 2.6.19-rc6 kernels quad opteron server running 64bit kernel, and the network card gets disabled. On identical server running 32bit kernel, same cards, same slots, same

Re: [PATCH net-next] drivers:net: Convert dma_alloc_coherent(...__GFP_ZERO) to dma_zalloc_coherent

memset from the static inline dma_zalloc_coherent and add just one use of __GFP_ZERO instead. Trivially reduces the size of the existing uses of dma_zalloc_coherent. Realign arguments as appropriate. Signed-off-by: Joe Perches j...@perches.com e1000 and ixgb bits: Acked-by: Jesse Brandeburg

Re: [net-next] pci_regs.h: Add PCI bus link speed and width defines

+linux-pci and see note below On Thu, Jan 2, 2014 at 4:21 PM, David Miller da...@davemloft.net wrote: From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Sat, 28 Dec 2013 04:36:13 -0800 Add missing PCI bus link speed 8.0 GT/s and bus link widths of x1, x2, x4 and x8. CC:

Re: [PATCH 2/2] libata: Fix NULL pointer of scsi_host in ata_port

On Wed, Jul 23, 2014 at 2:03 AM, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 07/23/2014 06:11 AM, Tejun Heo wrote: Hello, Can you please test the following patch? Tested-by: Alexey Kardashevskiy a...@ozlabs.ru on POWER8 + IBM IPR SCSI. FWIW, I tested Linus's current git tree and the

[PATCH] genirq: fix symbol export for __irq_set_affinity

to compile due to the lack of an export even though already defined via extern. Signed-off-by: Jesse Brandeburg jesse.brandeb...@intel.com CC: Thomas Gleixner t...@linutronix.de --- Note: The use of EXPORT_SYMBOL_GPL was only because the next latest function added to this file

Re: [PATCH] genirq: fix symbol export for __irq_set_affinity

On Thu, 18 Dec 2014 23:42:03 +0100 Thomas Gleixner t...@linutronix.de wrote: On Thu, 18 Dec 2014, Jesse Brandeburg wrote: Enabling this function means that kernel drivers can include an initial affinity setting for the interrupt, instead of all interrupts starting out life on CPU0

[PATCH] genirq: set initial affinity when hinting

:1 drivers/soc/ti/knav_qmss_queue.c:2 drivers/virtio/virtio_pci_common.c:2 Signed-off-by: Jesse Brandeburg jesse.brandeb...@intel.com CC: Thomas Gleixner t...@linutronix.de --- kernel/irq/manage.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c

Re: [PATCH] genirq: set initial affinity when hinting

+netdev, as network driver developers might be interested in this functionality. On Thu, Dec 18, 2014 at 5:22 PM, Jesse Brandeburg jesse.brandeb...@intel.com wrote: Problem: The default behavior of the kernel is somewhat undesirable as all requested interrupts end up on CPU0 after registration

Re: [tip:irq/core] genirq: Set initial affinity in irq_set_affinity_hint()

On Tue, 27 Jan 2015 22:36:23 -0800 Yinghai Lu ying...@kernel.org wrote: On Fri, Jan 23, 2015 at 2:42 AM, tip-bot for Jesse Brandeburg tip...@zytor.com wrote: Commit-ID: e2e64a932556cdfae455497dbe94a8db151fc9fa Gitweb: http://git.kernel.org/tip

[tip:irq/core PATCH] genirq: fix null pointer reference in irq_set_affinity_hint()

in irq_set_affinity_hint()) Reported-by: Yinghai Lu ying...@kernel.org Signed-off-by: Jesse Brandeburg jesse.brandeb...@intel.com CC: Thomas Gleixner t...@linutronix.de CC: net...@vger.kernel.org --- kernel/irq/manage.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/irq

Re: [tip:irq/core] genirq: Set initial affinity in irq_set_affinity_hint()

On Tue, 27 Jan 2015 22:36:23 -0800 Yinghai Lu ying...@kernel.org wrote: On Fri, Jan 23, 2015 at 2:42 AM, tip-bot for Jesse Brandeburg tip...@zytor.com wrote: Commit-ID: e2e64a932556cdfae455497dbe94a8db151fc9fa Gitweb: http://git.kernel.org/tip

[PATCH] irq: revert non-working patch to affinity defaults

help me debug what is going wrong, we can pick up the change later. This commit would also revert commit 4fe7ffb7e17ca (genirq: Fix null pointer reference in irq_set_affinity_hint()) which was a bug fix to the original patch. Signed-off-by: Jesse Brandeburg jesse.brandeb...@intel.com CC: Ingo

Re: [PATCH] irq: revert non-working patch to affinity defaults

On Fri, 3 Apr 2015 08:55:57 +0200 Ingo Molnar mi...@kernel.org wrote: So the original commit also has the problem that it unnecessary drops/retakes the descriptor lock: irq_put_desc_unlock(desc, flags); - /* set the initial affinity to prevent every interrupt being on CPU0 */ -

Re: [Intel-wired-lan] [PATCH v2 net-next 0/2] e1000e: fix PTP on e1000_pch_variants

On Sat, 23 Jul 2016 12:44:32 -0400 Jarod Wilson wrote: > This little series factors out the systim sanitization code first, then > adds e1000_pch_lpt as a new case in the switch that calls the sanitize > function, fixing PTP clock issues I've had reported against an Intel >

Re: [Intel-wired-lan] [PATCH] igb: add missing fields to TXDCTL-register

On Wed, 19 Oct 2016 14:37:59 +0200 Henrik Austad wrote: > The current list of E1000_TXDCTL-registers is incomplete. This adds > the missing parts for the Transmit Descriptor Control (TXDCTL) > register. > > The rest of these values (threshold for descriptor read/write) for >

Re: [PATCH] vfio/pci: Add Intel XXV710 to hidden INTx devices

t to the device. > Extend the device IDs to include these so that we hide that the > device supports INTx at all to the user. > Acked-by: Jesse Brandeburg <jesse.brandeb...@intel.com>

Re: [PATCH] PCI: Add Intel XXV710 to broken INTx masking quirk

irq xx: nobody cared..." > errors from the spurious interrupt handler when we try to use it > with device assignment. Thanks for doing this Alex, Acked-by: Jesse Brandeburg <jesse.brandeb...@intel.com>

Re: [Intel-wired-lan] [PATCH] intel: i40e: virtchnl: fix incorrect variable assignment

is > updated at line 1602 just before return, so assigning a value to this > variable in this code block is useless. > > Addresses-Coverity-ID: 1397693 > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Thanks for the fix, looks reasonable. Acked-by: Jesse Brandeburg <jesse.brandeb...@intel.com>

Re: [Intel-wired-lan] [PATCH] i40e: make const array patterns static, reduces object code size

0, x86-64) > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Looks good, thanks Colin! Acked-by: Jesse Brandeburg <jesse.brandeb...@intel.com>

Re: [RFC PATCH net-next 03/12] vhost_net: introduce vhost_has_more_pkts()

On Mon, 21 May 2018 17:04:24 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index de544ee..4ebac76 100644 > ---

Re: [RFC PATCH net-next 01/12] vhost_net: introduce helper to initialize tx iov iter

Hi Jason, a few nits. On Mon, 21 May 2018 17:04:22 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 34 +++--- > 1 file changed, 23 insertions(+), 11 deletions(-) > > diff --git a/drivers/vhost/net.c

Re: [RFC PATCH net-next 02/12] vhost_net: introduce vhost_exceeds_weight()

On Mon, 21 May 2018 17:04:23 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index 15d191a..de544ee 100644 > ---

Re: [RFC PATCH net-next 04/12] vhost_net: split out datacopy logic

On Mon, 21 May 2018 17:04:25 +0800 Jason wrote: > Instead of mixing zerocopy and datacopy logics, this patch tries to > split datacopy logic out. This results for a more compact code and > specific optimization could be done on top more easily. > > Signed-off-by: Jason Wang

Re: [RFC PATCH net-next 10/12] vhost_net: build xdp buff

On Mon, 21 May 2018 17:04:31 +0800 Jason wrote: > This patch implement build XDP buffers in vhost_net. The idea is do > userspace copy in vhost_net and build XDP buff based on the > page. Vhost_net can then submit one or an array of XDP buffs to > underlayer socket (e.g TUN). TUN can choose to do

[PATCH] um: fix user mode linux build

ger <rich...@nod.at> Cc: user-mode-linux-de...@lists.sourceforge.net Signed-off-by: Jesse Brandeburg <jesse.brandeb...@intel.com> --- arch/um/os-Linux/signal.c | 2 +- arch/x86/um/stub_segv.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/um/os-Linux/signal

Re: [Intel-wired-lan] [PATCH] i40e: Delete an error message for a failed memory allocation in i40e_init_interrupt_scheme()

> This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Thanks for the patch. Acked-by: Jesse Brandeburg <jesse.brandeb...@intel.com>

Re: [uml-devel] [PATCH] uml: Fix build with recent glibc

e.com/user-mode-linux-devel@lists.sourceforge.net/msg10071.html Reviewed-by: Jesse Brandeburg <jesse.brandeb...@intel.com>

Re: eepro100/e100 broken in 2.6.13-rc3

On 7/13/05, Mikhail Kshevetskiy <[EMAIL PROTECTED]> wrote: > symptom > === > modprobe e100 > ifconfig eth0 netmask > > result: > === > SIOCADDRT: Network is unreachable > > There were no such error in 2.6.13-rc2 odd, both e100 and eepro100 are broken? This might indicate something

Re: [patch 2.6.13-rc3] pci: restore BAR values after D3hot->D0 for devices that need it

On 7/27/05, John W. Linville <[EMAIL PROTECTED]> wrote: > Some PCI devices (e.g. 3c905B, 3c556B) lose all configuration > (including BARs) when transitioning from D3hot->D0. This leaves such > a device in an inaccessible state. The patch below causes the BARs > to be restored when enabling such

Re: Soft lockup in e100 driver ?

On 8/11/05, Stephen D. Williams <[EMAIL PROTECTED]> wrote: > The chipset is an Intel 8x0 something. Unfortunately, there is a > heatsink semi-permanently installed over everything. Is there a /proc > pseudofile that will give me good identifying chipset info to report here? you can show the

Re: Network drivers that don't suspend on interface down

On 12/20/06, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > Yeah, I guess that's a problem. From a user perspective, the > functionality is only really useful if the latency is very small. I > think where possible we'd want to power down the chip while keeping the > phy up, but it would be nice

Re: Very strange Marvell/Yukon Gigabit NIC networking problems

on 2.6.11/12 when it isn't working maybe you should send us the output of lspci -vvv just a hint, I'm guessing its power management related, and / or something to do with the pci bus code. On 8/30/05, Daniel Drake <[EMAIL PROTECTED]> wrote: > Forwarding on, please reply-to-all in future. > >

Re: [2.6 patch] the scheduled eepro100 removal

On 1/2/07, Eric Piel <[EMAIL PROTECTED]> wrote: Hi, I've been using e100 for years with no problem, however more by curiosity than necessity I'd like to know how will be handled the devices which are (supposedly) supported by eepro100 and not by e100? According to "modinfo eepro100" and

Re: Intel 82559 NIC corrupted EEPROM

On 11/29/06, John <[EMAIL PROTECTED]> wrote: > Let's go ahead and print the output from e100_load_eeprom > debug patch attached. Loading (then unloading) e100.ko fails the first few times (i.e. the driver claims one of the EEPROMs is corrupted). Thereafter, sometimes it fails, other times it

Re: e100 breakage located

sorry for the delay, your mail got marked as spam. In the future please copy networking issues to netdev@vger.kernel.org, and be sure to copy the maintainers of the driver you're having problems with (they are in the MAINTAINERS file) On 11/22/06, Amin Azez <[EMAIL PROTECTED]> wrote: I notice

Re: Intel 82559 NIC corrupted EEPROM

On 12/1/06, John <[EMAIL PROTECTED]> wrote: > can you try adding mdelay(100); in e100_eeprom_load before the for loop, > and then change the multiple udelay(4) to mdelay(1) in e100_eeprom_read I applied the attached patch. Loading the driver now takes around one minute :-) ouch, but yep,

Re: 2.6.19-rc6: irq 48: nobody cared

On 11/16/06, Krzysztof Sierota <[EMAIL PROTECTED]> wrote: Hi, I'm getting the following in dmesg with 2.6.19-rc5 and 2.6.19-rc6 kernels quad opteron server running 64bit kernel, and the network card gets disabled. On identical server running 32bit kernel, same cards, same slots, same

Re: Intel 82559 NIC corrupted EEPROM

On 11/27/06, John <[EMAIL PROTECTED]> wrote: John wrote: >> -0009 : System RAM >> 000a-000b : Video RAM area >> 000f-000f : System ROM >> 0010-0ffe : System RAM >> 0010-00296a1a : Kernel code >> 00296a1b-0031bbe7 : Kernel data >> 0fff-0fff2fff :

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

the > word out in case someone else is testing this kernel on this nic chipset. Upon some further investigation with Allen, I got this info, and it appears that his system is not freeing MSI irq's correctly. from our discussion: Allen wrote: Jesse Brandeburg wrote: I believe you may have an

Re: -rc5: e1000 resume weirdness

On 3/26/07, Ingo Molnar <[EMAIL PROTECTED]> wrote: hm, on a T60, after suspend/resume, i get an e1000 timeout: e1000: eth0: e1000_watchdog: NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang Tx Queue <0> TDH

Re: [BUG] ethX misnumbered and one missing in mii-tool

added netdev. On 3/29/07, Andrei Popa <[EMAIL PROTECTED]> wrote: In a dual core 2 server with an intel motherboard and 5 network cards(two onboard) and 1 pci express card with two slots and one pci-x pci64 card the kernel sees all of them in dmesg but in mii-tool are misnumbered and one card is

Re: [it really is text/plain :P] dual port onboard 82546EB checksum errors

please copy netdev, or better yet [EMAIL PROTECTED] in the future for e1000 issues like this. Feel free to move the conversation there, if you would like. On 4/19/07, David Ford <[EMAIL PROTECTED]> wrote: I have a rackmount server that has a dual port onboard 82546EB card. I've googled and

Re: [net-next] pci_regs.h: Add PCI bus link speed and width defines

+linux-pci On Thu, Jan 2, 2014 at 4:21 PM, David Miller wrote: > From: Jeff Kirsher > Date: Sat, 28 Dec 2013 04:36:13 -0800 > >> Add missing PCI bus link speed 8.0 GT/s and bus link widths of >> x1, x2, x4 and x8. >> >> CC: >> Signed-off-by: Jeff Kirsher > > Can a PCI person please ACK

Re: [PATCH 2/2] libata: Fix NULL pointer of scsi_host in ata_port

On Wed, Jul 23, 2014 at 2:03 AM, Alexey Kardashevskiy wrote: > On 07/23/2014 06:11 AM, Tejun Heo wrote: >> Hello, >> >> Can you please test the following patch? > > Tested-by: Alexey Kardashevskiy > > on POWER8 + IBM IPR SCSI. FWIW, I tested Linus's current git tree and the issue is fixed.

Re: [uml-devel] [PATCH] uml: Fix build with recent glibc

se the typedefs which are still available. They also work on > older glibcs. > > Signed-off-by: Andi Kleen same patch that I sent on Feb 1st. Hope you can get more traction than I did. https://www.mail-archive.com/user-mode-linux-devel@lists.sourceforge.net/msg10071.html Reviewed-by: Jesse Brandeburg

Re: [Intel-wired-lan] [PATCH] i40e: make const array patterns static, reduces object code size

ex filename >1953 496 02449 991 i40e_diag.o > > After: >text data bss dec hex filename >1798 584 02382 94e i40e_diag.o > > (gcc 6.3.0, x86-64) > > Signed-off-by: Colin Ian King Looks good, thanks Colin! Acked-by: Jesse Brandeburg

Re: [Intel-wired-lan] [PATCH] i40e: Delete an error message for a failed memory allocation in i40e_init_interrupt_scheme()

d-off-by: Markus Elfring Thanks for the patch. Acked-by: Jesse Brandeburg

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

Nitesh Narayan Lal wrote: > Introduce a new API num_housekeeping_cpus(), that can be used to retrieve > the number of housekeeping CPUs by reading an atomic variable > __num_housekeeping_cpus. This variable is set from housekeeping_setup(). > > This API is introduced for the purpose of drivers

Re: [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs

ight? I'm sure ixgbe and ice both have this problem too, you should fix them as well, at a minimum, and probably other vendors drivers: $ rg -c --stats num_online_cpus drivers/net/ethernet ... 50 files contained matches for this patch i40e Acked-by: Jesse Brandeburg

Re: [PATCH 4.19 47/48] i40e: Memory leak in i40e_config_iwarp_qvlist

On Tue, 11 Aug 2020 14:46:14 +0200 Pavel Machek wrote: > > --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c > > +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c > > @@ -449,16 +450,19 @@ static int i40e_config_iwarp_qvlist(stru > > "Incorrect number of iwarp

Re: [Intel-wired-lan] VRRP not working on i40e X722 S2600WFT

Lennart Sorensen wrote: > On Thu, Aug 27, 2020 at 02:30:39PM -0400, Lennart Sorensen wrote: > > I have hit a new problem with the X722 chipset (Intel R1304WFT server). > > VRRP simply does not work. > > > > When keepalived registers a vmac interface, and starts transmitting > > multicast packets

Re: [net v2 PATCH 2/2] net: ethernet: ti: cpsw_new: fix clean up of vlan mc entries for host port

Murali Karicheri wrote: > To flush the vid + mc entries from ALE, which is required when a VLAN > interface is removed, driver needs to call cpsw_ale_flush_multicast() > with ALE_PORT_HOST for port mask as these entries are added only for > host port. Without this, these entries remain in the ALE

Re: [net v2 PATCH 1/2] net: ethernet: ti: cpsw: fix clean up of vlan mc entries for host port

Murali Karicheri wrote: > To flush the vid + mc entries from ALE, which is required when a VLAN > interface is removed, driver needs to call cpsw_ale_flush_multicast() > with ALE_PORT_HOST for port mask as these entries are added only for > host port. Without this, these entries remain in the ALE

Re: [PATCH net-next 0/3] Fix some kernel-doc warnings for i40e

Wang Hai wrote: > Wang Hai (3): > i40e: Fix some kernel-doc warnings in i40e_client.c > i40e: Fix some kernel-doc warnings in i40e_common.c > i40e: Fix a kernel-doc warning in i40e_ptp.c > > drivers/net/ethernet/intel/i40e/i40e_client.c | 2 -- >

Re: [PATCH net] iavf: fix error return code in iavf_init_get_resources()

Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: b66c7bc1cd4d ("iavf: Refactor init state machine") > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong

Re: [PATCH V4 net-next 0/4] net: hns3: updates for -next

h needs more discussion. > V3 - fix a typo error in #1 reported by Jakub Kicinski. > rewrite #9 commit log. > remove #11 from this series. > V2 - reorder #2 & #3 to fix compiler error. > fix some checkpatch warnings in #10 & #11. For the series: Reviewed-by: Jesse Brandeburg

Re: [PATCH 1/1] ionic: fix array overflow on receiving too many fragments for a packet

Xiaohui Zhang wrote: > From: Zhang Xiaohui > > If the hardware receives an oversized packet with too many rx fragments, > skb_shinfo(skb)->frags can overflow and corrupt memory of adjacent pages. > This becomes especially visible if it corrupts the freelist pointer of > a slab page. > >

Re: [PATCH 1/1] ice: fix array overflow on receiving too many fragments for a packet

Xiaohui Zhang wrote: > From: Zhang Xiaohui > > If the hardware receives an oversized packet with too many rx fragments, > skb_shinfo(skb)->frags can overflow and corrupt memory of adjacent pages. > This becomes especially visible if it corrupts the freelist pointer of > a slab page. As I

Re: [PATCH] net: ethernet: et131x: Use GFP_KERNEL instead of GFP_ATOMIC when allocating tx_ring->tcb_ring

EL which should be enough. > > Signed-off-by: Christophe JAILLET Sure, but generally I'd say GFP_ATOMIC is ok if you're in an init path and you can afford to have the allocation thread sleep while memory is being found by the kernel. Reviewed-by: Jesse Brandeburg

Re: [PATCH 1/2] net: ag71xx: Slighly simplify code in 'ag71xx_rings_init()'

Christophe JAILLET Reviewed-by: Jesse Brandeburg

Re: [PATCH 2/2] net: ag71xx: Use GFP_KERNEL instead of GFP_ATOMIC in 'ag71xx_rings_init()'

On Wed, 31 Jul 2019 10:06:48 +0200 Christophe JAILLET wrote: > There is no need to use GFP_ATOMIC here, GFP_KERNEL should be enough. > The 'kcalloc()' just a few lines above, already uses GFP_KERNEL. > > Signed-off-by: Christophe JAILLET Reviewed-by: Jesse Brandeburg

Re: [PATCH] myri10ge: remove unneeded variable

On Wed, 31 Jul 2019 16:53:46 +0800 Ding Xiang wrote: > "error" is unneeded,just return 0 > > Signed-off-by: Ding Xiang Reviewed-by: Jesse Brandeburg

Re: [PATCH] team: Add vlan tx offload to hw_enc_features

On Wed, 7 Aug 2019 10:38:08 +0800 YueHaibing wrote: > We should also enable bonding's vlan tx offload in hw_enc_features, You mean team's vlan tx offload? > pass the vlan packets to the slave devices with vlan tci, let them s/let them to/let the slave/ > to handle vlan tunneling offload

Re: NETDEV WATCHDOG: WARNING: at net/sched/sch_generic.c:442 dev_watchdog

Steven Rostedt wrote: > On Wed, 19 Aug 2020 17:01:06 +0530 > Naresh Kamboju wrote: > > > kernel warning noticed on x86_64 while running LTP tracing > > ftrace-stress-test > > case. started noticing on the stable-rc linux-5.8.y branch. > > > > This device booted with KASAN config and DYNAMIC

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

On Mon, 17 Aug 2020 16:27:01 +0300 Kalle Valo wrote: > I was surprised to see that someone was using this driver in 2015, so > I'm not sure anymore what to do. Of course we could still just remove > it and later revert if someone steps up and claims the driver is still > usable. Hmm. Does anyone

Re: [PATCH] net/bluetooth/hci_sock.c: add CAP_NET_RAW check.

On Tue, 18 Aug 2020 15:56:48 +0800 Qingyu Li wrote: > When creating a raw PF_BLUETOOTH socket, > CAP_NET_RAW needs to be checked first. > Thanks for the patch! Your subject doesn't need to end in a period. In your commit message, I can guess why you'd want this patch, but your commit message

Re: [PATCH] net/bluetooth/bnep/sock.c: add CAP_NET_RAW check.

On Tue, 18 Aug 2020 16:07:03 +0800 Qingyu Li wrote: > When creating a raw PF_BLUETOOTH socket, > CAP_NET_RAW needs to be checked first. > These changes should be part of a series (patch 0,1,2 at least), and all my replies on your other patch apply to this one as well.

Re: [PATCH] net/bluetooth/cmtp/sock.c: add CAP_NET_RAW check.

On Tue, 18 Aug 2020 16:15:55 +0800 Qingyu Li wrote: > When creating a raw PF_BLUETOOTH socket, > CAP_NET_RAW needs to be checked first. Please see my previous replies.

Re: [PATCH] net/bluetooth/hidp/sock.c: add CAP_NET_RAW check.

On Tue, 18 Aug 2020 16:21:03 +0800 Qingyu Li wrote: > When creating a raw PF_BLUETOOTH socket, > CAP_NET_RAW needs to be checked first. > > Signed-off-by: Qingyu Li Please see my replies to your previous patches.

Re: [PATCH] qed_main: Remove unnecessary cast in kfree

On Tue, 18 Aug 2020 09:10:56 + Xu Wang wrote: > Remove unnecassary casts in the argument to kfree. > > Signed-off-by: Xu Wang You seem to have several of these patches, they should be sent in a series with the series patch subject (for example): [PATCH net-next 0/n] fix up casts on kfree

Re: [PATCH][next] net: hns3: remove redundant null check of an array

gainst 0") > Fixes: 04987ca1b9b6 ("net: hns3: add debugfs support for tm nodes, priority > and qset info") > Signed-off-by: Colin Ian King Reviewed-by: Jesse Brandeburg

Re: [PATCH net] hv_netvsc: Reset the RSC count if NVSP_STAT_FAIL in netvsc_receive()

uot;hv_netvsc: Add validation for untrusted Hyper-V > values") Reviewed-by: Jesse Brandeburg

Re: [PATCH][next] net/mlx5e: Fix spelling mistake "Unknouwn" -> "Unknown"

Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a netdev_warn message. Fix it. > > Signed-off-by: Colin Ian King Trivial patch, looks fine! Reviewed-by: Jesse Brandeburg

Re: [PATCH] octeontx2-af: remove unneeded semicolon

ding like [PATCH net-next] otherwise, for net-next: Reviewed-by: Jesse Brandeburg

Re: [PATCH v2 net-next 3/4] net: introduce common dev_page_is_reserved()

ellanox/mlx5/core/en_rx.c | 7 +-- > include/linux/skbuff.h| 15 +++ > 11 files changed, 27 insertions(+), 83 deletions(-) For the patch, and esp. for the Intel drivers: Reviewed-by: Jesse Brandeburg

Re: [PATCH v2 net-next 0/4] net: consolidate page_is_pfmemalloc() usage

rst argument of > skb_propagate_pfmemalloc(). > In Page Pool core code, it can be simply inlined instead. > Most of the callers from NIC drivers were just doppelgangers of > the same condition tests. Derive them into a new common function > do deduplicate the code. This is a useful cleanup! Thanks. For the

Re: [PATCH net-next 0/6] net: stmmac: Improvements for -next

mmac: ARP Offload for GMAC4+ Cores For the series, looks good to me. Reviewed-by: Jesse Brandeburg

[PATCH] um: fix user mode linux build

-de...@lists.sourceforge.net Signed-off-by: Jesse Brandeburg --- arch/um/os-Linux/signal.c | 2 +- arch/x86/um/stub_segv.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/um/os-Linux/signal.c b/arch/um/os-Linux/signal.c index a86d7cc2c2d8..a5c0c909c48b 100644 --- a/arch/um

Re: [PATCH net-next] net: Drop unlikely before IS_ERR(_OR_NULL)

On Wed, 5 Jun 2019 22:24:26 +0800 Kefeng wrote: > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag, > so no need to do that again from its callers. Drop it. > > segs = __skb_gso_segment(skb, features, false); > - if (unlikely(IS_ERR_OR_NULL(segs))) { > + if

Re: [PATCH net-next v3] hinic: add LRO support

some review comments below... On Mon, 3 Jun 2019 04:35:36 + Xue Chaojing wrote: > This patch adds LRO support for the HiNIC driver. > > Signed-off-by: Xue Chaojing > --- > .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 2 + > .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 8 +- >

Re: [PATCH net-next v4] hinic: add LRO support

On Tue, 4 Jun 2019 01:16:08 + Xue wrote: > This patch adds LRO support for the HiNIC driver. > > Reported-by: kbuild test robot > Reviewed-by: Jesse Brandeburg > Signed-off-by: Xue Chaojing Hm, you added my reviewed-by tag, but I didn't add it myself, I only comment

Re: [PATCH v6 1/2] x86: fix bitops.h warning with a moved cast

On Mon, 4 May 2020 12:51:12 -0700 Nick Desaulniers wrote: > Sorry for the very late report. It turns out that if your config > tickles __builtin_constant_p just right, this now produces invalid > assembly: > > $ cat foo.c > long a(long b, long c) { > asm("orb\t%1, %0" : "+q"(c): "r"(b)); >

Re: [PATCH v5] x86: bitops: fix build regression

appreciate the work done to find the right fix and clean up the code while not breaking sparse! I had a look at the assembly from gcc 9.3.1 and it looks good. Thanks! Reviewed-by: Jesse Brandeburg

Re: [RFC PATCH net-next 01/12] vhost_net: introduce helper to initialize tx iov iter

Hi Jason, a few nits. On Mon, 21 May 2018 17:04:22 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 34 +++--- > 1 file changed, 23 insertions(+), 11 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index

Re: [RFC PATCH net-next 02/12] vhost_net: introduce vhost_exceeds_weight()

On Mon, 21 May 2018 17:04:23 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index 15d191a..de544ee 100644 > --- a/drivers/vhost/net.c >

Re: [RFC PATCH net-next 03/12] vhost_net: introduce vhost_has_more_pkts()

On Mon, 21 May 2018 17:04:24 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index de544ee..4ebac76 100644 > --- a/drivers/vhost/net.c >

  1   2   >