RE: NumaTOP 1.0 launched

2013-04-17 Thread Jin, Yao
Hi, https://01.org/numatop/ is slightly faster to access. Or please access https://github.com/01org/numatop to get the source directly. Thanks Jin Yao -Original Message- From: Jin, Yao Sent: Wednesday, April 17, 2013 10:30 AM To: 'l...@lwn.net'; 'linux-kernel@vger.kernel.org

Re: [PATCH] pinctrl-baytrail: fix for irq descriptor conflict on ASUS T100TA

2014-04-24 Thread Jin, Yao
On 2014/4/23 20:23, Mika Westerberg wrote: On Wed, Apr 23, 2014 at 11:34:30AM +0300, Mika Westerberg wrote: On Tue, Apr 22, 2014 at 10:16:50PM -0700, Adam Williamson wrote: Well, I can't actually concur. See my results in https://bugzilla.kernel.org/show_bug.cgi?id=68291#c44 . 1. A kernel

Re: [PATCH] pinctrl-baytrail: fix for irq descriptor conflict on ASUS T100TA

2014-04-25 Thread Jin, Yao
On 2014/4/25 5:33, Adam Williamson wrote: On Thu, 2014-04-24 at 21:30 +0800, Jin, Yao wrote: Jin, do you have any idea what is going on? Maybe neither the patch (http://dougvj.net/baytrail_gpio_quirk_v3.patch) nor my patch breaks the touch screen. I have tried the clean 3.15-rc2

Re: [PATCH] pinctrl-baytrail: fix for irq descriptor conflict on ASUS T100TA

2014-04-25 Thread Jin, Yao
On 2014/4/25 17:40, Mika Westerberg wrote: [+Aubrey] On Fri, Apr 25, 2014 at 03:27:42PM +0800, Jin, Yao wrote: On 2014/4/25 5:33, Adam Williamson wrote: On Thu, 2014-04-24 at 21:30 +0800, Jin, Yao wrote: Jin, do you have any idea what is going on? Maybe neither the patch (http

Re: [PATCH] pinctrl-baytrail: fix for irq descriptor conflict on ASUS T100TA

2014-04-25 Thread Jin, Yao
On 2014/4/25 23:13, Adam Williamson wrote: On Fri, 2014-04-25 at 11:32 +0200, Linus Walleij wrote: On Thu, Apr 24, 2014 at 11:33 PM, Adam Williamson awill...@redhat.com wrote: Well, I just ran another test too. I built a kernel (3.15rc2) with both v3 of Doug's SDIO device enumeration

Re: [PATCH] pinctrl-baytrail: fix for irq descriptor conflict on ASUS T100TA

2014-04-25 Thread Jin, Yao
On 2014/4/26 11:04, Jin, Yao wrote: On 2014/4/25 23:13, Adam Williamson wrote: On Fri, 2014-04-25 at 11:32 +0200, Linus Walleij wrote: On Thu, Apr 24, 2014 at 11:33 PM, Adam Williamson awill...@redhat.com wrote: Well, I just ran another test too. I built a kernel (3.15rc2) with both

Re: [PATCH] pinctrl-baytrail: fix for irq descriptor conflict on ASUS T100TA

2014-04-20 Thread Jin, Yao
On 2014/4/19 4:44, Benjamin Tissoires wrote: On Wed, Apr 16, 2014 at 8:05 AM, Jin Yao yao@linux.intel.com wrote: A crash is triggered on the ASUS T100TA Baytrail-T because of a irq descriptor conflict. There are two gpio triggered acpi events in this device, GPIO 6 and 18. These gpios

Re: [PATCH] pinctrl-baytrail: fix for irq descriptor conflict on ASUS T100TA

2014-04-20 Thread Jin, Yao
:31, Jin, Yao wrote: On 2014/4/19 4:44, Benjamin Tissoires wrote: On Wed, Apr 16, 2014 at 8:05 AM, Jin Yao yao@linux.intel.com wrote: A crash is triggered on the ASUS T100TA Baytrail-T because of a irq descriptor conflict. There are two gpio triggered acpi events in this device, GPIO 6

Re: [PATCH] pinctrl-baytrail: fix for irq descriptor conflict on ASUS T100TA

2014-04-21 Thread Jin, Yao
On 2014/4/20 23:28, Adam Williamson wrote: On Sun, 2014-04-20 at 20:08 +0800, Jin, Yao wrote: For the issue that touch screen doesn't work, could you check power state of LPSS devices? For example: cd /sys/bus/acpi/devices grep -H . */power_state If they are D3cold, it should

Re: [PATCH] pinctrl-baytrail: fix for irq descriptor conflict on ASUS T100TA

2014-04-21 Thread Jin, Yao
On 2014/4/21 14:27, Jin, Yao wrote: On 2014/4/20 23:28, Adam Williamson wrote: On Sun, 2014-04-20 at 20:08 +0800, Jin, Yao wrote: For the issue that touch screen doesn't work, could you check power state of LPSS devices? For example: cd /sys/bus/acpi/devices grep -H . */power_state

Re: [PATCH] pinctrl-baytrail: fix for irq descriptor conflict on ASUS T100TA

2014-04-22 Thread Jin, Yao
Thanks Mika, I will fix this warning. On 2014/4/22 19:51, Mika Westerberg wrote: On Wed, Apr 16, 2014 at 08:05:59PM +0800, Jin Yao wrote: A crash is triggered on the ASUS T100TA Baytrail-T because of a irq descriptor conflict. There are two gpio triggered acpi events in this device, GPIO 6

Re: [PATCH] pinctrl-baytrail: workaround for irq descriptor conflict on ASUS T100TA

2014-04-22 Thread Jin, Yao
On 2014/4/22 21:18, Linus Walleij wrote: On Mon, Apr 14, 2014 at 4:48 AM, Jin, Yao yao@linux.intel.com wrote: A crash is triggered on the ASUS T100TA Baytrail-T because of a IRQ descriptor conflict. There are two gpio triggered acpi events in this device, GPIO 6 and 18. These gpios

[PATCH] pinctrl-baytrail: fix for irq descriptor conflict on ASUS T100TA

2014-04-16 Thread Jin Yao
. It still uses the irq domain to allocate irq descriptor but start from a predefined irq base number (256) to avoid the conflict. Signed-off-by: Jin Yao yao@linux.intel.com --- drivers/pinctrl/pinctrl-baytrail.c | 37 + 1 file changed, 29 insertions(+), 8

[PATCH] pinctrl-baytrail: workaround for irq descriptor conflict on ASUS T100TA

2014-04-13 Thread Jin, Yao
the IRQ conflict. It still uses the irq domain to allocate irq descriptor but start from a predefined irq base number (256). Signed-off-by: Jin Yao yao@linux.intel.com --- drivers/pinctrl/pinctrl-baytrail.c | 37 + 1 file changed, 29 insertions(+), 8 deletions

Re: [alsa-devel] [PATCH -next] ASoC: Intel: sst_hsw: remove kfree for memory allocated with devm_kzalloc

2015-04-16 Thread Jin, Yao
For HSW, a patch [PATCH] ASoC: Intel: Remove invalid kfree of devm allocated data to fix this issue has been applied. But yes, we also need a similar patch for Baytrail. Thanks Jin Yao On 2015/4/16 22:08, Jarkko Nikula wrote: On 04/16/2015 04:46 PM, weiyj...@163.com wrote: From: Wei Yongjun

Re: [alsa-devel] [PATCH] ASoC: Intel: fix ifnullfree.cocci warnings

2015-04-12 Thread Jin, Yao
JIn Yao On 2015/4/13 3:06, kbuild test robot wrote: sound/soc/intel/common/sst-ipc.c:287:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values

Re: [PATCH v3 0/5] perf report: Show inline stack

2017-02-20 Thread Jin, Yao
Hi, Any comments for this patch series? Thanks Jin Yao On 1/20/2017 5:39 PM, Jin Yao wrote: v3: Iterate on RIPs of all callchain entries to check if the RIP is in inline functions. Reverse the order of the inliner printout if necessary. Provide new options "--inline

[PATCH v3 3/5] perf report: Create new inline options

2017-01-19 Thread Jin Yao
printed. Each entry is the inline function name. --inline-line: If a callgraph address belongs to an inlined function, the inline stack will be printed. Each entry is the inline function source line. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/Documentation/perf-report.tx

[PATCH v3 2/5] perf report: Find the inline stack for a given address

2017-01-19 Thread Jin Yao
extends the function to let it support getting the inline stacks. It introduces the inline_list which will store the inline function result (filename:line_nr and funcname). Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/util/srcline.c

[PATCH v3 5/5] perf report: Show inline stack in browser mode

2017-01-19 Thread Jin Yao
(inline) /usr/include/c++/5/bits/random.h:332 (inline) /usr/include/c++/5/bits/random.h:151 (inline) - __hypot __hypot_finite Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/ui/browsers/hists.c | 170 +++--

[PATCH v3 0/5] perf report: Show inline stack

2017-01-19 Thread Jin Yao
the source line, actually the inline stack is equal to: 0.05% test2test2 [.] main | ---D C B A Jin Yao (5): perf report: Refactor common code in srcline.c perf report: Find the inline stack for a given address perf report: Create new inli

[PATCH v3 4/5] perf report: Show inline stack in stdio mode

2017-01-19 Thread Jin Yao
) /usr/include/c++/5/bits/random.h:332 (inline) /usr/include/c++/5/bits/random.h:151 (inline) __hypot | --40.09%--__hypot_finite The tag "inline" indicates these items are the entries in inline stack. Signed-off-by: Ji

[PATCH v3 1/5] perf report: Refactor common code in srcline.c

2017-01-19 Thread Jin Yao
) { *sep++ = '\0'; *file = filename; *line_nr = strtoul(sep, NULL, 0); ret = 1; } out: pclose(fp); return ret; If sep is NULL, filename is not freed or returned via file. Signed-off-by: Jin Yao <

[PATCH] perf symbols: Not using the ubuntu debuginfo when dso load

2016-09-01 Thread Jin Yao
nally objdump uses wrong start address to disassemble /lib/x86_64-linux-gnu/libc-2.23.so. This patch lets dso__load not try ubuntu debuginfo (/usr/lib/debug/lib/x86_64-linux-gnu/libc-2.23.so in this example), because 1: the image doesn't have valid assembly code (check output of objdump) 2: i

RE: [RFC][PATCH 7/7] perf/annotate: Add branch stack / basic block information

2016-09-08 Thread Jin, Yao
changed. Please let me know what do you think for this patch and if I should go ahead. Thanks Jin Yao -Original Message- From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] Sent: Friday, September 9, 2016 1:11 AM To: Andi Kleen <a...@firstfloor.org> Cc: Stephane Eranian <er

[PATCH v3 6/6] perf report: Display columns Predicted/Abort/Cycles in --branch-history

2016-10-25 Thread Jin Yao
ject Predicted Abort Cycles . . . .. 38.25% div.c:45 [.] main div97.6% 0 3 Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/Documentation/perf-report.txt | 12 tools/perf/builtin-report.c

[PATCH v3 1/6] perf report: Add branch flag to callchain cursor node

2016-10-25 Thread Jin Yao
it has. The branch history code has a loop detection pass that removes small loops. It would be nice for knowing how many loops were removed. This patch records the number of removed loops in a callchain cursor node. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/util/callchain.

[PATCH v3 5/6] perf report: Show branch info in callchain entry for browser mode

2016-10-25 Thread Jin Yao
If the branch is 100% predicated then the "predicated" is hide. Similarly, if there is no branch tsx abort, the "abort" is hide. There is only cycles shown (cycle is supported on skylake platform, older platform would be 0). If no removed loops, the "removed loops"

[PATCH v3 3/6] perf report: Create a symbol_conf flag for showing branch flag counting

2016-10-25 Thread Jin Yao
Create a new flag show_branchflag_count in symbol_conf. The flag is used to control if showing the branch flag counting information. The flag depends on if the perf.data has branch data and if user chooses the "branch-history" option in perf report command line. Signed-off-by: Ji

Re: [PATCH v3 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view

2016-10-25 Thread Jin, Yao
If I change it to, for example: removed iterations: 20% Is that OK? Thanks Jin Yao On 10/26/2016 9:19 AM, Andi Kleen wrote: | | | |--29.93%--main div.c:39 (predicted:50.6%, cycles:1, removed loops:12954) Removed loops should be divided

[PATCH v3 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view

2016-10-25 Thread Jin Yao
random.c:295 (cycles:1) | |__random random.c:295 (cycles:1) | |__random random.c:295 (cycles:1) Jin Yao (6): perf report: Add branch flag to callchain cursor node perf report: Caculate

[PATCH v3 2/6] perf report: Caculate and return the branch flag counting

2016-10-25 Thread Jin Yao
in callchain list. Besides the counting for branch flags, it also counts and returns the number of removed loops. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/util/callchain.c | 184 +++- tools/perf/util/callchain.h | 13 2

[PATCH v3 4/6] perf report: Show branch info in callchain entry for stdio mode

2016-10-25 Thread Jin Yao
_random random.c:297 (cycles:1) |__random random.c:295 (cycles:1) |__random random.c:295 (cycles:1) |__random random.c:295 (cycles:1) |__random random.c:295 (cycles:6

Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-20 Thread Jin, Yao
Hi Andi, Hi Nilay, Thanks so much for your comments! I will upgrade the patch to just display the count for abort. Thanks Jin Yao On 10/21/2016 2:20 AM, Andi Kleen wrote: OK, I am more confused now. Are you predicting some quantity related to transactions? Why would you divide abort count

Re: [PATCH 0/6] Show branch flags/cycles in perf report --branch-history callgraph view

2016-10-19 Thread Jin, Yao
/linux.git)? If so, I'd like to resend the patch. Thanks Jin Yao On 10/19/2016 4:26 PM, Jiri Olsa wrote: On Wed, Oct 19, 2016 at 05:25:47PM +0800, Jin Yao wrote: SNIP Predicted is hide in callchain entry if the branch is 100% predicted. Abort is hide in callchain entry if the branch is 0

[PATCH v2 3/6] perf report: Create a symbol_conf flag for showing branch flag counting

2016-10-19 Thread Jin Yao
Create a new flag show_branchflag_count in symbol_conf. The flag is used to control if showing the branch flag counting information. The flag depends on if the perf.data has branch data and if user chooses the "branch-history" option in perf report command line. Signed-off-by: Ji

[PATCH v2 5/6] perf report: Show branch info in callchain entry for browser mode

2016-10-19 Thread Jin Yao
If the branch is 100% predicated then the "predicated" is hide. Similarly, if there is no branch tsx abort, the "abort" is hide. There is only cycles shown (cycle is supported on skylake platform, older platform would be 0). Signed-off-by: Jin Yao <yao@linux.intel.

[PATCH v2 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view

2016-10-19 Thread Jin Yao
) | | | | | --22.69%--main div.c:42 (cycles:2) Predicted is hide in callchain entry if the branch is 100% predicted. Abort is hide in callchain entry if the branch is 0 aborted. Now stdio and browser modes are both supported. Jin Yao (6

[PATCH v2 1/6] perf report: Add branch flag to callchain cursor node

2016-10-19 Thread Jin Yao
it has. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/util/callchain.c | 11 +++-- tools/perf/util/callchain.h | 5 +++- tools/perf/util/machine.c | 56 + 3 files changed, 55 insertions(+), 17 deletions(-) diff --git a/tool

[PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-19 Thread Jin Yao
in callchain list. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/util/callchain.c | 165 +++- tools/perf/util/callchain.h | 11 +++ 2 files changed, 175 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/callchain.c b/tool

[PATCH v2 4/6] perf report: Show branch info in callchain entry for stdio mode

2016-10-19 Thread Jin Yao
s:1) | main div.c:40 (cycles:16) | main div.c:39 (cycles:16) | | | |--29.93%--main div.c:39 (predicted:50.6%, cycles:1) | | main div.c:44 (predicted:50.6%, cycles:1) Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools

[PATCH v2 6/6] perf report: Display columns Predicted/Abort/Cycles in --branch-history

2016-10-19 Thread Jin Yao
icted Abort Cycles . . . .. 38.25% div.c:45 [.] main div97.6% 0.0% 3 Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/Documentation/perf-report.txt | 8 +++ tools/perf/builtin-report.c

[PATCH 5/6] perf report: Show branch info in callchain entry with browser mode

2016-10-18 Thread Jin Yao
If the branch is 100% predicated then the "predicated" is hide. Similarly, if there is no branch tsx abort, the "abort" is hide. There is only cycles shown (cycle is supported on skylake platform, older platform would be 0). Signed-off-by: Jin Yao <yao@linux.intel.

[PATCH 3/6] perf report: Create a symbol_conf flag for showing branch flag counting

2016-10-18 Thread Jin Yao
Create a new flag show_branchflag_count in symbol_conf. The flag is used to control if showing the branch information. The flag depends on if the perf.data has branch data and if user chooses the "branch-history" option in perf report command line. Signed-off-by: Jin Yao <yao@li

[PATCH 4/6] perf report: Show branch info in callchain entry with stdio mode

2016-10-18 Thread Jin Yao
s:1) | main div.c:40 (cycles:16) | main div.c:39 (cycles:16) | | | |--29.93%--main div.c:39 (predicted:50.6%, cycles:1) | | main div.c:44 (predicted:50.6%, cycles:1) Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools

[PATCH 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-18 Thread Jin Yao
in callchain list. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/util/callchain.c | 165 +++- tools/perf/util/callchain.h | 11 +++ 2 files changed, 175 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/callchain.c b/tool

[PATCH 6/6] perf report: Display keys Predicted/Abort/Cycles in --branch-history

2016-10-18 Thread Jin Yao
icted Abort Cycles . . . .. 38.25% div.c:45 [.] main div97.6% 0.0% 3 Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/Documentation/perf-report.txt | 8 +++ tools/perf/builtin-report.c

[PATCH 1/6] perf report: Add branch flag to callchain cursor node

2016-10-18 Thread Jin Yao
. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/util/callchain.c | 11 +++-- tools/perf/util/callchain.h | 5 +++- tools/perf/util/machine.c | 56 + 3 files changed, 55 insertions(+), 17 deletions(-) diff --git a/tools/per

[PATCH 0/6] Show branch flags/cycles in perf report --branch-history callgraph view

2016-10-18 Thread Jin Yao
:42 (cycles:2) Predicted is hide in callchain entry if the branch is 100% predicted. Abort is hide in callchain entry if the branch is 0 aborted. Now stdio and browser modes are both supported. Jin Yao (6): perf report: Add branch flag to callchain cursor node perf report: Caculate and return

Re: [PATCH v4 4/6] perf report: Show branch info in callchain entry for stdio mode

2016-11-14 Thread Jin, Yao
Sorry, spelling mistake. It should be "predicted" and "is hidden". Thanks for correcting on that. Thanks Jin Yao On 11/15/2016 12:34 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Oct 31, 2016 at 09:19:52AM +0800, Jin Yao escreveu: If the branch is 100% predicated then the

[PATCH v1 0/4] perf report: Show inline stack

2016-11-28 Thread Jin Yao
dicate the source line, actually the inline stack is equal to: 0.05% test2test2 [.] main | ---D C B A Jin Yao (4): perf report: Find the inline stack for a given address perf report: Create a new option "--inline" perf report:

[PATCH v1 1/4] perf report: Find the inline stack for a given address

2016-11-28 Thread Jin Yao
extends the function to let it support getting the inline stacks. The results (filename:line_nr) would be saved in a list and returned to the caller. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/util/srcline.c | 206 +++--- tool

[PATCH v1 4/4] perf report: Show inline stack in browser mode

2016-11-28 Thread Jin Yao
For example: -0.05% test2test2 [.] main /home/jinyao/perf-dev/test/test2.c:27 (inline) /home/jinyao/perf-dev/test/test2.c:35 (inline) /home/jinyao/perf-dev/test/test2.c:45 (inline) /home/jinyao/perf-dev/test/test2.c:61 (inline) Signed-off-by: Jin Yao

[PATCH v1 3/4] perf report: Show inline stack in stdio mode

2016-11-28 Thread Jin Yao
(inline) /home/jinyao/perf-dev/test/test2.c:45 (inline) /home/jinyao/perf-dev/test/test2.c:61 (inline) The tag "inline" indicates these items are the entries in inline stack. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/ui/s

[PATCH v1 2/4] perf report: Create a new option "--inline"

2016-11-28 Thread Jin Yao
It takes some time to look for inline stack for callgraph addresses. So it provides a new option "--inline" to let user decide if enable this feature. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/Documentation/perf-report.txt | 4 tools/perf/

[PATCH v4 5/6] perf report: Show branch info in callchain entry for browser mode

2016-10-30 Thread Jin Yao
If the branch is 100% predicated then the "predicated" is hide. Similarly, if there is no branch tsx abort, the "abort" is hide. There is only cycles shown (cycle is supported on skylake platform, older platform would be 0). If no iterations, the "iterations" is hide

[PATCH v4 3/6] perf report: Caculate and return the branch flag counting

2016-10-30 Thread Jin Yao
in callchain list. Besides the counting for branch flags, it also counts and returns the average number of iterations. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/util/callchain.c | 189 +++- tools/perf/util/callchain.h | 14 +

[PATCH v4 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view

2016-10-30 Thread Jin Yao
) | | | | | --10.52%--compute_flag div.c:27 (cycles:1) | |rand rand.c:28 (cycles:1) Jin Yao (6): perf report: Add branch flag to callchain cursor node perf report: Create a symbol_conf flag

[PATCH v4 4/6] perf report: Show branch info in callchain entry for stdio mode

2016-10-30 Thread Jin Yao
_random random.c:297 (cycles:1) |__random random.c:295 (cycles:1) |__random random.c:295 (cycles:1) |__random random.c:295 (cycles:1) |__random random.c:295 (cycles:6) Signed-off-by: Ji

[PATCH v4 2/6] perf report: Create a symbol_conf flag for showing branch flag counting

2016-10-30 Thread Jin Yao
Create a new flag show_branchflag_count in symbol_conf. The flag is used to control if showing the branch flag counting information. The flag depends on if the perf.data has branch data and if user chooses the "branch-history" option in perf report command line. Signed-off-by: Ji

[PATCH v4 1/6] perf report: Add branch flag to callchain cursor node

2016-10-30 Thread Jin Yao
, it's good enough. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/util/callchain.c | 14 ++-- tools/perf/util/callchain.h | 8 - tools/perf/util/machine.c | 82 - 3 files changed, 86 insertions(+), 18 deletions(-) diff

[PATCH v4 6/6] perf report: Display columns Predicted/Abort/Cycles in --branch-history

2016-10-30 Thread Jin Yao
ject Predicted Abort Cycles . . . .. 38.25% div.c:45 [.] main div97.6% 0 3 Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/Documentation/perf-report.txt | 9 +++ tools/perf/builtin-report.c

[PATCH v2 4/5] perf report: Show inline stack in stdio mode

2016-12-06 Thread Jin Yao
(inline) /home/jinyao/perf-dev/test/test2.c:45 (inline) /home/jinyao/perf-dev/test/test2.c:61 (inline) The tag "inline" indicates these items are the entries in inline stack. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/ui/s

[PATCH v2 5/5] perf report: Show inline stack in browser mode

2016-12-06 Thread Jin Yao
For example: -0.05% test2test2 [.] main /home/jinyao/perf-dev/test/test2.c:27 (inline) /home/jinyao/perf-dev/test/test2.c:35 (inline) /home/jinyao/perf-dev/test/test2.c:45 (inline) /home/jinyao/perf-dev/test/test2.c:61 (inline) Signed-off-by: Jin Yao

[PATCH v2 3/5] perf report: Create a new option "--inline"

2016-12-06 Thread Jin Yao
It takes some time to look for inline stack for callgraph addresses. So it provides a new option "--inline" to let user decide if enable this feature. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/Documentation/perf-report.txt | 4 tools/perf/

[RESEND PATCH v2 5/5] perf report: Show inline stack in browser mode

2016-12-06 Thread Jin Yao
For example: -0.05% test2test2 [.] main /home/jinyao/perf-dev/test/test2.c:27 (inline) /home/jinyao/perf-dev/test/test2.c:35 (inline) /home/jinyao/perf-dev/test/test2.c:45 (inline) /home/jinyao/perf-dev/test/test2.c:61 (inline) Signed-off-by: Jin Yao

[RESEND PATCH v2 3/5] perf report: Create a new option "--inline"

2016-12-06 Thread Jin Yao
It takes some time to look for inline stack for callgraph addresses. So it provides a new option "--inline" to let user decide if enable this feature. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/Documentation/perf-report.txt | 4 tools/perf/

[RESEND PATCH v2 1/5] perf report: Refactor common code in srcline.c

2016-12-06 Thread Jin Yao
) { *sep++ = '\0'; *file = filename; *line_nr = strtoul(sep, NULL, 0); ret = 1; } out: pclose(fp); return ret; If sep is NULL, filename is not freed or returned via file. Signed-off-by: Jin Yao <

[RESEND PATCH v2 0/5] perf report: Show inline stack

2016-12-06 Thread Jin Yao
te the source line, actually the inline stack is equal to: 0.05% test2test2 [.] main | ---D C B A Jin Yao (5): perf report: Refactor common code in srcline.c perf report: Find the inline stack for a given address perf report: Create a new option &qu

[RESEND PATCH v2 2/5] perf report: Find the inline stack for a given address

2016-12-06 Thread Jin Yao
extends the function to let it support getting the inline stacks. It introduces the inline_list which will store the inline function result (format is filename:line_nr). Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/util/srcline.c

[RESEND PATCH v2 4/5] perf report: Show inline stack in stdio mode

2016-12-06 Thread Jin Yao
(inline) /home/jinyao/perf-dev/test/test2.c:45 (inline) /home/jinyao/perf-dev/test/test2.c:61 (inline) The tag "inline" indicates these items are the entries in inline stack. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/ui/s

[PATCH v2 2/5] perf report: Find the inline stack for a given address

2016-12-06 Thread Jin Yao
extends the function to let it support getting the inline stacks. It introduces the inline_list which will store the inline function result (format is filename:line_nr). Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/util/srcline.c

Re: [PATCH v2 0/5] perf report: Show inline stack

2016-12-06 Thread Jin, Yao
So sorry, please ignore this v2 patch series. I missed the Arnaldo other comments which were added in the code. I will RESEND v2 patch series later. On 12/7/2016 9:30 PM, Jin Yao wrote: v2: Thanks so much for Arnaldo's comments! The modifications are: 1. Divide v1 patch "

[PATCH v2 0/5] perf report: Show inline stack

2016-12-06 Thread Jin Yao
tually the inline stack is equal to: 0.05% test2test2 [.] main | ---D C B A Jin Yao (5): perf report: Refactor common code in srcline.c perf report: Find the inline stack for a given address perf report: Create a new option "--i

[PATCH v2 1/5] perf report: Refactor common code in srcline.c

2016-12-06 Thread Jin Yao
) { *sep++ = '\0'; *file = filename; *line_nr = strtoul(sep, NULL, 0); ret = 1; } out: pclose(fp); return ret; If sep is NULL, filename is not freed or returned via file. Signed-off-by: Jin Yao <

Re: [PATCH v2 0/5] perf report: Show inline stack

2016-12-07 Thread Jin, Yao
Got it, thanks so much! I will use the new version rather than just using the "RESEND" prefix in the future. For this time, since the "RESEND PATCH v2" has been sent out, I will not resend the v3 to avoid sending duplicate content to the mailing list. I will take care

Re: [PATCH v1 0/4] perf report: Show inline stack

2016-12-05 Thread Jin, Yao
Any comments on this patch series? Thanks Jin Yao On 11/29/2016 10:55 PM, Jin Yao wrote: It would be useful for perf to support a mode to query the inline stack for callgraph addresses. This would simplify finding the right code in code that does a lot of inlining. For example, the c code

Re: Inlined functions in perf report

2016-12-20 Thread Jin, Yao
(https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git) and branch (remotes/origin/perf/core). Thanks Jin Yao On 12/21/2016 1:01 AM, Steinar H. Gunderson wrote: On Tue, Dec 20, 2016 at 11:37:46AM -0300, Arnaldo Carvalho de Melo wrote: Woot. Is this available in git somewhere

Re: Inlined functions in perf report

2016-12-21 Thread Jin, Yao
/test2.c:27 /home/jinyao/skl-ws/perf-dev/lck-2867/test/test2.c:35 /home/jinyao/skl-ws/perf-dev/lck-2867/test/test2.c:45 /home/jinyao/skl-ws/perf-dev/lck-2867/test/test2.c:61 004004f0 : .. 40052d: e8 6e ff ff ff callq 4004a0 <puts@plt> Thanks Jin Yao On

Re: [PATCH v5 0/5] perf report: Show inline stack

2017-03-24 Thread Jin, Yao
_SLANG=1 FEATURES_DUMP=/home/jinyao/skl-ws/perf-dev/tmp/acme/tools/perf/BUILD_TEST_FEATURE_DUMP -j8 O=/tmp/tmp.eDBcxsrMuA DESTDIR=/tmp/tmp.0wwJYGzYTr OK I will send a patch "perf report: Fix build-test error for make_minimal_O target" to fix that. Thanks so much for your help! Thanks Jin

[PATCH] perf report: Fix build-test error for make_minimal_O target

2017-03-24 Thread Jin Yao
make -C tools/perf build-test The error is "undefined reference to dso__demangle_sym". This patch adds the dso__dmangle_sym() in symbol-minimal.c to fix it. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/util/symbol-minimal.c | 7 +++ 1 file changed, 7 ins

[PATCH v6 5/5] perf report: Show inline stack for browser mode

2017-03-25 Thread Jin Yao
/rtld.c:413 (inline) + _dl_sysdep_start dl-sysdep.c:250 Signed-off-by: Jin Yao <yao@linux.intel.com> Tested-by: Arnaldo Carvalho de Melo <a...@redhat.com> Tested-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/ui/brow

[PATCH v6 4/5] perf report: Show inline stack for stdio mode

2017-03-25 Thread Jin Yao
kernfs_refresh_inode security_inode_notifysecctx selinux_inode_notifysecctx selinux_inode_setsecurity security_context_to_sid security_context_to_sid_core string_to_context_struct symcmp Signed-off-by: Jin

[PATCH v6 2/5] perf report: Find the inline stack for a given address

2017-03-25 Thread Jin Yao
extends the function to let it support getting the inline stacks. It introduces the inline_list which will store the inline function result (filename:line_nr and funcname). If BFD lib is not supported, the result is only filename:line_nr. Signed-off-by: Jin Yao <yao@linux.intel.com>

[PATCH v6 1/5] perf report: Refactor common code in srcline.c

2017-03-25 Thread Jin Yao
) { *sep++ = '\0'; *file = filename; *line_nr = strtoul(sep, NULL, 0); ret = 1; } out: pclose(fp); return ret; If sep is NULL, filename is not freed or returned via file. Signed-off-by: Yao Jin <

[PATCH v6 0/5] perf report: Show inline stack

2017-03-25 Thread Jin Yao
c code to indicate the source line, actually the inline stack is equal to: 0.05% test2test2 [.] main | ---D C B A Jin Yao (5): perf report: Refactor common code in srcline.c perf report: Find the inline stack for a given address per

[PATCH v6 3/5] perf report: Introduce --inline option

2017-03-25 Thread Jin Yao
ction name or file/line. Signed-off-by: Yao Jin <yao@linux.intel.com> Tested-by: Milian Wolff <milian.wo...@kdab.com> Cc: Andi Kleen <a...@linux.intel.com> Cc: Jiri Olsa <jo...@kernel.org> Cc: Kan Liang <kan.li...@intel.com> Link: http://lkml.kernel.or

Re: [PATCH v5 2/5] perf report: Find the inline stack for a given address

2017-03-25 Thread Jin, Yao
Jin Yao On 3/25/2017 3:18 PM, Ravi Bangoria wrote: Hi Jin / Arnaldo, I see a build failure with this patch: On Friday 17 March 2017 03:12 AM, Jin Yao wrote: It would be useful for perf to support a mode to query the inline stack for a given callgraph address. This would simplify finding

[PATCH v5 1/5] perf report: Refactor common code in srcline.c

2017-03-16 Thread Jin Yao
) { *sep++ = '\0'; *file = filename; *line_nr = strtoul(sep, NULL, 0); ret = 1; } out: pclose(fp); return ret; If sep is NULL, filename is not freed or returned via file. Signed-off-by: Jin Yao <

[PATCH v5 4/5] perf report: Show inline stack for stdio mode

2017-03-16 Thread Jin Yao
:2076 Signed-off-by: Jin Yao <yao@linux.intel.com> Tested-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/ui/stdio/hist.c | 79 +- 1 file changed, 78 insertions(+), 1 deletion(-) diff --git a/tools/perf/ui/stdio/hist.c b/tools/p

Re: [PATCH v4 0/5] perf report: Show inline stack

2017-03-16 Thread Jin, Yao
Hi Wolff, Thanks so much for your review comments! I just send out the v5 patch series. The patch series are updated according to your comments. Thanks Jin Yao On 3/14/2017 8:59 PM, Milian Wolff wrote: On Friday, March 3, 2017 11:43:00 AM CET Jin Yao wrote: v4: Remove the options

[PATCH v5 2/5] perf report: Find the inline stack for a given address

2017-03-16 Thread Jin Yao
extends the function to let it support getting the inline stacks. It introduces the inline_list which will store the inline function result (filename:line_nr and funcname). Signed-off-by: Jin Yao <yao@linux.intel.com> Tested-by: Milian Wolff <milian.wo...@kdab.com> --- too

[PATCH v5 3/5] perf report: Create new inline option

2017-03-16 Thread Jin Yao
me or file/line. Signed-off-by: Jin Yao <yao@linux.intel.com> Tested-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/Documentation/perf-report.txt | 4 tools/perf/builtin-report.c | 2 ++ tools/perf/util/symbol.h | 3 ++- 3 files chang

[PATCH v5 5/5] perf report: Show inline stack for browser mode

2017-03-16 Thread Jin Yao
/rtld.c:413 (inline) + _dl_sysdep_start dl-sysdep.c:250 Signed-off-by: Jin Yao <yao@linux.intel.com> Tested-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/ui/browsers/hists.c | 171 +++-- tools/perf/util/hist.c | 5 ++ too

[PATCH v5 0/5] perf report: Show inline stack

2017-03-16 Thread Jin Yao
st/test2.c:27 (inline) /home/perf-dev/lck-2867/test/test2.c:35 (inline) /home/perf-dev/lck-2867/test/test2.c:45 (inline) /home/perf-dev/lck-2867/test/test2.c:61 (inline) I tag A/B/C/D in above c code to indicate the source line, actually the inline stack is equal to

[PATCH v4 1/5] perf/core: Define the common branch type classification

2017-04-11 Thread Jin Yao
. Remove the "cross" field in perf_branch_entry. The cross page computing will be done later in userspace. Signed-off-by: Jin Yao <yao@linux.intel.com> --- include/uapi/linux/perf_event.h | 29 - tools/include/uapi/linux/p

[PATCH v4 3/5] perf record: Create a new option save_type in --branch-filter

2017-04-11 Thread Jin Yao
The option indicates the kernel to save branch type during sampling. One example: perf record -g --branch-filter any,save_type Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/Documentation/perf-record.txt | 1 + tools/perf/util/parse-branch-options.c | 1 + 2 files chan

[PATCH v4 4/5] perf report: Show branch type statistics for stdio mode

2017-04-11 Thread Jin Yao
and to addresses. Signed-off-by: Jin Yao <yao@linux.intel.com> --- tools/perf/builtin-report.c | 70 + tools/perf/util/event.h | 3 +- tools/perf/util/hist.c | 5 +--- tools/perf/util/util.c

[PATCH v4 5/5] perf report: Show branch type in callchain entry

2017-04-11 Thread Jin Yao
forward/JCC backward and cross page checking in user space by from and to addresses, while each callchain entry only contains one ip (either from or to), so this patch will append a branch from address to the callchain entry which just contains the to ip. Signed-off-by: Jin Yao <yao@linux.intel.

[PATCH v4 0/5] perf report: Show branch type

2017-04-11 Thread Jin Yao
_random random.c:295 (JCC forward cycles:1) __random random.c:295 (JCC forward cycles:1) __random random.c:295 (JCC forward cycles:1) __random random.c:295 (RET cycles:9) Jin Yao (5): perf/core: Define the common branch type classification perf/x86/intel

  1   2   3   4   5   6   7   8   9   10   >