[PATCH] platform/x86: asus-wireless: Fix NULL pointer dereference

2018-04-06 Thread João Paulo Rechi Vita
ported-by: Dun Hum Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-wireless.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c index 343e12547660..ecd715c82de5 100644 --- a/drivers/platform/x8

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-19 Thread João Paulo Rechi Vita
land ABI and I don't think it has good enough reasons to do that. > This only changes which state will be reported when the battery is 100% charged and not discharging, it does not introduce / remove any values. I don't think that is considered ABI change, and on other hardware like the Dell Latitude 5480, /sys/class/power_supply//status already reports "Full" under these conditions. I still believe it is a bug that makes the ABI inconsistent across different hardware. -- João Paulo Rechi Vita http://about.me/jprvita

[PATCH 0/3] Fix display off hotkey on Asus machines

2018-10-31 Thread João Paulo Rechi Vita
with Wayland, so any clarifications in that regard would be greatly appreciated. João Paulo Rechi Vita (3): asus-wmi: Tell the EC the OS will handle the display off hotkey asus-nb-wmi: Map 0x35 to KEY_SCREENLOCK asus-nb-wmi: Drop mapping of 0x33 and 0x34 scan codes drivers/platform/x86/asus-nb-wm

[PATCH 1/3] asus-wmi: Tell the EC the OS will handle the display off hotkey

2018-10-31 Thread João Paulo Rechi Vita
IANE (Local0) } } ElseIf ((BLCT == One)) { If (ATKP) { ATKD.IANE (0x35) } } } (...) } Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-wmi.c | 3 ++- 1

[PATCH 2/3] asus-nb-wmi: Map 0x35 to KEY_SCREENLOCK

2018-10-31 Thread João Paulo Rechi Vita
-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-nb-wmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index db2af09067db..5a00a7665f9b 100644 --- a/drivers/platform/x86/asus-nb-wmi.c +++ b/drivers/platform

[PATCH 3/3] asus-nb-wmi: Drop mapping of 0x33 and 0x34 scan codes

2018-10-31 Thread João Paulo Rechi Vita
-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-nb-wmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index 5a00a7665f9b..b6f2ff95c3ed 100644 --- a/drivers/platform/x86/asus-nb-wmi.c +++ b/drivers/platform/x86

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-06 Thread João Paulo Rechi Vita
Hello Hans, thanks for your quick response, On Sat, Nov 3, 2018 at 4:28 AM Hans de Goede wrote: > > Hi, > > On 03-11-18 07:57, João Paulo Rechi Vita wrote: > > Commit 19fffc8450d4378580a8f019b195c4617083176f fixed reporting > > "Discharging" on some machines whe

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-06 Thread João Paulo Rechi Vita
On Mon, Nov 5, 2018 at 1:19 AM Pavel Machek wrote: > > On Fri 2018-11-02 23:57:32, João Paulo Rechi Vita wrote: > > Commit 19fffc8450d4378580a8f019b195c4617083176f fixed reporting > > "Discharging" on some machines when AC was connected but the battery was > &

[PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-02 Thread João Paulo Rechi Vita
it takes the battery capacity into consideration when checking if "Not charging" should be returned and "Full" is returned when the capacity is 100%. Signed-off-by: João Paulo Rechi Vita --- drivers/acpi/battery.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PATCH 1/2] rfkill: Rename rfkill_any_led_trigger* functions

2018-05-22 Thread João Paulo Rechi Vita
Rename these functions to rfkill_global_led_trigger*, as they are going to be extended to handle another global rfkill led trigger. This commit does not change any functionality. Signed-off-by: João Paulo Rechi Vita --- net/rfkill/core.c | 47 --- 1

[PATCH] platform/x86: asus-wireless: Fix format specifier

2018-05-22 Thread João Paulo Rechi Vita
From: João Paulo Rechi Vita u64 should be printed with %llx instead of %x and cast to uint. Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-wireless.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/asus-wireless.c b/drivers

[PATCH] platform/x86: asus-wmi: Fix NULL pointer dereference

2018-05-22 Thread João Paulo Rechi Vita
fa7cb512 ]--- note: modprobe[3275] exited with preempt_count 2 https://bugzilla.kernel.org/show_bug.cgi?id=196467 Reported-by: red.f0...@gmail.com Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-wmi.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-)

[PATCH 2/2] rfkill: Create rfkill-none LED trigger

2018-05-22 Thread João Paulo Rechi Vita
Creates a new trigger rfkill-none, as a complement to rfkill-any, which drives LEDs when any radio is enabled. The new trigger is meant to turn a LED ON whenever all radios are OFF, and turn it OFF otherwise. Signed-off-by: João Paulo Rechi Vita --- net/rfkill/core.c | 27

RTL8723BE performance regression

2018-04-03 Thread João Paulo Rechi Vita
0.00 v4.13569dbb8261 8.41 0.00 v4.15+revert d8a5b801923.861.41 v4.15+revert d8a5b80189 18.69 1.39 Best regards, -- João Paulo Rechi Vita http://about.me/jprvita

Re: RTL8723BE performance regression

2018-04-03 Thread João Paulo Rechi Vita
gnal > strength for good and bad cases. I have tried to keep the driver and the > btcoex code in sync, but there may be some combinations of antenna > configuration and FUSE contents that cause the code to fail. > What is the recommended way to monitor the signal strength? Thanks for s

[PATCH] Bluetooth: Add a new 13d3:3496 QCA_ROME device

2018-04-27 Thread João Paulo Rechi Vita
s=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms Signed-off

Re: RTL8723BE performance regression

2018-05-01 Thread João Paulo Rechi Vita
On Tue, Apr 3, 2018 at 7:51 PM, Larry Finger wrote: > On 04/03/2018 09:37 PM, João Paulo Rechi Vita wrote: >> >> On Tue, Apr 3, 2018 at 7:28 PM, Larry Finger >> wrote: >> >> (...) >> >>> As the antenna selection code changes affected your firs

[RFC PATCH 3/3] rtlwifi: btcoex: Always use 2ant-functions for RTL8723BE

2018-05-01 Thread João Paulo Rechi Vita
] Interval Transfer Bandwidth Retr [ 4] 0.00-10.00 sec 45.9 MBytes 38.5 Mbits/sec0 sender [ 4] 0.00-10.00 sec 45.0 MBytes 37.7 Mbits/sec receiver iperf Done. Signed-off-by: João Paulo Rechi Vita --- .../realtek/rtlwifi/btcoexist

[RFC PATCH 1/3] rtlwifi: btcoex: Don't init antenna position to main port

2018-05-01 Thread João Paulo Rechi Vita
MBytes 37.7 Mbits/sec receiver iperf Done. Signed-off-by: João Paulo Rechi Vita --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c b/drivers/net

[RFC PATCH 2/3] Revert "rtlwifi: fill FW version and subversion"

2018-05-01 Thread João Paulo Rechi Vita
MBytes 38.5 Mbits/sec0 sender [ 4] 0.00-10.00 sec 45.0 MBytes 37.7 Mbits/sec receiver iperf Done. Signed-off-by: João Paulo Rechi Vita --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c | 2 -- drivers/net/wireless/realtek/rtlwifi/rtl8723com

[PATCH] Bluetooth: Ignore CC events not matching the last HCI command

2019-04-24 Thread João Paulo Rechi Vita
Address type: 0x06 LE Public LE Random Discovery: Enabled (0x01) @ MGMT Event: Discovering (0x0013) plen 2 {0x0001} [hci0] 27.422067 Address type: 0x06 LE Public LE Random Discovery: Enabled (0x01) Signed-off-by:

[RESEND PATCH 0/3] RFKill airplane-mode indicator

2016-05-02 Thread João Paulo Rechi Vita
k 577/1880 PASS rfkill_wpa2_psk 0.330014 2016-04-29 12:48:59.016711 João Paulo Rechi Vita (3): rfkill: Create "rfkill-airplane-mode" LED trigger rfkill: Userspace control for airplane mode rfkill: Notify userspace of airplane-mode state changes Documentation/rfkill.txt| 15 +++ in

[RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger

2016-05-02 Thread João Paulo Rechi Vita
From: João Paulo Rechi Vita This creates a new LED trigger to be used by platform drivers as a default trigger for airplane-mode indicator LEDs. By default this trigger will fire when RFKILL_OP_CHANGE_ALL is called for all types (RFKILL_TYPE_ALL), setting the LED brightness to LED_FULL when the

[RESEND PATCH 3/3] rfkill: Notify userspace of airplane-mode state changes

2016-05-02 Thread João Paulo Rechi Vita
From: João Paulo Rechi Vita Signed-off-by: João Paulo Rechi Vita --- Documentation/rfkill.txt| 3 +++ include/uapi/linux/rfkill.h | 4 ++-- net/rfkill/core.c | 13 + 3 files changed, 18 insertions(+), 2 deletions(-) diff --git a/Documentation/rfkill.txt b

[RESEND PATCH 2/3] rfkill: Userspace control for airplane mode

2016-05-02 Thread João Paulo Rechi Vita
From: João Paulo Rechi Vita Provide an interface for the airplane-mode indicator be controlled from userspace. User has to first acquire the control through RFKILL_OP_AIRPLANE_MODE_INDICATOR_ACQUIRE and keep the fd open for the whole time it wants to be in control of the indicator. Closing the

Re: [PATCH 2/5] asus-wmi: Create quirk for airplane_mode LED

2016-05-25 Thread João Paulo Rechi Vita
On 25 May 2016 at 03:13, Corentin Chary wrote: > On Mon, Feb 8, 2016 at 6:05 PM, João Paulo Rechi Vita > wrote: >> Some Asus laptops that have an "airplane mode" indicator LED, also have >> the WMI WLAN user bit set, and the following bits in

[PATCH 0/2] Asus Wireless Radio Control driver

2016-01-05 Thread João Paulo Rechi Vita
the series and move the commits that drive the LED to a separate series, so this part can be merged without waiting for feedback on the new airplane mode RFKill LED trigger. Regards, Joao Paulo João Paulo Rechi Vita (2): platform/x86: Add Asus Wireless Radio Control driver asus-wireless:

[PATCH 2/2] asus-wireless: Add ACPI HID ATK4001

2016-01-05 Thread João Paulo Rechi Vita
As reported in https://bugzilla.kernel.org/show_bug.cgi?id=98931#c22 in the Asus UX31A the Asus Wireless Radio Control device (ASHS) uses the HID "ATK4001". Signed-off-by: João Paulo Rechi Vita Reported-by: Tasev Nikola --- drivers/platform/x86/asus-wireless.c | 1 + 1 file

Re: [PATCH 1/4] platform/x86: Add Asus Wireless Radio Control driver

2016-01-05 Thread João Paulo Rechi Vita
On 27 December 2015 at 08:21, Andy Shevchenko wrote: > On Sat, Dec 26, 2015 at 4:56 PM, João Paulo Rechi Vita > wrote: >> Some Asus notebooks like the Asus E202SA and the Asus X555UB have a >> separate ACPI device for notifications from the airplane mode hotkey. >&g

[PATCH 1/2] platform/x86: Add Asus Wireless Radio Control driver

2016-01-05 Thread João Paulo Rechi Vita
Else { (...) } } } Signed-off-by: João Paulo Rechi Vita --- MAINTAINERS | 6 +++ drivers/platform/x86/Kconfig | 15 +++ drivers/platform/x86/Makefile| 1 + drivers/pl

Re: [PATCH 4/4] asus-wireless: Toggle airplane mode LED

2016-01-05 Thread João Paulo Rechi Vita
On 27 December 2015 at 08:32, Andy Shevchenko wrote: > On Sat, Dec 26, 2015 at 4:56 PM, João Paulo Rechi Vita > wrote: >> In the ASHS device we have the HSWC method, which basically calls either >> OWGD or OWGS, depending on its parameter: >>

[PATCH 2/9] rfkill: Remove extra blank line

2016-02-08 Thread João Paulo Rechi Vita
Signed-off-by: João Paulo Rechi Vita --- net/rfkill/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/rfkill/core.c b/net/rfkill/core.c index ffbc375..56d79cb 100644 --- a/net/rfkill/core.c +++ b/net/rfkill/core.c @@ -455,7 +455,6 @@ bool rfkill_get_global_sw_state(const enum

[PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-08 Thread João Paulo Rechi Vita
RFKILL_OP_AIRPLANE_MODE_RELEASE restores the default policy. To change state of the indicator, the RFKILL_OP_AIRPLANE_MODE_CHANGE operation is used, passing the value on "struct rfkill_event.soft". If the caller has not acquired the airplane-mode control beforehand, the operation fails. Signed-off-by: João Paulo

[PATCH 1/9] rfkill: Improve documentation language

2016-02-08 Thread João Paulo Rechi Vita
Signed-off-by: João Paulo Rechi Vita --- net/rfkill/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/rfkill/core.c b/net/rfkill/core.c index a805831..ffbc375 100644 --- a/net/rfkill/core.c +++ b/net/rfkill/core.c @@ -282,8 +282,8 @@ static void rfkill_set_block

[PATCH 6/9] rfkill: Add documentation about LED triggers

2016-02-08 Thread João Paulo Rechi Vita
Signed-off-by: João Paulo Rechi Vita --- Documentation/rfkill.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/rfkill.txt b/Documentation/rfkill.txt index 2ee6ef9..1f0c270 100644 --- a/Documentation/rfkill.txt +++ b/Documentation/rfkill.txt @@ -83,6 +83,8 @@ rfkill drivers

[PATCH 9/9] rfkill: Notify userspace of airplane-mode state changes

2016-02-08 Thread João Paulo Rechi Vita
Signed-off-by: João Paulo Rechi Vita --- Documentation/rfkill.txt | 3 +++ net/rfkill/core.c| 13 + 2 files changed, 16 insertions(+) diff --git a/Documentation/rfkill.txt b/Documentation/rfkill.txt index aa6e014..5248812 100644 --- a/Documentation/rfkill.txt +++ b

[PATCH 4/9] rfkill: Move "state" sysfs file back to stable

2016-02-08 Thread João Paulo Rechi Vita
There is still quite a bit of code using this interface, so we can't just remove it. Hopefully it will be possible in the future, but since its scheduled removal date is past 2 years already, we are better having the documentation reflecting the current state of things. Signed-off-by: João

[PATCH 0/9] RFKill airplane-mode indicator

2016-02-08 Thread João Paulo Rechi Vita
_AIRPLANE_MODE_ACQUIRE, _AIRPLANE_MODE_RELEASE, and _AIRPLANE_MODE_CHANGE. When the airplane-mode indicator state changes, userspace gets notifications through the RFKill control misc device (/dev/rfkill). The series also contains a few general fixes and improvements to the subsystem. João Paulo Rechi Vita (9

[PATCH 5/9] rfkill: Factor rfkill_global_states[].cur assignments

2016-02-08 Thread João Paulo Rechi Vita
Factor all assignments to rfkill_global_states[].cur into a single function rfkill_update_global_state(). Signed-off-by: João Paulo Rechi Vita --- net/rfkill/core.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/net/rfkill/core.c b

[PATCH 3/9] rfkill: Point to the correct deprecated doc location

2016-02-08 Thread João Paulo Rechi Vita
The "claim" sysfs interface has been removed, so its documentation now lives in the "removed" folder. Signed-off-by: João Paulo Rechi Vita --- Documentation/ABI/stable/sysfs-class-rfkill | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentat

[PATCH 7/9] rfkill: Create "rfkill-airplane_mode" LED trigger

2016-02-08 Thread João Paulo Rechi Vita
, and to LED_OFF when the changing the state to unblocked. In the future there will be a mechanism for userspace to override the default policy, so it can implement its own. This trigger will be used by the asus-wireless x86 platform driver. Signed-off-by: João Paulo Rechi Vita --- Documentation

[PATCH 0/5] asus-wireless: LED control

2016-02-08 Thread João Paulo Rechi Vita
k for airplane_mode LED" for more details). João Paulo Rechi Vita (5): asus-wireless: Toggle airplane mode LED asus-wmi: Create quirk for airplane_mode LED asus-wmi: Add quirk_no_rfkill for the Asus X552VW asus-wmi: Add quirk_no_rfkill for the Asus U303LB asus-wmi: Add quirk_no_rfki

[PATCH 2/5] asus-wmi: Create quirk for airplane_mode LED

2016-02-08 Thread João Paulo Rechi Vita
, and vice-versa. This commit creates a quirk to not register a RFKill switch at all for these laptops, to allow the asus-wireless driver to drive the airplane mode LED correctly. It also adds a match to that quirk for the Asus X555UB. Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asu

[PATCH 3/5] asus-wmi: Add quirk_no_rfkill for the Asus X552VW

2016-02-08 Thread João Paulo Rechi Vita
Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-nb-wmi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index cfee863..86c0ae6 100644 --- a/drivers/platform/x86/asus-nb-wmi.c +++ b/drivers

[PATCH 5/5] asus-wmi: Add quirk_no_rfkill for the Asus Z550MA

2016-02-08 Thread João Paulo Rechi Vita
Signed-off-by: João Paulo Rechi Vita Reported-by: Ming Shuo Chiu --- drivers/platform/x86/asus-nb-wmi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index 4ded187..5adb842 100644 --- a/drivers/platform/x86

[PATCH 4/5] asus-wmi: Add quirk_no_rfkill for the Asus U303LB

2016-02-08 Thread João Paulo Rechi Vita
Signed-off-by: João Paulo Rechi Vita Reported-by: Mousou Yuu --- drivers/platform/x86/asus-nb-wmi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index 86c0ae6..4ded187 100644 --- a/drivers/platform/x86/asus

[PATCH 1/5] asus-wireless: Toggle airplane mode LED

2016-02-08 Thread João Paulo Rechi Vita
Mode", there is, when all radios are blocked. Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/Kconfig | 2 + drivers/platform/x86/asus-wireless.c | 92 +++- 2 files changed, 93 insertions(+), 1 deletion(-) diff --git a/drivers/plat

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-08 Thread João Paulo Rechi Vita
ge from Johannes http://www.spinics.net/lists/linux-wireless/msg146069.html and let me know if that covers your concern. Thanks! -- João Paulo Rechi Vita http://about.me/jprvita

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-08 Thread João Paulo Rechi Vita
On 8 February 2016 at 11:11, Dan Williams wrote: > On Mon, 2016-02-08 at 10:41 -0500, João Paulo Rechi Vita wrote: >> Provide an interface for the airplane-mode indicator be controlled >> from >> userspace. User has to first acquire the control through >> RFKILL_OP_AIR

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-09 Thread João Paulo Rechi Vita
separate function? > Yes, makes sense. This also made me notice I was assigning a negative value to a size_t variable (count). >> + } >> + >> list_del(&data->list); >> + > > (extra line) > After factoring out the _RELEASE code it looks better without this additional line. >> mutex_unlock(&rfkill_global_mutex); >> >> mutex_destroy(&data->mtx); > > Thanks, > Thanks for the review, Julian. I'm sending an updated version. -- João Paulo Rechi Vita http://about.me/jprvita

[PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-09 Thread João Paulo Rechi Vita
RFKILL_OP_AIRPLANE_MODE_RELEASE restores the default policy. To change state of the indicator, the RFKILL_OP_AIRPLANE_MODE_CHANGE operation is used, passing the value on "struct rfkill_event.soft". If the caller has not acquired the airplane-mode control beforehand, the operation fails. Signed-off-by: João Paulo

Re: [PATCH 5/5] asus-wmi: Add quirk_no_rfkill for the Asus Z550MA

2016-02-09 Thread João Paulo Rechi Vita
On 8 February 2016 at 16:03, Darren Hart wrote: > On Mon, Feb 08, 2016 at 12:05:23PM -0500, João Paulo Rechi Vita wrote: > > I'm waiting for the RFKILL reviews to complete, but quickly, patches 4 and 5 > require a commit message. There is always something you can add here, for &g

Re: [PATCHv2 08/10] rfkill: Use switch to demux userspace operations

2016-02-29 Thread João Paulo Rechi Vita
Hello Jouni, On 26 February 2016 at 12:59, Jouni Malinen wrote: > On Mon, Feb 22, 2016 at 11:36:39AM -0500, João Paulo Rechi Vita wrote: >> Using a switch to handle different ev.op values in rfkill_fop_write() >> makes the code easier to extend, as out-of-range values can always b

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

2016-02-16 Thread João Paulo Rechi Vita
s not extend the RFKill event struct. One alternative would be to move the control point to a separate device, like /dev/rfkill-airplane-mode, but I'm not sure this is a very elegant approach. Anyway, I'm open to work on changes to the API, but it would be great if you could at least

Re: [PATCHv2 08/10] rfkill: Use switch to demux userspace operations

2016-03-08 Thread João Paulo Rechi Vita
Hello Johannes, On 1 March 2016 at 11:15, João Paulo Rechi Vita wrote: > On 1 March 2016 at 08:43, Johannes Berg wrote: >> >> I'm fine with Jouni's change, preserving the original behaviour of >> requiring TYPE_ALL or the correct type, but I'm tempted to simp

Re: X450LCP lost abillity to turn the screen off

2019-02-11 Thread João Paulo Rechi Vita
ut I'm not responsible if a BIOS update breaks your machine in any way, so just do it if you this is something you are comfortable with and understand and assume all the risks yourself. We have been reporting machines with the old behavior back to Asus, but I don't know what they are doing with that information, if anything. I'm adding your machine with the old BIOS version to the list, so if you test the new BIOS let me know so I can add that as well. But please don't feel any pressure to update the BIOS if this is something you would not do otherwise. Best regards, -- João Paulo Rechi Vita

[PATCH] Bluetooth: Add new 13d3:3491 QCA_ROME device

2019-05-23 Thread João Paulo Rechi Vita
#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb I: If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb Signed-off-by: João Paulo Rechi Vita --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth

[PATCH] Bluetooth: Add new 13d3:3501 QCA_ROME device

2019-05-23 Thread João Paulo Rechi Vita
#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb I: If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb Signed-off-by: João Paulo Rechi Vita --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth

[PATCH 0/2] Quirk to enable QCA9377 to discover BLE devices

2019-04-23 Thread João Paulo Rechi Vita
sage, and the extra command complete event can be seen at timestamp 27.420131. Best regards, João Paulo Rechi Vita (2): Bluetooth: Create new HCI_QUIRK_WAIT_FOR_MATCHING_CC Bluetooth: Set HCI_QUIRK_WAIT_FOR_MATCHING_CC for QCA9377 drivers/bluetooth/btusb.c| 9 + include/net/bl

Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2019-01-08 Thread João Paulo Rechi Vita
Hello Marcel, On Wed, Dec 5, 2018 at 11:27 AM João Paulo Rechi Vita wrote: > > Hello Marcel, > > On Fri, Nov 9, 2018 at 4:36 PM João Paulo Rechi Vita > wrote: > > > > Hello Marcel, > > > > On Thu, Nov 8, 2018 at 11:49 PM Marcel Holtmann wrote: > >

Re: [PATCH AUTOSEL 4.20 008/117] platform/x86: asus-wmi: Tell the EC the OS will handle the display off hotkey

2019-01-08 Thread João Paulo Rechi Vita
Hello Sasha, On Tue, Jan 8, 2019 at 11:26 AM Sasha Levin wrote: > > From: João Paulo Rechi Vita > > [ Upstream commit 78f3ac76d9e5219589718b9e4733bee21627b3f5 ] > > In the past, Asus firmwares would change the panel backlight directly > through the EC when the display o

Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2019-01-09 Thread João Paulo Rechi Vita
: hci0: Found Intel DDC parameters: intel/ibt-11-5.ddc Jan 09 16:54:34 endless kernel: Bluetooth: hci0: Applying Intel DDC parameters completed Jan 09 16:54:34 endless kernel: Bluetooth: RFCOMM TTY layer initialized Jan 09 16:54:34 endless kernel: Bluetooth: RFCOMM socket layer initialized Jan 09 16:54:34 endless kernel: Bluetooth: RFCOMM ver 1.11 -- João Paulo Rechi Vita http://about.me/jprvita

Re: X450LCP lost abillity to turn the screen off

2019-02-12 Thread João Paulo Rechi Vita
On Mon, Feb 11, 2019 at 6:31 PM Marcos Paulo de Souza wrote: > > Hello João, > > On 2/11/19 5:14 PM, João Paulo Rechi Vita wrote: > > Hello Marcos, > > > > On Sun, Feb 10, 2019 at 5:05 PM Marcos Paulo de Souza > > wrote: > >> > >> > >&g

Re: [PATCH] platform/x86: asus-wireless: Fix NULL pointer dereference

2018-04-19 Thread João Paulo Rechi Vita
On Sat, Apr 7, 2018 at 8:50 AM, Darren Hart wrote: > On Fri, Apr 06, 2018 at 10:37:29PM -0700, João Paulo Rechi Vita wrote: >> When the module is removed the led workqueue is destroyed in the remove >> callback, before the led device is unregistered from the led subsystem. >&g

[PATCH v2] platform/x86: asus-wireless: Fix NULL pointer dereference

2018-04-19 Thread João Paulo Rechi Vita
ported-by: Dun Hum Cc: sta...@vger.kernel.org Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-wireless.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c index 343e12547660..b8e35a

Re: RTL8723BE performance regression

2018-05-09 Thread João Paulo Rechi Vita
On Tue, May 8, 2018 at 1:37 AM, Pkshih wrote: > On Mon, 2018-05-07 at 14:49 -0700, João Paulo Rechi Vita wrote: >> On Tue, May 1, 2018 at 10:58 PM, Pkshih wrote: >> > On Wed, 2018-05-02 at 05:44 +, Pkshih wrote: >> >> >> >> > -Original Mes

Re: RTL8723BE performance regression

2018-05-07 Thread João Paulo Rechi Vita
On Tue, May 1, 2018 at 10:58 PM, Pkshih wrote: > On Wed, 2018-05-02 at 05:44 +, Pkshih wrote: >> >> > -Original Message----- >> > From: João Paulo Rechi Vita [mailto:jprv...@gmail.com] >> > Sent: Wednesday, May 02, 2018 6:41 AM >> > To: Larr

[PATCH] i2c-hid: Disable IRQ before freeing buffers

2016-12-06 Thread João Paulo Rechi Vita
ext4_readdir+0x5e1/0x8b0 [] iterate_dir+0x92/0x120 [] SyS_getdents+0x98/0x110 [] ? iterate_dir+0x120/0x120 [] entry_SYSCALL_64_fastpath+0x16/0x71 FIX kmalloc-64: Restoring 0x880264083273-0x88026408329e=0x6b FIX kmalloc-64: Marking all objects used Signed-off-by: João Paulo Rechi Vita

Re: [PATCH 8/8] asus-wmi: Don't register rfkill if ASHS and user bit are present

2017-02-01 Thread João Paulo Rechi Vita
On 26 January 2017 at 17:45, Joe Perches wrote: > On Thu, 2017-01-26 at 10:30 -0500, João Paulo Rechi Vita wrote: >> Some Asus laptops that have an airplane-mode indicator LED, also have >> the WMI WLAN user bit set, and the following bits in their DSDT: > > style triv

Re: [PATCH 1/1] asus-wireless: Use the correct HSWC parameter for each HID

2017-02-01 Thread João Paulo Rechi Vita
On 27 January 2017 at 10:26, Andy Shevchenko wrote: > On Thu, Jan 26, 2017 at 5:00 PM, João Paulo Rechi Vita > wrote: >> Some Asus machines use 0x4/0x5 as their LED on/off values, while others use >> 0x0/0x1, as shown in the DSDT exerpts below (note "Arg0 == 0x02&quo

Re: [PATCH 0/8] asus-wmi: Get rid of quirk_no_rfkill{,_wapf4}

2017-02-01 Thread João Paulo Rechi Vita
On 27 January 2017 at 10:37, Andy Shevchenko wrote: > On Thu, Jan 26, 2017 at 5:30 PM, João Paulo Rechi Vita > wrote: >> This quirk avoids the conflicting usage of ASUS_WMI_DEVID_WLAN_LED >> (0x00010002) >> by both asus-wireless and asus-wmi on machines where the BIOS

Re: [PATCH 7/8] asus-wireless: Export ids list

2017-02-01 Thread João Paulo Rechi Vita
On 27 January 2017 at 10:36, Andy Shevchenko wrote: > On Thu, Jan 26, 2017 at 5:30 PM, João Paulo Rechi Vita > wrote: >> Signed-off-by: João Paulo Rechi Vita >> --- >> drivers/platform/x86/asus-wireless.c | 15 ++- >> drivers/platform/x86/asus-wireless

Re: [PATCH 1/1] asus-wireless: Fix identation

2017-02-01 Thread João Paulo Rechi Vita
On 27 January 2017 at 10:28, Andy Shevchenko wrote: > On Thu, Jan 26, 2017 at 4:25 PM, João Paulo Rechi Vita > wrote: >> Signed-off-by: João Paulo Rechi Vita >> --- >> drivers/platform/x86/asus-wireless.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion

[PATCH] asus-wireless: Fix identation

2017-02-01 Thread João Paulo Rechi Vita
Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-wireless.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c index 9f31bc1a47d0..a7ee18383146 100644 --- a/drivers/platform/x86/asus

[PATCH 1/1] asus-wireless: Fix identation

2017-01-26 Thread João Paulo Rechi Vita
Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-wireless.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c index 9f31bc1a47d0..c9b5ac152cf1 100644 --- a/drivers/platform/x86/asus

[PATCH 1/1] asus-wireless: Use the correct HSWC parameter for each HID

2017-01-26 Thread João Paulo Rechi Vita
| Return (Zero) | } | } | } | Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-wireless.c | 46 ++-- 1 fi

[PATCH 0/1] asus-wireless: Use the correct HSWC parameter for each HID

2017-01-26 Thread João Paulo Rechi Vita
that would avoid looping through device_ids[] in asus_wireless_add(). I'm happy to try suggestions to improve that. João Paulo Rechi Vita (1): asus-wireless: Use the correct HSWC parameter for each HID drivers/platform/x86/asus-wireless.c | 46 ++-- 1 file c

[PATCH 8/8] asus-wmi: Don't register rfkill if ASHS and user bit are present

2017-01-26 Thread João Paulo Rechi Vita
avoids adding DMI-based quirks for at least 21 different laptops. Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-wmi.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus

[PATCH 2/8] Revert "asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UF"

2017-01-26 Thread João Paulo Rechi Vita
This reverts commit a961a285b479977fa21f12f71cd62f28adaba17c. Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-nb-wmi.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index

[PATCH 1/8] Revert "asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UA"

2017-01-26 Thread João Paulo Rechi Vita
This reverts commit 56a37a72002b1eb01a1de391cf66383652784e78. Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-nb-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index

[PATCH 3/8] Revert "asus-wmi: Add quirk_no_rfkill for the Asus Z550MA"

2017-01-26 Thread João Paulo Rechi Vita
This reverts commit 6b7ff2af5286a8c6bec7ff5f4df62e3506c1674e. Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-nb-wmi.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index 5bf1dd225788

[PATCH 0/8] asus-wmi: Get rid of quirk_no_rfkill{,_wapf4}

2017-01-26 Thread João Paulo Rechi Vita
dependency between the modules. Any advice on alternatives here are welcome. PS: I don't think asus-wireless.h needs to also be listed in MAINTAINERS, please correct me if I'm wrong. João Paulo Rechi Vita (8): Revert "asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UA

[PATCH 4/8] Revert "asus-wmi: Add quirk_no_rfkill for the Asus U303LB"

2017-01-26 Thread João Paulo Rechi Vita
This reverts commit 02db9ff7af18f7ace60f430cbbaa1d846b350916. Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-nb-wmi.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index 9d686d642934

[PATCH 6/8] Revert "asus-wmi: Create quirk for airplane_mode LED"

2017-01-26 Thread João Paulo Rechi Vita
This reverts commit a977e59c0c67c9d492bb16677ce66d67cae0ebd8. Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-nb-wmi.c | 13 - drivers/platform/x86/asus-wmi.c| 8 +++- drivers/platform/x86/asus-wmi.h| 1 - 3 files changed, 3 insertions(+), 19

[PATCH 7/8] asus-wireless: Export ids list

2017-01-26 Thread João Paulo Rechi Vita
Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-wireless.c | 15 ++- drivers/platform/x86/asus-wireless.h | 10 ++ 2 files changed, 16 insertions(+), 9 deletions(-) create mode 100644 drivers/platform/x86/asus-wireless.h diff --git a/drivers/platform/x86

[PATCH 5/8] Revert "asus-wmi: Add quirk_no_rfkill for the Asus N552VW"

2017-01-26 Thread João Paulo Rechi Vita
This reverts commit 2d735244b798f0c8bf93ace1facfafdc1f7a4e6e. Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-nb-wmi.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index 5e088fbef5ad

[PATCHv2 1/2] platform/x86: asus-wmi: Detect quirk_no_rfkill from the DSDT

2017-02-20 Thread João Paulo Rechi Vita
ASUS_WMI_DSTS_USER_BIT avoids adding DMI-based quirks for at least 21 different laptops. Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-wmi.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus

[PATCHv2 2/2] platform/x86: asus-wmi: Remove quirk_no_rfkill

2017-02-20 Thread João Paulo Rechi Vita
X456UF" 6b7ff2af5286 "asus-wmi: Add quirk_no_rfkill for the Asus Z550MA" 02db9ff7af18 "asus-wmi: Add quirk_no_rfkill for the Asus U303LB" 2d735244b798 "asus-wmi: Add quirk_no_rfkill for the Asus N552VW" a977e59c0c67 "asus-wmi: Create quirk for airplane_m

[PATCHv2 0/2] platform/x86: asus-wmi: Substitute quirk_no_rfkill with a generic fix

2017-02-20 Thread João Paulo Rechi Vita
tream, and we expect this list to continue growing. This series makes use of ASUS_WMI_DSTS_USER_BIT plus the status of the ASHS device to skip asus_wmi_rfkill_init(), instead of static DMI-based quirks. João Paulo Rechi Vita (2): platform/x86: asus-wmi: Detect quirk_no_rfkill from the DSDT platfor

[PATCHv3] platform/x86: asus-wireless: Fix identation

2017-02-06 Thread João Paulo Rechi Vita
Fix identation problem introduced when this driver was first merged into the kernel. Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-wireless.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86

Re: [PATCH 7/8] asus-wireless: Export ids list

2017-02-06 Thread João Paulo Rechi Vita
On 4 February 2017 at 10:35, Andy Shevchenko wrote: > On Wed, Feb 1, 2017 at 2:23 PM, João Paulo Rechi Vita > wrote: >> On 27 January 2017 at 10:36, Andy Shevchenko >> wrote: >>> On Thu, Jan 26, 2017 at 5:30 PM, João Paulo Rechi Vita >>> wrote: > > F

Re: [PATCH 1/1] asus-wireless: Use the correct HSWC parameter for each HID

2017-02-07 Thread João Paulo Rechi Vita
On 4 February 2017 at 10:02, Andy Shevchenko wrote: > On Wed, Feb 1, 2017 at 2:20 PM, João Paulo Rechi Vita > wrote: >> On 27 January 2017 at 10:26, Andy Shevchenko >> wrote: >>> On Thu, Jan 26, 2017 at 5:00 PM, João Paulo Rechi Vita >>> wrote: > &

[PATCHv2] platform/x86: asus-wireless: Use per-HID HSWC parameters

2017-02-07 Thread João Paulo Rechi Vita
| Return (Zero) | } | } | } | Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-wireless.c | 57 ++-- 1 file changed, 42 insertions(+), 15 deletions(-) diff --git a/driv

Re: [PATCH 1/1] asus-wireless: Use the correct HSWC parameter for each HID

2017-02-08 Thread João Paulo Rechi Vita
On 7 February 2017 at 18:37, Andy Shevchenko wrote: > On Tue, Feb 7, 2017 at 11:44 PM, João Paulo Rechi Vita > wrote: >> On 4 February 2017 at 10:02, Andy Shevchenko >> wrote: >>> On Wed, Feb 1, 2017 at 2:20 PM, João Paulo Rechi Vita >>> wrote: &g

[PATCH] acpica: Fix double-free in acpi_ns_repair_CID()

2017-02-03 Thread João Paulo Rechi Vita
free. This problem was seen on a Acer TravelMate P449-G2-MG. Thanks to Daniel Drake for helping investigating this problem. Signed-off-by: João Paulo Rechi Vita --- drivers/acpi/acpica/nsrepair2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/acpi/acpica/nsrepair2.c b/drivers/acpi

Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger

2016-06-13 Thread João Paulo Rechi Vita
his is now contained in the platform-drivers-x86 subsystem. Thanks Johannes for your patience and help designing and reviewing the rfkill changes, even if not all of them made it through in the end. And thanks everyone else involved for the feedback. Best regards, -- João Paulo Rechi Vita http://about.me/jprvita

Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger

2016-06-13 Thread João Paulo Rechi Vita
s/class/rfkill > /sys/module/rfkill > If we use "rfkill" as a suffix, how do you expect userspace to be able to differentiate between a LED that indicates airplane-mode (LED ON when all radios are OFF) and a LED that indicates the state of a specific radio like WiFi or Bluetooth (LED ON when that specific radio is ON)? If we're going this route we should provide meaningful information here. -- João Paulo Rechi Vita http://about.me/jprvita

[PATCH 4/7] asus-wmi: Add quirk_no_rfkill for the Asus U303LB

2016-06-13 Thread João Paulo Rechi Vita
registering RFKill switches at all for this laptop and allows asus-wireless to drive the LED through the ASHS ACPI device. Signed-off-by: João Paulo Rechi Vita Reported-by: Mousou Yuu --- drivers/platform/x86/asus-nb-wmi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform

[PATCH 2/7] asus-wmi: Create quirk for airplane_mode LED

2016-06-13 Thread João Paulo Rechi Vita
: João Paulo Rechi Vita --- drivers/platform/x86/asus-nb-wmi.c | 13 + drivers/platform/x86/asus-wmi.c| 8 +--- drivers/platform/x86/asus-wmi.h| 1 + 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86

[PATCH 7/7] asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UA

2016-06-13 Thread João Paulo Rechi Vita
registering RFKill switches at all for this laptop and allows asus-wireless to drive the LED through the ASHS ACPI device. This laptop already has a quirk for setting WAPF=4, so this commit creates a new quirk, quirk_no_rfkill_wapf4, which both disables rfkill and sets WAPF=4. Signed-off-by: João Paulo

  1   2   >