Re: [PATCH 1/2] PCI: ASPM exit link state code could skip devices

2013-02-01 Thread Joe Lawrence
On Thu, 31 Jan 2013, Myron Stowe wrote: On Fri, 2013-01-18 at 13:23 -0500, Joe Lawrence wrote: From 3a51bbadba6c6e144aa5176c8112eb449325 Mon Sep 17 00:00:00 2001 From: Joe Lawrence joe.lawre...@stratus.com Date: Tue, 15 Jan 2013 14:51:57 -0500 Subject: [PATCH 1/2] PCI: ASPM exit link

Re: mpt2sas driver barfs when force removing a drive on 3.13.1

2014-02-12 Thread Joe Lawrence
3.14.0-rc2+ kernel whenever we unload the mpt2sas/mpt3sas driver or whenever we unplug the drive attached to the HBA. But after applying yours patch, these WARNING call trace is not observed. Regards, Sreekanth -Original Message- From: Joe Lawrence [mailto:joe.lawre...@stratus.com

Re: Please add to stable: module: don't unlink the module until we've removed all exposure.

2013-06-04 Thread Joe Lawrence
On Tue, 04 Jun 2013 15:26:28 +0930 Rusty Russell ru...@rustcorp.com.au wrote: Do you have a backtrace of the 3.9.4 crash? You can add CFLAGS_module.o = -O0 to get a clearer backtrace if you want... Hi Rusty, See my 3.9 stack traces below, which may or may not be what Ben had been seeing. If

Re: Please add to stable: module: don't unlink the module until we've removed all exposure.

2013-06-04 Thread Joe Lawrence
On Tue, 4 Jun 2013, Joe Lawrence wrote: Hi Rusty, See my 3.9 stack traces below, which may or may not be what Ben had been seeing. If you like, I can try a similar loop as the one you were testing in the other email. With a modified version of your module load/unload loop (only needed

Re: Please add to stable: module: don't unlink the module until we've removed all exposure.

2013-06-02 Thread Joe Lawrence
On Sun, 2 Jun 2013, Rusty Russell wrote: Ben Greear gree...@candelatech.com writes: It turns out, the bug I spent yesterday chasing in various 3.9 kernels is apparently fixed by the commit in the title (c9c390bb5535380d40614571894ef0c00bc026ff). Apparently being the operative word.

Re: Please add to stable: module: don't unlink the module until we've removed all exposure.

2013-06-03 Thread Joe Lawrence
[fixing Cc: sta...@kernel.org address] On Sun, 2 Jun 2013, Joe Lawrence wrote: On Sun, 2 Jun 2013, Rusty Russell wrote: Ben Greear gree...@candelatech.com writes: It turns out, the bug I spent yesterday chasing in various 3.9 kernels is apparently fixed by the commit

Re: Please add to stable: module: don't unlink the module until we've removed all exposure.

2013-06-03 Thread Joe Lawrence
[Cc: sta...@vger.kernel.org] Third time is a charm? The stable address was incorrect from the first msg in this thread, but the relevant bits remain quoted below... On Mon, 3 Jun 2013, Joe Lawrence wrote: [fixing Cc: sta...@kernel.org address] On Sun, 2 Jun 2013, Joe Lawrence wrote

docker crashes rcuos in __blkg_release_rcu

2014-06-08 Thread Joe Lawrence
Hi Tejun, Vivek, I came across this crash when attempting to run the 'hello world' example from the Getting Started section on the docker.io homepage. Repro kernels: (upstream linus) 3.15.0 (RHEL7 RC-2) 3.10.0-121.el7.x86_64 To reproduce, boot with slub_debug=FZPU and run the example. %

Re: docker crashes rcuos in __blkg_release_rcu

2014-06-10 Thread Joe Lawrence
On Mon, 9 Jun 2014 14:27:29 -0400 Vivek Goyal vgo...@redhat.com wrote: ... snip ... So the question is why request queue is being freed early. Are there any reference counting issues. Hi Vivek, Thanks for taking a look. For extra debugging, I wrote a quick set of kprobes that: 1 - On

[PATCH 0/2] block,scsi: fixup blk_get_request dead queue scenarios

2014-05-29 Thread Joe Lawrence
/1502882 Joe Lawrence (2): block,scsi: verify return pointer from blk_get_request block,scsi: convert and handle ERR_PTR from blk_get_request block/blk-core.c| 34 ++--- block/bsg.c | 8 +++ block

[PATCH 1/2] block,scsi: verify return pointer from blk_get_request

2014-05-29 Thread Joe Lawrence
The blk-core dead queue checks introduce an error scenario to blk_get_request that returns NULL if the request queue has been shutdown. This affects the behavior for __GFP_WAIT callers, who should verify the return value before dereferencing. Signed-off-by: Joe Lawrence joe.lawre...@stratus.com

[PATCH 2/2] block,scsi: convert and handle ERR_PTR from blk_get_request

2014-05-29 Thread Joe Lawrence
instead of a simple NULL pointer check. Signed-off-by: Joe Lawrence joe.lawre...@stratus.com Acked-by: Jiri Kosina jkos...@suse.cz [for pktdvd] Acked-by: Boaz Harrosh bharr...@panasas.com [for osd] --- block/blk-core.c| 34 ++--- block/bsg.c

Re: [PATCH 2/2] block,scsi: convert and handle ERR_PTR from blk_get_request

2014-06-17 Thread Joe Lawrence
On Tue, 17 Jun 2014 03:33:23 -0700 Christoph Hellwig h...@infradead.org wrote: On Wed, Jun 04, 2014 at 02:07:02PM -0400, Jeff Moyer wrote: Wow, that's a lot more churn than I expected. ;-) I think you should go ahead and repost this patch with the change mentioned above (you can add my

Re: [PATCH 2/2] block,scsi: convert and handle ERR_PTR from blk_get_request

2014-06-03 Thread Joe Lawrence
On Tue, 3 Jun 2014 15:45:36 -0400 Jeff Moyer jmo...@redhat.com wrote: Joe Lawrence joe.lawre...@stratus.com writes: The blk_get_request function may fail in low-memory conditions or during device removal (even if __GFP_WAIT is set). To distinguish between these errors, modify

Re: [PATCH 2/2] block,scsi: convert and handle ERR_PTR from blk_get_request

2014-06-03 Thread Joe Lawrence
On Tue, 3 Jun 2014 16:07:01 -0400 Jeff Moyer jmo...@redhat.com wrote: Joe Lawrence joe.lawre...@stratus.com writes: diff --git a/block/bsg.c b/block/bsg.c index 420a5a9..2b1c322 100644 --- a/block/bsg.c +++ b/block/bsg.c @@ -271,8 +271,8 @@ bsg_map_hdr(struct bsg_device *bd, struct

[PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios

2014-06-04 Thread Joe Lawrence
v1-v2: incorporate Jeff's feedback in bsg_map_hdr() and Reviewed-by tags. Joe Lawrence (2): block,scsi: verify return pointer from blk_get_request block,scsi: convert and handle ERR_PTR from blk_get_request block/blk-core.c| 34

[PATCH v2 1/2] block,scsi: verify return pointer from blk_get_request

2014-06-04 Thread Joe Lawrence
The blk-core dead queue checks introduce an error scenario to blk_get_request that returns NULL if the request queue has been shutdown. This affects the behavior for __GFP_WAIT callers, who should verify the return value before dereferencing. Signed-off-by: Joe Lawrence joe.lawre...@stratus.com

[PATCH v2 2/2] block,scsi: convert and handle ERR_PTR from blk_get_request

2014-06-04 Thread Joe Lawrence
instead of a simple NULL pointer check. Signed-off-by: Joe Lawrence joe.lawre...@stratus.com Acked-by: Jiri Kosina jkos...@suse.cz [for pktdvd] Acked-by: Boaz Harrosh bharr...@panasas.com [for osd] Reviewed-by: Jeff Moyer jmo...@redhat.com --- block/blk-core.c| 34

Re: mpt2sas driver barfs when force removing a drive on 3.13.1

2014-02-03 Thread Joe Lawrence
a lot like what I see on mpt2sas driver removal [1]. I posted a suggested fix back in Dec [2], which you might try, however it is not reviewed at this point. [1] http://thread.gmane.org/gmane.linux.scsi/86237 [2] https://github.com/joe-lawrence/linux/compare

Re: 3.15-mw: Oops Workqueue: writeback bdi_writeback_workfn (flush-8:16) RIP: e030:[ffffffff814c6bc1] [ffffffff814c6bc1] kobject_put+0x11/0x70

2014-04-14 Thread Joe Lawrence
On Mon, 14 Apr 2014 04:30:15 -0700 Christoph Hellwig h...@infradead.org wrote: On Sat, Apr 12, 2014 at 01:34:31PM +0200, Sander Eikelenboom wrote: Hi, I just ran into the oops belowafter some uptime. Classic use after free introduced by my recent changes, sorry. This should fix it:

Re: [PATCH block/for-linus] blkcg: fix use-after-free in __blkg_release_rcu() by making blkcg_gq refcnt an atomic_t

2014-06-20 Thread Joe Lawrence
(most likely negligible) overhead it may add is temporary. Signed-off-by: Tejun Heo t...@kernel.org Reported-by: Joe Lawrence joe.lawre...@stratus.com Cc: Vivek Goyal vgo...@redhat.com Link: http://lkml.kernel.org/g/alpine.deb.2.02.1406081816540.17...@jlaw-desktop.mno.stratus.com Cc: sta

Re: [PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios

2014-06-26 Thread Joe Lawrence
On Thu, 26 Jun 2014, Jeff Moyer wrote: Jens Axboe ax...@kernel.dk writes: On 2014-06-26 10:08, Jeff Moyer wrote: Joe Lawrence joe.lawre...@stratus.com writes: v1-v2: incorporate Jeff's feedback in bsg_map_hdr() and Reviewed-by tags. Joe Lawrence (2): block,scsi

Re: mpt2sas stuck installing

2014-07-07 Thread Joe Lawrence
On Fri, 4 Jul 2014, Joe Julian wrote: On 07/03/2014 10:32 PM, Joe Lawrence wrote: On Thu, Jul 3 2014 Joe Julian wrote: I have a knox enclosure with an unresponsive drive. When the mpt2sas module is loaded the module loading process hangs. modprobe/insmod is stuck and any further

Re: mpt2sas stuck installing

2014-07-14 Thread Joe Lawrence
On Sat, 12 Jul 2014 03:13:07 + Elliott, Robert (Server Storage) elli...@hp.com wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Joe Lawrence ... In your crash stack trace, the scsi error handler has

[PATCH v3 0/2] block,scsi: fixup blk_get_request dead queue scenarios

2014-07-02 Thread Joe Lawrence
ERR_PTR. __blk_mq_alloc_request doesn't include any blk_queue_dying checks, so I'm assuming that its failures can be attributed to -EWOULDBLOCK under !GFP_WAIT conditions. v1-v2: incorporate Jeff's feedback in bsg_map_hdr() and Reviewed-by tags. Joe Lawrence (2

[PATCH v3 1/2] block,scsi: verify return pointer from blk_get_request

2014-07-02 Thread Joe Lawrence
The blk-core dead queue checks introduce an error scenario to blk_get_request that returns NULL if the request queue has been shutdown. This affects the behavior for __GFP_WAIT callers, who should verify the return value before dereferencing. Signed-off-by: Joe Lawrence joe.lawre...@stratus.com

[PATCH v3 2/2] block,scsi: fixup blk_get_request dead queue scenarios

2014-07-02 Thread Joe Lawrence
instead of a simple NULL pointer check. For consistency, make a similar change to the blk_mq_alloc_request leg of blk_get_request. It may fail if the queue is dead, or the caller was unwilling to wait. Signed-off-by: Joe Lawrence joe.lawre...@stratus.com Acked-by: Jiri Kosina jkos...@suse.cz

Re: [PATCH v3 0/2] block,scsi: fixup blk_get_request dead queue scenarios

2014-07-02 Thread Joe Lawrence
FWIW, I spent some time looking at blk_get_request callers and as far as I can tell, most should be able to gracefully handle additional errno values of -ENODEV and -EWOULDBLOCK. I didn't chase down the pktcdvd or osd paths, however Jiri and Boaz ack'd the earlier patch version that added

Re: [PATCH] drivers: message: fusion: Simplify rounding

2014-07-03 Thread Joe Lawrence
ALIGN is certainly more readable to me. Reviewed-by: Joe Lawrence joe.lawre...@stratus.com -- Joe On Tue, 1 Jul 2014, Rasmus Villemoes wrote: Rounding up to a multiple of 4 should be done using the ALIGN macro. As a bonus, this also makes the generated code smaller. In GetIocFacts(), sz

Re: [PATCH] scsi: mpt2sas: mpt2sas_base.c: Fix for possible null pointer dereference

2014-07-03 Thread Joe Lawrence
On Wed, 28 May 2014, Christoph Hellwig wrote: - ioc_status = le16_to_cpu(mpi_reply-IOCStatus) MPI2_IOCSTATUS_MASK; + if (mpi_reply) { + ioc_status = le16_to_cpu(mpi_reply-IOCStatus) MPI2_IOCSTATUS_MASK; + } if (ioc_status != MPI2_IOCSTATUS_SUCCESS)

RE: mpt2sas stuck installing

2014-07-03 Thread Joe Lawrence
On Thu, Jul 3 2014 Joe Julian wrote: I have a knox enclosure with an unresponsive drive. When the mpt2sas module is loaded the module loading process hangs. modprobe/insmod is stuck and any further attempts to load modules also hang. By blacklisting the module and loading it last, I can

Re: [PATCH] lpfc: Avoid to disable pci_dev twice

2014-07-17 Thread Joe Lawrence
[ +cc linux-pci and Bjorn, comments inline/below ... ] On Thu, 17 Jul 2014 02:32:31 -0400 Mike Qiu qiud...@linux.vnet.ibm.com wrote: In IBM Power servers, when hardware error occurs during probe state, EEH subsystem will call driver's error_detected interface, which will call

Re: [PATCH v3 0/2] block,scsi: fixup blk_get_request dead queue scenarios

2014-08-27 Thread Joe Lawrence
On Tue, 26 Aug 2014 18:01:23 -0400 Jeff Moyer jmo...@redhat.com wrote: Jens Axboe ax...@kernel.dk writes: I have applied the first one, will look over the second one and hand apply it. Seems the NULL return was completely removed, so we _should_ be ok on the IS_ERR() conversion, though

Re: [PATCH v3 0/2] block,scsi: fixup blk_get_request dead queue scenarios

2014-08-27 Thread Joe Lawrence
On Wed, 27 Aug 2014 08:07:29 -0600 Jens Axboe ax...@kernel.dk wrote: On 08/26/2014 04:01 PM, Jeff Moyer wrote: Additionally, there's still quite a few places that call blk_get_request() and don't check the error return if __GFP_WAIT is set. Since most of the point of this is to fix

Re: [PATCH] checkpatch: Add test for commit id formatting style in commit log

2014-08-27 Thread Joe Lawrence
Try to standardize on a 12 character long lower case commit id along with a description of parentheses and the quoted subject line ie: commit 0123456789ab (commit description) Hi Joe / Andrew, I don't know if checkpatch is built for multiline regex, but I noticed that this new check

Re: [PATCH] checkpatch: Allow commit descriptions on separate line from commit id

2014-08-27 Thread Joe Lawrence
commit 12+hexdigits (commit description/subject line) is improved. Allow this form. Signed-off-by: Joe Perches j...@perches.com Suggested-by: Joe Lawrence joe.lawre...@stratus.com Hi Joe, The script changes work for me, one really minor nit though, this email address is missing a closing

Re: [PATCH v2 1/2] workqueue: add quiescent state between work items

2014-10-07 Thread Joe Lawrence
On Tue, 7 Oct 2014 06:43:29 -0700 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: On Tue, Oct 07, 2014 at 09:29:42AM +0200, Jiri Pirko wrote: [ ... snip ... ] Paul, Tehun, how do you propose to fix this on older kernels which do not have rcu_note_voluntary_context_switch? I'm

[PATCH] workqueue: add quiescent state between work items

2014-10-04 Thread Joe Lawrence
there are other higher priority tasks to run, so force a quiescent RCU state between work items with cond_resched_rcu_qs. Signed-off-by: Joe Lawrence joe.lawre...@stratus.com Link: https://lkml.kernel.org/r/20140926105227.01325...@jlaw-desktop.mno.stratus.com Link: https://lkml.kernel.org/r

[PATCH v2 1/2] workqueue: add quiescent state between work items

2014-10-05 Thread Joe Lawrence
there are other higher priority tasks to run, so force a quiescent RCU state between work items. Signed-off-by: Joe Lawrence joe.lawre...@stratus.com Link: https://lkml.kernel.org/r/20140926105227.01325...@jlaw-desktop.mno.stratus.com Link: https://lkml.kernel.org/r/20140929115445.40221...@jlaw

[PATCH v2 0/2] workqueue: add RCU quiescent state between items

2014-10-05 Thread Joe Lawrence
v2 - split into two patches: the first inlines the cond_resched_rcu_qs macro suitable for stable backport, the second converts to using cond_resched_rcu_qs. Joe Lawrence (2): workqueue: add quiescent state between work items workqueue: use cond_resched_rcu_qs macro kernel/workqueue.c |5

[PATCH v2 2/2] workqueue: use cond_resched_rcu_qs macro

2014-10-05 Thread Joe Lawrence
Tidy up and use cond_resched_rcu_qs when calling cond_resched and reporting potential quiescent state to RCU. Signed-off-by: Joe Lawrence joe.lawre...@stratus.com --- kernel/workqueue.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/workqueue.c b/kernel

schedule_delayed_work with a 0 jiffy delay

2014-09-26 Thread Joe Lawrence
Hello Tejun, (RHEL7 kernel, see config below) I'm debugging an RCU stall where it seems that the culprit is a kworker workqueue function that decides to reschedule itself over and over via schedule_delayed_work with a 0 jiffy delay. If I watch rcudata, I can see that the CPU currently running

Re: schedule_delayed_work with a 0 jiffy delay

2014-09-28 Thread Joe Lawrence
On Sun, 28 Sep 2014, Tejun Heo wrote: Hello, Joe. On Fri, Sep 26, 2014 at 10:52:27AM -0400, Joe Lawrence wrote: ... I was wondering if such behavior was expected on !PREEMPT kernels, especially after b22ce2785d97 workqueue: cond_resched() after processing each work item

Re: [SCSI RFC] mpt2sas: wait_for_completion_timeout timeout not reported

2014-12-30 Thread Joe Lawrence
On 12/29/2014 12:25 PM, Nicholas Mc Guire wrote: wait_for_completion_timeout reaching timeout was being ignored, this probably also should fail if timeout condition occurs ? this was only compile tested with x86_64_defconfig + CONFIG_SCSI_LOWLEVEL=y + CONFIG_SCSI_MPT2SAS=m patch is

Re: [SCIS] mpt3sas: wait_for_completion_timeout timeout not reported

2014-12-30 Thread Joe Lawrence
On 12/30/2014 11:19 AM, Nicholas Mc Guire wrote: wait_for_completion_timeout reaching timeout was being ignored, this also should fail if timeout condition occurs. Thanks to Joe Lawrence joe.lawre...@stratus.com for confirmation. How about this instead: Acked-by: Joe Lawrence joe.lawre

Re: [PATCH 17/20 v1] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API

2015-06-18 Thread Joe Lawrence
On 06/16/2015 01:37 AM, Sreekanth Reddy wrote: Created a thread using alloc_ordered_workqueue() API in order to process the works from firmware Work-queue sequentially instead of create_singlethread_workqueue() API. Changes in v1: No need to check for backport compatibility in the

Re: [PATCH] [RESEND] qla2xxx: prevent board_disable from running during EEH

2015-06-26 Thread Joe Lawrence
On 06/26/2015 12:33 PM, Mauricio Faria de Oliveira wrote: Commit f3ddac1918fe963bcbf8d407a3a3c0881b47248b ([SCSI] qla2xxx: Disable adapter when we encounter a PCI disconnect.) has introduced a code that disables the board, releasing some resources, when reading 0x. In case this

Re: [PATCH 17/20 v1] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API

2015-06-18 Thread Joe Lawrence
On 06/18/2015 09:06 AM, Sreekanth Reddy wrote: On Thu, Jun 18, 2015 at 5:40 PM, Joe Lawrence joe.lawre...@stratus.com wrote: On 06/16/2015 01:37 AM, Sreekanth Reddy wrote: Created a thread using alloc_ordered_workqueue() API in order to process the works from firmware Work-queue sequentially

Re: [PATCH 17/20] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API

2015-06-12 Thread Joe Lawrence
On 06/12/2015 05:42 AM, Sreekanth Reddy wrote: ... +#if defined(alloc_ordered_workqueue) + ioc-firmware_event_thread = alloc_ordered_workqueue( + ioc-firmware_event_name, WQ_MEM_RECLAIM); +#else + ioc-firmware_event_thread = create_singlethread_workqueue(

Re: [PATCH 1/2] mpt2sas: Refcount sas_device objects and fix unsafe list usage

2015-07-13 Thread Joe Lawrence
On 07/12/2015 12:24 AM, Calvin Owens wrote: These objects can be referenced concurrently throughout the driver, we need a way to make sure threads can't delete them out from under each other. This patch adds the refcount, and refactors the code to use it. Additionally, we cannot iterate over

Re: [Bugfix 4/5] x86/irq: Fix a race condition between vector assigning and cleanup

2015-12-01 Thread Joe Lawrence
On 11/30/2015 03:09 AM, Jiang Liu wrote: > Joe Lawrence <joe.lawre...@stratus.com> reported an use after release > issue related to x86 IRQ management code. Please refer to following > link for more information: > https://www.mail-archive.com/linux-kernel@vger.kernel.o

Re: [Bugfix 4/5] x86/irq: Fix a race condition between vector assigning and cleanup

2015-12-07 Thread Joe Lawrence
On 12/01/2015 05:46 PM, Joe Lawrence wrote: On 11/30/2015 03:09 AM, Jiang Liu wrote: Joe Lawrence <joe.lawre...@stratus.com> reported an use after release issue related to x86 IRQ management code. Please refer to following link for more information: https://www.mail-archive.com/linux-

Re: [patch 00/14] x86/irq: Plug various vector cleanup races

2016-01-04 Thread Joe Lawrence
es running the same PCI device removal and stress tests against the patchset. Thanks, Tested-by: Joe Lawrence <joe.lawre...@stratus.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More major

Re: [Bugfix v2 1/5] x86/irq: Do not reuse struct apic_chip_data.old_domain as temporary buffer

2015-12-24 Thread Joe Lawrence
ang@linux.intel.com> Hi Jiang, FWIW, my overnight testing is still running okay, so for v2: Tested-by: Joe Lawrence <joe.lawre...@stratus.com> However, it looks like there will probably be a v3. -- Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: irq_desc use-after-free in smp_irq_move_cleanup_interrupt

2015-11-25 Thread Joe Lawrence
On 11/25/2015 04:12 PM, Thomas Gleixner wrote: On Wed, 25 Nov 2015, Thomas Gleixner wrote: So if CPU1 gets the IPI _BEFORE_ move_in_progress is set to 0, and does not get another IPI before the next move . That has been that way forever. Duh. Working on a real fix this time. Here you go.

irq_desc use-after-free in smp_irq_move_cleanup_interrupt

2015-11-23 Thread Joe Lawrence
Hi Thomas, I've been chasing down a use-after-free on an irq_desc structure during repeated device removal testing that crashes 4.3 in smp_irq_move_cleanup_interrupt. So far I have a bunch of crashes and some data gleaned from instrumenting the kernel with trace logging. Details to follow, but

__rtc_read_alarm missing month/year field bug?

2016-06-20 Thread Joe Lawrence
_enable : no periodic_freq : 1024 batt_status : okay -- >8 -- >From d6feacf20b312c8ebfee902b8b84f68c1a82f035 Mon Sep 17 00:00:00 2001 From: Joe Lawrence <joe.lawre...@stratus.com> Date: Thu, 9 Jun 2016 14:52:28 -0400 Subject: [PATCH] rtc: check filled-in alarm values befor

Re: __rtc_read_alarm missing month/year field bug?

2016-06-27 Thread Joe Lawrence
On 06/20/2016 12:06 PM, Joe Lawrence wrote: > Hello Alessandro and Alexandre, > > I noticed an interesting cmos_rtc.rtc.aie_timer on a Stratus machine > running the 4.6 kernel, with an expiration time that puts the alarm way > out into next year. This is easily reproducible

PM domain change on unbound devices warning on ipmi_si unload

2016-01-27 Thread Joe Lawrence
Starting in 4.5-rc1, I noticed this warning on ipmi_si driver removal: % modprobe ipmi_si % rmmod ipmi_si bus: 'platform': driver_probe_device: matched device IPI0001:00 with driver ipmi_si bus: 'platform': really_probe: probing driver ipmi_si with device IPI0001:00 ipmi_si IPI0001:00: ipmi_si:

Re: PM domain change on unbound devices warning on ipmi_si unload

2016-01-29 Thread Joe Lawrence
On 01/29/2016 12:01 PM, Steven Rostedt wrote: > On Thu, Jan 28, 2016 at 02:13:04PM -0600, Corey Minyard wrote: >> Tomeu, you added that check in >> >> [989561de9b5112999475b406557d9c7e9e59c041] PM / Domains: add setter for >> dev.pm_domain >> >> and either something is wrong in the platform device

Re: PM domain change on unbound devices warning on ipmi_si unload

2016-02-02 Thread Joe Lawrence
On 02/02/2016 07:56 PM, Rafael J. Wysocki wrote: Does this help: https://patchwork.kernel.org/patch/8170821/ ? No more warnings on ipmi_si removal over here with that patch. Thanks, -- Joe

Re: [patch 00/14] x86/irq: Plug various vector cleanup races

2016-01-22 Thread Joe Lawrence
On 01/20/2016 03:26 AM, Borislav Petkov wrote: > ... tglx says you could also try enabling > CONFIG_DEBUG_OBJECTS and CONFIG_DEBUG_OBJECTS_TIMERS and collect full > dmesg from when the corruption happens. That might give us some more > insights as to what happens. Hi Boris, Excellent idea. With

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-19 Thread Joe Lawrence
On 03/14/2016 08:37 PM, Toshi Kani wrote: [... snip ...] >> Joe at Stratus also hit this issue but on a system where MTRR is enabled. >> He sent his report only to me as he thought it was caused by the >> ioremap_wc() changes and his driver was one that got it. In his case >> though he modified

Re: __rtc_read_alarm missing month/year field bug?

2016-07-21 Thread Joe Lawrence
On 07/19/2016, Alexandre Belloni wrote: > > Well like said in my previous mail, I don't think the rollover is the > issue here but I'm interested in knowing what conditions are leading > to endless interrupts. Hi Alexandre, Unfortunately I've switched employers so I no longer have access to the

[ppdev] sysfs warning on qemu boot

2016-11-09 Thread Joe Lawrence
Hi Sudip, I hit a sysfs_warn_dup inside QEMU running 4.9.0-rc4 (I suspect earlier versions as well, but this is the first upstream I've run in a while). This warning looks like something the kernel test robot ran into a few months ago: http://marc.info/?t=14726777333=1=2 I'm running

Re: [ppdev] sysfs warning on qemu boot

2016-11-09 Thread Joe Lawrence
On 11/09/2016 12:04 PM, Sudip Mukherjee wrote: > Hi Joe, > > On 09/11/16 16:00, Joe Lawrence wrote: >> Hi Sudip, >> >> I hit a sysfs_warn_dup inside QEMU running 4.9.0-rc4 (I suspect earlier >> versions as well, but this is the first upstream I've run in a w

Re: [ppdev] sysfs warning on qemu boot

2016-11-11 Thread Joe Lawrence
On 11/11/2016 04:14 PM, Sudip Mukherjee wrote: > Hi Joe, > > On Wednesday 09 November 2016 06:41 PM, Joe Lawrence wrote: >> On 11/09/2016 12:04 PM, Sudip Mukherjee wrote: >>> Hi Joe, >>> >>> On 09/11/16 16:00, Joe Lawrence wrote: >>>> Hi Sudip

[PATCH] livepatch/module: print notice of TAINT_LIVEPATCH

2017-01-12 Thread Joe Lawrence
Add back the "tainting kernel with TAINT_LIVEPATCH" kernel log message that commit 2992ef29ae01 ("livepatch/module: make TAINT_LIVEPATCH module-specific") dropped. Now that it's a module-specific taint flag, include the module name. Signed-off-by: Joe Lawrence <

Re: [PATCH v4] livepatch: introduce shadow variable API

2017-08-16 Thread Joe Lawrence
On 08/16/2017 08:43 AM, Miroslav Benes wrote: > >> [ ... snip ... ] > > There is a comment above about locking and we do not take the spinlock > here. That could surprise someone. So I'd keep only klp_shadow_add() > comment, because there it is strictly needed. It depends on the context in >

[PATCH v4] livepatch: introduce shadow variable API

2017-08-14 Thread Joe Lawrence
or example modules that demonstrate shadow variables. Signed-off-by: Joe Lawrence <joe.lawre...@redhat.com> --- Documentation/livepatch/shadow-vars.txt | 215 + include/linux/livepatch.h | 10 + kernel/livepatch/Makefile | 2 +- kernel/li

[PATCH v4] livepatch: shadow variables

2017-08-14 Thread Joe Lawrence
(), klp_shadow_set(), klp_shadow_add() - add "caller should hold lock" comments - Documentation - remove unnecessary klp_shadow_get() call in use-case - s/its shadow variable lifetimes/their shadow variables lifetimes/ Joe Lawrence (1): livepatch: introduce shadow variable API Doc

Re: [PATCH v3] livepatch: introduce shadow variable API

2017-08-10 Thread Joe Lawrence
On Thu, Aug 10, 2017 at 04:40:05PM +0200, Miroslav Benes wrote: > > It generally looks ok. Only few questions below... > > [...] > > > +In-flight parent objects > > + > > + ps_lock = klp_shadow_get_or_attach(sta, PS_LOCK, > > + _lock_fallback,

Re: [PATCH v3] livepatch: introduce shadow variable API

2017-08-14 Thread Joe Lawrence
On 08/11/2017 12:35 PM, Josh Poimboeuf wrote: > On Fri, Jul 28, 2017 at 01:25:22PM -0400, Joe Lawrence wrote: >> Add exported API for livepatch modules: >> >> klp_shadow_get() >> klp_shadow_attach() >> klp_shadow_get_or_attach() >> klp_shadow_up

Re: [PATCH v2 1/1] livepatch: add (un)patch callbacks

2017-08-14 Thread Joe Lawrence
On 08/11/2017 04:44 PM, Josh Poimboeuf wrote: > On Tue, Aug 08, 2017 at 03:36:07PM -0400, Joe Lawrence wrote: >> +++ b/Documentation/livepatch/callbacks.txt >> @@ -0,0 +1,75 @@ >> +(Un)patching Callbacks >> +== >> + >> +Livepatch

Re: [PATCH v2 1/2] livepatch: introduce shadow variable API

2017-07-07 Thread Joe Lawrence
On Fri, Jun 30, 2017 at 09:49:46PM +0800, kbuild test robot wrote: > Date: Fri, 30 Jun 2017 21:49:46 +0800 > From: kbuild test robot <l...@intel.com> > To: Joe Lawrence <joe.lawre...@redhat.com> > Cc: kbuild-...@01.org, live-patch...@vger.kernel.org, > linux-kernel@vger

Re: [PATCH] livepatch: add (un)patch hooks

2017-07-14 Thread Joe Lawrence
On Thu, Jul 13, 2017 at 08:46:40PM -0500, Josh Poimboeuf wrote: > Date: Thu, 13 Jul 2017 20:46:40 -0500 > From: Josh Poimboeuf <jpoim...@redhat.com> > To: Joe Lawrence <joe.lawre...@redhat.com> > Cc: live-patch...@vger.kernel.org, linux-kernel@vger.kernel.org, Jessica Yu &g

[PATCH] livepatch hooks, revisted

2017-07-12 Thread Joe Lawrence
ing, going). A new Documentation/ file is provided as well as a contrived sample module and livepatch demo to demonstrate the callbacks. The example is about as simple as possible, but could be further embellished to resemble a real-world livepatch fix if desired. Thanks, Joe Lawrence (1): livepatc

[PATCH] livepatch: add (un)patch hooks

2017-07-12 Thread Joe Lawrence
target and the livepatch module needs to execute code after the target is loaded, but before its module_init code is run. The patch-hook executes right before patching objects and the unpatch-hook executes right after unpatching objects. Signed-off-by: Joe Lawrence <joe.lawre...@redhat.

Re: [PATCH v2 1/2] livepatch: introduce shadow variable API

2017-07-18 Thread Joe Lawrence
On Mon, Jul 17, 2017 at 05:29:41PM +0200, Miroslav Benes wrote: > > On Wed, 28 Jun 2017, Joe Lawrence wrote: > > > +Brief API summary > > +- > > + [ ... snip ...] > > +* klp_shadow_detach() - detach and free all <*, num> shadow variabl

Re: [PATCH v2 2/2] livepatch: add shadow variable sample programs

2017-07-18 Thread Joe Lawrence
On Tue, Jul 18, 2017 at 04:47:45PM +0200, Petr Mladek wrote: > Date: Tue, 18 Jul 2017 16:47:45 +0200 > From: Petr Mladek <pmla...@suse.com> > To: Joe Lawrence <joe.lawre...@redhat.com> > Cc: live-patch...@vger.kernel.org, linux-kernel@vger.kernel.org, Josh > Poi

Re: [PATCH v2 1/2] livepatch: introduce shadow variable API

2017-07-18 Thread Joe Lawrence
On Tue, Jul 18, 2017 at 03:00:47PM +0200, Petr Mladek wrote: > Date: Tue, 18 Jul 2017 15:00:47 +0200 > From: Petr Mladek <pmla...@suse.com> > To: Miroslav Benes <mbe...@suse.cz> > Cc: Josh Poimboeuf <jpoim...@redhat.com>, Joe Lawrence > <joe.lawre...@redhat

Re: [PATCH v2 1/2] livepatch: introduce shadow variable API

2017-07-20 Thread Joe Lawrence
On 07/20/2017 10:45 AM, Miroslav Benes wrote: > > + * > + * Note: allocates @new_size space for shadow variable data and copies > + * @new_size bytes from @new_data into the shadow varaible's own > @new_data > + * space. If @new_data is NULL, @new_size is still allocated,

Re: [PATCH v2 1/2] livepatch: introduce shadow variable API

2017-07-21 Thread Joe Lawrence
On 07/21/2017 05:13 AM, Petr Mladek wrote: > On Thu 2017-07-20 16:30:37, Joe Lawrence wrote: >> Going back to existing kpatch use-cases, since we paired shadow variable >> creation to their parent object creation, -EEXIST was never an issue. I >> think we concocted one pr

Re: [PATCH] livepatch: add (un)patch hooks

2017-07-27 Thread Joe Lawrence
On 07/20/2017 12:17 AM, Josh Poimboeuf wrote: > - The pre-patch and pre-unpatch hooks can be run before the > patching/unpatching process begins. Hi Josh, By "(un)patching process" are you referring to the klp_patch at large or each klp_object? ie, would all klp_objects execute their hooks

Re: [PATCH] livepatch: add (un)patch hooks

2017-07-19 Thread Joe Lawrence
On 07/17/2017 11:51 AM, Petr Mladek wrote: > On Wed 2017-07-12 10:10:00, Joe Lawrence wrote: >> When the livepatch core executes klp_(un)patch_object, call out to a >> livepatch-module specified array of callback hooks. These hooks provide >> a notification mechanism for l

Re: [PATCH v2 1/2] livepatch: introduce shadow variable API

2017-07-20 Thread Joe Lawrence
On 07/18/2017 08:45 AM, Petr Mladek wrote: > On Wed 2017-06-28 11:37:26, Joe Lawrence wrote: >> diff --git a/Documentation/livepatch/shadow-vars.txt >> b/Documentation/livepatch/shadow-vars.txt >> new file mode 100644 >> index ..7f28982e6b1c >> ---

[PATCH v2 2/2] livepatch: add shadow variable sample programs

2017-06-28 Thread Joe Lawrence
Add sample livepatch modules to demonstrate the shadow variable API. Signed-off-by: Joe Lawrence <joe.lawre...@redhat.com> --- Reviewers -- it's probably easier to grok reading livepatch-shadow-mod.c *before* the two livepatch modules, livepatch-shadow-

[PATCH v2 1/2] livepatch: introduce shadow variable API

2017-06-28 Thread Joe Lawrence
s intended to be used by livepatch modules seeking to emulate additions to data structure definitions. See Documentation/livepatch/shadow-vars.txt for a summary of the new shadow variable API, including a few common use cases. Signed-off-by: Joe Lawrence <joe.lawre...@redhat.com> --- Documen

[PATCH v2 0/2] livepatch: add shadow variable API

2017-06-28 Thread Joe Lawrence
e code is easier to follow than the periodic kernel messages logged. Suggestions welcome. Joe Lawrence (2): livepatch: introduce shadow variable API livepatch: add shadow variable sample programs Documentation/livepatch/shadow-vars.txt | 156 + include/linux/livepatch.h

[PATCH v3] livepatch: introduce shadow variable API

2017-07-28 Thread Joe Lawrence
or exmaple modules that demonstrate shadow variables. Signed-off-by: Joe Lawrence <joe.lawre...@redhat.com> --- Documentation/livepatch/shadow-vars.txt | 217 + include/linux/livepatch.h | 10 + kernel/livepatch/Makefile | 2 +- kernel/li

[PATCH v3] livepatch: shadow variables

2017-07-28 Thread Joe Lawrence
erhaul usage/comments, drop the verbose dmesg logs Joe Lawrence (1): livepatch: introduce shadow variable API Documentation/livepatch/shadow-vars.txt | 217 + include/linux/livepatch.h | 10 + kernel/livepatch/Makefile | 2 +- kernel/livepa

Re: [PATCH] livepatch: add (un)patch hooks

2017-07-28 Thread Joe Lawrence
On 07/27/2017 05:36 PM, Josh Poimboeuf wrote: > On Thu, Jul 27, 2017 at 04:43:58PM -0400, Joe Lawrence wrote: >> On 07/20/2017 12:17 AM, Josh Poimboeuf wrote: >>> - The post-patch and post-unpatch hooks will need to be run from either >>> klp_complete_transition()

[PATCH v2 1/1] livepatch: add (un)patch callbacks

2017-08-08 Thread Joe Lawrence
include modification of global data and registration of newly available services/handlers. See Documentation/livepatch/callback.txt for details. Signed-off-by: Joe Lawrence <joe.lawre...@redhat.com> --- Documentation/livepatch/callbacks.txt| 75 +++ include/linux/livep

[PATCH v2 0/1] add (un)patch callbacks

2017-08-08 Thread Joe Lawrence
() and klp_module_coming/going() - reduce callbacks from a list to a single per-klp_object instance - revamp the sample callback demo - revamp documentation Feedback appreciated as always. Joe Lawrence (1): livepatch: add (un)patch callbacks Documentation/livepatch/callbacks.txt| 75

Re: [PATCH v4] livepatch: introduce shadow variable API

2017-08-18 Thread Joe Lawrence
On 08/17/2017 10:05 AM, Petr Mladek wrote: > On Mon 2017-08-14 16:02:43, Joe Lawrence wrote: >> [ ... snip ... ] >> +/* Allocate a new shadow variable for use inside the lock below */ >> +new_shadow = kzalloc(size + sizeof(*new_shadow), gfp_flags); > > We sh

[PATCH v3] livepatch: add (un)patch callbacks

2017-08-16 Thread Joe Lawrence
include modification of global data and registration of newly available services/handlers. See Documentation/livepatch/callback.txt for details. Signed-off-by: Joe Lawrence <joe.lawre...@redhat.com> --- Documentation/livepatch/callbacks.txt| 87 include/linux/livep

[PATCH v3] add (un)patch callbacks

2017-08-16 Thread Joe Lawrence
ed [ 102.977392] % rmmod samples/livepatch/livepatch-callbacks-demo.ko Part 1: Livepatch is loaded first, so vmlinux callbacks run Part 2: The livepatch's pre-patch-callback is setup to now return -ENODEV Part 3: When a targetted module is loaded, the pre-patch-callback returns -ENODEV an

Re: [PATCH v4] livepatch: introduce shadow variable API

2017-08-17 Thread Joe Lawrence
On 08/17/2017 10:05 AM, Petr Mladek wrote: > On Mon 2017-08-14 16:02:43, Joe Lawrence wrote: >> Add exported API for livepatch modules: >> >> klp_shadow_get() >> klp_shadow_attach() >> klp_shadow_get_or_attach() >> klp_shadow_up

Re: [PATCH v4] livepatch: introduce shadow variable API

2017-08-18 Thread Joe Lawrence
On 08/18/2017 10:04 AM, Petr Mladek wrote: > On Fri 2017-08-18 15:44:29, Nicolai Stange wrote: >> Joe Lawrence <joe.lawre...@redhat.com> writes: >> >> >>> + >>> +/** >>> + * klp_shadow_get() - retrieve a shadow variable data pointe

Re: [PATCH v4] livepatch: introduce shadow variable API

2017-08-18 Thread Joe Lawrence
On 08/17/2017 10:05 AM, Petr Mladek wrote: > On Mon 2017-08-14 16:02:43, Joe Lawrence wrote: >> [ ... snip ... ] >> diff --git a/samples/livepatch/livepatch-shadow-fix1.c >> b/samples/livepatch/livepatch-shadow-fix1.c >> new file mode 100644 >> index 00

  1   2   3   >