Re: [PATCH 4/9] dma: edma: Find missed events and issue them

2013-08-02 Thread Joel Fernandes
Hi Sekhar, Thanks for your detailed illustrations. On 08/02/2013 08:26 AM, Sekhar Nori wrote: [..] This can be used only for buffers that are contiguous in memory, not those that are scattered across memory. I was hinting at using the linking facility of EDMA to achieve this. Each PaRAM set

Re: [PATCH 4/9] dma: edma: Find missed events and issue them

2013-08-02 Thread Joel Fernandes
of size 5 each. Interrupts are setup to trigger for every 5 PaRAM set transfers. After the first 5 transfer, the ISR recycles them for the next 5 entries in the SG-list. This happens in parallel/simultaneously as the second set of 5 are being transferred. Thanks, -Joel On 08/02/2013 01:15 PM, Joel

[PATCH v3 08/12] dma: edma: Add one more required slot to MAX slots

2013-08-05 Thread Joel Fernandes
We'd now need a separate slot just for the channel and separate ones for the 2 linked sets, so we make adjustments to allocate an extra channel accordingly. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/dma/edma.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v3 05/12] ARM: edma: Add function to enable interrupt for a PaRAM slot

2013-08-05 Thread Joel Fernandes
To prevent common programming errors, add a function to enable interrupts correctly. Also keeps calling code more readable. Signed-off-by: Joel Fernandes jo...@ti.com --- arch/arm/common/edma.c | 15 +++ include/linux/platform_data/edma.h |1 + 2 files changed, 16

[PATCH v3 06/12] ARM: edma: Add pr_debug in edma_link

2013-08-05 Thread Joel Fernandes
Useful for visualizing linking of PaRAM slots Signed-off-by: Joel Fernandes jo...@ti.com --- arch/arm/common/edma.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c index aa43c49..34d3fc9 100644 --- a/arch/arm/common/edma.c +++ b/arch/arm

[PATCH v3 03/12] dma: edma: remove limits on number of slots

2013-08-05 Thread Joel Fernandes
With this series, this check is no longer required and we shouldn't need to reject drivers DMA'ing more than the MAX number of slots. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/dma/edma.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma

[PATCH v3 10/12] dma: edma: Check if MAX_NR_SG is even in prep function

2013-08-05 Thread Joel Fernandes
Splitting of MAX available slots into 2 sets of size MAX_NR_LS requires to the MAX_NR_SG function to be even. We ensure the same in prep function. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/dma/edma.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/edma.c b

[PATCH v3 04/12] dma: edma: Write out and handle MAX_NR_SG at a given time

2013-08-05 Thread Joel Fernandes
in the scatter-list and detect completion. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/dma/edma.c | 76 ++-- 1 file changed, 50 insertions(+), 26 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index b6d609c..080d669

[PATCH v3 11/12] dma: edma: Keep tracking of Pending interrupts (pending_acks)

2013-08-05 Thread Joel Fernandes
-by: Joel Fernandes jo...@ti.com --- drivers/dma/edma.c | 32 +--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 061f0cf..eca1b47 100644 --- a/drivers/dma/edma.c +++ b/drivers/dma/edma.c @@ -59,6 +59,10 @@ struct

[PATCH v3 12/12] dma: edma: Return if nothing left todo in edma_execute

2013-08-05 Thread Joel Fernandes
It is possible edma_execute is called even when all the SG elements have been submitted for transmission, we add a check for the same and avoid executing the rest of the function. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/dma/edma.c |3 +++ 1 file changed, 3 insertions(+) diff

[PATCH v3 02/12] ARM: edma: Don't clear EMR of channel in edma_stop

2013-08-05 Thread Joel Fernandes
on such channels cannot be performed. The EMR is ultimately being cleared by the Error interrupt handler once it is handled so we remove code that does it in edma_stop and allow it to happen there. Signed-off-by: Joel Fernandes jo...@ti.com --- arch/arm/common/edma.c |1 - 1 file changed, 1

[PATCH v3 07/12] dma: edma: Add function to dump a PaRAM set from PaRAM

2013-08-05 Thread Joel Fernandes
-by: Joel Fernandes jo...@ti.com --- drivers/dma/edma.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 080d669..a242269 100644 --- a/drivers/dma/edma.c +++ b/drivers/dma/edma.c @@ -102,6 +102,37 @@ static void

[PATCH v3 00/12] edma: Add support for SG lists of any length

2013-08-05 Thread Joel Fernandes
we can mark it as complete. [1] https://lkml.org/lkml/2013/7/29/312 [2] https://lkml.org/lkml/2013/7/30/54 Joel Fernandes (12): dma: edma: Setup parameters to DMA MAX_NR_SG at a time ARM: edma: Don't clear EMR of channel in edma_stop dma: edma: remove limits on number of slots dma: edma

[PATCH v3 09/12] dma: edma: Implement multiple linked sets for continuity

2013-08-05 Thread Joel Fernandes
. Suggested-by: Sekhar Nori nsek...@ti.com Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/dma/edma.c | 157 +++- 1 file changed, 118 insertions(+), 39 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index df50a04..70923a2

[PATCH v3 01/12] dma: edma: Setup parameters to DMA MAX_NR_SG at a time

2013-08-05 Thread Joel Fernandes
, still only 10 slots will be allocated to DMA the entire SG list of size 40. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/dma/edma.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 5f3e532..7b0853c 100644

Re: Regression 3.11-rc1: omap4panda: no usb and consequently no ethernet

2013-07-25 Thread Joel Fernandes
Hi Arend, On 07/25/2013 08:06 AM, Arend van Spriel wrote: On 07/18/2013 02:42 PM, Roger Quadros wrote: On 07/18/2013 03:38 PM, Arend van Spriel wrote: On 07/18/2013 01:30 PM, Roger Quadros wrote: On 07/18/2013 02:24 PM, Arend van Spriel wrote: On 07/18/2013 01:18 PM, Roger Quadros wrote: Hi

Re: Regression 3.11-rc1: omap4panda: no usb and consequently no ethernet

2013-07-25 Thread Joel Fernandes
On 07/25/2013 09:49 PM, Joel Fernandes wrote: [..] Can I get back on this topic. When USB and ethernet was working for me as stated above, I was not doing tftpboot. When I use tftpboot the images are obtained from the tftp server, but after kernel has started there is nothing in /sys/bus/usb

Re: [PATCH v2] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-07-27 Thread Joel Fernandes
Hi Tony or Sekhar, If this patch looks ok, could you pick it up for -rc cycle? It fixes DMA breakages after the merge window for devices for which DMA resources are being populated in device tree instead pdev. Thanks, -Joel On 07/22/2013 12:59 PM, Joel Fernandes wrote: HWMOD removal for MMC

[PATCH 3/9] ARM: edma: Add function to manually trigger an EDMA channel

2013-07-29 Thread Joel Fernandes
Manual trigger for events missed as a result of splitting a scatter gather list and DMA'ing it in batches. Add a helper function to trigger a channel incase any such events are missed. Signed-off-by: Joel Fernandes jo...@ti.com --- arch/arm/common/edma.c | 21

[PATCH 5/9] dma: edma: Leave linked to Null slot instead of DUMMY slot

2013-07-29 Thread Joel Fernandes
an error condition and detect the channel that missed it. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/dma/edma.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index aa4989f..1eda5cc 100644 --- a/drivers/dma/edma.c +++ b/drivers/dma/edma.c

[PATCH 8/9] dma: edma: Link to dummy slot only for last SG list split

2013-07-29 Thread Joel Fernandes
interrupts that occur for the last list split. The Dummy slot has the property of not raising an error condition if events are missed unlike the Null slot. We are OK with this as we're done with processing the whole list once we reach Dummy. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/dma/edma.c

[PATCH 4/9] dma: edma: Find missed events and issue them

2013-07-29 Thread Joel Fernandes
by the time we have setup the transfer for (2). So here, we catch the events missed as an error condition and issue them manually. [1] http://marc.info/?l=linux-omapm=137416733628831w=2 Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/dma/edma.c | 10 +- 1 file changed, 9 insertions

[PATCH 1/9] dma: edma: Setup parameters to DMA MAX_NR_SG at a time

2013-07-29 Thread Joel Fernandes
, still only 10 slots will be allocated to DMA the entire SG list of size 40. Also enable TC interrupts for slots that are a last in a current iteration, or that fall on a MAX_NR_SG boundary. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/dma/edma.c | 19 --- 1 file changed

[PATCH 9/9] dma: edma: remove limits on number of slots

2013-07-29 Thread Joel Fernandes
With this series, this check is no longer required and we shouldn't need to reject drivers DMA'ing more than the MAX number of slots. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/dma/edma.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma

[PATCH 0/9] dma: edma: Support scatter-lists of any length

2013-07-29 Thread Joel Fernandes
size 2, there will not be any noticeable performance improvement. But using 1 slot is even managed by just DMA'ing 1 SG entry at a time. [1] https://lkml.org/lkml/2013/7/18/432 [2] http://marc.info/?l=linux-omapm=137416733628831w=2 Joel Fernandes (9): dma: edma: Setup parameters to DMA

[PATCH 7/9] ARM: edma: Don't clear EMR of channel in edma_stop

2013-07-29 Thread Joel Fernandes
is ultimately being cleared by the Error interrupt handler once it is handled so we don't have to do it in edma_stop. Signed-off-by: Joel Fernandes jo...@ti.com --- arch/arm/common/edma.c |1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c index

[PATCH 2/9] dma: edma: Write out and handle MAX_NR_SG at a given time

2013-07-29 Thread Joel Fernandes
-by: Joel Fernandes jo...@ti.com --- drivers/dma/edma.c | 79 +++- 1 file changed, 54 insertions(+), 25 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 0b68f94..d9a151b 100644 --- a/drivers/dma/edma.c +++ b/drivers/dma/edma.c

[PATCH 6/9] dma: edma: Detect null slot errors and handle them correctly

2013-07-29 Thread Joel Fernandes
the manual triggerring to happen in edma_execute which will eventually be called. This fixes the issue where we are on a NULL slot and continue to receive events from modules like crypto that don't stop their request events after a transfer is completed. Signed-off-by: Joel Fernandes jo...@ti.com

Re: [PATCH v2] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-07-29 Thread Joel Fernandes
On 07/29/2013 02:01 AM, Sekhar Nori wrote: On Monday 22 July 2013 11:29 PM, Joel Fernandes wrote: HWMOD removal for MMC is breaking edma_start as the events are being manually triggered due to unused channel list not being clear, Thanks to Balaji TK for finding this issue. So, Reported

Re: [PATCH v2] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-07-29 Thread Joel Fernandes
On 07/29/2013 02:04 AM, Sekhar Nori wrote: On Sunday 28 July 2013 05:02 AM, Joel Fernandes wrote: Hi Tony or Sekhar, If this patch looks ok, could you pick it up for -rc cycle? It fixes DMA breakages after the merge window for devices for which DMA resources are being populated in device

Re: [PATCH] dma: edma: add device_slave_caps() support

2013-07-29 Thread Joel Fernandes
Hi Vinod, On 07/29/2013 04:45 AM, Vinod Koul wrote: On Thu, Jul 25, 2013 at 12:53:51PM +0530, Vinod Koul wrote: On Wed, Jul 24, 2013 at 02:36:26PM -0500, Joel Fernandes wrote: Also another point worth considering is the approach Russell suggested, I havent gotten a chance to dig deeper

Re: [PATCH v2] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-07-29 Thread Joel Fernandes
On 07/29/2013 11:52 PM, Sekhar Nori wrote: On Tuesday 30 July 2013 09:23 AM, Joel Fernandes wrote: On 07/29/2013 02:04 AM, Sekhar Nori wrote: On Sunday 28 July 2013 05:02 AM, Joel Fernandes wrote: Hi Tony or Sekhar, If this patch looks ok, could you pick it up for -rc cycle? It fixes DMA

[PATCH v2] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-08-23 Thread Joel Fernandes
Antoniou pa...@antoniou-consulting.com Signed-off-by: Joel Fernandes jo...@ti.com --- Note: Patch should go in for -rc cycle as it fixes existing crypto drivers. arch/arm/common/edma.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/arch/arm/common/edma.c b

Re: [PATCH] ARM: dts: add AM33XX EDMA support

2013-08-24 Thread Joel Fernandes
Updating CC with Matt's current email address. On 08/24/2013 01:02 PM, Sergei Shtylyov wrote: Hello. On 08/23/2013 11:06 PM, Sebastian Andrzej Siewior wrote: From: Matt Porter m...@ti.com Adds AM33XX EDMA support to the am33xx.dtsi as documented in

Re: [PATCH] ARM: dts: add AM33XX EDMA support

2013-08-26 Thread Joel Fernandes
Hi Benoit, On 08/26/2013 03:33 AM, Benoit Cousson wrote: Hi Sebastian, Is this patch different from that one: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg92176.html Lokesh just pointed me this patch because it was missing for the SHAM/AES series from Mark Greer.

Re: [PATCH v2] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-08-26 Thread Joel Fernandes
On 08/26/2013 05:46 AM, Sekhar Nori wrote: On Saturday 24 August 2013 01:23 AM, Joel Fernandes wrote: HWMOD removal for MMC and Crypto is breaking edma_start as the events are being manually triggered due to unused channel list not being clear. Atleast breakage has been seen

[PATCH] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-08-26 Thread Joel Fernandes
the of_* helpers to parse the arguments in the dmas phandle list. Reviewed-by: Sekhar Nori nsek...@ti.com Reported-by: Balaji T K balaj...@ti.com Cc: Pantel Antoniou pa...@antoniou-consulting.com Signed-off-by: Joel Fernandes jo...@ti.com --- Changes since v1, in v2 and v3: - Reduced indentation of non

Re: [PATCH v2 04/14] crypto: omap-aes: Simplify DMA usage by using direct SGs

2013-08-20 Thread Joel Fernandes
On 08/20/2013 07:57 AM, Lokesh Vutla wrote: Hi Joel, On Sunday 18 August 2013 08:12 AM, Joel Fernandes wrote: In early version of this driver, assumptions were made such as DMA layer requires contiguous buffers etc. Due to this, new buffers were allocated, mapped and used for DMA

[PATCH 00/10] crypto: omap-aes: DMA and PIO mode improvements

2013-08-14 Thread Joel Fernandes
(647168 bytes) Future work in this direction would be to dynamically change between PIO/DMA mode based on the block size. Joel Fernandes (10): crypto: scatterwalk: Add support for calculating number of SG elements crypto: omap-aes: Add useful debug macros crypto: omap-aes: Populate number

[PATCH 01/10] crypto: scatterwalk: Add support for calculating number of SG elements

2013-08-14 Thread Joel Fernandes
Crypto layer only passes nbytes to encrypt but in omap-aes driver we need to know number of SG elements to pass to dmaengine slave API. We add function for the same to scatterwalk library. Signed-off-by: Joel Fernandes jo...@ti.com --- crypto/scatterwalk.c | 22

[PATCH 06/10] crypto: omap-aes: Remove previously used intermediate buffers

2013-08-14 Thread Joel Fernandes
in omap_aes_device. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c | 90 - 1 file changed, 90 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index df2f867..71da52b 100644 --- a/drivers/crypto/omap-aes.c

[PATCH 03/10] crypto: omap-aes: Populate number of SG elements

2013-08-14 Thread Joel Fernandes
are used later. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 3838e0a..b7189a8 100644 --- a/drivers/crypto/omap-aes.c +++ b/drivers/crypto/omap-aes.c

[PATCH 05/10] crypto: omap-aes: Sync SG before DMA operation

2013-08-14 Thread Joel Fernandes
Earlier functions that did a similar sync are replaced by the dma_sync_sg_* which can operate on entire SG list. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap

[PATCH 04/10] crypto: omap-aes: Simplify DMA usage by using direct SGs

2013-08-14 Thread Joel Fernandes
performance (atleast 35% seen with encrypting a buffer size of 8K (2800 ops/sec vs 1800 ops/sec). Also DMA usage is much more simplified and coherent with rest of the code. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c | 147 - 1 file

[PATCH 08/10] crypto: omap-aes: PIO mode: Add IRQ handler and walk SGs

2013-08-14 Thread Joel Fernandes
errors. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c | 90 + 1 file changed, 90 insertions(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index c057eac..891455b 100644 --- a/drivers/crypto/omap-aes.c

[PATCH 10/10] crypto: omap-aes: Switch to PIO mode in probe function

2013-08-14 Thread Joel Fernandes
in this mode. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 54f2729..34e3b77 100644 --- a/drivers/crypto/omap-aes.c +++ b

[PATCH 09/10] crypto: omap-aes: PIO mode: platform data for OMAP4 and trigger it

2013-08-14 Thread Joel Fernandes
We initialize the scatter gather walk lists needed for PIO mode and avoid all DMA paths such as mapping/unmapping buffers by checking for the pio_only flag. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c | 43 ++- 1 file changed

[PATCH 07/10] crypto: omap-aes: Add IRQ info and helper macros

2013-08-14 Thread Joel Fernandes
Add IRQ information to pdata and helper macros. These are required for PIO-mode support. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 71da52b

[PATCH 02/10] crypto: omap-aes: Add useful debug macros

2013-08-14 Thread Joel Fernandes
When DEBUG is enabled, these macros can be used to print variables in integer and hex format, and clearly display which registers, offsets and values are being read/written , including printing the names of the offsets and their values. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers

Re: [PATCH 00/10] crypto: omap-aes: DMA and PIO mode improvements

2013-08-14 Thread Joel Fernandes
On 08/14/2013 06:12 PM, Joel Fernandes wrote: This patch series is a rewrite of the DMA portion of omap-aes driver and also adds support for PIO mode. Both these modes, give better performance than before. Earlier, only a single SG was used for DMA purpose, and the SG-list passed from

Re: [PATCH 02/10] crypto: omap-aes: Add useful debug macros

2013-08-14 Thread Joel Fernandes
On 08/14/2013 06:29 PM, Joe Perches wrote: On Wed, 2013-08-14 at 18:12 -0500, Joel Fernandes wrote: When DEBUG is enabled, these macros can be used to print variables in integer and hex format, and clearly display which registers, offsets and values are being read/written , including printing

Re: [PATCH 02/10] crypto: omap-aes: Add useful debug macros

2013-08-14 Thread Joel Fernandes
On 08/14/2013 07:47 PM, Joe Perches wrote: On Wed, 2013-08-14 at 18:40 -0500, Joel Fernandes wrote: On 08/14/2013 06:29 PM, Joe Perches wrote: On Wed, 2013-08-14 at 18:12 -0500, Joel Fernandes wrote: When DEBUG is enabled, these macros can be used to print variables in integer and hex format

Re: [PATCH 00/10] crypto: omap-aes: DMA and PIO mode improvements

2013-08-15 Thread Joel Fernandes
On 08/15/2013 12:58 AM, Dmitry Kasatkin wrote: On 15/08/13 02:30, Joel Fernandes wrote: On 08/14/2013 06:12 PM, Joel Fernandes wrote: This patch series is a rewrite of the DMA portion of omap-aes driver and also adds support for PIO mode. Both these modes, give better performance than before

Re: [PATCH 02/10] crypto: omap-aes: Add useful debug macros

2013-08-15 Thread Joel Fernandes
On 08/15/2013 01:23 AM, Dmitry Kasatkin wrote: On 15/08/13 06:12, Joel Fernandes wrote: On 08/14/2013 07:47 PM, Joe Perches wrote: On Wed, 2013-08-14 at 18:40 -0500, Joel Fernandes wrote: On 08/14/2013 06:29 PM, Joe Perches wrote: On Wed, 2013-08-14 at 18:12 -0500, Joel Fernandes wrote: When

Re: [PATCH v3 00/12] edma: Add support for SG lists of any length

2013-08-15 Thread Joel Fernandes
be detected as error conditions. This should architecturally be the final version of the patch series to add DMA support for SG lists of any length. Thanks, -Joel On 08/05/2013 11:14 AM, Joel Fernandes wrote: Here is a more improved approach for DMA support of SG lists of any length in the EDMA

[PATCH v2 06/14] crypto: omap-aes: Remove previously used intermediate buffers

2013-08-17 Thread Joel Fernandes
in omap_aes_device. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c | 90 - 1 file changed, 90 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 5e034a1..bbdd1c3 100644 --- a/drivers/crypto/omap

[PATCH v2 00/14] crypto: omap-aes: Improve DMA, add PIO mode and support for AM437x

2013-08-17 Thread Joel Fernandes
: omap-aes: Add useful debug macros will generate a checkpatch error, which cannot be fixed. Refer to patch for error message and reasons for why cannot be fixed, thanks. Joel Fernandes (14): crypto: scatterwalk: Add support for calculating number of SG elements crypto: omap-aes: Add

[PATCH v2 08/14] crypto: omap-aes: PIO mode: Add IRQ handler and walk SGs

2013-08-17 Thread Joel Fernandes
errors. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c | 90 + 1 file changed, 90 insertions(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 9a964e8..889dc99 100644 --- a/drivers/crypto/omap-aes.c

[PATCH v2 07/14] crypto: omap-aes: Add IRQ info and helper macros

2013-08-17 Thread Joel Fernandes
Add IRQ information to pdata and helper macros. These are required for PIO-mode support. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index bbdd1c3

[PATCH v2 12/14] crypto: omap-aes: Convert kzalloc to devm_kzalloc

2013-08-17 Thread Joel Fernandes
Use devm_kzalloc instead of kzalloc. With this change, there is no need to call kfree in error/exit paths. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto

[PATCH v2 02/14] crypto: omap-aes: Add useful debug macros

2013-08-17 Thread Joel Fernandes
that requires a do-while loop, but there is code that will break if a do-while loop is used in the macro so we ignore the checkpatch error in this case. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion

[PATCH v2 04/14] crypto: omap-aes: Simplify DMA usage by using direct SGs

2013-08-17 Thread Joel Fernandes
of atleast ~20% seen with encrypting a buffer size of 8K (1800 ops/sec vs 1400 ops/sec). Improvement will be higher for much larger blocks though such benchmarking is left as an exercise for the reader. Also DMA usage is much more simplified and coherent with rest of the code. Signed-off-by: Joel

[PATCH v2 10/14] crypto: omap-aes: Switch to PIO mode during probe

2013-08-17 Thread Joel Fernandes
in this mode. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 62b3260..d214dbf 100644 --- a/drivers/crypto/omap-aes.c +++ b

[PATCH v2 09/14] crypto: omap-aes: PIO mode: platform data for OMAP4/AM437x and trigger

2013-08-17 Thread Joel Fernandes
We initialize the scatter gather walk lists needed for PIO mode and avoid all DMA paths such as mapping/unmapping buffers by checking for the pio_only flag. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c | 43 ++- 1 file changed

[PATCH v2 05/14] crypto: omap-aes: Sync SG before DMA operation

2013-08-17 Thread Joel Fernandes
Earlier functions that did a similar sync are replaced by the dma_sync_sg_* which can operate on entire SG list. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap

[PATCH v2 13/14] crypto: omap-aes: Convert request_irq to devm_request_irq

2013-08-17 Thread Joel Fernandes
Keeps request_irq exit/error code paths simpler. Suggested-by: Lokesh Vutla lokeshvu...@ti.com Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap

[PATCH v2 11/14] crypto: omap-aes: Add support for cases of unaligned lengths

2013-08-17 Thread Joel Fernandes
then copy data into the buffer, and copy data out of it on completion. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c | 86 +++-- 1 file changed, 83 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto

[PATCH v2 01/14] crypto: scatterwalk: Add support for calculating number of SG elements

2013-08-17 Thread Joel Fernandes
Crypto layer only passes nbytes to encrypt but in omap-aes driver we need to know number of SG elements to pass to dmaengine slave API. We add function for the same to scatterwalk library. Signed-off-by: Joel Fernandes jo...@ti.com --- crypto/scatterwalk.c | 22

[PATCH v2 03/14] crypto: omap-aes: Populate number of SG elements

2013-08-17 Thread Joel Fernandes
are used later. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/omap-aes.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 26b802b..e369e6e 100644 --- a/drivers/crypto/omap-aes.c +++ b/drivers/crypto/omap-aes.c

[PATCH v2 14/14] crypto: omap-aes: Kconfig: Add build support for AM437x

2013-08-17 Thread Joel Fernandes
For AM437x SoC, ARCH_OMAP2 and ARCH_OMAP3 is not enabled in the defconfig. We follow same thing as SHA driver, and add depends on ARCH_OMAP2PLUS so that the config is selectable for AES driver on AM437x SoC builds. Signed-off-by: Joel Fernandes jo...@ti.com --- drivers/crypto/Kconfig |2

Re: [PATCH v2 02/14] crypto: omap-aes: Add useful debug macros

2013-08-17 Thread Joel Fernandes
On 08/17/2013 11:22 PM, Joe Perches wrote: On Sat, 2013-08-17 at 21:42 -0500, Joel Fernandes wrote: When DEBUG is enabled, these macros can be used to print variables in integer and hex format, and clearly display which registers, offsets and values are being read/written , including printing

[PATCH 0/3] Pending dmaengine patches

2013-07-18 Thread Joel Fernandes
I've reworked Matt's dmaegine sg_limits series addressing review comments at [1]. Currently MMC on AM33xx requires EDMA which was posted and accepted, following it is a series that are fixes that have to go in for it to work correctly. Without this series, DMA fails on MMC resulting in I/O

[PATCH 3/3] dma: edma: add device_slave_sg_limits() support

2013-07-18 Thread Joel Fernandes
max number of SG segments it will handle. The maximum size of an SG segment is limited by the addr_width and maxburst of a given transfer request. These values are provided by the client driver and used to calculate and return the maximum segment length. [Joel Fernandes jo...@ti.com: Changes

[PATCH 1/3] dmaengine: add dma_get_slave_sg_limits()

2013-07-18 Thread Joel Fernandes
of the transfer. dma_get_slave_sg_limits() returns an SG limits structure with the maximum number and size of SG segments that the given channel can handle. [Joel Fernandes jo...@ti.com: Changes to allocate limits structure in client and fill up in DMAEngine implementation.] Signed-off-by: Matt Porter

[PATCH 2/3] mmc: omap_hsmmc: set max_segs based on dma engine limits

2013-07-18 Thread Joel Fernandes
limit is present, the value is used to configure mmc-max_segs appropriately. [Joel Fernandes jo...@ti.com: Allocate sg_limits structure in client driver, and have the dmaengine implementation fill it up] Signed-off-by: Matt Porter mpor...@ti.com Acked-by: Tony Lindgren t...@atomide.com Signed-off

Re: [PATCH 1/3] dmaengine: add dma_get_slave_sg_limits()

2013-07-18 Thread Joel Fernandes
On 07/18/2013 12:08 PM, Russell King - ARM Linux wrote: On Thu, Jul 18, 2013 at 11:46:39AM -0500, Joel Fernandes wrote: The API is optionally implemented by dmaengine drivers and when unimplemented will return a NULL pointer. A client driver using this API provides the required dma channel

Re: [PATCH] ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black

2013-09-09 Thread Joel Fernandes
On 09/09/2013 01:43 PM, Koen Kooi wrote: Op 9 sep. 2013, om 20:27 heeft Joel Fernandes jo...@ti.com het volgende geschreven: On 09/09/2013 10:51 AM, Koen Kooi wrote: Op 9 sep. 2013, om 17:23 heeft Kevin Hilman khil...@linaro.org het volgende geschreven: Koen Kooi k

Re: [PATCH] ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black

2013-09-09 Thread Joel Fernandes
On 09/09/2013 10:51 AM, Koen Kooi wrote: Op 9 sep. 2013, om 17:23 heeft Kevin Hilman khil...@linaro.org het volgende geschreven: Koen Kooi k...@dominion.thruhere.net writes: The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, so create a common dtsi both

Re: [PATCH] ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black

2013-09-09 Thread Joel Fernandes
On 09/09/2013 01:51 PM, Joel Fernandes wrote: On 09/09/2013 01:43 PM, Koen Kooi wrote: Op 9 sep. 2013, om 20:27 heeft Joel Fernandes jo...@ti.com het volgende geschreven: On 09/09/2013 10:51 AM, Koen Kooi wrote: Op 9 sep. 2013, om 17:23 heeft Kevin Hilman khil...@linaro.org het volgende

Re: [PATCH] ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black

2013-09-09 Thread Joel Fernandes
On 09/09/2013 03:00 PM, Koen Kooi wrote: Op 9 sep. 2013, om 21:50 heeft Joel Fernandes jo...@ti.com het volgende geschreven: On 09/09/2013 01:51 PM, Joel Fernandes wrote: On 09/09/2013 01:43 PM, Koen Kooi wrote: Op 9 sep. 2013, om 20:27 heeft Joel Fernandes jo...@ti.com het volgende

Re: [PATCH] ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black

2013-09-09 Thread Joel Fernandes
On 09/09/2013 03:12 PM, Joel Fernandes wrote: On 09/09/2013 03:00 PM, Koen Kooi wrote: Op 9 sep. 2013, om 21:50 heeft Joel Fernandes jo...@ti.com het volgende geschreven: On 09/09/2013 01:51 PM, Joel Fernandes wrote: On 09/09/2013 01:43 PM, Koen Kooi wrote: Op 9 sep. 2013, om 20:27 heeft

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-10 Thread Joel Fernandes
On 07/31/2013 03:35 AM, Javier Martinez Canillas wrote: On 07/31/2013 01:44 AM, Linus Walleij wrote: On Tue, Jul 30, 2013 at 6:30 AM, Grant Likely grant.lik...@linaro.org wrote: On Mon, Jul 29, 2013 at 6:36 AM, Linus Walleij linus.wall...@linaro.org wrote: To solve this dilemma, perform an

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-10 Thread Joel Fernandes
On 09/10/2013 08:17 AM, Javier Martinez Canillas wrote: On 09/10/2013 09:00 AM, Joel Fernandes wrote: On 07/31/2013 03:35 AM, Javier Martinez Canillas wrote: On 07/31/2013 01:44 AM, Linus Walleij wrote: On Tue, Jul 30, 2013 at 6:30 AM, Grant Likely grant.lik...@linaro.org wrote: On Mon, Jul

Re: [PATCH 1/3] crypto: omap-des: Add omap-des driver for OMAP4/AM43xx

2013-09-10 Thread Joel Fernandes
); + +MODULE_DESCRIPTION(OMAP DES hw acceleration support.); +MODULE_LICENSE(GPL v2); +MODULE_AUTHOR(Joel Fernandes jo...@ti.com); -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-10 Thread Joel Fernandes
On 09/10/2013 10:48 AM, Javier Martinez Canillas wrote: On 09/10/2013 05:00 PM, Joel Fernandes wrote: On 09/10/2013 08:17 AM, Javier Martinez Canillas wrote: On 09/10/2013 09:00 AM, Joel Fernandes wrote: On 07/31/2013 03:35 AM, Javier Martinez Canillas wrote: On 07/31/2013 01:44 AM, Linus

[PATCH v3] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-09-10 Thread Joel Fernandes
the of_* helpers to parse the arguments in the dmas phandle list. Reviewed-by: Sekhar Nori nsek...@ti.com Reported-by: Balaji T K balaj...@ti.com Cc: Pantel Antoniou pa...@antoniou-consulting.com Signed-off-by: Joel Fernandes jo...@ti.com --- This patch is a repost of v2 with minor change of return

[PATCH 3/3] ARM: dts: add AM33XX MMC support and documentation

2013-09-10 Thread Joel Fernandes
-hs-handling added Signed-off-by: Matt Porter mpor...@ti.com Acked-by: Tony Lindgren t...@atomide.com Signed-off-by: Joel Fernandes jo...@ti.com --- .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 26 ++- arch/arm/boot/dts/am335x-bone.dts | 11 +++ arch/arm/boot

[PATCH 0/3] ARM: dts: Enable EDMA, MMC and SPI on AM33XX for v3.13

2013-09-10 Thread Joel Fernandes
Here are last few patches required to add EDMA and MMC/SPI support for AM33xx. Now that all dependent DMA patches and fixes are in linux next or mainline, except for [1] which should go in for 3.12 -rc cycle, it is safe to enable MMC and SPI support and this patch series enables it. These are

[PATCH 2/3] ARM: dts: add AM33XX SPI DMA support

2013-09-10 Thread Joel Fernandes
From: Matt Porter mpor...@ti.com Adds DMA resources to the AM33XX SPI nodes. Signed-off-by: Matt Porter mpor...@ti.com Signed-off-by: Joel A Fernandes joelag...@ti.com --- arch/arm/boot/dts/am33xx.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/am33xx.dtsi

[PATCH 1/3] ARM: dts: add AM33XX EDMA support

2013-09-10 Thread Joel Fernandes
From: Matt Porter m...@ti.com Adds AM33XX EDMA support to the am33xx.dtsi as documented in Documentation/devicetree/bindings/dma/ti-edma.txt [Joel Fernandes jo...@ti.com] Drop DT entries that are non-hardware-description as discussed in [1] [1] https://patchwork.kernel.org/patch/2226761

Re: [PATCH 0/3] ARM: dts: Enable EDMA, MMC and SPI on AM33XX for v3.13

2013-09-10 Thread Joel Fernandes
On 09/10/2013 02:39 PM, Koen Kooi wrote: Op 10 sep. 2013, om 21:24 heeft Joel Fernandes jo...@ti.com het volgende geschreven: Here are last few patches required to add EDMA and MMC/SPI support for AM33xx. Now that all dependent DMA patches and fixes are in linux next or mainline

Re: [PATCH v3] gpio: interrupt consistency check for OF GPIO IRQs

2013-09-10 Thread Joel Fernandes
On 09/10/2013 04:23 PM, Javier Martinez Canillas wrote: On 09/10/2013 09:52 PM, Stephen Warren wrote: On 09/10/2013 07:56 AM, Javier Martinez Canillas wrote: ... The only thing that this patch tries to solve is when a driver expect to request a IRQ and it doesn't care if is a real IRQ line

Re: [PATCH 0/3] ARM: dts: Enable EDMA, MMC and SPI on AM33XX for v3.13

2013-09-11 Thread Joel Fernandes
On 09/11/2013 12:18 AM, Koen Kooi wrote: Op 10 sep. 2013, om 22:14 heeft Joel Fernandes jo...@ti.com het volgende geschreven: On 09/10/2013 02:39 PM, Koen Kooi wrote: Op 10 sep. 2013, om 21:24 heeft Joel Fernandes jo...@ti.com het volgende geschreven: Here are last few patches

Re: [PATCH v2] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-07-30 Thread Joel Fernandes
On 07/30/2013 11:29 AM, Sekhar Nori wrote: On 7/30/2013 9:17 AM, Joel Fernandes wrote: diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c index a432e6c..765d578 100644 --- a/arch/arm/common/edma.c +++ b/arch/arm/common/edma.c + } else { + for (; i pdev-num_resources

Re: [PATCH 4/9] dma: edma: Find missed events and issue them

2013-07-30 Thread Joel Fernandes
Hi Sekhar, On 07/30/2013 02:05 AM, Sekhar Nori wrote: On Monday 29 July 2013 06:59 PM, Joel Fernandes wrote: In an effort to move to using Scatter gather lists of any size with EDMA as discussed at [1] instead of placing limitations on the driver, we work through the limitations of the EDMAC

Re: [PATCH 7/9] ARM: edma: Don't clear EMR of channel in edma_stop

2013-07-30 Thread Joel Fernandes
On 07/30/2013 03:29 AM, Sekhar Nori wrote: On Monday 29 July 2013 06:59 PM, Joel Fernandes wrote: We certainly don't want error conditions to be cleared anywhere 'anywhere' is a really loaded term. as this will make us 'forget' about missed events. We depend on knowing which events were

Re: [PATCH 3/9] ARM: edma: Add function to manually trigger an EDMA channel

2013-07-30 Thread Joel Fernandes
On 07/30/2013 12:18 AM, Sekhar Nori wrote: On Monday 29 July 2013 06:59 PM, Joel Fernandes wrote: Manual trigger for events missed as a result of splitting a scatter gather list and DMA'ing it in batches. Add a helper function to trigger a channel incase any such events are missed. Signed

Re: [PATCH 7/9] ARM: edma: Don't clear EMR of channel in edma_stop

2013-07-31 Thread Joel Fernandes
On 07/31/2013 04:35 AM, Sekhar Nori wrote: On Wednesday 31 July 2013 10:35 AM, Joel Fernandes wrote: On 07/30/2013 03:29 AM, Sekhar Nori wrote: On Monday 29 July 2013 06:59 PM, Joel Fernandes wrote: We certainly don't want error conditions to be cleared anywhere 'anywhere' is a really loaded

Re: [PATCH 4/9] dma: edma: Find missed events and issue them

2013-07-31 Thread Joel Fernandes
On 07/31/2013 04:18 AM, Sekhar Nori wrote: On Wednesday 31 July 2013 10:19 AM, Joel Fernandes wrote: Hi Sekhar, On 07/30/2013 02:05 AM, Sekhar Nori wrote: On Monday 29 July 2013 06:59 PM, Joel Fernandes wrote: In an effort to move to using Scatter gather lists of any size with EDMA

Re: [PATCH 4/9] dma: edma: Find missed events and issue them

2013-07-31 Thread Joel Fernandes
On 07/31/2013 09:27 PM, Joel Fernandes wrote: On 07/31/2013 04:18 AM, Sekhar Nori wrote: On Wednesday 31 July 2013 10:19 AM, Joel Fernandes wrote: Hi Sekhar, On 07/30/2013 02:05 AM, Sekhar Nori wrote: On Monday 29 July 2013 06:59 PM, Joel Fernandes wrote: In an effort to move to using

  1   2   3   4   5   6   7   8   9   10   >