[PATCH] USB: mos7840: remove unused variable

2012-11-08 Thread Johan Hovold
: stable sta...@vger.kernel.org Signed-off-by: Johan Hovold jhov...@gmail.com --- This patch against v3.4 also applies to v3.0 (and v3.2). Thanks, Johan drivers/usb/serial/mos7840.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index

Re: Fix memory leak in sierra_release() (this time with signed-off-by)

2012-10-24 Thread Johan Hovold
...@vger.kernel.org Acked-by: Johan Hovold jhov...@gmail.com Thanks, Johan diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c index 01d882c..76ef95b 100644 --- a/drivers/usb/serial/sierra.c +++ b/drivers/usb/serial/sierra.c @@ -959,6 +959,7 @@ static void sierra_release(struct

Re: [PATCH usb-linus] USB: keyspan: fix typo causing GPF on open

2012-11-10 Thread Johan Hovold
. Reported-by: Richard richj...@pacbell.net Cc: sta...@vger.kernel.org Cc: Johan Hovold jhov...@gmail.com Signed-off-by: Bjørn Mork bj...@mork.no Acked-by: Johan Hovold jhov...@gmail.com --- Hello Richard, I wonder if you are able to test and verify this? I do not guarantee

Re: kmemleak report on isp1763 and sierra MC8705

2012-11-10 Thread Johan Hovold
On Fri, Nov 9, 2012 at 11:14 PM, Richard Retanubun richardretanu...@ruggedcom.com wrote: On 29/10/12 06:14 PM, Alan Stern wrote: On Mon, 29 Oct 2012, Richard Retanubun wrote: Focusing down on one of the dumps: unreferenced object 0xd3849740 (size 8): comm khubd, pid 1026, jiffies

[PATCH] ARM: at91/ide: remove unsused at91-ide Kconfig entry

2012-11-14 Thread Johan Hovold
Commit cf844751fb25e (ARM: at91: drop ide driver in favor of the pata one) removed the at91-ide driver but did not remove the Kconfig entry. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/ide/Kconfig | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/ide/Kconfig b/drivers

[PATCH 2/2] ARM: at91: remove trailing semicolon from macros

2013-04-07 Thread Johan Hovold
Remove trailing semicolon from register-access macros. Signed-off-by: Johan Hovold jhov...@gmail.com --- arch/arm/mach-at91/at91_rstc.h| 2 +- arch/arm/mach-at91/at91_shdwc.h | 2 +- arch/arm/mach-at91/at91x40_time.c | 2 +- arch/arm/mach-at91/include

[PATCH 1/2] ARM: at91/setup: fix trivial typos

2013-04-07 Thread Johan Hovold
Fix a few trivial typos in panic, warning and debug messages. Signed-off-by: Johan Hovold jhov...@gmail.com --- arch/arm/mach-at91/setup.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-at91/setup.c b/arch/arm/mach-at91/setup.c index 4b67847..9e7c1e1

Re: [PATCH 035/102] USB: serial: add modem-status-change wait queue

2013-04-08 Thread Johan Hovold
On Mon, Apr 08, 2013 at 10:49:50AM +0100, Luis Henriques wrote: 3.5.7.10 -stable review patch. If anyone has any objections, please let me know. -- From: Johan Hovold jhov...@gmail.com commit e5b33dc9d16053c2ae4c2c669cf008829530364b upstream. Add modem-status-change

[PATCH] rtc: rtc-at91rm9200: fix missing iounmap

2013-04-11 Thread Johan Hovold
Add missing iounmap to probe error path and remove. Cc: stable sta...@vger.kernel.org Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/rtc/rtc-at91rm9200.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc

Re: [PATCH v2 0/5] ARM: at91: fix hanged boot

2013-04-11 Thread Johan Hovold
On Mon, Mar 11, 2013 at 07:07:54PM +0100, Johan Hovold wrote: These patches fix a few severe issues affecting most AT91 SOCs where boot can hang after a non-general reset, and where the only way to get the system booting again is to do a general reset -- something which could require

[PATCH 2/4] TTY: synclink_gt: fix DTR being raised on hang up

2013-04-12 Thread Johan Hovold
Make sure to check ASYNC_INITIALISED before raising DTR when waking up from blocked open in block_til_ready. Currently DTR could get raised at hang up as a blocked process would raise DTR unconditionally before checking for hang up and returning. Signed-off-by: Johan Hovold jhov...@gmail.com

[PATCH 3/4] TTY: synclinkmp: fix DTR being raised on hang up

2013-04-12 Thread Johan Hovold
Make sure to check ASYNC_INITIALISED before raising DTR when waking up from blocked open in block_til_ready. Currently DTR could get raised at hang up as a blocked process would raise DTR unconditionally before checking for hang up and returning. Signed-off-by: Johan Hovold jhov...@gmail.com

[PATCH 4/4] TTY: ircomm: fix DTR being raised on hang up

2013-04-12 Thread Johan Hovold
...@davemloft.net Signed-off-by: Johan Hovold jhov...@gmail.com --- net/irda/ircomm/ircomm_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/irda/ircomm/ircomm_tty.c b/net/irda/ircomm/ircomm_tty.c index 362ba47..41ac7938 100644 --- a/net/irda/ircomm/ircomm_tty.c +++ b/net/irda/ircomm

[PATCH 1/4] TTY: synclink: fix DTR being raised on hang up

2013-04-12 Thread Johan Hovold
Make sure to check ASYNC_INITIALISED before raising DTR when waking up from blocked open in block_til_ready. Currently DTR could get raised at hang up as a blocked process would raise DTR unconditionally before checking for hang up and returning. Signed-off-by: Johan Hovold jhov...@gmail.com

[PATCH 0/4] TTY: fix DTR being raised on hang up

2013-04-12 Thread Johan Hovold
this behaviour but is broken in other ways as it, for example, does not honour CBAUD or raise DTR at non-blocking open. Thanks, Johan Johan Hovold (4): TTY: synclink: fix DTR being raised on hang up TTY: synclink_gt: fix DTR being raised on hang up TTY: synclinkmp: fix DTR being raised on hang

Re: [rtc-linux] Re: [PATCH v2 0/5] ARM: at91: fix hanged boot

2013-04-12 Thread Johan Hovold
On Thu, Apr 11, 2013 at 06:54:14PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: On 17:55 Thu 11 Apr , Johan Hovold wrote: On Mon, Mar 11, 2013 at 07:07:54PM +0100, Johan Hovold wrote: These patches fix a few severe issues affecting most AT91 SOCs where boot can hang after a non

Re: [PATCH] rtc: rtc-at91rm9200: use a variable for storing IMR

2013-03-29 Thread Johan Hovold
On Thu, Mar 28, 2013 at 05:16:00PM +0100, Nicolas Ferre wrote: On 03/28/2013 10:57 AM, Johan Hovold : On Tue, Mar 26, 2013 at 05:09:59PM -0400, Douglas Gilbert wrote: On 13-03-26 03:27 PM, Johan Hovold wrote: On Fri, Mar 15, 2013 at 06:37:12PM +0100, Nicolas Ferre wrote: [...] @@ -198,9

Re: [PATCH] rtc: rtc-at91rm9200: use a variable for storing IMR

2013-03-29 Thread Johan Hovold
On Thu, Mar 28, 2013 at 02:20:17PM -0400, Douglas Gilbert wrote: On 13-03-28 05:57 AM, Johan Hovold wrote: On Tue, Mar 26, 2013 at 05:09:59PM -0400, Douglas Gilbert wrote: On 13-03-26 03:27 PM, Johan Hovold wrote: On Fri, Mar 15, 2013 at 06:37:12PM +0100, Nicolas Ferre wrote: On some

[RFC 5/5] rtc-at91rm9200: add support for at91sam9x5

2013-03-29 Thread Johan Hovold
Add support for the at91sam9x5-family which must use the shadow interrupt mask due to a hardware issue. --- drivers/rtc/rtc-at91rm9200.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index 2921866..f3e351f 100644 ---

[RFC 1/5] rtc-at91rm9200: add configuration support

2013-03-29 Thread Johan Hovold
Add configuration support which can be used to implement SoC-specific workarounds for broken hardware. --- drivers/rtc/rtc-at91rm9200.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index 434ebc3..5bae0a1 100644

[RFC 3/5] rtc-at91rm9200: refactor interrupt-register handling

2013-03-29 Thread Johan Hovold
Add accessors for the interrupt register. This will allow us to easily add a shadow interrupt-mask register to use on SoCs where the interrupt-mask register cannot be used. --- drivers/rtc/rtc-at91rm9200.c | 43 +-- 1 file changed, 29 insertions(+), 14

[RFC 4/5] rtc-at91rm9200: add shadow interrupt mask

2013-03-29 Thread Johan Hovold
Add shadow interrupt-mask register which can be used on SoCs where the actual hardware register is broken. Note that some care needs to be taken to make sure the shadow mask corresponds to the actual hardware state. The added overhead is not an issue for the non-broken SoCs due to the relatively

[RFC 2/5] rtc-at91rm9200: add device-tree support

2013-03-29 Thread Johan Hovold
Add device tree support. --- drivers/rtc/rtc-at91rm9200.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index 5bae0a1..67260f9 100644 --- a/drivers/rtc/rtc-at91rm9200.c +++ b/drivers/rtc/rtc-at91rm9200.c @@

Re: [RFC 2/5] rtc-at91rm9200: add device-tree support

2013-03-29 Thread Johan Hovold
On Fri, Mar 29, 2013 at 05:03:46PM +0100, Johan Hovold wrote: Add device tree support. --- drivers/rtc/rtc-at91rm9200.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index 5bae0a1..67260f9 100644

Re: [RFC PATCH v2] rtc: rtc-at91rm9200: manage IMR depending on revision

2013-04-03 Thread Johan Hovold
On Tue, Apr 02, 2013 at 06:36:06PM +0200, Nicolas Ferre wrote: Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com --- Hi again, Here is my latest revision of this fix. It depends on the patch that is already in Andrew's patch stack: drivers-rtc-rtc-at91rm9200c-add-dt-support.patch.

[PATCH] Revert drivers/rtc/rtc-at91rm9200.c: use a variable for storing IMR

2013-04-03 Thread Johan Hovold
, which this driver currently does not support. Cc: stable sta...@vger.kernel.org Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/rtc/rtc-at91rm9200.c | 50 +--- drivers/rtc/rtc-at91rm9200.h | 1 + 2 files changed, 20 insertions(+), 31 deletions

[RFC v2 1/4] rtc-at91rm9200: add configuration support

2013-04-03 Thread Johan Hovold
Add configuration support which can be used to implement SoC-specific workarounds for broken hardware. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/rtc/rtc-at91rm9200.c | 42 -- 1 file changed, 36 insertions(+), 6 deletions(-) diff --git

[RFC v2 4/4] rtc-at91rm9200: add support for at91sam9x5

2013-04-03 Thread Johan Hovold
Add support for the at91sam9x5-family which must use the shadow interrupt mask due to a hardware issue. Signed-off-by: Johan Hovold jhov...@gmail.com --- Documentation/devicetree/bindings/rtc/atmel,at91rm9200-rtc.txt | 2 +- drivers/rtc/rtc-at91rm9200.c | 7

[RFC v2 0/4] rtc-at91rm9200: add support for at91sam9x5

2013-04-03 Thread Johan Hovold
in the first patch could easily be reduced to a single flag set based on the compatible-property matching sam9x5. Johan v2 - rebase on top of DT-support patch by Joachim Eastwood - add missing brace in DT-id table Johan Hovold (4): rtc-at91rm9200: add configuration support rtc-at91rm9200

[RFC v2 2/4] rtc-at91rm9200: refactor interrupt-register handling

2013-04-03 Thread Johan Hovold
Add accessors for the interrupt register. This will allow us to easily add a shadow interrupt-mask register to use on SoCs where the interrupt-mask register cannot be used. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/rtc/rtc-at91rm9200.c | 43

[RFC v2 3/4] rtc-at91rm9200: add shadow interrupt mask

2013-04-03 Thread Johan Hovold
infrequent interrupt-mask updates. We do, however, only use the shadow mask value as a fall-back when it actually needed as there is still a theoretical possibility that the mask is incorrect (see the code for details). Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/rtc/rtc-at91rm9200.c

Re: [RFC PATCH v2] rtc: rtc-at91rm9200: manage IMR depending on revision

2013-04-03 Thread Johan Hovold
On Wed, Apr 03, 2013 at 12:37:47PM +0200, Nicolas Ferre wrote: On 04/03/2013 11:51 AM, Johan Hovold : On Tue, Apr 02, 2013 at 06:36:06PM +0200, Nicolas Ferre wrote: [...] I now use a different compatibility string to figure out what is the IP revision that has the boggus IMR error. I

Re: [PATCH v3 3/6] TTY: fix DTR being raised on hang up

2013-03-15 Thread Johan Hovold
On Wed, Mar 13, 2013 at 03:43:43PM -0400, Peter Hurley wrote: On Thu, 2013-03-07 at 15:55 +0100, Johan Hovold wrote: Make sure to check ASYNC_INITIALISED before raising DTR when waking up from blocked open in tty_port_block_til_ready. Currently DTR could get raised at hang up

Re: [PATCH v3 0/6] TTY: port hangup and close fixes

2013-03-15 Thread Johan Hovold
On Wed, Mar 13, 2013 at 03:50:32PM -0400, Peter Hurley wrote: On Thu, 2013-03-07 at 15:55 +0100, Johan Hovold wrote: These patches against 3.9-rc1 fix a few issues with tty-port hangup and close. The first and fifth patch are essentially clean ups. The second and third patch fix

Re: [PATCH v3 3/6] TTY: fix DTR being raised on hang up

2013-03-15 Thread Johan Hovold
On Fri, Mar 15, 2013 at 07:03:08AM -0400, Peter Hurley wrote: On Fri, 2013-03-15 at 10:24 +0100, Johan Hovold wrote: On Wed, Mar 13, 2013 at 03:43:43PM -0400, Peter Hurley wrote: On Thu, 2013-03-07 at 15:55 +0100, Johan Hovold wrote: Make sure to check ASYNC_INITIALISED before raising

Re: [PATCH v3 0/6] TTY: port hangup and close fixes

2013-03-15 Thread Johan Hovold
On Fri, Mar 15, 2013 at 12:05:58PM -0700, Greg KH wrote: On Thu, Mar 07, 2013 at 03:55:47PM +0100, Johan Hovold wrote: These patches against 3.9-rc1 fix a few issues with tty-port hangup and close. Are these for 3.9-final? I'd say it can wait for 3.10 as it fixes long-standing issues

Re: [PATCH 098/150] USB: serial: add modem-status-change wait queue

2013-03-26 Thread Johan Hovold
=136428758202815w=2 and should show up in 3.9-rc5. This patch and the following use-after-free patches should not be applied without that fix. Johan -- From: Johan Hovold jhov...@gmail.com commit e5b33dc9d16053c2ae4c2c669cf008829530364b upstream. Add modem-status-change wait

Re: [ 084/104] USB: serial: add modem-status-change wait queue

2013-03-26 Thread Johan Hovold
=136428758202815w=2 and should show up in 3.9-rc5. This patch and the following use-after-free patches should not be applied without that fix. Johan -- From: Johan Hovold jhov...@gmail.com commit e5b33dc9d16053c2ae4c2c669cf008829530364b upstream. Add modem-status-change wait

Re: [PATCH] rtc: rtc-at91rm9200: use a variable for storing IMR

2013-03-26 Thread Johan Hovold
On Fri, Mar 15, 2013 at 06:37:12PM +0100, Nicolas Ferre wrote: On some revisions of AT91 SoCs, the RTC IMR register is not working. Instead of elaborating a workaround for that specific SoC or IP version, we simply use a software variable to store the Interrupt Mask Register and modify it for

Re: [PATCH] rtc: rtc-at91rm9200: use a variable for storing IMR

2013-03-28 Thread Johan Hovold
On Tue, Mar 26, 2013 at 05:09:59PM -0400, Douglas Gilbert wrote: On 13-03-26 03:27 PM, Johan Hovold wrote: On Fri, Mar 15, 2013 at 06:37:12PM +0100, Nicolas Ferre wrote: On some revisions of AT91 SoCs, the RTC IMR register is not working. Instead of elaborating a workaround

[PATCH 1/2] w1-gpio: remove erroneous __exit and __exit_p()

2013-03-08 Thread Johan Hovold
mismatch for probe, but left remove marked with __exit. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/w1/masters/w1-gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c index d39dfa4..012817a 100644

[PATCH 2/2] w1-gpio: fix unused variable warning

2013-03-08 Thread Johan Hovold
Commit 8a1861d997 (w1-gpio: Simplify get rid of defines) removed the compile guards from the device-tree id table, thereby generating a warning when building without device-tree support. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/w1/masters/w1-gpio.c | 2 ++ 1 file changed, 2

[PATCH 1/3] ARM: at91/rtc: fix boot after RTC wake-up

2013-03-08 Thread Johan Hovold
to recover from a failed boot after an RTC-alarm is to remove any backup power (e.g. backup battery) or to disable (or acknowledge) the RTC-interrupt manually from the bootloader. In particular, a user-reset is not sufficient. Tested on at91sam9g45. Cc: stable sta...@vger.kernel.org Signed-off-by: Johan

[PATCH 3/3] ARM: at91: fix hanged boot

2013-03-08 Thread Johan Hovold
. Tested on at91sam9263 and at91sam9g45. Signed-off-by: Johan Hovold jhov...@gmail.com --- arch/arm/mach-at91/at91rm9200.c | 9 arch/arm/mach-at91/at91sam9260.c | 6 ++ arch/arm/mach-at91/at91sam9261.c | 6 ++ arch/arm/mach-at91/at91sam9263.c

[PATCH 2/3] Revert arm: at91: move at91rm9200 rtc header in drivers/rtc

2013-03-08 Thread Johan Hovold
This reverts commit 75984df05d86956541795f01e62d7dc67bc522fd. A couple of these register definitions are needed by arch code as the RTC-interrupts must be disabled at early boot. Signed-off-by: Johan Hovold jhov...@gmail.com --- arch/arm/mach-at91/include/mach/at91_rtc.h | 75

[PATCH 0/3] ARM: at91: fix hanged boot

2013-03-08 Thread Johan Hovold
when adding new SOCs either. The patches have been tested on at91sam9263 and at91sam9g45, and compile-tested for the other SOCs. Johan Johan Hovold (3): ARM: at91/rtc: fix boot after RTC wake-up Revert arm: at91: move at91rm9200 rtc header in drivers/rtc ARM: at91: fix hanged boot arch

Re: [rtc-linux] [PATCH 3/3] ARM: at91: fix hanged boot

2013-03-11 Thread Johan Hovold
On Fri, Mar 08, 2013 at 05:02:58PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: On 13:51 Fri 08 Mar , Johan Hovold wrote: Make sure the RTC and RTT-interrupts are masked at boot by adding a new SOC-initialiser and helpers functions. This fixes hanged boot on all AT91 SOCs

Re: [rtc-linux] [PATCH 3/3] ARM: at91: fix hanged boot

2013-03-11 Thread Johan Hovold
On Mon, Mar 11, 2013 at 12:06:37PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: On 11:02 Mon 11 Mar , Johan Hovold wrote: On Fri, Mar 08, 2013 at 05:02:58PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: On 13:51 Fri 08 Mar , Johan Hovold wrote: Make sure the RTC and RTT

[PATCH v2 0/5] ARM: at91: fix hanged boot

2013-03-11 Thread Johan Hovold
(non-DT), and compile-tested for the other SOCs and DT. Johan v2: - add DT-support - make sys_irq_mask non-mandatory Johan Hovold (5): ARM: at91/rtc: fix boot after RTC wake-up ARM: at91/dts: add RTC nodes ARM: at91/dts: add RTT nodes Revert arm: at91: move at91rm9200 rtc header

[PATCH v2 1/5] ARM: at91/rtc: fix boot after RTC wake-up

2013-03-11 Thread Johan Hovold
to recover from a failed boot after an RTC-alarm is to remove any backup power (e.g. backup battery) or to disable (or acknowledge) the RTC-interrupt manually from the bootloader. In particular, a user-reset is not sufficient. Tested on at91sam9g45. Cc: stable sta...@vger.kernel.org Signed-off-by: Johan

[PATCH v2 4/5] Revert arm: at91: move at91rm9200 rtc header in drivers/rtc

2013-03-11 Thread Johan Hovold
This reverts commit 75984df05d86956541795f01e62d7dc67bc522fd. A couple of these register definitions are needed by arch code as the RTC-interrupts must be disabled at early boot. Signed-off-by: Johan Hovold jhov...@gmail.com --- arch/arm/mach-at91/include/mach/at91_rtc.h | 75

[PATCH v2 3/5] ARM: at91/dts: add RTT nodes

2013-03-11 Thread Johan Hovold
Add RTT nodes for Atmel SOCs. Signed-off-by: Johan Hovold jhov...@gmail.com --- arch/arm/boot/dts/at91sam9260.dtsi | 5 + arch/arm/boot/dts/at91sam9263.dtsi | 10 ++ arch/arm/boot/dts/at91sam9g45.dtsi | 5 + 3 files changed, 20 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v2 5/5] ARM: at91: fix hanged boot

2013-03-11 Thread Johan Hovold
. Tested on at91sam9263 and at91sam9g45. Signed-off-by: Johan Hovold jhov...@gmail.com --- arch/arm/mach-at91/at91sam9260.c | 6 +++ arch/arm/mach-at91/at91sam9261.c | 6 +++ arch/arm/mach-at91/at91sam9263.c | 7 arch/arm/mach-at91/at91sam9g45.c | 7 arch/arm/mach-at91/at91sam9rl.c | 7

[PATCH v2 2/5] ARM: at91/dts: add RTC nodes

2013-03-11 Thread Johan Hovold
Add RTC nodes for Atmel SOCs. Use two different compatible properties to reflect the fact that the RTC-peripherals are backup powered (VDDBU) and are thus not reset on wake-up, user, watchdog or software reset on all SOCs but at91rm9200. Signed-off-by: Johan Hovold jhov...@gmail.com --- arch

[PATCH] ARM: w1-gpio: fix erroneous gpio requests

2013-03-12 Thread Johan Hovold
break other uses of the corresponding pin. On AT91 requesting gpio 0 changes the pin muxing for PIOA0, which, for instance, breaks SPI0 on at91sam9g20. Cc: stable sta...@vger.kernel.org Signed-off-by: Johan Hovold jhov...@gmail.com --- Not sure whose tree this should go in through, so adding

Re: [PATCH] ARM: w1-gpio: fix erroneous gpio requests

2013-03-12 Thread Johan Hovold
On Wed, Mar 13, 2013 at 04:24:20AM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: On Mar 13, 2013, at 4:20 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Mar 12, 2013 at 08:21:34PM +0100, Johan Hovold wrote: Fix regression introduced by commit d2323cf773 (onewire: w1-gpio

[PATCH] ARM: at91/avr32/atmel-mci: fix DMA-channel leak on module unload

2013-03-13 Thread Johan Hovold
enabled (if supported), but the DMA-channel is not released on module unload unless the DMA-config option is selected. Remove the no longer used CONFIG_MMC_ATMELMCI_DMA option completely. Cc: stable sta...@vger.kernel.org Signed-off-by: Johan Hovold jhov...@gmail.com --- arch/arm/configs

Re: [PATCH 0/5] at91: atmel_lcdfb: regression fixes and cpu_is removal

2013-03-04 Thread Johan Hovold
uses the intensity-bit and restore the old layout in that case. The last patch is a removal of uses of cpu_is_() macros in atmel_lcdfb with a platform-device-id table and static configurations. Patches from Johan Hovold taken from: [PATCH 0/3] atmel_lcdfb: fix 16-bpp regression

Re: [Fwd: [PATCH v2 0/4] TTY: port hangup and close fixes]

2013-03-06 Thread Johan Hovold
Hi Jiri, On Tue, Mar 05, 2013 at 05:02:44PM +0100, Jiri Slaby wrote: On 02/28/2013 09:57 PM, Peter Hurley wrote: Hi Jiri, Just wanted to make sure you saw this series. Hi, thanks for letting me know. Johan, care to CC Alan Cox and me (or at least LKML) when you're changing the TTY

Re: [Fwd: [PATCH v2 0/4] TTY: port hangup and close fixes]

2013-03-07 Thread Johan Hovold
On Wed, Mar 06, 2013 at 02:14:56PM -0500, Peter Hurley wrote: On Wed, 2013-03-06 at 17:52 +0100, Johan Hovold wrote: @@ -225,15 +232,13 @@ void tty_port_hangup(struct tty_port *port) spin_lock_irqsave(port-lock, flags); port-count = 0; port-flags

[PATCH v3 6/6] TTY: fix close of uninitialised ports

2013-03-07 Thread Johan Hovold
drain delay for an uninitialised port. Currently a drain delay of up to two seconds could be added when a tty fails to open. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/tty/tty_port.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/tty

[PATCH v3 2/6] TTY: wake up processes last at hangup

2013-03-07 Thread Johan Hovold
Move wake up of processes on blocked-open and modem-status wait queues to after port shutdown at hangup. This way the woken up processes can use the ASYNC_INITIALIZED flag to detect port shutdown. Note that this is the order currently used by serial-core. Signed-off-by: Johan Hovold jhov

[PATCH v3 4/6] TTY: fix DTR not being dropped on hang up

2013-03-07 Thread Johan Hovold
of those other seven drivers did not expect DTR to have been dropped by tty_port_close_start in the first place. ] Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/tty/mxser.c| 4 drivers/tty/n_gsm.c| 4 drivers/tty/tty_port.c | 27 +++ 3 files

[PATCH v3 1/6] TTY: clean up port shutdown

2013-03-07 Thread Johan Hovold
Untangle port-shutdown logic and make sure the initialised flag is always cleared for non-console ports. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/tty/tty_port.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/tty/tty_port.c b/drivers/tty

[PATCH v3 0/6] TTY: port hangup and close fixes

2013-03-07 Thread Johan Hovold
on tty_port_close_start directly but that did not manage DTR themselves Johan Hovold (6): TTY: clean up port shutdown TTY: wake up processes last at hangup TTY: fix DTR being raised on hang up TTY: fix DTR not being dropped on hang up TTY: clean up port drain-delay handling TTY: fix close

[PATCH v3 3/6] TTY: fix DTR being raised on hang up

2013-03-07 Thread Johan Hovold
Make sure to check ASYNC_INITIALISED before raising DTR when waking up from blocked open in tty_port_block_til_ready. Currently DTR could get raised at hang up as a blocked process would raise DTR unconditionally before checking for hang up and returning. Signed-off-by: Johan Hovold jhov

[PATCH v3 5/6] TTY: clean up port drain-delay handling

2013-03-07 Thread Johan Hovold
Move port drain-delay handling to a separate function. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/tty/tty_port.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c index cd65f7e..048cc85

Re: [PATCH 0/5] at91: atmel_lcdfb: regression fixes and cpu_is removal

2013-02-10 Thread Johan Hovold
uses the intensity-bit and restore the old layout in that case. The last patch is a removal of uses of cpu_is_() macros in atmel_lcdfb with a platform-device-id table and static configurations. Patches from Johan Hovold taken from: [PATCH 0/3] atmel_lcdfb: fix 16-bpp regression

[PATCH resend] ARM: at91/ide: remove unsused at91-ide Kconfig entry

2013-02-05 Thread Johan Hovold
Commit cf844751fb25e (ARM: at91: drop ide driver in favor of the pata one) removed the at91-ide driver but did not remove the Kconfig entry. Signed-off-by: Johan Hovold jhov...@gmail.com --- Resend of patch first posted mid-November with trivial added as CC. Perhaps it can go in via the AT91

Re: [PATCH resend] ARM: at91/ide: remove unsused at91-ide Kconfig entry

2013-02-05 Thread Johan Hovold
On Tue, Feb 5, 2013 at 2:59 PM, Jiri Kosina jkos...@suse.cz wrote: On Tue, 5 Feb 2013, Johan Hovold wrote: Commit cf844751fb25e (ARM: at91: drop ide driver in favor of the pata one) removed the at91-ide driver but did not remove the Kconfig entry. Signed-off-by: Johan Hovold jhov

Re: [PATCH] iio: lm3533-als: Fix build warnings

2012-08-22 Thread Johan Hovold
On Tue, Aug 14, 2012 at 09:29:21PM +0100, Jonathan Cameron wrote: On 08/02/2012 11:10 AM, Axel Lin wrote: Fix below build warnings: CC [M] drivers/iio/light/lm3533-als.o drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default]

[PATCH] mfd: add tps65910 32-kHz-crystal-input init

2012-07-11 Thread Johan Hovold
Replace tps65910_misc_init with a dedicated init function for the 32-kHz-crystal input. Signed-off-by: Johan Hovold jhov...@gmail.com --- Hi Samuel, How about something like this? My thought with misc_init was that it could be extended should more simple initialisation like for the ck32k_xtal

Re: kmemleak report on isp1763 and sierra MC8705

2012-11-14 Thread Johan Hovold
On Wed, Nov 14, 2012 at 12:12:01PM -0500, Richard Retanubun wrote: On 10/11/12 09:30 AM, Johan Hovold wrote: Hi Johan, There was a reference-count fix for the probe error path that went in to v3.5. Haven't read all the details on how you trigger your leak, but at the face of it, it could

Re: [PATCH v3 2/3] USB: serial: make minor allocation dynamic

2013-06-18 Thread Johan Hovold
@@ -123,8 +116,9 @@ static void return_serial(struct usb_ser mutex_lock(table_lock); for (i = 0; i serial-num_ports; ++i) - serial_table[serial-minor + i] = NULL; + idr_remove(serial_minors, serial-port[i]-minor); mutex_unlock(table_lock); +

Re: [PATCH 1/5] USB : serial : remove tty arg of handle_dcd_change.

2013-09-09 Thread Johan Hovold
On Mon, Sep 09, 2013 at 06:01:16PM +0200, Paul Chavent wrote: Do the same way as in serialcore.c for uart_handle_dcd_change. It removes duplicated code around the usb_serial_handle_dcd_change calls. Signed-off-by: Paul Chavent paul.chav...@onera.fr --- drivers/usb/serial/ch341.c | 7

Re: [PATCH 1/5] USB : serial : remove tty arg of handle_dcd_change.

2013-09-09 Thread Johan Hovold
On Mon, Sep 09, 2013 at 07:45:23PM +0200, Johan Hovold wrote: On Mon, Sep 09, 2013 at 06:01:16PM +0200, Paul Chavent wrote: Do the same way as in serialcore.c for uart_handle_dcd_change. It removes duplicated code around the usb_serial_handle_dcd_change calls. Signed-off-by: Paul

Re: usb-serial lockdep trace in linus' current tree.

2013-11-07 Thread Johan Hovold
to do be doing as well. Could be related. Care to give the fix below a try? Thanks, Johan From 7caaef75ebba3cfa3916b53ce1aee95291802ac4 Mon Sep 17 00:00:00 2001 From: Johan Hovold jhov...@gmail.com Date: Fri, 8 Nov 2013 00:44:31 +0100 Subject: [PATCH] USB: serial: fix write memory-allocation flag

Re: [PATCH 1/3] USB : serial : call handle_dcd_change in ftdi driver.

2013-09-13 Thread Johan Hovold
On Fri, Sep 13, 2013 at 05:35:11PM +0200, Paul Chavent wrote: Signed-off-by: Paul Chavent paul.chav...@onera.fr --- drivers/usb/serial/ftdi_sio.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index

Re: [PATCH 2/3] USB : serial : invoke dcd_change ldisc's handler.

2013-09-13 Thread Johan Hovold
On Fri, Sep 13, 2013 at 05:35:12PM +0200, Paul Chavent wrote: Signed-off-by: Paul Chavent paul.chav...@onera.fr --- Documentation/pps/pps.txt| 15 +++ drivers/usb/serial/generic.c | 9 + 2 files changed, 24 insertions(+) diff --git a/Documentation/pps/pps.txt

Re: [PATCH 3/3] USB : serial : pl2303 wake up after dcd status check.

2013-09-13 Thread Johan Hovold
On Fri, Sep 13, 2013 at 05:35:13PM +0200, Paul Chavent wrote: Seems to be done this way in other drivers (ch341, 8250, ...). And get tty reference only if dcd_change need to be called. This is fine. I have a patch here doing the same two changes as part of a larger clean-up of the pl2303

[PATCH v3 2/3] ARM: at91: fix hanged boot due to early rtt-interrupt

2013-10-16 Thread Johan Hovold
is not sufficient. Signed-off-by: Johan Hovold jhov...@gmail.com --- arch/arm/mach-at91/at91sam9260.c | 2 ++ arch/arm/mach-at91/at91sam9261.c | 2 ++ arch/arm/mach-at91/at91sam9263.c | 3 +++ arch/arm/mach-at91/at91sam9g45.c | 1 + arch/arm/mach-at91/at91sam9rl.c | 1 + arch/arm/mach-at91/generic.h

[PATCH v3 0/3] ARM: at91: fix hanged boot

2013-10-16 Thread Johan Hovold
sure write has reached the devices - split fix in two patches for RTC and RTT, respectively Johan Hovold (3): ARM: at91: fix hanged boot due to early rtc-interrupt ARM: at91: fix hanged boot due to early rtt-interrupt ARM: at91/rtc: disable interrupts at shutdown arch/arm/mach-at91

[PATCH v3 3/3] ARM: at91/rtc: disable interrupts at shutdown

2013-10-16 Thread Johan Hovold
been installed at next boot. Let us be well-behaved and disable them on clean shutdowns at least (as do the RTT-based rtc-at91sam9 driver). Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/rtc/rtc-at91rm9200.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/rtc/rtc

[PATCH v3 1/3] ARM: at91: fix hanged boot due to early rtc-interrupt

2013-10-16 Thread Johan Hovold
. In particular, a user reset is not sufficient. Signed-off-by: Johan Hovold jhov...@gmail.com --- arch/arm/mach-at91/Makefile | 2 +- arch/arm/mach-at91/at91sam9g45.c | 2 ++ arch/arm/mach-at91/at91sam9n12.c | 6 arch/arm/mach-at91/at91sam9rl.c

Re: [PATCH 2/7] USB: serial: add generic wait_until_sent implementation

2013-05-08 Thread Johan Hovold
On Wed, May 08, 2013 at 06:25:13PM +0400, Stas Sergeev wrote: 05.05.2013 22:32, Johan Hovold пишет: Add generic wait_until_sent implementation which polls for empty hardware buffers using the new port-operation tx_empty. The generic implementation will be used for all sub-drivers

[PATCH v2 2/8] USB: serial: add generic wait_until_sent implementation

2013-05-08 Thread Johan Hovold
Add generic wait_until_sent implementation which polls for empty hardware buffers using the new port-operation tx_empty. The generic implementation will be used for all sub-drivers that implement tx_empty but does not define wait_until_sent. Signed-off-by: Johan Hovold jhov...@gmail.com --- v2

Re: [PATCH v3 2/3] USB: serial: make minor allocation dynamic

2013-06-08 Thread Johan Hovold
) return_serial(serial); if (serial-attached serial-type-release) All three patches look good otherwise. The port-number disambiguation was indeed long overdue. Feel free to add Reviewed-by: Johan Hovold jhov...@gmail.com Thanks, Johan -- To unsubscribe from this list: send the line

Re: Regression: ftdi_sio is slow (since Wed Oct 10 15:05:06 2012)

2013-05-04 Thread Johan Hovold
On Sat, May 04, 2013 at 01:50:42AM +0400, Stas Sergeev wrote: 04.05.2013 00:34, Greg KH пишет: On Fri, May 03, 2013 at 10:27:18PM +0400, Stas Sergeev wrote: 03.05.2013 21:16, Greg KH пишет: [...] There's no guarantee as to how long select or an ioctl will take, and now that we have

Re: Regression: ftdi_sio is slow (since Wed Oct 10 15:05:06 2012)

2013-05-05 Thread Johan Hovold
On Sat, May 04, 2013 at 07:39:57AM -0400, Peter Hurley wrote: On 05/04/2013 07:15 AM, Johan Hovold wrote: On Sat, May 04, 2013 at 01:50:42AM +0400, Stas Sergeev wrote: 04.05.2013 00:34, Greg KH пишет: On Fri, May 03, 2013 at 10:27:18PM +0400, Stas Sergeev wrote: 03.05.2013 21:16, Greg KH

[PATCH 6/7] USB: ti_usb_3410_5052: fix chars_in_buffer overhead

2013-05-05 Thread Johan Hovold
in chars_in_buffer) without breaking tty_wait_until_sent (used by, for example, tcdrain, tcsendbreak and close). Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/ti_usb_3410_5052.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/usb

[PATCH 3/7] USB: ftdi_sio: clean up get_modem_status

2013-05-05 Thread Johan Hovold
Use usb-serial port rather than tty as argument to get_modem_status. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/ftdi_sio.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index

[PATCH 0/7] USB: serial: add wait_until_sent-support

2013-05-05 Thread Johan Hovold
are also currently checked in chars_in_buffer in io_ti (since 3.8) and ti_usb_3410_5052 (in 3.10). Note that simply removing the hardware-buffer checks (e.g. for the stable trees) would break tty_wait_until_sent, which is used, for instance, by tcdrain, tcsendbreak, and close. Johan Johan Hovold (7

[PATCH 1/7] USB: serial: add wait_until_sent operation

2013-05-05 Thread Johan Hovold
Add wait_until_sent operation which can be used to wait for hardware buffers to drain. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/usb-serial.c | 17 + include/linux/usb/serial.h | 1 + 2 files changed, 18 insertions(+) diff --git a/drivers/usb

[PATCH 2/7] USB: serial: add generic wait_until_sent implementation

2013-05-05 Thread Johan Hovold
Add generic wait_until_sent implementation which polls for empty hardware buffers using the new port-operation tx_empty. The generic implementation will be used for all sub-drivers that implement tx_empty but does not define wait_until_sent. Signed-off-by: Johan Hovold jhov...@gmail.com

[PATCH 5/7] USB: io_ti: fix chars_in_buffer overhead

2013-05-05 Thread Johan Hovold
) without breaking tty_wait_until_sent (used by, for example, tcdrain, tcsendbreak and close). Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/io_ti.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/usb/serial/io_ti.c b/drivers

[PATCH 7/7] USB: serial: clean up chars_in_buffer

2013-05-05 Thread Johan Hovold
No need to grab disconnect mutex in chars_in_buffer now that no sub-driver is or should be querying hardware buffers anymore. (They should use wait_until_sent.) Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/usb-serial.c | 11 ++- 1 file changed, 2 insertions(+), 9

[PATCH 4/7] USB: ftdi_sio: fix chars_in_buffer overhead

2013-05-05 Thread Johan Hovold
) without breaking tty_wait_until_sent (used by, for example, tcdrain, tcsendbreak and close). Reported-by: Stas Sergeev s...@list.ru Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/ftdi_sio.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git

Re: [RFC] raise the maximum number of usb-serial devices to 512

2013-06-04 Thread Johan Hovold
On Mon, Jun 03, 2013 at 07:49:59PM -0700, Greg KH wrote: On Mon, May 27, 2013 at 02:28:51PM +0200, Bjørn Mork wrote: But, IMHO, a nicer approach would be to make the allocation completely dynamic, using e.g. the idr subsystem. Static tables are always feel like straight jackets to me, no

Re: [PATCH 1/3] USB: serial: ports: add minor and port number

2013-06-06 Thread Johan Hovold
On Wed, Jun 05, 2013 at 10:55:39AM -0700, Greg KH wrote: From: Greg Kroah-Hartman gre...@linuxfoundation.org The usb_serial_port structure had the number field, which was the minor number for the port, which almost no one really cared about. They really wanted the number of the port within

[PATCH] USB: whiteheat: fix broken port configuration

2013-06-06 Thread Johan Hovold
When configuring the port (e.g. set_termios) the port minor number rather than the port number was used in the request (and they only coincide for minor number 0). Cc: sta...@vger.kernel.org Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/whiteheat.c | 2 +- 1 file changed

  1   2   3   4   5   6   7   8   9   10   >