Re: [PATCH 2.6.21-rc4] kernel/exit: Fix a comment and code contradiction

2007-03-17 Thread Johannes Weiner
Hi, On Sat, Mar 17, 2007 at 08:21:32AM +0200, Ahmed S. Darwish wrote: Comment in release_task() claims that group leader's parent process is signalled only if it desires so, which is not true. AFAIS, `if it wants notification' means, it does not ignore its children via SIG_IGN als handler for

ACPI initialization failure with v2.6.21-rc4

2007-03-18 Thread Johannes Weiner
Hi, The kernel version mentioned in the subject won't boot because the ACPI system does not get initialized; the system freezes on an outb() in acpi_os_write_port() i.e. it does not do anything anymore and just hangs. Here is the `stack trace' I managed to extract via debugging output:

ACPI initialization failure with v2.6.21-rc4

2007-03-18 Thread Johannes Weiner
[resend due to wrong mail headers last time] Hi, The kernel version mentioned in the subject won't boot because the ACPI system does not get initialized; the system freezes on an outb() in acpi_os_write_port() i.e. it does not do anything anymore and just hangs. Here is the `stack trace' I

[PATCH] dmaenginge.c: class_device_register() return value

2007-03-19 Thread Johannes Weiner
that memory is allocated for chan-local in dma_async_device_register() but I couldn't find where it is released again. I am quite new to this all, please give me feedback! Signed-off-by: Johannes Weiner [EMAIL PROTECTED] diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c index

[PATCH] Documentation/sysrq.txt: added short description for 'Q' (timerlist)

2007-03-19 Thread Johannes Weiner
Hi, I added the 'Q' to list. A short description in the `Ok, so what can I use them for'-section, on when or why to use it would be nice! Signed-off-by: Johannes Weiner [EMAIL PROTECTED] diff --git a/Documentation/sysrq.txt b/Documentation/sysrq.txt index 452c0f1..d43aa9d 100644

Re: reboot swsusp mode leaves moon icon blinking

2007-03-20 Thread Johannes Weiner
Hi, On Tue, Mar 20, 2007 at 01:32:45PM +0100, Pavel Machek wrote: Date: Tue, 20 Mar 2007 13:32:45 +0100 From: Pavel Machek [EMAIL PROTECTED] To: Rafael J. Wysocki [EMAIL PROTECTED], kernel list linux-kernel@vger.kernel.org Cc: Andrew Morton [EMAIL PROTECTED] Subject: reboot swsusp

Re: reboot swsusp mode leaves moon icon blinking

2007-03-20 Thread Johannes Weiner
Hi, On Tue, Mar 20, 2007 at 07:01:21PM +0100, Pavel Machek wrote: What does the reboot swsusp mean? echo reboot ...disk. Thank you. I am having this (or a similar problem): echo shutdown /sys/power/disk; echo disk /sys/power/state Yep, that's duplicate. Try patch below. I

Re: [PATCH 2/7] Initial implementation of the trec driver and include files

2007-03-21 Thread Johannes Weiner
Hi, On Tue, Mar 20, 2007 at 11:47:35PM -0700, Wink Saville wrote: --- /dev/null +++ b/drivers/trec/trec.c [...] +struct trec_dev_struct +{ + struct cdevcdev; /* Character device structure */ Your patch has broken lines where there shouldn't be any.

Re: [PATCH 2/7] Initial implementation of the trec driver and include files

2007-03-21 Thread Johannes Weiner
Hi, On Wed, Mar 21, 2007 at 09:22:39AM +0100, Johannes Weiner wrote: Your patch has broken lines where there shouldn't be any. I mean, the attached patch. This is probably not an error in the patch but in the way of posting it. +static int snprint_address(char *b, int bsize, unsigned long

Re: [PATCH 2/7] Initial implementation of the trec driver and include files

2007-03-21 Thread Johannes Weiner
Hi, On Wed, Mar 21, 2007 at 09:49:12AM -0700, Wink Saville wrote: Please don't use camel-case - in general. Would p_next, p_cur and p_end be OK? I think it's generally disliked. Quoting Documentation/CodingStyle: ``Encoding the type of a function into the name (so-called Hungarian

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-21 Thread Johannes Weiner
RB_EMPTY_ROOT() as last call in this loop does not trigger? Did I even get the right place on where the NULL pointer dereference happens? :) =Hannes Signed-off-by: Johannes Weiner [EMAIL PROTECTED] diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index b6491c0..ca84f0b 100644 --- a/block/cfq

Re: [PATCH] - fix compile warning: `found' might be used uninitialized in this function

2007-03-21 Thread Johannes Weiner
Hi, On Thu, Mar 22, 2007 at 12:48:05AM +0100, roland wrote: fs/block_dev.c: In function `bd_claim_by_kobject': fs/block_dev.c:953: warning: `found' might be used uninitialized in this function found actually _is_ used uninitialized if the call to bd_claim() returns anything but 0. Thank

Re: [PATCH] - fix compile warning: `found' might be used uninitialized in this function

2007-03-22 Thread Johannes Weiner
Hi, On Thu, Mar 22, 2007 at 12:45:40AM -0800, Andrew Morton wrote: On Thu, Mar 22, 2007 at 12:48:05AM +0100, roland wrote: fs/block_dev.c: In function `bd_claim_by_kobject': fs/block_dev.c:953: warning: `found' might be used uninitialized in this function found actually _is_ used

Re: [PATCH] - fix compile warning: `found' might be used uninitialized in this function

2007-03-22 Thread Johannes Weiner
Hi, On Thu, Mar 22, 2007 at 05:26:04PM +0100, Johannes Weiner wrote: The code in there is irksome - it'd be nice to find some way of restructuring it to make it less obscure, and to kill that warning. Functionscope or filescope? ;) Oh well... I think the latter. I wil clean it up

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-22 Thread Johannes Weiner
Hi, On Wed, Mar 21, 2007 at 08:04:00PM +0100, Johannes Weiner wrote: Did I even get the right place on where the NULL pointer dereference happens? :) No, I did not. Sorry for the noise. =Hannes - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-22 Thread Johannes Weiner
Hi, On Thu, Mar 22, 2007 at 07:42:35PM +0100, Jens Axboe wrote: diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index b6491c0..ca84f0b 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c @@ -961,8 +961,8 @@ __cfq_dispatch_requests(struct cfq_data *cfqd, struct cfq_queue

[PATCH] Catch kmalloc failure in kmem_cache_init() (was: [QUESTION] check for mem in slab)

2007-04-02 Thread Johannes Weiner
. Patch attached. Signed-off-by: Johannes Weiner [EMAIL PROTECTED] diff --git a/mm/slab.c b/mm/slab.c index 57f7aa4..6d7e486 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -1512,6 +1512,7 @@ void __init kmem_cache_init(void) struct array_cache *ptr; ptr = kmalloc(sizeof

[PATCH] Catch kmalloc() failure in kmem_cache_init()

2007-04-02 Thread Johannes Weiner
Hi, This patch makes kmem_cache_init() trigger a BUG when the calls to kmalloc() fail. Altough the kernel would not boot anyway on failure, this adds some clarity to the code. Signed-off-by: Johannes Weiner [EMAIL PROTECTED] diff --git a/mm/slab.c b/mm/slab.c index 57f7aa4..6d7e486 100644

Re: [RFC, PATCH] watchdog on gpio

2008-01-14 Thread Johannes Weiner
Hi, Mike Frysinger [EMAIL PROTECTED] writes: wonder if we could design a printk designed for __init functions to address this in a clean fashion. #define init_printk(fmt, __VA_ARGS__) \ do { \ static const __init char __fmt[] = fmt; \ printk(__fmt , ## __VA_ARGS__); \ } while

printk-wrapper with sectionized string constants [was: Re: [RFC, PATCH] watchdog on gpio]

2008-01-14 Thread Johannes Weiner
Hi, Mike Frysinger [EMAIL PROTECTED] writes: How about: #define init_printk(fmt, args...) ({\ static const __init char __fmt[] = fmt; \ printk(__fmt, args);\ }) Now it returns the printk result. i wasnt really worried about that ... i was

Re: OOM killer problem - how to read the kernel log?

2007-11-10 Thread Johannes Weiner
Hi, On Fri, Nov 09, 2007 at 10:35:14PM +0100, Tobias Brox wrote: We're running 32 bits linux, maybe it would help to upgrade to 64 bits? Although you can address up to 64GB of RAM with PAE, the address space of directly accessible memory is still at 32bit (4GB) and access to higher memory costs

Re: cpuinfo_cur_freq always max

2007-12-17 Thread Johannes Weiner
Hi Steve, Stephen Clark [EMAIL PROTECTED] writes: But with 2.6.23.8-34.fc7 /sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_cur_freq is always the max cpu speed of 1826000. While cpuinfo_cur_freq is the max 1826000 /proc/cpuinfo relflects the correct speed when idle of 996000 Which governor

Re: cpuinfo_cur_freq always max

2007-12-17 Thread Johannes Weiner
Hi, Stephen Clark [EMAIL PROTECTED] writes: Which governor are you using? ondemand? Not sure - but the only thing that is changed is the kernel - if I go back to 2.6.23.1 it works correctly. Have a look at /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor Hannes PS: Steve,

Re: [RFC/PATCH 1/4] pci: Add pci_enable_device_{io,mem} intefaces

2007-12-17 Thread Johannes Weiner
Hi Benjamin, Benjamin Herrenschmidt [EMAIL PROTECTED] writes: --- linux-work.orig/drivers/pci/pci.c 2007-12-18 09:37:56.0 +1100 +++ linux-work/drivers/pci/pci.c 2007-12-18 09:38:25.0 +1100 [...] +int pci_enable_device_io(struct pci_dev *dev) +{ + int err; +

Re: cpuinfo_cur_freq always max

2007-12-18 Thread Johannes Weiner
Hi, Stephen Clark [EMAIL PROTECTED] writes: userspace Please supply the full dmesg output on the non-working kernel the corresponding .config (or /proc/config.gz). Added Dave to CC. Hannes -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: RFC: permit link(2) to work across --bind mounts ?

2007-12-19 Thread Johannes Weiner
Hi Al, Al Viro [EMAIL PROTECTED] writes: On Wed, Dec 19, 2007 at 02:43:26PM +0100, Bodo Eggert wrote: Since nobody knows about this security boundary and everybody knows about the annoying can't link across bind-mountpoints bug, ... how about teaching people to RTFM? Starting, perhaps,

Re: 2.6.24-rc5-git7: Reported regressions from 2.6.23

2007-12-21 Thread Johannes Weiner
seen a discussion about this particular problem, so if I missed something, please tell me and consider this mail obsolete. Hannes From: Johannes Weiner [EMAIL PROTECTED] Date: Tue, 18 Dec 2007 13:03:49 +0100 Subject: [PATCH] cpufreq: Initialise default governor before use When the cpufreq

Re: 2.6.24-rc5-git7: Reported regressions from 2.6.23

2007-12-21 Thread Johannes Weiner
Hi, Michael Tokarev [EMAIL PROTECTED] writes: By the way, is there any real need to specify default governor at a compile time in the first place? Performance governor (which was the only default so far) is a very simple one (not large to consider its size effects for embedded systems for

Re: 2.6.24-rc5-git7: Reported regressions from 2.6.23

2007-12-21 Thread Johannes Weiner
btw, here is the oops as I pencil-copied it: NULL pointer deref EIP: wq_per_cpu queue_delayed_work_on() do_dbs_timer() cpufreq_governor_dbs() __cpufreq_governor() __cpufreq_set_policy()

Re: Patch: Hide process info from other users/users not in my group

2007-11-20 Thread Johannes Weiner
Hi Daniel, On Tue, Nov 20, 2007 at 11:34:20AM +0100, Daniel Reichelt wrote: # diff -Naur linux-2.6.23.8/fs/Kconfig linux-2.6.23.8-dhr/fs/Kconfig --- linux-2.6.23.8/fs/Kconfig 2007-11-16 19:14:27.0 +0100 +++ linux-2.6.23.8-dhr/fs/Kconfig 2007-11-20 11:33:18.0 +0100 @@

Re: Lnux 2.6.24-rc5

2007-12-12 Thread Johannes Weiner
Hi, Oleksandr Natalenko [EMAIL PROTECTED] writes: And... Linus, why do yo make mistakes in headers of announces :)? Not first time. This is the effect of a plugin for the Linus-bot written in Lisp. It's an output-scrambler that makes him act more human. Hannes -- To unsubscribe

Re: [PATCH][KJ] 8250: remove unnecessary variable tmout from wait_for_xmitr()

2007-12-13 Thread Johannes Weiner
. How about the following, totally untested, solution? This converts the function to use more common timeout-loop constructs, gets rid of the shadowed variable and localises another variable even more! Hooray! Hannes Signed-off-by: Johannes Weiner [EMAIL PROTECTED] --- drivers/serial

Re: [PATCH] Option to disable AMD C1E (allows dynticks to work)

2007-12-13 Thread Johannes Weiner
Hi, Eduard-Gabriel Munteanu [EMAIL PROTECTED] writes: diff --git a/arch/x86/kernel/setup_64.c b/arch/x86/kernel/setup_64.c index 30d94d1..15556a0 100644 --- a/arch/x86/kernel/setup_64.c +++ b/arch/x86/kernel/setup_64.c @@ -583,6 +583,17 @@ static void __init amd_detect_cmp(struct

Re: [RFC PATCH 2/6] Preempt-RCU: Reorganize RCU code into rcuclassic.c and rcupdate.c

2007-12-14 Thread Johannes Weiner
Hi, Gautham R Shenoy [EMAIL PROTECTED] writes: diff --git a/kernel/rcuclassic.c b/kernel/rcuclassic.c new file mode 100644 index 000..11c16aa --- /dev/null +++ b/kernel/rcuclassic.c +/** + * call_rcu - Queue an RCU callback for invocation after a grace period. + * @head: structure to

Re: [RFC] [patch 1/2] add non_init_kernel_text_address

2007-12-14 Thread Johannes Weiner
Hi, Srinivasa Ds [EMAIL PROTECTED] writes: Forgot to change non_init_core_kernel_text() to regular_core_kernel_text(). Resending the patch. [...] This patch creates non_init_kernel_text_address() to identify non_init text area. You still refer to the old name here :) How about

[PATCH] cpufreq: Default governor initialisation before use

2007-12-16 Thread Johannes Weiner
Ensure that the selected default cpufreq governor is initialised before used by the cpufreq driver on boot by using fs_initcall() instead of module_init(). Signed-off-by: Johannes Weiner [EMAIL PROTECTED] --- On boot, speedstep_init() calls into cpufreq_gov_dbs(). The driver has not yet been

Re: [PATCH 00/31] numa/core patches

2012-10-30 Thread Johannes Weiner
On Tue, Oct 30, 2012 at 02:29:25PM +0800, Zhouping Liu wrote: On 10/29/2012 01:56 AM, Johannes Weiner wrote: On Fri, Oct 26, 2012 at 11:08:00AM +0200, Peter Zijlstra wrote: On Fri, 2012-10-26 at 17:07 +0800, Zhouping Liu wrote: [ 180.918591] RIP: 0010:[8118c39a] [8118c39a

Re: [PATCH RFC] mm,vmscan: only evict file pages when we have plenty

2012-10-31 Thread Johannes Weiner
On Tue, Oct 30, 2012 at 02:42:04PM -0400, Rik van Riel wrote: If we have more inactive file pages than active file pages, we skip scanning the active file pages alltogether, with the idea that we do not want to evict the working set when there is plenty of streaming IO in the cache.

Re: [PATCH v3 1/6] memcg: split mem_cgroup_force_empty into reclaiming and reparenting parts

2012-10-31 Thread Johannes Weiner
to their callers to make to code easier. This patch doesn't have any functional changes. Signed-off-by: Michal Hocko mho...@suse.cz Reviewed-by: Tejun Heo t...@kernel.org Acked-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH v3 2/6] memcg: root_cgroup cannot reach mem_cgroup_move_parent

2012-10-31 Thread Johannes Weiner
have to bother with the root cgroup and it can assume it can always move charges upwards. Signed-off-by: Michal Hocko mho...@suse.cz Reviewed-by: Tejun Heo t...@kernel.org Acked-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] hugetlb: do not use vma_hugecache_offset for vma_prio_tree_foreach

2012-09-26 Thread Johannes Weiner
On Mon, Aug 13, 2012 at 03:55:41PM +0200, Michal Hocko wrote: 0c176d5 (mm: hugetlb: fix pgoff computation when unmapping page from vma) fixed pgoff calculation but it has replaced it by vma_hugecache_offset which is not approapriate for offsets used for vma_prio_tree_foreach because that one

Re: [PATCH v3 04/13] kmem accounting basic infrastructure

2012-09-26 Thread Johannes Weiner
On Thu, Sep 27, 2012 at 12:02:14AM +0400, Glauber Costa wrote: On 09/26/2012 11:56 PM, Tejun Heo wrote: Hello, On Wed, Sep 26, 2012 at 11:46:37PM +0400, Glauber Costa wrote: Besides not being part of cgroup core, and respecting very much both cgroups' and basic sanity properties, kmem

[patch 0/2] memcg fixups that fell through cracks in 3.5

2012-10-04 Thread Johannes Weiner
Hi Andrew, an older version of mm: memcg: count pte references from every member of the reclaimed hierarchy patch made it into the 3.5 (c3ac9a8ade65ccbfd145fbff895ae8d8d62d09b0) by accident and I didn't notice until just now. #1 is a fixup on top, tagged for 3.5-stable. #2 is a cleanup you

[patch 2/2] mm: memcg: clean up mm_match_cgroup() signature

2012-10-04 Thread Johannes Weiner
It really should return a boolean for match/no match. And since it takes a memcg, not a cgroup, fix that parameter name as well. Signed-off-by: Johannes Weiner han...@cmpxchg.org Acked-by: Michal Hocko mho...@suse.cz --- include/linux/memcontrol.h | 14 +++--- 1 file changed, 7

[patch 1/2] mm: memcontrol: handle potential crash when rmap races with task exit

2012-10-04 Thread Johannes Weiner
page_referenced() counts only references of mm's that are associated with the memcg hierarchy that is being reclaimed. However, if it races with the owner of the mm exiting, mm-owner may be NULL. Don't crash, just ignore the reference. Signed-off-by: Johannes Weiner han...@cmpxchg.org Cc: sta

Re: [patch 1/2] mm: memcontrol: handle potential crash when rmap races with task exit

2012-10-04 Thread Johannes Weiner
On Thu, Oct 04, 2012 at 08:49:58PM +0200, Michal Hocko wrote: On Thu 04-10-12 14:09:16, Johannes Weiner wrote: page_referenced() counts only references of mm's that are associated with the memcg hierarchy that is being reclaimed. However, if it races with the owner of the mm exiting, mm

Re: [PATCH v3 12/13] execute the whole memcg freeing in rcu callback

2012-10-05 Thread Johannes Weiner
On Thu, Oct 04, 2012 at 02:53:13PM +0400, Glauber Costa wrote: On 10/01/2012 05:27 PM, Michal Hocko wrote: On Tue 18-09-12 18:04:09, Glauber Costa wrote: A lot of the initialization we do in mem_cgroup_create() is done with softirqs enabled. This include grabbing a css id, which holds

Re: [tip:numa/core] sched/numa/mm: Improve migration

2012-10-19 Thread Johannes Weiner
On Thu, Oct 18, 2012 at 10:05:39AM -0700, tip-bot for Peter Zijlstra wrote: Commit-ID: 713f937655c4b15131b5a0eae4610918a4febe17 Gitweb: http://git.kernel.org/tip/713f937655c4b15131b5a0eae4610918a4febe17 Author: Peter Zijlstra a.p.zijls...@chello.nl AuthorDate: Fri, 12 Oct 2012

Re: [PATCH] mm: Simplify for_each_populated_zone()

2012-10-19 Thread Johannes Weiner
On Fri, Oct 19, 2012 at 04:25:47PM +0530, Srivatsa S. Bhat wrote: Move the check for populated_zone() to the control statement of the 'for' loop and get rid of the odd looking if/else block. Signed-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com --- include/linux/mmzone.h |

Re: [PATCH] memcg: oom: fix totalpages calculation for memory.swappiness==0

2012-10-11 Thread Johannes Weiner
-by: David Rientjes rient...@google.com Cc: stable [3.5+] I also don't think it's hackish, the limit depends very much on whether reclaim can swap, so it's natural that swappiness shows up here. Acked-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list: send the line

Re: [PATCH v3] mm: thp: Set the accessed flag for old pages on access fault.

2012-10-25 Thread Johannes Weiner
not result in a CoW update the access flags for the faulting pmd. Cc: Chris Metcalf cmetc...@tilera.com Cc: Kirill A. Shutemov kir...@shutemov.name Cc: Andrea Arcangeli aarca...@redhat.com Signed-off-by: Will Deacon will.dea...@arm.com Acked-by: Johannes Weiner han...@cmpxchg.org Ok chaps

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Johannes Weiner
On Wed, Oct 24, 2012 at 09:36:27PM -0700, Hugh Dickins wrote: On Wed, 24 Oct 2012, Dave Jones wrote: Machine under significant load (4gb memory used, swap usage fluctuating) triggered this... WARNING: at mm/shmem.c:1151 shmem_getpage_gfp+0xa5c/0xa70() Pid: 29795, comm: trinity-child4

Re: [PATCH 00/31] numa/core patches

2012-10-28 Thread Johannes Weiner
to fold it into #31. Signed-off-by: Johannes Weiner han...@cmpxchg.org --- diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 5c30a14..0d7ebd3 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -801,8 +801,6 @@ void do_huge_pmd_numa_page(struct mm_struct *mm, struct vm_area_struct *vma

Re: [PATCH] sched, numa, mm: Add memcg support to do_huge_pmd_numa_page()

2012-10-29 Thread Johannes Weiner
Subject: sched, numa, mm: Add memcg support to do_huge_pmd_numa_page() From: Johannes Weiner han...@cmpxchg.org Date: Thu Oct 25 12:49:51 CEST 2012 Add memory control group support to hugepage migration. Signed-off-by: Johannes Weiner han...@cmpxchg.org Tested-by: Zhouping Liu z

Re: [PATCH] mm: Fix calculation of dirtyable memory

2012-11-12 Thread Johannes Weiner
with v3.2-4896-gab8fabd (which means that we should include Cc: sta...@kernel.org for 3.3+). The diff itself looks good to me, thanks again: Acked-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 1/4] bootmem: remove not implemented function call, bootmem_arch_preferred_node()

2012-11-12 Thread Johannes Weiner
On Tue, Nov 13, 2012 at 01:31:52AM +0900, Joonsoo Kim wrote: There is no implementation of bootmeme_arch_preferred_node() and call for this function will makes compile-error. So, remove it. Signed-off-by: Joonsoo Kim js1...@gmail.com Acked-by: Johannes Weiner han...@cmpxchg.org

Re: [PATCH 2/4] avr32, kconfig: remove HAVE_ARCH_BOOTMEM

2012-11-12 Thread Johannes Weiner
On Tue, Nov 13, 2012 at 01:31:53AM +0900, Joonsoo Kim wrote: Now, there is no code for CONFIG_HAVE_ARCH_BOOTMEM. So remove it. Cc: Haavard Skinnemoen hskinnem...@gmail.com Cc: Hans-Christian Egtvedt egtv...@samfundet.no Signed-off-by: Joonsoo Kim js1...@gmail.com Acked-by: Johannes Weiner

Re: [PATCH 3/4] bootmem: remove alloc_arch_preferred_bootmem()

2012-11-12 Thread Johannes Weiner
directly return kmalloc*'s return value. Signed-off-by: Joonsoo Kim js1...@gmail.com Acked-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 4/4] bootmem: fix wrong call parameter for free_bootmem()

2012-11-12 Thread Johannes Weiner
() with virtual address. So fix them. Cc: Andrew Morton a...@linux-foundation.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Signed-off-by: Joonsoo Kim js1...@gmail.com Acked-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 4/4] bootmem: fix wrong call parameter for free_bootmem()

2012-11-12 Thread Johannes Weiner
it's applied to memory from kzalloc(). Ben? Signed-off-by: Johannes Weiner han...@cmpxchg.org --- diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c index 7d5a6b4..1963680 100644 --- a/drivers/macintosh/smu.c +++ b/drivers/macintosh/smu.c @@ -565,7 +565,7 @@ int __init smu_init (void

Re: [PATCH 4/4] bootmem: fix wrong call parameter for free_bootmem()

2012-11-12 Thread Johannes Weiner
On Mon, Nov 12, 2012 at 08:10:27PM -0500, Johannes Weiner wrote: On Tue, Nov 13, 2012 at 01:31:55AM +0900, Joonsoo Kim wrote: It is somehow strange that alloc_bootmem return virtual address and free_bootmem require physical address. Anyway, free_bootmem()'s first parameter should

Re: [PATCH 4/4] bootmem: fix wrong call parameter for free_bootmem()

2012-11-12 Thread Johannes Weiner
this look? Much better. How about this in addition? Signed-off-by: Johannes Weiner han...@cmpxchg.org --- diff --git a/include/linux/bootmem.h b/include/linux/bootmem.h index 7b74452..b519cb2 100644 --- a/include/linux/bootmem.h +++ b/include/linux/bootmem.h @@ -49,7 +49,7 @@ extern unsigned long

Re: [PATCH 21/31] sched, numa, mm: Implement THP migration

2012-11-13 Thread Johannes Weiner
...@chello.nl Add THP migration for the NUMA working set scanning fault case. It uses the page lock to serialize. No migration pte dance is necessary because the pte is already unmapped when we decide to migrate. Signed-off-by: Peter Zijlstra a.p.zijls...@chello.nl Cc: Johannes Weiner han

Re: [PATCH v3 3/6] memcg: Simplify mem_cgroup_force_empty_list error handling

2012-11-13 Thread Johannes Weiner
On Tue, Oct 30, 2012 at 11:35:59AM +0100, Michal Hocko wrote: On Mon 29-10-12 15:00:22, Andrew Morton wrote: On Mon, 29 Oct 2012 17:58:45 +0400 Glauber Costa glom...@parallels.com wrote: + * move charges to its parent or the root cgroup if the group has no + * parent (aka

Re: [PATCH v3 4/6] cgroups: forbid pre_destroy callback to fail

2012-11-13 Thread Johannes Weiner
in pre_destroy) so we have to move it after the lock is released. Changes since v1 - Li Zefan pointed out that mem_cgroup_pre_destroy cannot be called with cgroup_lock held Signed-off-by: Michal Hocko mho...@suse.cz Acked-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list

Re: [PATCH] memory cgroup: update root memory cgroup when node is onlined

2012-10-18 Thread Johannes Weiner
On Thu, Oct 18, 2012 at 12:03:44PM -0700, Hugh Dickins wrote: On Tue, 16 Oct 2012, Wen Congyang wrote: At 09/14/2012 09:36 AM, Hugh Dickins Wrote: Description to be filled in later: would it be needed for -stable, or is onlining already broken in other ways that you're now fixing up?

[TRIVIAL PATCH] Remove unused variable in drivers/dma/ioatdma.c

2007-10-07 Thread Johannes Weiner
Hi, I found this in an `allyesconfig' build: CC drivers/dma/ioatdma.o drivers/dma/ioatdma.c: In function #ioat_dma_free_chan_resources#: drivers/dma/ioatdma.c:247: warning: unused variable #chanctrl# Hannes Signed-off-by: Johannes Weiner [EMAIL PROTECTED] diff --git

dtc_setup() used anywhere?

2007-10-07 Thread Johannes Weiner
Hi, The compiler warned me that dtc_setup() is unused in drivers/scsi/dtc.c:182. I do not see a call to it anywhere and no __setup() near to it. Am I missing something? Hannes -- 3BD8 AF56 11AF 205C 9DB6 B10F 76F1 0634 71A4 DCA0 - To unsubscribe from this list: send the line

[PATCH] __do_softirq() loop cleanup

2007-10-10 Thread Johannes Weiner
Hi, This changes __do_softirq() to use a C looping construct instead of simulating one by means of goto. Signed-off-by: Johannes Weiner [EMAIL PROTECTED] diff --git a/kernel/softirq.c b/kernel/softirq.c index 0f546dd..bacee6b 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@ -212,38

[PATCH 1/2] i386 memory initialization cleanup

2007-10-10 Thread Johannes Weiner
386 memory init cleanup -- prerequisites This patch fixes whitespace errors only. Signed-off-by: Johannes Weiner [EMAIL PROTECTED] --- arch/i386/mm/init.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/i386/mm/init.c b/arch/i386/mm

[PATCH 2/2] i386 memory initialization cleanup

2007-10-10 Thread Johannes Weiner
i386 memory init cleanup This patch improves code readability in the i386 memory initialization code by refactoring, removal of needless casts, fixing of line width exceedings, macro-inline function replacement, some comments and indentation correction. Signed-off-by: Johannes Weiner [EMAIL

Re: [PATCH] init: Fix printk format strings

2007-10-11 Thread Johannes Weiner
Hi, On Thu, Oct 11, 2007 at 08:17:02AM +0200, Vegard Nossum wrote: This makes sure printk format strings are string literals containing no more than a single line. Perhaps you should write _why_ one-line printk()s are even needed, with profound reasons instead of constantly talking about

Re: [PATCH] Cgroup: Fix memory accounting scalability in shrink_page_list

2012-07-20 Thread Johannes Weiner
| | | alloc_pages_current --- Signed-off-by: Tim Chen tim.c.c...@linux.intel.com Good one. Acked-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] swap: redirty page if page write fails on swap file

2013-04-17 Thread Johannes Weiner
to memory corruption when the page is eventually swapped back in. This patch sets the page dirty when direct_IO() fails. It fixes a memory corruption that happened while using swap-over-NFS. Signed-off-by: Jerome Marchand jmarc...@redhat.com Acked-by: Johannes Weiner han...@cmpxchg.org

Re: [PATCH] thp: fix huge zero page logic for page with pfn == 0

2013-04-17 Thread Johannes Weiner
-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [Bug fix PATCH v4] Reusing a resource structure allocated by bootmem

2013-04-18 Thread Johannes Weiner
On Thu, Apr 18, 2013 at 05:36:12PM +0900, Yasuaki Ishimatsu wrote: @@ -151,6 +162,39 @@ __initcall(ioresources_init); #endif /* CONFIG_PROC_FS */ +static void free_resource(struct resource *res) +{ + if (!res) + return; + + if (PageSlab(virt_to_head_page(res))) {

Re: [PATCH 02/10] mm: vmscan: Obey proportional scanning requirements for kswapd

2013-04-18 Thread Johannes Weiner
On Thu, Apr 11, 2013 at 08:57:50PM +0100, Mel Gorman wrote: @@ -1841,17 +1848,58 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc) lruvec, sc); } } + + if

Re: [PATCH 03/10] mm: vmscan: Flatten kswapd priority loop

2013-04-18 Thread Johannes Weiner
it is failing to reclaim any pages. To avoid infinite looping for high-order allocation requests kswapd will not reclaim for high-order allocations when it has reclaimed at least twice the number of pages as the allocation request. Signed-off-by: Mel Gorman mgor...@suse.de Acked-by: Johannes

Re: [PATCH 04/10] mm: vmscan: Decide whether to compact the pgdat based on reclaim progress

2013-04-18 Thread Johannes Weiner
: Acked-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 05/10] mm: vmscan: Do not allow kswapd to scan at maximum priority

2013-04-18 Thread Johannes Weiner
. Signed-off-by: Mel Gorman mgor...@suse.de Acked-by: Rik van Riel r...@redhat.com Reviewed-by: Michal Hocko mho...@suse.cz Acked-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH 06/10] mm: vmscan: Have kswapd writeback pages based on dirty pages encountered, not priority

2013-04-18 Thread Johannes Weiner
are being recycled before flusher threads can clean them and flags the zone so that kswapd will start writing pages until the zone is balanced. Signed-off-by: Mel Gorman mgor...@suse.de Acked-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 08/10] mm: vmscan: Have kswapd shrink slab only once per priority

2013-04-18 Thread Johannes Weiner
On Thu, Apr 11, 2013 at 08:57:56PM +0100, Mel Gorman wrote: If kswaps fails to make progress but continues to shrink slab then it'll either discard all of slab or consume CPU uselessly scanning shrinkers. This patch causes kswapd to only call the shrinkers once per priority. But the priority

Re: [PATCH 09/10] mm: vmscan: Check if kswapd should writepage once per pgdat scan

2013-04-18 Thread Johannes Weiner
per pgdat scan if kswapd should be writing pages. Signed-off-by: Mel Gorman mgor...@suse.de Reviewed-by: Michal Hocko mho...@suse.cz Acked-by: Rik van Riel r...@redhat.com Acked-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 10/10] mm: vmscan: Move logic from balance_pgdat() to kswapd_shrink_zone()

2013-04-18 Thread Johannes Weiner
-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [patch] mm, memcg: give exiting processes access to memory reserves

2013-04-03 Thread Johannes Weiner
oom killer exemption for TIF_MEMDIE tasks, now immediately granted for processes with pending SIGKILLs and those in the exit path, to be equivalent to what is done for the global oom killer. Signed-off-by: David Rientjes rient...@google.com Acked-by: Johannes Weiner han...@cmpxchg.org

[patch 1/5] mm: Try harder to allocate vmemmap blocks

2013-03-20 Thread Johannes Weiner
. Reported-and-tested-by: Bernhard Schmidt bernhard.schm...@lrz.de Reference: http://bugs.debian.org/699913 Signed-off-by: Ben Hutchings b...@decadent.org.uk Signed-off-by: Johannes Weiner han...@cmpxchg.org --- mm/sparse-vmemmap.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions

[patch 2/5] sparse-vmemmap: specify vmemmap population range in bytes

2013-03-20 Thread Johannes Weiner
is too coarse. Just translate the section range into bytes once in the generic sparse code, then pass byte ranges down the stack. Signed-off-by: Johannes Weiner han...@cmpxchg.org --- arch/arm64/mm/mmu.c | 13 + arch/ia64/mm/discontig.c | 7 +++ arch/powerpc/mm/init_64.c

[patch 5/5] x86-64: fall back to regular page vmemmap on allocation failure

2013-03-20 Thread Johannes Weiner
Memory hotplug can happen on a machine under load, memory shortness and fragmentation, so huge page allocations for the vmemmap are not guaranteed to succeed. Try to fall back to regular pages before failing the hotplug event completely. Signed-off-by: Johannes Weiner han...@cmpxchg.org

[patch 3/5] x86-64: remove dead debugging code for !pse setups

2013-03-20 Thread Johannes Weiner
No need to maintain addr_end and p_end when they are never actually read anywhere on !pse setups. Remove the dead code. Signed-off-by: Johannes Weiner han...@cmpxchg.org --- arch/x86/mm/init_64.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c

[patch 4/5] x86-64: use vmemmap_populate_basepages() for !pse setups

2013-03-20 Thread Johannes Weiner
We already have generic code to allocate vmemmap with regular pages, use it. Signed-off-by: Johannes Weiner han...@cmpxchg.org --- arch/x86/mm/init_64.c | 81 --- 1 file changed, 38 insertions(+), 43 deletions(-) diff --git a/arch/x86/mm/init_64.c

[patch 0/5] sparse-vmemmap: hotplug fixes cleanups

2013-03-20 Thread Johannes Weiner
Hotplug can happen at times when the memory situation is less than perfect to allocate huge pages for the vmemmap. This series makes the allocation try harder in patch #1. The remaining patches allow x86-64 to fall back to regular pages as a last resort before the hotplug event fails completely.

Re: [PATCH 01/10] mm: vmscan: Limit the number of pages kswapd reclaims at each priority

2013-03-21 Thread Johannes Weiner
than my hack that just always went with SWAP_CLUSTER_MAX, what with inter-zone LRU cycle time balancing and all. Acked-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 02/10] mm: vmscan: Obey proportional scanning requirements for kswapd

2013-03-21 Thread Johannes Weiner
On Sun, Mar 17, 2013 at 01:04:08PM +, Mel Gorman wrote: Simplistically, the anon and file LRU lists are scanned proportionally depending on the value of vm.swappiness although there are other factors taken into account by get_scan_count(). The patch mm: vmscan: Limit the number of pages

Re: [PATCH 02/10] mm: vmscan: Obey proportional scanning requirements for kswapd

2013-03-22 Thread Johannes Weiner
On Thu, Mar 21, 2013 at 06:02:38PM +, Mel Gorman wrote: On Thu, Mar 21, 2013 at 12:25:18PM -0400, Johannes Weiner wrote: On Sun, Mar 17, 2013 at 01:04:08PM +, Mel Gorman wrote: Simplistically, the anon and file LRU lists are scanned proportionally depending on the value

Re: [PATCH 02/10] mm: vmscan: Obey proportional scanning requirements for kswapd

2013-03-22 Thread Johannes Weiner
On Fri, Mar 22, 2013 at 06:25:56PM +, Mel Gorman wrote: On Fri, Mar 22, 2013 at 12:53:49PM -0400, Johannes Weiner wrote: So would it make sense to determine the percentage scanned of the type that we stop scanning, then scale the original goal of the remaining LRUs to that percentage

Re: [PATCH] memcg: fix memcg_cache_name() to use cgroup_name()

2013-03-27 Thread Johannes Weiner
On Wed, Mar 27, 2013 at 09:36:39AM +0100, Michal Hocko wrote: As cgroup supports rename, it's unsafe to dereference dentry-d_name without proper vfs locks. Fix this by using cgroup_name() rather than dentry directly. Also open code memcg_cache_name because it is called only from

Re: [PATCH] memcg: do not check for do_swap_account in mem_cgroup_{read,write,reset}

2013-03-27 Thread Johannes Weiner
, mem_cgroup_write and mem_cgroup_reset. Signed-off-by: Michal Hocko mho...@suse.cz Acked-by: Johannes Weiner han...@cmpxchg.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] memcg: fix memcg_cache_name() to use cgroup_name()

2013-03-27 Thread Johannes Weiner
On Wed, Mar 27, 2013 at 04:11:04PM +0100, Michal Hocko wrote: On Wed 27-03-13 10:58:25, Johannes Weiner wrote: On Wed, Mar 27, 2013 at 09:36:39AM +0100, Michal Hocko wrote: [...] + /* + * kmem_cache_create_memcg duplicates the given name and + * cgroup_name for this name requires

Re: mmap vs fs cache

2013-03-07 Thread Johannes Weiner
On Thu, Mar 07, 2013 at 04:43:12PM +0100, Jan Kara wrote: Added mm list to CC. On Tue 05-03-13 09:57:34, Howard Chu wrote: I'm testing our memory-mapped database code on a small VM. The machine has 32GB of RAM and the size of the DB on disk is ~44GB. The database library mmaps the

Re: mmap vs fs cache

2013-03-08 Thread Johannes Weiner
On Fri, Mar 08, 2013 at 07:00:55AM -0800, Howard Chu wrote: Chris Friesen wrote: On 03/08/2013 03:40 AM, Howard Chu wrote: There is no way that a process that is accessing only 30GB of a mmap should be able to fill up 32GB of RAM. There's nothing else running on the machine, I've killed or

  1   2   3   4   5   6   7   8   9   10   >