[PATCH] Include: blkdev: Removed duplicate 'struct request;' declaration.

2016-08-01 Thread John Pittman
In include/linux/blkdev.h duplicate declarations of the request struct exist. Cleaned up by removing the second, unneeded declaration. Signed-off-by: John Pittman <jpitt...@redhat.com> --- include/linux/blkdev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/blkdev.h b/i

[PATCH] Include: block: blk_types: Removed unneeded union from bio struct

2016-08-23 Thread John Pittman
In include/linux/blk_types.h a nameless, single member union exists within the bio struct. It seems to be left over from earlier, edited patches added in 3.18. Cleaned up by removing the union and the tab given to its contents. Signed-off-by: John Pittman <jpitt...@redhat.com> --- i

[PATCH] sd: Cleaned up comment references to @sdp argument explanation.

2017-01-12 Thread John Pittman
In sd.c there are two comment references to 'struct scsi_device *sdp' as an argument. One of the references has a typo and the other should be a reference to 'struct device *dev' instead. Fixed by correcting the typo in the first and changing the explanation in the second. Signed-off-by: John

[PATCH] sd: Cleaned up comment references to @sdp argument explanation.

2017-01-12 Thread John Pittman
In sd.c there are two comment references to 'struct scsi_device *sdp' as an argument. One of the references has a typo and the other should be a reference to 'struct device *dev' instead. Fixed by correcting the typo in the first and changing the explanation in the second. Signed-off-by: John

[PATCH] block: Change 'unsigned' to 'unsigned int' throughout block layer

2018-02-14 Thread John Pittman
of 'unsigned *' Fixed 64 total warnings. Signed-off-by: John Pittman <jpitt...@redhat.com> --- block/badblocks.c| 4 ++-- block/bio-integrity.c| 4 ++-- block/bio.c | 8 block/blk-core.c | 2 +- block/blk-lib.c

[PATCH] scsi: qla2xxx: Fix braces styling issue

2018-02-24 Thread John Pittman
In several spots throughout qla2xxx, checkpatch.pl has detected braces being used to contain single statements. Remove braces to maintain consistency with the guidelines presented in section 3 of coding-style.rst. Signed-off-by: John Pittman <jpitt...@redhat.com> --- drivers/scsi/q

[PATCH] dm cache: require io_mode cache feature selection to be mutually exclusive

2018-06-21 Thread John Pittman
check for more than one io_mode selection. Signed-off-by: John Pittman --- drivers/md/dm-cache-target.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c index ce14a3d..45e3bed 100644 --- a/drivers/

[PATCH] scsi: scsi_dh_alua: Correct comment for alua_alloc_pg()

2018-03-14 Thread John Pittman
In the comment for function alua_alloc_pg() the argument '@h' is mistakenly referred to. Fix this by replacing it with the correct argument reference, '@tpgs', and provide a short description. Signed-off-by: John Pittman <jpitt...@redhat.com> --- drivers/scsi/device_handler/scsi_dh_alua

[PATCH] scsi: scsi_dh_alua: Correct comment for alua_alloc_pg()

2018-03-14 Thread John Pittman
In the comment for function alua_alloc_pg() the argument '@h' is mistakenly referred to. Fix this by replacing it with the correct argument reference, '@tpgs', and provide a short description. Signed-off-by: John Pittman --- drivers/scsi/device_handler/scsi_dh_alua.c | 2 +- 1 file changed, 1

[PATCH] block: Change 'unsigned' to 'unsigned int' throughout block layer

2018-02-14 Thread John Pittman
of 'unsigned *' Fixed 64 total warnings. Signed-off-by: John Pittman --- block/badblocks.c| 4 ++-- block/bio-integrity.c| 4 ++-- block/bio.c | 8 block/blk-core.c | 2 +- block/blk-lib.c | 6 +++--- block/blk-merge.c

[PATCH] scsi: qla2xxx: Fix braces styling issue

2018-02-24 Thread John Pittman
In several spots throughout qla2xxx, checkpatch.pl has detected braces being used to contain single statements. Remove braces to maintain consistency with the guidelines presented in section 3 of coding-style.rst. Signed-off-by: John Pittman --- drivers/scsi/qla2xxx/qla_init.c | 21

[PATCH] dm cache: require io_mode cache feature selection to be mutually exclusive

2018-06-21 Thread John Pittman
check for more than one io_mode selection. Signed-off-by: John Pittman --- drivers/md/dm-cache-target.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c index ce14a3d..45e3bed 100644 --- a/drivers/

[PATCH] sd: Cleaned up comment references to @sdp argument explanation.

2017-01-12 Thread John Pittman
In sd.c there are two comment references to 'struct scsi_device *sdp' as an argument. One of the references has a typo and the other should be a reference to 'struct device *dev' instead. Fixed by correcting the typo in the first and changing the explanation in the second. Signed-off-by: John

[PATCH] sd: Cleaned up comment references to @sdp argument explanation.

2017-01-12 Thread John Pittman
In sd.c there are two comment references to 'struct scsi_device *sdp' as an argument. One of the references has a typo and the other should be a reference to 'struct device *dev' instead. Fixed by correcting the typo in the first and changing the explanation in the second. Signed-off-by: John

[PATCH] Include: block: blk_types: Removed unneeded union from bio struct

2016-08-23 Thread John Pittman
In include/linux/blk_types.h a nameless, single member union exists within the bio struct. It seems to be left over from earlier, edited patches added in 3.18. Cleaned up by removing the union and the tab given to its contents. Signed-off-by: John Pittman --- include/linux/blk_types.h | 5

[PATCH] Include: blkdev: Removed duplicate 'struct request;' declaration.

2016-08-01 Thread John Pittman
In include/linux/blkdev.h duplicate declarations of the request struct exist. Cleaned up by removing the second, unneeded declaration. Signed-off-by: John Pittman --- include/linux/blkdev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index

Re: [PATCH] block: recalculate segment count for multi-segment discard requests correctly

2021-02-08 Thread John Pittman
Hi Jens, when you get a moment, could you take a quick look at this one for ack? On Thu, Feb 4, 2021 at 11:49 AM Laurence Oberman wrote: > > On Thu, 2021-02-04 at 10:27 +0800, Ming Lei wrote: > > On Mon, Feb 01, 2021 at 11:48:50AM -0500, David Jeffery wrote: > > > When a stacked block device