I'm having a problem with a DS3234 SPI based RTC chip and rtc/hctosys.c on the
3.10.29 kernel of the RaspberryPi. I'm not sure this is a bug or not but
thought I'd ask. I've enabled the kernel config option for HCTOSYS which, on
boot, should set the system's date/time to the value read from the
On Wed, Jun 11, 2014 at 04:53:55PM -0700, John Stultz wrote:
On Wed, Jun 11, 2014 at 4:01 PM, John Whitmore arig...@gmail.com wrote:
I'm having a problem with a DS3234 SPI based RTC chip and rtc/hctosys.c on
the
3.10.29 kernel of the RaspberryPi. I'm not sure this is a bug
On Tue, May 26, 2015 at 09:53:07AM -0400, Austin S Hemmelgarn wrote:
On 2015-05-25 05:24, John Whitmore wrote:
On Sun, May 24, 2015 at 09:11:56PM -0400, valdis.kletni...@vt.edu wrote:
On Sun, 24 May 2015 11:32:36 +0100, John Whitmore said:
$ ./mkknlimg ../../linux/arch/arm/boot/zImage 3.18.0
I tried to subscribe to the RaspberryPi Kernel mailing list a few days ago but
I guess that my request has not been accepted as yet. Maybe it was missed so I
re-tried a moment ago. Since I can't get in there I thought I'd try
here. Apologies, bit of a panic.
So I'm trying to make a few changes to
On Sun, May 24, 2015 at 09:11:56PM -0400, valdis.kletni...@vt.edu wrote:
On Sun, 24 May 2015 11:32:36 +0100, John Whitmore said:
$ ./mkknlimg ../../linux/arch/arm/boot/zImage 3.18.0-can+.img
tail: +: invalid number of bytes
* Is this a valid kernel? In pass-through mode.
Looks like
Simple changes to block comments.
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/android/ion/ion.c | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/andro
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 273 +
1 file changed, 112 insertions(+), 161 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/iee
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 134 +++--
1 file changed, 42 insertions(+), 92 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/iee
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
I few other minor coding style issues.
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 42 ++
1 file changed, 19 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTPro
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/iee
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/iee
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index 13f1ee
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 148 ++---
1 file changed, 74 insertions(+), 74 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/iee
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 93 ++
1 file changed, 44 insertions(+), 49 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/iee
The file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c has a lot of
coding style issues, this will be the first of many small patches which clear
up some, if not all, of the problems with the file.
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/iee
There were a lot of coding style issues with this file, but I think I've
reduced the number down to mainly line length and CamelCase issues. I've put
it in 13 patches to, hopefully, make it easier to review, and see that I've
made no changes to functionality of the code, (I hope).
John
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/iee
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT
Coding style edit to clear the checkpatch.pl errors of the type:
ERROR: spaces required around that...
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 122 ++---
1 file changed, 61 insertions(+), 61 del
Coding style edit to clear the checkpatch.pl errors of the type:
ERROR: that open brace { should be on the previous line
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 197 -
1 file changed, 70 inse
Coding style edit to clear the checkpatch.pl check:
CHECK: Alignment should match open parenthesis
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff
Coding style edit to clear the checkpatch.pl check:
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/s
Spelling correction in comment: singal -> signal
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
Coding style edit to clear the checkpatch.pl Warnings:
WARNING: Block comments should align the * on each line
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 181 +++--
1 file changed, 97 insertions(+), 84 del
Coding style edit to clear the remaining checkpatch.pl errors:
ERROR: trailing whitespace
ERROR: space prohibited after that open parenthesis '('
ERROR: space required before the open brace '{'
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/iee
Coding style edit to clear the checkpatch.pl errors of the type:
ERROR: space required before the open parenthesis '('
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 176 ++---
1 file changed, 87 insertions(
Coding style edit to clear the checkpatch.pl check:
CHECK: spaces preferred around that '&'
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drive
Coding style edit to clear the checkpatch.pl warning:
WARNING: please, no spaces at the start of a line
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
Coding style edit to clear the checkpatch.pl error:
ERROR: space required after that close brace '}'
And balanced the brace of the same else statement:
CHECK: Unbalanced braces around else statement
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/iee
Coding style edit to clear the checkpatch.pl errors of the type:
ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16
1 file changed, 8 insertions
Coding style edit to clear the checkpatch.pl errors of the type:
ERROR: space prohibited before that ','
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/d
Second attempt at this commit, apologies for that.
Coding style changes to resolve some of the scripts/checkpatch.pl issues with
the file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c.
There remain line length and CamelCase issues unresolved in the file.
Coding style edit to clear the checkpatch.pl warnings:
WARNING: Prefer using '"%s...", __func__' to using '', this function's
name, in a string
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++--
1
Coding style edit to clear the checkpatch.pl warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/s
Coding style edit to clear the checkpatch.pl warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
Coding style edit to clear the checkpatch.pl check:
CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 13 -
1 file changed, 13 deletions(-)
diff
Coding style edit to clear the checkpatch.pl warning:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +++---
1 file changed, 3 insertions(+), 7 del
Coding style edit to clear the checkpatch.pl check:
CHECK: Please don't use multiple blank lines
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 24 --
1 file changed, 24 deletions(-)
diff --git a/d
Coding style edit to clear the checkpatch.pl check:
CHECK: Please use a blank line after function/struct/union/enum declarations
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 7 +++
1 file changed, 7 insertions(+)
diff
Coding style edit to clear the checkpatch.pl check:
CHECK: Lines should not end with a '('
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/s
Coding style edit to clear the checkpatch.pl check:
CHECK: Comparison to NULL could be written "!..."
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletion
Coding style edit to clear the checkpatch.pl check:
CHECK: Unnecessary parentheses around ...
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/d
Coding style edit to clear the checkpatch.pl warnings:
WARNING: void function return statements are not generally useful
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/d
Coding style edit to clear the checkpatch.pl check:
CHECK: spaces preferred around that 'x'
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/d
Coding style edit to clear the checkpatch.pl error:
ERROR: switch and case should be at the same indent
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 48 +++---
1 file changed, 24 insertions(+), 24 del
Coding style edit to clear the checkpatch.pl warning:
WARNING: void function return statements are not generally useful
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/d
There were numerous coding syle errors in this file where spaces were required
around operators.
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 126 ++---
1 file changed, 63 insertions(+), 63 deletions(-)
Correct the coding style of parenthesis and braces in various code blocks
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 217 -
1 file changed, 79 insertions(+), 138 deletions(-)
diff --git a/drivers/s
five patches with simple coding style changes to the file
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
The last two patches should probably have been combined as both dealt with the
addition or removal of blank lines, but I missed one style issue on the first
pass. In that situation I
Two switch statements had wrong indentation of 'case' options
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 48 +++---
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/rt
Coding style requires blank line after definitions and function definition,
blank lines removed. Correction of some indentation.
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 96 --
1 file chang
Missed these in the last pass. Coding style does not require blank line after
opening brace of a function.
Signed-off-by: John Whitmore <johnfwhitm...@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/s
Change comparison to NULL to better adhere to coding standard.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers
Return statments from void functions are not required by the coding standard.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging
Function HTIOTActIsDisableMCS14 contained spurious space at start of line.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers
Function HTIOTPeerDetermine used incorrect indentation in if statements.
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b
On Sun, Jun 03, 2018 at 02:28:35PM +0200, Greg KH wrote:
> On Sun, Jun 03, 2018 at 01:04:13PM +0100, John Whitmore wrote:
> > Signed-off-by: John Whitmore
> > ---
> > drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++--
> > 1 file changed, 6 insertion
Added spaces around various operators, as preferred by coding style.
Signed-off-by: John Whitmore
---
.../rtl8192u/ieee80211/rtl819x_HTProc.c | 22 +--
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b
Simple addition & removal of blank lines as required
Signed-off-by: John Whitmore
---
.../rtl8192u/ieee80211/rtl819x_HTProc.c | 64 +--
1 file changed, 16 insertions(+), 48 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/sta
Declaration of function was spread over three lines.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u
Version 6 : Sorry to send this out again but version 5 contained a little less
verbosity then required.
Again these are just some simple coding style changes to the file, so nothing
of importance.
Remove unneccessary parentheses - Coding Style change
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging
On Fri, Jun 08, 2018 at 03:18:51PM +0300, Dan Carpenter wrote:
> On Wed, Jun 06, 2018 at 12:40:03PM +0100, John Whitmore wrote:
> > @@ -1072,10 +1072,10 @@ void HTInitializeHTInfo(struct ieee80211_device
> > *ieee)
> > pHTInfo->CurrentAMPDUFactor
Remove unneccessary parentheses, and removed unnecessary (void *) cast
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b
On Wed, Jun 06, 2018 at 12:39:55PM +0100, John Whitmore wrote:
> Version 6 : Sorry to send this out again but version 5 contained a little less
> verbosity then required.
>
> Again these are just some simple coding style changes to the file, so nothing
> of importance.
>
Rec
Previous truncation of comment blocks to 80 character line length resulted in
some white space at endof line.
Signed-off-by: John Whitmore
---
.../rtl8192u/ieee80211/rtl819x_HTProc.c | 26 +--
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging
Removed the unrequired braces from single statement blocks - Coding Style.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b
Corrected the coding style of if statement.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211
Simple spelling correction.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index
Simple coding style changes to single file
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
Removed an extra indentation from the code of the various case options in a
switch statement.
Signed-off-by: John Whitmore
---
.../rtl8192u/ieee80211/rtl819x_HTProc.c | 30 +--
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8192u
Some of the comment blocks are commening out code so have been left for the
moment.
Signed-off-by: John Whitmore
---
.../rtl8192u/ieee80211/rtl819x_HTProc.c | 366 ++
1 file changed, 195 insertions(+), 171 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211
Where possible truncation of block comments to the 80 character length
prefered by the coding style.
Signed-off-by: John Whitmore
---
.../rtl8192u/ieee80211/rtl819x_HTProc.c | 157 +++---
1 file changed, 98 insertions(+), 59 deletions(-)
diff --git a/drivers/staging/rtl8192u
Changed a number of hard coded function names to use %s and __func__
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b
Correcton of a few block comments to comply with Coding Style.
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers
Simple addition & removal of blank lines as required
Signed-off-by: John Whitmore
---
.../rtl8192u/ieee80211/rtl819x_HTProc.c | 64 +--
1 file changed, 16 insertions(+), 48 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/sta
Added spaces around various operators, as preferred by coding style.
Signed-off-by: John Whitmore
---
.../rtl8192u/ieee80211/rtl819x_HTProc.c | 22 +--
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index 9cca4a8f1cf5
Function HTIOTPeerDetermine used incorrect indentation in if statements.
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b
Declaration of function was spread over three lines.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u
Another attempt at cleaning up some of the coding style issues with this file.
Change comparison to NULL to better adhere to coding standard.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers
Function HTIOTActIsDisableMCS14 contained spurious space at start of line.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers
Return statments from void functions are not required by the coding standard.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging
The file includes the file rtl819x_HT.h, which has already been included by
the previously included file ieee80211.h
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u
8192u/ieee80211/rtl819x_HT.h" as a first
step towards possibly merging the two files into one.
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HT.h | 190 +-
1 file changed, 93 insertions(+), 97 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee8
Chnaged logging statements to use %s and __func__ instead of hard coding the
function name in a string.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u
This patch set includes two fairly trivial patches but the third patch is
possibly controversial.
There are two files called rtl819x_HT.h
$ find -name rtl819x_HT.h -print
./drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
./drivers/staging/rtl8192e/rtl819x_HT.h
The two files are very similar but
On Mon, Jun 25, 2018 at 12:06:30PM +0300, Andy Shevchenko wrote:
> On Sun, Jun 24, 2018 at 6:34 PM, John Whitmore
> wrote:
> > Replaced memory initialising loop with memset, as suggested by Andy
> > Shevchenko
> >
>
> Suggested-by ?
>
Em, not sure how to res
On Sun, Jun 24, 2018 at 08:59:22AM -0700, Joe Perches wrote:
> Rather than doing individual patches for each line
> with a whitespace issue, I think it'd be better to
> do a single driver wide patch.
>
> Perhaps use a tool like:
>
> $ git ls-files drivers/staging/rtl8192u |
> xargs
On Tue, Jun 26, 2018 at 11:56:40AM +0800, Greg Kroah-Hartman wrote:
> On Mon, Jun 25, 2018 at 08:50:26PM +0100, John Whitmore wrote:
> > On Mon, Jun 25, 2018 at 02:05:04PM +0100, Justin Skists wrote:
> > >
> > > > On 25 June 2018 at 13:36 John Whitmore wrote:
&g
On Tue, Jun 26, 2018 at 11:56:24AM +0800, Greg KH wrote:
> On Sun, Jun 24, 2018 at 04:34:51PM +0100, John Whitmore wrote:
> > Changed a number of hard coded function names to use %s and __func__
> >
> > Mailing list response suggest that there is a better method for debugging
On Mon, Jun 25, 2018 at 02:05:04PM +0100, Justin Skists wrote:
>
> > On 25 June 2018 at 13:36 John Whitmore wrote:
> >
> >
> > On Mon, Jun 25, 2018 at 12:06:30PM +0300, Andy Shevchenko wrote:
> > > On Sun, Jun 24, 2018 at 6:34 PM, John Whitmore
Where possible truncation of block comments to the 80 character length
preferred by the coding style.
In a previous version of this commit some of the comments were contentious so
those have not been touched in this version.
Signed-off-by: John Whitmore
---
.../rtl8192u/ieee80211
Corrected the coding style of if statement.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211
Simple spelling correction.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index
Removed the unrequired braces from single statement blocks - Coding Style.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b
Changed a number of hard coded function names to use %s and __func__
Mailing list response suggest that there is a better method for debugging
using netdev_dbg(). I can't argue with that, but for the moment this change
will clear the checkpatch.pl Warning.
Signed-off-by: John Whitmore
1 - 100 of 1236 matches
Mail list logo
