Re: how to look for source code in kernel

2012-12-28 Thread Jonathan Neuschäfer
On Fri, Dec 28, 2012 at 11:49:53AM -0800, Eric W. Biederman wrote: Al Viro v...@zeniv.linux.org.uk writes: On Thu, Dec 27, 2012 at 11:36:13PM -0800, Eric W. Biederman wrote: But then I am probably peculiar keeping an index of the source code in my head. When I need to look for something

[PATCH 2/2] soc: qcom: smsm: Avoid the use of an uninitialized value

2017-03-15 Thread Jonathan Neuschäfer
If qcom_smem_get returns an error besides -EPROBE_DEFER or -ENOENT, don't assume that size has been set. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- drivers/soc/qcom/smsm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soc/qcom/smsm.c b/d

[PATCH 1/2] soc: qcom: smsm: Handle probe deferral

2017-03-15 Thread Jonathan Neuschäfer
If qcom_smem_get or qcom_smem_alloc return -EPROBE_DEFER, let the caller the caller handle it, instead of treating it as an error. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- v1: - TODO: Reading qcom_smsm_probe, I noticed memory leaks in error paths: smsm, smsm->ent

Re: [PATCH 1/2] soc: qcom: smsm: Handle probe deferral

2017-03-17 Thread Jonathan Neuschäfer
On Wed, Mar 15, 2017 at 12:43:56PM +0100, Jonathan Neuschäfer wrote: [...] > - TODO: Reading qcom_smsm_probe, I noticed memory leaks in error paths: > smsm, smsm->entries, etc. are allocated (with devm_kzalloc), but not > freed when the function returns early. This should

Re: [PATCH 1/2] soc: qcom: smsm: Handle probe deferral

2017-04-03 Thread Jonathan Neuschäfer
(ret != -EPROBE_DEFER) > dev_err(); > return ret; > } > > However, for us to reach this point in smsm_probe() the above > qcom_smem_get() must have returned successfully, i.e. we have SMEM in > place so there's no need to handle this case specifically. I came to the same conclusion but wasn't sure. I'll drop this part from my patch. I'll send a v2 of this series, although after applying your suggestions, I can't claim much originality anymore. Thanks for the review, Jonathan Neuschäfer signature.asc Description: PGP signature

Re: [PATCH] drm/udl: Fix unaligned memory access in udl_render_hline

2017-04-11 Thread Jonathan Neuschäfer
On Tue, Apr 11, 2017 at 09:30:53AM -0400, Sean Paul wrote: > On Fri, Apr 07, 2017 at 10:02:29PM +0200, Jonathan Neuschäfer wrote: > > On SPARC, the udl driver filled my kernel log with these messages: > > > > [186668.910612] Kernel unaligned access at TPC[76609c] > > u

[PATCH v2 1/2] ARM: dts: msm8974: Hook up adsp-pil's xo clock

2017-03-06 Thread Jonathan Neuschäfer
Without this patch (and with CONFIG_QCOM_ADSP_PIL), I get this error: [0.711529] qcom_adsp_pil adsp-pil: failed to get xo clock [0.711540] remoteproc remoteproc0: releasing adsp-pil With this patch, adsp-pil can initialize correctly. Signed-off-by: Jonathan Neuschäfer

[PATCH v2 2/2] ARM: qcom_defconfig: Enable Qualcomm remoteproc and related drivers

2017-03-06 Thread Jonathan Neuschäfer
here, its currently used to signal state of the ring buffers for WiFi." CONFIG_QCOM_WCNSS_CTRL is required to load firmware/configuration data into the WCNSS core, which handles WiFi and Bluetooth. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> Acked-by: Bjorn Anderss

[PATCH v2] soc: qcom: smsm: Improve error handling, quiesce probe deferral

2017-04-05 Thread Jonathan Neuschäfer
Don't use size if info indicates an error condition. Previously a non-ENOENT error (such as -EPROBE_DEFER) would lead to size being used even though it hadn't necessarily been initialized in qcom_smem_get. Don't print an error message in the -EPROBE_DEFER case. Signed-off-by: Jonathan Neuschäfer

[PATCH] drm/udl: Fix unaligned memory access in udl_render_hline

2017-04-07 Thread Jonathan Neuschäfer
-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- drivers/gpu/drm/udl/udl_transfer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/udl/udl_transfer.c b/drivers/gpu/drm/udl/udl_transfer.c index 917dcb978c2c..0c87b1ac6b68 100644 --- a/drivers/gpu/d

Re: [patches] [PATCH v7 05/15] irqchip: New RISC-V PLIC Driver

2017-08-03 Thread Jonathan Neuschäfer
> + * ... > + * base + 0xFC: Reserved As far as I can see, given that the Priority threshold/Claim/complete area begins at base+0x20 and ends at base+0x100 (exclusive), and the space occupied by one context is 0x1000 bytes, there should be space for (0x100-0x20)/0x1000 = 0xe00 = 3584, not 15872 contexts. Am I missing something? Jonathan Neuschäfer signature.asc Description: PGP signature

Re: [patches] Re: [PATCH v7 01/15] MAINTAINERS: Add RISC-V

2017-08-03 Thread Jonathan Neuschäfer
On Tue, Aug 01, 2017 at 04:03:28PM +0300, Andy Shevchenko wrote: > On Mon, 2017-07-31 at 17:59 -0700, Palmer Dabbelt wrote: > > From: Jonathan Neuschäfer <j.neuschae...@gmx.net> > > > > RISC-V needs a MAINTAINERS entry. Let's add one. > > > > Have you chec

Re: [patches] [PATCH 2/9] RISC-V: Atomic and Locking Code

2017-07-07 Thread Jonathan Neuschäfer
On Tue, Jul 04, 2017 at 12:50:55PM -0700, Palmer Dabbelt wrote: [...] > +/* These barries need to enforce ordering on both devices or memory. */ Very minor nit: s/barries/barriers/ (in several places) Jonathan Neuschäfer signature.asc Description: PGP signature

Re: [patches] [PATCH 1/9] RISC-V: Init and Halt Code

2017-07-07 Thread Jonathan Neuschäfer
l instruction"); >DO_ERROR_INFO(do_trap_load_misaligned, I'm not familiar with the trap handling infrastructure, but looking at include/uapi/asm-generic/siginfo.h, SEGV_ACCERR would alias to BUS_ADRERR (both are defined as (__SI_FAULT|2)). So if you use SEGV_*, you need to use SIGSEGV, too. With DO_ERROR_INFO(..., SIGSEGV, SEGV_ACCERR, ...); it looks good to me. Jonathan Neuschäfer signature.asc Description: PGP signature

Re: [patches] Re: [PATCH 04/17] MAINTAINERS: Add RISC-V

2017-07-12 Thread Jonathan Neuschäfer
On Wed, Jul 12, 2017 at 01:31:17PM +0200, Arnd Bergmann wrote: > On Wed, Jul 12, 2017 at 1:16 PM, James Hogan wrote: > > On Tue, Jul 11, 2017 at 06:31:17PM -0700, Palmer Dabbelt wrote: [...] > >> +RISC-V ARCHITECTURE > >> +M: Palmer Dabbelt > >> +M:

Re: [patches] [PATCH 17/17] RISC-V: Build Infastructure

2017-07-25 Thread Jonathan Neuschäfer
th a hint of RISC-V in the name, such as ISA_RVC. (Take this with a grain of salt, perhaps.) Jonathan Neuschäfer signature.asc Description: PGP signature

Re: [patches] [PATCH 17/17] RISC-V: Build Infastructure

2017-07-26 Thread Jonathan Neuschäfer
ouldn't be a need for CONFIG_ISA_A (or an equivalent option). CONFIG_RISCV_ISA_C (which Arnd suggested) makes it even clearer that these are RISC-V related options. Here's my patch, for reference (untested, because I currently don't have a riscv compiler installed): Subject: [PATCH] RISC-V: Re

Re: [patches] [PATCH 1/9] RISC-V: Init and Halt Code

2017-07-04 Thread Jonathan Neuschäfer
p_insn_misaligned, > + SIGBUS, BUS_ADRALN, "instruction address misaligned"); > +DO_ERROR_INFO(do_trap_insn_fault, > + SIGBUS, BUS_ADRALN, "instruction access fault"); For a general instruction access fault, BUS_ADRALN seems wrong. A variant of SIGSEGV seems more appropriate, IMHO. Jonathan Neuschäfer signature.asc Description: PGP signature

Re: [PATCH 4/5] arm64: dts: Add ipq8074 SoC and MTP board support

2017-04-28 Thread Jonathan Neuschäfer
H_QCOM) += msm8992-bullhead-rev-101.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8994-angler-rev-101.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb > +dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk01.dtb Maybe this list should be alphabetically sorted ('i' before 'm'). (I have no strong preference) Thanks, Jonathan Neuschäfer signature.asc Description: PGP signature

[PATCH 3/6] Documentation: kernel-docs: Remove "Here is its" at the end of lines

2017-05-15 Thread Jonathan Neuschäfer
anymore, because the "Abstract:" is clearly separated. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- Documentation/process/kernel-docs.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/process/kernel-docs.rst

[PATCH 5/6] Documentation: howto: Remove outdated info about bugzilla mailing lists

2017-05-15 Thread Jonathan Neuschäfer
The mailing list archives[1,2] show no activity since September 2011. [1]: https://lists.linuxfoundation.org/pipermail/bugme-new/ [2]: https://lists.linuxfoundation.org/pipermail/bugme-janitors/ Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- Documentation/process/howto.r

[PATCH 4/6] Documentation: Remove outdated info about -git patches

2017-05-15 Thread Jonathan Neuschäfer
Since the 3.2 cycle, there were no -git patches/tarballs on kernel.org. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- Documentation/process/applying-patches.rst | 40 +- Documentation/process/howto.rst| 9 --- 2 files chan

[PATCH 6/6] Documentation: mono: Update links and s/CVS/Git/

2017-05-15 Thread Jonathan Neuschäfer
The old URLs redirect to the new ones, so just update them in mono.rst. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- Documentation/admin-guide/mono.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/admin-guide/mono.rst b/Documen

[PATCH 2/6] Documentation: kernel-docs: Move vfs.txt under "Docs at the Linux Kernel tree"

2017-05-15 Thread Jonathan Neuschäfer
It's unneccessary to point to an external mirror of the Documentation directory. Also, drop the date field, because in-kernel documentation is continually updated. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- Documentation/process/kernel-docs.rst | 23 +++-

[PATCH 1/6] Documentation: coding-style: Escape \n\t to fix HTML rendering

2017-05-15 Thread Jonathan Neuschäfer
Without this patch, Sphinx renders the sentence as follows, thus hiding the backslashes: [...] end each string except the last with nt to properly indent the next instruction [...] Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- Documentation/process/

Re: [PATCH] iommu: of: Fix check for returning EPROBE_DEFER

2017-05-16 Thread Jonathan Neuschäfer
ed-by: Will Deacon <will.dea...@arm.com> Thanks, Jonathan Neuschäfer

Re: [PATCH v2] soc: qcom: smsm: Improve error handling, quiesce probe deferral

2017-05-31 Thread Jonathan Neuschäfer
t; even though it hadn't necessarily been initialized in qcom_smem_get. > > > > Don't print an error message in the -EPROBE_DEFER case. > > > > Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> > > Reviewed-by: Bjorn Andersson <bjorn.anders...@linar

Re: [patches] [PATCH v8 08/18] irqchip: New RISC-V PLIC Driver

2017-09-14 Thread Jonathan Neuschäfer
ase + 0x28: Reserved > + * ... > + * base + 0x200FFC: Reserved > + * base + 0x201000: Priority threshold for context 1 > + * base + 0x201004: Claim/complete for context 1 > + * ... > + * base + 0xFFE000: Priority threshold for context 15871 > + * base + 0xFFE004: Claim/

Re: [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-06 Thread Jonathan Neuschäfer
clkgear; > + struct slim_framer *a_framer; > + struct mutexm_ctrl; > + struct slim_addrt *addrt; > + u8 num_dev; > + struct workqueue_struct *wq; > + int (*set_laddr)(struct slim_controller *ctrl, > + struct slim_eaddr *ea, u8 laddr); > + int (*get_laddr)(struct slim_controller *ctrl, > + struct slim_eaddr *ea, u8 *laddr); > +}; Thanks, Jonathan Neuschäfer signature.asc Description: PGP signature

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-07 Thread Jonathan Neuschäfer
On Sat, Oct 07, 2017 at 11:24:33AM +0100, Srinivas Kandagatla wrote: > Thanks for the comments. > > On 07/10/17 07:42, Jonathan Neuschäfer wrote: > > Hi, > > > > On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org > > wrote: > > >

Re: [Patch v6 6/7] regmap: add SLIMBUS support

2017-10-06 Thread Jonathan Neuschäfer
t; + struct slim_val_inf msg = {0,}; > + > + msg.start_offset = reg; > + msg.num_bytes = 1; > + msg.wbuf = (void *) > + > + return slim_change_val_element(slim, ); > +} dito > +static struct regmap_bus regmap_slimbus_bus = { > + .reg_write = reg

Re: [Patch v6 3/7] slimbus: qcom: Add Qualcomm Slimbus controller driver

2017-10-07 Thread Jonathan Neuschäfer
MGR_INT_MSG_BUF_CONTE | MGR_INT_RX_MSG_RCVD | > + MGR_INT_TX_MSG_SENT), dev->base + MGR_INT_EN); > + writel_relaxed(1, dev->base + MGR_CFG); > + /* > + * Framer registers are beyond 1K memory region after Manager and/or > +

Re: [Patch v6 4/7] slimbus: Add support for 'clock-pause' feature

2017-10-07 Thread Jonathan Neuschäfer
t of clock pause > + */ > + if (sched->clk_state == SLIM_CLK_PAUSED && ctrl->wakeup) > + ret = ctrl->wakeup(ctrl); > + if (!ret) > + sched->clk_state = SLIM_CLK_ACTIVE; > + mutex_unlock(>m_reconf); > + > + return ret; > + } [...] Thanks, Jonathan Neuschäfer signature.asc Description: PGP signature

Re: [Patch v6 5/7] slimbus: qcom: Add runtime-pm support using clock-pause feature

2017-10-07 Thread Jonathan Neuschäfer
+ * We dont want to return suspend failure in that case so that > + * display and relevant components can still go to suspend. > + * If there is some other error, then it should prevent > + * system level suspend > + */ > + ret = 0; > + } > + return ret; > +} Thanks, Jonathan Neuschäfer signature.asc Description: PGP signature

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-07 Thread Jonathan Neuschäfer
return -EINVAL; > + > + return slim_xfer_msg(ctrl, sb, msg, SLIM_MSG_MC_REQUEST_CHANGE_VALUE); > +} > +EXPORT_SYMBOL_GPL(slim_request_change_val_element); [...] > +/** > + * struct slim_pending: context of pending transfers > + * @cb: callback for this transfer > + * @ctx: contex for the callback function s/contex/context/ > + * @need_tid: True if this transfer need Transaction ID > + */ > +struct slim_pending { > + void (*cb)(void *ctx, int err); > + void *ctx; > + bool need_tid; > +}; Thanks, Jonathan Neuschäfer signature.asc Description: PGP signature

Re: [PATCH 2/3] ARM: qcom_defconfig: enable MSM IOMMU for display

2017-11-27 Thread Jonathan Neuschäfer
ck requires IOMMU support? Jonathan Neuschäfer signature.asc Description: PGP signature

Re: [PATCH] drm/i915/guc: Fix doc reference to intel_guc_fw.c

2017-11-28 Thread Jonathan Neuschäfer
On Tue, Nov 28, 2017 at 09:51:13AM +0100, Michal Wajdeczko wrote: > On Tue, 28 Nov 2017 07:50:52 +0100, Jonathan Neuschäfer > <j.neuschae...@gmx.net> wrote: > > > Sphinx complains that it can't find intel_guc_loader.c, and rightly so: > > The file has been renamed. &

Re: [PATCH 1/2] MAINTAINERS: regulator: Add Documentation/power/regulator/

2017-11-28 Thread Jonathan Neuschäfer
On Tue, Nov 28, 2017 at 03:15:37PM +, Mark Brown wrote: > On Tue, Nov 28, 2017 at 05:22:02AM +0100, Jonathan Neuschäfer wrote: > > On Sun, Nov 19, 2017 at 06:09:06AM +0100, Jonathan Neuschäfer wrote: > > > Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> >

Re: [PATCH v7 11/13] slimbus: qcom: Add Qualcomm Slimbus controller driver

2017-11-23 Thread Jonathan Neuschäfer
o __le16 *: ea.manf_id = le16_to_cpup((__le16 *)_addr[4]); Like Charles, I don't quite see the point of the for loop that fills e_addr. I guess it did effectively a byteswap, so the original code, that assumed little-endian, could simply dereference a u16 *. This does not make a lot of sense anymore, once you use properly (CPU-)endian- independent code. (Of course, you'll need to replace le16 with be16 if you drop that loop.) Thanks, Jonathan Neuschäfer signature.asc Description: PGP signature

Re: [PATCH 1/2] MAINTAINERS: regulator: Add Documentation/power/regulator/

2017-11-27 Thread Jonathan Neuschäfer
On Sun, Nov 19, 2017 at 06:09:06AM +0100, Jonathan Neuschäfer wrote: > Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Ping. Should I resend this series with Cc: linux-...@vger.kernel.org? > > di

[PATCH] drm/i915/guc: Fix doc reference to intel_guc_fw.c

2017-11-27 Thread Jonathan Neuschäfer
Sphinx complains that it can't find intel_guc_loader.c, and rightly so: The file has been renamed. Fixes: e8668bbcb0f9 ("drm/i915/guc: Rename intel_guc_loader.c to intel_guc_fw.c") Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Signed-off-by: Jonathan Neuschäfer <j.

[PATCH] genericirq.rst: Remove :c:func:`...` in code blocks

2017-11-27 Thread Jonathan Neuschäfer
t;) Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- Documentation/core-api/genericirq.rst | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Documentation/core-api/genericirq.rst b/Documentation/core-api/genericirq.rst index 0054bd48be84..4da

Re: [PATCH v8 01/13] Documentation: Add SLIMbus summary

2017-12-01 Thread Jonathan Neuschäfer
APIs to exchange control-information with a SLIMbus > +device. APIs can be synchronous or asynchronous. > +From controller's perspective, multiple buffers can be queued to/from > +hardware for sending/receiving data using slim_ctrl_buf circular buffer. > +The header file has more documentation about messaging > APIs. Once the kerneldoc documentation (i.e. the /** ... */ comments in the source) is included somewhere, I think it would make sense to make slim_ctrl_buf a clickable link to the struct's documentation. Thanks, Jonathan Neuschäfer signature.asc Description: PGP signature

Re: [PATCH] dt-bindings: chosen: Document linux,initrd-{start,end}

2017-12-15 Thread Jonathan Neuschäfer
On Fri, Dec 15, 2017 at 03:01:47PM -0600, Rob Herring wrote: > On Sat, Dec 09, 2017 at 04:33:02PM +0100, Jonathan Neuschäfer wrote: > > These properties have been in use for a very long time (at least since > > 2005), but were never documented in chosen.txt. > > > &

[PATCH] tools/gpio: Don't use u_int32_t

2017-12-14 Thread Jonathan Neuschäfer
u_int32_t is a non-standard version of uint32_t, that was apparently introduced by BSD. Use uint32_t from stdint.h instead. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- tools/gpio/gpio-event-mon.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

[PATCH] dt-bindings: display: panel: Fix compatible string for Toshiba LT089AC29000

2017-12-16 Thread Jonathan Neuschäfer
The compatible string for this panel was specified as toshiba,lt089ac29000.txt. I believe this is a mistake. Fixes: 06e733e41f87 ("drm/panel: simple: add Toshiba LT089AC19000") Cc: Lucas Stach <l.st...@pengutronix.de> Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net&g

[PATCH] dt-bindings: trivial-devices: Remove fsl,mc13892

2017-11-17 Thread Jonathan Neuschäfer
This device's bindings are not trivial: Additional properties are documented in in Documentation/devicetree/bindings/mfd/mc13xxx.txt. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- Documentation/devicetree/bindings/trivial-devices.txt | 1 - 1 file changed, 1 deletion(-)

Re: [PATCH] dt-bindings: Add a RISC-V SBI firmware node

2017-11-20 Thread Jonathan Neuschäfer
On Mon, Nov 20, 2017 at 11:50:00AM -0800, Palmer Dabbelt wrote: > The RISC-V privileged ISA mandates the presence of an SBI, but there's > no reason not to put it in the device tree. This would allow us to > possibly remove the SBI later. Thanks! > > CC: Jonathan Neuschä

Re: [patches] Re: [PATCH] dt-bindings: Add a RISC-V SBI firmware node

2017-11-20 Thread Jonathan Neuschäfer
n a similar fashion, the ABI and SBI will continue to evolve. For example, > we'll probably add new system calls to extend the user ABI and new hyper > calls to extend the SBI. My problem with the wording was that the OS somehow has to know which version and variant of the SBI it is talking to --

Re: [PATCH] dt-bindings: trivial-devices: Remove fsl,mc13892

2017-11-21 Thread Jonathan Neuschäfer
On Mon, Nov 20, 2017 at 03:10:45PM -0600, Rob Herring wrote: > On Sat, Nov 18, 2017 at 03:22:32AM +0100, Jonathan Neuschäfer wrote: > > This device's bindings are not trivial: Additional properties are > > documented in in Documentation/devicetree/bindings/mfd/mc13xxx.txt. >

[PATCH 1/2] MAINTAINERS: regulator: Add Documentation/power/regulator/

2017-11-18 Thread Jonathan Neuschäfer
Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2811a211632c..a644d41e088c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14447,6 +14447,7 @@ W: http://www.slimlogic.co.uk/?p

[PATCH 2/2] regulator: Update code examples in documentation

2017-11-18 Thread Jonathan Neuschäfer
This involves using the REGULATOR_SUPPLY initializer macro and reindenting some of the code. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- Documentation/power/regulator/machine.txt | 36 ++- 1 file changed, 16 insertions(+), 20 deletions(-)

Re: [patches] Re: [PATCH v9 03/12] dt-bindings: RISC-V CPU Bindings

2017-11-19 Thread Jonathan Neuschäfer
qcom,scm): / { firmware { sbi { compatible = "riscv,sbi"; }; }; }; This topic may warrant some discussion, because other people may have different opinions, and there hasn't been a discussion about it, AFAICS. Thanks, Jonathan Neuschä

Re: [patches] Re: [PATCH] dt-bindings: Add a RISC-V SBI firmware node

2017-11-21 Thread Jonathan Neuschäfer
ion that wouldn't require a device tree node > would be to have Linux boot in machine mode [...] and then provide its > own SBI implementation. I think this can work. Thanks, Jonathan Neuschäfer signature.asc Description: PGP signature

Re: [PATCH v2 5/5] samples: Introduce Qualcomm QMI sample client

2017-11-07 Thread Jonathan Neuschäfer
he associated remote test service and will return with the result of the > + * transaction. It serves as an example of how to have the QMI helpers > decode a > + * transaction response into a provided object automatically. > + */ > +static ssize_t data_write(struct file *file, const char __user *user_buf, > + size_t count, loff_t *ppos) Jonathan Neuschäfer signature.asc Description: PGP signature

[PATCH] Documentation: mono: Update links and s/CVS/Git/

2017-12-09 Thread Jonathan Neuschäfer
The URLs in mono.rst redirect to pages on www.mono-project.com, so let's update them. I took the liberty to update the compilation instructions to the Linux-specific version, because readers of the kernel documentation will most likely use Linux. Signed-off-by: Jonathan Neuschäfer <j.neusc

[PATCH] dt-bindings: chosen: Document linux,initrd-{start,end}

2017-12-09 Thread Jonathan Neuschäfer
These properties have been in use for a very long time (at least since 2005), but were never documented in chosen.txt. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- Documentation/devicetree/bindings/chosen.txt | 15 +++ 1 file changed, 15 insertions(+) diff

Re: [PATCH 2/2] powerpc: wii_defconfig: Enable GPIO-related options

2018-05-07 Thread Jonathan Neuschäfer
On Mon, Apr 30, 2018 at 03:42:47PM +0200, Jonathan Neuschäfer wrote: > Now that there's a GPIO driver for the Wii, let's enable the following > drivers: > > - the GPIO driver itself > - gpio-keys > - gpio-poweroff > - gpio-leds and a few LED triggers > > Signed-

[PATCH v2 1/4] powerpc: wii_defconfig: Disable Ethernet driver support code

2018-05-07 Thread Jonathan Neuschäfer
The Wii doesn't have built-in Ethernet and USB Ethernet adapters are in a different menu. Disable CONFIG_ETHERNET to save some space in support code for Ethernet drivers. Note that this patch doesn't disable any Ethernet drivers, because they are not enabled by default. Signed-off-by: Jonathan

[PATCH v2 3/4] powerpc: wii_defconfig: Enable Wii SDHCI driver

2018-05-07 Thread Jonathan Neuschäfer
This allows access to the SD card and the BCM4318 Wifi module. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- Note that until some fixes in the interrupt controller drivers used on the Wii, the SDHCI controllers will not be usable. v2: - Patch added to the series ---

[PATCH v2 4/4] powerpc: wii_defconfig: Disable BCMA support

2018-05-07 Thread Jonathan Neuschäfer
The B43 driver only needs CONFIG_SSB to support the WLAN card found in the Wii. Configure it accordingly, and disable BCMA bus support to save a bit of space. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- v2: - Patch added to the series --- arch/powerpc/configs/wii_def

[PATCH v2 2/4] powerpc: wii_defconfig: Enable GPIO-related options

2018-05-07 Thread Jonathan Neuschäfer
Now that there's a GPIO driver for the Wii, let's enable the following drivers: - the GPIO driver itself - gpio-keys - gpio-poweroff - gpio-leds and a few LED triggers Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- v2: - Set CONFIG_NEW_LEDS=y and CONFIG_LEDS_TRIGGERS=y, w

[PATCH 1/2] powerpc: flipper-pic: Don't match all IRQ domains

2018-05-10 Thread Jonathan Neuschäfer
On the Wii, there is a secondary IRQ controller (hlwd-pic), so flipper-pic's match operation should not be hardcoded to return 1. In fact, the default matching logic is sufficient, and we can completely omit flipper_pic_match. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> ---

[PATCH 0/2] powerpc: Wii IRQ fixes

2018-05-10 Thread Jonathan Neuschäfer
for the problem at hand, but it works and should only cause problems when both processors in the system (PPC and ARM) try to use the same interrupt, if at all. Jonathan Neuschäfer (2): powerpc: flipper-pic: Don't match all IRQ domains powerpc: hlwd-pic: Prevent interrupts from being handled

[PATCH 2/2] powerpc: hlwd-pic: Prevent interrupts from being handled by Starlet

2018-05-10 Thread Jonathan Neuschäfer
will also make sure that Linux can properly talk to the SD card controller (and potentially other devices). If access to a device through IPC is desired in the future, interrupts from that device should not be handled by Linux directly. [1]: https://github.com/lewurm/mini Signed-off-by: Jonathan Ne

Re: [PATCH v2 0/4] powerpc: wii_defconfig updates

2018-05-07 Thread Jonathan Neuschäfer
I forgot to CC the right set of people/mailing lists on the cover letter. Sorry. Here it is: On Mon, May 07, 2018 at 04:20:15PM +0200, Jonathan Neuschäfer wrote: > v1: https://www.spinics.net/lists/kernel/msg2790389.html > https://www.spinics.net/lists/kernel/msg279038

[PATCH] Documentation: gpio: driver: Fix a typo and some odd grammar

2018-05-16 Thread Jonathan Neuschäfer
Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- Documentation/driver-api/gpio/driver.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/driver-api/gpio/driver.rst b/Documentation/driver-api/gpio/driver.rst index 505ee906d7d9..cbe024

[PATCH] genirq: Fix editing error in a comment

2018-06-17 Thread Jonathan Neuschäfer
When the comment was reflowed to a wider format, the "*" snuck in. Fixes: ae88a23b32fa ("irq: refactor and clean up the free_irq() code flow") Signed-off-by: Jonathan Neuschäfer --- kernel/irq/manage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/k

[PATCH 2/2] powerpc: wii_defconfig: Enable GPIO-related options

2018-04-30 Thread Jonathan Neuschäfer
Now that there's a GPIO driver for the Wii, let's enable the following drivers: - the GPIO driver itself - gpio-keys - gpio-poweroff - gpio-leds and a few LED triggers Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- arch/powerpc/configs/wii_defconfig | 8 1 file c

[PATCH 1/2] powerpc: wii_defconfig: Disable Ethernet driver support code

2018-04-30 Thread Jonathan Neuschäfer
kernel_config_data 13691 13324-367 Total: Before=8341718, After=8341351, chg -0.00% Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- arch/powerpc/configs/wii_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/configs/wii_defcon

Re: [PATCH 3/6] gpio: Add GPIO driver for Nintendo Wii

2018-01-16 Thread Jonathan Neuschäfer
On Tue, Jan 16, 2018 at 10:42:54AM +0100, Linus Walleij wrote: > On Mon, Jan 15, 2018 at 4:13 AM, Jonathan Neuschäfer > <j.neuschae...@gmx.net> wrote: > > > This patch is based on code developed by Albert Herranz and the GameCube > > Linux Team, file arch/powerpc/platfo

[PATCH v2 5/6] powerpc: wii.dts: Add ngpios property

2018-01-21 Thread Jonathan Neuschäfer
The Hollywood GPIO controller supports 32 GPIOs, but on the Wii, only 24 are used. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- v2: - no change --- arch/powerpc/boot/dts/wii.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/boot/dts/wii.dts b/arch/p

[PATCH v2 6/6] powerpc: wii.dts: Add GPIO line names

2018-01-21 Thread Jonathan Neuschäfer
These are the GPIO line names on a Nintendo Wii, as documented in: https://wiibrew.org/wiki/Hardware/Hollywood_GPIOs Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- v2: - no change --- arch/powerpc/boot/dts/wii.dts | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v2 4/6] dt-bindings: gpio: Add binding for Wii GPIO controller

2018-01-21 Thread Jonathan Neuschäfer
The Nintendo Wii game console has a GPIO controller, which is used for the optical disk slot LED, buttons, poweroff, etc. This patch adds a binding for this GPIO controller. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> Reviewed-by: Rob Herring <r...@kernel.org> ---

[PATCH v2 3/6] gpio: Add GPIO driver for Nintendo Wii

2018-01-21 Thread Jonathan Neuschäfer
-Wii-Linux-Kernels, but has grown quite dissimilar. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> Cc: Albert Herranz <albert_herr...@yahoo.es> Cc: Segher Boessenkool <seg...@kernel.crashing.org> --- v2: - Change hlwd_gpio_driver.driver.name to "gpio-hlwd" t

[PATCH v2 2/6] powerpc: wii: Explicitly configure GPIO owner for poweroff pin

2018-01-21 Thread Jonathan Neuschäfer
. I think the Wii can be switched to the generic gpio-poweroff driver, after the GPIO driver is merged. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- v2: - no change --- arch/powerpc/platforms/embedded6xx/wii.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v2 0/6] Nintendo Wii GPIO driver

2018-01-21 Thread Jonathan Neuschäfer
subsystems (GPIO, DT, core resource management), I guess it should be picked up patch-by-patch by the different maintainers. The main difference between v2 and the previous version is that I rewrote the driver on top of the GPIO_GENERIC library, saving 60 lines of code. Jonathan Neuschäfer (6

[PATCH v2 1/6] resource: Extend the PPC32 reserved memory hack

2018-01-21 Thread Jonathan Neuschäfer
This hack, however, doesn't account for the "resource"-based API in kernel/resource.c, because __request_region performs its own checks. Extend the hack to kernel/resource.c, to allow more drivers to allocate their MMIO regions on the Wii. Signed-off-by: Jonathan Neuschäfer <j.neusch

[PATCH 0/6] Nintendo Wii GPIO driver

2018-01-14 Thread Jonathan Neuschäfer
subsystems (GPIO, DT, core resource management), I guess it should be picked up patch-by-patch by the different maintainers. Jonathan Neuschäfer (6): resource: Extend the PPC32 reserved memory hack powerpc: wii: Explicitly configure GPIO owner for poweroff pin gpio: Add GPIO driver for Nintendo

[PATCH 6/6] powerpc: wii.dts: Add GPIO line names

2018-01-14 Thread Jonathan Neuschäfer
These are the GPIO line names on a Nintendo Wii, as documented in: https://wiibrew.org/wiki/Hardware/Hollywood_GPIOs Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- arch/powerpc/boot/dts/wii.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/powerpc/bo

[PATCH 2/6] powerpc: wii: Explicitly configure GPIO owner for poweroff pin

2018-01-14 Thread Jonathan Neuschäfer
. I think the Wii can be switched to the generic gpio-poweroff driver, after the GPIO driver is merged. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- arch/powerpc/platforms/embedded6xx/wii.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/powerpc/pla

[PATCH 3/6] gpio: Add GPIO driver for Nintendo Wii

2018-01-14 Thread Jonathan Neuschäfer
lwd-gpio.c \ drivers/gpio/gpio-hlwd.c Cc: Albert Herranz <albert_herr...@yahoo.es> Cc: Segher Boessenkool <seg...@kernel.crashing.org> Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- This driver currently uses __raw_readl and __raw_writel to access the GPIO

[PATCH 5/6] powerpc: wii.dts: Add ngpios property

2018-01-14 Thread Jonathan Neuschäfer
The Hollywood GPIO controller supports 32 GPIOs, but on the Wii, only 24 are used. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- arch/powerpc/boot/dts/wii.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/boot/dts/wii.dts b/arch/powerpc/boot/dts/wii.dts

[PATCH 1/6] resource: Extend the PPC32 reserved memory hack

2018-01-14 Thread Jonathan Neuschäfer
This hack, however, doesn't account for the "resource"-based API in kernel/resource.c, because __request_region performs its own checks. Extend the hack to kernel/resource.c, to allow more drivers to allocate their MMIO regions on the Wii. Signed-off-by: Jonathan Neuschäfer <j

[PATCH 4/6] dt-bindings: gpio: Add binding for Wii GPIO controller

2018-01-14 Thread Jonathan Neuschäfer
Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- .../bindings/gpio/nintendo,hollywood-gpio.txt | 27 ++ .../devicetree/bindings/powerpc/nintendo/wii.txt | 9 +--- 2 files changed, 28 insertions(+), 8 deletions(-) create mode 100644 Documen

Re: [PATCH v2 1/6] resource: Extend the PPC32 reserved memory hack

2018-01-27 Thread Jonathan Neuschäfer
On Wed, Jan 24, 2018 at 12:23:05PM +1100, Michael Ellerman wrote: > Jonathan Neuschäfer <j.neuschae...@gmx.net> writes: [...] > > Do you have any pointer on how to implement discontiguous memory > > support? CONFIG_ARCH_SPARSEMEM_ENABLE seems relevant. > > I'm n

Re: [PATCH 06/20] riscv: Remove ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE select

2018-02-05 Thread Jonathan Neuschäfer
OSITIVE select from RISCV. > > Discovered with the > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > script. > > Signed-off-by: Ulf Magnusson <ulfali...@gmail.com> > --- > arch/riscv/Kconfig | 1 - > 1 file changed, 1 deletion(-) Looks good

Re: [PATCH v2 3/6] gpio: Add GPIO driver for Nintendo Wii

2018-01-31 Thread Jonathan Neuschäfer
Hi, On Sun, Jan 28, 2018 at 07:31:58PM +0200, Andy Shevchenko wrote: > On Mon, Jan 22, 2018 at 7:04 AM, Jonathan Neuschäfer > <j.neuschae...@gmx.net> wrote: > > Style issues below. > > > +#define HW_GPIO_OWNER 0x3c > > + > > + > > +str

[PATCH] powerpc: wii: Probe the whole devicetree

2018-02-06 Thread Jonathan Neuschäfer
. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- arch/powerpc/platforms/embedded6xx/wii.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/embedded6xx/wii.c b/arch/powerpc/platforms/embedded6xx/wii.c index f598d5fe1d72..4de26c3c4f6d

Re: [PATCH v3 2/4] gpio: Add GPIO driver for Nintendo Wii

2018-02-09 Thread Jonathan Neuschäfer
On Fri, Feb 09, 2018 at 05:30:55PM +0200, Andy Shevchenko wrote: > On Fri, Feb 9, 2018 at 2:07 PM, Jonathan Neuschäfer > <j.neuschae...@gmx.net> wrote: > > The Nintendo Wii's chipset (called "Hollywood") has a GPIO controller > > that supports a configurable num

Re: [PATCH v3 2/4] gpio: Add GPIO driver for Nintendo Wii

2018-02-09 Thread Jonathan Neuschäfer
On Fri, Feb 09, 2018 at 01:07:29PM +0100, Jonathan Neuschäfer wrote: > The Nintendo Wii's chipset (called "Hollywood") has a GPIO controller > that supports a configurable number of pins (up to 32), interrupts, and > some special mechanisms to share the controller between the

[PATCH] Documentation/process/howto: Remove outdated info about bugzilla mailing lists

2018-02-13 Thread Jonathan Neuschäfer
The mailing list archives[1,2] show no activity since September 2011. [1]: https://lists.linuxfoundation.org/pipermail/bugme-new/ [2]: https://lists.linuxfoundation.org/pipermail/bugme-janitors/ Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- Documentation/process/howto.r

[PATCH] admin-guide: Fix list formatting in tained-kernels.html

2018-02-13 Thread Jonathan Neuschäfer
Without this patch, the points 1-9 in the list are rendered as an HTML blockquote containing a list, causing them to be indented further than the rest of the list. While at it, also fix the quotation marks around G and P. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.

[PATCH v3 0/4] Nintendo Wii GPIO driver

2018-02-09 Thread Jonathan Neuschäfer
ork around a resource allocation problem on PPC32. In this version, I dropped this patch, because the problem will be solved differently and in a separate patchset. I also dropped the dt-bindings patch, because Linus Walleij has already applied it. Jonathan Neuschäfer (4): powerpc: wii: Explicitly conf

[PATCH v3 1/4] powerpc: wii: Explicitly configure GPIO owner for poweroff pin

2018-02-09 Thread Jonathan Neuschäfer
. I think the Wii can be switched to the generic gpio-poweroff driver, after the GPIO driver is merged. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- v2, v3: - no change --- arch/powerpc/platforms/embedded6xx/wii.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v3 2/4] gpio: Add GPIO driver for Nintendo Wii

2018-02-09 Thread Jonathan Neuschäfer
-Wii-Linux-Kernels, but has grown quite dissimilar. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> Cc: Albert Herranz <albert_herr...@yahoo.es> Cc: Segher Boessenkool <seg...@kernel.crashing.org> <--- v3: - Do some style cleanups, as suggest b

[PATCH v3 4/4] powerpc: wii.dts: Add GPIO line names

2018-02-09 Thread Jonathan Neuschäfer
These are the GPIO line names on a Nintendo Wii, as documented in: https://wiibrew.org/wiki/Hardware/Hollywood_GPIOs Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- v2, v3: - no change --- arch/powerpc/boot/dts/wii.dts | 8 1 file changed, 8 insertions(+) diff

[PATCH v3 3/4] powerpc: wii.dts: Add ngpios property

2018-02-09 Thread Jonathan Neuschäfer
The Hollywood GPIO controller supports 32 GPIOs, but on the Wii, only 24 are used. Signed-off-by: Jonathan Neuschäfer <j.neuschae...@gmx.net> --- v2, v3: - no change --- arch/powerpc/boot/dts/wii.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/boot/dts/wii.dts

Re: [PATCH v2 3/6] gpio: Add GPIO driver for Nintendo Wii

2018-02-07 Thread Jonathan Neuschäfer
On Wed, Feb 07, 2018 at 01:29:45PM +0100, Linus Walleij wrote: > On Mon, Jan 22, 2018 at 6:04 AM, Jonathan Neuschäfer > <j.neuschae...@gmx.net> wrote: > > > The Nintendo Wii's chipset (called "Hollywood") has a GPIO controller > > that supports a configurable

Re: [PATCH 1/6] powerpc/mm/32: Use pfn_valid to check if pointer is in RAM

2018-02-21 Thread Jonathan Neuschäfer
oremap_caller, except that there's this code, which apparently trashes memblock 0 completely on non-CONFIG_NEED_MULTIPLE_NODES: https://elixir.bootlin.com/linux/v4.16-rc2/source/arch/powerpc/mm/mem.c#L223 Thanks, Jonathan Neuschäfer signature.asc Description: PGP signature

  1   2   >