[PATCH v2 2/2] Staging: android/ion: fix sparse warning

Declare private function static to fix sparse warning: ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \ was not declared. Should it be static? Signed-off-by: Joseph Wright <rjosephwri...@gmail.com> --- Changes in v2: - Split into multiple patches drivers/staging/a

[PATCH v2 0/2] Staging: android/ion: fix sparse warnings

Split sparse warning fixes into multiple patches. Joseph Wright (2): Staging: android/ion: fix sparse warnings Staging: android/ion: fix sparse warning drivers/staging/android/ion/ion.h | 4 drivers/staging/android/ion/ion_cma_heap.c | 2 +- 2 files changed, 5 insertions(+), 1

[PATCH v2 1/2] Staging: android/ion: fix sparse warnings

-by: Joseph Wright <rjosephwri...@gmail.com> --- Changes in v2: - Split into multiple patches drivers/staging/android/ion/ion.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h index fa9ed81..fda1e91 100644 --- a/drivers/s

[PATCH v3 1/1] Staging: android/ion: declare function static

Declare private function static to fix sparse warning: ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \ was not declared. Should it be static? Signed-off-by: Joseph Wright <rjosephwri...@gmail.com> --- Changes in v3: - Make subject clearer drivers/staging/andro

[PATCH v3 0/1] Staging: android/ion: fix sparse warnings

Improve commit message. Previous version included a patch to add declarations to ion.h, but I have dropped that as the same declarations were recently removed. Joseph Wright (1): Staging: android/ion: declare function static drivers/staging/android/ion/ion_cma_heap.c | 2 +- 1 file changed

Re: [PATCH v3 1/1] Staging: android/ion: declare function static

On Tue, Jul 18, 2017 at 08:58:22AM +0200, Greg KH wrote: > On Sat, Jul 15, 2017 at 11:43:05AM +0000, Joseph Wright wrote: > > Declare private function static to fix sparse warning: > > > > ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \ > > was not de

[PATCH 0/2] Staging: pi433: fix sparse warnings

Two patches included to fix warnings found with sparse. Joseph Wright (2): Staging: pi433: declare functions static Staging: pi433: check error after kthread_run() drivers/staging/pi433/pi433_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.9.3

[PATCH 1/2] Staging: pi433: declare functions static

Declare functions static to fix sparse warnings: warning: symbol 'pi433_receive' was not declared. Should it be static? warning: symbol 'pi433_tx_thread' was not declared. Should it be static? Signed-off-by: Joseph Wright <rjosephwri...@gmail.com> --- drivers/staging/pi433/pi433_if

[PATCH 2/2] Staging: pi433: check error after kthread_run()

Error should be checked with IS_ERR after calling kthread_run() instead of comparing the returned pointer to an int. Found by sparse warning: incompatible types for operation (<) left side has type struct task_struct *tx_task_struct right side has type int Signed-off-by: Joseph Wri

[PATCH] Staging: android/ion: fix sparse warnings

' \ was not declared. Should it be static? Signed-off-by: Joseph Wright <rjosephwri...@gmail.com> --- drivers/staging/android/ion/ion.h | 4 drivers/staging/android/ion/ion_cma_heap.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/andro

[PATCH v2 1/2] Staging: android/ion: fix sparse warnings

-by: Joseph Wright --- Changes in v2: - Split into multiple patches drivers/staging/android/ion/ion.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h index fa9ed81..fda1e91 100644 --- a/drivers/staging/android/ion/ion.h +++ b

[PATCH v2 0/2] Staging: android/ion: fix sparse warnings

Split sparse warning fixes into multiple patches. Joseph Wright (2): Staging: android/ion: fix sparse warnings Staging: android/ion: fix sparse warning drivers/staging/android/ion/ion.h | 4 drivers/staging/android/ion/ion_cma_heap.c | 2 +- 2 files changed, 5 insertions(+), 1

[PATCH v2 2/2] Staging: android/ion: fix sparse warning

Declare private function static to fix sparse warning: ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \ was not declared. Should it be static? Signed-off-by: Joseph Wright --- Changes in v2: - Split into multiple patches drivers/staging/android/ion/ion_cma_heap.c | 2

[PATCH] Staging: android/ion: fix sparse warnings

' \ was not declared. Should it be static? Signed-off-by: Joseph Wright --- drivers/staging/android/ion/ion.h | 4 drivers/staging/android/ion/ion_cma_heap.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging

[PATCH v3 0/1] Staging: android/ion: fix sparse warnings

Improve commit message. Previous version included a patch to add declarations to ion.h, but I have dropped that as the same declarations were recently removed. Joseph Wright (1): Staging: android/ion: declare function static drivers/staging/android/ion/ion_cma_heap.c | 2 +- 1 file changed

[PATCH v3 1/1] Staging: android/ion: declare function static

Declare private function static to fix sparse warning: ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \ was not declared. Should it be static? Signed-off-by: Joseph Wright --- Changes in v3: - Make subject clearer drivers/staging/android/ion/ion_cma_heap.c | 2 +- 1

Re: [PATCH v3 1/1] Staging: android/ion: declare function static

On Tue, Jul 18, 2017 at 08:58:22AM +0200, Greg KH wrote: > On Sat, Jul 15, 2017 at 11:43:05AM +0000, Joseph Wright wrote: > > Declare private function static to fix sparse warning: > > > > ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \ > > was not de

[PATCH 0/2] Staging: pi433: fix sparse warnings

Two patches included to fix warnings found with sparse. Joseph Wright (2): Staging: pi433: declare functions static Staging: pi433: check error after kthread_run() drivers/staging/pi433/pi433_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.9.3

[PATCH 1/2] Staging: pi433: declare functions static

Declare functions static to fix sparse warnings: warning: symbol 'pi433_receive' was not declared. Should it be static? warning: symbol 'pi433_tx_thread' was not declared. Should it be static? Signed-off-by: Joseph Wright --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2

[PATCH 2/2] Staging: pi433: check error after kthread_run()

Error should be checked with IS_ERR after calling kthread_run() instead of comparing the returned pointer to an int. Found by sparse warning: incompatible types for operation (<) left side has type struct task_struct *tx_task_struct right side has type int Signed-off-by: Joseph Wri