Re: [RFC] arm: use built-in byte swap function

2013-02-05 Thread Kim Phillips
sions, so we should check for gcc >= 4.5 instead of gcc >= 4.6. I've added a new check for !CC_OPTIMIZE_FOR_SIZE and build-tested all defconfigs with gcc 4.6.3 - here's v5: >From 11aa942a84fe94d204424a19b6b13fdb2b359ee6 Mon Sep 17 00:00:00 2001 From: Kim Phillips Date: Mon, 28

Re: [RFC] arm: use built-in byte swap function

2013-02-06 Thread Kim Phillips
On Wed, 6 Feb 2013 09:02:04 + "Woodhouse, David" wrote: > On Tue, 2013-02-05 at 21:04 -0600, Kim Phillips wrote: > > gcc -Os emits calls to __bswapsi2 on those platforms to save space > > because they don't have the single rev byte swap instruction. > > I

Re: [PATCH] crypto: caam - set RDB bit in security configuration register

2013-02-06 Thread Kim Phillips
On Wed, 6 Feb 2013 17:17:46 +0530 Vakul Garg wrote: > This change is required for post SEC-5.0 devices which have RNG4. Setting RDB wrap your commit message text to 75 chars > in security configuration register allows CAAM to use the "Random Data Buffer" > to be filled by a single request. The

Re: [RFC] arm: use built-in byte swap function

2013-02-08 Thread Kim Phillips
On Fri, 8 Feb 2013 17:47:33 -0500 Nicolas Pitre wrote: > On Fri, 8 Feb 2013, Woodhouse, David wrote: > > > On Fri, 2013-02-08 at 15:04 -0500, Nicolas Pitre wrote: > > > On Fri, 8 Feb 2013, Woodhouse, David wrote: > > > > > > > On Thu, 2013-02-07 at 18:13 +, Russell King - ARM Linux wrote: >

[RFC] arm: use built-in byte swap function

2013-01-28 Thread Kim Phillips
Enable the compiler intrinsic for byte swapping on arch ARM. This allows the compiler to detect and be able to optimize out byte swappings, e.g. in big endian to big endian moves. AFAICT, arm gcc got __builtin_bswap{32,64} support in 4.6, and for the 16-bit version in 4.8. Signed-off-by: Kim

Re: [RFC] arm: use built-in byte swap function

2013-01-30 Thread Kim Phillips
ll, but it should help drivers for big-endian devices. >From 31df859be202f00d017b707649e7709281994d15 Mon Sep 17 00:00:00 2001 From: Kim Phillips Date: Mon, 28 Jan 2013 19:30:33 -0600 Subject: [PATCH] arm: use built-in byte swap function Enable the compiler intrinsic for byte swapping on arch AR

Re: [RFC] arm: use built-in byte swap function

2013-01-31 Thread Kim Phillips
On Thu, 31 Jan 2013 09:28:01 + Russell King - ARM Linux wrote: > On Wed, Jan 30, 2013 at 08:09:00PM -0600, Kim Phillips wrote: > > The savings come mostly from device-tree related code, and some > > from drivers. > > You forget that IP networking is all big endian, s

[PATCH v4] arm: use built-in byte swap function

2013-01-31 Thread Kim Phillips
>From 1490bd8823c05e0dda982524bb70cb6c6427ddf9 Mon Sep 17 00:00:00 2001 From: Kim Phillips Date: Mon, 28 Jan 2013 19:30:33 -0600 Subject: [PATCH] arm: use built-in byte swap function Enable the compiler intrinsic for byte swapping on arch ARM. This allows the compiler to detect and be able

[PATCH v6] arm: use built-in byte swap function

2013-02-22 Thread Kim Phillips
On Thu, 21 Feb 2013 22:40:08 -0500 Nicolas Pitre wrote: > On Thu, 21 Feb 2013, Kim Phillips wrote: > > > Here's the asm version I'm working on now, based on compiler > > output of the C version. Haven't tested beyond defconfig builds, > > which pass ok.

[PATCH 2/3] dtc: import latest upstream dtc

2013-02-26 Thread Kim Phillips
This updates scripts/dtc to upstream dtc commit 27cdc1b "Added license header to dtc/libfdt/fdt.h and libfdt_env.h" from git://git.jdl.com/software/dtc.git. Signed-off-by: Kim Phillips --- scripts/dtc/dtc.c | 3 -- scripts/dtc/fdtdump.c | 29 +-- s

[PATCH 1/3] libfdt: add fdt type definitions in libfdt_env.h

2013-02-26 Thread Kim Phillips
in preparation for the forthcoming dtc update which adds fdt specific types: fdt{16,32,64}_t. Signed-off-by: Kim Phillips --- arch/arm/boot/compressed/libfdt_env.h | 4 include/linux/libfdt_env.h| 6 ++ 2 files changed, 10 insertions(+) diff --git a/arch/arm/boot

[PATCH 3/3] ARM: zImage: sparse fixes

2013-02-26 Thread Kim Phillips
) arch/arm/boot/compressed/atags_to_fdt.c:141:54:expected unsigned int [unsigned] arch/arm/boot/compressed/atags_to_fdt.c:141:54:got restricted __be32 [usertype] Signed-off-by: Kim Phillips --- arch/arm/boot/compressed/atags_to_fdt.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH 2/3] dtc: import latest upstream dtc

2013-02-27 Thread Kim Phillips
On Tue, 26 Feb 2013 21:08:06 -0600 Rob Landley wrote: > On 02/26/2013 07:36:14 PM, Kim Phillips wrote: > > This updates scripts/dtc to upstream dtc commit 27cdc1b > > There's an upstream for dts? dtc - the device tree compiler, yes. > > "Added license

Re: [RFC] arm: use built-in byte swap function

2013-02-19 Thread Kim Phillips
On Fri, 8 Feb 2013 22:16:47 -0500 Nicolas Pitre wrote: > On Fri, 8 Feb 2013, Kim Phillips wrote: > > > On Fri, 8 Feb 2013 17:47:33 -0500 > > Nicolas Pitre wrote: > > > > > On Fri, 8 Feb 2013, Woodhouse, David wrote: > > > > > > >

Re: [RFC] arm: use built-in byte swap function

2013-02-20 Thread Kim Phillips
On Wed, 20 Feb 2013 10:43:18 -0500 Nicolas Pitre wrote: > On Wed, 20 Feb 2013, Woodhouse, David wrote: > > On Wed, 2013-02-20 at 09:06 -0500, Nicolas Pitre wrote: > > > ... in which case there is no harm shipping a .c file and trivially > > > enforcing -O2, the rest being equal. > > > > For tod

Re: [RFC] arm: use built-in byte swap function

2013-02-20 Thread Kim Phillips
On Wed, 20 Feb 2013 23:29:58 -0500 Nicolas Pitre wrote: > On Wed, 20 Feb 2013, Kim Phillips wrote: > > > On Wed, 20 Feb 2013 10:43:18 -0500 > > Nicolas Pitre wrote: > > > > > On Wed, 20 Feb 2013, Woodhouse, David wrote: > > > > On Wed, 2

Re: [RFC] arm: use built-in byte swap function

2013-02-21 Thread Kim Phillips
On Thu, 21 Feb 2013 11:40:54 -0500 Nicolas Pitre wrote: > On Thu, 21 Feb 2013, Kim Phillips wrote: > > > On Wed, 20 Feb 2013 23:29:58 -0500 > > Nicolas Pitre wrote: > > > > > On Wed, 20 Feb 2013, Kim Phillips wrote: > > > > > > > On

Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-13 Thread Kim Phillips
e > --- this fixes a 'WARNING: at lib/kobject.c:593' on a p2020, so: Tested-by: Kim Phillips Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.

RFC: (re-)binding the VFIO platform driver to a platform device

2013-10-01 Thread Kim Phillips
is the name for the driver (-dt for device tree) which has already been pointed out as a misnomer and should probably be rewritten as 'vfio-platform': http://lists.linux-foundation.org/pipermail/iommu/2013-August/006284.html [2] >From 6fa383d3f7bb53eb5efbb324c07484191b29543d Mon Sep 17 00:

Re: RFC: (re-)binding the VFIO platform driver to a platform device

2013-10-01 Thread Kim Phillips
On Tue, 1 Oct 2013 14:15:38 -0500 Scott Wood wrote: > On Tue, 2013-10-01 at 13:38 -0500, Kim Phillips wrote: > > Hi, > > > > Santosh and I are having a problem figuring out how to enable binding > > (and re-binding) platform devices to a platform VFIO driver (see &

Re: RFC: (re-)binding the VFIO platform driver to a platform device

2013-10-01 Thread Kim Phillips
On Tue, 1 Oct 2013 14:17:16 -0500 Scott Wood wrote: > On Tue, 2013-10-01 at 14:15 -0500, Scott Wood wrote: > > On Tue, 2013-10-01 at 13:38 -0500, Kim Phillips wrote: > > > Hi, > > > > > > Santosh and I are having a problem figuring out how to enable bin

Re: RFC: (re-)binding the VFIO platform driver to a platform device

2013-10-01 Thread Kim Phillips
On Tue, 1 Oct 2013 13:00:54 -0700 Greg Kroah-Hartman wrote: > On Tue, Oct 01, 2013 at 01:38:31PM -0500, Kim Phillips wrote: > > Hi, > > > > Santosh and I are having a problem figuring out how to enable binding > > (and re-binding) platform devices to a platform VFIO d

Re: [LNG] [PATCH] mfd: twl6030: Fix endianness problem in IRQ handler

2013-10-02 Thread Kim Phillips
On Wed, 2 Oct 2013 14:08:44 +0300 Taras Kondratiuk wrote: > From: Danke Xie > > The current TWL 6030 IRQ handler assumes little endianness. > This change makes it endian-neutral. > > Signed-off-by: Danke Xie > Signed-off-by: Taras Kondratiuk > --- this patch causes a new sparse warning: m

Re: RFC: (re-)binding the VFIO platform driver to a platform device

2013-10-02 Thread Kim Phillips
r Dall [mailto:christoffer.d...@linaro.org] > > > > Sent: Wednesday, October 02, 2013 10:14 AM > > > > To: Alex Williamson > > > > Cc: Kim Phillips; gre...@linuxfoundation.org; linux- > > > > ker...@vger.kernel.org; a.mota...@virtualopensystems.com;

[PATCH] i2c: s3c2410: fix clk_disable/clk_unprepare warnings

2013-09-17 Thread Kim Phillips
m Sang Signed-off-by: Kim Phillips --- drivers/i2c/busses/i2c-s3c2410.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index 3535f3c..3747b9b 100644 --- a/drivers/i2c/busses/i2c-s3c2410.c +++ b/drivers/i2c/busses/i2c-s3

[PATCH linux-stable-3.10.y] ARM: KVM: Fix 64-bit coprocessor handling

2013-09-19 Thread Kim Phillips
Dall Signed-off-by: Kim Phillips Cc: Gleb Natapov Cc: Paolo Bonzini Cc: Russell King Cc: Jonghwan Choi Cc: kvm...@lists.cs.columbia.edu Cc: k...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: # 3.10.x --- resumbission of: https://lkml.org/lkml

Re: RFC: (re-)binding the VFIO platform driver to a platform device

2013-10-09 Thread Kim Phillips
On Wed, 9 Oct 2013 15:03:19 -0500 Scott Wood wrote: > On Wed, 2013-10-09 at 14:44 -0500, Yoder Stuart-B08248 wrote: > > > From: Wood Scott-B07421 > > > Sent: Wednesday, October 09, 2013 2:22 PM > > > > > > On Wed, 2013-10-09 at 14:02 -0500, Yoder Stuart-B08248 wrote: > > > > Have been thinking a

Re: [PATCH] powerpc/crypto: Add property for 'era' in SEC dts crypto node

2013-04-09 Thread Kim Phillips
On Tue, 9 Apr 2013 17:20:33 +0530 Vakul Garg wrote: > The crypto node now contains a new property 'fsl,sec-era'. > This is required so that applications can retrieve era info without > having to be able to read SEC's register space. > > Signed-off-by: Vakul Garg > --- > arch/powerpc/boot/dts/f

[PATCH v7] arm: use built-in byte swap function

2013-05-23 Thread Kim Phillips
8117090 7bdb62 vmlinux-imx_v6_v7 #builtin-bswap Signed-off-by: Kim Phillips Reviewed-by: Nicolas Pitre Acked-by: David Woodhouse --- resending as v6 appears to have fallen though the cracks. Russell? v7: rebased onto next-20130521, re-ran above vmlinux sizes with Linaro gcc 4.8, added

[PATCH v2 1/2] crypto: caam - change key gen functions to return signed int

2013-03-26 Thread Kim Phillips
commit 2af8f4a "crypto: caam - coccicheck fixes" added error return values yet neglected to change the type from unsigned. Signed-off-by: Kim Phillips --- v1 posted here: http://article.gmane.org/gmane.linux.kernel.cryptoapi/7664 v2: updated commit text with 'coccicheck f

[PATCH v2 2/2] v2 crypto: caam - static constify error data

2013-03-26 Thread Kim Phillips
checkstack reports report_deco_status(), report_ccb_status() as particularly excessive stack users. Move their lookup tables off the stack and put them in .rodata. Signed-off-by: Kim Phillips --- v1 posted here: http://article.gmane.org/gmane.linux.kernel.cryptoapi/7571 v2: made cha_id_list

Re: [PATCH] crypto: caam - fix typo "CRYPTO_AHASH"

2013-03-07 Thread Kim Phillips
t; drivers do. That would apparently (indirectly) select CRYPTO_HASH2, > which would enable the ahash functionality this driver uses. > > Signed-off-by: Paul Bolle > --- Reviewed-by: Kim Phillips Kim -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH v6 0/8] Raid: enable talitos xor offload for improving performance

2012-08-06 Thread Kim Phillips
according to Ira's advice; fwiw, I gave v5 a test-drive, setting up a RAID5 array on ramdisks [1], and this patchseries, along with FSL_DMA && NET_DMA set seems to be holding water, so this series gets my: Tested-by: Kim Phillips Thanks, Kim [1] mdadm --create --verbose --force /

Re: [PATCH 0/3] UCC TDM driver for MPC83xx platforms

2008-01-14 Thread Kim Phillips
On Thu, 10 Jan 2008 21:41:20 -0700 "Aggrwal Poonam" <[EMAIL PROTECTED]> wrote: > Hello All > > I am waiting for more feedback on the patches. > > If there are no objections please consider them for 2.6.25. > if this isn't going to go through Alessandro Rubini/misc drivers, can it go through th

Re: [PATCH] generic RTC support for PPC

2007-01-30 Thread Kim Phillips
On Tue, 30 Jan 2007 10:03:40 -0600 [EMAIL PROTECTED] (Olof Johansson) wrote: > On Tue, Jan 30, 2007 at 12:37:12AM -0600, Kumar Gala wrote: > > > > On Jan 29, 2007, at 11:17 PM, Tom Rini wrote: > > > > >On Thu, Jan 25, 2007 at 01:37:54AM -0600, Olof Johansson wrote: > > > > > >>Make the PPC RTC f

Re: Kconfig warnings on latest GIT

2007-05-08 Thread Kim Phillips
On Tue, 8 May 2007 00:04:14 +0300 Ismail Dönmez <[EMAIL PROTECTED]> wrote: > > drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' > refers to undefined symbol 'UCC_FAST' looks like this introduces the error: commit 7d776cb596994219584257eb5956b87628e5deaf Author: Timur

Re: [PATCH 47/61] perf c2c report: Add cacheline browser

2016-09-20 Thread Kim Phillips
On Mon, 19 Sep 2016 15:09:56 +0200 Jiri Olsa wrote: > + /* reset abort key so that it can get Ctrl-C as a key */ > + SLang_reset_tty(); > + SLang_init_tty(0, 0, 0); this fails to build on systems without slang: CC builtin-c2c.o builtin-c2c.c: In function ‘perf_c2c__browse_ca

perf tests kmod-path: don't fail if compressed modules aren't supported

2016-09-20 Thread Kim Phillips
__kmod_path__parse() uses is_supported_compression() to determine and parse out compressed module file extensions. On systems without zlib, this test fails and __kmod_path__parse() continues to strcmp "ko" with "gz". Don't do this on those systems. Signed-off-by: Kim

Re: [PATCH v7 0/6] perf annotate: Cross arch support + few fixes

2016-09-21 Thread Kim Phillips
On Wed, 21 Sep 2016 21:17:50 +0530 Ravi Bangoria wrote: > Kim, I don't have arm test machine. Can you please help me to test > this on arm. This works for me: hitting return on return instructions yields "Invalid jump offset", but I'll get that later. Thanks, Kim

Re: [PATCH 47/61] perf c2c report: Add cacheline browser

2016-09-21 Thread Kim Phillips
On Wed, 21 Sep 2016 14:55:40 +0200 Jiri Olsa wrote: > On Wed, Sep 21, 2016 at 10:21:55AM +0200, Jiri Olsa wrote: > > On Tue, Sep 20, 2016 at 03:10:07PM -0500, Kim Phillips wrote: > > > this fails to build on systems without slang: > > > > > > CC b

Re: [PATCH v7 0/6] perf annotate: Cross arch support + few fixes

2016-09-22 Thread Kim Phillips
On Thu, 22 Sep 2016 10:48:13 +0530 Ravi Bangoria wrote: > On Thursday 22 September 2016 01:04 AM, Kim Phillips wrote: > > On Wed, 21 Sep 2016 21:17:50 +0530 > > Ravi Bangoria wrote: > > > >> Kim, I don't have arm test machine. Can you please help me to test &

Re: [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC

2016-09-27 Thread Kim Phillips
On Tue, 27 Sep 2016 07:53:56 -0700 Vineet Gupta wrote: > This doesn't seem to be used anywhere I thought so too, until I got this response for an equivalent patch: https://lkml.org/lkml/2016/8/31/53 Kim

Re: [PATCH v6 2/7] perf annotate: Add cross arch annotate support

2016-08-23 Thread Kim Phillips
On Tue, 23 Aug 2016 11:17:16 +0900 Namhyung Kim wrote: > On Tue, Aug 23, 2016 at 8:01 AM, Kim Phillips wrote: > > On Fri, 19 Aug 2016 18:29:33 +0530 > > Ravi Bangoria wrote: > > > >> Changes in v6: > >> - Instead of adding only those instructions defi

Re: [PATCH 06/27] Provide supplementary error message facility [ver #5]

2017-08-17 Thread Kim Phillips
higher level of user experience improvement it can give perf users (see RFC below): Am I taking the right approach here by assuming this new error message facility is indeed eligible for upstream acceptance sometime soon? Thanks, Kim >From da34ddaf1aa8c731f645c268a1caf17029caca8c Mon Sep 17 00:00:00

[PATCH v2] perf tools: Add ARM Statistical Profiling Extensions (SPE) support

2017-08-17 Thread Kim Phillips
On Mon, 17 Jul 2017 19:48:22 -0500 Kim Phillips wrote: > On Fri, 30 Jun 2017 15:02:41 +0100 > Mark Rutland wrote: > > > Hi Kim, > > Hi Mark, > > > On Wed, Jun 28, 2017 at 08:43:10PM -0500, Kim Phillips wrote: > > > > if (evlist) { > >

[PATCH] perf/annotate: Fix branch instruction with multiple operands

2017-05-26 Thread Kim Phillips
From: Ravi Bangoria Perf annotate is dropping the cr* fields from branch instructions. Fix it by adding support to display branch instructions having multiple operands. Objdump of int_sqrt: 20.36 | c04d2694: subf r10,r10,r3 | c04d2698: v bgtcr6,c04d26a0

[PATCH] perf tools: Add missing powerpc triplet

2017-05-29 Thread Kim Phillips
On an Ubuntu xenial system, perf annotate says to install powerpc objdump on a system that already has binutils-powerpc-linux-gnu installed. Make perf aware of the missing triplet for the powerpc-linux-gnu target. Signed-off-by: Kim Phillips Cc: Ravi Bangoria --- tools/perf/arch/common.c | 1

Re: [RFC 2/3] perf tool: stat: say more about why event is not supported by the kernel

2017-10-24 Thread Kim Phillips
On Tue, 24 Oct 2017 14:35:30 +0100 Will Deacon wrote: > On Tue, Oct 24, 2017 at 03:04:08AM -0500, Kim Phillips wrote: > > +++ b/tools/perf/builtin-stat.c > > @@ -625,9 +625,13 @@ static int __run_perf_stat(int argc, const char **argv) > > if (err

Re: [RFC 3/3] perf tool: arm-ccn: add a supplemental strerror function

2017-10-24 Thread Kim Phillips
On Tue, 24 Oct 2017 14:35:19 +0100 Will Deacon wrote: > On Tue, Oct 24, 2017 at 03:04:15AM -0500, Kim Phillips wrote: > > Use the Arm CCN driver as an example of how to try to improve > > upon its existing dmesg error output, and duplicate error string > > generation l

Re: [RFC 1/3] perf tool: Introduce arch-specific supplemental perf open strerror capability

2017-10-24 Thread Kim Phillips
On Tue, 24 Oct 2017 14:35:35 +0100 Will Deacon wrote: > On Tue, Oct 24, 2017 at 03:04:04AM -0500, Kim Phillips wrote: > > Introduce new tools/perf/arch/*/util/evsel.c:perf_evsel__suppl_strerror() > > so each arch can start to customize usability for its h/w PMU drivers. > &g

Re: [RFC 1/3] perf tool: Introduce arch-specific supplemental perf open strerror capability

2017-10-24 Thread Kim Phillips
On Tue, 24 Oct 2017 12:27:44 -0200 Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 24, 2017 at 03:04:04AM -0500, Kim Phillips escreveu: > > Introduce new tools/perf/arch/*/util/evsel.c:perf_evsel__suppl_strerror() > > The naming... suppl for what? for the open operation? strerror(

Re: [RFC 1/3] perf tool: Introduce arch-specific supplemental perf open strerror capability

2017-10-25 Thread Kim Phillips
On Tue, 24 Oct 2017 20:23:00 -0500 Kim Phillips wrote: > On Tue, 24 Oct 2017 12:27:44 -0200 > Arnaldo Carvalho de Melo wrote: > > > Em Tue, Oct 24, 2017 at 03:04:04AM -0500, Kim Phillips escreveu: > > > Introduce new tools/perf/arch/*/util/evsel.c:perf_evsel__suppl_

[PATCH RESEND 1/2] tools perf: c2c: fix spelling mistakes in browser help text

2017-11-14 Thread Kim Phillips
Togle -> Toggle, lenght -> length. Signed-off-by: Kim Phillips --- tools/perf/builtin-c2c.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c index bb1ee22bd221..651782d98b5d 100644 --- a/tools/perf/builtin

[PATCH RESEND 2/2] perf tool: evsel: say which PMU Hardware event doesn't support sampling/overflow-interrupts

2017-11-14 Thread Kim Phillips
sudo ./newperf record -e armv8_pmuv3/mem_access/,ccn/cycles/,armv8_pmuv3/l2d_cache/ true Error: ccn/cycles/: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat' Signed-off-by: Kim Phillips --- tools/perf/util/evsel.c | 5 +++-- 1 file changed, 3 insertions(+),

[PATCH 1/2] tools perf: c2c: fix spelling mistakes in browser help text

2017-10-27 Thread Kim Phillips
Togle -> Toggle, lenght -> length. Signed-off-by: Kim Phillips --- tools/perf/builtin-c2c.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c index bb1ee22bd221..651782d98b5d 100644 --- a/tools/perf/builtin

[PATCH 2/2] perf tool: evsel: say which PMU Hardware event doesn't support sampling/overflow-interrupts

2017-10-27 Thread Kim Phillips
sudo ./newperf record -e armv8_pmuv3/mem_access/,ccn/cycles/,armv8_pmuv3/l2d_cache/ true Error: ccn/cycles/: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat' Signed-off-by: Kim Phillips --- tools/perf/util/evsel.c | 5 +++-- 1 file changed, 3 insertions(+),

[PATCH v3 1/2] perf tools: Add ARM Statistical Profiling Extensions (SPE) support

2017-10-27 Thread Kim Phillips
s-etm and spe can be used simultaneously, however disabled for simplicity in this release Signed-off-by: Kim Phillips --- v3: trying to address comments from v2: - despite adding a find_all_arm_spe_pmus() function to scan for all arm_spe_ device instances, in order to ensure auxtrace_record__in

[PATCH 2/2] perf tools: arm-spe: add customized strerror function

2017-10-27 Thread Kim Phillips
en idle, try without //I $ Signed-off-by: Kim Phillips --- DO NOT APPLY: This should really be an RFC, since depends on this RFC: https://www.spinics.net/lists/arm-kernel/msg613725.html but providing as part of SPE tool patch anyway in case it helps resolve the RFC. tools/perf/arc

[PATCH] perf arm64: Fix include path for asm-generic/unistd.h

2018-08-06 Thread Kim Phillips
6 ("perf arm64: Generate system call table from asm/unistd.h") Signed-off-by: Kim Phillips --- Hi, sorry for late response - was on vacation. I was able to reproduce and fix by adding this -I to the $hostcc line. Please test, and let me know if this is an acceptable fix. tools/perf/arch/ar

Re: [PATCH 2/2] perf test shell: make perf inet_pton test more portable

2018-06-20 Thread Kim Phillips
On Wed, 20 Jun 2018 10:46:22 -0300 Arnaldo Carvalho de Melo wrote: > Em Tue, Jun 19, 2018 at 06:49:52PM -0500, Kim Phillips escreveu: > > Debian based systems such as Ubuntu have dash as their default shell. > > Even if the normal or root user's shell is bash, certain scripts

Re: [PATCH 2/2] perf test shell: make perf inet_pton test more portable

2018-06-21 Thread Kim Phillips
On Thu, 21 Jun 2018 12:18:00 -0300 Arnaldo Carvalho de Melo wrote: > Would be good if we had some utility that given a two files, one with > regexps, could tell if, line by line, those expressions matched, better, > one that is present in all these OSes... I didn't find any, but given the two-fi

[PATCH v2] perf annotate: fix parsing aarch64 branch instructions after objdump update

2018-08-27 Thread Kim Phillips
Molnar Cc: Arnaldo Carvalho de Melo Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Fixes: b13bbeee5ee6 ("perf annotate: Fix branch instruction with multiple operands") Signed-off-by: Kim Phillips --- v2: address acme's comments: - consolidate into a validate_comma()

[PATCH] perf annotate: Handle arm64 move instructions

2018-08-27 Thread Kim Phillips
Thomas Richter Cc: Hendrik Brueckner Signed-off-by: Kim Phillips --- tools/perf/arch/arm64/annotate/instructions.c | 59 ++- tools/perf/arch/s390/annotate/instructions.c | 2 - 2 files changed, 58 insertions(+), 3 deletions(-) diff --git a/tools/perf/arch/arm64/annotate/in

Re: [PATCH v4 0/2]: perf: reduce data loss when profiling highly parallel CPU bound workloads

2018-08-28 Thread Kim Phillips
On Tue, 28 Aug 2018 18:44:57 +0300 Alexey Budankov wrote: > Experiment with profiling matrix multiplication code executing 128 > threads on Intel Xeon Phi (KNM) with 272 cores, like below, > demonstrates data loss metrics value of 98%: So I took these two patches for a quick test-drive on intel

Re: [PATCH v2] perf: Support for Arm A32/T32 instruction sets in CoreSight trace

2018-08-29 Thread Kim Phillips
On Wed, 29 Aug 2018 10:44:23 +0100 Robert Walker wrote: > This patch adds support for generating instruction samples from trace of > AArch32 programs using the A32 and T32 instruction sets. > > T32 has variable 2 or 4 byte instruction size, so the conversion between > addresses and instruction c

Re: [PATCH v2] perf: Support for Arm A32/T32 instruction sets in CoreSight trace

2018-08-29 Thread Kim Phillips
On Wed, 29 Aug 2018 15:34:16 +0100 Robert Walker wrote: > Hi Kim, Hi Robert, > On 29/08/18 14:49, Kim Phillips wrote: > > On Wed, 29 Aug 2018 10:44:23 +0100 > > Robert Walker wrote: > > > >> This patch adds support for generating instruction samples from tra

Re: [GIT PULL 00/44] perf/core improvements and fixes

2018-08-09 Thread Kim Phillips
On Thu, 9 Aug 2018 11:57:38 -0300 Arnaldo Carvalho de Melo wrote: Hi Arnaldo, > Arch specific: > > arm64: (Sean V Kelley) > > - Enable JSON events for Ampere Computing eMAG processor > Did this one get missed?: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1745454.html Than

[PATCH] perf tools: arm-spe: Fix uninitialized record error variable

2018-08-10 Thread Kim Phillips
s-etm does. Signed-off-by: Kim Phillips --- Hi Arnaldo, please apply to perf/urgent / stable series if at all possible. Thank you. tools/perf/arch/arm64/util/arm-spe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/util/arm-s

Re: [PATCH v3 0/7] perf: Add ioctl for PMU driver configuration

2018-08-13 Thread Kim Phillips
On Wed, 18 Jul 2018 15:48:00 -0600 Mathieu Poirier wrote: > This set adds the capability to communiate event specific configuration > to the PMU kernel driver using an ioctl(). The functionatlity is made > generic enough for anyone to use but is targeted at the identification > of CoreSight sink

Re: [PATCH v3 0/7] perf: Add ioctl for PMU driver configuration

2018-08-14 Thread Kim Phillips
On Tue, 14 Aug 2018 10:15:56 -0600 Mathieu Poirier wrote: > On Mon, 13 Aug 2018 at 11:46, Kim Phillips wrote: > > It yields success for the --per-thread case..: > > > > $ sudo taskset -c 0 ./perf record -e cs_etm/@2001.etf/ --per-thread > > uname -a >

Re: [PATCH v3 0/7] perf: Add ioctl for PMU driver configuration

2018-08-21 Thread Kim Phillips
On Tue, 21 Aug 2018 09:39:22 +0100 Suzuki K Poulose wrote: > On 08/20/2018 04:25 PM, Kim Phillips wrote: > > On Mon, 20 Aug 2018 15:36:47 +0100 > > Suzuki K Poulose wrote: > > > >> On 08/20/2018 03:22 PM, Kim Phillips wrote: > >>> On Mon, 20 Aug

Re: [PATCH v3 0/7] perf: Add ioctl for PMU driver configuration

2018-08-21 Thread Kim Phillips
On Tue, 21 Aug 2018 11:16:49 -0600 Mathieu Poirier wrote: > On Mon, 20 Aug 2018 at 08:36, Suzuki K Poulose wrote: > > > > On 08/20/2018 03:22 PM, Kim Phillips wrote: > > > On Mon, 20 Aug 2018 11:03:03 +0100 > > > Suzuki K Poulose wrote: > > > >

Re: [PATCH] Properly interpret indirect call in perf annotate.

2018-08-23 Thread Kim Phillips
7;t parse only address. > > Signed-off-by: Martin Liška > --- Tested this doesn't incur any grievances parsing aarch64 code: Tested-by: Kim Phillips Thanks, Kim

[PATCH] perf annotate: fix parsing aarch64 branch instructions after objdump update

2018-08-23 Thread Kim Phillips
Molnar Cc: Arnaldo Carvalho de Melo Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Fixes: b13bbeee5ee6 ("perf annotate: Fix branch instruction with multiple operands") Signed-off-by: Kim Phillips --- tools/perf/util/annotate.c | 17 - tools/perf/util/annotate

Re: [PATCH] perf annotate: fix parsing aarch64 branch instructions after objdump update

2018-08-24 Thread Kim Phillips
On Fri, 24 Aug 2018 09:59:22 +0200 Thomas-Mich Richter wrote: > On 08/24/2018 02:10 AM, Kim Phillips wrote: > > Tested no difference in output for sample x86_64, power arch perf.data > > files. > > Tested, no difference in output on s390. Just to let you know. Thanks!

Re: [PATCH] perf tools: Fixing uninitialised variable

2018-01-23 Thread Kim Phillips
of the for > loop. > > Signed-off-by: Mathieu Poirier > --- Cc'ing me and adding a: Fixes: ffd3d18c20b8 ("perf tools: Add ARM Statistical Profiling Extensions (SPE) support") line would also be nice. Other than those nits: Acked-by: Kim Phillips Thanks! Kim

Re: [PATCH 00/10] perf tools: Add support for CoreSight trace decoding

2018-01-10 Thread Kim Phillips
On Fri, 15 Dec 2017 09:44:49 -0700 Mathieu Poirier wrote: > This patchset adds support for per-thread CoreSight trace decoding from the > "perf report" interface. It is largely modelled on what has been done for > intelPT traces and currently targets the ETMv4 architecture. Support for > cpu-w

Re: [PATCH 00/10] perf tools: Add support for CoreSight trace decoding

2018-01-11 Thread Kim Phillips
On Thu, 11 Jan 2018 08:45:21 -0700 Mathieu Poirier wrote: > On 11 January 2018 at 05:23, Mark Brown wrote: > > On Wed, Jan 10, 2018 at 06:08:21PM -0600, Kim Phillips wrote: > >> Mathieu Poirier wrote: > > > >> > Instructions on how to build and inst

Re: [PATCH 00/10] perf tools: Add support for CoreSight trace decoding

2018-01-11 Thread Kim Phillips
On Thu, 11 Jan 2018 14:11:00 -0700 Mathieu Poirier wrote: > On 11 January 2018 at 10:28, Kim Phillips wrote: > > On Thu, 11 Jan 2018 08:45:21 -0700 > > Mathieu Poirier wrote: > > > >> On 11 January 2018 at 05:23, Mark Brown wrote: > >> > On Wed, Jan

[PATCH v5] perf tools: Add ARM Statistical Profiling Extensions (SPE) support

2018-01-12 Thread Kim Phillips
Snapshot support (record -S), and conversion to native perf events (e.g., via 'perf inject --itrace'), are also not supported - Technically both cs-etm and spe can be used simultaneously, however disabled for simplicity in this release Reviewed-by: Dongjiu Geng Acked-by: Adrian

Re: [PATCH 00/10] perf tools: Add support for CoreSight trace decoding

2018-01-16 Thread Kim Phillips
On Tue, 16 Jan 2018 12:35:26 + Mike Leach wrote: > Hi, > > On 11 January 2018 at 22:18, Mathieu Poirier > wrote: > > On 11 January 2018 at 14:49, Kim Phillips wrote: > >> On Thu, 11 Jan 2018 14:11:00 -0700 > >> Mathieu Poirier wrote: > >> &g

Re: [PATCH 00/10] perf tools: Add support for CoreSight trace decoding

2018-01-16 Thread Kim Phillips
On Tue, 16 Jan 2018 10:58:06 -0700 Mathieu Poirier wrote: > On Tue, Jan 16, 2018 at 11:01:02AM -0600, Kim Phillips wrote: > > On Tue, 16 Jan 2018 12:35:26 + > > Mike Leach wrote: > > > > > Hi, > > > > > > On 11 January 2018 at 22:18, Math

[PATCH v6] perf tools: Add ARM Statistical Profiling Extensions (SPE) support

2018-01-14 Thread Kim Phillips
Snapshot support (record -S), and conversion to native perf events (e.g., via 'perf inject --itrace'), are also not supported - Technically both cs-etm and spe can be used simultaneously, however disabled for simplicity in this release Reviewed-by: Dongjiu Geng Acked-by: Adrian

Re: [PATCH] perf tools arm64: Add libdw DWARF post unwind support for ARM64

2018-03-09 Thread Kim Phillips
On Fri, 9 Mar 2018 13:49:50 -0500 Martin Vuille wrote: > For https://patchwork.kernel.org/patch/10211483/, I'm not sure how to go > about doing a reply to all. Hit reply-all from the copy in your Sent folder. Kim

[PATCH] perf tools: Add a dso_size option to perf report --sort

2018-03-27 Thread Kim Phillips
25 0.09% 12324864 libmozjs-52.so.0.0.0 0.05% 4796416 perf 0.04%843776 libgjs.so.0.0.0 0.03% 1409024 libmutter-clutter-1.so Cc: Maxim Kuvyrkov Signed-off-by: Kim Phillips --- tools/perf/Documentation/perf-report.txt | 1 + tools/perf/util/hist.h | 1 + tools

Re: [PATCH] perf tools: Add a dso_size option to perf report --sort

2018-03-27 Thread Kim Phillips
On Tue, 27 Mar 2018 04:27:02 -0700 Andi Kleen wrote: > On Tue, Mar 27, 2018 at 06:09:56AM -0500, Kim Phillips wrote: > > Add DSO size to perf report/top sort output list. > > > > This includes adding a map__size fn to map.h, which is > > approximately equa

[PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

2018-04-11 Thread Kim Phillips
e Melo Cc: Namhyung Kim Cc: Jiri Olsa Cc: Ingo Molnar Cc: David Ahern Cc: Alexander Shishkin Cc: Peter Zijlstra Cc: Fixes: 1d12cec6ce99 ("perf machine: Fix paranoid check in machine__set_kernel_mmap()") Signed-off-by: Kim Phillips --- It's not clear to me what the specific intent o

Re: [PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

2018-04-12 Thread Kim Phillips
On Thu, 12 Apr 2018 10:57:56 +0900 Namhyung Kim wrote: > On Wed, Apr 11, 2018 at 07:29:40PM -0500, Kim Phillips wrote: > > On Thu, 12 Apr 2018 08:31:09 +0900 > > Namhyung Kim wrote: > > > On Wed, Apr 11, 2018 at 06:07:52PM -0500, Kim Phillips wrote: > > > > -

Re: [PATCH RESEND] perf unwind: Report error from dwfl_attach_state

2018-03-19 Thread Kim Phillips
ailure, log the reported error. > > Signed-off-by: Martin Vuille > --- Reviewed-by: Kim Phillips Kim

[PATCH] perf tests: run dwarf unwind test on arm32

2018-04-10 Thread Kim Phillips
Enable the unwind test on arm32: $ ./perf test unwind 58: DWARF unwind : Ok Signed-off-by: Kim Phillips --- tools/perf/arch/arm/include/arch-tests.h | 12 tools/perf/arch/arm/tests/Build | 2 ++ tools/perf/arch/arm/tests/arch

[PATCH] perf tools arm64: Add libdw DWARF post unwind support for ARM64

2018-03-08 Thread Kim Phillips
nwind : Ok Reported-by: Christian Hansen Originally-by: Jean Pihet Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: linux-kernel@vger.kernel.org Cc: linux-perf-us...@vger.kernel.org Signed-off-by

Re: [PATCH] perf tools arm64: Add libdw DWARF post unwind support for ARM64

2018-03-09 Thread Kim Phillips
On Fri, 9 Mar 2018 12:06:27 -0300 Arnaldo Carvalho de Melo wrote: Hi Arnaldo, > Em Thu, Mar 08, 2018 at 09:10:30PM -0600, Kim Phillips escreveu: > > Based on prior work: > > > > https://lkml.org/lkml/2014/5/6/395 > > Thanks, looks good, applying. > > Jean,

Re: [PATCH 2/2] perf test shell: make perf inet_pton test more portable

2018-06-29 Thread Kim Phillips
On Fri, 29 Jun 2018 12:21:55 -0300 Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 21, 2018 at 03:32:50PM -0500, Kim Phillips escreveu: > > On Thu, 21 Jun 2018 12:18:00 -0300 > > Arnaldo Carvalho de Melo wrote: > > > > > Would be good if we had some utility th

Re: [PATCH 2/2] perf test shell: make perf inet_pton test more portable

2018-06-29 Thread Kim Phillips
On Thu, 28 Jun 2018 22:36:36 +0200 Michael Petlan wrote: > On Thu, 21 Jun 2018, Arnaldo Carvalho de Melo wrote: > > Em Thu, Jun 21, 2018 at 11:19:15AM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Wed, Jun 20, 2018 at 07:45:46PM -0500, Kim Phillips escreveu: > >>

[PATCH v2 1/4] perf test shell: Replace '|&' with '2>&1 |' to work with more shells

2018-06-29 Thread Kim Phillips
valho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: Thomas Richter Cc: Michael Petlan Signed-off-by: Kim Phillips --- v2: indent terminal session logs with a space to avoid git-am parsing '--- start ---' as the end of the des

[PATCH v2 2/4] perf test shell: make perf inet_pton test more portable

2018-06-29 Thread Kim Phillips
: Ingo Molnar Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: Thomas Richter Cc: Michael Petlan Cc: "Hendrik Brückner" Cc: Sandipan Das Signed-off-by: Kim Phillips --- V2: rewritten with a cleaner, POSIX compliant two-file approach instead of using arrays (bashism). Note

[PATCH v2 3/4] perf llvm-utils: remove bashism from kernel include fetch script

2018-06-29 Thread Kim Phillips
portable non-zero failure status code 1. Signed-off-by: Kim Phillips --- v2: new for this remove bashisms series tools/perf/util/llvm-utils.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/llvm-utils.c b/tools/perf/util/llvm-utils.c index 976e658e38dc

[PATCH v2 4/4] perf test shell: prevent temporary editor files from being considered test scripts

2018-06-29 Thread Kim Phillips
--- sh: 1: ./tests/shell/.record+probe_libc_inet_pton.sh.swp: Permission denied end 0VIM 8.0: FAILED! Signed-off-by: Kim Phillips --- v2: new this series tools/perf/tests/builtin-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/tests/builtin-test.c b

Re: [PATCH 1/6] coresight: remove CORESIGHT_LINKS_AND_SINKS dependencies and selections

2018-05-24 Thread Kim Phillips
On Thu, 24 May 2018 09:32:48 -0600 Mathieu Poirier wrote: > On 23 May 2018 at 13:51, Kim Phillips wrote: > > On Tue, 22 May 2018 11:31:40 -0600 > > Mathieu Poirier wrote: > > > >> On Thu, May 17, 2018 at 08:20:19PM -0500, Kim Phillips wrote: > >> > A

Re: [PATCH 6/6] coresight: allow to build as modules

2018-05-24 Thread Kim Phillips
On Tue, 22 May 2018 15:39:06 -0600 Mathieu Poirier wrote: > On Thu, May 17, 2018 at 08:20:24PM -0500, Kim Phillips wrote: > > Allow to build coresight as modules. This greatly enhances developer > > efficiency by allowing the development to take place exclusively on the > >

  1   2   3   4   5   >