and passed to zswap (in zbud_alloc()),
- user-supplied eviction callback is called (in zbud_reclaim_page()).
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com
---
mm/zbud.c | 150
Move out the code for unusing swap entries from loop in try_to_unuse()
to separate function: try_to_unuse_swp_entry(). Export this new function
in swapfile.h just like try_to_unuse() is exported.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
include/linux/swapfile.h |2 +
mm
with other solution.
Best regards,
Krzysztof Kozlowski
Krzysztof Kozlowski (4):
zbud: use page ref counter for zbud pages
mm: split code for unusing swap entries from try_to_unuse
mm: add zbud flag to page flags
mm: reclaim zbud pages on migration and compaction
include/linux/page
Add PageZbud flag to page flags to distinguish pages allocated in zbud.
Currently these pages do not have any flags set.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
include/linux/page-flags.h | 12
mm/page_alloc.c|3 +++
mm/zbud.c
tries to write them back.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
include/linux/zbud.h | 11 +++-
mm/compaction.c | 20 ++-
mm/internal.h|1 +
mm/page_alloc.c |6 ++
mm/zbud.c| 163
Hi Bob,
Thank you for review.
On wto, 2013-08-06 at 17:00 +0800, Bob Liu wrote:
Nit picker, how about change the name to adjust_lists() or something
like this because we don't do any rebalancing.
OK, I'll change it.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line
On wto, 2013-08-06 at 17:16 +0800, Bob Liu wrote:
On 08/06/2013 02:42 PM, Krzysztof Kozlowski wrote:
This reclaim process is different than zbud_reclaim_page(). It acts more
like swapoff() by trying to unuse pages stored in zbud page and bring
them back to memory. The standard
-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
arch/arm/mach-msm/gpiomux.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-msm/gpiomux.c b/arch/arm/mach-msm/gpiomux.c
index 2b8e2d2..4110b82 100644
--- a/arch/arm/mach-msm/gpiomux.c
+++ b/arch/arm/mach-msm
On wto, 2013-08-06 at 09:58 -0700, Dave Hansen wrote:
On 08/05/2013 11:42 PM, Krzysztof Kozlowski wrote:
+#ifdef CONFIG_ZBUD
+ /* Allocated by zbud. Flag is necessary to find zbud pages to unuse
+* during migration/compaction.
+*/
+ PG_zbud,
+#endif
Do you _really_ need
Hi Seth,
On wto, 2013-08-06 at 13:51 -0500, Seth Jennings wrote:
I like the idea. I few things below. Also agree with Bob the
s/rebalance/adjust/ for rebalance_lists().
OK.
s/else if/if/ since the if above returns if true.
Sure.
+ /* zbud_free() or zbud_alloc() */
+
Hi Minchan,
On wto, 2013-08-13 at 16:04 +0900, Minchan Kim wrote:
patch 2 introduce pinpage control
subsystem. So, subsystems want to control pinpage should implement own
pinpage_xxx functions because each subsystem would have other character
so what kinds of data structure for managing
Hi,
On pon, 2013-09-09 at 14:47 -0500, Seth Jennings wrote:
On Fri, Aug 30, 2013 at 10:42:53AM +0200, Krzysztof Kozlowski wrote:
Use page reference counter for zbud pages. The ref counter replaces
zbud_header.under_reclaim flag and ensures that zbud page won't be freed
when zbud_free
Currently zbud pages do not have any flags set so it is not possible to
identify them during migration or compaction.
Implement PageZbud() by comparing page-_mapcount to -127 to distinguish
pages allocated by zbud. Just like PageBuddy() is implemented.
Signed-off-by: Krzysztof Kozlowski k.kozlow
Move freechunks variable in zbud_free() and zbud_alloc() to block-level
scope (from function scope).
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
mm/zbud.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/mm/zbud.c b/mm/zbud.c
index 3f4be72..1d5b26b
().
Best regards,
Krzysztof Kozlowski
Krzysztof Kozlowski (5):
zbud: use page ref counter for zbud pages
zbud: make freechunks a block local variable
mm: use mapcount for identifying zbud pages
mm: use indirect zbud handle and radix tree
mm: migrate zbud pages
include/linux/mm.h | 23
to address this problem by
protecting handles from freeing.
Also the call to zbud_unmap() in zswap_writeback_entry() was moved
further - when the tree's lock could be obtained.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
include/linux/zbud.h |2 +-
mm/zbud.c| 313
and passed to zswap (in zbud_alloc()),
- user-supplied eviction callback is called (in zbud_reclaim_page()).
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com
Reviewed-by: Bob Liu bob@oracle.com
---
mm/zbud.c | 117
be replaced for example with pin page control
subsystem:
http://article.gmane.org/gmane.linux.kernel.mm/105308
In such case the zbud migration code (zbud_migrate_page()) can be safely
re-used.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
include/linux/zbud.h |1 +
mm/compaction.c
,
- max77693_update_reg() reorder val and mask.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/extcon/extcon-max77693.c | 14 +++---
drivers/mfd/max77693-irq.c |2 +-
drivers/mfd/max77693.c
,
- sec_reg_update() reorder val and mask.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mfd/sec-core.c |6 +++---
drivers/regulator/s5m8767.c | 26 +-
include/linux/mfd/samsung/core.h
On śro, 2013-10-02 at 17:51 -0700, John Stultz wrote:
+static void try_to_discard_one(struct vrange_root *vroot, struct page *page,
+ struct vm_area_struct *vma, unsigned long addr)
+{
+ struct mm_struct *mm = vma-vm_mm;
+ pte_t *pte;
+ pte_t pteval;
On wto, 2013-10-01 at 16:04 -0500, Seth Jennings wrote:
Yes, it is very similar. I'm beginning to like aspects of this patch
more as I explore this issue more.
At first, I balked at the idea of yet another abstraction layer, but it
is very hard to avoid unless you want to completely
pm_runtime_put() wasn't called if clock rate could not be set up in
s3c64xx_spi_setup() leading to invalid count of device pm_runtime usage.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
drivers/spi/spi-s3c64xx.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi
Mark device as PM runtime active during initialization to reflect
actual device power/clocks state. This reduces the enable count for SPI
bus controller gate clock so it can be disabled when the bus controller
is not used.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off
sleep for the time of s3c64xx_spi_hwinit().
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/spi/spi-s3c64xx.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c
On Mon, 2013-10-21 at 11:42 +0200, Sylwester Nawrocki wrote:
pm_runtime_{get,put}* must not be called from drivers's system suspend/resume
callbacks. Please use pm_runtime_suspended() to check device runtime PM status
in s3c64xx_spi_{suspend,resume} callbacks and handle the clocks
During PM resume and suspend do not ignore the return value of
spi_master_suspend() or spi_master_resume(). Instead pass it further.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/spi/spi-s3c64xx.c |8
1
is not suspended.
During resume do not enable the clocks if device is runtime suspended.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/spi/spi-s3c64xx.c | 14 --
1 file changed, 8 insertions(+), 6 deletions
,
Krzysztof Kozlowski
Chanwoo Choi (2):
mfd: max14577: Add max14577 MFD driver core
extcon: max14577: Add extcon-max14577 driver to support MUIC device
Krzysztof Kozlowski (3):
charger: max14577: Add charger support for Maxim 14577
regulator: max14577: Add regulator driver for Maxim 14577
mfd
enabled or disabled.
2. Current regulator for the charger. It provides current from 90mA up
to 950mA.
Driver supports Device Tree.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/regulator/Kconfig|7 ++
drivers
Add document describing device tree bindings for MAX14577 MFD driver.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
Documentation/devicetree/bindings/mfd/max14577.txt | 48
1 file changed, 48
1.1. It has also SFOUT LDO output for powering USB devices.
Signed-off-by: Chanwoo Choi cw00.c...@samsung.com
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mfd/Kconfig | 13 ++
drivers/mfd/Makefile
MAX14577 chip is a multi-function device which includes MUIC, charger
and voltage regulator. The driver is located in drivers/mfd.
This patch supports battery charging control of MAX14577 chip and
provides power supply class information to userspace.
Signed-off-by: Krzysztof Kozlowski k.kozlow
Choi cw00.c...@samsung.com
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/extcon/Kconfig | 10 +
drivers/extcon/Makefile |1 +
drivers/extcon/extcon-max14577.c | 749
On Fri, 2013-11-22 at 09:16 +, Lee Jones wrote:
(...)
On Fri, 22 Nov 2013, Krzysztof Kozlowski wrote:
--- a/include/linux/mfd/max14577.h
+++ b/include/linux/mfd/max14577.h
@@ -63,7 +63,6 @@ struct max14577_platform_data {
int (*set_gpio_pogo_cb) (int new_dev);
- int
information to userspace.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
...
diff --git a/drivers/power/max14577_charger.c
b/drivers/power/max14577_charger.c
...
+static struct platform_driver max14577_charger_driver
On Fri, 2013-11-22 at 09:31 +, Lee Jones wrote:
(...)
+static struct mfd_cell max14577_devs[] = {
+ { .name = max14577-muic, },
+ { .name = max14577-regulator, },
+ { .name = max14577-charger, },
+};
If these all support device tree, shouldn't you be populating
On Fri, 2013-11-22 at 10:35 +, Mark Brown wrote:
On Fri, Nov 22, 2013 at 09:46:09AM +0100, Krzysztof Kozlowski wrote:
+#defineDELAY_MS_DEFAULT17000 /* unit:
millisecond */
This delay is sufficiently large that the delayed work using it probably
ought
Add document describing device tree bindings for MAX14577 MFD driver.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
Documentation/devicetree/bindings/mfd/max14577.txt | 48
1 file changed, 48
of_get_child_by_name() for accessing regulators bindings.
7. Added documentation of bindings (fifth patch).
Best regards,
Krzysztof Kozlowski
Chanwoo Choi (2):
mfd: max14577: Add max14577 MFD driver core
extcon: max14577: Add extcon-max14577 driver to support MUIC device
Krzysztof Kozlowski
MAX14577 chip is a multi-function device which includes MUIC, charger
and voltage regulator. The driver is located in drivers/mfd.
This patch supports battery charging control of MAX14577 chip and
provides power supply class information to userspace.
Signed-off-by: Krzysztof Kozlowski k.kozlow
Choi cw00.c...@samsung.com
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/extcon/Kconfig | 10 +
drivers/extcon/Makefile |1 +
drivers/extcon/extcon-max14577.c | 752
enabled or disabled.
2. Current regulator for the charger. It provides current from 90mA up
to 950mA.
Driver supports Device Tree.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mfd/max14577.c |3 +-
drivers
1.1. It has also SFOUT LDO output for powering USB devices.
Signed-off-by: Chanwoo Choi cw00.c...@samsung.com
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Reviewed-by: Mark Brown broo...@linaro.org
---
drivers/mfd/Kconfig
On Fri, 2013-11-22 at 10:15 +, Lee Jones wrote:
+#ifdef CONFIG_OF
+static int max14577_regulator_dt_parse_pdata(struct platform_device *pdev,
+ struct max14577_platform_data *pdata)
+{
+ struct max14577 *max14577 = dev_get_drvdata(pdev-dev.parent);
...
Please test. Thanks!
drivers/rtc/rtc-s5m.c | 54 -
1 file changed, 27 insertions(+), 27 deletions(-)
Seems good, tested on device with S5M8767.
Tested-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Best regards,
Krzysztof
--
To unsubscribe
On 11/26/2013 10:17 AM, Krzysztof Kozlowski wrote:
On 11/15/2013 12:54 PM, Geert Uytterhoeven wrote:
drivers/rtc/rtc-s5m.c: In function ‘s5m_rtc_probe’:
drivers/rtc/rtc-s5m.c:545: warning: assignment from incompatible
pointer type
struct s5m_rtc_info.rtc has type struct regmap *, while
struct
/gmane.linux.kernel/1595905
Best regards,
Krzysztof
Krzysztof Kozlowski (5):
rtc: s5m: Fix register updating by adding regmap for RTC
rtc: s5m: Fix unsuccesful IRQ request during probe
rtc: s5m: Limit endless loop waiting for register update
mfd: sec: Add PM ops and make it a wake up source
Probe failed for rtc-s5m:
s5m-rtc s5m-rtc: Failed to request alarm IRQ: 12: -22
s5m-rtc: probe of s5m-rtc failed with error -22
Fix rtc-s5m interrupt request by using regmap_irq_get_virq() for mapping
the IRQ.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off
Add PM suspend/resume ops to rtc-s5m driver and enable IRQ wake during
suspend so the RTC would act like a wake up source. This allows waking
up from suspend to RAM on RTC alarm interrupt.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
is still suspended) and RTC Alarm interrupt is disabled.
Disable the S5M8767 interrupts during suspend (disable_irq()) and enable
them during resume so the device will be still woken up but the interrupt
won't happen before resuming I2C bus.
Signed-off-by: Krzysztof Kozlowski k.kozlow
.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mfd/sec-core.c | 14 ++
drivers/rtc/rtc-s5m.c|2 +-
include/linux/mfd/samsung/core.h |1 +
3 files changed, 16 insertions(+), 1
After setting alarm or time the driver is waiting for UDR register to be
cleared indicating that registers data have been transferred.
Limit the endless loop to only 5 retries.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
On Tue, 2013-11-26 at 15:07 +0100, Geert Uytterhoeven wrote:
On Tue, Nov 26, 2013 at 2:50 PM, Krzysztof Kozlowski
k.kozlow...@samsung.com wrote:
On S5M8767A registers were not properly updated and read due to usage of
the same regmap as the PMIC. This could be observed in various hangs
Add document describing device tree bindings for MAX14577 MFD driver.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
Documentation/devicetree/bindings/mfd/max14577.txt | 48
1 file changed, 48
enabled or disabled.
2. Current regulator for the charger. It provides current from 90mA up
to 950mA.
Driver supports Device Tree.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mfd/max14577.c | 13 +-
drivers
Match max14577 regulator driver by of_compatible specified in mfd_cell.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
drivers/mfd/max14577.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
index 94b766d
patchset
as this was applied by Lee Jones.
Best regards,
Krzysztof Kozlowski
Krzysztof Kozlowski (5):
mfd/rtc: s5m: Fix register updating by adding regmap for RTC
rtc: s5m: Fix unsuccesful IRQ request during probe
rtc: s5m: Limit endless loop waiting for register update
rtc: s5m: Enable
Add const to static struct regmap_irq and static struct
regmap_config.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
drivers/mfd/sec-core.c |8
drivers/mfd/sec-irq.c | 12 ++--
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/mfd
Probe failed for rtc-s5m:
s5m-rtc s5m-rtc: Failed to request alarm IRQ: 12: -22
s5m-rtc: probe of s5m-rtc failed with error -22
Fix rtc-s5m interrupt request by using regmap_irq_get_virq() for mapping
the IRQ.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off
Add PM suspend/resume ops to rtc-s5m driver and enable IRQ wake during
suspend so the RTC would act like a wake up source. This allows waking
up from suspend to RAM on RTC alarm interrupt.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
.
On this chip family the RTC has different I2C address than PMIC so
additional regmap is needed.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mfd/sec-core.c | 30 ++
drivers/mfd/sec
After setting alarm or time the driver is waiting for UDR register to be
cleared indicating that registers data have been transferred.
Limit the endless loop to only 5 retries.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Hi Mark,
On Wed, 2013-11-27 at 16:28 +, Mark Brown wrote:
On Wed, Nov 27, 2013 at 04:13:23PM +, Lee Jones wrote:
On Wed, 27 Nov 2013, Mark Brown wrote:
The usual thing to do is of_get_child_by_name() on the parent to get the
container to search in.
What do you mean when you
On Fri, 2013-10-11 at 12:02 -0700, Andrew Morton wrote:
(cc Hugh)
On Fri, 11 Oct 2013 11:54:22 +0200 Krzysztof Kozlowski
k.kozlow...@samsung.com wrote:
Swapoff used old_block_size from swap_info which could be overwritten by
concurrent swapon.
Reported-by: Weijie Yang weijie.yang
On Fri, 2013-10-11 at 11:55 -0700, Andrew Morton wrote:
On Fri, 11 Oct 2013 11:54:22 +0200 Krzysztof Kozlowski
k.kozlow...@samsung.com wrote:
Swapoff used old_block_size from swap_info which could be overwritten by
concurrent swapon.
Better changelogs, please. What were the user
. It reduces the possibility of races as the swapon
must overwrite p-old_block_size before acquiring swapon_mutex in
swapoff.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
mm/swapfile.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/mm
On Tue, 2013-10-15 at 02:59 -0700, Hugh Dickins wrote:
On Mon, 14 Oct 2013, Krzysztof Kozlowski wrote:
Fix race between swapoff and swapon resulting in setting blocksize of
PAGE_SIZE for block devices during swapoff.
The swapon modifies swap_info-old_block_size before acquiring
with reordered buf and count
parameters so it depends on:
mfd: sec: reorder params in API for regmap consistency
http://www.spinics.net/lists/kernel/msg1632519.html
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers
driver for SFOUT and charger.
The patchset is rebased on latest Linus' tree (v3.12-4849-g10d0c97) however
testing was mostly done on 3.10. Except minor change in extcon_dev_register()
function the patchset cleanly applies to 3.10 and 3.12.
Best regards,
Krzysztof Kozlowski
Chanwoo Choi (2
1.1. It has also SFOUT LDO output for powering USB devices.
Signed-off-by: Chanwoo Choi cw00.c...@samsung.com
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/mfd/Kconfig | 13 ++
drivers/mfd/Makefile
Choi cw00.c...@samsung.com
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/extcon/Kconfig | 10 +
drivers/extcon/Makefile |1 +
drivers/extcon/extcon-max14577.c | 806
MAX14577 chip is a multi-function device which includes MUIC, charger
and voltage regulator. The driver is located in drivers/mfd.
This patch supports battery charging control of MAX14577 chip and
provides power supply class information to userspace.
Signed-off-by: Krzysztof Kozlowski k.kozlow
enabled or disabled.
2. Current regulator for the charger. It provides current from 90mA up
to 950mA.
Driver supports Device Tree.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/regulator/Kconfig|7 +
drivers
Hi,
On Wed, 2013-11-13 at 13:13 +, Mark Brown wrote:
On Wed, Nov 13, 2013 at 08:40:54AM +0100, Krzysztof Kozlowski wrote:
+/**
+ * After resuming from suspend it may happen that IRQ is signalled but
+ * IRQ GPIO is not high. Also the interrupt registers won't have any data
+ * (all
Hi,
On Wed, 2013-11-13 at 11:50 +, Mark Rutland wrote:
I see some of_* calls in the code, but no documentation of the binding.
As this has more than just a compatible, interrupts, and reg, it needs
its own binding document.
[...]
+static struct mfd_cell max14577_devs[] = {
+
On Wed, 2013-11-13 at 13:23 +, Mark Brown wrote:
On Wed, Nov 13, 2013 at 08:40:57AM +0100, Krzysztof Kozlowski wrote:
+static inline int max14577_reg_set_safeout(struct regmap *rmap, int on)
+{
+ u8 reg_data = (on ? 0x1 CTRL2_SFOUTORD_SHIFT : 0x0);
The ternery operator is rarely
() for accessing regulators bindings.
7. Added documentation of bindings (fifth patch).
Best regards,
Krzysztof Kozlowski
Chanwoo Choi (2):
mfd: max14577: Add max14577 MFD driver core
extcon: max14577: Add extcon-max14577 driver to support MUIC device
Krzysztof Kozlowski (3):
charger: max14577
Choi cw00.c...@samsung.com
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/extcon/Kconfig | 10 +
drivers/extcon/Makefile |1 +
drivers/extcon/extcon-max14577.c | 806
enabled or disabled.
2. Current regulator for the charger. It provides current from 90mA up
to 950mA.
Driver supports Device Tree.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/regulator/Kconfig|7 ++
drivers
MAX14577 chip is a multi-function device which includes MUIC, charger
and voltage regulator. The driver is located in drivers/mfd.
This patch supports battery charging control of MAX14577 chip and
provides power supply class information to userspace.
Signed-off-by: Krzysztof Kozlowski k.kozlow
On Wed, 2013-11-20 at 15:31 +, Mark Brown wrote:
On Wed, Nov 20, 2013 at 03:12:08PM +0100, Krzysztof Kozlowski wrote:
+static irqreturn_t max14577_irq_thread(int irq, void *data)
+{
+ struct max14577 *max14577 = data;
+ u8 irq_reg[MAX14577_IRQ_REGS_NUM] = {0};
+ u8
On Mon, 2013-12-02 at 15:10 -0800, Andrew Morton wrote:
On Thu, 28 Nov 2013 09:09:38 +0100 Krzysztof Kozlowski
k.kozlow...@samsung.com wrote:
This is a second version of patchset of small but important fixes for
rtc-s5m
driver. Last patches also add waking up on RTC alarm interrupts
authors.
6. Use of_get_child_by_name() for accessing regulators bindings.
7. Added documentation of bindings (fifth patch).
Best regards,
Krzysztof Kozlowski
Krzysztof Kozlowski (3):
charger: max14577: Add charger support for Maxim 14577
regulator: max14577: Add regulator driver for Maxim 14577
MAX14577 chip is a multi-function device which includes MUIC, charger
and voltage regulator. The driver is located in drivers/mfd.
This patch supports battery charging control of MAX14577 chip and
provides power supply class information to userspace.
Signed-off-by: Krzysztof Kozlowski k.kozlow
Add document describing device tree bindings for MAX14577 MFD driver.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
Documentation/devicetree/bindings/mfd/max14577.txt | 48
1 file changed, 48
enabled or disabled.
2. Current regulator for the charger. It provides current from 90mA up
to 950mA.
Driver supports Device Tree.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/regulator/Kconfig|7 ++
drivers
On Wed, 2013-12-04 at 19:50 +0900, Chanwoo Choi wrote:
Hi Krzysztof,
On 12/04/2013 07:40 PM, Krzysztof Kozlowski wrote:
Add document describing device tree bindings for MAX14577 MFD driver.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park
On Wed, 2013-12-04 at 20:01 +0900, Chanwoo Choi wrote:
On 12/04/2013 07:56 PM, Krzysztof Kozlowski wrote:
On Wed, 2013-12-04 at 19:50 +0900, Chanwoo Choi wrote:
(...)
I prefer to add dt data about max14577-muic on following:
If extcon consumer driver need to use muic device, dts should
On Wed, 2013-12-04 at 11:20 +, Lee Jones wrote:
Add document describing device tree bindings for MAX14577 MFD driver.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
Documentation/devicetree/bindings/mfd
MAX14577 chip is a multi-function device which includes MUIC, charger
and voltage regulator. The driver is located in drivers/mfd.
This patch supports battery charging control of MAX14577 chip and
provides power supply class information to userspace.
Signed-off-by: Krzysztof Kozlowski k.kozlow
enabled or disabled.
2. Current regulator for the charger. It provides current from 90mA up
to 950mA.
Driver supports Device Tree.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/regulator/Kconfig|7 ++
drivers
resume. This lead to removal of the weird
IRQ/GPIO code discussed during review.
5. Minor fixes pointed by checkpatch, added authors.
6. Use of_get_child_by_name() for accessing regulators bindings.
7. Added documentation of bindings (fifth patch).
Best regards,
Krzysztof Kozlowski
Krzysztof
Add document describing device tree bindings for MAX14577 MFD driver.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
Documentation/devicetree/bindings/mfd/max14577.txt | 65
1 file changed, 65
On Wed, 2014-03-12 at 14:37 +0100, Robert Baldyga wrote:
This patch moves code creating new i2c clients and regmaps to function
drivers which use them. It allows to avoid creating this instances when
individual function drivers are not enabled.
Signed-off-by: Robert Baldyga
memory
(because regmap_add_irq_chip() will free it on error);
This results in invalid memory access during driver remove because the
tps65910_irq_exit() tests whether 'tps65910-chip_irq' is not null.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Cc: sta...@vger.kernel.org
Fixes
The tps65910_i2c_probe() allocates regmap_irq_chip in
tps65910_irq_init() but it does not clean this up in case of
mfd_add_devices() failure.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
drivers/mfd/tps65910.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd
but the 'data' variable was not changed.
This could lead to errors if the caller passed such 'data' to
regmap_del_irq_chip().
The 'data' pointer should be changed atomically from the caller
perspective - set it only on regmap_add_irq_chip() success.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Krzysztof Kozlowski (3):
clk: s2mps11: Add support for S2MPS14 clocks
mfd: sec-core: Add of_compatible strings for MFD cells
Documentation: mfd: s2mps11: Describe S5M8767 and S2MPS14 clocks
Documentation/devicetree/bindings/mfd/s2mps11.txt | 24 +---
drivers/clk/Kconfig
Add bindings documentation for clocks on S5M8767 and S2MPS14 devices.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Cc: Tomasz Figa t.f...@samsung.com
Cc: devicet...@vger.kernel.org
Cc: Rob Herring robh...@kernel.org
Cc: Pawel Moll pawel.m...@arm.com
Cc: Mark Rutland mark.rutl
1 - 100 of 16169 matches
Mail list logo
